Re: [Geotools-devel] JMapPane improvements

2009-03-02 Thread Michael Bedward
Hi Jody, Thanks for catching the Envelope usage - much better. Yep - I was unsure about class names. On the one hand they are inconveniently long. On the other that means they get grouped together in the javadocs when you're using the 'All classes' listing (as I generally do). I don't feel str

Re: [Geotools-devel] JMapPane improvements

2009-03-02 Thread Jody Garnett
Thanks Michael; the Hudson build is still down until it does a fresh checkout (since it cannot checkout over top of its old demo/mappane-uses folder). I hope someone does not need to go into that server and fix it? Is there an svn update flag that will remove folders? I did a couple quick reviews a

[Geotools-devel] Build failed in Hudson: geotools-trunk #1429

2009-03-02 Thread Hudson
See http://hudson.opengeo.org/hudson/job/geotools-trunk/1429/changes -- started Updating http://svn.osgeo.org/geotools/trunk ERROR: Failed to update http://svn.osgeo.org/geotools/trunk org.tmatesoft.svn.core.SVNException: svn: Failed to add directory 'demo/

Re: [Geotools-devel] GeoApi change breaks the build?

2009-03-02 Thread Justin Deoliveira
> > I am not blocked, just trying to improve the code base. The change I > advocate will need a proposal because it will break everything that uses > a ComplexType, gets its value, and expects a Collection of Property. And what exactly is that? As far as I know the community schema stuff you a

Re: [Geotools-devel] JMapPane improvements

2009-03-02 Thread Michael Bedward
ok - I resurrected the mappane-use demo. Ian's MapViewer class just needed a few import / class name changes and it now builds ok. The intro demo builds now too. Meanwhile labelling of features (e.g. with countries.shp in the mappane-use/data dir) will not work properly right now. I've strippe

Re: [Geotools-devel] Namespace support

2009-03-02 Thread Jody Garnett
It is more that iterator order is not defined unless you are a list. So while we could use Set (presumably to indicate that we are not going to have duplicate names) it would fail to capture the idea of an order. SortedSet would capture the idea of an order (but is otherwise crazy since the various

[Geotools-devel] [jira] Created: (GEOT-2364) Build broken on Windows: unit test failure in imagemosaic-jdbc

2009-03-02 Thread Ben Caradoc-Davies (JIRA)
Build broken on Windows: unit test failure in imagemosaic-jdbc -- Key: GEOT-2364 URL: http://jira.codehaus.org/browse/GEOT-2364 Project: GeoTools Issue Type: Bug Component

Re: [Geotools-devel] Namespace support

2009-03-02 Thread Ben Caradoc-Davies
Andrea Aime wrote: > Set getProperties gives up namespace support, [...] > List would give the best of both worlds it seems? These are all interfaces. I thought iteration order was specified by the implementation? Collection is iterable and allows implementers to choose. See, for example, the us

Re: [Geotools-devel] Namespace support

2009-03-02 Thread Ben Caradoc-Davies
Andrea Aime wrote: > jgarnett++ I think you mean ++jgarnett, because you want to increment before use. :-) -- Ben Caradoc-Davies Software Engineer, CSIRO Exploration and Mining Australian Resources Research Centre 26 Dick Perry Ave, Kensington WA 6151, Australia --

Re: [Geotools-devel] ComplexTypeImpl

2009-03-02 Thread Ben Caradoc-Davies
Jody Garnett wrote: > On a related note Ben; when thinking about the SimpleFeature interface please > understand that it does not meet the needs of GML SimpleFeature profile (it > has reduced scope and is really focused on meeting the basic/shapefile idea > of a Feature). I am well aware of thi

Re: [Geotools-devel] ComplexTypeImpl

2009-03-02 Thread Ben Caradoc-Davies
Rob Atkinson wrote: > (warning - rhetorical question) Why do we want a SimpleFeature at all? In my view, simple feature types exist to support the easy construction of types from unstructured data such as database views and shapefiles. They allow, at runtime, decisions such as: can this type be

Re: [Geotools-devel] GeoApi change breaks the build?

2009-03-02 Thread Ben Caradoc-Davies
Justin Deoliveira wrote: > Jody Garnett wrote: >> What bothers me more is how changes to geoapi have been handled >> recently. In some cases ( like Ben's proposed changes ) it seems a >> formal proposal is needed. >> >> >> I missed this conversation about Ben's proposed changes; what ar

Re: [Geotools-devel] GeoApi change breaks the build?

2009-03-02 Thread Jody Garnett
Justin Deoliveira wrote: >> I missed this conversation about Ben's proposed changes; what are >> they? I was not signed up to the mailing list for a bit - in general >> Ben has my full support since he is deep in the depths of >> implementation now and I want to know what is holding him up as so

Re: [Geotools-devel] GeoApi change breaks the build?

2009-03-02 Thread Justin Deoliveira
Jody Garnett wrote: > What bothers me more is how changes to geoapi have been handled > recently. In some cases ( like Ben's proposed changes ) it seems a > formal proposal is needed. > > > I missed this conversation about Ben's proposed changes; what are they? > I was not signed up

[Geotools-devel] Hudson build is back to normal: geotools-trunk #1427

2009-03-02 Thread Hudson
See http://hudson.opengeo.org/hudson/job/geotools-trunk/1427/changes -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enter

Re: [Geotools-devel] GeoApi change breaks the build?

2009-03-02 Thread Jody Garnett
> > What bothers me more is how changes to geoapi have been handled > recently. In some cases ( like Ben's proposed changes ) it seems a > formal proposal is needed. I missed this conversation about Ben's proposed changes; what are they? I was not signed up to the mailing list for a bit - in gene

Re: [Geotools-devel] Handling of Expression / PropertyName in style

2009-03-02 Thread Jody Garnett
Andrea Aime wrote: > Well, for that, I'd say we could tackle it in a number of ways: > - have a special function interface that allows for bounds compuatation > - just try to transform the bounds and get the bounds of the result > > I guess what I'm proposing is not really full blown Expression, bu

Re: [Geotools-devel] Handling of Expression / PropertyName in style

2009-03-02 Thread Andrea Aime
Jody Garnett wrote: > Hi Andrea: > > A while ago you talked about using an Expression (rather than a > PropertyName) in Rule; we have a similar thing in the symbolizers where > Expressions is already allowed. > > At the time our conversation got stuck based on how to calculate the > effective

[Geotools-devel] Build failed in Hudson: geotools-trunk #1426

2009-03-02 Thread Hudson
See http://hudson.opengeo.org/hudson/job/geotools-trunk/1426/changes -- [...truncated 780 lines...] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec Running org.geotools.referencing.FactoriesTest Mar 2, 2009 5:10:25 PM java.util.pref

Re: [Geotools-devel] EPSG authority connection handling patch

2009-03-02 Thread Jody Garnett
Andrea your patch sounds similar to the work I did in the referencing module; where everything was moved over to DataSource internally; and a connection was created as needed. It may not be directly similar since a pool of workers was kept each with a connection and cache; but they would be ret

[Geotools-devel] Build failed in Hudson: geotools-trunk #1425

2009-03-02 Thread Hudson
See http://hudson.opengeo.org/hudson/job/geotools-trunk/1425/changes Changes: [mcr] Improving user interface of utilities on 2.6.x -- [...truncated 789 lines...] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec Running org.geotools

Re: [Geotools-devel] GeoApi change breaks the build?

2009-03-02 Thread Justin Deoliveira
> Hum we should do something about this. From what I see whoever > is working on GeoApi changes is not making the corresponding > GeoTools changes. Shall we sit on a specific GeoApi build? > Cut a GeoApi relase? Or just get off GeoApi so that GeoTools can > have back some control on its destiny

Re: [Geotools-devel] JMapPane improvements

2009-03-02 Thread Michael Bedward
sorry about that - I'll fix up the introduction now Michael -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Str

Re: [Geotools-devel] EPSG authority connection handling patch

2009-03-02 Thread Andrea Aime
Martin Desruisseaux wrote: > Hello Andrea > > The problem you are pointing can be solved in a simplier way... > > >> A deeper analysis shows an architectural problem with the sql >> based EPSG factories, in particular, they get a hold on a single >> SQL connection and try to perform every operat

Re: [Geotools-devel] GeoApi change breaks the build?

2009-03-02 Thread Jody Garnett
I take that back; it looks some changes were deployed to GEOAPI I was unaware of trying to fix the build now. Jody Jody Garnett wrote: > Hi Andrea; > > I deployed the GeoAPI 2.3-SNAPSHOT and made sure to delete mine and do > a local build before committing. This is obviously my mistake and I >

Re: [Geotools-devel] EPSG authority connection handling patch

2009-03-02 Thread Martin Desruisseaux
Hello Andrea The problem you are pointing can be solved in a simplier way... > A deeper analysis shows an architectural problem with the sql > based EPSG factories, in particular, they get a hold on a single > SQL connection and try to perform every operation against it, > without any possibilit

Re: [Geotools-devel] StyleFactory review and portrayal package questions

2009-03-02 Thread Jody Garnett
On Tue, Mar 3, 2009 at 2:58 AM, johann sorel wrote: > Hi again, > > I've just maid my first complete review of the styleFactory. > > the major things I have fixed : > - missing rotation parameter on several creation methods Good catch. > > - symbolizer creation methods wanted an Expression, but

Re: [Geotools-devel] GeoApi change breaks the build?

2009-03-02 Thread Jody Garnett
Hi Andrea; I deployed the GeoAPI 2.3-SNAPSHOT and made sure to delete mine and do a local build before committing. This is obviously my mistake and I will look at it now. Can you confirm that maven downloaded GeoAPI 2.3-SNAPSHOT? Jody Andrea Aime wrote: > Hi, > my GeoTools build is broken even

[Geotools-devel] Handling of Expression / PropertyName in style

2009-03-02 Thread Jody Garnett
Hi Andrea: A while ago you talked about using an Expression (rather than a PropertyName) in Rule; we have a similar thing in the symbolizers where Expressions is already allowed. At the time our conversation got stuck based on how to calculate the effective bounds of an expression (with a coup

Re: [Geotools-devel] EPSG authority connection handling patch

2009-03-02 Thread Simone Giannecchini
Ciao Andrea, as you know this problem has been bothering us as well, we have customized geoservers in production that serve remote sensing layers acquired daily where this issue has popped up once in a while. I am +1 about applying the patch, since as you point out, right now referencing is more or

[Geotools-devel] GeoApi change breaks the build?

2009-03-02 Thread Andrea Aime
Hi, my GeoTools build is broken even after trying a -U build with the following error message: /home/aaime/devel/gt2-trunk/modules/library/main/src/main/java/org/geotools/styling/StyleFactoryImpl.java:[40,25] cannot find symbol symbol : class ExtensionSymbolizer location: package org.opengis.st

[Geotools-devel] EPSG authority connection handling patch

2009-03-02 Thread Andrea Aime
Hi, I'm writing to submit to the PSC consideration a patch for the sql based authority factories. Lately I've been repeatedly experiencing issues with the HSQL based EPSG factory, for some reason the connection to the EPSG database gets corrupted and GeoServer ability to decode SRS codes into CRS

Re: [Geotools-devel] GeoApi change breaks the build?

2009-03-02 Thread Andrea Aime
Andrea Aime wrote: > Hi, > my GeoTools build is broken even after trying a -U build with > the following error message: > > /home/aaime/devel/gt2-trunk/modules/library/main/src/main/java/org/geotools/styling/StyleFactoryImpl.java:[40,25] > > cannot find symbol > symbol : class ExtensionSymboliz

[Geotools-devel] Build failed in Hudson: geotools-trunk #1424

2009-03-02 Thread Hudson
See http://hudson.opengeo.org/hudson/job/geotools-trunk/1424/changes Changes: [mbedward] added a simple status bar class (not functional yet); re-arranged methods among the mouse listener / tool interfaces but it still seems to lack coherence [jive] patch up the build; some demo code breaking

Re: [Geotools-devel] JMapPane improvements

2009-03-02 Thread Jody Garnett
Aside be careful to build; after you remove the jmappane sample use demo; the demo/introduction failed because it made use of that module. Hopefully we can revise demo/introduction to use your new api tomorrow? Jody Michael Bedward wrote: > cheers mate > > I'll put a simple demo up as well tomo

Re: [Geotools-devel] Build failed in Hudson: geotools-trunk #1422

2009-03-02 Thread Jody Garnett
Looks like you got a bit of work; remember to do a "mvn clean install" before committing (note I got caught out today as well due to not doing a "mvn install -Dall" so it is not just you. Jody On Mon, Mar 2, 2009 at 7:47 PM, Hudson wrote: > See http://hudson.opengeo.org/hudson/job/geotools-trunk

Re: [Geotools-devel] JMapPane improvements

2009-03-02 Thread Michael Bedward
cheers mate I'll put a simple demo up as well tomorrow to illustrate the story so far Michael 2009/3/2 Jody Garnett : > Thanks muchly - I am going to review tomorrow morning (during my weekly > office hours) and hopefully produce some nice docs. When at work I will > deploy a 2.6-SNAPSHOT and we

[Geotools-devel] JMapPane improvements

2009-03-02 Thread Jody Garnett
Thanks muchly - I am going to review tomorrow morning (during my weekly office hours) and hopefully produce some nice docs. When at work I will deploy a 2.6-SNAPSHOT and we can ask interested parties on the user list to try out the code / docs. fun fun fun Jody Michael Bedward wrote: > oops -

[Geotools-devel] Build failed in Hudson: geotools-trunk #1423

2009-03-02 Thread Hudson
See http://hudson.opengeo.org/hudson/job/geotools-trunk/1423/changes Changes: [mbedward] removed mappane demo from build [mbedward] removing existing mappane demo -- [...truncated 8387 lines...] [INFO] Building Next Generation JDBC DataStores [INFO]ta

Re: [Geotools-devel] Build failed in Hudson: geotools-trunk #1422

2009-03-02 Thread Martin Desruisseaux
Hello Jive Its look like that the switch to GeoAPI 2.3-SNASHPOT is causing issue; I'm sorry for that. Do you want me to take the hand on that? Martin -- Open Source Business Conference (OSBC), March 24-25, 200

Re: [Geotools-devel] Build failed in Hudson: geotools-trunk #1422

2009-03-02 Thread Michael Bedward
oops - sorry, forgot to remove the existing JMapPane demo from trunk Michael 2009/3/2 Hudson : > See http://hudson.opengeo.org/hudson/job/geotools-trunk/1422/changes > > Changes: -- Open Source Business Conference (OSBC)

[Geotools-devel] Build failed in Hudson: geotools-trunk #1422

2009-03-02 Thread Hudson
See http://hudson.opengeo.org/hudson/job/geotools-trunk/1422/changes Changes: [jive] explicitly ignore geoapi-dummy-pending to restore build; no explicit dependeny on geoapi from unsupported/geometry to avoid tripping up on dummy-pending clash -- [...tru