[Geotools-devel] Postgis tests broken on trunk

2008-12-30 Thread Jody Garnett
Hi Andrea; this thread has been on my rainy day list for a while. I have added, but not committed, two utility methods: - Types.assertNameAssignable (ensures that the name/value relationship holds to the point that you can assign data over) - Types.assertOrderAssignable (ensures that the order/v

Re: [Geotools-devel] Postgis tests broken on trunk

2008-12-04 Thread Andrea Aime
Jody Garnett ha scritto: > Andrea Aime wrote: >> Looked into PostgisDataStore as well, no length information there >> either. And I cannot find anything in 2.2.x either: >> http://gtsvn.refractions.net/branches/2.2.x/module/main/src/org/geotools/data/jdbc/JDBC1DataStore.java >> >> >> >> So...

Re: [Geotools-devel] Postgis tests broken on trunk

2008-12-03 Thread Jody Garnett
Andrea Aime wrote: > Looked into PostgisDataStore as well, no length information there > either. And I cannot find anything in 2.2.x either: > http://gtsvn.refractions.net/branches/2.2.x/module/main/src/org/geotools/data/jdbc/JDBC1DataStore.java > > > > So... how is this a functionality restore?

Re: [Geotools-devel] Postgis tests broken on trunk

2008-12-03 Thread Andrea Aime
Jody Garnett ha scritto: > I feel a bit like the shot messenger; the change to the new feature > model resulted in the change to the equals contract. During that change > we lost the length information that I depended on for exporting > shapefiles from a PostGIS table FeatureType. Restoring that

Re: [Geotools-devel] Postgis tests broken on trunk

2008-12-02 Thread Jody Garnett
I feel a bit like the shot messenger; the change to the new feature model resulted in the change to the equals contract. During that change we lost the length information that I depended on for exporting shapefiles from a PostGIS table FeatureType. Restoring that has shown that the FeatureType

Re: [Geotools-devel] Postgis tests broken on trunk

2008-12-02 Thread Andrea Aime
Andrea Aime ha scritto: >> This is a dammed if you do dammed if you don't - the length information >> is needed if we are going to export from PostGIS into a shapefile >> correctly. > > Well, broken build is in my book more damned, it prevents any > other work in the module. It's the first sing

Re: [Geotools-devel] Postgis tests broken on trunk

2008-12-02 Thread Andrea Aime
Jody Garnett ha scritto: > In what way does this break the equality tests? Is data being truncated? >> Now, I'm wondering two things: >> - why is the build box not running the postgis tests? >>We must re-enable this, the normal dev build does not run them >> > That is also my question. Ok,

Re: [Geotools-devel] Postgis tests broken on trunk

2008-12-01 Thread Andrea Aime
Jody Garnett ha scritto: > Andrea Aime wrote: ... > Apparently not. >> Fixing this requires a softer equality, one that does not care about >> the restrictions, and that >> needs to be propagated in quite a bit of places... >> > It sounds like you are asking for a comparison of FeatureType her

Re: [Geotools-devel] Postgis tests broken on trunk

2008-12-01 Thread Jody Garnett
Andrea Aime wrote: > Hi, > > today I was looking into a postgis issue and found > that many tests on trunk were broken. > Investigating I tracked down the issue at a commit Jody > made one month and a half ago, that enables the length > restriction parsing on attributes: > r31660, October 14 2008,

Re: [Geotools-devel] Postgis tests broken on trunk

2008-12-01 Thread Andrea Aime
Andrea Aime ha scritto: > Hi, > today I was looking into a postgis issue and found > that many tests on trunk were broken. > Investigating I tracked down the issue at a commit Jody > made one month and a half ago, that enables the length > restriction parsing on attributes: > r31660, October 14 200

[Geotools-devel] Postgis tests broken on trunk

2008-12-01 Thread Andrea Aime
Hi, today I was looking into a postgis issue and found that many tests on trunk were broken. Investigating I tracked down the issue at a commit Jody made one month and a half ago, that enables the length restriction parsing on attributes: r31660, October 14 2008, "Make use of length if available"