Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_9.0/armv7l
Package network:osmocom:nightly/osmo-mgw failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build log:
[
Patch Set 1: Code-Review-1
(2 comments)
libosmo-trau -> libosmotrau and the rest looks fine.
https://gerrit.osmocom.org/#/c/5169/1/recipes-osmocom/libosmo-abis/libosmo-abis.inc
File recipes-osmocom/libosmo-abis/libosmo-abis.inc:
Line 7: INC_PR="r3.${META_TELEPHONY_OSMO_INC}"
We can drop the
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5168
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf50808f0b826e82614ecd5844ab082ac017873
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_9.0/aarch64
Package network:osmocom:nightly/osmo-mgw failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/xUbuntu_17.04/x86_64
Package network:osmocom:nightly/osmo-mgw failed to build in xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/osmo-mgw failed to build in xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/osmo-mgw failed to build in xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_8.0/i586
Package network:osmocom:nightly/osmo-mgw failed to build in Debian_8.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/xUbuntu_17.10/x86_64
Package network:osmocom:nightly/osmo-mgw failed to build in xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_8.0/x86_64
Package network:osmocom:nightly/osmo-mgw failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_9.0/x86_64
Package network:osmocom:nightly/osmo-mgw failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/xUbuntu_17.04/i586
Package network:osmocom:nightly/osmo-mgw failed to build in xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_9.0/i586
Package network:osmocom:nightly/osmo-mgw failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/xUbuntu_16.10/i586
Package network:osmocom:nightly/osmo-mgw failed to build in xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/xUbuntu_16.04/i586
Package network:osmocom:nightly/osmo-mgw failed to build in xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-mgw
Last lines of build log:
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/5006/2/src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl
File src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl:
Line 77: gprs nsvc 0 local udp port 23000
Reminder: I shall set this one to 23020 like already done in osmo-bsc.cfg.tmpl
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/5008/2/src/osmo_gsm_tester/bts_octphy.py
File src/osmo_gsm_tester/bts_octphy.py:
Line 177: config.overlay(values, sgsn_conf)
> heh, why not
What would happen then? because self.sgsn is None in that case. Does overlay()
actually
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/#/c/5004/2/src/osmo_gsm_tester/pcu_osmo.py
File src/osmo_gsm_tester/pcu_osmo.py:
Line 43: # othwerwise osmo-pcu ends after connecting to socket with
"pcu_l1_if.cpp:416 BTS not available"
> (typo otherwise)
I'll fix it.
Line 44:
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/5003/2/src/osmo_gsm_tester/pcu_sysmo.py
File src/osmo_gsm_tester/pcu_sysmo.py:
Line 49: event_loop.wait(self, self.sysmobts.ready_for_pcu)
> expecting this to be part of the test script. We should not make assumption
I don't
Review at https://gerrit.osmocom.org/5177
osmo-sgsn: Install example osmo-gtphub config file
Change-Id: Ie8ee1e4b1e0d0a7ca00764a1906b1ff26b7bea4d
---
M recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/5178
osmocom: Use CONFFILES for cfg files
Change-Id: I4a4c7d4a5e3e58c413c82b75f442ae9321d64998
---
M recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
M recipes-osmocom/osmo-bsc/osmo-bsc.inc
M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
M
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/5008/2/src/osmo_gsm_tester/bts_octphy.py
File src/osmo_gsm_tester/bts_octphy.py:
Line 177: config.overlay(values, sgsn_conf)
heh, why not
if self.sgsn:
config.overlay...
--
To view, visit
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/5004/2/src/osmo_gsm_tester/pcu_osmo.py
File src/osmo_gsm_tester/pcu_osmo.py:
Line 44: event_loop.wait(self, self.bts.ready_for_pcu)
> oh, here it is. I'd have expected this in a test script instead.
decided that this
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/5003/2/src/osmo_gsm_tester/pcu_sysmo.py
File src/osmo_gsm_tester/pcu_sysmo.py:
Line 49: event_loop.wait(self, self.sysmobts.ready_for_pcu)
expecting this to be part of the test script. We should not make assumptions
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5001
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eed70838e4e8656c4bc1337df70e631a10d69c7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5002
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec370a444998c632b3615ad1a6d6f67e64e2bfeb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/5006/2/src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl
File src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl:
Line 81: % else:
indent is not same as '% if'
--
To view, visit https://gerrit.osmocom.org/5006
To
Patch Set 2: Code-Review+1
(3 comments)
https://gerrit.osmocom.org/#/c/5004/2/src/osmo_gsm_tester/pcu_osmo.py
File src/osmo_gsm_tester/pcu_osmo.py:
Line 43: # othwerwise osmo-pcu ends after connecting to socket with
"pcu_l1_if.cpp:416 BTS not available"
(typo otherwise)
Line 44:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5007
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I777835345355538a945599fb088630af63dc9140
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/5157/1/include/osmocom/bsc/osmo_bsc_mgcp.h
File include/osmocom/bsc/osmo_bsc_mgcp.h:
Line 47:mgcp_trans_id_t mgw_pending_trans;
(makes me think ... this requires that we only have a single MGCP transaction
pending
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5174
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bce9ca39b7751b557374b7ab57c6c9005bcdb7d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5175
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d044382c0bb66e190400e3397449c3f2387359a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5176
ggsn: Ignore PCO with length 0, don't abort processing
The existing code would abort iterating over the list of PCO TLVs
if a TLV of length zero was encountered. However, there's nothing
in the spec that would make a zero-length PCO invalid, so we
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5107
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7badc729e97b76701abbce6a73a1ad1e46d3fee0
Gerrit-PatchSet: 4
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1: Code-Review+2
(2 comments)
https://gerrit.osmocom.org/#/c/5172/1/tests/mgcp/mgcp_test.c
File tests/mgcp/mgcp_test.c:
Line 796: if (msg && strcmp(t->name, "CRCX") == 0) {
lol, didn't even see the missing quotes ... so much for picking too general
macro names further
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/5011/3/suites/gprs/ping.py
File suites/gprs/ping.py:
Line 29: bts.start()
> wait(bts.ready_for_pcu) ?
That's done by the pcu automatically when needed.
--
To view, visit https://gerrit.osmocom.org/5011
To unsubscribe, visit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5173
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ee79eaaca2fada673baf6ff4c226aa16c26269
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5167
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a23c1828cf216031d69d481ad35dd458ee7d4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5175
to look at the new patch set (#2).
mgcp_test: fix possible double free
Change-Id: I2d044382c0bb66e190400e3397449c3f2387359a
---
M tests/mgcp/mgcp_test.c
1 file changed, 2
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5174
to look at the new patch set (#2).
mgcp_test: add returncode check
The returncode of get_conn_id_from_response() is unchecked, which
is intentional since some of the test messages will
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5173
to look at the new patch set (#2).
mgcp_test: fix nullpointer dereference
Change-Id: Ic2ee79eaaca2fada673baf6ff4c226aa16c26269
Fixes: Coverity CID#180536
---
M
Patch Set 1:
Yes it is used afterwards in another commit, but that one is already quite big
so it's better to split this into a former commit
--
To view, visit https://gerrit.osmocom.org/5067
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/5173/1//COMMIT_MSG
Commit Message:
Line 7: mgcp_test: fix nullpointer dereferentiation
("dereference" or "dereferencing")
--
To view, visit https://gerrit.osmocom.org/5173
To unsubscribe, visit
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/5011/3/suites/gprs/ping.py
File suites/gprs/ping.py:
Line 29: bts.start()
wait(bts.ready_for_pcu) ?
--
To view, visit https://gerrit.osmocom.org/5011
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5067/1//COMMIT_MSG
Commit Message:
Line 11: "pcu_l1_if.cpp:416 BTS not available"
there's no caller though, I assume that will follow in a test case?
--
To view, visit https://gerrit.osmocom.org/5067
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5067
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7209589f60bda63094336e417638906be5e273c4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5066
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c1bef81040e2c6210177f04743e7acf3eb9ad8f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5011
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8695029cb7a43cd48f650c88f38b4c054da0bc6b
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5068
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie65d7d33322c775a1040b5c81f367d882a7c2c5b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Review at https://gerrit.osmocom.org/5173
mgcp_test: fix nullpointer dereferentiation
Change-Id: Ic2ee79eaaca2fada673baf6ff4c226aa16c26269
Fixes: Coverity CID#180536
---
M tests/mgcp/mgcp_test.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5172
mgcp_test: fix wrong strcmp() parameters
The CRCX string parameter lacks the quotes and the result of
the function call is not checked against zero. Also the
return code of get_conn_id_from_response() is not asserted.
Fixes: Coverity CID#180534
Review at https://gerrit.osmocom.org/5174
mgcp_test: add returncode check
The returncode of get_conn_id_from_response() is unchecked, which
is intentional since some of the test messages will intentionally cause
this function to fail (the response does not inclde a connection
identifier). This
Review at https://gerrit.osmocom.org/5175
mgcp_test: fix possible double free
Change-Id: I2d044382c0bb66e190400e3397449c3f2387359a
---
M tests/mgcp/mgcp_test.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/75/5175/1
diff --git
Review at https://gerrit.osmocom.org/5171
ortp: Move DEPENDS to inc file and fix whitespace
Change-Id: Idf1c060d8fdbe0a309366ed7bd1e79f40625405c
---
M recipes-misc/ortp/ortp.inc
M recipes-misc/ortp/ortp_0.25.0.bb
2 files changed, 2 insertions(+), 3 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5170
ortp: Remove unused old ortp 0.16.5
A new version 0.25.0 was added around 3 years ago and has been used
since then, because osmocom stack requires at least 0.22.0.
This 0.16.5 version has been unused since then, so we can drop it.
Change-Id:
Review at https://gerrit.osmocom.org/5169
libosmo-abis: Split libosmo-trau into its own package
Change-Id: Ica8b6c39aed9f3370aeab84e821c8de871d2f0be
---
M recipes-osmocom/libosmo-abis/libosmo-abis.inc
1 file changed, 9 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5168
libosmo-abis: Remove unused patch
The patch was applied upstream in
37fcd93a508b52f6f33bf47191bba41cb7367b0d, and removed from libosmo-abis
recipe in meta-telephony d91abc18f1a1d0003fe946c5dce173f1946b9712.
Change-Id:
Patch Set 1: Code-Review+1
I confirm this fixes the segfault in my PC and test passes successfully.
--
To view, visit https://gerrit.osmocom.org/5167
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/5167
client: use string as connection identifier
The test that tests the cancelation of a pending mgcp message
uses an integer as connection identifier, which leads to a
segfault since connection identifiers are represented as strings.
Use a string as
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4980
to look at the new patch set (#9).
mgcp: use osmo-mgw to switch rtp streams
in the current implementation we still use osmo-bsc_mgcp, which
has many problems and is also
Review at https://gerrit.osmocom.org/5166
osmo-hnbgw: don't configure specific local IP address for STP connection
It's not necessary to set a local IP to connect to OsmoSTP with, 'any' is as
good as any.
Related: OS#2663
Change-Id: If5d0a1500de5e2c4b80acf025761d0264a8a51a0
---
M src/hnbgw.c
Patch Set 2:
Do you have any alternative in mind regarding this topic? AFAIR that's how it's
done in the kernel for instance. Or maybe you think it's not worth it having
aflag to disable ipv6 support?
--
To view, visit https://gerrit.osmocom.org/5121
To unsubscribe, visit
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS
..
osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS
The upper layers (L1SAP,
Patch Set 3: Verified+1
--
To view, visit https://gerrit.osmocom.org/5136
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1065ae9c400bb5240a63ab8213aee59aeb9ceeff
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5136
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1065ae9c400bb5240a63ab8213aee59aeb9ceeff
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review-1
I think it's rather ugly to have the code full of #ifdef's. I'm really not
sure if this is the way to go, sorry.
--
To view, visit https://gerrit.osmocom.org/5121
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5162
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3906dbf55ccf1650083398e08ac870add0bbdcef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5160
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e226a12b074c96c572f90e3aaf62716d0cd47c5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5161
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I207362e055dbfafc42fad2cfdd0cf1da9dcad88b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5163
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id62f186d93bb0165764d9d25fbee2d359df79149
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: UHDDevice.cpp: add USRP B205mini support
..
UHDDevice.cpp: add USRP B205mini support
The B205mini is similar to the B200mini and runs OsmoTRX just
Patch Set 1:
patch adding the option in osmo-ci can be found in
https://gerrit.osmocom.org/#/c/5165/
--
To view, visit https://gerrit.osmocom.org/5163
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 3: Code-Review+1
> I don't have equipment right now to test this, but the code looks
> good on the first glance.
>
> Just one comment - is this requirement of sending the first frame
> number documented in the parameters of the relevant functions? That
> would be great to have it
Review at https://gerrit.osmocom.org/5165
jobs: Add IPv6 build option to osmo-ggsn job
Change-Id: I3f97bcd163b0458d00c0def7982cdaa349f08747
---
M jobs/gerrit-verifications.yml
M jobs/master-builds.yml
2 files changed, 6 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5164
jobs: Fix osmo-ggsn GTP build option
As far as I understand, the variable is populated using the name field.
In openggsn build it matches, but it doesn't in osmo-ggsn.
Change-Id: Ifb1a630b77a8c2f442e26dbef8e608882e8f9a71
---
M
Review at https://gerrit.osmocom.org/5163
contrib: Add IPv6 build option
Change-Id: Id62f186d93bb0165764d9d25fbee2d359df79149
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/63/5163/1
diff --git
Review at https://gerrit.osmocom.org/5162
tests: Split ipv6 specific tests into a new test group
This way they can be easily disabled later on when IPv6 support is made
optional.
Change-Id: I3906dbf55ccf1650083398e08ac870add0bbdcef
---
M tests/lib/Makefile.am
M tests/lib/in46a_test.c
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5121
to look at the new patch set (#2).
Add configure flag to disable ipv6 support
Some users may want to disable ipv6 related features in case they are
not needed. It can also be used as a
Review at https://gerrit.osmocom.org/5159
Embedded: fix sercomm test
The external sercomm_drv_[un]lock() functions are defined as stubs in
case of non-embedded build only which causes linking issue with
sercomm_test. Let's define the same stubs in sercomm_test
unconditionally - the
Patch Set 2:
With this new version tests are passing both with "--disable-ipv6" flag and
with "--enable-ipv6" (default) flag.
I tested locally with an osmo-bts-trx and a mobile phone that GPRS was working
fine in both cases.
TODO:
- Modify osmo-ggsn to build both with "disable-ipv6" flag and
Review at https://gerrit.osmocom.org/5160
ggsn.c: Print version of unhandled ip packet
Change-Id: I7e226a12b074c96c572f90e3aaf62716d0cd47c5
---
M ggsn/ggsn.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/60/5160/1
diff --git
Review at https://gerrit.osmocom.org/5158
TBF: implement independent T31xx timers
Previously TBF got single timer so the pending timer was automatically
cancelled when new one was scheduled. Let's make it more robust by
implementing independent T31 xx timers from 3GPP TS 44.060 ยง13.2 with
Review at https://gerrit.osmocom.org/5157
mgcp: cancel transactions on timeout
when a transaction to the MGW times out, then the context
information is freed. Unfortunately the client is not informed
about this and will try to execute the callback anyway.
explicitly cancel the transaction in
Patch Set 2: Code-Review-1
I guess this can be abandoned now?
--
To view, visit https://gerrit.osmocom.org/2537
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cb8a90010451bed3a1462ac9ba48275c28d48aa
Gerrit-PatchSet: 2
Gerrit-Project:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5084/1/src/Makefile.am
File src/Makefile.am:
Line 25:libcommon-cs \
> Does this position really matter? I mean, if you are running with parallel
I'm not 100% sure but I think that parallel make takes this into account. At
least
Max has submitted this change and it was merged.
Change subject: Remove unneeded .py scripts
..
Remove unneeded .py scripts
The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for
vty and ctrl tests instead of
Patch Set 1:
It's only used inside OSMO_ASSERT() where it's compared to 0. I think it would
be better to just print it, but that's rather topic for another patch.
--
To view, visit https://gerrit.osmocom.org/5119
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Max has submitted this change and it was merged.
Change subject: Fix compiler warning
..
Fix compiler warning
Move function declarations which use gprs_rlcmac_ul_tbf into tbf.h to
avoid compiler warning:
In file included from
Patch Set 1:
We're testing it, so I've been asking this myself. One possible reason is that
I'm using latest xubuntu and the build slave is old jenkins. Maybe smth in the
toolchain have become stricter in a meantime?
--
To view, visit https://gerrit.osmocom.org/5123
To unsubscribe, visit
Max has submitted this change and it was merged.
Change subject: embedded: fix tests
..
embedded: fix tests
In case of embedded build some tests are failing to link properly. Fix
it:
* do not run fsm_test unless CTRL is
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5084/1/src/Makefile.am
File src/Makefile.am:
Line 25:libcommon-cs \
Does this position really matter? I mean, if you are running with parallel
make, couldn't it fail the same way?
--
To view, visit
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5139
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7e1af11cdac8587bb4d66fb4eacee4b79945359
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Return the name of the configured "MS"
..
mobile: Return the name of the configured "MS"
In lua osmo.ms():name() will print the name/number
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Simplify code and check the cb ref in load_cb
..
mobile: Simplify code and check the cb ref in load_cb
Change parameters and check if the
94 matches
Mail list logo
