Change in osmo-sgsn[master]: osmo-sgsn: ping GGSN periodically and check for restart counter

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9934 ) Change subject: osmo-sgsn: ping GGSN periodically and check for restart counter .. Patch Set 2: (3 comments)

Change in osmo-sgsn[master]: Maintain per ggsn pdp ctx list

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9933 ) Change subject: Maintain per ggsn pdp ctx list .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9933/1//COMMIT_MSG Commit

Change in osmo-sgsn[master]: sgsn_libgtp.c: Log pointer of deleted context

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9932 ) Change subject: sgsn_libgtp.c: Log pointer of deleted context .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: ms: Quit early when all tests concluded..

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9716 ) Change subject: ms: Quit early when all tests concluded.. .. Patch Set 3: @pespin: Please review the latest version of this patch. Your

Change in simtrace2[master]: sniff: add checksum verification for ATR and PPS

2018-07-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9966 ) Change subject: sniff: add checksum verification for ATR and PPS .. sniff: add checksum verification for ATR and PPS a checksum

Change in simtrace2[master]: sniff: add checksum verification for ATR and PPS

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9966 ) Change subject: sniff: add checksum verification for ATR and PPS .. Patch Set 6: Code-Review+2 -- To view, visit

Change in python/osmo-python-tests[master]: Introduce script ctrl2cgi.py

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9963 ) Change subject: Introduce script ctrl2cgi.py .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9963 To

Change in libosmocore[master]: tests: ctrl: Test received ERROR messages are handled correctly

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9984 ) Change subject: tests: ctrl: Test received ERROR messages are handled correctly .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: ctrl: ctrl_handle_msg: Avoid sending back received ERROR msgs

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9983 ) Change subject: ctrl: ctrl_handle_msg: Avoid sending back received ERROR msgs .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: ctrl: Introduce ctrl_cmd_parse3 API

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9978 ) Change subject: ctrl: Introduce ctrl_cmd_parse3 API .. Patch Set 2: I'm not sure if the API shouldn't be redesigned completely. The entire

Change in openbsc[master]: bsc: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9981 ) Change subject: bsc: ctrl: Avoid sending back received ERROR msgs .. Patch Set 3: Code-Review+2 -- To view, visit

Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9979 ) Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation .. Patch Set 3: Code-Review+1 -- To view,

Change in openbsc[master]: nat: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9980 ) Change subject: nat: ctrl: Avoid sending back received ERROR msgs .. Patch Set 3: Code-Review+2 -- To view, visit

Change in libosmocore[master]: gsm0808: Add value_string for encryption algorithms

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9901 ) Change subject: gsm0808: Add value_string for encryption algorithms .. Patch Set 3: Code-Review+2 -- To view, visit

Change in openbsc[master]: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/9973 ) Change subject: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed

Change in openbsc[master]: bsc: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/9974 ) Change subject: bsc: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. bsc: ctrl: Use ctrl_cmd_parse2 to obtain detailed

Change in libosmocore[master]: gsm0808: Add value_string for encryption algorithms

2018-07-12 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9901 to look at the new patch set (#3). Change subject: gsm0808: Add value_string for encryption algorithms

Change in libosmo-sccp[master]: comment: explain xua_msg free in m3ua_rx_xfer()

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9958 ) Change subject: comment: explain xua_msg free in m3ua_rx_xfer() .. Patch Set 3: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: add osmo_xua_msg_tall_ctx_init()

2018-07-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9953 ) Change subject: add osmo_xua_msg_tall_ctx_init() .. add osmo_xua_msg_tall_ctx_init() So far the tall_xua ctx used to allocate from

Change in libosmo-sccp[master]: fix two memleaks in ipa_rx_msg_sccp()

2018-07-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9956 ) Change subject: fix two memleaks in ipa_rx_msg_sccp() .. fix two memleaks in ipa_rx_msg_sccp() 1: Do not call xua_msg_alloc() which

Change in libosmo-sccp[master]: add osmo_xua_msg_tall_ctx_init()

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9953 ) Change subject: add osmo_xua_msg_tall_ctx_init() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9953 To

Change in osmo-bsc[master]: call osmo_xua_msg_tall_ctx_init()

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9955 ) Change subject: call osmo_xua_msg_tall_ctx_init() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9955 To

Change in libosmocore[master]: rate_ctr: Improve logging

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9753 ) Change subject: rate_ctr: Improve logging .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/9753/3//COMMIT_MSG Commit Message:

Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

2018-07-12 Thread Pau Espin Pedrol
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9979 to look at the new patch set (#3). Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation

Change in libosmocore[master]: ctrl: Log CMD TYPE on invalid ID number

2018-07-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9972 ) Change subject: ctrl: Log CMD TYPE on invalid ID number .. ctrl: Log CMD TYPE on invalid ID number Change-Id:

Change in libosmocore[master]: ctrl: Fix parsing of ERROR recvd msgs with id=err

2018-07-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9977 ) Change subject: ctrl: Fix parsing of ERROR recvd msgs with id=err .. ctrl: Fix parsing of ERROR recvd msgs with id=err Our

Change in libosmocore[master]: ctrl: Fix parsing of ERROR recvd msgs with id=err

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9977 ) Change subject: ctrl: Fix parsing of ERROR recvd msgs with id=err .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9982 ) Change subject: ctrl: Avoid sending back received ERROR msgs .. Patch Set 1: (1 comment)

Change in libosmocore[master]: ctrl: Log CMD TYPE on invalid ID number

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9972 ) Change subject: ctrl: Log CMD TYPE on invalid ID number .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9972 To

Change in pysim[master]: pySim-read: read contents of PLMN related files.

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9969 ) Change subject: pySim-read: read contents of PLMN related files. .. Patch Set 3: Code-Review+2 -- To view, visit

Change in pysim[master]: cards: add update method for EF:PLMNsel to Card class

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9970 ) Change subject: cards: add update method for EF:PLMNsel to Card class .. Patch Set 1: Code-Review+2 -- To view, visit

Change in pysim[master]: pySim-read: Print exception when reading of EF.MSISDN fails

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9968 ) Change subject: pySim-read: Print exception when reading of EF.MSISDN fails .. Patch Set 2: Code-Review+2 -- To view, visit

Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9979 ) Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation .. Patch Set 2: Code-Review+2 (1 comment)

Change in osmo-bsc[master]: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9982 ) Change subject: ctrl: Avoid sending back received ERROR msgs .. Patch Set 1: Code-Review+1 (1 comment)

Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9979 ) Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation .. Patch Set 2: Code-Review-1 (1 comment)

Change in openbsc[master]: nat: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9980 ) Change subject: nat: ctrl: Avoid sending back received ERROR msgs .. Patch Set 2: Code-Review+2 -- To view, visit

Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9979 ) Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation .. Patch Set 2: (1 comment)

Change in openbsc[master]: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9973 ) Change subject: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. Patch Set 1: Code-Review+2 ah ok wait, so when the peer sent an

Change in openbsc[master]: nat: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9980 ) Change subject: nat: ctrl: Avoid sending back received ERROR msgs .. Patch Set 2: (1 comment)

Change in openbsc[master]: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9973 ) Change subject: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. Patch Set 1: This is a patch previous to introduction of

Change in openbsc[master]: bsc: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9974 ) Change subject: bsc: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. Patch Set 1: This is a patch previous to introduction of

Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9979 ) Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation .. Patch Set 2: (1 comment)

Change in openbsc[master]: bsc: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9974 ) Change subject: bsc: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. Patch Set 1: (1 comment)

Change in openbsc[master]: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9973 ) Change subject: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. Patch Set 1: -Code-Review (1 comment)

Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

2018-07-12 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9979 to look at the new patch set (#2). Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation

Change in openbsc[master]: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9973 ) Change subject: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. Patch Set 1: Code-Review+2 -- To view, visit

Change in pysim[master]: cosmetic: fix excess space in log output (typo)

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9967 ) Change subject: cosmetic: fix excess space in log output (typo) .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: tests: ctrl: Test received ERROR messages are handled correctly

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9984 Change subject: tests: ctrl: Test received ERROR messages are handled correctly .. tests: ctrl: Test received ERROR messages are handled

Change in libosmocore[master]: ctrl: Introduce ctrl_cmd_parse3 API

2018-07-12 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9978 to look at the new patch set (#2). Change subject: ctrl: Introduce ctrl_cmd_parse3 API .. ctrl: Introduce

Change in libosmocore[master]: ctrl: ctrl_handle_msg: Avoid sending back received ERROR msgs

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9983 Change subject: ctrl: ctrl_handle_msg: Avoid sending back received ERROR msgs .. ctrl: ctrl_handle_msg: Avoid sending back received ERROR

Change in libosmocore[master]: ctrl: Log CMD TYPE on invalid ID number

2018-07-12 Thread Pau Espin Pedrol
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9972 to look at the new patch set (#3). Change subject: ctrl: Log CMD TYPE on invalid ID number .. ctrl:

Change in libosmocore[master]: ctrl: Fix parsing of ERROR recvd msgs with id=err

2018-07-12 Thread Pau Espin Pedrol
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9977 to look at the new patch set (#2). Change subject: ctrl: Fix parsing of ERROR recvd msgs with id=err ..

Change in libosmocore[master]: ctrl: Fix parsing of ERROR recvd msgs with id=err

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9977 ) Change subject: ctrl: Fix parsing of ERROR recvd msgs with id=err .. Patch Set 1: Code-Review+2 (1 comment)

Change in libosmocore[master]: gsm_08_08: gsm0808_permitted_speech does not have value strings

2018-07-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9976 ) Change subject: gsm_08_08: gsm0808_permitted_speech does not have value strings .. gsm_08_08: gsm0808_permitted_speech does not have

Change in libosmocore[master]: gsm_04_08: add function to get value string

2018-07-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9975 ) Change subject: gsm_04_08: add function to get value string .. gsm_04_08: add function to get value string The value string table

Change in libosmocore[master]: gsm_08_08: gsm0808_permitted_speech does not have value strings

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9976 ) Change subject: gsm_08_08: gsm0808_permitted_speech does not have value strings .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: gsm_04_08: add function to get value string

2018-07-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9975 ) Change subject: gsm_04_08: add function to get value string .. Patch Set 1: Code-Review+2 the policy is that we add inline functions excatly

Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9979 ) Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation .. Patch Set 1: (1 comment)

Change in libosmocore[master]: ctrl: Log CMD TYPE on invalid ID number

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9972 ) Change subject: ctrl: Log CMD TYPE on invalid ID number .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9972 To

Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9979 ) Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9982 ) Change subject: ctrl: Avoid sending back received ERROR msgs .. Patch Set 1: Requires libosmocore

Change in osmo-bsc[master]: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9982 Change subject: ctrl: Avoid sending back received ERROR msgs .. ctrl: Avoid sending back received ERROR msgs Change-Id:

Change in openbsc[master]: bsc: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9981 ) Change subject: bsc: ctrl: Avoid sending back received ERROR msgs .. Patch Set 1: Requires libosmocore

Change in openbsc[master]: bsc: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9981 Change subject: bsc: ctrl: Avoid sending back received ERROR msgs .. bsc: ctrl: Avoid sending back received ERROR msgs Change-Id:

Change in libosmocore[master]: gsm_04_08: add function to get value string

2018-07-12 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/9975 ) Change subject: gsm_04_08: add function to get value string .. Patch Set 1: > I'm not against doing it one way or the other, but I think we >

Change in openbsc[master]: nat: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9980 ) Change subject: nat: ctrl: Avoid sending back received ERROR msgs .. Patch Set 1: Requires libosmocore

Change in openbsc[master]: nat: ctrl: use strtol instead of atoi as it has explicit error docume...

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9979 Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation .. nat: ctrl: use strtol instead of atoi as

Change in openbsc[master]: nat: ctrl: Avoid sending back received ERROR msgs

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9980 Change subject: nat: ctrl: Avoid sending back received ERROR msgs .. nat: ctrl: Avoid sending back received ERROR msgs We only send back

Change in libosmocore[master]: ctrl: Fix parsing of ERROR recvd msgs with id=err

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9977 Change subject: ctrl: Fix parsing of ERROR recvd msgs with id=err .. ctrl: Fix parsing of ERROR recvd msgs with id=err Our implementation

Change in libosmocore[master]: ctrl: Introduce ctrl_cmd_parse3 API

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9978 Change subject: ctrl: Introduce ctrl_cmd_parse3 API .. ctrl: Introduce ctrl_cmd_parse3 API Callers require to know whether the returned

Change in libosmocore[master]: gsm_08_08: gsm0808_permitted_speech does not have value strings

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9976 ) Change subject: gsm_08_08: gsm0808_permitted_speech does not have value strings .. Patch Set 1: Same for this one. Do we want to have an

Change in libosmocore[master]: gsm_08_08: gsm0808_permitted_speech does not have value strings

2018-07-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9976 Change subject: gsm_08_08: gsm0808_permitted_speech does not have value strings .. gsm_08_08: gsm0808_permitted_speech does not have value strings

Change in libosmocore[master]: gsm_04_08: add function to get value string

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9975 ) Change subject: gsm_04_08: add function to get value string .. Patch Set 1: I'm not against doing it one way or the other, but I think

Change in libosmocore[master]: gsm_04_08: add function to get value string

2018-07-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9975 Change subject: gsm_04_08: add function to get value string .. gsm_04_08: add function to get value string The value string table

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #182

2018-07-12 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Change in libosmocore[master]: vty: fix use-after-free and memleaks in is_cmd_ambiguous()

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9939 ) Change subject: vty: fix use-after-free and memleaks in is_cmd_ambiguous() .. Patch Set 2: (2 comments)

Change in libosmocore[master]: vty: fix use-after-free and memleaks in is_cmd_ambiguous()

2018-07-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9939 ) Change subject: vty: fix use-after-free and memleaks in is_cmd_ambiguous() .. Patch Set 2: (3 comments)

Change in libosmocore[master]: vty: fix use-after-free and memleaks in is_cmd_ambiguous()

2018-07-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/9939 ) Change subject: vty: fix use-after-free and memleaks in is_cmd_ambiguous() .. vty: fix use-after-free and memleaks in

Build failed in Jenkins: master-gapk » a1=default,a2=default,a3=default,osmocom-master-debian9 #18

2018-07-12 Thread jenkins
See -- [...truncated 127.42 KB...] checking dynamic linker characteristics... GNU/Linux ld.so checking how to hardcode

Change in openbsc[master]: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9973 ) Change subject: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. Patch Set 1: Relaed: https://osmocom.org/issues/3394 -- To

Change in openbsc[master]: bsc: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9974 Change subject: bsc: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. bsc: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

Change in openbsc[master]: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9973 Change subject: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error .. nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error

Change in libosmocore[master]: ctrl: Log CMD TYPE on invalid ID number

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9972 Change subject: ctrl: Log CMD TYPE on invalid ID number .. ctrl: Log CMD TYPE on invalid ID number Change-Id:

Change in gr-gsm[master]: README.md: fix white space

2018-07-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9971 ) Change subject: README.md: fix white space .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/9971 To

Change in gr-gsm[master]: README.md: fix white space

2018-07-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded a new patch set (#2) to the change originally created by Piotr Krysik. ( https://gerrit.osmocom.org/9971 ) Change subject: README.md: fix white space .. README.md: fix white space Change-Id:

Change in gr-gsm[master]: Foobar change to test gerrit again

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9971 ) Change subject: Foobar change to test gerrit again .. Patch Set 1: You probably want to "Abandon" this patch I guess (there's a button

Change in gr-gsm[master]: Foobar change to test gerrit again

2018-07-12 Thread Piotr Krysik
Piotr Krysik has posted comments on this change. ( https://gerrit.osmocom.org/9971 ) Change subject: Foobar change to test gerrit again .. Patch Set 1: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/9971 To

Change in gr-gsm[master]: Foobar change to test gerrit again

2018-07-12 Thread Piotr Krysik
Piotr Krysik has uploaded this change for review. ( https://gerrit.osmocom.org/9971 Change subject: Foobar change to test gerrit again .. Foobar change to test gerrit again Change-Id: I818b5296e2a208df9f096bcc9d13b88ffe01379c

Change in libosmo-sccp[master]: sua: Export IEI value_string names

2018-07-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has abandoned this change. ( https://gerrit.osmocom.org/9959 ) Change subject: sua: Export IEI value_string names .. Abandoned -- To view, visit https://gerrit.osmocom.org/9959 To unsubscribe, or for help

Change in pysim[master]: pySim-read: read contents of PLMN related files.

2018-07-12 Thread dexter
dexter has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/9969 ) Change subject: pySim-read: read contents of PLMN related files. .. pySim-read: read contents of PLMN related files. The files EF.PLMNsel,

Change in pysim[master]: pySim-read: Print exception when reading of EF.MSISDN fails

2018-07-12 Thread dexter
dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/9968 ) Change subject: pySim-read: Print exception when reading of EF.MSISDN fails .. pySim-read: Print exception when reading of EF.MSISDN fails At the

Change in pysim[master]: tests: add test program to verify pysim-prog.py (and pysim-read.py)

2018-07-12 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/9947 ) Change subject: tests: add test program to verify pysim-prog.py (and pysim-read.py) .. Patch Set 3: (1 comment) The whitespace issues are now

Change in pysim[master]: tests: add test program to verify pysim-prog.py (and pysim-read.py)

2018-07-12 Thread dexter
dexter has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/9947 ) Change subject: tests: add test program to verify pysim-prog.py (and pysim-read.py) .. tests: add test program to verify pysim-prog.py (and

Change in pysim[master]: tests: add test program to verify pysim-prog.py (and pysim-read.py)

2018-07-12 Thread dexter
dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/9947 ) Change subject: tests: add test program to verify pysim-prog.py (and pysim-read.py) .. tests: add test program to verify pysim-prog.py (and