Change in osmo-ttcn3-hacks[master]: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL

2018-11-05 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11562 ) Change subject: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: bsc: gsm0808: Fix return code in bsc_compl_l3

2018-11-05 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11605 ) Change subject: bsc: gsm0808: Fix return code in bsc_compl_l3 .. Patch Set 1: (1 comment) Or, even better, use errno constants.

Change in osmo-gsm-manuals[master]: msc: update vty reference

2018-11-05 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11587 ) Change subject: msc: update vty reference .. Patch Set 1: Would be nice to see in commit message how the update was actually done. Is it somehow

Change in osmo-ttcn3-hacks[master]: BSC LCLS: add bts-loop tests

2018-11-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11559 ) Change subject: BSC LCLS: add bts-loop tests .. Patch Set 3: (5 comments) https://gerrit.osmocom.org/#/c/11559/3/bsc/BSC_Tests.ttcn

Change in libosmocore[master]: Support cipher mode reject with extended cause

2018-11-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11601 ) Change subject: Support cipher mode reject with extended cause .. Patch Set 1: (1 comment)

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_resp_unsol

2018-11-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11604 ) Change subject: bsc: Introduce test TC_paging_resp_unsol .. Patch Set 1: Code-Review+1 What about 'bsc/expected-results.xml'? -- To

Change in osmo-bsc[master]: gsm0408_rcvmsg: Release lchan if L3 fails to complete

2018-11-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11606 ) Change subject: gsm0408_rcvmsg: Release lchan if L3 fails to complete .. Patch Set 1: Code-Review-1 (2 comments)

Change in osmo-bsc[master]: bsc: gsm0808: Fix return code in bsc_compl_l3

2018-11-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11605 ) Change subject: bsc: gsm0808: Fix return code in bsc_compl_l3 .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmocom-bb[master]: layer23: Avoid mempcy with NULL src

2018-11-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11610 ) Change subject: layer23: Avoid mempcy with NULL src .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11610 To

Change in osmocom-bb[master]: layer23: Fix build against gpsd >= 3.18

2018-11-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11609 ) Change subject: layer23: Fix build against gpsd >= 3.18 .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmocom-bb[master]: cosmetic: fix trailing whitespace

2018-11-05 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11608 ) Change subject: cosmetic: fix trailing whitespace .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11608 To

Change in osmocom-bb[master]: layer23: Avoid mempcy with NULL src

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11610 Change subject: layer23: Avoid mempcy with NULL src .. layer23: Avoid mempcy with NULL src Fixes following ASan warning:

Change in osmocom-bb[master]: cosmetic: fix trailing whitespace

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11608 Change subject: cosmetic: fix trailing whitespace .. cosmetic: fix trailing whitespace Change-Id:

Change in osmocom-bb[master]: layer23: Fix build against gpsd >= 3.18

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11609 Change subject: layer23: Fix build against gpsd >= 3.18 .. layer23: Fix build against gpsd >= 3.18 Change-Id:

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add missing tr_BSSMAP_HandoverPerformed template

2018-11-05 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11607 Change subject: BSSMAP_Templates: Add missing tr_BSSMAP_HandoverPerformed template .. BSSMAP_Templates: Add missing tr_BSSMAP_HandoverPerformed

Change in osmo-bsc[master]: gsm0408_rcvmsg: Release lchan if L3 fails to complete

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11606 Change subject: gsm0408_rcvmsg: Release lchan if L3 fails to complete .. gsm0408_rcvmsg: Release lchan if L3 fails to complete

Change in osmo-bsc[master]: bsc: gsm0808: Fix return code in bsc_compl_l3

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11605 Change subject: bsc: gsm0808: Fix return code in bsc_compl_l3 .. bsc: gsm0808: Fix return code in bsc_compl_l3 complete_layer3 returns

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_resp_unsol

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11604 Change subject: bsc: Introduce test TC_paging_resp_unsol .. bsc: Introduce test TC_paging_resp_unsol With this test we want to verify

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #298

2018-11-05 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Change in osmo-ci[master]: TTCN-3: add PCU tests

2018-11-05 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11603 Change subject: TTCN-3: add PCU tests .. TTCN-3: add PCU tests Change-Id: Ifee0373cd920e80486cb40cb872f2be1e736ef06 Related: OS#2890 --- M

Change in osmo-bsc[master]: gsm_data: make cgi_for_msc available for other modules

2018-11-05 Thread dexter
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11527 to look at the new patch set (#2). Change subject: gsm_data: make cgi_for_msc available for other modules

Change in libosmocore[master]: Fix deprecation warning in gsm0808_test

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11602 ) Change subject: Fix deprecation warning in gsm0808_test .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11602/1//COMMIT_MSG

Change in libosmocore[master]: Fix deprecation warning in gsm0808_test

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11602 ) Change subject: Fix deprecation warning in gsm0808_test .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: Fix deprecation warning in gsm0808_test

2018-11-05 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11602 ) Change subject: Fix deprecation warning in gsm0808_test .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11602 To unsubscribe,

Change in libosmocore[master]: Update 3GPP TS 08.08 Cause handling

2018-11-05 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11577 ) Change subject: Update 3GPP TS 08.08 Cause handling .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11577 To unsubscribe, or

Change in libosmocore[master]: Support cipher mode reject with extended cause

2018-11-05 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11601 ) Change subject: Support cipher mode reject with extended cause .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11601 To

Change in osmo-gsm-tester[master]: ms_driver: Allow to specify env and binary name/path

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11596 ) Change subject: ms_driver: Allow to specify env and binary name/path .. Patch Set 1: test is failing with following error: ---

Change in osmo-ci[master]: ttcn3-testsuites: replace manually generated jobs

2018-11-05 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11600 ) Change subject: ttcn3-testsuites: replace manually generated jobs .. ttcn3-testsuites: replace manually generated jobs Let all TTCN3

Change in osmo-dev[master]: replace src/* git scripts with a single src/gits

2018-11-05 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11560 ) Change subject: replace src/* git scripts with a single src/gits .. Patch Set 4: Code-Review-1 (19 comments)

Change in osmo-ci[master]: ttcn3-testsuites: replace manually generated jobs

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11600 ) Change subject: ttcn3-testsuites: replace manually generated jobs .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: ttcn3-testsuites: replace manually generated jobs

2018-11-05 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11600 ) Change subject: ttcn3-testsuites: replace manually generated jobs .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11600

Change in osmo-ttcn3-hacks[master]: BSC LCLS: add bts-loop tests

2018-11-05 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11559 ) Change subject: BSC LCLS: add bts-loop tests .. Patch Set 3: Not sure how ATM. So far the plan is to implement MSC side and test with real hw, than

Change in libosmocore[master]: Update 3GPP TS 08.08 Cause handling

2018-11-05 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11577 ) Change subject: Update 3GPP TS 08.08 Cause handling .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11577 To unsubscribe, or

Change in osmo-ttcn3-hacks[master]: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11562 ) Change subject: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL .. Patch Set 3: (1 comment)

Change in osmo-gsm-tester[master]: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11580 ) Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH .. Patch Set 2: Code-Review+1 (2 comments)

Change in osmo-gsm-tester[master]: suits: Add an initial test for the ms_driver

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10687 ) Change subject: suits: Add an initial test for the ms_driver .. Patch Set 8: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: ms_driver: Consult the suite to get the binaries

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11599 ) Change subject: ms_driver: Consult the suite to get the binaries .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: ms_driver: Switch to process.Process from subprocess

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11597 ) Change subject: ms_driver: Switch to process.Process from subprocess .. Patch Set 1: Code-Review-1 (2 comments)

Change in osmo-ci[master]: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs

2018-11-05 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11370 ) Change subject: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs .. Patch Set 5: > if you're not overwriting the manual jobs, have you tested that

Change in osmo-gsm-tester[master]: ms_driver: Allow to specify env and binary name/path

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11596 ) Change subject: ms_driver: Allow to specify env and binary name/path .. Patch Set 1: (1 comment)

Change in osmo-ci[master]: ttcn3-testsuites: replace manually generated jobs

2018-11-05 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11600 ) Change subject: ttcn3-testsuites: replace manually generated jobs .. Patch Set 1: Verified+1 This is rolled out on Jenkins. Follow up to:

Change in osmo-ci[master]: ttcn3-testsuites: replace manually generated jobs

2018-11-05 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11600 Change subject: ttcn3-testsuites: replace manually generated jobs .. ttcn3-testsuites: replace manually generated jobs Let all TTCN3 related

Change in osmo-gsm-tester[master]: ms_driver: Initialize event_server_sk_tmp_dira in ctor

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11594 ) Change subject: ms_driver: Initialize event_server_sk_tmp_dira in ctor .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: ms_driver: Use terminate not kill and initialize in ctor

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11595 ) Change subject: ms_driver: Use terminate not kill and initialize in ctor .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: ms_driver: Initialize event_server_sk_tmp_dira in ctor

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11594 ) Change subject: ms_driver: Initialize event_server_sk_tmp_dira in ctor .. Patch Set 1: (1 comment)

Change in osmo-sip-connector[master]: configure.ac: add --enable-sanitize

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11592 ) Change subject: configure.ac: add --enable-sanitize .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11592

Change in osmo-ci[master]: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs

2018-11-05 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11370 ) Change subject: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs .. jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs New JJB config, that

Change in osmo-sip-connector[master]: configure.ac: add --enable-sanitize

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11592 ) Change subject: configure.ac: add --enable-sanitize .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11592/1//COMMIT_MSG

Change in osmo-ci[master]: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs

2018-11-05 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11370 ) Change subject: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/11370 To

Change in osmo-dev[master]: sanitize.opts: add --enable-sanitize to ALL builds

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11593 ) Change subject: sanitize.opts: add --enable-sanitize to ALL builds .. Patch Set 1: You probably don't want to enable sanitize in

Change in docker-playground[master]: ttcn3-bts-test: Log RACH requests in GSMTAP

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11567 ) Change subject: ttcn3-bts-test: Log RACH requests in GSMTAP .. ttcn3-bts-test: Log RACH requests in GSMTAP Change-Id:

Change in docker-playground[master]: ttcn3-bts-test: Log RACH requests in GSMTAP

2018-11-05 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11567 ) Change subject: ttcn3-bts-test: Log RACH requests in GSMTAP .. Patch Set 1: Verified+1 -- To view, visit

Change in osmo-ci[master]: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs

2018-11-05 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11370 ) Change subject: jobs: ttcn3-testsuites.yml for ttcn3/nplab jobs .. Patch Set 4: Code-Review+1 That's exactly the thing I've been looking for - will