Change in osmo-bsc[master]: bsc: band_compatible: Return band non-compatible for invalid arfcn

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11790 ) Change subject: bsc: band_compatible: Return band non-compatible for invalid arfcn .. Patch Set 2: > > Uploaded patch set 2. > > I

Change in osmocom-bb[master]: mobile: add function to show active calls

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11818 ) Change subject: mobile: add function to show active calls .. Patch Set 1: (1 comment)

Change in osmocom-bb[master]: mobile: use proper type for boolean flags

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11817 ) Change subject: mobile: use proper type for boolean flags .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmocom-bb[master]: mobile: add header for MS' MNCC functions

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11816 ) Change subject: mobile: add header for MS' MNCC functions .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmocom-bb[master]: mobile: use proper type for boolean flags

2018-11-16 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11817 Change subject: mobile: use proper type for boolean flags .. mobile: use proper type for boolean flags This makes reading code easier and simplifies

Change in osmocom-bb[master]: mobile: add function to show active calls

2018-11-16 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11818 Change subject: mobile: add function to show active calls .. mobile: add function to show active calls Change-Id:

Change in osmocom-bb[master]: mobile: add header for MS' MNCC functions

2018-11-16 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11816 Change subject: mobile: add header for MS' MNCC functions .. mobile: add header for MS' MNCC functions This simplifies adding new functions and

Change in osmo-bsc[master]: bsc: band_compatible: Return band non-compatible for invalid arfcn

2018-11-16 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11790 ) Change subject: bsc: band_compatible: Return band non-compatible for invalid arfcn .. Patch Set 2: > Uploaded patch set 2. I read adding

Change in osmo-bsc[master]: LCLS: make config and control redable in 'sh conns'

2018-11-16 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11815 Change subject: LCLS: make config and control redable in 'sh conns' .. LCLS: make config and control redable in 'sh conns' Display LCLS config and

Change in osmocom-bb[master]: mobile: log socket path on error

2018-11-16 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11812 Change subject: mobile: log socket path on error .. mobile: log socket path on error Change-Id: I18eb46743e4c0e4e8f8032883f39fec355f03c78 --- M

Change in osmocom-bb[master]: l1l2 interface: use LOGP for socket errors

2018-11-16 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11814 Change subject: l1l2 interface: use LOGP for socket errors .. l1l2 interface: use LOGP for socket errors Log via LOGP() like the rest of the file

Change in osmocom-bb[master]: osmocon: log error cause for socket opening

2018-11-16 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11813 Change subject: osmocon: log error cause for socket opening .. osmocon: log error cause for socket opening Change-Id:

Change in osmo-dev[master]: Add expect script: 'vty' for easy access to all vtys

2018-11-16 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11811 ) Change subject: Add expect script: 'vty' for easy access to all vtys .. Patch Set 2: > Uploaded patch set 2. I wonder is this of any use..

Change in osmo-dev[master]: Add expect script: 'vty' for easy access to all vtys

2018-11-16 Thread Keith Whyte
Keith Whyte has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/11811 ) Change subject: Add expect script: 'vty' for easy access to all vtys .. Add expect script: 'vty' for easy access to all vtys This expect

Change in osmo-dev[master]: Add expect script: 'vty' for easy access to all vtys

2018-11-16 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/11811 Change subject: Add expect script: 'vty' for easy access to all vtys .. Add expect script: 'vty' for easy access to all vtys This expect

Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

2018-11-16 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11792 ) Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it. .. Patch Set 3: > Ahh, sorry :/ For some reason, I

Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

2018-11-16 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11792 ) Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it. .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: vlr: drop unused is_ps parameter in vlr_subscr_req_lu()

2018-11-16 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/11761 ) Change subject: vlr: drop unused is_ps parameter in vlr_subscr_req_lu() .. vlr: drop unused is_ps parameter in vlr_subscr_req_lu() the

Change in libosmocore[master]: fsm: fix apidoc of osmo_fsm_state_name()

2018-11-16 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/11808 ) Change subject: fsm: fix apidoc of osmo_fsm_state_name() .. fsm: fix apidoc of osmo_fsm_state_name() The api documentation of

Change in libosmocore[master]: gsm29118: add value strings for SGSAP IEI

2018-11-16 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/11780 ) Change subject: gsm29118: add value strings for SGSAP IEI .. gsm29118: add value strings for SGSAP IEI The value strings for the SGSAP

Change in osmo-dev[master]: fill_config.py: add ${foreach(FOO)}

2018-11-16 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11810 Change subject: fill_config.py: add ${foreach(FOO)} .. fill_config.py: add ${foreach(FOO)} This patch indicates that we should rather use a

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: make VTY interface available

2018-11-16 Thread dexter
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11701 to look at the new patch set (#4). Change subject: BSC_ConnectionHandler: make VTY interface available

Change in osmo-ttcn3-hacks[master]: BSC: log BTS number on failure

2018-11-16 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11809 Change subject: BSC: log BTS number on failure .. BSC: log BTS number on failure It's useful to see which BTS exactly has failed the test in

Change in osmo-trx[master]: UHDDevice: setRxGain on chan 0 when using multi-arfcn

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11571 ) Change subject: UHDDevice: setRxGain on chan 0 when using multi-arfcn .. Patch Set 2: Great, but that ws is still there, please see my

Change in libosmocore[master]: fsm: fix apidoc of osmo_fsm_state_name()

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11808 ) Change subject: fsm: fix apidoc of osmo_fsm_state_name() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-manuals[master]: cosmetic: update usage of OSMO_GSM_MANUALS_DIR

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11806 ) Change subject: cosmetic: update usage of OSMO_GSM_MANUALS_DIR .. Patch Set 2: You probably want to move this as a fixup of another

Change in osmo-gsm-manuals[master]: remove project specific files

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11738 ) Change subject: remove project specific files .. Patch Set 5: I'd personally remove them one by one as they are moved to its own repo,

Change in osmo-gsm-manuals[master]: publish from project repos, not this repo anymore

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11740 ) Change subject: publish from project repos, not this repo anymore .. Patch Set 2: (1 comment)

Change in libosmocore[master]: fsm: fix apidoc of osmo_fsm_state_name()

2018-11-16 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11808 Change subject: fsm: fix apidoc of osmo_fsm_state_name() .. fsm: fix apidoc of osmo_fsm_state_name() The api documentation of osmo_fsm_state_name()

Change in osmo-gsm-manuals[master]: copy NITB's osmobsc-usermanual.adoc to OsmoBSC

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11805 ) Change subject: copy NITB's osmobsc-usermanual.adoc to OsmoBSC .. Patch Set 1: Code-Review+1 You could also move it to common/, but

Change in osmo-gsm-manuals[master]: *.adoc: use {srcdir} for out-of-tree builds

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11804 ) Change subject: *.adoc: use {srcdir} for out-of-tree builds .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: Makefile.*.inc: adjust to out-of-tree building

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11803 ) Change subject: Makefile.*.inc: adjust to out-of-tree building .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: Osmo*/Makefile.am: use $(srcdir)

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11802 ) Change subject: Osmo*/Makefile.am: use $(srcdir) .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-gsm-manuals[master]: vty_reference_combine.sh: add *reference.xml arg

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11801 ) Change subject: vty_reference_combine.sh: add *reference.xml arg .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: vty_reference_combine.sh: add *reference.xml arg

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11801 ) Change subject: vty_reference_combine.sh: add *reference.xml arg .. Patch Set 1: (1 comment)

Change in osmo-gsm-manuals[master]: Osmo*/Makefile.am: use $(srcdir)

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11802 ) Change subject: Osmo*/Makefile.am: use $(srcdir) .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11802/1//COMMIT_MSG Commit

Change in osmo-gsm-manuals[master]: vty_reference_combine.sh: add *reference.xml arg

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11801 ) Change subject: vty_reference_combine.sh: add *reference.xml arg .. Patch Set 1: (1 comment)

Change in osmo-gsm-manuals[master]: *-vty-reference.xml: use ./common, not ../common

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11800 ) Change subject: *-vty-reference.xml: use ./common, not ../common .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: *.adoc: include from ./common, not ../common

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11799 ) Change subject: *.adoc: include from ./common, not ../common .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: *filter.conf/*.sty: use symlinks to build, common

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11798 ) Change subject: *filter.conf/*.sty: use symlinks to build, common .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: use autotools to add "make install" target

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11725 ) Change subject: use autotools to add "make install" target .. Patch Set 5: (1 comment)

Change in osmo-gsm-manuals[master]: prepare for autotools: add git-version-gen

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11797 ) Change subject: prepare for autotools: add git-version-gen .. Patch Set 1: Code-Review+1 Worth checking if we do modifications to the

Change in osmo-gsm-manuals[master]: s/TOPDIR/OSMO_GSM_MANUALS_DIR/g

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11796 ) Change subject: s/TOPDIR/OSMO_GSM_MANUALS_DIR/g .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11796 To

Change in osmo-gsm-manuals[master]: tests: add shared content pdf build tests

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11795 ) Change subject: tests: add shared content pdf build tests .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: make check: properly reference dependencies

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11794 ) Change subject: make check: properly reference dependencies .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-ttcn3-hacks[master]: WIP: MSC_Tests: extend SGSAP testcases

2018-11-16 Thread dexter
dexter has abandoned this change. ( https://gerrit.osmocom.org/11702 ) Change subject: WIP: MSC_Tests: extend SGSAP testcases .. Abandoned fixed up into I38543c35a9e74cea276e58d1d7ef01ef07ffe858 -- To view, visit

Change in osmo-trx[master]: UHDDevice: setRxGain on chan 0 when using multi-arfcn

2018-11-16 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11571 to look at the new patch set (#2). Change subject: UHDDevice: setRxGain on chan 0 when using multi-arfcn ..

Change in osmo-gsm-manuals[master]: jenkins.sh: do not use libosomcore source

2018-11-16 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11793 ) Change subject: jenkins.sh: do not use libosomcore source .. jenkins.sh: do not use libosomcore source Build scripts do not depend on the

Change in osmo-dev[master]: gits: fix MODS marks by timestamp-only changes

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11807 Change subject: gits: fix MODS marks by timestamp-only changes .. gits: fix MODS marks by timestamp-only changes Use 'git diff' instead of 'git

Change in osmo-bts[master]: add missing check of osmo_wqueue_enqueue() return value

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11783 ) Change subject: add missing check of osmo_wqueue_enqueue() return value .. Patch Set 1: (1 comment)

Change in osmo-trx[master]: UHDDevice: setRxGain on chan 0 when using multi-arfcn

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11571 ) Change subject: UHDDevice: setRxGain on chan 0 when using multi-arfcn .. Patch Set 1: (1 comment) I don't think 'Same check is done in

Change in osmo-gsm-manuals[master]: jenkins.sh: do not use libosomcore source

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11793 ) Change subject: jenkins.sh: do not use libosomcore source .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: ChannelizerBase: Fix ASan alloc-dealloc-mismatch

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11570 ) Change subject: ChannelizerBase: Fix ASan alloc-dealloc-mismatch .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-bsc[master]: bsc: band_compatible: Return band non-compatible for invalid arfcn

2018-11-16 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11790 to look at the new patch set (#2). Change subject: bsc: band_compatible: Return band non-compatible for invalid arfcn

Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11792 ) Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it. .. Patch Set 3: Ahh, sorry :/ For some reason, I

Change in osmo-bts[master]: add missing check of osmo_wqueue_enqueue() return value

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11783 ) Change subject: add missing check of osmo_wqueue_enqueue() return value .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: add missing 'break' in switch statement

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11781 ) Change subject: add missing 'break' in switch statement .. Patch Set 2: Code-Review+1 -- To view, visit

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #309

2018-11-16 Thread jenkins
See -- [...truncated 3.74 KB...] checking build system type... x86_64-unknown-linux-gnu checking host system type...

Change in osmo-gsm-manuals[master]: remove project specific files

2018-11-16 Thread osmith
Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11738 to look at the new patch set (#5). Change subject: remove project specific files ..

Change in osmo-gsm-manuals[master]: use autotools to add "make install" target

2018-11-16 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11725 ) Change subject: use autotools to add "make install" target .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11725 To

Change in osmo-gsm-manuals[master]: *.adoc: use {srcdir} for out-of-tree builds

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11804 Change subject: *.adoc: use {srcdir} for out-of-tree builds .. *.adoc: use {srcdir} for out-of-tree builds Define a new {srcdir} variable in

Change in osmo-gsm-manuals[master]: cosmetic: update usage of OSMO_GSM_MANUALS_DIR

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11806 Change subject: cosmetic: update usage of OSMO_GSM_MANUALS_DIR .. cosmetic: update usage of OSMO_GSM_MANUALS_DIR OSMO_GSM_MANUALS_DIR should use

Change in osmo-gsm-manuals[master]: copy NITB's osmobsc-usermanual.adoc to OsmoBSC

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11805 Change subject: copy NITB's osmobsc-usermanual.adoc to OsmoBSC .. copy NITB's osmobsc-usermanual.adoc to OsmoBSC Includes from other projects don't

Change in osmo-gsm-manuals[master]: Osmo*/Makefile.am: use $(srcdir)

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11802 Change subject: Osmo*/Makefile.am: use $(srcdir) .. Osmo*/Makefile.am: use $(srcdir) Use $(srcdir) infront of all relative paths, which reference

Change in osmo-gsm-manuals[master]: prepare for autotools: add git-version-gen

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11797 Change subject: prepare for autotools: add git-version-gen .. prepare for autotools: add git-version-gen Add the latestest upstream version of

Change in osmo-gsm-manuals[master]: *.adoc: include from ./common, not ../common

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11799 Change subject: *.adoc: include from ./common, not ../common .. *.adoc: include from ./common, not ../common Change hardcoded ../common paths,

Change in osmo-gsm-manuals[master]: *-vty-reference.xml: use ./common, not ../common

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11800 Change subject: *-vty-reference.xml: use ./common, not ../common .. *-vty-reference.xml: use ./common, not ../common Change hardcoded ../common

Change in osmo-gsm-manuals[master]: make check: properly reference dependencies

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11794 Change subject: make check: properly reference dependencies .. make check: properly reference dependencies Use $(ASCIIDOC_DEPS) instead of assuming

Change in osmo-gsm-manuals[master]: tests: add shared content pdf build tests

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11795 Change subject: tests: add shared content pdf build tests .. tests: add shared content pdf build tests Build project independent

Change in osmo-gsm-manuals[master]: Makefile.*.inc: adjust to out-of-tree building

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11803 Change subject: Makefile.*.inc: adjust to out-of-tree building .. Makefile.*.inc: adjust to out-of-tree building Makefile.asciidoc.inc: create a

Change in osmo-gsm-manuals[master]: jenkins.sh: do not use libosomcore source

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11793 Change subject: jenkins.sh: do not use libosomcore source .. jenkins.sh: do not use libosomcore source Build scripts do not depend on the

Change in osmo-gsm-manuals[master]: vty_reference_combine.sh: add *reference.xml arg

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11801 Change subject: vty_reference_combine.sh: add *reference.xml arg .. vty_reference_combine.sh: add *reference.xml arg Pass the path to

Change in osmo-gsm-manuals[master]: publish from project repos, not this repo anymore

2018-11-16 Thread osmith
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11740 to look at the new patch set (#2). Change subject: publish from project repos, not this repo anymore

Change in osmo-gsm-manuals[master]: s/TOPDIR/OSMO_GSM_MANUALS_DIR/g

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11796 Change subject: s/TOPDIR/OSMO_GSM_MANUALS_DIR/g .. s/TOPDIR/OSMO_GSM_MANUALS_DIR/g Replace TOPDIR with OSMO_GSM_MANUALS_DIR. When the project

Change in osmo-gsm-manuals[master]: *filter.conf/*.sty: use symlinks to build, common

2018-11-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11798 Change subject: *filter.conf/*.sty: use symlinks to build, common .. *filter.conf/*.sty: use symlinks to build, common $(OSMO_GSM_MANUALS_DIR) is

Change in osmo-gsm-manuals[master]: remove project specific files

2018-11-16 Thread osmith
Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11738 to look at the new patch set (#4). Change subject: remove project specific files ..

Change in osmo-msc[master]: move project specific manuals to their own repos

2018-11-16 Thread osmith
Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11726 to look at the new patch set (#2). Change subject: move project specific manuals to their own repos

Change in osmo-bts[master]: properly initialize si3 in test_is_ccch_for_agch_setup()

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11784 ) Change subject: properly initialize si3 in test_is_ccch_for_agch_setup() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11789 ) Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc .. Patch Set 1: > Sorry, but I don't think it

Change in libosmocore[master]: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11789 ) Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc .. Patch Set 1: Code-Review-1 Sorry, but I

Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11792 ) Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it. .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11792 ) Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it. .. Patch Set 3: (1 comment)

Change in libosmocore[master]: gsm48: gsm48_decode_freq_list: Improve documentation of paramter f

2018-11-16 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11785 ) Change subject: gsm48: gsm48_decode_freq_list: Improve documentation of paramter f .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: bsc: vty: Verify and warn on invalid arfcn passed

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11791 ) Change subject: bsc: vty: Verify and warn on invalid arfcn passed .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: bsc: band_compatible: Return band non-compatible for invalid arfcn

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11790 ) Change subject: bsc: band_compatible: Return band non-compatible for invalid arfcn .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: bsc: band_compatible: Return band non-compatible for invalid arfcn

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11790 ) Change subject: bsc: band_compatible: Return band non-compatible for invalid arfcn .. Patch Set 1: (1 comment)

Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

2018-11-16 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/11792 ) Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it. .. Patch Set 3: (1 comment)

Change in osmo-bsc[master]: bsc: bts_alloc: Use enum value during neigh_list_manual_mode initiali...

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11775 ) Change subject: bsc: bts_alloc: Use enum value during neigh_list_manual_mode initialization .. Patch Set 3: Code-Review+1 -- To view,

Change in osmo-bsc[master]: bsc: vty: Use enum value in neighbor-list check

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11778 ) Change subject: bsc: vty: Use enum value in neighbor-list check .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: examples: Remove neighbor-list invalid for default setup

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11774 ) Change subject: examples: Remove neighbor-list invalid for default setup .. Patch Set 3: Code-Review+1 In general, it would be great to

Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

2018-11-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11792 ) Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it. .. Patch Set 3: Code-Review+1 (1 comment) Looks

Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

2018-11-16 Thread Keith Whyte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11792 to look at the new patch set (#3). Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

2018-11-16 Thread Keith Whyte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11792 to look at the new patch set (#2). Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it.

Change in osmo-msc[master]: libmsc: Don't send SMS STATUS REPORT locally if ESME accepted it

2018-11-16 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/11792 Change subject: libmsc: Don't send SMS STATUS REPORT locally if ESME accepted it .. libmsc: Don't send SMS STATUS REPORT locally if ESME

Change in osmo-bsc[master]: bsc: band_compatible: Return band non-compatible for invalid arfcn

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11790 ) Change subject: bsc: band_compatible: Return band non-compatible for invalid arfcn .. Patch Set 1: Fails from here du to dependent

Change in osmo-bsc[master]: bsc: vty: Verify and warn on invalid arfcn passed

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11791 Change subject: bsc: vty: Verify and warn on invalid arfcn passed .. bsc: vty: Verify and warn on invalid arfcn passed Related: OS#3063

Change in osmo-bsc[master]: bsc: band_compatible: Return band non-compatible for invalid arfcn

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11790 Change subject: bsc: band_compatible: Return band non-compatible for invalid arfcn .. bsc: band_compatible: Return band non-compatible

Change in libosmocore[master]: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11789 Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc .. gsm: Deprecate buggy gsm_arfcn2band API and

Change in libosmocore[master]: add contrib/struct_endianess.py

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11786 ) Change subject: add contrib/struct_endianess.py .. Patch Set 2: Code-Review-1 -1 see reason in next patch. -- To view, visit

Change in libosmocore[master]: add/clean big-endian packed structs (struct_endianess.py)

2018-11-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11787 ) Change subject: add/clean big-endian packed structs (struct_endianess.py) .. Patch Set 2: Code-Review-1 (2 comments)

  1   2   >