Change in osmo-ttcn3-hacks[master]: msc: TC_gsup_cancel: end with f_expect_clear() to avoid broken pipe

2019-03-13 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13187 ) Change subject: msc: TC_gsup_cancel: end with f_expect_clear() to avoid broken pipe .. msc: TC_gsup_cancel: end with

Change in osmo-ttcn3-hacks[master]: msc: add codec to all Assignment Complete messages

2019-03-13 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13186 ) Change subject: msc: add codec to all Assignment Complete messages .. msc: add codec to all Assignment Complete messages So far we

Change in osmo-bsc[master]: log N-CONNECT from MSC

2019-03-13 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13228 ) Change subject: log N-CONNECT from MSC .. log N-CONNECT from MSC Change-Id: I83f15c7231b2b766aba4d25339d08acbbca3a47e --- M

Change in osmo-bsc[master]: incoming connect: don't crash if calling addr is missing

2019-03-13 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13227 ) Change subject: incoming connect: don't crash if calling addr is missing .. incoming connect: don't crash if calling addr is

Change in libosmocore[master]: osmo_gsm48_classmark_a5_name(): fix 'no-cm3' label

2019-03-13 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13207 ) Change subject: osmo_gsm48_classmark_a5_name(): fix 'no-cm3' label .. osmo_gsm48_classmark_a5_name(): fix 'no-cm3' label

Change in libosmo-sccp[master]: improve logging for rejected AS in xua_rkm.c

2019-03-13 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13229 ) Change subject: improve logging for rejected AS in xua_rkm.c .. improve logging for rejected AS in xua_rkm.c Change a loglevel

Change in osmo-bsc[master]: Move LCLS references from gsm_data to osmo_bsc_lcls

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13220 ) Change subject: Move LCLS references from gsm_data to osmo_bsc_lcls .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: ipaccess/Makefile.am: Remove unneeded libmgcp-client dep

2019-03-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13218 ) Change subject: ipaccess/Makefile.am: Remove unneeded libmgcp-client dep .. ipaccess/Makefile.am: Remove unneeded libmgcp-client dep

Change in osmo-bsc[master]: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13223 ) Change subject: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: I'm not sure with what the "no-install" LDFLAGS do, and I

Change in osmo-dev[master]: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13235 ) Change subject: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmo-sccp[master]: Fix output of route destination in 'show ss7 instance <0-15> route'

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13233 ) Change subject: Fix output of route destination in 'show ss7 instance <0-15> route' .. Patch Set 1: (1 comment)

Change in libosmo-sccp[master]: vty: Ensure to properly save route pointcode and mask when writing

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13232 ) Change subject: vty: Ensure to properly save route pointcode and mask when writing .. Patch Set 2: (1 comment)

Change in libosmo-sccp[master]: vty: Ensure to properly save route pointcode and mask when writing

2019-03-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13232 ) Change subject: vty: Ensure to properly save route pointcode and mask when writing .. vty: Ensure to properly save route pointcode

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: assignment_fsm: Properly support assigning signalling mode TCH/x

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13172 ) Change subject: assignment_fsm: Properly support assigning signalling mode TCH/x .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (3 comments)

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-13 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (8 comments) Tx for the review, will fix that

Change in osmo-ttcn3-hacks[master]: ggsn: add tests to validate IPv4v6 pdp ctx

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13231 ) Change subject: ggsn: add tests to validate IPv4v6 pdp ctx .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13231 To

Change in osmo-ttcn3-hacks[master]: ggsn: add tests to validate IPv4v6 pdp ctx

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13231 ) Change subject: ggsn: add tests to validate IPv4v6 pdp ctx .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 7: (1 comment)

Change in osmo-pcu[master]: TBF: update MCS counters

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13243 ) Change subject: TBF: update MCS counters .. Patch Set 1: (1 comment) This change is ready for review.

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (6 comments)

Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 7: (1 comment)

Change in osmo-pcu[master]: MCS: remove unused function

2019-03-13 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13239 ) Change subject: MCS: remove unused function .. MCS: remove unused function Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b --- M

Change in gr-gsm[master]: Fix the TCH/H decoder XML definition

2019-03-13 Thread Vasil Velichkov
Vasil Velichkov has posted comments on this change. ( https://gerrit.osmocom.org/13246 ) Change subject: Fix the TCH/H decoder XML definition .. Patch Set 1: The problem was reported in

Change in osmo-bsc[master]: osmo_bsc_msc: Use meaningful amr rate configuration on BTS level

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13092 ) Change subject: osmo_bsc_msc: Use meaningful amr rate configuration on BTS level .. Patch Set 6: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: codec_pref: fix special handling for AMR rate configuration (S15-S0)

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13093 ) Change subject: codec_pref: fix special handling for AMR rate configuration (S15-S0) .. Patch Set 8: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13236 ) Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add testcases to verify S15-S0 handling

2019-03-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13237 ) Change subject: BSC_Tests: add testcases to verify S15-S0 handling .. Patch Set 2: Code-Review+2 -- To view, visit

Change in gr-gsm[master]: Fix the TCH/H decoder XML definition

2019-03-13 Thread Vasil Velichkov
Hello Piotr Krysik, Vadim Yanitskiy, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/13246 to review the following change. Change subject: Fix the TCH/H decoder XML definition .. Fix the TCH/H

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13236 ) Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 7: Code-Review+1 (1 comment)

Change in osmo-bsc[master]: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13223 ) Change subject: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps .. Patch Set 2: (1 comment)

Change in libosmo-sccp[master]: improve logging for rejected AS in xua_rkm.c

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13229 ) Change subject: improve logging for rejected AS in xua_rkm.c .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: Fix TA index encoder

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13238 ) Change subject: Fix TA index encoder .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13238 To unsubscribe,

Change in osmo-pcu[master]: MCS: remove unused function

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13239 ) Change subject: MCS: remove unused function .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13239 To

Change in osmo-pcu[master]: Debian: bump copyright year

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13240 ) Change subject: Debian: bump copyright year .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13240 To

Change in osmo-pcu[master]: MCS: move Mode enum outside of class definition

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13163 ) Change subject: MCS: move Mode enum outside of class definition .. Patch Set 4: (3 comments)

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (2 comments)

Change in osmo-pcu[master]: Update IA Rest Octets encoding

2019-03-13 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13245 Change subject: Update IA Rest Octets encoding .. Update IA Rest Octets encoding Write initial bits of 3GPP TS 44.018 ยง10.5.2.16 IA Rest Octets the

Change in osmo-pcu[master]: Debian: bump copyright year

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13240 ) Change subject: Debian: bump copyright year .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/13240/1/debian/copyright File

Change in osmo-pcu[master]: TBF-DL: cosmetic update for helper routines

2019-03-13 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13244 Change subject: TBF-DL: cosmetic update for helper routines .. TBF-DL: cosmetic update for helper routines * use enum values where appropriate *

Change in osmo-pcu[master]: TBF: update MCS counters

2019-03-13 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13243 Change subject: TBF: update MCS counters .. TBF: update MCS counters * use enum CodingScheme directly instead of converting it to class and back *

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-13 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/13242 Change subject: libmsc: Allow different channel types to be requested as silent calls .. libmsc: Allow different channel types to be requested as

Change in osmo-bsc[master]: codec_pref: fix special handling for AMR rate configuration (S15-S0)

2019-03-13 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13093 to look at the new patch set (#8). Change subject: codec_pref: fix special handling for AMR rate configuration (S15-S0)

Change in osmo-bsc[master]: lchan_fsm: make sure multi rate configuration is valid

2019-03-13 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13094 to look at the new patch set (#8). Change subject: lchan_fsm: make sure multi rate configuration is valid

Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC

2019-03-13 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13199 to look at the new patch set (#8). Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC

Change in osmo-bsc[master]: lchan_fsm: do not include 12.2k in active set on HR channels

2019-03-13 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13095 to look at the new patch set (#8). Change subject: lchan_fsm: do not include 12.2k in active set on HR channels

Change in osmo-bsc[master]: osmo_bsc_msc: Use meaningful amr rate configuration on BTS level

2019-03-13 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13092 to look at the new patch set (#6). Change subject: osmo_bsc_msc: Use meaningful amr rate configuration on BTS level

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add testcases to verify S15-S0 handling

2019-03-13 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13237 to look at the new patch set (#2). Change subject: BSC_Tests: add testcases to verify S15-S0 handling .. BSC_Tests:

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h

2019-03-13 Thread dexter
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13236 to look at the new patch set (#2). Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h ..

Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC

2019-03-13 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13199 to look at the new patch set (#7). Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC

Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC

2019-03-13 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13199 ) Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC .. Patch Set 6: > mgw_endpoint_fsm.c: In function

Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: > On stream_stream_test_LDFLAGS there is an

Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag

2019-03-13 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: On stream_stream_test_LDFLAGS there is an

Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag

2019-03-13 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: Verified+1 Code-Review+1 > Worked for me too. I'm still puzzled

Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 7: (4 comments)

Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: amr_test: add to .gitignore, use -noinstall flag .. Patch Set 1: Code-Review+1 Worked for me too. I'm still puzzled why it doesn't

Change in osmo-pcu[master]: MCS: remove unused function

2019-03-13 Thread Max
Hello Pau Espin Pedrol, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13239 to look at the new patch set (#2). Change subject: MCS: remove unused function .. MCS: remove unused

Change in osmo-pcu[master]: Debian: bump copyright year

2019-03-13 Thread Max
Hello Pau Espin Pedrol, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13240 to look at the new patch set (#2). Change subject: Debian: bump copyright year .. Debian: bump copyright

Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

2019-03-13 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13067 to look at the new patch set (#7). Change subject: MCS: move HeaderType enum outside of class definition .. MCS:

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13236 ) Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h .. Patch Set 1: Code-Review+1 (1 comment)

Change in libosmo-netif[master]: amr_test: add to .gitignore, use -noinstall flag

2019-03-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13241 Change subject: amr_test: add to .gitignore, use -noinstall flag .. amr_test: add to .gitignore, use -noinstall flag Do not link the test against

Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13199 ) Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC .. Patch Set 6: mgw_endpoint_fsm.c: In function

Change in osmo-dev[master]: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage

2019-03-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13235 ) Change subject: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: ipaccess/Makefile.am: Remove unneeded libosmo-sigtran dep

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13219 ) Change subject: ipaccess/Makefile.am: Remove unneeded libosmo-sigtran dep .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: Move msc related code from gsm_data to bsc_msc

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13221 ) Change subject: Move msc related code from gsm_data to bsc_msc .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13221 To

Change in osmo-bsc[master]: configure.ac: Add flag to enable/disable build of ipaccess related utils

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13222 ) Change subject: configure.ac: Add flag to enable/disable build of ipaccess related utils .. Patch Set 2: Is there particular use-case or setup where

Change in osmo-bsc[master]: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13223 ) Change subject: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps .. Patch Set 2: (1 comment)

Change in osmo-bsc[master]: Move LCLS references from gsm_data to osmo_bsc_lcls

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13220 ) Change subject: Move LCLS references from gsm_data to osmo_bsc_lcls .. Patch Set 1: Code-Review+1 I don't really get how moving stuff unrelated to

Change in osmo-bsc[master]: net_init.c: remove unneeded header

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13224 ) Change subject: net_init.c: remove unneeded header .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13224 To unsubscribe,

Change in osmo-ttcn3-hacks[master]: ggsn: add tests to validate IPv4v6 pdp ctx

2019-03-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13231 ) Change subject: ggsn: add tests to validate IPv4v6 pdp ctx .. Patch Set 1: (1 comment)

Change in osmo-ttcn3-hacks[master]: ggsn: add tests to validate IPv4v6 pdp ctx

2019-03-13 Thread osmith
Hello Pau Espin Pedrol, Daniel Willmann, Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13231 to look at the new patch set (#2). Change subject: ggsn: add tests to validate IPv4v6 pdp ctx

Change in libosmo-sccp[master]: improve logging for rejected AS in xua_rkm.c

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13229 ) Change subject: improve logging for rejected AS in xua_rkm.c .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13229 To

Change in osmo-bsc[master]: incoming connect: don't crash if calling addr is missing

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13227 ) Change subject: incoming connect: don't crash if calling addr is missing .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: log N-CONNECT from MSC

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13228 ) Change subject: log N-CONNECT from MSC .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13228 To unsubscribe, or for help

Change in libosmo-sccp[master]: Fix output of route destination in 'show ss7 instance <0-15> route'

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13233 ) Change subject: Fix output of route destination in 'show ss7 instance <0-15> route' .. Patch Set 1: (1 comment)

Change in libosmo-sccp[master]: Store + show remote ip/port in dynamically created ASPs

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13234 ) Change subject: Store + show remote ip/port in dynamically created ASPs .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: MCS: remove unused function

2019-03-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13239 ) Change subject: MCS: remove unused function .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13239 To unsubscribe, or

Change in osmo-pcu[master]: Debian: update copyright file

2019-03-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13240 ) Change subject: Debian: update copyright file .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/13240/1/debian/copyright

Change in libosmo-sccp[master]: vty: Ensure to properly save route pointcode and mask when writing

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13232 ) Change subject: vty: Ensure to properly save route pointcode and mask when writing .. Patch Set 2: Code-Review+2 (1 comment) I agree that *2() is

Change in osmo-ttcn3-hacks[master]: ggsn: add tests to validate IPv4v6 pdp ctx

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13231 ) Change subject: ggsn: add tests to validate IPv4v6 pdp ctx .. Patch Set 1: (1 comment)

Change in osmo-pcu[master]: Fix TA index encoder

2019-03-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13238 ) Change subject: Fix TA index encoder .. Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/13238 To

Change in osmo-pcu[master]: MCS: move Mode enum outside of class definition

2019-03-13 Thread Max
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13163 to look at the new patch set (#3). Change subject: MCS: move Mode enum outside of class definition

Change in osmo-pcu[master]: MCS: remove unused function

2019-03-13 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13239 Change subject: MCS: remove unused function .. MCS: remove unused function Change-Id: I32ab5ac36a0db90f2bea670b7684784b83a90b6b --- M

Change in osmo-pcu[master]: Debian: update copyright file

2019-03-13 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13240 Change subject: Debian: update copyright file .. Debian: update copyright file * add missing header * bump copyright year Change-Id:

Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

2019-03-13 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13067 to look at the new patch set (#6). Change subject: MCS: move HeaderType enum outside of class definition .. MCS:

Change in osmo-bsc[master]: codec_pref: fix special handling for AMR rate configuration (S15-S0)

2019-03-13 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13093 ) Change subject: codec_pref: fix special handling for AMR rate configuration (S15-S0) .. Set Ready For Review -- To view, visit

Change in osmo-pcu[master]: Fix TA index encoder

2019-03-13 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13238 Change subject: Fix TA index encoder .. Fix TA index encoder The TAI is described as { 0 | 1 < TIMING_ADVANCE_INDEX : bit (4) > } in 3GPP TS 44.018

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h

2019-03-13 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13236 Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h .. BSC_Tests: fix TC_assignment_codec_amr_f/h The testcase TC_assignment_codec_amr_f

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add testcases to verify S15-S0 handling

2019-03-13 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13237 Change subject: BSC_Tests: add testcases to verify S15-S0 handling .. BSC_Tests: add testcases to verify S15-S0 handling The handling of the AMR

Change in osmo-bsc[master]: lchan_fsm: make sure multi rate configuration is valid

2019-03-13 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13094 to look at the new patch set (#7). Change subject: lchan_fsm: make sure multi rate configuration is valid

Change in osmo-bsc[master]: lchan_fsm: do not include 12.2k in active set on HR channels

2019-03-13 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13095 to look at the new patch set (#7). Change subject: lchan_fsm: do not include 12.2k in active set on HR channels

Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC

2019-03-13 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13199 to look at the new patch set (#6). Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC

Change in libosmo-netif[master]: amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf

2019-03-13 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13211 ) Change subject: amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf .. amr: be sure result of osmo_amr_bwe_to_oa() fits into int

Change in libosmo-netif[master]: amr: cosmetic: correct sourcecode formatting

2019-03-13 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13210 ) Change subject: amr: cosmetic: correct sourcecode formatting .. amr: cosmetic: correct sourcecode formatting Change-Id:

Change in libosmo-netif[master]: amr: make buffer in osmo_amr_bwe_to_oa() static

2019-03-13 Thread dexter
dexter has abandoned this change. ( https://gerrit.osmocom.org/13212 ) Change subject: amr: make buffer in osmo_amr_bwe_to_oa() static .. Abandoned -- To view, visit https://gerrit.osmocom.org/13212 To unsubscribe, or for help

Change in osmo-dev[master]: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage

2019-03-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13235 Change subject: run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage .. run.sh: fix $TO_RAN_IP and $TO_RAN_IU_IP usage Add curly braces around both

  1   2   >