Change in osmo-pcu[master]: bts.h: always include C-headers

Max has posted comments on this change. ( https://gerrit.osmocom.org/13403 ) Change subject: bts.h: always include C-headers .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13403/1/src/bts.h File src/bts.h:

Change in osmo-pcu[master]: TBF: update MCS counters

Max has posted comments on this change. ( https://gerrit.osmocom.org/13243 ) Change subject: TBF: update MCS counters .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/13243 To

Change in osmo-pcu[master]: Rewrite Packet Uplink IA Rest Octets for SBA

Max has posted comments on this change. ( https://gerrit.osmocom.org/12955 ) Change subject: Rewrite Packet Uplink IA Rest Octets for SBA .. Patch Set 15: This change is ready for review. -- To view, visit

Change in osmo-pcu[master]: TBF-DL: cosmetic update for helper routines

Max has posted comments on this change. ( https://gerrit.osmocom.org/13244 ) Change subject: TBF-DL: cosmetic update for helper routines .. Patch Set 3: This change is ready for review. -- To view, visit

Change in osmo-pcu[master]: Update IA Rest Octets encoding

Max has posted comments on this change. ( https://gerrit.osmocom.org/13245 ) Change subject: Update IA Rest Octets encoding .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/13245

Change in osmo-pcu[master]: Use Timing Advance Index in UL assignments

Max has posted comments on this change. ( https://gerrit.osmocom.org/12956 ) Change subject: Use Timing Advance Index in UL assignments .. Patch Set 12: This change is ready for review. -- To view, visit

Change in osmo-pcu[master]: Fix Channel Coding Command for MCS

Max has posted comments on this change. ( https://gerrit.osmocom.org/13216 ) Change subject: Fix Channel Coding Command for MCS .. Patch Set 6: This change is ready for review. -- To view, visit

Change in osmo-pcu[master]: Rewrite Packet Uplink IA Rest Octets for MBA

Max has posted comments on this change. ( https://gerrit.osmocom.org/12961 ) Change subject: Rewrite Packet Uplink IA Rest Octets for MBA .. Patch Set 9: This change is ready for review. -- To view, visit

Change in osmo-pcu[master]: MCS: add Channel Coding Command encoder

Max has posted comments on this change. ( https://gerrit.osmocom.org/13215 ) Change subject: MCS: add Channel Coding Command encoder .. Patch Set 5: This change is ready for review. -- To view, visit

Change in osmo-pcu[master]: MCS: add mcs_is_*() helpers

Max has posted comments on this change. ( https://gerrit.osmocom.org/13214 ) Change subject: MCS: add mcs_is_*() helpers .. Patch Set 5: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/13214 To

Change in libosmocore[master]: Doxygen: fix documentation of osmo_timer_setup()

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13411 ) Change subject: Doxygen: fix documentation of osmo_timer_setup() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: src/rate_ctr.c: drop some incorrect \ref references

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13410 ) Change subject: src/rate_ctr.c: drop some incorrect \ref references .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: Doxygen: fix documentation of rate_ctr_for_each_counter()

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13409 ) Change subject: Doxygen: fix documentation of rate_ctr_for_each_counter() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: core/msgb.h: fix incorrect Doxygen parameter description

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13408 ) Change subject: core/msgb.h: fix incorrect Doxygen parameter description .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: core/msgb.h: drop meaningless parameter of msgb_eq_* helpers

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13405 ) Change subject: core/msgb.h: drop meaningless parameter of msgb_eq_* helpers .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: src/msgb.c: fix Doxygen documentation for msgb_printf()

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13407 ) Change subject: src/msgb.c: fix Doxygen documentation for msgb_printf() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: core/msgb.h: fix dead msgb2 reference in msgb_eq_* helpers

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13404 ) Change subject: core/msgb.h: fix dead msgb2 reference in msgb_eq_* helpers .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: Doxygen: fix documentation of osmo_timer_setup()

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13411 Change subject: Doxygen: fix documentation of osmo_timer_setup() .. Doxygen: fix documentation of osmo_timer_setup() This change fixes

Change in libosmocore[master]: Doxygen: fix documentation of rate_ctr_for_each_counter()

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13409 Change subject: Doxygen: fix documentation of rate_ctr_for_each_counter() .. Doxygen: fix documentation of rate_ctr_for_each_counter()

Change in libosmocore[master]: src/rate_ctr.c: drop some incorrect \ref references

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13410 Change subject: src/rate_ctr.c: drop some incorrect \ref references .. src/rate_ctr.c: drop some incorrect \ref references

Change in libosmocore[master]: core/msgb.h: fix incorrect Doxygen parameter description

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13408 Change subject: core/msgb.h: fix incorrect Doxygen parameter description .. core/msgb.h: fix incorrect Doxygen parameter description

Change in libosmocore[master]: src/msgb.c: fix Doxygen documentation for msgb_printf()

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13407 Change subject: src/msgb.c: fix Doxygen documentation for msgb_printf() .. src/msgb.c: fix Doxygen documentation for msgb_printf() This

Change in osmo-pcu[master]: Add ARQ type helpers

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13406 Change subject: Add ARQ type helpers .. Add ARQ type helpers Add functions to check/log EGPRS ARQ type (as described in 3GPP TS 44.060 §8.1.1). Note -

Change in libosmocore[master]: core/msgb.h: fix dead msgb2 reference in msgb_eq_* helpers

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13404 Change subject: core/msgb.h: fix dead msgb2 reference in msgb_eq_* helpers .. core/msgb.h: fix dead msgb2 reference in msgb_eq_* helpers

Change in libosmocore[master]: core/msgb.h: drop meaningless parameter of msgb_eq_* helpers

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13405 Change subject: core/msgb.h: drop meaningless parameter of msgb_eq_* helpers .. core/msgb.h: drop meaningless parameter of msgb_eq_*

Change in osmo-pcu[master]: bts.h: always include C-headers

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13403 ) Change subject: bts.h: always include C-headers .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13403/1/src/bts.h File

Change in osmo-pcu[master]: bts.h: always include C-headers

Max has posted comments on this change. ( https://gerrit.osmocom.org/13403 ) Change subject: bts.h: always include C-headers .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13403/1/src/bts.h File src/bts.h:

Change in osmo-pcu[master]: bts.h: always include C-headers

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13403 ) Change subject: bts.h: always include C-headers .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-pcu[master]: Update MCS selection for retransmission

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13402 ) Change subject: Update MCS selection for retransmission .. Patch Set 1: (2 comments)

Change in libosmocore[master]: src/logging.c: fix syntax errors in Doxygen documentation

Max has posted comments on this change. ( https://gerrit.osmocom.org/13401 ) Change subject: src/logging.c: fix syntax errors in Doxygen documentation .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: bts.h: always include C-headers

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13403 Change subject: bts.h: always include C-headers .. bts.h: always include C-headers Previously C-headers were only included if bts.h was used by C++

Change in osmo-pcu[master]: Include pdch.h in bts.h even if we're not compiling C++

Max has posted comments on this change. ( https://gerrit.osmocom.org/13361 ) Change subject: Include pdch.h in bts.h even if we're not compiling C++ .. Patch Set 2: Code-Review+1 That's generic fix unrelated to oc2g in any

Change in osmo-pcu[master]: Update MCS selection for retransmission

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13402 Change subject: Update MCS selection for retransmission .. Update MCS selection for retransmission In 3GPP TS 44.060 the selection of MCS for

Change in osmo-gsm-tester[master]: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy

Hello Daniel Willmann, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13363 to look at the new patch set (#2). Change subject: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy

Change in openbsc[master]: osmo-bsc-mgcp.service: Fix parsing of cmdline option s

Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13348 ) Change subject: osmo-bsc-mgcp.service: Fix parsing of cmdline option s .. osmo-bsc-mgcp.service: Fix parsing of cmdline option s

Change in openbsc[master]: talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init

Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13387 ) Change subject: talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init .. talloc_ctx_init: Use public API

Change in openbsc[master]: osmo-bsc-mgcp.service: Fix parsing of cmdline option s

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13348 ) Change subject: osmo-bsc-mgcp.service: Fix parsing of cmdline option s .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: src/logging.c: fix syntax errors in Doxygen documentation

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13401 ) Change subject: src/logging.c: fix syntax errors in Doxygen documentation .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: logging_gsmtap.c: document all params of log_target_create_gsmtap()

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13400 ) Change subject: logging_gsmtap.c: document all params of log_target_create_gsmtap() .. Patch Set 1: Code-Review+1 (1 comment)

Change in libosmocore[master]: core/linuxlist.h: fix and unify Doxygen documentation

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13398 ) Change subject: core/linuxlist.h: fix and unify Doxygen documentation .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: core/linuxlist.h: fix and unify Doxygen documentation

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13398 to look at the new patch set (#2). Change subject: core/linuxlist.h: fix and unify Doxygen documentation

Change in libosmocore[master]: src/logging.c: fix syntax errors in Doxygen documentation

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13401 Change subject: src/logging.c: fix syntax errors in Doxygen documentation .. src/logging.c: fix syntax errors in Doxygen documentation

Change in libosmocore[master]: core/linuxlist.h: fix and unify Doxygen documentation

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13398 ) Change subject: core/linuxlist.h: fix and unify Doxygen documentation .. Patch Set 1: (4 comments)

Change in libosmocore[master]: logging_gsmtap.c: document all params of log_target_create_gsmtap()

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13400 Change subject: logging_gsmtap.c: document all params of log_target_create_gsmtap() .. logging_gsmtap.c: document all params of

Change in osmo-bts[master]: Forward GPRS SUSPEND REQ from DCCH to PCU socket

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13347 ) Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: Forward GPRS SUSPEND REQ from DCCH to PCU socket

osmith has posted comments on this change. ( https://gerrit.osmocom.org/13347 ) Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket .. Patch Set 1: (3 comments) Comments addressed, please have another look. I

Change in osmo-bts[master]: Forward GPRS SUSPEND REQ from DCCH to PCU socket

Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13347 to look at the new patch set (#2). Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket

Change in libosmocore[master]: core/linuxlist.h: fix white-space and inconsistent alignment

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13399 ) Change subject: core/linuxlist.h: fix white-space and inconsistent alignment .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: core/linuxlist.h: fix and unify Doxygen documentation

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13398 ) Change subject: core/linuxlist.h: fix and unify Doxygen documentation .. Patch Set 1: (5 comments)

Change in osmo-pcu[master]: MCS: move Mode enum outside of class definition

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13163 ) Change subject: MCS: move Mode enum outside of class definition .. MCS: move Mode enum outside of class definition Move Mode (EDGE/GPRS)

Change in libosmocore[master]: core/linuxlist.h: fix white-space and inconsistent alignment

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13399 Change subject: core/linuxlist.h: fix white-space and inconsistent alignment .. core/linuxlist.h: fix white-space and inconsistent

Change in libosmocore[master]: core/linuxlist.h: fix and unify Doxygen documentation

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13398 Change subject: core/linuxlist.h: fix and unify Doxygen documentation .. core/linuxlist.h: fix and unify Doxygen documentation - drop

Change in openbsc[master]: talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13387 ) Change subject: talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: Revert "ipa_ccm_idtag_parse*: Fix reported length value"

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13396 ) Change subject: Revert "ipa_ccm_idtag_parse*: Fix reported length value" .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: Doxygen: fix incorrect / missing parameter description

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13397 ) Change subject: Doxygen: fix incorrect / missing parameter description .. Doxygen: fix incorrect / missing parameter description

Change in libosmocore[master]: Revert "ipa_ccm_idtag_parse*: Fix reported length value"

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13396 ) Change subject: Revert "ipa_ccm_idtag_parse*: Fix reported length value" .. Revert "ipa_ccm_idtag_parse*: Fix reported length value"

Change in libosmocore[master]: Doxygen: fix incorrect / missing parameter description

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13397 ) Change subject: Doxygen: fix incorrect / missing parameter description .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: core/linuxlist.h: fix and unify Doxygen documentation

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13398 ) Change subject: core/linuxlist.h: fix and unify Doxygen documentation .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: Doxygen: fix incorrect / missing parameter description

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13397 ) Change subject: Doxygen: fix incorrect / missing parameter description .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: core/linuxlist.h: fix white-space and inconsistent alignment

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13399 ) Change subject: core/linuxlist.h: fix white-space and inconsistent alignment .. Patch Set 2: Code-Review+1 I generally try to avoid such

Change in osmo-pcu[master]: Remove custom alarms

Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13360 ) Change subject: Remove custom alarms .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13360/1/src/osmo-bts-oc2g/oc2g_l1_if.c

Change in osmo-pcu[master]: MCS: move Mode enum outside of class definition

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13163 ) Change subject: MCS: move Mode enum outside of class definition .. Patch Set 7: Code-Review+2 -- To view, visit

Change in libosmocore[master]: core/linuxlist.h: fix white-space and inconsistent alignment

Vadim Yanitskiy has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/13399 ) Change subject: core/linuxlist.h: fix white-space and inconsistent alignment .. core/linuxlist.h: fix white-space and inconsistent

Change in libosmocore[master]: Doxygen: fix incorrect / missing parameter description

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13397 Change subject: Doxygen: fix incorrect / missing parameter description .. Doxygen: fix incorrect / missing parameter description

Change in libosmocore[master]: Revert "ipa_ccm_idtag_parse*: Fix reported length value"

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13396 Change subject: Revert "ipa_ccm_idtag_parse*: Fix reported length value" .. Revert "ipa_ccm_idtag_parse*: Fix reported length value" This reverts

Change in libosmocore[master]: add osmo_str_startswith()

Max has posted comments on this change. ( https://gerrit.osmocom.org/13394 ) Change subject: add osmo_str_startswith() .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13394/1//COMMIT_MSG Commit

Change in libosmocore[master]: gsm_utils.h: remove unused include of gsm_08_08.h

Max has posted comments on this change. ( https://gerrit.osmocom.org/13390 ) Change subject: gsm_utils.h: remove unused include of gsm_08_08.h .. Patch Set 2: Does this really depends on all the preceding patches or it can be

Change in libosmocore[master]: gsm_utils.h: remove unused include of gsm_08_08.h

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13390 ) Change subject: gsm_utils.h: remove unused include of gsm_08_08.h .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: MCS: move Mode enum outside of class definition

osmith has posted comments on this change. ( https://gerrit.osmocom.org/13163 ) Change subject: MCS: move Mode enum outside of class definition .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13163

Change in gr-gsm[master]: Fix the TCH/H decoder and demapper XML definitions

Piotr Krysik has submitted this change and it was merged. ( https://gerrit.osmocom.org/13246 ) Change subject: Fix the TCH/H decoder and demapper XML definitions .. Fix the TCH/H decoder and demapper XML definitions - The

Change in gr-gsm[master]: Fix the TCH/H decoder and demapper XML definitions

Piotr Krysik has posted comments on this change. ( https://gerrit.osmocom.org/13246 ) Change subject: Fix the TCH/H decoder and demapper XML definitions .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: Use libosmocore for IMSI parsing

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13395 ) Change subject: Use libosmocore for IMSI parsing .. Patch Set 1: (1 comment)