Max has uploaded this change for review. ( https://gerrit.osmocom.org/12352
Change subject: Store GSN address in libosmocore struct
..
Store GSN address in libosmocore struct
That's automated code change made using following
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12330 )
Change subject: Use proper type for tch_rtp_connect() parameter
..
Use proper type for tch_rtp_connect() parameter
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/12330 )
Change subject: Use proper type for tch_rtp_connect() parameter
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12330
Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 )
Change subject: Use msgb helper instead of local #define for debug print
..
Patch Set 2:
This change is ready for review.
--
To view, visit https
Max has abandoned this change. ( https://gerrit.osmocom.org/12272 )
Change subject: cleanup: remove unused define
..
Abandoned
Superseded by new revision of parent patch.
--
To view, visit https://gerrit.osmocom.org/12272
Max has posted comments on this change. ( https://gerrit.osmocom.org/12329 )
Change subject: MNCC: use log wrapper for call processing
..
Patch Set 2:
> Patch Set 2:
>
> Yep, looks fine.
Feel free to add +
Max has posted comments on this change. ( https://gerrit.osmocom.org/12335 )
Change subject: VLR: drop unused struct members
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/12335/3/include/osmocom/msc/vlr.h
File
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12337 )
Change subject: VLR tests: avoid leaking LAC access details
..
VLR tests: avoid leaking LAC access details
Avoid leaking details
Max has posted comments on this change. ( https://gerrit.osmocom.org/12337 )
Change subject: VLR tests: avoid leaking LAC access details
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12337
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Stefan Sperling
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12336 )
Change subject: VLR tests: add logging macro with explicit value description
..
VLR tests: add logging macro with explicit value description
Max has posted comments on this change. ( https://gerrit.osmocom.org/12337 )
Change subject: VLR tests: avoid leaking LAC access details
..
Patch Set 2: Code-Review+2
Trivial macro rename from earlier revision which got +2
Max has posted comments on this change. ( https://gerrit.osmocom.org/12336 )
Change subject: VLR tests: add logging macro with explicit value description
..
Patch Set 2: Code-Review+2
Trivial rename from previous revision
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Stefan Sperling
-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Stefan Sperling
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic462297edac4c55689f93cc45771c8b5e2aed864
Gerrit-Change-Number: 12336
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I993ebc3e14f25e83124b6d3f8461a4b18f971f8e
Gerrit-Change-Number: 12338
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12241 )
Change subject: Remove -Wall for autogenerated code
..
Remove -Wall for autogenerated code
There seems to be no option for ttcn3_makefilegen
Max has posted comments on this change. ( https://gerrit.osmocom.org/12296 )
Change subject: MSC: match default expectation with config
..
Patch Set 1: Code-Review+2
1 + 1 = 2 :)
--
To view, visit https://gerrit.osmocom.org
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12296 )
Change subject: MSC: match default expectation with config
..
MSC: match default expectation with config
In MSC_Tests.default we expect /tmp
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12333 )
Change subject: CC: log more details about unhandled message/state
..
CC: log more details about unhandled message/state
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/12335 )
Change subject: comment: vlr: drop unused struct members
..
Patch Set 1:
Not sure if entire .ps can be dropped - it looks like pre-split leftover
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e0febd04f7338aed7222dcfcd9bfddc7b8fda59
Gerrit-Change-Number: 12333
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12338
Change subject: Remove redundancy in LAC processing
..
Remove redundancy in LAC processing
Always use LAC which is part of Cell Global ID otherwise we
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12336
Change subject: VLR tests: add logging macro with explicit value description
..
VLR tests: add logging macro with explicit value description
To avoid
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12337
Change subject: VLR tests: avoid leaking LAC access details
..
VLR tests: avoid leaking LAC access details
Avoid leaking details on accessing data
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12335
Change subject: comment: vlr: drop unused struct members
..
comment: vlr: drop unused struct members
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12333
Change subject: cosmetic: log more details about unhandled message/state
..
cosmetic: log more details about unhandled message/state
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12334
Change subject: cosmetic: drop unused variable
..
cosmetic: drop unused variable
Change-Id: Iff358eb2328cdd052e66b572aeec1b767174949b
---
M src/libmsc
Max has posted comments on this change. ( https://gerrit.osmocom.org/11787 )
Change subject: add/clean big-endian packed structs (struct_endianess.py)
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12302 )
Change subject: msc_vty.c: configurable retrieval of IMEI, IMEISV
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12302/1/src/libmsc
Max has posted comments on this change. ( https://gerrit.osmocom.org/12321 )
Change subject: vty: Introduce telnet_init_default and make vty port
configurable
..
Patch Set 1: Code-Review-1
(2 comments)
Please clarify why
: I5c44d7bb28f1ff895dd4f839d75840495503c916
Gerrit-Change-Number: 12329
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol
Max has posted comments on this change. ( https://gerrit.osmocom.org/12208 )
Change subject: Revert "mobile: use VTY bind addr from config, deprecate cmd
line options"
..
Patch Set 1: Code-Review-1
> Patch Set 1
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12328 )
Change subject: cosmetic: drop duplicated #include
..
cosmetic: drop duplicated #include
Change-Id
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12277 )
Change subject: MSC: use config file for mncc path
..
MSC: use config file for mncc path
Use config file parameter instead of command line
Max has posted comments on this change. ( https://gerrit.osmocom.org/12277 )
Change subject: MSC: use config file for mncc path
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/12277
To unsubscribe
Max has posted comments on this change. ( https://gerrit.osmocom.org/12318 )
Change subject: ctrl: log host/port on errors
..
Patch Set 1:
> Patch Set 1:
>
> > What would be the right approach to make host:po
Max has abandoned this change. ( https://gerrit.osmocom.org/12319 )
Change subject: Use absolute path for default config
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/12319
To unsubscribe, or for help writing mail
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12328
Change subject: cosmetic: drop duplicated #include
..
cosmetic: drop duplicated #include
Change-Id: I216425ba5994a49981d51bce6cfa7c3fa5fe9e40
---
M
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12330
Change subject: Use proper type for tch_rtp_connect() parameter
..
Use proper type for tch_rtp_connect() parameter
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12329
Change subject: MNCC: use log wrapper for call processing
..
MNCC: use log wrapper for call processing
Add log/debug wrappers to conveniently print
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12331
Change subject: MNCC: internalize bridge error handling
..
MNCC: internalize bridge error handling
This can be handled internally instead of checking
Max has posted comments on this change. ( https://gerrit.osmocom.org/11746 )
Change subject: Store subscriber's cell identity
..
Patch Set 3:
(1 comment)
This change is ready for review.
https://gerrit.osmocom.org/#/c/11746
Max has posted comments on this change. ( https://gerrit.osmocom.org/12319 )
Change subject: Use absolute path for default config
..
Patch Set 1:
> Patch Set 1: Code-Review-1
>
> As far as I can tell, in all repo
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12319
Change subject: Use absolute path for default config
..
Use absolute path for default config
Change-Id: I37c559af99872de9290335699e2118924ae2156a
Max has posted comments on this change. ( https://gerrit.osmocom.org/12318 )
Change subject: ctrl: log host/port on errors
..
Patch Set 1:
> Patch Set 1: Code-Review-1
>
> I feel this entire patchset breaks
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12316
Change subject: ctrl: make config structure public
..
ctrl: make config structure public
Moving configuration data from anonymous struct into shared
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12318
Change subject: ctrl: log host/port on errors
..
ctrl: log host/port on errors
In case of multiple ctrl-client entries in .cfg file it's impossible
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12317
Change subject: ctrl: pass config struct to all simple_ctrl_*()
..
ctrl: pass config struct to all simple_ctrl_*()
Make basic logging-related
Max has posted comments on this change. ( https://gerrit.osmocom.org/11992 )
Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/11992/7
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11826 )
Change subject: LCLS: add gsm0808_create_ass2()
..
LCLS: add gsm0808_create_ass2()
It allows setting additional assignment parameters
Max has removed a vote on this change.
Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
..
Removed Code-Review+2 by Max
--
To view, visit https://gerrit.osmocom.org/12020
To unsubscribe, or for help writing mail
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11827 )
Change subject: LCLS, TS 29.205: add GCR routines
..
LCLS, TS 29.205: add GCR routines
Add functions to encode and decode Global Call
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12020 )
Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
..
LCLS, TS 48.008: add GCR IE encoding/decoding
* add functions to encode
Max has removed a vote on this change.
Change subject: LCLS, TS 29.205: add GCR routines
..
Removed Code-Review+2 by Max
--
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help writing mail filters
Max has posted comments on this change. ( https://gerrit.osmocom.org/11992 )
Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..
Patch Set 7: Code-Review-1
(4 comments)
https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/11989 )
Change subject: gsupclient: add osmo_gsup_msg_enc_send()
..
Patch Set 4: Code-Review-1
(3 comments)
Sorry, haven't noticed those earlier.
https
Max has posted comments on this change. ( https://gerrit.osmocom.org/11787 )
Change subject: add/clean big-endian packed structs (struct_endianess.py)
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c
Max has posted comments on this change. ( https://gerrit.osmocom.org/11992 )
Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..
Patch Set 7:
Is this some named timer from the spec or it's just smth
Max has posted comments on this change. ( https://gerrit.osmocom.org/12234 )
Change subject: tweak comment to indicate sub_pres_vlr fsm as dead code
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/12234/3
Max has posted comments on this change. ( https://gerrit.osmocom.org/12236 )
Change subject: vlr_lu_fsm: drop unused out_state INIT -> WAIT_IMEI
..
Patch Set 2:
Do you need to update some .adoc or .msc as well or this is
Max has posted comments on this change. ( https://gerrit.osmocom.org/12291 )
Change subject: trx_toolkit/ctrl_if_trx.py: drop meaningless warnings
..
Patch Set 2:
(1 comment)
Could you clarify in commit message if RESET
Max has posted comments on this change. ( https://gerrit.osmocom.org/11989 )
Change subject: gsupclient: add osmo_gsup_msg_enc_send()
..
Patch Set 3: Code-Review-1
(2 comments)
Please double check.
https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 )
Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
..
Patch Set 18: Code-Review+2
Will merge at the end of the day unless some objections
Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 )
Change subject: LCLS, TS 29.205: add GCR routines
..
Patch Set 24: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe
Max has posted comments on this change. ( https://gerrit.osmocom.org/12300 )
Change subject: Introduce recipe for osmo-sysmon
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12300
To unsubscribe
Max has posted comments on this change. ( https://gerrit.osmocom.org/12299 )
Change subject: Introduce recipe liboping 1.10.0
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12299
To unsubscribe
Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 )
Change subject: LCLS, TS 29.205: add GCR routines
..
Patch Set 24:
(1 comment)
https://gerrit.osmocom.org/#/c/11827/23/tests/gsm29205
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12298
Change subject: MSC: adjust gsup log level to error
..
MSC: adjust gsup log level to error
The HLR emulation is active only for short time during each
Max has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/12243/3/src/gprs
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12296
Change subject: MSC: match default expectation with config
..
MSC: match default expectation with config
In MSC_Tests.default we expect /tmp/mncc.sock
Max has posted comments on this change. ( https://gerrit.osmocom.org/12286 )
Change subject: Introduce systemd service file and install with autotools
..
Patch Set 2: Code-Review-1
Is it enabled by default in OE? If so than
Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 )
Change subject: Use msgb helper instead of local #define for debug print
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12271/1/tests
Max has posted comments on this change. ( https://gerrit.osmocom.org/12286 )
Change subject: Install systemd services with autotools
..
Patch Set 1:
(1 comment)
In general, see comment on the previous patch: I'm not convinced
Max has posted comments on this change. ( https://gerrit.osmocom.org/12286 )
Change subject: Install systemd services with autotools
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/12286
Max has posted comments on this change. ( https://gerrit.osmocom.org/12284 )
Change subject: Move source code to src subdir
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12284
To unsubscribe
Max has posted comments on this change. ( https://gerrit.osmocom.org/12285 )
Change subject: Add cmdline option parsing support
..
Patch Set 1: Code-Review-1
(1 comment)
This program regularly print stuff on screen based
Max has posted comments on this change. ( https://gerrit.osmocom.org/12293 )
Change subject: require 'ipa-name' option to be set via config file
..
Patch Set 1:
(2 comments)
That's a minor note though - mostly commenting just
Max has posted comments on this change. ( https://gerrit.osmocom.org/12227 )
Change subject: ACL: integrate sanitize check into sgsn_acl_* functions
..
Patch Set 5:
> Patch Set 5:
> I did, maybe it was not clear enou
Max has posted comments on this change. ( https://gerrit.osmocom.org/12242 )
Change subject: remove pointless declaration of struct gsm_network
..
Patch Set 2: Code-Review+1
> Patch Set 2:
> What is wrong with the c
Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 )
Change subject: Use msgb helper instead of local #define for debug print
..
Patch Set 1:
> Patch Set 1: Code-Review+2
>
> I don't agree, I d
Max has posted comments on this change. ( https://gerrit.osmocom.org/12242 )
Change subject: remove pointless declaration of struct gsm_network
..
Patch Set 2:
Good, but now commit message require adjustment as well
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12277
Change subject: MSC: use config file for mncc path
..
MSC: use config file for mncc path
Use config file parameter instead of command line option
Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 )
Change subject: Use msgb helper instead of local #define for debug print
..
Patch Set 1:
> Patch Set 1:
> I know you wanted to split them
Max has posted comments on this change. ( https://gerrit.osmocom.org/10170 )
Change subject: clear GPRS indicator in SI3 while PCU is disconnected
..
Patch Set 1:
Shouldn't this be marked as WIP while we're waiting on license
Max has posted comments on this change. ( https://gerrit.osmocom.org/12240 )
Change subject: comment: vlr: put the 'balancing' comment closer to the put()
..
Patch Set 1: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12266 )
Change subject: vty: show subscriber: put() before printing the use count
..
Patch Set 1:
(2 comments)
Please clarify.
https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12272 )
Change subject: cleanup: remove unused define
..
Patch Set 1:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12272
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12272
Change subject: cleanup: remove unused define
..
cleanup: remove unused define
Change-Id: Ibff603dd581f60b600f2469ad464a0bf77e24bfe
---
M tests
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12271
Change subject: Use msgb helper instead of local #define for debug print
..
Use msgb helper instead of local #define for debug print
This change
Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 )
Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
..
Patch Set 18:
(1 comment)
https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808
Max has posted comments on this change. ( https://gerrit.osmocom.org/1576 )
Change subject: CTRL: remove boilerplate
..
Patch Set 5:
> Easiest to get rid of them is to just "Reply", so bear with me
You mean
Max has posted comments on this change. ( https://gerrit.osmocom.org/12242 )
Change subject: remove pointless declaration of struct gsm_network
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12242/1/src/gprs
Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 )
Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
..
Patch Set 18:
(2 comments)
https://gerrit.osmocom.org/#/c/12020/4/tests/gsm0808
Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf
Gerrit-Change-Number: 11827
Gerrit-PatchSet: 24
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit
-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-CC: Stefan Sperling
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers
..
msgb: add test helpers
It's often handy to compare certain msgb layer to a given array and
print
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12247
Change subject: cosmetic: move bit counter outside of egprs_window_size()
..
cosmetic: move bit counter outside of egprs_window_size
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12246
Change subject: cosmetic: use const pointer for bts_data
..
cosmetic: use const pointer for bts_data
It's used several time for logging so let's call
901 - 1000 of 3542 matches
Mail list logo
