Change in libosmocore[master]: gsm48_mi_to_string(): do not read from zero length input buffer

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12157 ) Change subject: gsm48_mi_to_string(): do not read from zero length input buffer .. Patch Set 6: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: Add osmo_sockaddr_in_to_str_and_uint()

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11842 ) Change subject: Add osmo_sockaddr_in_to_str_and_uint() .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11842

Change in osmo-msc[master]: provide software version information to gsup peer

2018-12-06 Thread Stefan Sperling
://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2eba32569349facdbb1fda201067c62cc804ccf4 Gerrit-Change-Number: 12178 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-06 Thread Stefan Sperling
, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I317d6c59f77e92fbb2b875a83dc0ec2fa5cb6006 Gerrit-Change-Number: 12177 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-06 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12177 Change subject: make gsup ipa name configurable in osmo-msc.cfg .. make gsup ipa name configurable in osmo-msc.cfg Add a 'ipa-name' VTY

Change in osmo-msc[master]: provide software version information to gsup peer

2018-12-06 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12178 Change subject: provide software version information to gsup peer .. provide software version information to gsup peer Provide software

Change in libosmo-abis[master]: log IPA tags correctly

2018-12-06 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12175 ) Change subject: log IPA tags correctly .. log IPA tags correctly Due to apparent copy-paste errors, wrong values were being

Change in libosmo-abis[master]: log IPA tags correctly

2018-12-06 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12175 Change subject: log IPA tags correctly .. log IPA tags correctly Due to apparent copy-paste errors, wrong values were being logged

Change in osmo-hlr[master]: store timestamp of last location update seen from subscriber

2018-12-06 Thread Stefan Sperling
rit-PatchSet: 5 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-hlr[master]: store timestamp of last location update seen from subscriber

2018-12-06 Thread Stefan Sperling
rit-PatchSet: 4 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: msgb: add test helpers

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12017 ) Change subject: msgb: add test helpers .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12017 To unsubscribe

Change in libosmocore[master]: msgb: add test helpers

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12017 ) Change subject: msgb: add test helpers .. Patch Set 11: Code-Review+1 (1 comment) I like this idea. https://gerrit.osmocom.org/#/c

Change in libosmocore[master]: LCLS: add gsm0808_create_ass2()

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11826 ) Change subject: LCLS: add gsm0808_create_ass2() .. Patch Set 26: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11826

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11827 ) Change subject: LCLS, TS 29.205: add GCR routines .. Patch Set 21: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11827

Change in libosmocore[master]: Allow log_init() with NULL log_info

2018-12-06 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12092 ) Change subject: Allow log_init() with NULL log_info .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12092

Change in osmo-hlr[master]: introduce osmo_gsup_client_create2()

2018-12-06 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12098 ) Change subject: introduce osmo_gsup_client_create2() .. introduce osmo_gsup_client_create2() Add a new API which allows creating

Change in osmo-msc[master]: make: prepare for adding transcript tests

2018-12-05 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12126 ) Change subject: make: prepare for adding transcript tests .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-msc[master]: msc_main: mncc: move mncc socket decision to after read_cfg

2018-12-05 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12129 ) Change subject: msc_main: mncc: move mncc socket decision to after read_cfg .. Patch Set 6: Code-Review+1 -- To view, visit https

Change in osmo-msc[master]: python tests: use py shebang instead of $(PYTHON)

2018-12-05 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12138 ) Change subject: python tests: use py shebang instead of $(PYTHON) .. Patch Set 2: Code-Review+1 Fine with me. -- To view, visit https

Change in osmo-msc[master]: add test_nodes.vty transcript test

2018-12-05 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12127 ) Change subject: add test_nodes.vty transcript test .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12127

Change in osmo-msc[master]: cosmetic: msc_main.c: default args definition style

2018-12-05 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12128 ) Change subject: cosmetic: msc_main.c: default args definition style .. Patch Set 5: Code-Review+1 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: MSC_Test: Test what happens when Paging for SMS is unanswered

2018-12-05 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11897 ) Change subject: MSC_Test: Test what happens when Paging for SMS is unanswered .. Patch Set 6: Code-Review+1 -- To view, visit https

Change in osmo-bsc[master]: paging: Add VTY options to calculate T3113 timeout dynamically

2018-12-05 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11654 ) Change subject: paging: Add VTY options to calculate T3113 timeout dynamically .. Patch Set 6: Code-Review+1 -- To view, visit https

Change in osmo-msc[master]: vty: mncc cfg: separate the 'mncc' from 'mncc-guard-timeout'

2018-12-05 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12130 ) Change subject: vty: mncc cfg: separate the 'mncc' from 'mncc-guard-timeout' .. Patch Set 6: Code-Review+1 -- To view, visit https

Change in osmo-hlr[master]: introduce osmo_gsup_client_create2()

2018-12-05 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12098 ) Change subject: introduce osmo_gsup_client_create2() .. Patch Set 2: Thanks for the review. Should be all good in next patch set

Change in osmo-hlr[master]: introduce osmo_gsup_client_create2()

2018-12-05 Thread Stefan Sperling
mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ief09677e07d6e977247185b72c605f109aa091f5 Gerrit-Change-Number: 12098 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins

Change in osmo-hlr[master]: store timestamp of last location update seen from subscriber

2018-12-04 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12121 Change subject: store timestamp of last location update seen from subscriber .. store timestamp of last location update seen from

Change in osmo-hlr[master]: Rename db_bootstrap.sed to db_sql2c.sed

2018-12-04 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12101 ) Change subject: Rename db_bootstrap.sed to db_sql2c.sed .. Rename db_bootstrap.sed to db_sql2c.sed Side effect of the db schema

Change in osmo-trx[master]: lms: Close device on LMS_Init failure

2018-12-04 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12091 ) Change subject: lms: Close device on LMS_Init failure .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12091

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-12-04 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. add database schema versioning to the HLR database Make

Change in libosmocore[master]: Logging: don't print hex category by default

2018-12-04 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12095 ) Change subject: Logging: don't print hex category by default .. Patch Set 3: Note that log_target_create() still contains this code

Change in libosmocore[master]: Allow log_init() with NULL log_info

2018-12-04 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12092 ) Change subject: Allow log_init() with NULL log_info .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12092

Change in osmo-trx[master]: lms: allow setting Tx/RxFreq for lchan!=0

2018-12-04 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12097 ) Change subject: lms: allow setting Tx/RxFreq for lchan!=0 .. Patch Set 1: Can you explain why this change is needed? It's not obvious

Change in osmo-trx[master]: lms: Improve Set{Rx, Tx}{Gain, Freq} logging

2018-12-04 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12099 ) Change subject: lms: Improve Set{Rx,Tx}{Gain,Freq} logging .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-trx[master]: transceiver: log chan on CTRL command received

2018-12-04 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12100 ) Change subject: transceiver: log chan on CTRL command received .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-12-04 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 9: > Patch Set 9: Code-Review+1 > > (1 comment)

Change in osmo-hlr[master]: introduce osmo_gsup_client_create2()

2018-12-04 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12098 Change subject: introduce osmo_gsup_client_create2() .. introduce osmo_gsup_client_create2() Add a new API which allows creating a GSUP

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-12-03 Thread Stefan Sperling
Gerrit-PatchSet: 8 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-12-03 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/11898/7

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-12-03 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 7: (5 comments) https://gerrit.osmocom.org/#/c/11898/7

Change in osmo-bsc[master]: paging: Add VTY options to calculate T3113 timeout dynamically

2018-12-03 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11654 ) Change subject: paging: Add VTY options to calculate T3113 timeout dynamically .. Patch Set 5: Code-Review+1 Looks fine to me now. Your

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-30 Thread Stefan Sperling
: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b Gerrit-Change-Number: 11898 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-30 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 6: > Patch Set 5: Code-Review-1 > The above is wh

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-30 Thread Stefan Sperling
-Change-Number: 11898 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-30 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 5: (4 comments) https://gerrit.osmocom.org/#/c/11898/5

Change in osmo-sysmon[master]: fix file descriptor leak in osysmon_file_read

2018-11-30 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11943 ) Change subject: fix file descriptor leak in osysmon_file_read .. fix file descriptor leak in osysmon_file_read Don't forget

Change in osmo-sysmon[master]: fix file descriptor leak in osysmon_file_read

2018-11-27 Thread Stefan Sperling
: newpatchset Gerrit-Change-Id: Ie1b5734748438c6d785cd96dfa9af6303cd102da Gerrit-Change-Number: 11943 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Stefan Sperling

Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

2018-11-27 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11521 ) Change subject: add DLCX command statistics to osmo-mgw .. add DLCX command statistics to osmo-mgw Add a counter group for DLCX

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 5: > If we are otherwise happy with this time, O

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 5: > - If needed, run upgrade commands. I think I wo

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b Gerrit-Change-Number: 11898 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: > Patch Set 4: Code-Review-1 > Also, I

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11898/4

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11898/4

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-27 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: I found a way to check the existence of tables

Change in osmo-sysmon[master]: fix file descriptor leak in osysmon_file_read

2018-11-27 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11943 Change subject: fix file descriptor leak in osysmon_file_read .. fix file descriptor leak in osysmon_file_read Don't forget to close

Change in libsmpp34[master]: fix use of partly initialized struct in tcp test

2018-11-27 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11854 ) Change subject: fix use of partly initialized struct in tcp test .. fix use of partly initialized struct in tcp test Properly

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-23 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11898/1

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-23 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11898/1

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-23 Thread Stefan Sperling
https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b Gerrit-Change-Number: 11898 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-23 Thread Stefan Sperling
-MessageType: newpatchset Gerrit-Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b Gerrit-Change-Number: 11898 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Pau Espin Pedrol

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-23 Thread Stefan Sperling
-MessageType: newpatchset Gerrit-Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b Gerrit-Change-Number: 11898 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Pau Espin Pedrol

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-23 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11898/1

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-23 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 ) Change subject: add database schema versioning to the HLR database .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11898/1

Change in osmo-hlr[master]: add database schema versioning to the HLR database

2018-11-22 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11898 Change subject: add database schema versioning to the HLR database .. add database schema versioning to the HLR database This introduces

Change in osmo-bsc[master]: paging: Add VTY options to calculate T3113 timeout dynamically

2018-11-22 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11654 ) Change subject: paging: Add VTY options to calculate T3113 timeout dynamically .. Patch Set 3: Code-Review+1 (1 comment) https

Change in osmo-dev[master]: Add expect script: 'vty' for easy access to all vtys

2018-11-22 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11811 ) Change subject: Add expect script: 'vty' for easy access to all vtys .. Patch Set 2: Code-Review+1 For better visibility to end users

Change in osmo-bsc[master]: vty: add command to show TRX selectively

2018-11-22 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11721 ) Change subject: vty: add command to show TRX selectively .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-msc[master]: osmo_msc: remove unused parameter from msc_dtap()

2018-11-22 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11835 ) Change subject: osmo_msc: remove unused parameter from msc_dtap() .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-ci[master]: Add osmo-sysmon to coverity submission

2018-11-22 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11882 ) Change subject: Add osmo-sysmon to coverity submission .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11882

Change in osmo-ci[master]: Add osmo-sysmon to default depcheck config

2018-11-22 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11883 ) Change subject: Add osmo-sysmon to default depcheck config .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-ggsn[master]: fix format string error in ippool_printaddr()

2018-11-22 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11870 ) Change subject: fix format string error in ippool_printaddr() .. fix format string error in ippool_printaddr() The variable

Change in osmo-ggsn[master]: fix a format string directives in queue_seqset()

2018-11-22 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11862 ) Change subject: fix a format string directives in queue_seqset() .. fix a format string directives in queue_seqset() Coverity

Change in osmo-sgsn[master]: consistently check the result of osmo_shift_v_fixed()

2018-11-22 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11876 ) Change subject: consistently check the result of osmo_shift_v_fixed() .. consistently check the result of osmo_shift_v_fixed

Change in osmo-ggsn[master]: initialize local variable addr in ippool_new()

2018-11-22 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11869 ) Change subject: initialize local variable addr in ippool_new() .. initialize local variable addr in ippool_new() Coverity points

Change in osmo-ggsn[master]: replace bogus memcpy() call in ippool_newip()

2018-11-22 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11861 ) Change subject: replace bogus memcpy() call in ippool_newip() .. replace bogus memcpy() call in ippool_newip() When copying

Change in osmo-ggsn[master]: properly store IPv6 addresses in struct tun_t

2018-11-22 Thread Stefan Sperling
: Stefan Sperling Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Pau Espin Pedrol

Change in osmo-sgsn[master]: consistently check the result of osmo_shift_v_fixed()

2018-11-22 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11876 Change subject: consistently check the result of osmo_shift_v_fixed() .. consistently check the result of osmo_shift_v_fixed() Coverity

Change in osmo-ggsn[master]: properly store IPv6 addresses in struct tun_t

2018-11-22 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11871 ) Change subject: properly store IPv6 addresses in struct tun_t .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11871/1/lib

Change in osmo-ggsn[master]: properly store IPv6 addresses in struct tun_t

2018-11-22 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11871 ) Change subject: properly store IPv6 addresses in struct tun_t .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11871/1/lib

Change in osmo-ggsn[master]: properly store IPv6 addresses in struct tun_t

2018-11-22 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11871 ) Change subject: properly store IPv6 addresses in struct tun_t .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/11871/1/lib

Change in osmo-ggsn[master]: properly store IPv6 addresses in struct tun_t

2018-11-21 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11871 Change subject: properly store IPv6 addresses in struct tun_t .. properly store IPv6 addresses in struct tun_t All addresses in struct

Change in osmo-ggsn[master]: fix format string error in ippool_printaddr()

2018-11-21 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11870 Change subject: fix format string error in ippool_printaddr() .. fix format string error in ippool_printaddr() The variable

Change in osmo-ggsn[master]: initialize local variable addr in ippool_new()

2018-11-21 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11869 Change subject: initialize local variable addr in ippool_new() .. initialize local variable addr in ippool_new() Coverity points out

Change in osmo-ggsn[master]: fix allocation of ippool's hash table

2018-11-21 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11858 ) Change subject: fix allocation of ippool's hash table .. fix allocation of ippool's hash table The calloc() call in ippool_new

Change in osmo-ggsn[master]: replace bogus memcpy() call in ippool_newip()

2018-11-21 Thread Stefan Sperling
org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic21560f7519e776107485a8779702fb1279d065c Gerrit-Change-Number: 11861 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofm

Change in osmo-ggsn[master]: check ioctl() call return value in tun_new()

2018-11-21 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11856 ) Change subject: check ioctl() call return value in tun_new() .. check ioctl() call return value in tun_new() Coverity complains

Change in osmo-ggsn[master]: fix a format string directives in queue_seqset()

2018-11-21 Thread Stefan Sperling
: newpatchset Gerrit-Change-Id: I889019aad963932fdc032421e60a72c809a93bca Gerrit-Change-Number: 11862 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-CC: Vadim Yanitskiy

Change in osmo-ggsn[master]: fix a format string directives in queue_seqset()

2018-11-21 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11862 ) Change subject: fix a format string directives in queue_seqset() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11862/1/gtp

Change in osmo-ggsn[master]: fix a format string directives in queue_seqset()

2018-11-21 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11862 Change subject: fix a format string directives in queue_seqset() .. fix a format string directives in queue_seqset() Coverity pointed out

Change in osmo-ggsn[master]: check ioctl() call return value in tun_new()

2018-11-21 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11856 ) Change subject: check ioctl() call return value in tun_new() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11856/1/lib

Change in osmo-ggsn[master]: replace bogus memcpy() call in ippool_newip()

2018-11-21 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11861 Change subject: replace bogus memcpy() call in ippool_newip() .. replace bogus memcpy() call in ippool_newip() When copying an address

Change in osmo-ggsn[master]: fix allocation of ippool's hash table

2018-11-21 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11858 Change subject: fix allocation of ippool's hash table .. fix allocation of ippool's hash table The calloc() call in ippool_new() had two

Change in osmo-ggsn[master]: check ioctl() call return value in tun_new()

2018-11-21 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11856 Change subject: check ioctl() call return value in tun_new() .. check ioctl() call return value in tun_new() Coverity complains about

Change in libsmpp34[master]: fix use of partly initialized struct in tcp test

2018-11-21 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11854 Change subject: fix use of partly initialized struct in tcp test .. fix use of partly initialized struct in tcp test Properly initialize

Change in osmo-sgsn[master]: update gbproxy test expected output

2018-11-20 Thread Stefan Sperling
://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia3df811755b1c88cf7a27a466677b24a6c32fd8e Gerrit-Change-Number: 11840 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-sgsn[master]: update gbproxy test expected output

2018-11-20 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11840 Change subject: update gbproxy test expected output .. update gbproxy test expected output libosmocore commit

Change in libosmocore[master]: document unblock-ack vs. signalling in gprs_ns_process_msg()

2018-11-20 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11839 ) Change subject: document unblock-ack vs. signalling in gprs_ns_process_msg() .. document unblock-ack vs. signalling

Change in libosmocore[master]: document unblock-ack vs. signalling in gprs_ns_process_msg()

2018-11-20 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11839 Change subject: document unblock-ack vs. signalling in gprs_ns_process_msg() .. document unblock-ack vs. signalling in gprs_ns_process_msg

Change in libosmocore[master]: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK

2018-11-20 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11833 ) Change subject: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c

<    1   2   3   4   5   6   7   8   9   10   >