Pau Espin Pedrol has abandoned this change.
Change subject: ofono_client: Discover modem path from imsi
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2696
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review-2
related: https://osmocom.org/issues/2509
--
To view, visit https://gerrit.osmocom.org/2696
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I602604d25f51b24d87877bc8ac798525b7be61dd
Gerrit-PatchSet: 1
Gerrit-Proj
Patch Set 1:
I agree in the sense that the implementation is a bit more complex than what we
initially though, but now that it's already there and it works I think it's
nice to keep it as it simplifies configuration and still provides the
possibility to configure it manually as done before.
A
Patch Set 1: Code-Review-1
I'm starting to get why this needs to be complicated... :/
The modem path becomes a dynamic property of the modem resource, yet it is the
single ofono handle that *defines* which resource is reserved. And we must only
query unreserved modems' properties.
I hate to s
Patch Set 1:
(1 comment)
so far just a hint on the KeyError problem.
In general I'm not following why this patch is so complex; need to take a look
later and discuss with you...
https://gerrit.osmocom.org/#/c/2696/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Pau Espin Pedrol has abandoned this change.
Change subject: ofono_client: Discover modem path from imsi
..
Abandoned
I splitted this commit in the next patch series, it didn't get updated.
--
To view, visit https://gerrit.osm
Review at https://gerrit.osmocom.org/2696
ofono_client: Discover modem path from imsi
Change-Id: I602604d25f51b24d87877bc8ac798525b7be61dd
---
M example/resources.conf
M src/osmo_gsm_tester/ofono_client.py
M src/osmo_gsm_tester/resource.py
M src/osmo_gsm_tester/suite.py
4 files changed, 105 ins
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2676/2/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 70: def _wait(condition, condition_args, condition_kwargs, timeout,
timestep):
> what is the problem you're solving? That test.wait is not populated
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2676/2/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 70: def _wait(condition, condition_args, condition_kwargs, timeout,
timestep):
> I'm duplicating it to avoid the problem to call through test.wait()
Patch Set 3:
> The main issue is that it's a chicken-egg problem.
I think it is sufficient to store the modem path with those modems that are
currently reserved.
* get a listing of modem paths from ofono;
* read the state file and see if any of those paths are currently reserved;
* check only
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2676
to look at the new patch set (#3).
ofono_client: Discover modem path from imsi
Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1
---
M example/resources.conf
M src/osm
Patch Set 2:
(1 comment)
The main issue is that it's a chicken-egg problem. I cannot properly identify a
modem until I use it, because we are identifying them using the IMSI and to
check which is the one I need to potentially power on all of them.
So, I guess to solve that, we would need at s
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/2676/2/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 70: def _wait(condition, condition_args, condition_kwargs, timeout,
timestep):
I'm confused, didn't I write this code? are you moving
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2676
to look at the new patch set (#2).
ofono_client: Discover modem path from imsi
Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1
---
M example/resources.conf
M src/osm
Patch Set 1:
(4 comments)
I guess I'm not removing "modem[].path" from resource.py:RESOURCES_SCHEMA
because it can still be used as explained on my other comments.
https://gerrit.osmocom.org/#/c/2676/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 96:
Patch Set 1:
one more thing: also remove "modem[].path" from resource.py:RESOURCES_SCHEMA
--
To view, visit https://gerrit.osmocom.org/2676
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1
Gerrit-P
Patch Set 1: Code-Review-1
(8 comments)
some code structuring issues, looks good otherwise.
https://gerrit.osmocom.org/#/c/2676/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 84: def modem_is_powered(modem_obj, val):
first reflex: if it requires a mode
Review at https://gerrit.osmocom.org/2676
ofono_client: Discover modem path from imsi
Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1
---
M example/resources.conf
M src/osmo_gsm_tester/ofono_client.py
M src/osmo_gsm_tester/osmo_nitb.py
3 files changed, 65 insertions(+), 14 deletions(-)
18 matches
Mail list logo
