Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2598
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92f1879a35d8bb399ee916b7ef72f9ee7d47409
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2608/2/contrib/jenkins-run.sh
File contrib/jenkins-run.sh:
Line 20: exit_code="1"
Isn't the script be terminated before reaching the end due to set -e if
osmo-gsm-tester.py exits with != 0?
--
To view, visit
Max has submitted this change and it was merged.
Change subject: Prepare for BTS attribute reporting via OML
..
Prepare for BTS attribute reporting via OML
* move BTS model name resolution into separate function
* add
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2544
to look at the new patch set (#3).
Get basic BTS attributes
Request BTS attributes via OML on connection and parse the response:
request/parse incoming response as
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2602
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I129f5189ce2bebd761bc752b158fb8778b31010e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2606/1/src/osmo_gsm_tester/bts_sysmo.py
File src/osmo_gsm_tester/bts_sysmo.py:
Line 50: self.run_dir =
util.Dir(os.path.abspath(self.suite_run.trial.get_run_dir().new_dir(self.name(
I think it would be better to use
Patch Set 1:
I saw you already did that in another commit afterwards. I guess we can drop
this one then.
--
To view, visit https://gerrit.osmocom.org/2606
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2607
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2ba876a42eef9122a92645edd1f28ddb56e6be3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2591
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3d5da00f7ece6dbcd4c999187a5748c9331e60f
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1:
sorry, I missed that patch ... will comment there
--
To view, visit https://gerrit.osmocom.org/2595
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb0f8d2058fa7ebb7f0f731645f9266cacdb120
Gerrit-PatchSet: 1
Gerrit-Project:
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2600/2/src/osmo_gsm_tester/trial.py
File src/osmo_gsm_tester/trial.py:
Line 77: self.log('Detailed log at', detailed_log)
> join this logging with the one above it?
I considered it, but adding the long abspath to the 'Trial start'
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2597
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4886cb3fe0cb9c66d170097b98b4d1eb67cab81
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: rather have an underscore in pcap_recorder.py
..
cosmetic: rather have an underscore in pcap_recorder.py
Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2588
to look at the new patch set (#4).
Restructure SI2quater generation
In preparation for extended SI2q messages:
* add SI2q-specific accessor macro
* add *_offset
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2611
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36eafbb9868b2ec9ae2173f8d1b651b976ccf88
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2612
SI2quater: fix EARFCN inclusion check
Previously only the existance of bts->si_common.si2quater_neigh_list was
checked but not the actual number of EARFCNs in it. Fix it by using
si2q_earfcn_count() and adjust tests accordingly. While at it - reformat
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2594
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I574937dbf31bce49cfb7523f91041c20fecb421e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix PACCH paging: don't return early in case of NULL TBF
..
fix PACCH paging: don't return early in case of NULL TBF
Commit
Patch Set 1:
You're probably right. I still wonder how can we test this for sure. Do we have
GAN implementation using those somewhere?
--
To view, visit https://gerrit.osmocom.org/2592
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2606/1/src/osmo_gsm_tester/bts_sysmo.py
File src/osmo_gsm_tester/bts_sysmo.py:
Line 50: self.run_dir =
util.Dir(os.path.abspath(self.suite_run.trial.get_run_dir().new_dir(self.name(
> I think it would be better to use
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2606/1/src/osmo_gsm_tester/bts_sysmo.py
File src/osmo_gsm_tester/bts_sysmo.py:
Line 50: self.run_dir =
util.Dir(os.path.abspath(self.suite_run.trial.get_run_dir().new_dir(self.name(
> I did something in that line in
Patch Set 1:
> I still wonder how can we test this for sure.
> Do we have GAN implementation using those somewhere?
IDK. Harald (as git blame shows) should know better.
--
To view, visit https://gerrit.osmocom.org/2592
To unsubscribe, visit https://gerrit.osmocom.org/settings
Pau Espin Pedrol has abandoned this change.
Change subject: jenkins-run: Provide a link to the latest trial archived
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2443
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2627
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60f5d4982cd96ab29f9924ec11b46bf56fbfc346
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2628
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac485324f40545339d8df6884f1dea319a23648
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2625
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3749e1e4974742bc8c32722e0e998775b5394829
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1:
How was this found? Is there specific test case we might add which fails with
old code but works with new one?
--
To view, visit https://gerrit.osmocom.org/2592
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2604
to look at the new patch set (#2).
fix: exception outside of trial run should be logged and cause nonzero rc
>From an earlier stage of the code, there was still an exception catcher
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2608
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I949849d85d93cb47c839cd738788cf6f9b22fc12
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2604
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8085318c91b06a3e8f7d3f8cfdd15a99650666e2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Review at https://gerrit.osmocom.org/2624
use osmo_{htonl,htons,ntohl,ntohs}() functions all over libosmocore
This gets us one step closer to fixing the embedded build
Change-Id: I3fc2639b6ade9ab138766987eceab7ec9498fdc7
---
M src/gsm/gsm0341.c
M src/gsm/gsm0808.c
M src/gsm/gsm0808_utils.c
M
Hello Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1607
to look at the new patch set (#2).
stats: Build UDP socket code only if sys/socket.h exists
Change-Id: I6beb4fcc394ed7d3f8dd7a097b6e998245ecf401
---
M
Review at https://gerrit.osmocom.org/2622
endian.h: Make it work on 'bare iron' builds (and possibly more platforms)
We can use __BYTE_ORDER__ which seems to be defined by both gcc and
clang/llvm.
Change-Id: Id6821c99e88242126d9697099b1dd92c6212526a
---
M include/osmocom/core/endian.h
1 file
Review at https://gerrit.osmocom.org/2627
gsm0808 + ipa: fix compilation on systems without sys/socket.h
Change-Id: I60f5d4982cd96ab29f9924ec11b46bf56fbfc346
---
M include/osmocom/gsm/gsm0808.h
M include/osmocom/gsm/gsm0808_utils.h
M src/gsm/gsm0808_utils.c
M src/gsm/ipa.c
4 files changed, 17
Review at https://gerrit.osmocom.org/2628
strrb: Add missing #include to talloc.h
The strrb.c code uses talloc API without using the proper #include.
Change-Id: I4ac485324f40545339d8df6884f1dea319a23648
---
M src/strrb.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/2623
introduce byteswap.h with osmo_{htonl,ntohl,htons,ntohs}
We need to have an architecture-independend way of endian conversion /
byte swapping functions which will also work on embedded (bare iron)
builds. Let's introduce osmocom/core/bytesawp.h for
Review at https://gerrit.osmocom.org/2621
src/logging.c: Fix EMBEDDED build
We don't enable/build _file_output in EMBEDDED builds, so we shouldn'r
refer to that symbol.
Change-Id: I491aa8ee9d20a96cbb2814700475afe03eb99c9e
---
M src/logging.c
1 file changed, 1 insertion(+), 1 deletion(-)
Harald Welte has restored this change.
Change subject: stats: Build UDP socket code only if sys/socket.h exists
..
Restored
--
To view, visit https://gerrit.osmocom.org/1607
To unsubscribe, visit
Patch Set 1:
> How was this found? Is there specific test case we might add which
> fails with old code but works with new one?
This was found by cppcheck: "unreachable part of code".
My assumption is that the TVLV_GROSS_LEN was merely
copy-pasted to VTVLV_GAN_GROSS_LEN, and return statements
Neels Hofmeyr has submitted this change and it was merged.
Change subject: OsmoGSMTester: add install docs; fixes and tweaks
..
OsmoGSMTester: add install docs; fixes and tweaks
Change-Id:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2600
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5f443f1af0dc774d4d4c588a238b786a83e44d3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2604/1/src/osmo-gsm-tester.py
File src/osmo-gsm-tester.py:
Line 216: log.log_exn()
> could it be an issue: if at some early stage before log object is initializ
'pass' would "swallow" the exception, the 'raise' keeps it alive and
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2597
to look at the new patch set (#2).
cosmetic: rather have an underscore in pcap_recorder.py
Change-Id: Ib4886cb3fe0cb9c66d170097b98b4d1eb67cab81
---
M
Patch Set 1: Code-Review-1
documentation missing
--
To view, visit https://gerrit.osmocom.org/2623
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc0cc1e36d4ed63a35cf8ceff3af0f26e5ac7a3d
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2622
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6821c99e88242126d9697099b1dd92c6212526a
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2621
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I491aa8ee9d20a96cbb2814700475afe03eb99c9e
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1607
to look at the new patch set (#4).
stats: Disable stats*.c on embedded targets
Change-Id: I6beb4fcc394ed7d3f8dd7a097b6e998245ecf401
---
M include/osmocom/core/stats.h
Patch Set 1: Code-Review+1
(3 comments)
(cosmetics)
https://gerrit.osmocom.org/#/c/2585/1/src/osmo_gsm_tester/bts_octphy.py
File src/osmo_gsm_tester/bts_octphy.py:
Line 57: '-i', self.nitb.addr())
(the oct bts is not working and we're not going to make it work at
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2611
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36eafbb9868b2ec9ae2173f8d1b651b976ccf88
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2629
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7ddf51d3bf0189ce07b488a3dcdcfce6907aba
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: fsm_test.c: fix unreachable check
..
fsm_test.c: fix unreachable check
Change-Id: Ic3d5da00f7ece6dbcd4c999187a5748c9331e60f
---
M tests/fsm/fsm_test.c
1
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2591
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3d5da00f7ece6dbcd4c999187a5748c9331e60f
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: all manuals: number paragraphs up to level 5 depth
..
all manuals: number paragraphs up to level 5 depth
Change-Id:
Review at https://gerrit.osmocom.org/2630
pcap_recorder: use self.filters instead of gen_filter
Change-Id: I53779d521fbeed7c37bcaeb12be2531e4dbc005c
---
M src/osmo_gsm_tester/pcap_recorder.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2585
to look at the new patch set (#2).
Enable GSMTAP on BTS and record it on the main unit NITB
Change-Id: I057a83bc20c5e664ac1778812452f189166919ba
---
M
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2612
to look at the new patch set (#2).
SI2quater: fix EARFCN inclusion check
Previously only the existance of bts->si_common.si2quater_neigh_list was
checked but not the
Neels Hofmeyr has submitted this change and it was merged.
Change subject: log state dir
..
log state dir
On the log output, clearly show which state dir is used. Since all runs should
use the same state dir, this is important
Neels Hofmeyr has submitted this change and it was merged.
Change subject: log: tweak osmo-gsm-tester.py stdout: all_origins=False,
src=False
..
log: tweak osmo-gsm-tester.py stdout: all_origins=False, src=False
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: debug suite: add test that deliberately fails
..
debug suite: add test that deliberately fails
Change-Id: I42ab624f8dd8e91ee62b8eccfa451e01fd3694d0
---
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2626
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib: rethink jenkins jobs with build slave approach
..
contrib: rethink jenkins jobs with build slave approach
Previously, the idea was to run a
Neels Hofmeyr has submitted this change and it was merged.
Change subject: checkout dependencies from script
..
checkout dependencies from script
The jenkins jobs used to have multiple source repositories configured, but it
is
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: contrib: add 'build-' to script names
..
cosmetic: contrib: add 'build-' to script names
Distinguish the scripts that build binaries from the
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix name of local var, to not shadow 'suite' module
..
fix name of local var, to not shadow 'suite' module
This caused "UnboundLocalError: local
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2596
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbc4521053610d55c9c32eff950ed8fa68dda171
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: gsm0808 + ipa: fix compilation on systems without sys/socket.h
..
gsm0808 + ipa: fix compilation on systems without sys/socket.h
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: libosmogb: Convert to use new endian conversion helpers
..
libosmogb: Convert to use new endian conversion helpers
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: introduce byteswap.h with osmo_{htonl,ntohl,htons,ntohs}
..
introduce byteswap.h with osmo_{htonl,ntohl,htons,ntohs}
We need to have an
Harald Welte has submitted this change and it was merged.
Change subject: strrb: Add missing #include to talloc.h
..
strrb: Add missing #include to talloc.h
The strrb.c code uses talloc API without using the proper #include.
Harald Welte has submitted this change and it was merged.
Change subject: use osmo_{htonl,htons,ntohl,ntohs}() functions all over
libosmocore
..
use osmo_{htonl,htons,ntohl,ntohs}() functions all over libosmocore
This gets us
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2626
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: endian.h: Make it work on 'bare iron' builds (and possibly more
platforms)
..
endian.h: Make it work on 'bare iron' builds (and possibly more platforms)
Harald Welte has submitted this change and it was merged.
Change subject: src/logging.c: Fix EMBEDDED build
..
src/logging.c: Fix EMBEDDED build
We don't enable/build _file_output in EMBEDDED builds, so we shouldn'r
refer to
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2623
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc0cc1e36d4ed63a35cf8ceff3af0f26e5ac7a3d
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: pcap: pass complete filter string to PcapRecorder
..
pcap: pass complete filter string to PcapRecorder
Composing the filter in gen_filter() is more
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2612
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4fb2a9e870db66cac58b1e8d113587b30d64ce2
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2612/1/openbsc/src/libbsc/system_information.c
File openbsc/src/libbsc/system_information.c:
Line 695: if (e)
we typically exit early, i.e. "if (!e) return 0;"
--
To view, visit https://gerrit.osmocom.org/2612
To
Max has submitted this change and it was merged.
Change subject: Restructure SI2quater generation
..
Restructure SI2quater generation
In preparation for extended SI2q messages:
* add SI2q-specific accessor macro
* add
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2586
to look at the new patch set (#2).
nitb: Filter ssh packets in pcap
Change-Id: I62a6ae7bd3a84baceb684c26727d2269c86ed023
---
M src/osmo_gsm_tester/osmo_nitb.py
1 file changed, 1
Review at https://gerrit.osmocom.org/2629
pcap: pass complete filter string to PcapRecorder
Composing the filter in gen_filter() is more complex than we need. We pass the
address and potentially further filter elements separately, and then
gen_filter() has to guess how to combine these.
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/1607/4/src/stats.c
File src/stats.c:
Line 245: #endif
Would be nice to get a comment on where this belongs to - similar to other
#endifs in this file.
--
To view, visit https://gerrit.osmocom.org/1607
To unsubscribe, visit
Harald Welte has submitted this change and it was merged.
Change subject: remove pcu own bitvector implementation
..
remove pcu own bitvector implementation
The osmocore bitvec is exact the same, but use a pointer instead of
a
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jenkins-run: clean up also upon error
..
jenkins-run: clean up also upon error
Change-Id: I949849d85d93cb47c839cd738788cf6f9b22fc12
---
M
Neels Hofmeyr has submitted this change and it was merged.
Change subject: trial: always use abspath
..
trial: always use abspath
No actual failure known, but using the abspath will prevent further problems
when running a
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2588
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib554cf7ffc949a321571e1ae2ada1160e1b35fa6
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2631
OsmoGSMTester: say 'modems', not 'modem' (sounds like it supports only one)
Change-Id: Ib59788a50754ea5290e665a9f9376d70e01c9be5
---
M OsmoGSMTester/chapters/install.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1607
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6beb4fcc394ed7d3f8dd7a097b6e998245ecf401
Gerrit-PatchSet: 6
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2635
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4e22f182a47b72b1fe43146716a4fbccceb62e6
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2633
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ee199381c7b5986a9540d124836c0f66c86
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2634
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f3b53f464b119d65747bcb0be0af2d631e1cc05
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1607
to look at the new patch set (#6).
stats: Disable stats*.c on embedded targets
Change-Id: I6beb4fcc394ed7d3f8dd7a097b6e998245ecf401
---
M include/osmocom/core/stats.h
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2632
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2735fc8d19fd68ef2c14a31e83cb396dc2e05587
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: timer: use timerclear() rather than explicit tv_set = tv_usec = 0
..
timer: use timerclear() rather than explicit tv_set = tv_usec = 0
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: stats: Disable stats*.c on embedded targets
..
stats: Disable stats*.c on embedded targets
Change-Id: I6beb4fcc394ed7d3f8dd7a097b6e998245ecf401
---
M
Review at https://gerrit.osmocom.org/2648
utils/osmo-sim-test.c: strip unused variables
Change-Id: Id577d9df5a814ad5aa00e1d04c4790d75d17ad7e
---
M utils/osmo-sim-test.c
1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/48/2648/1
Review at https://gerrit.osmocom.org/2647
gsm/gsm0411_smr.c: strip unused variable
Change-Id: I53f69913907588c45a9661c4e86e1bfb57a2418f
---
M src/gsm/gsm0411_smr.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/2647/1
Review at https://gerrit.osmocom.org/2649
fix '/include/openbsc ' to have no trailing space
The newline and $NULL manage to append a trailing space to the 'openbsc' dir.
This was broken in commit 7b6673fa06dada3ec4586b1c0d735e9df4177a48
"Consistenly format variables in */Makefile.am files"
by
Review at https://gerrit.osmocom.org/2650
gitignore: Update with new *_gen.c files and generic 'tags'
Change-Id: I6e9df474b4d93e6e20c6d19ac9ffab5b7b959143
---
M .gitignore
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: pcap_recorder: use self.filters instead of gen_filter
..
pcap_recorder: use self.filters instead of gen_filter
Change-Id:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2585
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I057a83bc20c5e664ac1778812452f189166919ba
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
1 - 100 of 111 matches
Mail list logo
