Review at https://gerrit.osmocom.org/2700
install hlr.sql in prefix/doc/osmo-hlr/
In particular I need this to start a fresh osmo-hlr instance on the
osmo-gsm-tester. Might also come in handy during packaging?
Change-Id: I08e48375814ab93691892299d34909c6d0bf12a2
---
M debian/osmo-hlr.install
Patch Set 1: Code-Review-1
pending https://gerrit.osmocom.org/2681
--
To view, visit https://gerrit.osmocom.org/2678
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbb7d921e7340739883650f778d5a7341840875
Gerrit-PatchSet: 1
Patch Set 2:
Each program will have one network address. We are not going to add a single
one for each separate protocol now. If we really need to, we can decide to
separate individual things (like BTS<->BSC separate from BSC<->MSC) but I don't
see a need at this point.
IMHO 'public' can be
Patch Set 2:
(1 comment)
> IMHO 'public' can be misunderstood as 'not loopback'.
Of course this is exactly what you meant, sorry :P
> We will name it either bind_addr or local_addr (matching the names
> we use in the VTY config).
This is about the member names for classes. The global
Review at https://gerrit.osmocom.org/2707
debug: config logging before templates: use pprint and an all-caps label
Change-Id: I0e1c1d3ce8163d5b40c17b7d0fb0847a068ced76
---
M src/osmo_gsm_tester/bts_osmotrx.py
M src/osmo_gsm_tester/bts_sysmo.py
M src/osmo_gsm_tester/osmo_nitb.py
3 files
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2714
to look at the new patch set (#2).
config: nitb template: move ip_address to nitb.ip_address
It's the NITB's address, so it should go in the nitb.* scope.
Change-Id:
Review at https://gerrit.osmocom.org/2705
resource error logging that is easier to understand
Log what a suite requested, what it has reserved and the complete resource
state.
Change-Id: Ic6887bbe5fe74a73f0e344cd4078dd7ed989cc15
---
M src/osmo_gsm_tester/resource.py
M
Review at https://gerrit.osmocom.org/2704
resources.conf: remove unused example BTS
Change-Id: I370789a4dc048cf71c1951f2eb70bfec261583a2
---
M example/resources.conf
1 file changed, 0 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
Neels Hofmeyr has abandoned this change.
Change subject: rename resource nitb_iface to eth_iface
..
Abandoned
I accidentally re-submitted with different change-id. See
https://gerrit.osmocom.org/2712
Review at https://gerrit.osmocom.org/2721
default-suites.conf: run aoip
Change-Id: I0f7d6feec5062c2aaf07eb9a7f543a4a84cb1ff7
---
M example/default-suites.conf
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/21/2721/1
diff
Review at https://gerrit.osmocom.org/2713
rename more items from nitb to bsc
A NITB is a BSC + MSC, and if a BTS talks to a NITB, it talks to the BSC part
of the NITB. Hence it makes more sense to name certain things 'bsc' instead of
'nitb', to prepare for a separate BSC process appearing
Review at https://gerrit.osmocom.org/2719
MSC+BSC: add test api to run OsmoMSC and OsmoBSC with AoIP
Change-Id: I5842e8f1cba8e8e6bedfc08540efcafe207159cb
---
M example/defaults.conf
A src/osmo_gsm_tester/osmo_bsc.py
A src/osmo_gsm_tester/osmo_hlr.py
A src/osmo_gsm_tester/osmo_mgcpgw.py
A
Review at https://gerrit.osmocom.org/2714
config: nitb template: move ip_address to nitb.ip_address
It's the NITB's address, so it should go in the nitb.* scope.
Change-Id: I71a5ef153b7156b0644253f5aa8a0c848f42ab3b
---
M src/osmo_gsm_tester/osmo_nitb.py
M
Review at https://gerrit.osmocom.org/2712
rename resource nitb_iface to ip_address
I would like to use the IP addresses also for OsmoBSC processes, so it is more
than clear now that 'nitb_iface' was the wrong naming choice.
The only distinction we may need in the future is public versus
Review at https://gerrit.osmocom.org/2720
MSC+BSC: add separate suites for AoIP: aoip_sms, aoip_debug
It would be nicer to select the network programs as scenarios, i.e.
independently from the specifics of tests that don't care whether a NITB or a
MSC+BSC is in place. See OS#2270.
For now
Review at https://gerrit.osmocom.org/2717
contrib: add jenkins-build-osmo-msc.sh
Change-Id: I2d5520cab0ad09f23e3ba49404385af80acf56f6
---
A contrib/jenkins-build-osmo-msc.sh
1 file changed, 82 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
Review at https://gerrit.osmocom.org/2715
bts: add remote_addr() function
To start an MGCPGW, we so far need the BTS address in advance (should get fixed
at some point, but so far we do).
The sysmoBTS has a fixed IP address configured. The osmo-bts-trx so far always
uses 127.0.0.1 (should
Review at https://gerrit.osmocom.org/2716
resources.conf: more IP addresses
The upcoming BSC+MSC+HLR+MGCPGW style will need four IP addresses. I found six
already configured on the main unit, so adding all of them to our
resources.conf.
Change-Id: Ie0e0ed9bb7fbd87ebe630c32ef59659117d77ed8
---
Review at https://gerrit.osmocom.org/2702
osmo_nitb.py: remove unused imports
Change-Id: I55c118c6b277a2c8cddc251e3d36571b12504266
---
M src/osmo_gsm_tester/osmo_nitb.py
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
Review at https://gerrit.osmocom.org/2701
contrib/jenkins: don't package /share/doc/libosmocore
Change-Id: Ibd2674c3f65f820a72d77c40a9e9df3e094bb41d
---
M contrib/jenkins-build-osmo-bts-sysmo.sh
M contrib/jenkins-build-osmo-bts-trx.sh
M contrib/jenkins-build-osmo-nitb.sh
3 files changed, 12
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2678
to look at the new patch set (#2).
apply rename of resource nitb_iface to ip_address
See osmo-gsm-tester change-id I829903d7b2111ab5ee106bce52d6121204a5a401
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: osmo_nitb.py: Remove unused var
..
osmo_nitb.py: Remove unused var
Change-Id: Ifb0c274aac9f8fda177992f19146807387485627
---
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2699
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb0c274aac9f8fda177992f19146807387485627
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2684
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I039e4d1908a04bf606b101ddc6a186ba67e6178e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2:
see https://gerrit.osmocom.org/2684
--
To view, visit https://gerrit.osmocom.org/2670
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I039e4d1908a04bf606b101ddc6a186ba67e6178e
Gerrit-PatchSet: 2
Gerrit-Project:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Handle termination signals to exit gracefully and prevent
resource leak
..
Handle termination signals to exit gracefully and prevent resource leak
Patch Set 3:
> The main issue is that it's a chicken-egg problem.
I think it is sufficient to store the modem path with those modems that are
currently reserved.
* get a listing of modem paths from ofono;
* read the state file and see if any of those paths are currently reserved;
* check only
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2676/2/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 70: def _wait(condition, condition_args, condition_kwargs, timeout,
timestep):
> I'm duplicating it to avoid the problem to call through
Review at https://gerrit.osmocom.org/2693
Add human-readable names for signal_ns
Change-Id: Id664355eb8305fb287e4dae0800fb20dc2f9b8cd
Related: SYS#3610
---
M include/osmocom/gprs/gprs_ns.h
M src/gb/gprs_ns.c
M src/gb/libosmogb.map
3 files changed, 14 insertions(+), 0 deletions(-)
git pull
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2692/1/src/osmo_gsm_tester/bts_sysmo.py
File src/osmo_gsm_tester/bts_sysmo.py:
Line 135: self._conf_for_ntib = config.get_defaults('nitb_bts')
I think it may be a good idea to do all the overlay stuff inside configure()
and
Review at https://gerrit.osmocom.org/2692
Verify that BTS successfully connects to NITB
Change-Id: I1bbf9ac2b05d95a113ed4ad5e93093431496d44e
---
M example/defaults.conf
M selftest/template_test/osmo-nitb.cfg.tmpl
M src/osmo_gsm_tester/bts_sysmo.py
M src/osmo_gsm_tester/osmo_nitb.py
4 files
Max has submitted this change and it was merged.
Change subject: Remove redundant test
..
Remove redundant test
After switching to libosmocoding there's no need in low-level bursts
test which is part of libosmocoding anyway.
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2693/1/src/gb/libosmogb.map
File src/gb/libosmogb.map:
Line 41: gprs_signal_ns_names;
all other NS realted symbols are prefixed 'gprs_ns_', yours is not. Please try
to align with existing conventions.
--
To view, visit
Patch Set 9:
ok, everyone except Tom has voted +1. @tom, any further feedback on this, or
shall we merge it?
--
To view, visit https://gerrit.osmocom.org/2454
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/2694
Distinguish between unsupported and invalid MCS
Previously MCS0 was incorrectly set for some of type1 header values
while according to 3GPP TS 44.060 it can only be set for type3. Fix
this:
* use EGPRS_MCS* constants instead of magic values
* do not
Review at https://gerrit.osmocom.org/2696
ofono_client: Discover modem path from imsi
Change-Id: I602604d25f51b24d87877bc8ac798525b7be61dd
---
M example/resources.conf
M src/osmo_gsm_tester/ofono_client.py
M src/osmo_gsm_tester/resource.py
M src/osmo_gsm_tester/suite.py
4 files changed, 105
Review at https://gerrit.osmocom.org/2695
event_loop: Create a global event loop to poll and wait for events
Change-Id: Iaa78bae0f053496377609b24a11ebaef3fd77598
---
A src/osmo_gsm_tester/event_loop.py
M src/osmo_gsm_tester/ofono_client.py
M src/osmo_gsm_tester/process.py
M
Review at https://gerrit.osmocom.org/2697
ofono_client: Power off modem when resource is freed
Change-Id: Ibde7573267f1c63d075cf0147ed614a4b1ff46c8
---
M src/osmo_gsm_tester/ofono_client.py
M src/osmo_gsm_tester/resource.py
M src/osmo_gsm_tester/suite.py
3 files changed, 35 insertions(+), 0
Harald Welte has submitted this change and it was merged.
Change subject: tests/Makefile.am: do not test disabled features
..
tests/Makefile.am: do not test disabled features
Compiling tests for disabled features breaks build.
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2682
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcc24b493092a5a8e3561d7642a0b4608a8beae
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/#/c/2692/1/example/defaults.conf
File example/defaults.conf:
Line 13: cell_identity: 0
> i.e. for now all BTS have a cell_identity == 0?
As you say, the issue stated here is not specific to this patch and can be
solved later in the same
Pau Espin Pedrol has abandoned this change.
Change subject: ofono_client: Discover modem path from imsi
..
Abandoned
I splitted this commit in the next patch series, it didn't get updated.
--
To view, visit
Harald Welte has submitted this change and it was merged.
Change subject: ipaccess-config: properly create swload
..
ipaccess-config: properly create swload
Instead of 20, use the actual buffer sizes of struct sw_load, which
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2018
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e34a1348a290d3f58dd830d08da65b94b3270db
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 9:
I didn't get a chance to read that yet.
--
To view, visit https://gerrit.osmocom.org/2454
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1da6d71ed0564f1d684f3a836e998d09de5f0351
Gerrit-PatchSet: 9
Gerrit-Project:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2693
to look at the new patch set (#2).
Add human-readable names for signal_ns
Change-Id: Id664355eb8305fb287e4dae0800fb20dc2f9b8cd
Related: SYS#3610
---
M
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2681/2/src/osmo_gsm_tester/osmo_nitb.py
File src/osmo_gsm_tester/osmo_nitb.py:
Line 29: eth_iface = None
The rename to eth_iface makes sense on the resource level, but the NITB and
other programs should be agnostic of
Review at https://gerrit.osmocom.org/2698
suite.py: Fix typo in variable name used during exception
Fixes a possible double exception introduced in 0ffb4144
Change-Id: I44a30f51c23e6a57ccae3483c806c0ed25d2ecf9
---
M src/osmo_gsm_tester/suite.py
1 file changed, 1 insertion(+), 1 deletion(-)
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2697
to look at the new patch set (#2).
ofono_client: Power off modem when resource is freed
Change-Id: Ibde7573267f1c63d075cf0147ed614a4b1ff46c8
---
M selftest/suite_test.py
M
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2681/2/src/osmo_gsm_tester/osmo_nitb.py
File src/osmo_gsm_tester/osmo_nitb.py:
Line 29: eth_iface = None
> The rename to eth_iface makes sense on the resource level, but the NITB and
AFAIU it should still be possible for the BSC to
Review at https://gerrit.osmocom.org/2699
osmo_nitb.py: Remove unused var
Change-Id: Ifb0c274aac9f8fda177992f19146807387485627
---
M src/osmo_gsm_tester/osmo_nitb.py
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2692
to look at the new patch set (#2).
Verify that BTS successfully connects to NITB
The current API to request the NITB if a BTS is connected has many
drawbacks. Afaik,
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: suite.py: Fix typo in variable name used during exception
..
suite.py: Fix typo in variable name used during exception
Fixes a possible double
Patch Set 1: Code-Review+2
would be good to have a regression test for this, but will touch this code soon
(improving the output that reports resource details on error) and will see
about it then
--
To view, visit https://gerrit.osmocom.org/2698
To unsubscribe, visit
54 matches
Mail list logo
