Change in libosmo-sccp[master]: Make pointcode width function public

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11709 ) Change subject: Make pointcode width function public .. Patch Set 2: Code-Review-1 Why is it needed to be public? Please state so in

Change in libosmo-sccp[master]: SS7: safeguard against wrong number of pointcode component

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11707 ) Change subject: SS7: safeguard against wrong number of pointcode component .. Patch Set 1: Code-Review-1 (1 comment) This function is

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11722 ) Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error .. Patch Set 1: (1 comment)

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11727 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: > Can you add a link here as a comment to the commit adding this to >

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Code-Review+1 > > What about fixing the Makefile lines

Change in libosmo-sccp[master]: Log ip:port for created SS7 server

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11708 ) Change subject: Log ip:port for created SS7 server .. Patch Set 2: Code-Review-1 (1 comment)

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: make clean: also rm *.html

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11723 ) Change subject: Makefile.asciidoc.inc: make clean: also rm *.html .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11727 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: Can you add a link here as a comment to the commit adding

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11727 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: move project specific manuals to their own repos

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11725 Change subject: move project specific manuals to their own repos .. move project specific manuals to their own repos * use autotools (so we can

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11722 Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error .. Makefile.asciidoc.inc: always exit 1 on a2x error a2x wraps asciidoc. When a2x

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11724 Change subject: unix-time-to-fmt.py: fix crash without argument .. unix-time-to-fmt.py: fix crash without argument Print "unknown" to stdout when

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: make clean: also rm *.html

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11723 Change subject: Makefile.asciidoc.inc: make clean: also rm *.html .. Makefile.asciidoc.inc: make clean: also rm *.html HTML files get created when

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11722 ) Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error .. Patch Set 1: (1 comment)

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Wouldn't it make more sense to take now() as date or 0?

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Why is this needed? Where is it called without

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11727 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: > > Can you add a link here as a comment to the commit

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: What about fixing the Makefile lines to include -C or

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: > What about fixing the Makefile lines to include -C or whatever

Change in docker-playground[master]: Add ttcn3-bscnat-test docker image

2018-11-12 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11657 ) Change subject: Add ttcn3-bscnat-test docker image .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11657 To unsubscribe,

Change in osmo-gsm-tester[master]: iperf3: Fix parsing of incorrect json from iperf3

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11712 ) Change subject: iperf3: Fix parsing of incorrect json from iperf3 .. iperf3: Fix parsing of incorrect json from iperf3

Change in osmo-bsc[master]: vty: add command to show TRX selectively

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11721 ) Change subject: vty: add command to show TRX selectively .. Patch Set 1: Code-Review-1 (1 comment)

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11727 Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. merge_doc.xsl: move to osmo-gsm-manuals.git Allows building the manuals without the

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: > Where is it called without arguments and why?

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11722 ) Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error .. Patch Set 1: Code-Review+2 -- To view, visit

Change in docker-playground[master]: Add ttcn3-bscnat-test docker image

2018-11-12 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11657 ) Change subject: Add ttcn3-bscnat-test docker image .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/11657 To unsubscribe,

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 1: (2 comments)

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Keith Whyte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11716 to look at the new patch set (#2). Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Allow

Change in osmo-gsm-manuals[master]: move project specific files to their own repos

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11738 ) Change subject: move project specific files to their own repos .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: merge_doc.xsl: move from libosmocore.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11736 ) Change subject: merge_doc.xsl: move from libosmocore.git .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/11727 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Abandoned New version with updated depends ID:

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11739 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: merge_doc.xsl: move from libosmocore.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11736 ) Change subject: merge_doc.xsl: move from libosmocore.git .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11735 ) Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t .. Patch Set 1: Code-Review-1 (7 comments)

Change in osmo-sgsn[master]: fix bogus error check in gprs_sndcp_comp_create()

2018-11-12 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11730 Change subject: fix bogus error check in gprs_sndcp_comp_create() .. fix bogus error check in gprs_sndcp_comp_create() The function

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add missing field in tr_BSSMAP_HandoverPerformed te...

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11731 ) Change subject: BSSMAP_Templates: Add missing field in tr_BSSMAP_HandoverPerformed template .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed...

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11732 ) Change subject: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed template .. Patch Set 1: Code-Review+2 -- To

Change in osmo-gsm-manuals[master]: Makefile: move dep-check code to check-depends.sh

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11737 ) Change subject: Makefile: move dep-check code to check-depends.sh .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11739 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: The file gets added here:

Change in osmo-msc[master]: move project specific manuals to their own repos

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11726 ) Change subject: move project specific manuals to their own repos .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11728 Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. gsm0808: add message generator for BSSMAP HANDOVER PERFORMED We

Change in osmo-sgsn[master]: fix bogus assertion in encode_comp_field()

2018-11-12 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11729 Change subject: fix bogus assertion in encode_comp_field() .. fix bogus assertion in encode_comp_field() Fix an obvious logic bug in an

Change in osmo-sgsn[master]: fix bogus assertion in encode_comp_field()

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11729 ) Change subject: fix bogus assertion in encode_comp_field() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11734 ) Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho .. Patch Set 1: (1 comment)

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11739 Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. merge_doc.xsl: move to osmo-gsm-manuals.git Allows building the manuals without the

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 2: Code-Review+1 (2 comments)

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 2: (2 comments)

Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover

2018-11-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11733 Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover .. BSC_Tests: expect a HANDOVER PERFORMED message on internal

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed...

2018-11-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11732 Change subject: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed template .. BSSMAP_Templates: do not match on omit in

Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

2018-11-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11734 Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho .. handover_fsm: send HANDOVER PERFORMED msg on internal ho When an

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add missing field in tr_BSSMAP_HandoverPerformed te...

2018-11-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11731 Change subject: BSSMAP_Templates: Add missing field in tr_BSSMAP_HandoverPerformed template .. BSSMAP_Templates: Add missing field in

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11735 Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t .. bts: Allocate TRX for BTS dynamically, deprecate -t No need to

Change in osmo-gsm-manuals[master]: move project specific files to their own repos

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11738 Change subject: move project specific files to their own repos .. move project specific files to their own repos Related: OS#3385 Change-Id:

Change in osmo-gsm-manuals[master]: Makefile: move dep-check code to check-depends.sh

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11737 Change subject: Makefile: move dep-check code to check-depends.sh .. Makefile: move dep-check code to check-depends.sh Make it possible to run the

Change in osmo-gsm-manuals[master]: merge_doc.xsl: move from libosmocore.git

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11736 Change subject: merge_doc.xsl: move from libosmocore.git .. merge_doc.xsl: move from libosmocore.git Allow building manuals without the libosmocore

Change in osmo-sgsn[master]: fix bogus error check in gprs_sndcp_comp_create()

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11730 ) Change subject: fix bogus error check in gprs_sndcp_comp_create() .. Patch Set 1: (1 comment)

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed...

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11732 ) Change subject: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed template .. Patch Set 1: Code-Review+1 -- To

Change in osmo-sgsn[master]: fix bogus assertion in encode_comp_field()

2018-11-12 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11729 ) Change subject: fix bogus assertion in encode_comp_field() .. fix bogus assertion in encode_comp_field() Fix an obvious logic

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 1: (4 comments)

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11735 to look at the new patch set (#2). Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11735 ) Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: support odd-length calling MSISDN in MSC tests

2018-11-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11743 ) Change subject: support odd-length calling MSISDN in MSC tests .. Patch Set 1: (1 comment)

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-12 Thread Stefan Sperling
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11656 to look at the new patch set (#2). Change subject: use enums consistently instead of falling back to int

Change in pysim[master]: pySim/transport: introduce Calypso based reader interface

2018-11-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/11480 ) Change subject: pySim/transport: introduce Calypso based reader interface .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-gsm-manuals[master]: Makefile.common.inc: add publish target

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11740 ) Change subject: Makefile.common.inc: add publish target .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11735 ) Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t .. Patch Set 1: (1 comment)

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #305

2018-11-12 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Change in osmo-bsc[master]: abis_rsl.c: drop unused enum sacch_deact

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11665 ) Change subject: abis_rsl.c: drop unused enum sacch_deact .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11665 To

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11735 to look at the new patch set (#3). Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: hlr: Fix DTE by requesting the correct type

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11637 ) Change subject: hlr: Fix DTE by requesting the correct type .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: hlr: Fix DTE by requesting the correct type

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11637 ) Change subject: hlr: Fix DTE by requesting the correct type .. hlr: Fix DTE by requesting the correct type Previous commit

Change in osmo-ttcn3-hacks[master]: hlr: Fix DTE by requesting the correct type

2018-11-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11637 ) Change subject: hlr: Fix DTE by requesting the correct type .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: Makefile.common.inc: add publish target

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11740 Change subject: Makefile.common.inc: add publish target .. Makefile.common.inc: add publish target Publishes all generated PDFs to

Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11741 Change subject: gitignore: add make/ and net/ (with exceptions) .. gitignore: add make/ and net/ (with exceptions) Ignore all files and folders

Change in pysim[master]: pySim/transport: introduce Calypso based reader interface

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11480 ) Change subject: pySim/transport: introduce Calypso based reader interface .. pySim/transport: introduce Calypso based reader

Change in pysim[master]: pySim-*.py: add command line option for Calypso reader

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11482 ) Change subject: pySim-*.py: add command line option for Calypso reader .. pySim-*.py: add command line option for Calypso reader

Change in pysim[master]: pySim-*.py: refactor card reader driver initialization

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11481 ) Change subject: pySim-*.py: refactor card reader driver initialization .. pySim-*.py: refactor card reader driver initialization

Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11742 Change subject: coverity: gscon_forget_lchan: squelch forward-null .. coverity: gscon_forget_lchan: squelch forward-null conn->fi should

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Keith Whyte
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11716 to look at the new patch set (#3). Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

Change in osmo-ttcn3-hacks[master]: support odd-length calling MSISDN in MSC tests

2018-11-12 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11743 Change subject: support odd-length calling MSISDN in MSC tests .. support odd-length calling MSISDN in MSC tests MSC tests were unable to

Change in osmo-ttcn3-hacks[master]: support odd-length calling MSISDN in MSC tests

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11743 ) Change subject: support odd-length calling MSISDN in MSC tests .. Patch Set 1: Code-Review+1 (1 comment)

Change in pysim[master]: pySim-*.py: refactor card reader driver initialization

2018-11-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/11481 ) Change subject: pySim-*.py: refactor card reader driver initialization .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: always directly send BSSMAP Clear Request

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11700 ) Change subject: always directly send BSSMAP Clear Request .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11700 To

Change in osmo-ttcn3-hacks[master]: bsc: add inter-bsc ho incoming failure tests

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11699 ) Change subject: bsc: add inter-bsc ho incoming failure tests .. Patch Set 1: (1 comment)

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 1: (1 comment)

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

2018-11-12 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11722 ) Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error .. Makefile.asciidoc.inc: always exit 1 on a2x error a2x wraps

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message and IEs

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11751 Change subject: GSUP/SMS: introduce READY-FOR-SM message and IEs .. GSUP/SMS: introduce READY-FOR-SM message and IEs According to 3GPP TS

Change in libosmo-abis[master]: osmo_ortp: Log domain and fix strings without endl char

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11744 Change subject: osmo_ortp: Log domain and fix strings without endl char .. osmo_ortp: Log domain and fix strings without endl char

Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11742 ) Change subject: coverity: gscon_forget_lchan: squelch forward-null .. Patch Set 1: (1 comment)

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: make VTY interface available

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11701 ) Change subject: BSC_ConnectionHandler: make VTY interface available .. Patch Set 2: Code-Review+2 added bonus if you include the change-id

Change in osmo-gsm-manuals[master]: Makefile.common.inc: add publish target

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11740 ) Change subject: Makefile.common.inc: add publish target .. Patch Set 1: I'm confused, don't we already publish the manuals automatically?!

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 1: Code-Review-1 (2 comments)

Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11734 ) Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho .. Patch Set 1: Code-Review+1 (4 comments) patch looks good, but

Change in osmo-msc[master]: Store subscriber's cell identity

2018-11-12 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11746 Change subject: Store subscriber's cell identity .. Store subscriber's cell identity It's defined similar to LAC and could be potentially useful for

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: introduce ctrl interface

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11697 ) Change subject: BSC_ConnectionHandler: introduce ctrl interface .. Patch Set 4: Code-Review+2 (1 comment) though I'm not familiar I'm

Change in osmo-msc[master]: vlr: use unused is_ps parameter in vlr_subscr_req_lu()

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11563 ) Change subject: vlr: use unused is_ps parameter in vlr_subscr_req_lu() .. Patch Set 1: Code-Review-1 let's rather drop the argument and

Change in osmo-dev[master]: gits: use git plumbing commands

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11706 ) Change subject: gits: use git plumbing commands .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11706 To

Change in osmo-dev[master]: gits: use git plumbing commands

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11706 ) Change subject: gits: use git plumbing commands .. gits: use git plumbing commands Instead of 'git status' and 'git branch', which

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. Allows

  1   2   >