Change in libosmocore[master]: platform independence fix: tdef range tests

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12841 )

Change subject: platform independence fix: tdef range tests
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2
Gerrit-Change-Number: 12841
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 06 Feb 2019 01:05:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: platform independence fix: tdef range tests

[Neels Hofmeyr]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12841

to look at the new patch set (#4).

Change subject: platform independence fix: tdef range tests
..

platform independence fix: tdef range tests

Run INT_MAX and ULONG_MAX related tests only manually, remove from automatic
testing. This will hopefully fix recent build failures on various platforms.

Add a 64 bit output example for expected results when invoking
`./tdef_test range'. This is not checked automatically and merely serves for
manual reference.

For vty tests, use 32bit max values instead of INT_MAX and ULONG_MAX.

Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2
---
M tests/Makefile.am
M tests/tdef/tdef_test.c
M tests/tdef/tdef_test.ok
A tests/tdef/tdef_test_range_64bit.ok
M tests/tdef/tdef_vty_test_config_root.c
M tests/tdef/tdef_vty_test_config_root.vty
M tests/tdef/tdef_vty_test_config_subnode.c
M tests/tdef/tdef_vty_test_config_subnode.vty
8 files changed, 490 insertions(+), 133 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12841/4
--
To view, visit https://gerrit.osmocom.org/12841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2
Gerrit-Change-Number: 12841
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: platform independence fix: tdef range tests

[Neels Hofmeyr]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12841

to look at the new patch set (#3).

Change subject: platform independence fix: tdef range tests
..

platform independence fix: tdef range tests

Run INT_MAX and ULONG_MAX related tests only manually, remove from automatic
testing. This will hopefully fix recent build failures on various platforms.

Add a 64 bit output example for expected results when invoking
`./tdef_test range'. This is not checked automatically and merely serves for
manual reference.

For vty tests, use 32bit max values instead of INT_MAX and ULONG_MAX.

Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2
---
M tests/Makefile.am
M tests/tdef/tdef_test.c
M tests/tdef/tdef_test.ok
A tests/tdef/tdef_test_range_64bit.ok
M tests/tdef/tdef_vty_test_config_root.c
M tests/tdef/tdef_vty_test_config_root.vty
M tests/tdef/tdef_vty_test_config_subnode.c
M tests/tdef/tdef_vty_test_config_subnode.vty
8 files changed, 488 insertions(+), 131 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12841/3
--
To view, visit https://gerrit.osmocom.org/12841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2
Gerrit-Change-Number: 12841
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: platform independence fix: tdef range tests

[Neels Hofmeyr]

Neels Hofmeyr has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/12841 )

Change subject: platform independence fix: tdef range tests
..

platform independence fix: tdef range tests

Run INT_MAX and ULONG_MAX related tests only manually, remove from automatic
testing. This will hopefully fix recent build failures on various platforms.

Add a 64 bit output example for expected results when invoking
`./tdef_test range'. This is not checked automatically and merely serves for
manual reference.

For vty tests, use 32bit max values instead of INT_MAX and ULONG_MAX.

Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2
---
M tests/Makefile.am
M tests/tdef/tdef_test.c
M tests/tdef/tdef_test.ok
A tests/tdef/tdef_test_range_64bit.ok
M tests/tdef/tdef_vty_test_config_root.c
M tests/tdef/tdef_vty_test_config_root.vty
M tests/tdef/tdef_vty_test_config_subnode.c
M tests/tdef/tdef_vty_test_config_subnode.vty
8 files changed, 471 insertions(+), 114 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12841/2
--
To view, visit https://gerrit.osmocom.org/12841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2
Gerrit-Change-Number: 12841
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-CC: Jenkins Builder (102)

Change in osmo-bsc[master]: comments: clarify usage of conn.assignment and .handover scopes

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12842


Change subject: comments: clarify usage of conn.assignment and .handover scopes
..

comments: clarify usage of conn.assignment and .handover scopes

Change-Id: I7ef602c3ce086aecbc3ae3ae6d3fd33ad2b9f85c
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 13 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/12842/1

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 867a46c..389f9a5 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -99,6 +99,9 @@
SUBSCR_SCCP_ST_CONNECTED
 };

+/* Information retrieved during an Assignment Request from the MSC. This used 
as storage of the Assignment instructions
+ * parsed from the Assignment Request message, to pass on until the gscon and 
assignment FSMs have decided whether an
+ * Assignment is actually going to be carried out. Must remain unchanged after 
initial decoding. */
 struct assignment_request {
bool aoip;

@@ -112,6 +115,9 @@
uint16_t s15_s0;
 };

+/* State of an ongoing Assignment, while the assignment_fsm is still busy. 
This serves as state separation to keep the
+ * currently used lchan and gscon unmodified until the outcome of an 
Assignment is known. If the Assignment fails, this
+ * state is simply discarded, and the gscon carries on with the original lchan 
remaining unchanged. */
 struct assignment_fsm_data {
struct assignment_request req;
bool requires_voice_stream;
@@ -204,12 +210,17 @@
/* back pointers */
struct gsm_network *network;

-   /* the primary / currently active lchan to the BTS/subscriber */
+   /* the primary / currently active lchan to the BTS/subscriber. During 
Assignment and Handover, separate lchans
+* are kept in the .assignment or .handover sub-structs, respectively, 
so that this lchan remains unaffected
+* until Assignment or Handover have actually succeeded. */
struct gsm_lchan *lchan;

+   /* Only valid during an ongoing Assignment; might be overwritten at any 
time by a failed Assignment attempt.
+* Once an Assignment was successful, all relevant state must be copied 
out of this sub-struct. */
struct assignment_fsm_data assignment;

-   /* handover information, if a handover is pending for this conn. */
+   /* handover information, if a handover is pending for this conn. Valid 
only during an ongoing Handover
+* operation. If a Handover was successful, all relevant state must be 
copied out of this sub-struct. */
struct handover ho;

/* buffer/cache for classmark of the ME of the subscriber */

--
To view, visit https://gerrit.osmocom.org/12842
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ef602c3ce086aecbc3ae3ae6d3fd33ad2b9f85c
Gerrit-Change-Number: 12842
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-bsc[master]: handover_fsm: do not access conn->assignment.req, it may be outdated

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12734 )

Change subject: handover_fsm: do not access conn->assignment.req, it may be 
outdated
..


Patch Set 2:

> Patch Set 1:
>
> >conn->assignment.* values are only valid during an ongoing assignment
>
> Maybe add clarifying comment next to them to make sure this mistake won't 
> happen again?

ack, i've now added https://gerrit.osmocom.org/#/c/osmo-bsc/+/12842


--
To view, visit https://gerrit.osmocom.org/12734
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8018fd9d56421f2ab7be91703018f6d6f21c929
Gerrit-Change-Number: 12734
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Max 
Gerrit-Comment-Date: Wed, 06 Feb 2019 00:31:48 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmocore[master]: platform independence fix: tdef range tests

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12841


Change subject: platform independence fix: tdef range tests
..

platform independence fix: tdef range tests

Run INT_MAX and ULONG_MAX related tests only manually, remove from automatic
testing. This will hopefully fix recent build failures on various platforms.

Add a 64 bit output example for expected results when invoking
`./tdef_test range'. This is not checked automatically and merely serves for
manual reference.

Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2
---
M tests/Makefile.am
M tests/tdef/tdef_test.c
M tests/tdef/tdef_test.ok
A tests/tdef/tdef_test_range_64bit.ok
4 files changed, 457 insertions(+), 100 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12841/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 54fb11f..63f3959 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -300,6 +300,7 @@
 oap/oap_client_test.ok oap/oap_client_test.err \
 vty/vty_transcript_test.vty\
 tdef/tdef_test.ok \
+tdef/tdef_test_range_64bit.ok \
 tdef/tdef_vty_test_config_root.vty \
 tdef/tdef_vty_test_config_subnode.vty \
 tdef/tdef_vty_test_dynamic.vty \
diff --git a/tests/tdef/tdef_test.c b/tests/tdef/tdef_test.c
index 682c7ac..c08a158 100644
--- a/tests/tdef/tdef_test.c
+++ b/tests/tdef/tdef_test.c
@@ -49,21 +49,12 @@
/* test conversions */
{ .T=1000, .default_val=2*1000, .unit=OSMO_TDEF_MS, .desc="two seconds 
from ms" },
{ .T=1001, .default_val=60*1000, .unit=OSMO_TDEF_MS, .desc="one minute 
from ms" },
-   { .T=1002, .default_val=(ULONG_MAX/60), .unit=OSMO_TDEF_M, 
.desc="almost too many seconds" },
-   { .T=1003, .default_val=ULONG_MAX, .unit=OSMO_TDEF_M, .desc="too many 
seconds" },
{ .T=1004, .default_val=1, .unit=OSMO_TDEF_MS, .desc="one ms" },
{ .T=1005, .default_val=0, .unit=OSMO_TDEF_MS, .desc="zero ms" },
{ .T=1006, .default_val=0, .unit=OSMO_TDEF_S, .desc="zero s" },
{ .T=1007, .default_val=0, .unit=OSMO_TDEF_M, .desc="zero m" },
{ .T=1008, .default_val=0, .unit=OSMO_TDEF_CUSTOM, .desc="zero" },

-   /* test range */
-   { .T=INT_MAX, .default_val=ULONG_MAX, .unit=OSMO_TDEF_S, .desc="very 
large" },
-   { .T=INT_MAX-1, .default_val=ULONG_MAX-1, .unit=OSMO_TDEF_S, 
.desc="very large" },
-   { .T=INT_MAX-2, .default_val=LONG_MAX, .unit=OSMO_TDEF_S, .desc="very 
large" },
-   { .T=INT_MAX-3, .default_val=ULONG_MAX, .unit=OSMO_TDEF_M, .desc="very 
large in minutes" },
-   { .T=INT_MIN, .default_val=ULONG_MAX, .unit=OSMO_TDEF_S, 
.desc="negative" },
-
{ .T=0, .default_val=1, .unit=OSMO_TDEF_CUSTOM, .desc="zero" },

/* no desc */
@@ -72,13 +63,26 @@
{}  //  <-- important! last entry shall be zero
 };

-#define print_tdef_get(T, AS_UNIT) do { \
-   unsigned long val = osmo_tdef_get(tdefs, T, AS_UNIT, 999); \
+static struct osmo_tdef tdefs_range[] = {
+   { .T=1002, .default_val=(ULONG_MAX/60), .unit=OSMO_TDEF_M, 
.desc="almost too many seconds" },
+   { .T=1003, .default_val=ULONG_MAX, .unit=OSMO_TDEF_M, .desc="too many 
seconds" },
+
+   { .T=INT_MAX, .default_val=ULONG_MAX, .unit=OSMO_TDEF_S, .desc="very 
large" },
+   { .T=INT_MAX-1, .default_val=ULONG_MAX-1, .unit=OSMO_TDEF_S, 
.desc="very large" },
+   { .T=INT_MAX-2, .default_val=LONG_MAX, .unit=OSMO_TDEF_S, .desc="very 
large" },
+   { .T=INT_MAX-3, .default_val=ULONG_MAX, .unit=OSMO_TDEF_M, .desc="very 
large in minutes" },
+   { .T=INT_MIN, .default_val=ULONG_MAX, .unit=OSMO_TDEF_S, 
.desc="negative" },
+
+   {}
+};
+
+#define print_tdef_get(TDEFS, T, AS_UNIT) do { \
+   unsigned long val = osmo_tdef_get(TDEFS, T, AS_UNIT, 999); \
printf("osmo_tdef_get(tdefs, %d, %s, 999)\t= %lu\n", T, 
osmo_tdef_unit_name(AS_UNIT), val); \
} while (0)

-#define print_tdef_get_short(T, AS_UNIT) do { \
-   unsigned long val = osmo_tdef_get(tdefs, T, AS_UNIT, 999); \
+#define print_tdef_get_short(TDEFS, T, AS_UNIT) do { \
+   unsigned long val = osmo_tdef_get(TDEFS, T, AS_UNIT, 999); \
printf("osmo_tdef_get(%d, %s)\t= %lu\n", T, 
osmo_tdef_unit_name(AS_UNIT), val); \
} while (0)

@@ -95,7 +99,7 @@
printf("\n");
 }

-static void test_tdef_get()
+static void test_tdef_get(bool test_range)
 {
int i;
enum osmo_tdef_unit as_unit;
@@ -108,7 +112,18 @@
unsigned int T = tdefs[i].T;
print_tdef_info(T);
for (as_unit = OSMO_TDEF_S; as_unit <= OSMO_TDEF_CUSTOM; 
as_unit++) {
-   print_tdef_get_short(T, as_unit);
+   print_tdef_get_short(tdefs, T, as_unit);
+   }
+   }
+
+   

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  357s]  #include 
[  357s]   ^~~~
[  357s] compilation terminated.
[  357s] Makefile:518: recipe for target 'sgs_server.o' failed
[  357s] make[4]: *** [sgs_server.o] Error 1
[  357s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  357s] Makefile:424: recipe for target 'all-recursive' failed
[  357s] make[3]: *** [all-recursive] Error 1
[  357s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  357s] Makefile:464: recipe for target 'all-recursive' failed
[  357s] make[2]: *** [all-recursive] Error 1
[  357s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  357s] Makefile:396: recipe for target 'all' failed
[  357s] make[1]: *** [all] Error 2
[  357s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  357s] dh_auto_build: make -j1 returned exit code 2
[  357s] debian/rules:45: recipe for target 'build' failed
[  357s] make: *** [build] Error 2
[  357s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  357s] 
[  357s] lamb62 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:24:07 UTC 2019.
[  357s] 
[  357s] ### VM INTERACTION START ###
[  360s] [  336.842064] sysrq: SysRq : Power Off
[  360s] [  336.848483] reboot: Power down
[  360s] ### VM INTERACTION END ###
[  360s] 
[  360s] lamb62 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:24:11 UTC 2019.
[  360s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_18.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_18.10/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_18.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  134s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized 
-Werror=memset-transposed-args -Werror=null-dereference 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o osmo_msc.o 
osmo_msc.c
[  134s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized 
-Werror=memset-transposed-args -Werror=null-dereference 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o 
ctrl_commands.o ctrl_commands.c
[  134s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized 
-Werror=memset-transposed-args -Werror=null-dereference 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o 
sgs_iface.o sgs_iface.c
[  135s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized 
-Werror=memset-transposed-args -Werror=null-dereference 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o 
sgs_server.o sgs_server.c
[  135s] sgs_server.c:28:10: fatal error: netinet/sctp.h: No such file or 
directory
[  135s]  #include 
[  135s]   ^~~~
[  135s] compilation terminated.
[  135s] make[4]: *** [Makefile:542: sgs_server.o] Error 1
[  135s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  135s] make[3]: *** [Makefile:424: all-recursive] Error 1
[  135s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  135s] make[2]: *** [Makefile:464: all-recursive] Error 1
[  135s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  135s] make[1]: *** [Makefile:396: all] Error 2
[  135s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  135s] dh_auto_build: make -j1 returned exit code 2
[  135s] make: *** [debian/rules:45: build] Error 2
[  135s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  135s] 
[  135s] lamb11 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:20:23 UTC 2019.
[  135s] 
[  135s] ### VM INTERACTION START ###
[  138s] [  125.523110] sysrq: SysRq : Power Off
[  138s] [  125.532726] reboot: Power down
[  138s] ### VM INTERACTION END ###
[  138s] 
[  138s] lamb11 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:20:27 UTC 2019.
[  138s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  188s]  #include 
[  188s]   ^~~~
[  188s] compilation terminated.
[  188s] Makefile:518: recipe for target 'sgs_server.o' failed
[  188s] make[4]: *** [sgs_server.o] Error 1
[  188s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  188s] Makefile:424: recipe for target 'all-recursive' failed
[  188s] make[3]: *** [all-recursive] Error 1
[  188s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  188s] Makefile:464: recipe for target 'all-recursive' failed
[  188s] make[2]: *** [all-recursive] Error 1
[  188s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  188s] Makefile:396: recipe for target 'all' failed
[  188s] make[1]: *** [all] Error 2
[  188s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  188s] dh_auto_build: make -j1 returned exit code 2
[  188s] debian/rules:45: recipe for target 'build' failed
[  188s] make: *** [build] Error 2
[  188s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  188s] 
[  188s] lamb24 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:11:31 UTC 2019.
[  188s] 
[  188s] ### VM INTERACTION START ###
[  192s] [  176.889964] sysrq: SysRq : Power Off
[  192s] [  176.932708] reboot: Power down
[  192s] ### VM INTERACTION END ###
[  192s] 
[  192s] lamb24 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:11:36 UTC 2019.
[  192s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[   97s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security 
-Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o 
sgs_server.o sgs_server.c
[   97s] sgs_server.c:28:26: fatal error: netinet/sctp.h: No such file or 
directory
[   97s] compilation terminated.
[   97s] Makefile:518: recipe for target 'sgs_server.o' failed
[   97s] make[4]: *** [sgs_server.o] Error 1
[   97s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   97s] Makefile:424: recipe for target 'all-recursive' failed
[   97s] make[3]: *** [all-recursive] Error 1
[   97s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   97s] Makefile:464: recipe for target 'all-recursive' failed
[   97s] make[2]: *** [all-recursive] Error 1
[   97s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   97s] Makefile:396: recipe for target 'all' failed
[   97s] make[1]: *** [all] Error 2
[   97s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   97s] dh_auto_build: make -j1 returned exit code 2
[   97s] debian/rules:45: recipe for target 'build' failed
[   97s] make: *** [build] Error 2
[   97s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   97s] 
[   97s] lamb04 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:09:51 UTC 2019.
[   97s] 
[   97s] ### VM INTERACTION START ###
[  100s] [   89.408145] sysrq: SysRq : Power Off
[  100s] [   89.413687] reboot: Power down
[  100s] ### VM INTERACTION END ###
[  100s] 
[  100s] lamb04 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:09:55 UTC 2019.
[  100s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-msc failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  155s]  #include 
[  155s]   ^
[  155s] compilation terminated.
[  155s] Makefile:518: recipe for target 'sgs_server.o' failed
[  155s] make[4]: *** [sgs_server.o] Error 1
[  155s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  155s] Makefile:424: recipe for target 'all-recursive' failed
[  155s] make[3]: *** [all-recursive] Error 1
[  155s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  155s] Makefile:464: recipe for target 'all-recursive' failed
[  155s] make[2]: *** [all-recursive] Error 1
[  155s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  155s] Makefile:396: recipe for target 'all' failed
[  155s] make[1]: *** [all] Error 2
[  155s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  155s] dh_auto_build: make -j1 returned exit code 2
[  155s] debian/rules:45: recipe for target 'build' failed
[  155s] make: *** [build] Error 2
[  155s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  155s] 
[  155s] armbuild02 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:08:16 UTC 2019.
[  155s] 
[  155s] ### VM INTERACTION START ###
[  158s] [  130.787800] SysRq : Power Off
[  158s] [  130.789521] reboot: Power down
[  158s] ### VM INTERACTION END ###
[  158s] 
[  158s] armbuild02 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:08:20 UTC 2019.
[  158s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_18.04/i586

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  169s]  #include 
[  169s]   ^~~~
[  169s] compilation terminated.
[  169s] Makefile:518: recipe for target 'sgs_server.o' failed
[  169s] make[4]: *** [sgs_server.o] Error 1
[  169s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  169s] Makefile:424: recipe for target 'all-recursive' failed
[  169s] make[3]: *** [all-recursive] Error 1
[  169s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  169s] Makefile:464: recipe for target 'all-recursive' failed
[  169s] make[2]: *** [all-recursive] Error 1
[  169s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  169s] Makefile:396: recipe for target 'all' failed
[  169s] make[1]: *** [all] Error 2
[  169s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  169s] dh_auto_build: make -j1 returned exit code 2
[  169s] debian/rules:45: recipe for target 'build' failed
[  169s] make: *** [build] Error 2
[  169s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  169s] 
[  169s] cloud111 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:06:06 UTC 2019.
[  169s] 
[  169s] ### VM INTERACTION START ###
[  172s] [  151.985503] sysrq: SysRq : Power Off
[  172s] [  151.998789] reboot: Power down
[  174s] ### VM INTERACTION END ###
[  174s] 
[  174s] cloud111 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:06:11 UTC 2019.
[  174s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  113s]  #include 
[  113s]   ^
[  113s] compilation terminated.
[  113s] Makefile:518: recipe for target 'sgs_server.o' failed
[  113s] make[4]: *** [sgs_server.o] Error 1
[  113s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  113s] Makefile:424: recipe for target 'all-recursive' failed
[  113s] make[3]: *** [all-recursive] Error 1
[  113s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  113s] Makefile:464: recipe for target 'all-recursive' failed
[  113s] make[2]: *** [all-recursive] Error 1
[  113s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  113s] Makefile:396: recipe for target 'all' failed
[  113s] make[1]: *** [all] Error 2
[  113s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  113s] dh_auto_build: make -j1 returned exit code 2
[  113s] debian/rules:45: recipe for target 'build' failed
[  113s] make: *** [build] Error 2
[  113s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  113s] 
[  113s] morla5 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:06:11 UTC 2019.
[  113s] 
[  113s] ### VM INTERACTION START ###
[  116s] [  102.357955] sysrq: SysRq : Power Off
[  116s] [  102.406231] reboot: Power down
[  117s] ### VM INTERACTION END ###
[  117s] 
[  117s] morla5 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:06:16 UTC 2019.
[  117s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l

Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  139s]  #include 
[  139s]   ^
[  139s] compilation terminated.
[  139s] Makefile:518: recipe for target 'sgs_server.o' failed
[  139s] make[4]: *** [sgs_server.o] Error 1
[  139s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  139s] Makefile:424: recipe for target 'all-recursive' failed
[  139s] make[3]: *** [all-recursive] Error 1
[  139s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  139s] Makefile:464: recipe for target 'all-recursive' failed
[  139s] make[2]: *** [all-recursive] Error 1
[  139s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  139s] Makefile:396: recipe for target 'all' failed
[  139s] make[1]: *** [all] Error 2
[  139s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  139s] dh_auto_build: make -j1 returned exit code 2
[  139s] debian/rules:45: recipe for target 'build' failed
[  139s] make: *** [build] Error 2
[  139s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  139s] 
[  139s] armbuild01 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:06:02 UTC 2019.
[  139s] 
[  139s] ### VM INTERACTION START ###
[  142s] [  117.450051] SysRq : Power Off
[  142s] [  117.451685] reboot: Power down
[  142s] ### VM INTERACTION END ###
[  142s] 
[  142s] armbuild01 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:06:05 UTC 2019.
[  142s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_18.04/i586

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  212s]   GSM48_IE_CHDES_2_AFTER
[  212s] gsm_04_08_rr.c:316:22: note: each undeclared identifier is reported 
only once for each function it appears in
[  212s] cc1: some warnings being treated as errors
[  212s] Makefile:627: recipe for target 'gsm_04_08_rr.o' failed
[  212s] make[4]: *** [gsm_04_08_rr.o] Error 1
[  212s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc'
[  212s] Makefile:409: recipe for target 'all-recursive' failed
[  212s] make[3]: *** [all-recursive] Error 1
[  212s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  212s] Makefile:447: recipe for target 'all-recursive' failed
[  212s] make[2]: *** [all-recursive] Error 1
[  212s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  212s] Makefile:379: recipe for target 'all' failed
[  212s] make[1]: *** [all] Error 2
[  212s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  212s] dh_auto_build: make -j1 returned exit code 2
[  212s] debian/rules:45: recipe for target 'build' failed
[  212s] make: *** [build] Error 2
[  212s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  212s] 
[  212s] lamb20 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
21:04:02 UTC 2019.
[  212s] 
[  212s] ### VM INTERACTION START ###
[  216s] [  203.412218] sysrq: SysRq : Power Off
[  216s] [  203.429826] reboot: Power down
[  216s] ### VM INTERACTION END ###
[  216s] 
[  216s] lamb20 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
21:04:07 UTC 2019.
[  216s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_17.10/i586

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  115s]  #include 
[  115s]   ^~~~
[  115s] compilation terminated.
[  115s] Makefile:518: recipe for target 'sgs_server.o' failed
[  115s] make[4]: *** [sgs_server.o] Error 1
[  115s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  115s] Makefile:424: recipe for target 'all-recursive' failed
[  115s] make[3]: *** [all-recursive] Error 1
[  115s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  115s] Makefile:464: recipe for target 'all-recursive' failed
[  115s] make[2]: *** [all-recursive] Error 1
[  115s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  115s] Makefile:396: recipe for target 'all' failed
[  115s] make[1]: *** [all] Error 2
[  115s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  115s] dh_auto_build: make -j1 returned exit code 2
[  115s] debian/rules:45: recipe for target 'build' failed
[  115s] make: *** [build] Error 2
[  115s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  115s] 
[  115s] lamb19 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:03:52 UTC 2019.
[  115s] 
[  115s] ### VM INTERACTION START ###
[  118s] [  102.676223] sysrq: SysRq : Power Off
[  118s] [  102.680986] reboot: Power down
[  118s] ### VM INTERACTION END ###
[  118s] 
[  118s] lamb19 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:03:56 UTC 2019.
[  118s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in Raspbian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Raspbian_9.0/armv7l

Package network:osmocom:nightly/osmo-bsc failed to build in Raspbian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  159s]   ^~~
[  159s] gsm_04_08_rr.c:316:22: note: each undeclared identifier is reported 
only once for each function it appears in
[  159s] cc1: some warnings being treated as errors
[  159s] Makefile:627: recipe for target 'gsm_04_08_rr.o' failed
[  159s] make[4]: *** [gsm_04_08_rr.o] Error 1
[  159s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc'
[  159s] Makefile:409: recipe for target 'all-recursive' failed
[  159s] make[3]: *** [all-recursive] Error 1
[  159s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  159s] Makefile:447: recipe for target 'all-recursive' failed
[  159s] make[2]: *** [all-recursive] Error 1
[  159s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  159s] Makefile:379: recipe for target 'all' failed
[  159s] make[1]: *** [all] Error 2
[  159s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  159s] dh_auto_build: make -j1 returned exit code 2
[  159s] debian/rules:45: recipe for target 'build' failed
[  159s] make: *** [build] Error 2
[  159s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  159s] 
[  159s] armbuild04 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
21:04:16 UTC 2019.
[  159s] 
[  159s] ### VM INTERACTION START ###
[  162s] [  137.332655] SysRq : Power Off
[  162s] [  137.343692] reboot: Power down
[  162s] ### VM INTERACTION END ###
[  162s] 
[  162s] armbuild04 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
21:04:19 UTC 2019.
[  162s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-msc failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[   91s]  #include 
[   91s]   ^
[   91s] compilation terminated.
[   92s] Makefile:506: recipe for target 'sgs_server.o' failed
[   92s] make[4]: *** [sgs_server.o] Error 1
[   92s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   92s] Makefile:412: recipe for target 'all-recursive' failed
[   92s] make[3]: *** [all-recursive] Error 1
[   92s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   92s] Makefile:452: recipe for target 'all-recursive' failed
[   92s] make[2]: *** [all-recursive] Error 1
[   92s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   92s] Makefile:383: recipe for target 'all' failed
[   92s] make[1]: *** [all] Error 2
[   92s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   92s] dh_auto_build: make -j1 returned exit code 2
[   92s] debian/rules:45: recipe for target 'build' failed
[   92s] make: *** [build] Error 2
[   92s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   92s] 
[   92s] lamb07 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:01:51 UTC 2019.
[   92s] 
[   92s] ### VM INTERACTION START ###
[   93s] Powering off.
[   93s] [   82.066696] reboot: Power down
[   93s] ### VM INTERACTION END ###
[   93s] 
[   93s] lamb07 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:01:53 UTC 2019.
[   93s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  195s] gcc -DHAVE_CONFIG_H -I. -I../..   -I../../include -I../..  -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/  
-I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ 
 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security 
-Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args 
-Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o 
sgs_server.o sgs_server.c
[  195s] sgs_server.c:28:26: fatal error: netinet/sctp.h: No such file or 
directory
[  195s] compilation terminated.
[  195s] Makefile:518: recipe for target 'sgs_server.o' failed
[  195s] make[4]: *** [sgs_server.o] Error 1
[  195s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  195s] Makefile:424: recipe for target 'all-recursive' failed
[  195s] make[3]: *** [all-recursive] Error 1
[  195s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  195s] Makefile:464: recipe for target 'all-recursive' failed
[  195s] make[2]: *** [all-recursive] Error 1
[  195s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  195s] Makefile:396: recipe for target 'all' failed
[  195s] make[1]: *** [all] Error 2
[  195s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  195s] dh_auto_build: make -j1 returned exit code 2
[  195s] debian/rules:45: recipe for target 'build' failed
[  195s] make: *** [build] Error 2
[  195s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  196s] 
[  196s] lamb09 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:01:30 UTC 2019.
[  196s] 
[  196s] ### VM INTERACTION START ###
[  199s] [  186.719084] sysrq: SysRq : Power Off
[  199s] [  186.735045] reboot: Power down
[  199s] ### VM INTERACTION END ###
[  199s] 
[  199s] lamb09 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:01:34 UTC 2019.
[  199s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.10/i586

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[   82s]   GSM48_IE_CHDES_2_AFTER
[   82s] gsm_04_08_rr.c:316:22: note: each undeclared identifier is reported 
only once for each function it appears in
[   82s] cc1: some warnings being treated as errors
[   82s] Makefile:627: recipe for target 'gsm_04_08_rr.o' failed
[   82s] make[4]: *** [gsm_04_08_rr.o] Error 1
[   82s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc'
[   82s] Makefile:409: recipe for target 'all-recursive' failed
[   82s] make[3]: *** [all-recursive] Error 1
[   82s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   82s] Makefile:447: recipe for target 'all-recursive' failed
[   82s] make[2]: *** [all-recursive] Error 1
[   82s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   82s] Makefile:379: recipe for target 'all' failed
[   82s] make[1]: *** [all] Error 2
[   82s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   82s] dh_auto_build: make -j1 returned exit code 2
[   82s] debian/rules:45: recipe for target 'build' failed
[   82s] make: *** [build] Error 2
[   82s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   82s] 
[   82s] sheep81 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
21:01:40 UTC 2019.
[   82s] 
[   82s] ### VM INTERACTION START ###
[   85s] [   77.431660] sysrq: SysRq : Power Off
[   85s] [   77.437403] reboot: Power down
[   85s] ### VM INTERACTION END ###
[   85s] 
[   85s] sheep81 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
21:01:43 UTC 2019.
[   85s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_9.0/i586

Package network:osmocom:nightly/osmo-msc failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  141s]  #include 
[  141s]   ^
[  141s] compilation terminated.
[  141s] Makefile:518: recipe for target 'sgs_server.o' failed
[  141s] make[4]: *** [sgs_server.o] Error 1
[  141s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  141s] Makefile:424: recipe for target 'all-recursive' failed
[  141s] make[3]: *** [all-recursive] Error 1
[  141s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  141s] Makefile:464: recipe for target 'all-recursive' failed
[  141s] make[2]: *** [all-recursive] Error 1
[  141s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  141s] Makefile:396: recipe for target 'all' failed
[  141s] make[1]: *** [all] Error 2
[  141s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  141s] dh_auto_build: make -j1 returned exit code 2
[  141s] debian/rules:45: recipe for target 'build' failed
[  141s] make: *** [build] Error 2
[  141s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  141s] 
[  141s] wildcard2 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:00:16 UTC 2019.
[  141s] 
[  141s] ### VM INTERACTION START ###
[  144s] [  122.157619] sysrq: SysRq : Power Off
[  144s] [  122.160806] reboot: Power down
[  145s] ### VM INTERACTION END ###
[  145s] 
[  145s] wildcard2 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
21:00:21 UTC 2019.
[  145s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  135s]   ^~~
[  135s] gsm_04_08_rr.c:316:22: note: each undeclared identifier is reported 
only once for each function it appears in
[  135s] cc1: some warnings being treated as errors
[  135s] Makefile:627: recipe for target 'gsm_04_08_rr.o' failed
[  135s] make[4]: *** [gsm_04_08_rr.o] Error 1
[  135s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc'
[  135s] Makefile:409: recipe for target 'all-recursive' failed
[  135s] make[3]: *** [all-recursive] Error 1
[  135s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  135s] Makefile:447: recipe for target 'all-recursive' failed
[  135s] make[2]: *** [all-recursive] Error 1
[  135s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  135s] Makefile:379: recipe for target 'all' failed
[  135s] make[1]: *** [all] Error 2
[  135s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  135s] dh_auto_build: make -j1 returned exit code 2
[  135s] debian/rules:45: recipe for target 'build' failed
[  135s] make: *** [build] Error 2
[  135s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  135s] 
[  135s] armbuild02 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
20:57:38 UTC 2019.
[  135s] 
[  135s] ### VM INTERACTION START ###
[  138s] [  116.325585] SysRq : Power Off
[  138s] [  116.326758] reboot: Power down
[  138s] ### VM INTERACTION END ###
[  138s] 
[  138s] armbuild02 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
20:57:41 UTC 2019.
[  138s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/i586

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  191s]   ^~~
[  191s] gsm_04_08_rr.c:316:22: note: each undeclared identifier is reported 
only once for each function it appears in
[  191s] cc1: some warnings being treated as errors
[  191s] Makefile:627: recipe for target 'gsm_04_08_rr.o' failed
[  191s] make[4]: *** [gsm_04_08_rr.o] Error 1
[  191s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc'
[  191s] Makefile:409: recipe for target 'all-recursive' failed
[  191s] make[3]: *** [all-recursive] Error 1
[  191s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  191s] Makefile:447: recipe for target 'all-recursive' failed
[  191s] make[2]: *** [all-recursive] Error 1
[  191s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  191s] Makefile:379: recipe for target 'all' failed
[  191s] make[1]: *** [all] Error 2
[  191s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  191s] dh_auto_build: make -j1 returned exit code 2
[  191s] debian/rules:45: recipe for target 'build' failed
[  191s] make: *** [build] Error 2
[  191s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  191s] 
[  191s] lamb23 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
20:58:02 UTC 2019.
[  191s] 
[  191s] ### VM INTERACTION START ###
[  194s] [  174.963199] sysrq: SysRq : Power Off
[  194s] [  174.998186] reboot: Power down
[  194s] ### VM INTERACTION END ###
[  194s] 
[  194s] lamb23 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
20:58:06 UTC 2019.
[  194s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[   60s]   ^
[   60s] gsm_04_08_rr.c:316:22: note: each undeclared identifier is reported 
only once for each function it appears in
[   60s] cc1: some warnings being treated as errors
[   60s] Makefile:627: recipe for target 'gsm_04_08_rr.o' failed
[   60s] make[4]: *** [gsm_04_08_rr.o] Error 1
[   60s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc'
[   60s] Makefile:409: recipe for target 'all-recursive' failed
[   60s] make[3]: *** [all-recursive] Error 1
[   60s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   60s] Makefile:447: recipe for target 'all-recursive' failed
[   60s] make[2]: *** [all-recursive] Error 1
[   60s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   60s] Makefile:379: recipe for target 'all' failed
[   60s] make[1]: *** [all] Error 2
[   60s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   60s] dh_auto_build: make -j1 returned exit code 2
[   60s] debian/rules:45: recipe for target 'build' failed
[   60s] make: *** [build] Error 2
[   60s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   60s] 
[   60s] build79 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
20:55:40 UTC 2019.
[   60s] 
[   60s] ### VM INTERACTION START ###
[   63s] [   56.509314] sysrq: SysRq : Power Off
[   63s] [   56.511408] reboot: Power down
[   63s] ### VM INTERACTION END ###
[   63s] 
[   63s] build79 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
20:55:44 UTC 2019.
[   63s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-msc in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_8.0/i586

Package network:osmocom:nightly/osmo-msc failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-msc

Last lines of build log:
[  133s]  #include 
[  133s]   ^
[  133s] compilation terminated.
[  134s] Makefile:506: recipe for target 'sgs_server.o' failed
[  134s] make[4]: *** [sgs_server.o] Error 1
[  134s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  134s] Makefile:412: recipe for target 'all-recursive' failed
[  134s] make[3]: *** [all-recursive] Error 1
[  134s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  134s] Makefile:452: recipe for target 'all-recursive' failed
[  134s] make[2]: *** [all-recursive] Error 1
[  134s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  134s] Makefile:383: recipe for target 'all' failed
[  134s] make[1]: *** [all] Error 2
[  134s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  134s] dh_auto_build: make -j1 returned exit code 2
[  134s] debian/rules:45: recipe for target 'build' failed
[  134s] make: *** [build] Error 2
[  134s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  134s] 
[  134s] lamb54 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
20:52:22 UTC 2019.
[  134s] 
[  134s] ### VM INTERACTION START ###
[  135s] Powering off.
[  135s] [  123.410437] reboot: Power down
[  135s] ### VM INTERACTION END ###
[  135s] 
[  135s] lamb54 failed "build osmo-msc_1.3.1.9.34d30.dsc" at Tue Feb  5 
20:52:24 UTC 2019.
[  135s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-bsc in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/i586

Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-bsc

Last lines of build log:
[  177s]   ^
[  177s] gsm_04_08_rr.c:316:22: note: each undeclared identifier is reported 
only once for each function it appears in
[  177s] cc1: some warnings being treated as errors
[  177s] Makefile:616: recipe for target 'gsm_04_08_rr.o' failed
[  177s] make[4]: *** [gsm_04_08_rr.o] Error 1
[  177s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bsc'
[  177s] Makefile:397: recipe for target 'all-recursive' failed
[  177s] make[3]: *** [all-recursive] Error 1
[  177s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  177s] Makefile:435: recipe for target 'all-recursive' failed
[  177s] make[2]: *** [all-recursive] Error 1
[  177s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  177s] Makefile:366: recipe for target 'all' failed
[  177s] make[1]: *** [all] Error 2
[  177s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  177s] dh_auto_build: make -j1 returned exit code 2
[  177s] debian/rules:45: recipe for target 'build' failed
[  177s] make: *** [build] Error 2
[  177s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  177s] 
[  177s] lamb62 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
20:47:51 UTC 2019.
[  177s] 
[  177s] ### VM INTERACTION START ###
[  179s] Powering off.
[  179s] [  156.535810] reboot: Power down
[  179s] ### VM INTERACTION END ###
[  179s] 
[  179s] lamb62 failed "build osmo-bsc_1.4.0.13.96376.dsc" at Tue Feb  5 
20:47:53 UTC 2019.
[  179s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-msc[master]: libmsc/osmo_msc.c: move connection ref-counting code to 'ran_conn.c'

[Vadim Yanitskiy]

Hello Max, Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12698

to look at the new patch set (#3).

Change subject: libmsc/osmo_msc.c: move connection ref-counting code to 
'ran_conn.c'
..

libmsc/osmo_msc.c: move connection ref-counting code to 'ran_conn.c'

The connection ref-counting implementation is specific to RAN
connections, and is not applicable for anything else. Moreover,
the API of this code is declared in 'ran_conn.h', so let's
move the code to a more logical place.

Change-Id: I593675d9bf56eaef12afdaf596ee1337b9a44259
---
M src/libmsc/osmo_msc.c
M src/libmsc/ran_conn.c
2 files changed, 111 insertions(+), 111 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/98/12698/3
--
To view, visit https://gerrit.osmocom.org/12698
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I593675d9bf56eaef12afdaf596ee1337b9a44259
Gerrit-Change-Number: 12698
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 

Change in osmo-msc[master]: libmsc/osmo_msc.c: move connection ref-counting code to 'ran_conn.c'

[Vadim Yanitskiy]

Hello Max, Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12698

to look at the new patch set (#2).

Change subject: libmsc/osmo_msc.c: move connection ref-counting code to 
'ran_conn.c'
..

libmsc/osmo_msc.c: move connection ref-counting code to 'ran_conn.c'

The connection ref-counting implementation is specific to RAN
connections, and is not applicable for anything else.

Change-Id: I593675d9bf56eaef12afdaf596ee1337b9a44259
---
M src/libmsc/osmo_msc.c
M src/libmsc/ran_conn.c
2 files changed, 111 insertions(+), 111 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/98/12698/2
--
To view, visit https://gerrit.osmocom.org/12698
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I593675d9bf56eaef12afdaf596ee1337b9a44259
Gerrit-Change-Number: 12698
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 

Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

[Vadim Yanitskiy]

Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11992

to look at the new patch set (#8).

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..

libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

It may happen that either the MS or an ESME would become
unresponsive during a call independent SS session, e.g.
due to a bug, or a dropped message. In such cases, the
corresponding transaction would remain unfreed forever.

This change introduces a guard timer, that prevents keeping
'stalled' NCSS sessions forever. As soon as it expires, both
sides (i.e. MS and ESME) are getting notified, and the
transaction is being released.

By default, the timer expires after 30 seconds. As soon as
either the MS, or an ESME initiates any activity,
the watchdog timer is rescheduled.

The timeout value can be configured from the VTY:

  msc
   ...
   ! Use 0 to disable this timer
   ncss guard-timeout 30

This change makes TC_lu_and_ss_session_timeout pass.

Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Depends Change-Id: (libosmocore) Ie3ac85fcef90a5e532334ba3482804d5305c88d7
Related Change-Id: (TTCN) I3e1791773d56617172ae27a46889a1ae4d400e2f
Related: OS#3655
---
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/transaction.h
M src/libmsc/gsm_09_11.c
M src/libmsc/msc_vty.c
M src/libmsc/osmo_msc.c
M tests/test_nodes.vty
6 files changed, 88 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/11992/8
--
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 8
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Stefan Sperling 

Build failure of network:osmocom:nightly/libosmo-netif in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_9.0/armv7l

Package network:osmocom:nightly/libosmo-netif failed to build in 
Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-netif

Last lines of build log:
[  207s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[  207s]^
[  207s] stream-server.c:81:11: note: each undeclared identifier is reported 
only once for each function it appears in
[  207s] stream-server.c:81:7: warning: unused variable 'buf' 
[-Wunused-variable]
[  207s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[  207s]^~~
[  207s] Makefile:573: recipe for target 'stream-server.o' failed
[  207s] make[3]: *** [stream-server.o] Error 1
[  207s] make[3]: Leaving directory '/usr/src/packages/BUILD/examples'
[  207s] Makefile:494: recipe for target 'all-recursive' failed
[  207s] make[2]: *** [all-recursive] Error 1
[  207s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  207s] Makefile:380: recipe for target 'all' failed
[  207s] make[1]: *** [all] Error 2
[  207s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  207s] dh_auto_build: make -j1 returned exit code 2
[  207s] debian/rules:13: recipe for target 'build' failed
[  207s] make: *** [build] Error 2
[  207s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  207s] 
[  207s] armbuild04 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  
5 20:17:08 UTC 2019.
[  207s] 
[  207s] ### VM INTERACTION START ###
[  210s] [  173.832722] SysRq : Power Off
[  210s] [  173.836317] reboot: Power down
[  210s] ### VM INTERACTION END ###
[  210s] 
[  210s] armbuild04 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  
5 20:17:11 UTC 2019.
[  210s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-netif in Raspbian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Raspbian_9.0/armv7l

Package network:osmocom:nightly/libosmo-netif failed to build in 
Raspbian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-netif

Last lines of build log:
[  203s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[  203s]^
[  203s] stream-server.c:81:11: note: each undeclared identifier is reported 
only once for each function it appears in
[  203s] stream-server.c:81:7: warning: unused variable 'buf' 
[-Wunused-variable]
[  203s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[  203s]^~~
[  203s] Makefile:573: recipe for target 'stream-server.o' failed
[  203s] make[3]: *** [stream-server.o] Error 1
[  203s] make[3]: Leaving directory '/usr/src/packages/BUILD/examples'
[  203s] Makefile:494: recipe for target 'all-recursive' failed
[  203s] make[2]: *** [all-recursive] Error 1
[  203s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  203s] Makefile:380: recipe for target 'all' failed
[  203s] make[1]: *** [all] Error 2
[  203s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  203s] dh_auto_build: make -j1 returned exit code 2
[  203s] debian/rules:13: recipe for target 'build' failed
[  203s] make: *** [build] Error 2
[  203s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  203s] 
[  203s] armbuild04 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  
5 20:15:48 UTC 2019.
[  203s] 
[  203s] ### VM INTERACTION START ###
[  206s] [  183.127955] SysRq : Power Off
[  206s] [  183.129270] reboot: Power down
[  206s] ### VM INTERACTION END ###
[  206s] 
[  206s] armbuild04 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  
5 20:15:51 UTC 2019.
[  206s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-netif in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_18.04/i586

Package network:osmocom:nightly/libosmo-netif failed to build in 
xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-netif

Last lines of build log:
[  278s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[  278s]^
[  278s] stream-server.c:81:11: note: each undeclared identifier is reported 
only once for each function it appears in
[  278s] stream-server.c:81:7: warning: unused variable 'buf' 
[-Wunused-variable]
[  278s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[  278s]^~~
[  278s] Makefile:573: recipe for target 'stream-server.o' failed
[  278s] make[3]: *** [stream-server.o] Error 1
[  278s] make[3]: Leaving directory '/usr/src/packages/BUILD/examples'
[  278s] Makefile:494: recipe for target 'all-recursive' failed
[  278s] make[2]: *** [all-recursive] Error 1
[  278s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  278s] Makefile:380: recipe for target 'all' failed
[  278s] make[1]: *** [all] Error 2
[  278s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  278s] dh_auto_build: make -j1 returned exit code 2
[  278s] debian/rules:13: recipe for target 'build' failed
[  278s] make: *** [build] Error 2
[  278s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  278s] 
[  278s] lamb62 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  5 
20:11:14 UTC 2019.
[  278s] 
[  278s] ### VM INTERACTION START ###
[  281s] [  240.367387] sysrq: SysRq : Power Off
[  281s] [  240.400879] reboot: Power down
[  281s] ### VM INTERACTION END ###
[  281s] 
[  281s] lamb62 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  5 
20:11:18 UTC 2019.
[  281s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-netif in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_8.0/i586

Package network:osmocom:nightly/libosmo-netif failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-netif

Last lines of build log:
[  140s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[  140s]^
[  140s] stream-server.c:81:11: note: each undeclared identifier is reported 
only once for each function it appears in
[  140s] stream-server.c:81:7: warning: unused variable 'buf' 
[-Wunused-variable]
[  140s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[  140s]^
[  140s] Makefile:561: recipe for target 'stream-server.o' failed
[  140s] make[3]: *** [stream-server.o] Error 1
[  140s] make[3]: Leaving directory '/usr/src/packages/BUILD/examples'
[  140s] Makefile:483: recipe for target 'all-recursive' failed
[  140s] make[2]: *** [all-recursive] Error 1
[  140s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  140s] Makefile:368: recipe for target 'all' failed
[  140s] make[1]: *** [all] Error 2
[  140s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  140s] dh_auto_build: make -j1 returned exit code 2
[  140s] debian/rules:13: recipe for target 'build' failed
[  140s] make: *** [build] Error 2
[  140s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  140s] 
[  140s] morla3 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  5 
20:10:34 UTC 2019.
[  140s] 
[  140s] ### VM INTERACTION START ###
[  141s] Powering off.
[  141s] [  126.357162] reboot: Power down
[  141s] ### VM INTERACTION END ###
[  141s] 
[  141s] morla3 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  5 
20:10:36 UTC 2019.
[  141s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-netif in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_16.04/i586

Package network:osmocom:nightly/libosmo-netif failed to build in 
xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-netif

Last lines of build log:
[  193s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[  193s]^
[  193s] stream-server.c:81:11: note: each undeclared identifier is reported 
only once for each function it appears in
[  193s] stream-server.c:81:7: warning: unused variable 'buf' 
[-Wunused-variable]
[  193s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[  193s]^
[  193s] Makefile:573: recipe for target 'stream-server.o' failed
[  193s] make[3]: *** [stream-server.o] Error 1
[  193s] make[3]: Leaving directory '/usr/src/packages/BUILD/examples'
[  193s] Makefile:494: recipe for target 'all-recursive' failed
[  193s] make[2]: *** [all-recursive] Error 1
[  193s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  193s] Makefile:380: recipe for target 'all' failed
[  193s] make[1]: *** [all] Error 2
[  193s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  193s] dh_auto_build: make -j1 returned exit code 2
[  193s] debian/rules:13: recipe for target 'build' failed
[  193s] make: *** [build] Error 2
[  193s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  193s] 
[  193s] lamb24 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  5 
20:08:20 UTC 2019.
[  193s] 
[  193s] ### VM INTERACTION START ###
[  197s] [  182.629859] sysrq: SysRq : Power Off
[  197s] [  182.656669] reboot: Power down
[  197s] ### VM INTERACTION END ###
[  197s] 
[  197s] lamb24 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  5 
20:08:24 UTC 2019.
[  197s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmo-netif in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_17.10/i586

Package network:osmocom:nightly/libosmo-netif failed to build in 
xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmo-netif

Last lines of build log:
[   81s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[   81s]^
[   81s] stream-server.c:81:11: note: each undeclared identifier is reported 
only once for each function it appears in
[   81s] stream-server.c:81:7: warning: unused variable 'buf' 
[-Wunused-variable]
[   81s]   char buf[OSMO_SOCK_NAME_MAXLEN];
[   81s]^~~
[   81s] Makefile:573: recipe for target 'stream-server.o' failed
[   81s] make[3]: *** [stream-server.o] Error 1
[   81s] make[3]: Leaving directory '/usr/src/packages/BUILD/examples'
[   81s] Makefile:494: recipe for target 'all-recursive' failed
[   81s] make[2]: *** [all-recursive] Error 1
[   81s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   81s] Makefile:380: recipe for target 'all' failed
[   81s] make[1]: *** [all] Error 2
[   81s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   81s] dh_auto_build: make -j1 returned exit code 2
[   81s] debian/rules:13: recipe for target 'build' failed
[   81s] make: *** [build] Error 2
[   81s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   81s] 
[   81s] sheep81 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  5 
20:06:25 UTC 2019.
[   81s] 
[   81s] ### VM INTERACTION START ###
[   84s] [   77.214119] sysrq: SysRq : Power Off
[   84s] [   77.220735] reboot: Power down
[   84s] ### VM INTERACTION END ###
[   84s] 
[   84s] sheep81 failed "build libosmo-netif_0.4.0.10.827d.dsc" at Tue Feb  5 
20:06:29 UTC 2019.
[   84s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l

Package network:osmocom:nightly/libosmocore failed to build in 
Raspbian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  678s] | configure:4063: checking dependency style of gcc
[  678s] | configure:4174: result: none
[  678s] | configure:4219: checking build system type
[  678s] | configure:4233: result: arm-unknown-linux-gnueabihf
[  678s] | configure:4253: checking host system type
[  678s] | configure:4266: result: arm-unknown-linux-gnueabihf
[  678s] | configure:4307: checking how to print strings
[  678s] | configure:4334: result: printf
[  678s] | configure:4355: checking for a sed that does not truncate output
[  678s] | configure:4419: result: /bin/sed
[  678s] | configure:4437: checking for grep that handles long lines and -e
[  678s] | configure:4495: result: /bin/grep
[  678s] | configure:4500: checking for egrep
[  678s] | configure:4562: result: /bin/grep -E
[  678s] | configure:4567: checking for fgrep
[  678s] | configure:4629: result: /bin/grep -F
[  678s] | configure:4664: checking for ld used by gcc
[  678s] | configure:4731: result: /usr/bin/ld
[  678s] | configure:4738: checking if the linker (/usr/bin/ld) is GNU ld
[  678s] | configure:4753: result: yes
[  678s] | configure:4765: checking for BSD- or MS-compatible name lister (nm)
[  678s] | configure:4819: result: /usr/bin/nm -B
[  678s] | configure:4949: checking the name lister (/usr/bin/nm -B) interface
[  680s] | configure:[  636.480950] SysRq : Power Off
[  680s] [  636.486333] reboot: Power down
[  680s] ### VM INTERACTION END ###
[  680s] 
[  680s] armbuild04 failed "build libosmocore_1.0.1.31.74c4.dsc" at Tue Feb  5 
20:05:38 UTC 2019.
[  680s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/armv7l

Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  480s] | config.status:1199: creating Doxyfile.coding
[  480s] | config.status:1199: creating Doxyfile.gb
[  480s] | config.status:1199: creating Doxyfile.ctrl
[  480s] | config.status:1199: creating Makefile
[  480s] | config.status:1199: creating config.h
[  480s] | config.status:1428: executing tests/atconfig commands
[  480s] | config.status:1428: executing depfiles commands
[  480s] | config.status:1428: executing libtool commands
[  480s] | configure:16841: WARNING: unrecognized options: 
--disable-maintainer-mode
[  480s] | 
[  480s] | ##  ##
[  480s] | ## Cache variables. ##
[  480s] | ##  ##
[  480s] | 
[  480s] | ac_cv_build=arm-unknown-linux-gnueabihf
[  480s] | ac_cv_c_compiler_gnu=yes
[  480s] | ac_cv_env_CC_set=
[  480s] | ac_cv_env_CC_value=
[  480s] | ac_cv_env_CFLAGS_set=set
[  480s] | ac_cv_env_CFLAGS_value='-g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security'
[  480s] | ac_cv_env_CPPFLAGS_set=set
[  480s] | ac_cv_env_CPPFLAGS_value='-Wdate-time -D_FORTIFY_SOURCE=2'
[  480s] | ac_cv_env_CPP_set=
[  482s] | ac_cv_env[  455.650882] SysRq : Power Off
[  482s] [  455.662066] reboot: Power down
[  482s] ### VM INTERACTION END ###
[  482s] 
[  482s] armbuild02 failed "build libosmocore_1.0.1.31.74c4.dsc" at Tue Feb  5 
20:01:57 UTC 2019.
[  482s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.10/i586

Package network:osmocom:nightly/libosmocore failed to build in 
xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  289s] + --> N (configured as T-2147483648 4294967295 s) rc=0;state=N 
T=-2147483648, 2147483647.00 s remaining
[  289s]  - test T=0:
[  289s]   --> O (no timer configured for this state)
[  289s]  - test no timer:
[  289s]   --> X (no timer configured for this state)
[  289s]  - test undefined timer, using default_val arg of osmo[  277.160467] 
serial8250: too much work for irq4
[  289s] _tdef_fsm_inst_state_chg(), here passed as 999:
[  289s] - --> Y (configured as T666 18446744073709551615 -) rc=0;  state=Y 
T=666, 999.00 s remaining
[  289s] + --> Y (configured as T666 4294967295 -) rc=0;state=Y T=666, 
999.00 s remaining
[  289s]  - test disallowed transition:
[  289s]   --> Z (no timer configured for this state)
[  289s]   --> B (configured as T2 100 ms) rc=0;state=B T=2, 1.00 s 
remaining
[  289s] 52. testsuite.at:329: 52. tdef (testsuite.at:329): FAILED 
(testsuite.at:332)
[  289s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  289s] make[1]: *** [override_dh_auto_test] Error 1
[  289s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  289s] debian/rules:15: recipe for target 'build' failed
[  289s] make: *** [build] Error 2
[  289s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  289s] 
[  289s] cumulus2 failed "build libosmocore_1.0.1.31.74c4.dsc" at Tue Feb  5 
19:59:20 UTC 2019.
[  289s] 
[  289s] ### VM INTERACTION START ###
[  292s] [  280.308149] sysrq: SysRq : Power Off
[  292s] [  280.322645] reboot: Power down
[  292s] ### VM INTERACTION END ###
[  292s] 
[  292s] cumulus2 failed "build libosmocore_1.0.1.31.74c4.dsc" at Tue Feb  5 
19:59:23 UTC 2019.
[  292s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/i586

Package network:osmocom:nightly/libosmocore failed to build in 
xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  376s] | This file was extended by libosmocore config.status 1.0.1.31-74c4, 
which was
[  376s] | generated by GNU Autoconf 2.69.  Invocation command line was
[  376s] | 
[  376s] |   CONFIG_FILES= 
[  376s] |   CONFIG_HEADERS  = 
[  376s] |   CONFIG_LINKS= 
[  376s] |   CONFIG_COMMANDS = 
[  376s] |   $ ./config.status Doxyfile.core
[  376s] | 
[  376s] | on build36
[  376s] | 
[  376s] | config.status:1203: creating Doxyfile.core
[  376s] 
[  376s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  376s] make[1]: *** [override_dh_auto_test] Error 1
[  376s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  376s] debian/rules:15: recipe for target 'build' failed
[  376s] make: *** [build] Error 2
[  376s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  376s] 
[  376s] build36 failed "build libosmocore_1.0.1.31.74c4.dsc" at Tue Feb  5 
20:00:08 UTC 2019.
[  376s] 
[  376s] ### VM INTERACTION START ###
[  380s] [  366.024700] sysrq: SysRq : Power Off
[  380s] [  366.089564] reboot: Power down
[  380s] ### VM INTERACTION END ###
[  380s] 
[  380s] build36 failed "build libosmocore_1.0.1.31.74c4.dsc" at Tue Feb  5 
20:00:12 UTC 2019.
[  380s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in libosmocore[master]: gsm/gsm0480: introduce gsm0480_create_release_complete[_cause]() API

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12839


Change subject: gsm/gsm0480: introduce 
gsm0480_create_release_complete[_cause]() API
..

gsm/gsm0480: introduce gsm0480_create_release_complete[_cause]() API

In OsmoMSC, it's required to be able to specify a particular GSM 04.07
transaction ID for GSM 04.80 Release complete message instead of the
hard-coded value, that is used gsm0480_create_ussd_release_complete().

Let's finally deprecate gsm0480_create_ussd_release_complete(), and
introduce two new functions without USSD prefix, as this message
is also used in other "structured" supplementary services:

  - gsm0480_create_release_complete,
  - gsm0480_create_release_complete_cause.

The second one can be used to encode optional Cause IE (see 2.5.1).

Change-Id: Ie3ac85fcef90a5e532334ba3482804d5305c88d7
---
M include/osmocom/gsm/gsm0480.h
M src/gsm/gsm0480.c
M src/gsm/libosmogsm.map
3 files changed, 65 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/12839/1

diff --git a/include/osmocom/gsm/gsm0480.h b/include/osmocom/gsm/gsm0480.h
index 827464e..9d6d67d 100644
--- a/include/osmocom/gsm/gsm0480.h
+++ b/include/osmocom/gsm/gsm0480.h
@@ -117,7 +117,11 @@
 struct msgb *gsm0480_create_unstructuredSS_Notify(int alertPattern, const char 
*text);
 struct msgb *gsm0480_create_notifySS(const char *text);
 struct msgb *gsm0480_create_ussd_notify(int level, const char *text);
-struct msgb *gsm0480_create_ussd_release_complete(void);
+struct msgb *gsm0480_create_ussd_release_complete(void)
+   OSMO_DEPRECATED("Use gsm0480_create_release_complete() instead.");
+struct msgb *gsm0480_create_release_complete(uint8_t tid);
+struct msgb *gsm0480_create_release_complete_cause(uint8_t tid, uint8_t 
cause_loc,
+  uint8_t cause_value);

 int gsm0480_wrap_invoke(struct msgb *msg, int op, int link_id);
 int gsm0480_wrap_facility(struct msgb *msg);
diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index b5c9844..e9c148a 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -921,6 +921,7 @@
return msg;
 }

+/*! Deprecated, use gsm0480_create_release_complete[_cause]() instead. */
 struct msgb *gsm0480_create_ussd_release_complete(void)
 {
struct msgb *msg;
@@ -936,3 +937,59 @@

return msg;
 }
+
+/*! Create a GSM 04.80 Release complete (see 2.5) message, prefixed
+ *  by GSM 04.08 L3 header with a given transaction ID.
+ * \param[in] tid  GSM 04.07 transaction identifier (and TI flag)
+ * \return  message buffer containing the Release complete message
+ */
+struct msgb *gsm0480_create_release_complete(uint8_t tid)
+{
+   struct msgb *msg;
+
+   msg = gsm0480_msgb_alloc_name("TS 04.80 USSD REL COMPL");
+   if (!msg)
+   return NULL;
+
+   /* Push the L3 header */
+   gsm48_push_l3hdr_tid(msg, GSM48_PDISC_NC_SS,
+tid, GSM0480_MTYPE_RELEASE_COMPLETE);
+
+   return msg;
+}
+
+/*! Create a GSM 04.80 Release complete (see 2.5) message, prefixed
+ *  by GSM 04.08 L3 header with a given transaction ID, containing
+ *  additional Cause IE (see 2.5.1), encoded according to GSM 04.80,
+ *  section 10.5.4.11 (without diagnostic info).
+ * \param[in] tid  GSM 04.07 transaction identifier (and TI flag)
+ * \param[in] cause_loc  cause location (see GSM 04.08, table 10.85)
+ * \param[in] cause_value  cause value (see GSM 04.08, table 10.86)
+ * \return  message buffer containing the Release complete message
+ */
+struct msgb *gsm0480_create_release_complete_cause(uint8_t tid, uint8_t 
cause_loc,
+  uint8_t cause_value)
+{
+   uint8_t *cause_ie;
+   struct msgb *msg;
+
+   msg = gsm0480_create_release_complete(tid);
+   if (!msg)
+   return NULL;
+
+   /* Encode cause IE (see GSM 04.08, section 10.5.4.11)
+* with fixed length (2 bytes of TL, 2 bytes of payload).
+* NOTE: we don't use gsm48_encode_cause() API because
+* it wants gsm_mncc_cause struct from us. */
+   cause_ie = msgb_put(msg, 2 + 2);
+   cause_ie[0] = GSM48_IE_CAUSE;
+   cause_ie[1] = 2;
+
+   /* Coding standard defined for the GSM PLMNs,
+* Location and cause: as given by caller,
+* No extension. */
+   cause_ie[2] = (1 << 7) | (0x03 << 5) | (cause_loc & 0x0f);
+   cause_ie[3] = (1 << 7) | cause_value;
+
+   return msg;
+}
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 602c7a6..fcf977d 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -89,6 +89,9 @@
 gsm0480_create_ussd_resp;
 gsm0480_create_ussd_notify;
 gsm0480_create_ussd_release_complete;
+gsm0480_create_release_complete;
+gsm0480_create_release_complete_cause;
+
 gsm0480_extract_ie_by_tag;
 gsm0480_parse_facility_ie;
 

Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12730 )

Change subject: Inactive connection cleanup (disabled by default)
..


Patch Set 6: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 6
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 17:10:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12730 )

Change subject: Inactive connection cleanup (disabled by default)
..


Patch Set 6: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 6
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 17:03:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Add stream client/server test

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12837 )

Change subject: Add stream client/server test
..


Patch Set 7:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 7
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 17:00:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12730 )

Change subject: Inactive connection cleanup (disabled by default)
..


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/#/c/12730/5/src/libosmo-mgcp/mgcp_conn.c
File src/libosmo-mgcp/mgcp_conn.c:

https://gerrit.osmocom.org/#/c/12730/5/src/libosmo-mgcp/mgcp_conn.c@138
PS5, Line 138: long
> In 'mgcp.h' you're using 'unsigned int', so why it is 'long' here? […]
Good point, changed it to use "int" everywhere to match osmo_timer_schedule().



--
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:51:44 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

[osmith]

Hello Vadim Yanitskiy, daniel, Max, Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12730

to look at the new patch set (#6).

Change subject: Inactive connection cleanup (disabled by default)
..

Inactive connection cleanup (disabled by default)

Add a watchdog timer to connections, and close these connections when
the watchdog timer expires. Kick the watchdog whenever RTP messages or
the relevant MGCP messages arrive.

This feature is disabled by default, as it is incompatible with LCLS
(connections in LCLS state appear to be inactive). Enable it with the
new "conn-timeout" VTY setting. In general, this feature can be used to
work around interoperability problems causing connections to stay open
forever, and slowly exhausting all available ports. This happened for
various reasons already.

MDCX is the only relevant MGCP message:
- CRCX creates the conn and timer
- DLCX deletes the conn and timer
- MDCX is the only remaining supported MGCP message that indicates a CI
- Can't easily generically parse a CI for all MGCP messages, parsing is
  done in handle_modify_con().

Related: OS#3429
Change-Id: I18886052e090466f73829133c24f011806cc1fe0
---
M include/osmocom/mgcp/mgcp.h
M include/osmocom/mgcp/mgcp_internal.h
M src/libosmo-mgcp/mgcp_conn.c
M src/libosmo-mgcp/mgcp_network.c
M src/libosmo-mgcp/mgcp_protocol.c
M src/libosmo-mgcp/mgcp_vty.c
M tests/mgcp/mgcp_test.c
7 files changed, 54 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/30/12730/6
--
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 6
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 

Change in libosmo-netif[master]: Stream client: fix disconnection logic

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12760 )

Change subject: Stream client: fix disconnection logic
..

Stream client: fix disconnection logic

Previously closing the client did not alter its state, so we might
end-up with a client without any file descriptors, but being in state
STREAM_CLI_STATE_CONNECTED. Fix this inconsistency by setting
appropriate state.

Related issue is that reconnect function, which is always (at least in
the library and examples) called when some problem with the connection
is detected, closed the connection only after checking whether
reconnection is enabled. This might result in another inconsistency
fixed in this patch by moving the check below connection cleanup.

While at it, also move connection close logging to appropriate place:
it's confusing to see logs about connection being closed while in
reality it wasn't even established.

Change-Id: If41ed60bd625488c283d1e8a2b078e640f04c78e
---
M src/stream.c
1 file changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/stream.c b/src/stream.c
index 7cc77c9..7b97d2a 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -169,12 +169,13 @@
  *  connection (if any) and schedule a re-connect timer */
 void osmo_stream_cli_reconnect(struct osmo_stream_cli *cli)
 {
+   osmo_stream_cli_close(cli);
+
if (cli->reconnect_timeout < 0) {
LOGSCLI(cli, LOGL_DEBUG, "not reconnecting, disabled.\n");
return;
}
-   LOGSCLI(cli, LOGL_DEBUG, "connection closed\n");
-   osmo_stream_cli_close(cli);
+
LOGSCLI(cli, LOGL_DEBUG, "retrying in %d seconds...\n",
cli->reconnect_timeout);
osmo_timer_schedule(>timer, cli->reconnect_timeout, 0);
@@ -192,6 +193,11 @@
osmo_fd_unregister(>ofd);
close(cli->ofd.fd);
cli->ofd.fd = -1;
+
+   if (cli->state == STREAM_CLI_STATE_CONNECTED)
+   LOGSCLI(cli, LOGL_DEBUG, "connection closed\n");
+
+   cli->state = STREAM_CLI_STATE_NONE;
 }

 static void osmo_stream_cli_read(struct osmo_stream_cli *cli)

--
To view, visit https://gerrit.osmocom.org/12760
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If41ed60bd625488c283d1e8a2b078e640f04c78e
Gerrit-Change-Number: 12760
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pablo Neira Ayuso 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 

Change in osmo-mgw[master]: Inactive connection cleanup (disabled by default)

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12730 )

Change subject: Inactive connection cleanup (disabled by default)
..


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12730/5/src/libosmo-mgcp/mgcp_conn.c
File src/libosmo-mgcp/mgcp_conn.c:

https://gerrit.osmocom.org/#/c/12730/5/src/libosmo-mgcp/mgcp_conn.c@138
PS5, Line 138: long
In 'mgcp.h' you're using 'unsigned int', so why it is 'long' here?
Also, osmo_timer_schedule() is using 'int'.



--
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:31:16 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Stream client: fix disconnection logic

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12760 )

Change subject: Stream client: fix disconnection logic
..


Patch Set 4:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/12760
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If41ed60bd625488c283d1e8a2b078e640f04c78e
Gerrit-Change-Number: 12760
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pablo Neira Ayuso 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:26:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmo-netif[master]: Add stream client/server test

[Max]

Hello daniel, Harald Welte, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12837

to look at the new patch set (#5).

Change subject: Add stream client/server test
..

Add stream client/server test

Previously stream client and server code were only used in examples
which means regressions could be easily introduced unnoticed until they
trigger bugs in external code which relies on osmo_stream_*()

Fix this by adding basic client-server interaction test with single
reconnection iteration.

Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
---
M .gitignore
M tests/Makefile.am
A tests/stream/stream_test.c
A tests/stream/stream_test.ok
M tests/testsuite.at
5 files changed, 289 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/37/12837/5
--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 

Change in libosmo-netif[master]: Add socket name functions to stream client/server

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12827 )

Change subject: Add socket name functions to stream client/server
..

Add socket name functions to stream client/server

Add functions to get the description of a server link or client
connection which examine data on corresponding socket.

Those functions use static buffers and intended for single use in
log/printf statements as illustarted by corresponding example changes.

Change-Id: If9a8e211da85956781479862a63c4fc6e53ed6be
---
M examples/stream-client.c
M examples/stream-server.c
M include/osmocom/netif/stream.h
M src/stream.c
4 files changed, 35 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/examples/stream-client.c b/examples/stream-client.c
index 6178dcd..e2fb901 100644
--- a/examples/stream-client.c
+++ b/examples/stream-client.c
@@ -39,7 +39,7 @@

 static int connect_cb(struct osmo_stream_cli *conn)
 {
-   LOGP(DSTREAMTEST, LOGL_NOTICE, "connected\n");
+   LOGP(DSTREAMTEST, LOGL_NOTICE, "connected: %s\n", 
osmo_stream_cli_get_sockname(conn));
return 0;
 }

diff --git a/examples/stream-server.c b/examples/stream-server.c
index b02eefe..c1086ec 100644
--- a/examples/stream-server.c
+++ b/examples/stream-server.c
@@ -171,7 +171,7 @@
kbd_ofd->cb = kbd_cb;
osmo_fd_register(kbd_ofd);

-   LOGP(DSTREAMTEST, LOGL_NOTICE, "Entering main loop\n");
+   LOGP(DSTREAMTEST, LOGL_NOTICE, "Entering main loop on %s\n", 
osmo_stream_srv_link_get_sockname(srv));

while(1) {
osmo_select_main(0);
diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h
index 969d42f..3044511 100644
--- a/include/osmocom/netif/stream.h
+++ b/include/osmocom/netif/stream.h
@@ -27,6 +27,7 @@
 void osmo_stream_srv_link_set_accept_cb(struct osmo_stream_srv_link *link, int 
(*accept_cb)(struct osmo_stream_srv_link *link, int fd));
 void osmo_stream_srv_link_set_data(struct osmo_stream_srv_link *link, void 
*data);
 void *osmo_stream_srv_link_get_data(struct osmo_stream_srv_link *link);
+char *osmo_stream_srv_link_get_sockname(const struct osmo_stream_srv_link 
*link);
 struct osmo_fd *osmo_stream_srv_link_get_ofd(struct osmo_stream_srv_link 
*link);

 int osmo_stream_srv_link_open(struct osmo_stream_srv_link *link);
@@ -60,6 +61,7 @@
 void osmo_stream_cli_set_data(struct osmo_stream_cli *cli, void *data);
 void osmo_stream_cli_set_reconnect_timeout(struct osmo_stream_cli *cli, int 
timeout);
 void *osmo_stream_cli_get_data(struct osmo_stream_cli *cli);
+char *osmo_stream_cli_get_sockname(const struct osmo_stream_cli *cli);
 struct osmo_fd *osmo_stream_cli_get_ofd(struct osmo_stream_cli *cli);
 void osmo_stream_cli_set_connect_cb(struct osmo_stream_cli *cli, int 
(*connect_cb)(struct osmo_stream_cli *cli));
 void osmo_stream_cli_set_read_cb(struct osmo_stream_cli *cli, int 
(*read_cb)(struct osmo_stream_cli *cli));
diff --git a/src/stream.c b/src/stream.c
index f1d87d4..7cc77c9 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -405,6 +405,18 @@
return cli->data;
 }

+/*! \brief Get the stream client socket description.
+ *  \param[in] cli Stream Client to examine
+ *  \returns Socket description or NULL in case of error */
+char *osmo_stream_cli_get_sockname(const struct osmo_stream_cli *cli)
+{
+   static char buf[OSMO_SOCK_NAME_MAXLEN];
+
+   osmo_sock_get_name_buf(buf, OSMO_SOCK_NAME_MAXLEN, cli->ofd.fd);
+
+   return buf;
+}
+
 /*! \brief Get Osmocom File Descriptor of the stream client socket
  *  \param[in] cli Stream Client to modify
  *  \returns Pointer to \ref osmo_fd */
@@ -711,6 +723,25 @@
return link->data;
 }

+/*! \brief Get description of the stream server link e. g. 127.0.0.1:1234
+ *  \param[in] link Stream Server Link to examine
+ *  \returns Link description or NULL in case of error */
+char *osmo_stream_srv_link_get_sockname(const struct osmo_stream_srv_link 
*link)
+{
+   static char buf[INET6_ADDRSTRLEN + 6];
+   int rc = osmo_sock_get_local_ip(link->ofd.fd, buf, INET6_ADDRSTRLEN);
+   if (rc < 0)
+   return NULL;
+
+   buf[strnlen(buf, INET6_ADDRSTRLEN + 6)] = ':';
+
+   rc = osmo_sock_get_local_ip_port(link->ofd.fd, buf + strnlen(buf, 
INET6_ADDRSTRLEN + 6), 6);
+   if (rc < 0)
+   return NULL;
+
+   return buf;
+}
+
 /*! \brief Get Osmocom File Descriptor of the stream server link
  *  \param[in] link Stream Server Link
  *  \returns Pointer to \ref osmo_fd */

--
To view, visit https://gerrit.osmocom.org/12827
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If9a8e211da85956781479862a63c4fc6e53ed6be
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: 

Change in osmo-msc[master]: VLR tests: use msgb_eq_data_print() for comparison

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12571 )

Change subject: VLR tests: use msgb_eq_data_print() for comparison
..

VLR tests: use msgb_eq_data_print() for comparison

This simplifies tests refactoring by showing exact byte where mismatch
happened. It also makes code more readable.

No changes in expected test output are necessary because the additional
logging will be triggered iff the test fails so the result will be
visible only during debugging of unit test issues.

Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786
---
M tests/msc_vlr/msc_vlr_tests.c
1 file changed, 12 insertions(+), 11 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c
index 296f055..eb6df09 100644
--- a/tests/msc_vlr/msc_vlr_tests.c
+++ b/tests/msc_vlr/msc_vlr_tests.c
@@ -570,15 +570,21 @@
 int __real_osmo_gsup_client_send(struct osmo_gsup_client *gsupc, struct msgb 
*msg);
 int __wrap_osmo_gsup_client_send(struct osmo_gsup_client *gsupc, struct msgb 
*msg)
 {
-   const char *is = osmo_hexdump_nospc(msg->data, msg->len);
+   uint8_t buf[512];
+   int len;
+
fprintf(stderr, "GSUP --> HLR: %s: %s\n",
-   osmo_gsup_message_type_name(msg->data[0]), is);
+   osmo_gsup_message_type_name(msg->data[0]), 
osmo_hexdump_nospc(msg->data, msg->len));

OSMO_ASSERT(gsup_tx_expected);
-   if (strcmp(gsup_tx_expected, is)) {
-   fprintf(stderr, "Mismatch! Expected:\n%s\n", gsup_tx_expected);
+   OSMO_ASSERT(strlen(gsup_tx_expected) <= (sizeof(buf) * 2));
+
+   len = osmo_hexparse(gsup_tx_expected, buf, sizeof(buf));
+   if (len < 1)
abort();
-   }
+
+   if (!msgb_eq_data_print(msg, buf, len))
+   abort();

talloc_free(msg);
gsup_tx_confirmed = true;
@@ -596,13 +602,8 @@

/* Mask the sequence number out before comparing */
msg->data[1] &= 0x3f;
-   if (msg->len != dtap_tx_expected->len
-   || memcmp(msg->data, dtap_tx_expected->data, msg->len)) {
-   fprintf(stderr, "Mismatch! Expected:\n%s\n",
-  osmo_hexdump_nospc(dtap_tx_expected->data,
- dtap_tx_expected->len));
+   if (!msgb_eq_data_print(msg, dtap_tx_expected->data, 
dtap_tx_expected->len))
abort();
-   }

btw("DTAP matches expected message");


--
To view, visit https://gerrit.osmocom.org/12571
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: osmith 

Change in osmo-msc[master]: Move enum definition to header file

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12598 )

Change subject: Move enum definition to header file
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h
File src/libmsc/smpp_smsc.h:

https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h@22
PS1, Line 22: enum esme_bind {
> I'd sort of like the osmo_* prefix here, but then it's missing in 
> esme_read_state as well... […]
we never put osmo_ prefixes into any symbols/type-names unless they're part of 
an installed library.  libmsc.a is never installed and as such an internal part 
of osmo-msc.  Therefore an osmo* prefix would actually be wrong.



--
To view, visit https://gerrit.osmocom.org/12598
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71b2512894ec2a71a25f35f07ff4308035d951f9
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: daniel 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:24:29 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs/osmo-bts: Build osmo-bts-oc2g as well

[daniel]

daniel has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12838 )

Change subject: jobs/osmo-bts: Build osmo-bts-oc2g as well
..

jobs/osmo-bts: Build osmo-bts-oc2g as well

Build osmo-bts with support for oc2g as well. Uses origin/nrw/oc2g as
firmware.

Fixes: OS#3745
Change-Id: Iaaeb44b949cf6403601f069800c381fe5eae2f6e
---
M jobs/master-builds.yml
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  daniel: Verified
  Harald Welte: Looks good to me, approved



diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index 52e3ca7..c908ed9 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -187,9 +187,9 @@

   - osmo-bts:
   a1_name: FIRMWARE_VERSION
-  a1: !!python/tuple [master, femtobts_v2.7, superfemto_v2.4, 
superfemto_v3.0.1pre, superfemto_v3.1, superfemto_v5.1, v2017.01, 
origin/nrw/litecell15]
+  a1: !!python/tuple [master, femtobts_v2.7, superfemto_v2.4, 
superfemto_v3.0.1pre, superfemto_v3.1, superfemto_v5.1, v2017.01, 
origin/nrw/litecell15, origin/nrw/oc2g]
   a2_name: BTS_MODEL
-  a2: !!python/tuple [sysmo, oct, trx, oct+trx, lc15]
+  a2: !!python/tuple [sysmo, oct, trx, oct+trx, lc15, oc2g]
   a3_name: WITH_MANUALS
   a3: !!python/tuple ["1", "0"]
   combination_filter: >
@@ -200,7 +200,8 @@
 (FIRMWARE_VERSION == "superfemto_v3.1" && BTS_MODEL == "sysmo" && 
WITH_MANUALS == "0") ||
 (FIRMWARE_VERSION == "superfemto_v5.1" && BTS_MODEL == "sysmo" && 
WITH_MANUALS == "0") ||
 (FIRMWARE_VERSION == "v2017.01" && BTS_MODEL == "lc15" && 
WITH_MANUALS == "0") ||
-(FIRMWARE_VERSION == "origin/nrw/litecell15" && BTS_MODEL == 
"lc15" && WITH_MANUALS == "0")
+(FIRMWARE_VERSION == "origin/nrw/litecell15" && BTS_MODEL == 
"lc15" && WITH_MANUALS == "0") ||
+(FIRMWARE_VERSION == "origin/nrw/oc2g" && BTS_MODEL == "oc2g" && 
WITH_MANUALS == "0")
   cmd: 'PUBLISH=1 ./contrib/jenkins_bts_model.sh "$BTS_MODEL"'

   - osmo-ggsn:

--
To view, visit https://gerrit.osmocom.org/12838
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaaeb44b949cf6403601f069800c381fe5eae2f6e
Gerrit-Change-Number: 12838
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 

Change in libosmo-netif[master]: Add socket name functions to stream client/server

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12827 )

Change subject: Add socket name functions to stream client/server
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12827
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9a8e211da85956781479862a63c4fc6e53ed6be
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:22:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: VLR tests: use msgb_eq_data_print() for comparison

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12571 )

Change subject: VLR tests: use msgb_eq_data_print() for comparison
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12571
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:22:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Stream client: update logging

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12836 )

Change subject: Stream client: update logging
..

Stream client: update logging

Introduce logging macro wrapper to properly log current client state and
function to aid in debugging.

Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53
---
M src/stream.c
1 file changed, 25 insertions(+), 16 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/stream.c b/src/stream.c
index dbbaa9c..f1d87d4 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -49,6 +49,9 @@
 #include 
 #endif

+#define LOGSCLI(cli, level, fmt, args...) \
+   LOGP(DLINP, level, "[%s] %s(): " fmt, 
get_value_string(stream_cli_state_names, (cli)->state), __func__, ## args)
+
 /*! \addtogroup stream Osmocom Stream Socket
  *  @{
  *
@@ -131,6 +134,13 @@
 STREAM_CLI_STATE_MAX
 };

+static const struct value_string stream_cli_state_names[] = {
+   { STREAM_CLI_STATE_NONE,   "  NONE" },
+   { STREAM_CLI_STATE_CONNECTING, "CONNECTING" },
+   { STREAM_CLI_STATE_CONNECTED,  " CONNECTED" },
+   { 0, NULL }
+};
+
 #define OSMO_STREAM_CLI_F_RECONF   (1 << 0)
 #define OSMO_STREAM_CLI_F_NODELAY  (1 << 1)

@@ -160,12 +170,12 @@
 void osmo_stream_cli_reconnect(struct osmo_stream_cli *cli)
 {
if (cli->reconnect_timeout < 0) {
-   LOGP(DLINP, LOGL_DEBUG, "not reconnecting, disabled.\n");
+   LOGSCLI(cli, LOGL_DEBUG, "not reconnecting, disabled.\n");
return;
}
-   LOGP(DLINP, LOGL_DEBUG, "connection closed\n");
+   LOGSCLI(cli, LOGL_DEBUG, "connection closed\n");
osmo_stream_cli_close(cli);
-   LOGP(DLINP, LOGL_DEBUG, "retrying in %d seconds...\n",
+   LOGSCLI(cli, LOGL_DEBUG, "retrying in %d seconds...\n",
cli->reconnect_timeout);
osmo_timer_schedule(>timer, cli->reconnect_timeout, 0);
cli->state = STREAM_CLI_STATE_CONNECTING;
@@ -186,7 +196,7 @@

 static void osmo_stream_cli_read(struct osmo_stream_cli *cli)
 {
-   LOGP(DLINP, LOGL_DEBUG, "message received\n");
+   LOGSCLI(cli, LOGL_DEBUG, "message received\n");

if (cli->read_cb)
cli->read_cb(cli);
@@ -201,7 +211,7 @@
struct llist_head *lh;
int ret;

-   LOGP(DLINP, LOGL_DEBUG, "sending data\n");
+   LOGSCLI(cli, LOGL_DEBUG, "sending data\n");

if (llist_empty(>tx_queue)) {
cli->ofd.when &= ~BSC_FD_WRITE;
@@ -212,7 +222,7 @@
msg = llist_entry(lh, struct msgb, list);

if (cli->state == STREAM_CLI_STATE_CONNECTING) {
-   LOGP(DLINP, LOGL_ERROR, "not connected, dropping data!\n");
+   LOGSCLI(cli, LOGL_ERROR, "not connected, dropping data!\n");
return 0;
}

@@ -235,7 +245,7 @@
if (errno == EPIPE || errno == ENOTCONN) {
osmo_stream_cli_reconnect(cli);
}
-   LOGP(DLINP, LOGL_ERROR, "error to send\n");
+   LOGSCLI(cli, LOGL_ERROR, "error to send\n");
}
msgb_free(msg);
return 0;
@@ -255,7 +265,7 @@
return 0;
}
ofd->when &= ~BSC_FD_WRITE;
-   LOGP(DLINP, LOGL_DEBUG, "connection done.\n");
+   LOGSCLI(cli, LOGL_DEBUG, "connection done.\n");
cli->state = STREAM_CLI_STATE_CONNECTED;
if (cli->proto == IPPROTO_SCTP) {
 #ifdef SO_NOSIGPIPE
@@ -263,7 +273,7 @@

ret = setsockopt(ofd->fd, SOL_SOCKET, SO_NOSIGPIPE, 
(void*), sizeof(val));
if (ret < 0)
-   LOGP(DLINP, LOGL_DEBUG, "Failed setting 
SO_NOSIGPIPE: %s\n", strerror(errno));
+   LOGSCLI(cli, LOGL_DEBUG, "Failed setting 
SO_NOSIGPIPE: %s\n", strerror(errno));
 #endif
sctp_sock_activate_events(ofd->fd);
}
@@ -272,11 +282,11 @@
break;
case STREAM_CLI_STATE_CONNECTED:
if (what & BSC_FD_READ) {
-   LOGP(DLINP, LOGL_DEBUG, "connected read\n");
+   LOGSCLI(cli, LOGL_DEBUG, "connected read\n");
osmo_stream_cli_read(cli);
}
if (what & BSC_FD_WRITE) {
-   LOGP(DLINP, LOGL_DEBUG, "connected write\n");
+   LOGSCLI(cli, LOGL_DEBUG, "connected write\n");
osmo_stream_cli_write(cli);
}
break;
@@ -503,7 +513,7 @@
 {
struct osmo_stream_cli *cli = data;

-   LOGP(DLINP, LOGL_DEBUG, "reconnecting.\n");
+   LOGSCLI(cli, LOGL_DEBUG, "reconnecting.\n");

switch(cli->state) {
case 

Change in libosmo-netif[master]: Stream client: update logging

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12836 )

Change subject: Stream client: update logging
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53
Gerrit-Change-Number: 12836
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:21:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs/osmo-bts: Build osmo-bts-oc2g as well

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12838 )

Change subject: jobs/osmo-bts: Build osmo-bts-oc2g as well
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12838
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaeb44b949cf6403601f069800c381fe5eae2f6e
Gerrit-Change-Number: 12838
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:20:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs/osmo-bts: Build osmo-bts-oc2g as well

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12838 )

Change subject: jobs/osmo-bts: Build osmo-bts-oc2g as well
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12838/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12838/1//COMMIT_MSG@7
PS1, Line 7: jobs/osmo-bts: Build osmo-bts-oc2g as well
jobs/master-builds.yml?



--
To view, visit https://gerrit.osmocom.org/12838
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaeb44b949cf6403601f069800c381fe5eae2f6e
Gerrit-Change-Number: 12838
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:14:24 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in python/osmo-python-tests[master]: osmo-trap2cgi: Fix script installation and dependencies

[daniel]

daniel has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12828 )

Change subject: osmo-trap2cgi: Fix script installation and dependencies
..

osmo-trap2cgi: Fix script installation and dependencies

* Install systemd file with debian
* Depend on python3-aiohttp in python3-osmopy-utils as it is required
  for osmo-trap2cgi

Related: SYS#4399
Sponsored-by: On-Waves ehf
Change-Id: I6add5f37b63dd5fcfdefe0459b539e0050d03897
---
M debian/control
A debian/python3-osmopy-utils.osmo-trap2cgi.service
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Max: Looks good to me, approved



diff --git a/debian/control b/debian/control
index 8bea167..52b614c 100644
--- a/debian/control
+++ b/debian/control
@@ -31,7 +31,7 @@

 Package: python3-osmopy-utils
 Architecture: all
-Depends: ${python3:Depends}, ${misc:Depends}, python3-osmopy-libs, 
python3-twisted, python3-treq
+Depends: ${python3:Depends}, ${misc:Depends}, python3-osmopy-libs, 
python3-twisted, python3-treq, python3-aiohttp
 Description: Python code (not only) for testing of Osmocom programs
  .
  This package contains the Python 3 version of osmopy utils.
diff --git a/debian/python3-osmopy-utils.osmo-trap2cgi.service 
b/debian/python3-osmopy-utils.osmo-trap2cgi.service
new file mode 12
index 000..f1cd169
--- /dev/null
+++ b/debian/python3-osmopy-utils.osmo-trap2cgi.service
@@ -0,0 +1 @@
+../contrib/systemd/osmo-trap2cgi.service
\ No newline at end of file

--
To view, visit https://gerrit.osmocom.org/12828
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6add5f37b63dd5fcfdefe0459b539e0050d03897
Gerrit-Change-Number: 12828
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 

Change in libosmo-netif[master]: Add stream client/server test

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12837 )

Change subject: Add stream client/server test
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:09:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Add stream client/server test

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12837 )

Change subject: Add stream client/server test
..


Patch Set 3: Code-Review+1

I would still have made the test count upwards, and adjust the safeguard and 
abort code accordingly, but it isn't really important. So fine with me. Thanks 
for the explanations!


--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:07:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Add stream client/server test

[Max]

Hello daniel, Harald Welte, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12837

to look at the new patch set (#4).

Change subject: Add stream client/server test
..

Add stream client/server test

Previously stream client and server code were only used in examples
which means regressions could be easily introduced unnoticed until they
trigger bugs in external code which relies on osmo_stream_*()

Fix this by adding basic client-server interaction test with single
reconnection iteration.

Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
---
M .gitignore
M tests/Makefile.am
A tests/stream/stream_test.c
A tests/stream/stream_test.ok
M tests/testsuite.at
5 files changed, 279 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/37/12837/4
--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 

Change in libosmo-netif[master]: Stream client: update logging

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12836 )

Change subject: Stream client: update logging
..


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/12836/1/src/stream.c
File src/stream.c:

https://gerrit.osmocom.org/#/c/12836/1/src/stream.c@52
PS1, Line 52:
> it's customary to put (cli) in such macros, as you don't know how exactly the 
> 'cli' will be specifie […]
Done


https://gerrit.osmocom.org/#/c/12836/1/src/stream.c@136
PS1, Line 136:
> static?
Done



-- 
To view, visit https://gerrit.osmocom.org/12836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53
Gerrit-Change-Number: 12836
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:03:59 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: jobs/osmo-bts: Build osmo-bts-oc2g as well

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12838 )

Change subject: jobs/osmo-bts: Build osmo-bts-oc2g as well
..


Patch Set 1: Verified+1

Build runs through on jenkins


--
To view, visit https://gerrit.osmocom.org/12838
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaeb44b949cf6403601f069800c381fe5eae2f6e
Gerrit-Change-Number: 12838
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:03:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-abis[master]: Log peer's port in accept callback

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12654 )

Change subject: Log peer's port in accept callback
..

Log peer's port in accept callback

* log port from which we accept() the connection in addition to address
* use macro helper for logging

Change-Id: I186974dae1819af8c92f9ea9eeb966ec7c9c9f55
---
M src/input/ipa.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/src/input/ipa.c b/src/input/ipa.c
index 9853ffa..e41ec42 100644
--- a/src/input/ipa.c
+++ b/src/input/ipa.c
@@ -266,8 +266,8 @@
link->addr = talloc_strdup(link, ipbuf);
}

-   LOGP(DLINP, LOGL_NOTICE, "accept()ed new link from %s to port %u\n",
-   inet_ntoa(sa.sin_addr), link->port);
+   LOGIPA(link, LOGL_NOTICE, "accept()ed new link from %s:%u\n",
+   inet_ntoa(sa.sin_addr), ntohs(sa.sin_port));

ret = link->accept_cb(link, fd);
if (ret < 0) {

--
To view, visit https://gerrit.osmocom.org/12654
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I186974dae1819af8c92f9ea9eeb966ec7c9c9f55
Gerrit-Change-Number: 12654
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 

Change in libosmo-abis[master]: Log peer's port in accept callback

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12654 )

Change subject: Log peer's port in accept callback
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12654
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I186974dae1819af8c92f9ea9eeb966ec7c9c9f55
Gerrit-Change-Number: 12654
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:02:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Add stream client/server test

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12837 )

Change subject: Add stream client/server test
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.ok
File tests/stream/stream_test.ok:

https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.ok@54
PS2, Line 54: Test step 3 [client OK, server NA]
> The step output is a bit weird, because it is counting steps down and then 
> stops at 3. […]
Counting down to 0 guarantees that the test will terminate in no longer than 
'steps' iterations regardless of potential issues with callbacks or other 
functions. Stopping at 3 (pretty arbitrary number actually) ensures that that 
test terminated as expected vs via safeguard above.



--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:02:39 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmo-netif[master]: Add stream client/server test

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12837 )

Change subject: Add stream client/server test
..


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.c
File tests/stream/stream_test.c:

https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.c@15
PS2, Line 15: #include 
> Is errno. […]
Yes. See negative error returns below for example.


https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.c@175
PS2, Line 175:
> Should this be 127.0.0.1? If not, please explain.
Pretty much any localhost (127.0.0.1/8) address will do so it doesn't matter if 
it's .1 or .11 or .111 as long as it's the same for server and client.



--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:59:39 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: jobs/osmo-bts: Build osmo-bts-oc2g as well

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/12838


Change subject: jobs/osmo-bts: Build osmo-bts-oc2g as well
..

jobs/osmo-bts: Build osmo-bts-oc2g as well

Build osmo-bts with support for oc2g as well. Uses origin/nrw/oc2g as
firmware.

Fixes: OS#3745
Change-Id: Iaaeb44b949cf6403601f069800c381fe5eae2f6e
---
M jobs/master-builds.yml
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/38/12838/1

diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index 52e3ca7..c908ed9 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -187,9 +187,9 @@

   - osmo-bts:
   a1_name: FIRMWARE_VERSION
-  a1: !!python/tuple [master, femtobts_v2.7, superfemto_v2.4, 
superfemto_v3.0.1pre, superfemto_v3.1, superfemto_v5.1, v2017.01, 
origin/nrw/litecell15]
+  a1: !!python/tuple [master, femtobts_v2.7, superfemto_v2.4, 
superfemto_v3.0.1pre, superfemto_v3.1, superfemto_v5.1, v2017.01, 
origin/nrw/litecell15, origin/nrw/oc2g]
   a2_name: BTS_MODEL
-  a2: !!python/tuple [sysmo, oct, trx, oct+trx, lc15]
+  a2: !!python/tuple [sysmo, oct, trx, oct+trx, lc15, oc2g]
   a3_name: WITH_MANUALS
   a3: !!python/tuple ["1", "0"]
   combination_filter: >
@@ -200,7 +200,8 @@
 (FIRMWARE_VERSION == "superfemto_v3.1" && BTS_MODEL == "sysmo" && 
WITH_MANUALS == "0") ||
 (FIRMWARE_VERSION == "superfemto_v5.1" && BTS_MODEL == "sysmo" && 
WITH_MANUALS == "0") ||
 (FIRMWARE_VERSION == "v2017.01" && BTS_MODEL == "lc15" && 
WITH_MANUALS == "0") ||
-(FIRMWARE_VERSION == "origin/nrw/litecell15" && BTS_MODEL == 
"lc15" && WITH_MANUALS == "0")
+(FIRMWARE_VERSION == "origin/nrw/litecell15" && BTS_MODEL == 
"lc15" && WITH_MANUALS == "0") ||
+(FIRMWARE_VERSION == "origin/nrw/oc2g" && BTS_MODEL == "oc2g" && 
WITH_MANUALS == "0")
   cmd: 'PUBLISH=1 ./contrib/jenkins_bts_model.sh "$BTS_MODEL"'

   - osmo-ggsn:

--
To view, visit https://gerrit.osmocom.org/12838
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaaeb44b949cf6403601f069800c381fe5eae2f6e
Gerrit-Change-Number: 12838
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 

Change in libosmo-netif[master]: Stream client: update logging

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12836 )

Change subject: Stream client: update logging
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53
Gerrit-Change-Number: 12836
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:56:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: VLR tests: use msgb_eq_data_print() for comparison

[Max]

Hello Stefan Sperling, Neels Hofmeyr, Harald Welte, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12571

to look at the new patch set (#3).

Change subject: VLR tests: use msgb_eq_data_print() for comparison
..

VLR tests: use msgb_eq_data_print() for comparison

This simplifies tests refactoring by showing exact byte where mismatch
happened. It also makes code more readable.

No changes in expected test output are necessary because the additional
logging will be triggered iff the test fails so the result will be
visible only during debugging of unit test issues.

Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786
---
M tests/msc_vlr/msc_vlr_tests.c
1 file changed, 12 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/71/12571/3
--
To view, visit https://gerrit.osmocom.org/12571
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: osmith 

Change in libosmo-netif[master]: Add stream client/server test

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12837 )

Change subject: Add stream client/server test
..


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.c
File tests/stream/stream_test.c:

https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.c@15
PS2, Line 15: #include 
Is errno.h used?


https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.c@175
PS2, Line 175:
Should this be 127.0.0.1? If not, please explain.


https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.ok
File tests/stream/stream_test.ok:

https://gerrit.osmocom.org/#/c/12837/2/tests/stream/stream_test.ok@54
PS2, Line 54: Test step 3 [client OK, server NA]
The step output is a bit weird, because it is counting steps down and then 
stops at 3. How about the classic step 1, 2, 3, ...? Or what's the advantage of 
having it implemented like it is now?



--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:55:24 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Stream client: update logging

[Max]

Hello daniel, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12836

to look at the new patch set (#3).

Change subject: Stream client: update logging
..

Stream client: update logging

Introduce logging macro wrapper to properly log current client state and
function to aid in debugging.

Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53
---
M src/stream.c
1 file changed, 25 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/36/12836/3
--
To view, visit https://gerrit.osmocom.org/12836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53
Gerrit-Change-Number: 12836
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 

Change in libosmo-netif[master]: Add stream client/server test

[Max]

Hello daniel, Harald Welte, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12837

to look at the new patch set (#3).

Change subject: Add stream client/server test
..

Add stream client/server test

Previously stream client and server code were only used in examples
which means regressions could be easily introduced unnoticed until they
trigger bugs in external code which relies on osmo_stream_*()

Fix this by adding basic client-server interaction test with single
reconnection iteration.

Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
---
M .gitignore
M tests/Makefile.am
A tests/stream/stream_test.c
A tests/stream/stream_test.ok
M tests/testsuite.at
5 files changed, 305 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/37/12837/3
--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 

Change in libosmo-netif[master]: Stream client: update logging

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12836 )

Change subject: Stream client: update logging
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12836/2/src/stream.c
File src/stream.c:

https://gerrit.osmocom.org/#/c/12836/2/src/stream.c@52
PS2, Line 52: #define LOGSCLI(cli, level, fmt, args...) LOGP(DLINP, level, 
"[%s] %s(): " fmt, get_value_string(stream_cli_state_names, (cli)->state), 
__func__, ## args)
This line is longer than 120 characters



--
To view, visit https://gerrit.osmocom.org/12836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53
Gerrit-Change-Number: 12836
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:40:38 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Stream examples: fix typos in error message

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12825 )

Change subject: Stream examples: fix typos in error message
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12825
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47cc8c7340eb188d85a49d4f41c295bed0e1bee4
Gerrit-Change-Number: 12825
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-CC: daniel 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:29:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Move enum definition to header file

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12598 )

Change subject: Move enum definition to header file
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h
File src/libmsc/smpp_smsc.h:

https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h@22
PS1, Line 22: enum esme_bind {
I'd sort of like the osmo_* prefix here, but then it's missing in 
esme_read_state as well...and it's not part of libosmo*



--
To view, visit https://gerrit.osmocom.org/12598
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71b2512894ec2a71a25f35f07ff4308035d951f9
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: daniel 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:25:56 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmo-netif[master]: Stream examples: fix typos in error message

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12825 )

Change subject: Stream examples: fix typos in error message
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12825/1/examples/stream-server.c
File examples/stream-server.c:

https://gerrit.osmocom.org/#/c/12825/1/examples/stream-server.c@145
PS1, Line 145:  fprintf(stderr, "cannot create server link\n");
> here as well
Done



--
To view, visit https://gerrit.osmocom.org/12825
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47cc8c7340eb188d85a49d4f41c295bed0e1bee4
Gerrit-Change-Number: 12825
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Harald Welte 
Gerrit-CC: daniel 
Gerrit-CC: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:25:00 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmo-netif[master]: Add socket name functions to stream client/server

[Max]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12827

to look at the new patch set (#3).

Change subject: Add socket name functions to stream client/server
..

Add socket name functions to stream client/server

Add functions to get the description of a server link or client
connection which examine data on corresponding socket.

Those functions use static buffers and intended for single use in
log/printf statements as illustarted by corresponding example changes.

Change-Id: If9a8e211da85956781479862a63c4fc6e53ed6be
---
M examples/stream-client.c
M examples/stream-server.c
M include/osmocom/netif/stream.h
M src/stream.c
4 files changed, 35 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/27/12827/3
--
To view, visit https://gerrit.osmocom.org/12827
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9a8e211da85956781479862a63c4fc6e53ed6be
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 

Change in libosmo-netif[master]: Stream client: update logging

[Max]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12836

to look at the new patch set (#2).

Change subject: Stream client: update logging
..

Stream client: update logging

Introduce logging macro wrapper to properly log current client state and
function to aid in debugging.

Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53
---
M src/stream.c
1 file changed, 24 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/36/12836/2
--
To view, visit https://gerrit.osmocom.org/12836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53
Gerrit-Change-Number: 12836
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 

Change in libosmo-netif[master]: Add stream client/server test

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12837 )

Change subject: Add stream client/server test
..


Patch Set 2:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/12837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:18:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmo-netif[master]: Stream examples: print accepted client address

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12826 )

Change subject: Stream examples: print accepted client address
..

Stream examples: print accepted client address

Display socket information for accepted client.

Change-Id: I5aa6757be79754cf7ffa4a276dae1cfb80fe904e
---
M examples/stream-server.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/examples/stream-server.c b/examples/stream-server.c
index 31487a0..b02eefe 100644
--- a/examples/stream-server.c
+++ b/examples/stream-server.c
@@ -5,6 +5,7 @@
 #include 

 #include 
+#include 
 #include 
 #include 
 #include 
@@ -77,6 +78,8 @@

 static int accept_cb(struct osmo_stream_srv_link *srv, int fd)
 {
+   char buf[OSMO_SOCK_NAME_MAXLEN];
+
if (conn != NULL) {
LOGP(DSTREAMTEST, LOGL_ERROR, "Sorry, this example only "
"support one client simultaneously\n");
@@ -91,6 +94,9 @@
return -1;
}

+   osmo_sock_get_name_buf(buf, OSMO_SOCK_NAME_MAXLEN, fd);
+   LOGP(DSTREAMTEST, LOGL_NOTICE, "accepted client: %s\n", buf);
+
return 0;
 }


--
To view, visit https://gerrit.osmocom.org/12826
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5aa6757be79754cf7ffa4a276dae1cfb80fe904e
Gerrit-Change-Number: 12826
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in osmo-bsc[master]: Implement CSFB "Fast Return" Handling at RR RELEASE

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12788 )

Change subject: Implement CSFB "Fast Return" Handling at RR RELEASE
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12788
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfbb87e2e16b05032ad1cb91c11fad1b2f76d755
Gerrit-Change-Number: 12788
Gerrit-PatchSet: 5
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: daniel 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:12:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: Implement CSFB "Fast Return" Handling at RR RELEASE

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12788 )

Change subject: Implement CSFB "Fast Return" Handling at RR RELEASE
..

Implement CSFB "Fast Return" Handling at RR RELEASE

When the MSC sends a BSSMAP CLEAR CMD containing a CSFB Indication IE,
it lets us know that the to-be-released connection related to a CSFB
call.

We as the BSC then subsequently should include the "Cell Selection
Indicator after release of all TCH and SDCCH" IE in the RR RELEASE
message sent to the MS/UE.  This IE contains the LTE neighbor cells
that we're configured to broadcast in si2quater.

That in turn will make sure the MS/UE can return very quickly to
the LTE cell.

Closes: OS#3777
Change-Id: Ibfbb87e2e16b05032ad1cb91c11fad1b2f76d755
Requires: libosmocore Id4bd7f7543f5b0f4f6f876e283bd065039c37646
Requires: libosmocore I0e101af316438b56d63d43fc2cb16d7caf563d07
Requires: libosmocore I8980a6b6d1973b67a2d9ad411c878d956fb428d1
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/osmo_bsc_bssap.c
4 files changed, 89 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 9f2f816..a5fe1f1 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -557,6 +557,9 @@
/* If a release event is being handled, ignore other 
ricocheting release events until that
 * release handling has concluded. */
bool in_release_handler;
+
+   /* is this release at the end of a CSFB call? */
+   bool is_csfb;
} release;

/* The logical channel type */
diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c 
b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index fc34968..13a5730 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -718,6 +718,8 @@
/* Regular allstate event processing */
switch (event) {
case GSCON_EV_A_CLEAR_CMD:
+   if (conn->lchan)
+   conn->lchan->release.is_csfb = *(bool *)data;
/* MSC tells us to cleanly shut down */
if (conn->fi->state != ST_CLEARING)
osmo_fsm_inst_state_chg(fi, ST_CLEARING, 60, 999);
diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c
index f1061ef..349bfea 100644
--- a/src/osmo-bsc/gsm_04_08_rr.c
+++ b/src/osmo-bsc/gsm_04_08_rr.c
@@ -28,7 +28,9 @@
 #include 

 #include 
+#include 
 #include 
+#include 

 #include 
 #include 
@@ -40,6 +42,8 @@
 #include 
 #include 
 #include 
+#include 
+

 /* should ip.access BTS use direct RTP streams between each other (1),
  * or should OpenBSC always act as RTP relay/proxy in between (0) ? */
@@ -236,6 +240,56 @@
lchan->mr_ms_lv + 1);
 }

+
+#define CELL_SEL_IND_AFTER_REL_MAX_BITS(4+MAX_EARFCN_LIST*19)
+#define CELL_SEL_IND_AFTER_REL_MAX_BYTES 
((CELL_SEL_IND_AFTER_REL_MAX_BITS/8)+1)
+
+/* Generate a CSN.1 encoded "Cell Selection Indicator after release of all TCH 
and SDCCH"
+ * as per TF 44.018 version 15.3.0 Table 10.5.2.1e.1.  This only generates the 
"value"
+ * part of the IE, not the tag+length wrapper */
+static int generate_cell_sel_ind_after_rel(uint8_t *out, unsigned int out_len, 
const struct gsm_bts *bts)
+{
+   struct bitvec bv;
+   unsigned int i, rc;
+
+   bv.data = out;
+   bv.data_len = out_len;
+   bitvec_zero();
+
+   /* E-UTRAN Description */
+   bitvec_set_uint(, 3, 3);
+   bitvec_set_bit(, 1);
+
+   for (i = 0; i < MAX_EARFCN_LIST; i++) {
+   const struct osmo_earfcn_si2q *e = 
>si_common.si2quater_neigh_list;
+   if (e->arfcn[i] == OSMO_EARFCN_INVALID)
+   continue;
+
+   if (bitvec_tailroom_bits() < 19) {
+   LOGP(DRR, LOGL_NOTICE, "%s: Not enough room to store 
EARFCN %u in the "
+   "Cell Selection Indicator IE\n", 
gsm_bts_name(bts), e->arfcn[i]);
+   } else {
+   bitvec_set_uint(, e->arfcn[i], 16);
+   /* No "Measurement Bandwidth" */
+   bitvec_set_bit(, 0);
+   /* No "Not Allowed Cells" */
+   bitvec_set_bit(, 0);
+   /* No "TARGET_PCID" */
+   bitvec_set_bit(, 0);
+   }
+   }
+
+   rc = bitvec_used_bytes();
+
+   if (rc == 1) {
+   /* only the header was written to the bitvec, no actual EARFCNs 
were present */
+   return 0;
+   } else {
+   /* return the number of bytes used */
+   return rc;
+   }
+}
+
 /* 7.1.7 and 9.1.7: RR CHANnel RELease */
 int 

Change in libosmo-netif[master]: Stream examples: fix typos in error message

[Max]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12825

to look at the new patch set (#2).

Change subject: Stream examples: fix typos in error message
..

Stream examples: fix typos in error message

Likely a copy-paste error from corresponding client example code.

Change-Id: I47cc8c7340eb188d85a49d4f41c295bed0e1bee4
---
M examples/stream-server.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/25/12825/2
--
To view, visit https://gerrit.osmocom.org/12825
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47cc8c7340eb188d85a49d4f41c295bed0e1bee4
Gerrit-Change-Number: 12825
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: daniel 

Change in libosmocore[master]: gsm0808: Add CSFB indication IE to BSSMAP CLEAR COMMAND

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12829 )

Change subject: gsm0808: Add CSFB indication IE to BSSMAP CLEAR COMMAND
..

gsm0808: Add CSFB indication IE to BSSMAP CLEAR COMMAND

When a call that was established in a CSFB context ends the CLEAR
COMMAND that is send from the BSC to the MSC should contain a CSFB
indication IE, which consists of just the IE byte itsslef. This
additional IE tells the BSC to include other CSFB related IEs into the
RR Release message.

Change-Id: Id8a75e1da2d5f520064666e4ee413d1c91da6ae3
Related: OS#3778
---
M include/osmocom/gsm/gsm0808.h
M src/gsm/gsm0808.c
M src/gsm/libosmogsm.map
3 files changed, 18 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 6d14e13..35e7a8e 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -49,6 +49,7 @@
 struct msgb *gsm0808_create_reset(void);
 struct msgb *gsm0808_create_reset_ack(void);
 struct msgb *gsm0808_create_clear_command(uint8_t cause);
+struct msgb *gsm0808_create_clear_command2(uint8_t cause, bool csfb_ind);
 struct msgb *gsm0808_create_clear_complete(void);
 struct msgb *gsm0808_create_cipher(const struct gsm0808_encrypt_info *ei,
   const uint8_t *cipher_response_mode);
diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index fce8e0a..2907255 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -195,6 +195,22 @@
return msg;
 }

+/*! Create BSSMAP Clear Command message.
+ *  \param[in] cause TS 08.08 cause value.
+ *  \param[in] csfb_ind indicate that the call was established in an CSFB 
context.
+ *  \returns callee-allocated msgb with BSSMAP Clear Command message. */
+struct msgb *gsm0808_create_clear_command2(uint8_t cause, bool csfb_ind)
+{
+   struct msgb *msg = gsm0808_create_clear_command(cause);
+   if (!msg)
+   return NULL;
+
+   if (csfb_ind)
+   msgb_v_put(msg, GSM0808_IE_CSFB_INDICATION);
+
+   return msg;
+}
+
 /*! Create BSSMAP Cipher Mode Command message
  *  \param[in] ei Mandatory Encryption Information
  *  \param[in] cipher_response_mode optional 1-byte Cipher Response Mode
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 3cfe6a7..602c7a6 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -164,6 +164,7 @@
 gsm0808_create_classmark_request;
 gsm0808_create_classmark_update;
 gsm0808_create_clear_command;
+gsm0808_create_clear_command2;
 gsm0808_create_clear_complete;
 gsm0808_create_clear_rqst;
 gsm0808_create_paging;

--
To view, visit https://gerrit.osmocom.org/12829
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8a75e1da2d5f520064666e4ee413d1c91da6ae3
Gerrit-Change-Number: 12829
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: gsm0808: Add CSFB indication IE to BSSMAP CLEAR COMMAND

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12829 )

Change subject: gsm0808: Add CSFB indication IE to BSSMAP CLEAR COMMAND
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12829
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8a75e1da2d5f520064666e4ee413d1c91da6ae3
Gerrit-Change-Number: 12829
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:11:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Add descriptor functions to stream client/server

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12827 )

Change subject: Add descriptor functions to stream client/server
..


Patch Set 1:

when you refer to "description" I initially immediately thought of the kind of 
description that users can set via the VTY.  I'm not sure if "description" is 
good naming in this context.  What about "sockname" instead?


--
To view, visit https://gerrit.osmocom.org/12827
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9a8e211da85956781479862a63c4fc6e53ed6be
Gerrit-Change-Number: 12827
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:10:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #392

[jenkins]

See 


--
[...truncated 2.16 KB...]
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in libosmo-netif[master]: Stream examples: print accepted client address

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12826 )

Change subject: Stream examples: print accepted client address
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12826
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5aa6757be79754cf7ffa4a276dae1cfb80fe904e
Gerrit-Change-Number: 12826
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:08:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Stream client: fix disconnection logic

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12760 )

Change subject: Stream client: fix disconnection logic
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12760
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If41ed60bd625488c283d1e8a2b078e640f04c78e
Gerrit-Change-Number: 12760
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pablo Neira Ayuso 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:07:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Stream client: update logging

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12836 )

Change subject: Stream client: update logging
..


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/12836/1/src/stream.c
File src/stream.c:

https://gerrit.osmocom.org/#/c/12836/1/src/stream.c@52
PS1, Line 52: cli
it's customary to put (cli) in such macros, as you don't know how exactly the 
'cli' will be specified by the caller.


https://gerrit.osmocom.org/#/c/12836/1/src/stream.c@136
PS1, Line 136: const struct value_string stream_cli_state_names[] = {
static?



--
To view, visit https://gerrit.osmocom.org/12836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53
Gerrit-Change-Number: 12836
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:06:57 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC_Tests: Don't make invalid assumptions about RR RELEASE

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12818 )

Change subject: BSC_Tests: Don't make invalid assumptions about RR RELEASE
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12818
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9d078c9b66f040fe673b5d957cf8e2c6d5892c
Gerrit-Change-Number: 12818
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:05:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Add stream client/server test

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12837


Change subject: Add stream client/server test
..

Add stream client/server test

Previously stream client and server code were only used in examples
which means regressions could be easily introduced unnoticed until they
trigger bugs in external code which relies on osmo_stream_*()

Fix this by adding basic client-server interaction test with single
reconnection iteration.

Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
---
M tests/Makefile.am
A tests/stream/stream_test.c
A tests/stream/stream_test.ok
M tests/testsuite.at
4 files changed, 298 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/37/12837/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 03a7a3c..c85c103 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1,7 +1,7 @@
 AM_CFLAGS = -Wall -I$(top_srcdir)/include $(LIBOSMOCORE_CFLAGS) -g
 AM_LDFLAGS = $(LIBOSMOCORE_LDFLAGS)

-check_PROGRAMS = osmux/osmux_test osmux/osmux_test2 jibuf/jibuf_test
+check_PROGRAMS = osmux/osmux_test osmux/osmux_test2 stream/stream_test 
jibuf/jibuf_test
 check_HEADERS =

 osmux_osmux_test_SOURCES = osmux/osmux_test.c
@@ -10,6 +10,9 @@
 osmux_osmux_test2_SOURCES = osmux/osmux_test2.c
 osmux_osmux_test2_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) 
$(top_builddir)/src/libosmonetif.la

+stream_stream_test_SOURCES = stream/stream_test.c
+stream_stream_test_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) 
$(top_builddir)/src/libosmonetif.la
+
 jibuf_jibuf_test_SOURCES = jibuf/jibuf_test.c
 jibuf_jibuf_test_LDADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) 
$(top_builddir)/src/libosmonetif.la

diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c
new file mode 100644
index 000..ed3e9ea
--- /dev/null
+++ b/tests/stream/stream_test.c
@@ -0,0 +1,232 @@
+/*
+ * (C) 2019 by sysmocom - s.f.m.c. GmbH.
+ * Author: Max Suraev
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#define DSTREAMTEST 0
+struct log_info_cat osmo_stream_test_cat[] = {
+   [DSTREAMTEST] = {
+   .name = "DSTREAMTEST",
+   .description = "STREAM test",
+   .color = "\033[1;35m",
+   .enabled = 1, .loglevel = LOGL_DEBUG,
+   },
+};
+
+const struct log_info osmo_stream_test_log_info = {
+   .filter_fn = NULL,
+   .cat = osmo_stream_test_cat,
+   .num_cat = ARRAY_SIZE(osmo_stream_test_cat),
+};
+
+void sighandler(int foo)
+{
+   LOGP(DSTREAMTEST, LOGL_NOTICE, "Signal received: closing stream.\n");
+   exit(EXIT_SUCCESS);
+}
+
+static struct msgb *make_msgb(const char *m)
+{
+   struct msgb *msg = msgb_alloc(512, "STREAM test");
+   if (!msg) {
+   printf("Unable to allocate message\n");
+   return NULL;
+   }
+
+   if (m)
+   msgb_printf(msg, "%s", m);
+
+   return msg;
+}
+
+/* client callbacks */
+static int connect_cb_cli(struct osmo_stream_cli *conn)
+{
+   void *cli_data = osmo_stream_cli_get_data(conn);
+   printf("\nClient's connect() callback triggered [%s]\n", cli_data ? 
"OK" : "NA");
+
+   return 0;
+}
+
+static int read_cb_cli(struct osmo_stream_cli *conn)
+{
+   int bytes;
+   void *cli_data = osmo_stream_cli_get_data(conn);
+   struct msgb *msg = make_msgb(NULL);
+   if (!msg)
+   return -ENOMEM;
+
+   printf("Client's read() callback triggered\n");
+
+   bytes = osmo_stream_cli_recv(conn, msg);
+   if (bytes < 0) {
+   printf("Unable to receive message\n");
+   return -EINVAL;
+   }
+
+   if (bytes)
+   printf("Client received %d(%d) bytes: %s\n", bytes, msg->len, 
msgb_hexdump(msg));
+   else
+   printf("Client received 0 bytes\n");
+
+   /* N. B: do not dereference opaque pointer itself as it might be 
invalid by the time callback is triggered! */
+   if (!cli_data) {
+   /* we reply to trigger server's read() callback */
+   printf("Client's initial connection, contacting server\n");
+   msgb_reset(msg);
+   osmo_stream_cli_set_data(conn, msg);
+   msgb_printf(msg, "%s", "Doh, responding to server :-D");
+   printf("Client sent %d bytes message: %s\n", msg->len, 
msgb_hexdump(msg));
+   osmo_stream_cli_send(conn, msg);
+   } else {
+   printf("Client's subsequent connection, closing link\n");
+   osmo_stream_cli_close(conn);
+   }
+
+   return 0;
+}
+
+/* 

Change in osmo-bsc[master]: Implement CSFB "Fast Return" Handling at RR RELEASE

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12788

to look at the new patch set (#5).

Change subject: Implement CSFB "Fast Return" Handling at RR RELEASE
..

Implement CSFB "Fast Return" Handling at RR RELEASE

When the MSC sends a BSSMAP CLEAR CMD containing a CSFB Indication IE,
it lets us know that the to-be-released connection related to a CSFB
call.

We as the BSC then subsequently should include the "Cell Selection
Indicator after release of all TCH and SDCCH" IE in the RR RELEASE
message sent to the MS/UE.  This IE contains the LTE neighbor cells
that we're configured to broadcast in si2quater.

That in turn will make sure the MS/UE can return very quickly to
the LTE cell.

Closes: OS#3777
Change-Id: Ibfbb87e2e16b05032ad1cb91c11fad1b2f76d755
Requires: libosmocore Id4bd7f7543f5b0f4f6f876e283bd065039c37646
Requires: libosmocore I0e101af316438b56d63d43fc2cb16d7caf563d07
Requires: libosmocore I8980a6b6d1973b67a2d9ad411c878d956fb428d1
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/osmo_bsc_bssap.c
4 files changed, 89 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/12788/5
--
To view, visit https://gerrit.osmocom.org/12788
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibfbb87e2e16b05032ad1cb91c11fad1b2f76d755
Gerrit-Change-Number: 12788
Gerrit-PatchSet: 5
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: daniel 

Change in osmo-ttcn3-hacks[master]: BSC_Tests: Don't make invalid assumptions about RR RELEASE

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12818 )

Change subject: BSC_Tests: Don't make invalid assumptions about RR RELEASE
..

BSC_Tests: Don't make invalid assumptions about RR RELEASE

The RR RELEASE message does not always have to be '060D00'O,
which constrains it to:
* not having any optional IEs
* not having a cause value != 00

Let's relax the matching to accept any RR RELEASE message, whatever
the cause may be, and whether or not there are any optional IEs at the
end.

At the same time, also remove some copy+pasting but rather have one
template that gets used everywhere.

Change-Id: I4b9d078c9b66f040fe673b5d957cf8e2c6d5892c
---
M bsc/BSC_Tests.ttcn
M bsc/BSC_Tests_LCLS.ttcn
2 files changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  daniel: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index af32b8c..5ac8191 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -62,6 +62,7 @@
 const integer NUM_TCHH_PER_BTS := 2;
 const integer NUM_TCHF_PER_BTS := 4;
 const integer NUM_SDCCH_PER_BTS := 4;
+template octetstring t_l3_rr_chan_rel := '060D??*'O;


 /* per-BTS state which we keep */
@@ -860,7 +861,6 @@
   ) runs on test_CT {

var RslLinkId main_dcch := valueof(ts_RslLinkID_DCCH(0));
-   var octetstring l3_rr_chan_rel := '060D00'O;
var boolean got_deact_sacch := false;
var boolean got_rr_chan_rel := false;
var boolean got_rll_rel_req := false;
@@ -872,7 +872,7 @@
got_deact_sacch := true;
repeat;
}
-   [] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0, 
tr_RSL_DATA_REQ(rsl_chan_nr, ?, l3_rr_chan_rel))) {
+   [] IPA_RSL[bts_nr].receive(tr_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0, 
tr_RSL_DATA_REQ(rsl_chan_nr, ?, t_l3_rr_chan_rel))) {
got_rr_chan_rel := true;
repeat;
}
@@ -2812,12 +2812,11 @@
 * RR should be released and Clear Request should go to the MSC. */

var MgcpCommand mgcp;
-   var octetstring l3_rr_chan_rel := '060D00'O;
interleave {
[] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {
log("Got Deact SACCH");
}
-   [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, l3_rr_chan_rel)) {
+   [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, t_l3_rr_chan_rel)) {
log("Got RR Release");
}
[] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL)) {
diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn
index c401206..0fada93 100644
--- a/bsc/BSC_Tests_LCLS.ttcn
+++ b/bsc/BSC_Tests_LCLS.ttcn
@@ -700,10 +700,9 @@

/* Perform hard BSSMAP Clear on "A" side, expect no LS on "B" side */
var myBSSMAP_Cause cause_val := GSM0808_CAUSE_CALL_CONTROL;
-   var octetstring l3_rr_chan_rel := '060D00'O;
CONN_A.send(ts_BSSMAP_ClearCommand(enum2int(cause_val)));
interleave {
-   [] CONN_A.receive(tr_RSL_DATA_REQ(?, tr_RslLinkID_DCCH(0), 
l3_rr_chan_rel));
+   [] CONN_A.receive(tr_RSL_DATA_REQ(?, tr_RslLinkID_DCCH(0), 
t_l3_rr_chan_rel));
[] CONN_A.receive(tr_RSL_DEACT_SACCH(?));
[] CONN_A.receive(tr_RSL_RF_CHAN_REL(?)) -> value rsl {
var RSL_IE_Body ieb;

--
To view, visit https://gerrit.osmocom.org/12818
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b9d078c9b66f040fe673b5d957cf8e2c6d5892c
Gerrit-Change-Number: 12818
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 

Change in osmo-ttcn3-hacks[master]: BSC_Tests: Don't make invalid assumptions about RR RELEASE

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12818 )

Change subject: BSC_Tests: Don't make invalid assumptions about RR RELEASE
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12818
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9d078c9b66f040fe673b5d957cf8e2c6d5892c
Gerrit-Change-Number: 12818
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:01:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: Stream examples: fix typo in error message

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12825 )

Change subject: Stream examples: fix typo in error message
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12825/1/examples/stream-server.c
File examples/stream-server.c:

https://gerrit.osmocom.org/#/c/12825/1/examples/stream-server.c@145
PS1, Line 145:  fprintf(stderr, "cannot create client\n");
here as well



--
To view, visit https://gerrit.osmocom.org/12825
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47cc8c7340eb188d85a49d4f41c295bed0e1bee4
Gerrit-Change-Number: 12825
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: daniel 
Gerrit-Comment-Date: Tue, 05 Feb 2019 14:55:06 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No