Change in osmo-msc[master]: a_iface_bssap: check bssamp length field

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13307 ) Change subject: a_iface_bssap: check bssamp length field .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-bsc[master]: osmo_bsc_bssap: check bssamp length field

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13306 ) Change subject: osmo_bsc_bssap: check bssamp length field .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-msc[master]: a_iface_bssap: check bssamp length field

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13307 Change subject: a_iface_bssap: check bssamp length field .. a_iface_bssap: check bssamp length field At the moment the length field of the bssmap

Change in osmo-bsc[master]: osmo_bsc_bssap: check bssamp length field

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13306 Change subject: osmo_bsc_bssap: check bssamp length field .. osmo_bsc_bssap: check bssamp length field At the moment the length field of the bssmap

Change in osmo-sysmon[master]: Add vty option to print output of shell cmd on every poll step

Hello Max, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13304 to look at the new patch set (#2). Change subject: Add vty option to print output of shell cmd on every poll step

Change in osmo-bts[master]: Constify pcu_rx_*() parameters

Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13298 ) Change subject: Constify pcu_rx_*() parameters .. Constify pcu_rx_*() parameters Use const for data parameter where

Change in osmo-bts[master]: Constify pcu_rx_*() parameters

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13298 ) Change subject: Constify pcu_rx_*() parameters .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13298 To

Change in osmo-ttcn3-hacks[master]: BTS: use PCU-related test cases as version string

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13305 Change subject: BTS: use PCU-related test cases as version string .. BTS: use PCU-related test cases as version string When running PCU-related tests

Change in osmo-sysmon[master]: Add vty option to print output of shell cmd on every poll step

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13304 Change subject: Add vty option to print output of shell cmd on every poll step .. Add vty option to print output of shell cmd on every

Change in osmo-ttcn3-hacks[master]: Use dumpcap for ttcn3-tcpdump-*.sh if available

Max has posted comments on this change. ( https://gerrit.osmocom.org/13253 ) Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available .. Patch Set 5: > But I just realized: `apt install wireshark` and I have another

Change in osmo-ttcn3-hacks[master]: Use dumpcap for ttcn3-tcpdump-*.sh if available

osmith has posted comments on this change. ( https://gerrit.osmocom.org/13253 ) Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available .. Patch Set 5: Code-Review+1 > I'm somewhat reluctant to make it more complex by

Change in osmo-bts[master]: Constify pcu_rx_*() parameters

dexter has posted comments on this change. ( https://gerrit.osmocom.org/13298 ) Change subject: Constify pcu_rx_*() parameters .. Patch Set 1: Code-Review+1 > Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: Use dumpcap for ttcn3-tcpdump-*.sh if available

Max has posted comments on this change. ( https://gerrit.osmocom.org/13253 ) Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available .. Patch Set 5: (4 comments) The tcpdump might be installed into non-standard

Change in osmo-ttcn3-hacks[master]: Use dumpcap for ttcn3-tcpdump-*.sh if available

Hello tnt, Daniel Willmann, Harald Welte, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13253 to look at the new patch set (#5). Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available

Change in osmo-bts[master]: Constify pcu_rx_*() parameters

osmith has posted comments on this change. ( https://gerrit.osmocom.org/13298 ) Change subject: Constify pcu_rx_*() parameters .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13298 To unsubscribe,

Change in osmo-ttcn3-hacks[master]: Use dumpcap for ttcn3-tcpdump-*.sh if available

osmith has posted comments on this change. ( https://gerrit.osmocom.org/13253 ) Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available .. Patch Set 4: Code-Review-1 (4 comments) Supporting /usr/local/bin/dumpcap is

Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh

Max has posted comments on this change. ( https://gerrit.osmocom.org/13301 ) Change subject: Add scripts/osmocom-list-commits.sh .. Patch Set 2: Code-Review+1 (2 comments)

Change in libosmocore[master]: Make rate_ctr_group_free() more robust

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13303 Change subject: Make rate_ctr_group_free() more robust .. Make rate_ctr_group_free() more robust Properly check and handle empty or NULL input.

Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh

osmith has posted comments on this change. ( https://gerrit.osmocom.org/13301 ) Change subject: Add scripts/osmocom-list-commits.sh .. Patch Set 2: (2 comments)

Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh

Hello Pau Espin Pedrol, Max, Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13301 to look at the new patch set (#2). Change subject: Add scripts/osmocom-list-commits.sh

Change in osmo-ci[master]: jobs: add osmocom-list-commits.yml

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13302 Change subject: jobs: add osmocom-list-commits.yml .. jobs: add osmocom-list-commits.yml Related: OS#3840 Change-Id:

Change in osmo-bts[master]: oc2g: change log level for calibration file errors to ERROR

Max has posted comments on this change. ( https://gerrit.osmocom.org/13266 ) Change subject: oc2g: change log level for calibration file errors to ERROR .. Patch Set 3: The commit log doesn't seem to match actual change: it's

Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh

Max has posted comments on this change. ( https://gerrit.osmocom.org/13301 ) Change subject: Add scripts/osmocom-list-commits.sh .. Patch Set 1: (1 comment)

Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh

Max has posted comments on this change. ( https://gerrit.osmocom.org/13301 ) Change subject: Add scripts/osmocom-list-commits.sh .. Patch Set 1: (1 comment)

Change in osmo-ttcn3-hacks[master]: Use dumpcap for ttcn3-tcpdump-*.sh if available

Max has posted comments on this change. ( https://gerrit.osmocom.org/13253 ) Change subject: Use dumpcap for ttcn3-tcpdump-*.sh if available .. Patch Set 4: This change is ready for review. -- To view, visit

Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13301 Change subject: Add scripts/osmocom-list-commits.sh .. Add scripts/osmocom-list-commits.sh Generate a table of Osmocom repositories and their

Change in osmo-bts[master]: testme

dexter has abandoned this change. ( https://gerrit.osmocom.org/13299 ) Change subject: testme .. Abandoned -- To view, visit https://gerrit.osmocom.org/13299 To unsubscribe, or for help writing mail filters, visit

Change in libosmo-sccp[master]: add osmo_sccp_addr_cmp(), osmo_sccp_addr_ri_cmp()

Max has posted comments on this change. ( https://gerrit.osmocom.org/13118 ) Change subject: add osmo_sccp_addr_cmp(), osmo_sccp_addr_ri_cmp() .. Patch Set 2: (1 comment) Do you plan to use osmo_sccp_gt_cmp() or it can be

Change in osmo-bts[master]: Make gsm_pchan2chan_nr() static

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13297 ) Change subject: Make gsm_pchan2chan_nr() static .. Make gsm_pchan2chan_nr() static It's only used inside of gsm_data_shared.c so let's mark

Change in osmo-bts[master]: testme

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13299 ) Change subject: testme .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/13299 To unsubscribe, or for help

Change in osmo-bts[master]: Make gsm_pchan2chan_nr() static

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13297 ) Change subject: Make gsm_pchan2chan_nr() static .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13297 To

Change in osmo-bts[master]: main: remove wrong call to oml_fail_rep() on SIGUSR1/2 and SIGABRT

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13296 ) Change subject: main: remove wrong call to oml_fail_rep() on SIGUSR1/2 and SIGABRT .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-bts[master]: oc2gbts_mgr_calib: don't use fsync() on *FILE pointer

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13271 ) Change subject: oc2gbts_mgr_calib: don't use fsync() on *FILE pointer .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: l1_if: add include for missing header file

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13273 ) Change subject: l1_if: add include for missing header file .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: pcu_sock: cast to long unsigned int before printing

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13267 ) Change subject: pcu_sock: cast to long unsigned int before printing .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: oc2gbts_mgr_calib: do not return NULL on integer function

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13272 ) Change subject: oc2gbts_mgr_calib: do not return NULL on integer function .. Patch Set 3: Code-Review+2 Thanks for checking. I didn't

Change in gr-gsm[master]: Fix the TCH/H decoder and demapper XML definitions

Hello Piotr Krysik, fixeria, Vadim Yanitskiy, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13246 to look at the new patch set (#2). Change subject: Fix the TCH/H decoder and demapper XML definitions

Change in osmo-bts[master]: testme

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13299 Change subject: testme .. testme Change-Id: I8ab2f766a159a9bf79fe43be74e26d6358620763 --- A test.me 1 file changed, 0 insertions(+), 0 deletions(-)

Change in osmo-bts[master]: Make gsm_pchan2chan_nr() static

dexter has posted comments on this change. ( https://gerrit.osmocom.org/13297 ) Change subject: Make gsm_pchan2chan_nr() static .. Patch Set 1: Code-Review+1 > Build Successful > >

Change in osmo-bts[master]: Constify pcu_rx_*() parameters

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13298 Change subject: Constify pcu_rx_*() parameters .. Constify pcu_rx_*() parameters Use const for data parameter where appropriate. Change-Id:

Change in osmo-bts[master]: oc2gbts_mgr_calib: don't use fsync() on *FILE pointer

Hello Daniel Willmann, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13271 to look at the new patch set (#3). Change subject: oc2gbts_mgr_calib: don't use fsync() on *FILE pointer

Change in osmo-bts[master]: Make gsm_pchan2chan_nr() static

Max has uploaded this change for review. ( https://gerrit.osmocom.org/13297 Change subject: Make gsm_pchan2chan_nr() static .. Make gsm_pchan2chan_nr() static It's only used inside of gsm_data_shared.c so let's mark it as

Change in osmo-bts[master]: oc2gbts_mgr_vty: remove calls to vty_install_default()

dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13270 ) Change subject: oc2gbts_mgr_vty: remove calls to vty_install_default() .. oc2gbts_mgr_vty: remove calls to vty_install_default() The

Change in osmo-bts[master]: oml: make oml_tx_failure_event_rep() public

dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13264 ) Change subject: oml: make oml_tx_failure_event_rep() public .. oml: make oml_tx_failure_event_rep() public The static function

Change in osmo-pcu[master]: MS store: move test helper to unit test

osmith has posted comments on this change. ( https://gerrit.osmocom.org/13213 ) Change subject: MS store: move test helper to unit test .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13213 To

Change in osmo-bts[master]: oc2g: change log level for calibration file errors to ERROR

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13266 to look at the new patch set (#3). Change subject: oc2g: change log level for calibration file errors to ERROR

Change in osmo-bts[master]: oml: use oml_tx_failure_event_rep() instead of signals to SS_FAIL

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13269 to look at the new patch set (#2). Change subject: oml: use oml_tx_failure_event_rep() instead of signals to SS_FAIL

Change in osmo-bts[master]: oml: use oml_tx_failure_event_rep() instead of oml_fail_rep()

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13268 to look at the new patch set (#2). Change subject: oml: use oml_tx_failure_event_rep() instead of oml_fail_rep()

Change in osmo-bts[master]: main: remove wrong call to oml_fail_rep() on SIGUSR1/2 and SIGABRT

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13296 Change subject: main: remove wrong call to oml_fail_rep() on SIGUSR1/2 and SIGABRT .. main: remove wrong call to oml_fail_rep() on SIGUSR1/2 and

Change in osmo-bts[master]: pcu_sock: cast to long unsigned int before printing

Max has posted comments on this change. ( https://gerrit.osmocom.org/13267 ) Change subject: pcu_sock: cast to long unsigned int before printing .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13267

Change in osmo-bts[master]: l1_if: add include for missing header file

Max has posted comments on this change. ( https://gerrit.osmocom.org/13273 ) Change subject: l1_if: add include for missing header file .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13273 To

Change in osmo-bts[master]: l1_if: add include for missing header file

Hello Pau Espin Pedrol, Daniel Willmann, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13273 to look at the new patch set (#2). Change subject: l1_if: add include for missing header file

Change in osmo-bts[master]: oc2gbts_mgr_calib: don't use fsync() von *FILE pointer

Hello Daniel Willmann, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13271 to look at the new patch set (#2). Change subject: oc2gbts_mgr_calib: don't use fsync() von *FILE pointer

Change in osmo-bts[master]: pcu_sock: cast to long unsigned int before printing

Hello Pau Espin Pedrol, Daniel Willmann, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13267 to look at the new patch set (#2). Change subject: pcu_sock: cast to long unsigned int before printing

Change in osmo-bts[master]: oc2gbts_mgr_calib: do not return NULL on integer function

dexter has posted comments on this change. ( https://gerrit.osmocom.org/13272 ) Change subject: oc2gbts_mgr_calib: do not return NULL on integer function .. Patch Set 1: > I'm almost sure I did the same kind of fixes for LC-15

Change in osmo-bts[master]: pcu_sock: cast to long unsigned int before printing

dexter has posted comments on this change. ( https://gerrit.osmocom.org/13267 ) Change subject: pcu_sock: cast to long unsigned int before printing .. Patch Set 1: > Agree with Harald I see, didn't know about the %z before.

Change in osmo-bts[master]: lc15: remove unused define constant FACTORY_ROM_PATH

dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13263 ) Change subject: lc15: remove unused define constant FACTORY_ROM_PATH .. lc15: remove unused define constant FACTORY_ROM_PATH Change-Id:

Change in osmo-bts[master]: oc2g: remove unused define constant FACTORY_ROM_PATH

dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13262 ) Change subject: oc2g: remove unused define constant FACTORY_ROM_PATH .. oc2g: remove unused define constant FACTORY_ROM_PATH Change-Id: