Change in ...osmo-mgw[master]: manuals: Update vty/counter documentation

2019-06-19 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14533 ) Change subject: manuals: Update vty/counter documentation .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...openbsc[master]: manuals: Generate vty/counter documentation for osmo-bscnat

2019-06-19 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14530 ) Change subject: manuals: Generate vty/counter documentation for osmo-bscnat .. Patch Set 1: Code-Review-1 (1 comment) https

Change in ...libosmocore[master]: vty: Remove trailing whitespace in output from show asciidoc

2019-06-19 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14536 ) Change subject: vty: Remove trailing whitespace in output from show asciidoc .. vty: Remove trailing whitespace in output

Change in ...docker-playground[master]: regen_doc.sh: Add optional parameter to customize docker execution

2019-06-19 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14527 ) Change subject: regen_doc.sh: Add optional parameter to customize docker execution .. Patch Set 2: (1 comment) https

Change in ...docker-playground[master]: regen_doc.sh: Add optional parameter to customize docker execution

2019-06-19 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14527 ) Change subject: regen_doc.sh: Add optional parameter to customize docker execution .. Patch Set 2: Code-Review+1

Change in ...osmo-msc[master]: sms_queue.c: Improve misleading log line

2019-06-20 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14554 Change subject: sms_queue.c: Improve misleading log line .. sms_queue.c: Improve misleading log line Otherwise when read in a log

Change in ...osmo-msc[master]: sms_queue.c: Improve misleading log line

2019-06-20 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14554 ) Change subject: sms_queue.c: Improve misleading log line .. sms_queue.c: Improve misleading log line Otherwise when read

Change in ...openbsc[master]: bsc-nat: Remove whitespace at the end of CTR descriptions

2019-06-20 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14539 ) Change subject: bsc-nat: Remove whitespace at the end of CTR descriptions .. Patch Set 1: Anyways, we don't use that formatting

Change in ...osmo-ggsn[master]: gtp: queue.c: Document queue APIs

2019-06-20 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14557 ) Change subject: gtp: queue.c: Document queue APIs .. Patch Set 2: Code-Review+2 Oh thanks I forgot about the final dot

Change in ...libosmo-abis[master]: ipaccess: allow tcp keepalive for ipa clients, add TCP_USER_TIMEOUT

2019-06-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14562 ) Change subject: ipaccess: allow tcp keepalive for ipa clients, add TCP_USER_TIMEOUT .. Patch Set 2: This patch should be split

Change in ...libosmocore[master]: gsm: lapd_core: Log timeout used upon start of T200

2019-06-21 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14566 Change subject: gsm: lapd_core: Log timeout used upon start of T200 .. gsm: lapd_core: Log timeout used upon start of T200

Change in ...docker-playground[master]: ttcn3-hlr-test: log to file and gsmtap

2019-06-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14563 ) Change subject: ttcn3-hlr-test: log to file and gsmtap .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14563/2

Change in ...libosmo-abis[master]: ipaccess: allow tcp keepalive for ipa clients

2019-06-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14564 ) Change subject: ipaccess: allow tcp keepalive for ipa clients .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...libosmo-abis[master]: add TCP_USER_TIMEOUT to keepalive

2019-06-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14565 ) Change subject: add TCP_USER_TIMEOUT to keepalive .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in ...docker-playground[master]: ttcn3-hlr-test: log to file and gsmtap

2019-06-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14563 ) Change subject: ttcn3-hlr-test: log to file and gsmtap .. Patch Set 2: Then if you want to push it forward, add it for all

Change in ...osmo-bts[master]: revert changes to T200

2019-06-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14567 ) Change subject: revert changes to T200 .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14567/1/src/common/oml.c File src

Change in ...osmo-bts[master]: revert changes to T200

2019-06-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14567 ) Change subject: revert changes to T200 .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14567/1//COMMIT_MSG Commit

Change in ...osmo-bts[master]: revert changes to T200

2019-06-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14567 ) Change subject: revert changes to T200 .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts

Change in ...osmo-bts[master]: bts: Set T200 DCCH values for CCCH

2019-06-21 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14568 Change subject: bts: Set T200 DCCH values for CCCH .. bts: Set T200 DCCH values for CCCH Otherwise t200_ms_dcch array values are left

Change in ...libosmocore[master]: gsm: lapd_core: Log timeout used upon start of T200

2019-06-21 Thread pespin
/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib50a9c23de881c66c9218833703cc41101e06bfd Gerrit-Change-Number: 14566 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-bts[master]: bts: Set T200 DCCH values for CCCH

2019-06-21 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14568 ) Change subject: bts: Set T200 DCCH values for CCCH .. Patch Set 1: I'm not sure this is the best approach or even really correct

Change in ...osmo-ggsn[master]: cosmetic: gtp: queue: remove trailing whitespace

2019-06-20 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14555 Change subject: cosmetic: gtp: queue: remove trailing whitespace .. cosmetic: gtp: queue: remove trailing whitespace Change-Id

Change in ...osmo-ggsn[master]: gtp: queue.c: Document queue APIs

2019-06-20 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14557 Change subject: gtp: queue.c: Document queue APIs .. gtp: queue.c: Document queue APIs Change-Id

Change in ...osmo-ggsn[master]: gtp: Add missing headers

2019-06-20 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14556 Change subject: gtp: Add missing headers .. gtp: Add missing headers Those headers are using types defined in other places (like

Change in ...osmo-msc[master]: libmsc/msc_net_init.c: pass pointer to gsm_network directly

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14467 ) Change subject: libmsc/msc_net_init.c: pass pointer to gsm_network directly .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: inform HLR/EUSE if Paging has failed

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14475 ) Change subject: libmsc/gsm_09_11.c: inform HLR/EUSE if Paging has failed .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: properly handle OSMO_GSUP_MSGT_PROC_SS_ERROR

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14477 ) Change subject: libmsc/gsm_09_11.c: properly handle OSMO_GSUP_MSGT_PROC_SS_ERROR .. Patch Set 1: Code-Review+1 (1 comment) https

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: drop rudimentary vsub->cgi.lai.lac check

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14465 ) Change subject: libmsc/gsm_09_11.c: drop rudimentary vsub->cgi.lai.lac check .. Patch Set 3: Code-Review+2 -- To view, visit ht

Change in ...libosmocore[master]: bitvec: correct comment in bitvec_alloc

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14479 ) Change subject: bitvec: correct comment in bitvec_alloc .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-pcu[master]: tests/BitcompTest: fix wording in log message

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14482 ) Change subject: tests/BitcompTest: fix wording in log message .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-pcu[master]: decompress_crbb: replace int8_t with uint8_t as length

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14480 ) Change subject: decompress_crbb: replace int8_t with uint8_t as length .. Patch Set 1: Assert failed test[itr].expect_rc == rc

Change in ...osmo-pcu[master]: decompress_crbb: add length argument for search_runlen

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14481 ) Change subject: decompress_crbb: add length argument for search_runlen .. Patch Set 1: Code-Review+1 (1 comment) https

Change in ...osmo-pcu[master]: encoding: use `/* */` for comments instead of `#if 0 #endif`

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14483 ) Change subject: encoding: use `/* */` for comments instead of `#if 0 #endif` .. Patch Set 1: Code-Review+1 (2 comments) https

Change in ...osmo-pcu[master]: egprs_rlc_compression: fix white spaces

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14484 ) Change subject: egprs_rlc_compression: fix white spaces .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() and early trans allocation

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14463 ) Change subject: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() and early trans allocation .. Patch Set 3: Code-Review+1 (1 comment

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: log network-originated session establishment error

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14464 ) Change subject: libmsc/gsm_09_11.c: log network-originated session establishment error .. Patch Set 3: Code-Review+2 -- To view

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: drop meaningless check for concurrent paging

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14466 ) Change subject: libmsc/gsm_09_11.c: drop meaningless check for concurrent paging .. Patch Set 3: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: Add Cell Broadcast related definitions from 3GPP TS 23.041

2019-06-17 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14471 ) Change subject: Add Cell Broadcast related definitions from 3GPP TS 23.041 .. Patch Set 1: /home/osmocom-build/jenkins/workspace

Change in ...osmo-mgw[master]: mgcp-cli: Support lowercase header parameters

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14594 ) Change subject: mgcp-cli: Support lowercase header parameters .. mgcp-cli: Support lowercase header parameters MGCP RFC3435

Change in ...osmo-mgw[master]: mgw: Allow receiving lowercase MGCP header keyword

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14598 ) Change subject: mgw: Allow receiving lowercase MGCP header keyword .. mgw: Allow receiving lowercase MGCP header keyword

Change in ...osmo-mgw[master]: mgw: Allow receiving uppercase noanswer keyword

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14600 ) Change subject: mgw: Allow receiving uppercase noanswer keyword .. mgw: Allow receiving uppercase noanswer keyword MGCP

Change in ...osmo-mgw[master]: mgw: Support receiving uppercase connection mode

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14595 ) Change subject: mgw: Support receiving uppercase connection mode .. mgw: Support receiving uppercase connection mode MGCP

Change in ...osmo-mgw[master]: mgw: Support receiving lowercase LCO codec

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14596 ) Change subject: mgw: Support receiving lowercase LCO codec .. mgw: Support receiving lowercase LCO codec MGCP RFC3435 (https

Change in ...osmo-mgw[master]: mgw: Support uppercase LCO options

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14589 ) Change subject: mgw: Support uppercase LCO options .. mgw: Support uppercase LCO options MGCP RFC3435 (https

Change in ...osmo-mgw[master]: mgw: Make check of duplicated LCO fields case insensitive

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14597 ) Change subject: mgw: Make check of duplicated LCO fields case insensitive .. mgw: Make check of duplicated LCO fields case

Change in ...osmo-mgw[master]: mgw: Support lowercase header parameters

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14590 ) Change subject: mgw: Support lowercase header parameters .. mgw: Support lowercase header parameters MGCP RFC3435 (https

Change in ...osmo-mgw[master]: mgw: Allow receiving lowercase X-Osmo-Ign Callid field

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14599 ) Change subject: mgw: Allow receiving lowercase X-Osmo-Ign Callid field .. mgw: Allow receiving lowercase X-Osmo-Ign Callid

Change in ...osmo-ttcn3-hacks[master]: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14659 ) Change subject: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates .. Patch Set 1: Code-Review+1 -- To view

Change in ...osmo-mgw[master]: "make dist" fix for: no rule to make mgcp_common.h

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14655 ) Change subject: "make dist" fix for: no rule to make mgcp_common.h .. Patch Set 2: Code-Review+1 (1 comme

Change in ...osmo-mgw[master]: mgw: Support uppercase LCO options

2019-07-03 Thread pespin
://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d Gerrit-Change-Number: 14589 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14660 ) Change subject: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-mgw[master]: mgw: Support lowercase header parameters

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14590 ) Change subject: mgw: Support lowercase header parameters .. Patch Set 3: Code-Review+2 Only commit description changed with fix

Change in ...osmo-mgw[master]: mgcp-cli: Support lowercase header parameters

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14594 ) Change subject: mgcp-cli: Support lowercase header parameters .. Patch Set 2: Code-Review+2 Only commit description changed with fix

Change in ...osmo-mgw[master]: mgw: Support uppercase LCO options

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14589 ) Change subject: mgw: Support uppercase LCO options .. Patch Set 2: Code-Review+2 Adding +2 after applying osmith's comment

Change in ...docker-playground[master]: debian-stretch-build-dist: new Dockerfile

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14654 ) Change subject: debian-stretch-build-dist: new Dockerfile .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-mgw[master]: mgw: Support uppercase LCO options

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14589 ) Change subject: mgw: Support uppercase LCO options .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14589/1/src/libosmo

Change in ...osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14658 ) Change subject: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation .. Patch Set 1: Code-Review+1 -- To view

Change in ...osmo-mgw[master]: mgw: Support lowercase header parameters

2019-07-03 Thread pespin
https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I48252415f9d0cd985ad097f334aa4c1665f52511 Gerrit-Change-Number: 14590 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith

Change in ...osmo-mgw[master]: mgcp-cli: Support lowercase header parameters

2019-07-03 Thread pespin
Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f7b07b77c2946e9cd6f0eeca00011bd905126dd Gerrit-Change-Number: 14594 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Transceiver: Get rid of SoftVector in struct

Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API .. Transceiver: replace UDPSocket with libosmocore

Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector()

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() .. Transceiver: Move soft bits normalization

Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind .. Transceiver: Drop use of GSM::Time from

Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu...

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() .. Transceiver: Move

Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind .. Patch Set 2: +1+1=2 -- To view, visit https

Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Patch Set 2: Code-Review+2 +1+1=+2 -- To view

Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API .. Patch Set 2: Code-Review+2 +1+1=+2 -- To view, visit

Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation

2019-07-04 Thread pespin
-Id: Ib4ceec553f2e5f77bf3f624968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version .. Patch Set 6: Code-Review-1 See my comment from

Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu...

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() .. Patch Set 2: Code-Review+2

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version .. Patch Set 5: Code-Review-1 (6 comments) https

Change in ...osmo-pcap[master]: gitignore: fix application names

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14671 ) Change subject: gitignore: fix application names .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make"

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix "./configure && make clean && make" .. tests/Makefile.am

Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make"

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix "./configure && make clean && make" .. Patch Set 2: (1 comment)

Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 ) Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in ...osmo-trx[master]: Add C/I computation

2019-07-04 Thread pespin
g/c/osmo-trx/+/14674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib4ceec553f2e5f77bf3f624968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: newchange

Change in ...osmo-trx[master]: Transceiver: Support TRXD v1

2019-07-04 Thread pespin
-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation

2019-07-04 Thread pespin
: Ib4ceec553f2e5f77bf3f624968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset

Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14612 ) Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers .. Patch Set 4: (2 comments) https

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Patch Set 2: (1 comment) https

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14593 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support .. Patch Set 7: Code-Review+1 -- To view, visit

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14669 ) Change subject: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst() family: Use struct to gather all out params

2019-07-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14672 Change subject: sigProcLib: detectAnyBurst() family: Use struct to gather all out params .. sigProcLib: detectAnyBurst() family: Use

Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst(): make TSC used to detect burst available...

2019-07-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14673 Change subject: sigProcLib: detectAnyBurst(): make TSC used to detect burst available to caller .. sigProcLib: detectAnyBurst(): make

Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation

2019-07-04 Thread pespin
: Ib4ceec553f2e5f77bf3f624968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset

Change in ...osmo-trx[master]: Transceiver: Support TRXD v1

2019-07-04 Thread pespin
: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 ) Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs .. Patch Set 1: Code-Review+1 (1 comment) https

Change in ...osmo-trx[master]: Transceiver: Support TRXD v1

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 .. Patch Set 6: (2 comments) This change is ready for review. https

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version .. Patch Set 6: (1 comment) https

Change in ...osmo-trx[master]: Transceiver: Move nbits burst size calculation to pullRadioVector()

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14656 ) Change subject: Transceiver: Move nbits burst size calculation to pullRadioVector() .. Transceiver: Move nbits burst size

Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field

2019-07-03 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 ) Change subject: Transceiver: Drop unused rssi_valid struct field .. Transceiver: Drop unused rssi_valid struct field

Change in ...osmo-trx[master]: Transceiver: Move nbits calculation to pullRadioVector()

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14631 ) Change subject: Transceiver: Move nbits calculation to pullRadioVector() .. Patch Set 3: Abandoned in favor of merged https

Change in ...osmo-trx[master]: Transceiver: Move nbits calculation to pullRadioVector()

2019-07-03 Thread pespin
pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14631 ) Change subject: Transceiver: Move nbits calculation to pullRadioVector() .. Abandoned Abandoned in favor of merged https://gerrit.osmocom.org

Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU

2019-07-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 ) Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-trx[master]: Transceiver: Simplify code on early error return when calling detectA...

2019-07-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14662 Change subject: Transceiver: Simplify code on early error return when calling detectAnyBurst .. Transceiver: Simplify code on early

Change in ...osmo-trx[master]: Transceiver: Support pulling idle frames in pullRadioVector()

2019-07-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14664 Change subject: Transceiver: Support pulling idle frames in pullRadioVector() .. Transceiver: Support pulling idle frames

Change in ...osmo-trx[master]: Transceiver: Move out TRXD socket send code to prepare for TRXDv1

2019-07-03 Thread pespin
-Change-Number: 14646 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset

Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command

2019-07-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14665 Change subject: Transceiver: Support SETFORMAT command .. Transceiver: Support SETFORMAT command Only old v0 is supported so far

<    1   2   3   4   5   6   7   8   9   10   >