Change in libosmo-netif[master]: src/stream.c: Don't leak socket during SCTP_EVENTS getsockopt

2020-06-03 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18639 ) Change subject: src/stream.c: Don't leak socket during SCTP_EVENTS getsockopt .. src/stream.c: Don't leak socket during

Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands

2020-06-03 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556 ) Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands .. trx_if: Clarify {SET;ADJ}POWER TRXC commands Change-Id:

Change in osmo-gsm-manuals[master]: trx_if: Clarify {SET; ADJ}POWER TRXC commands

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18556 ) Change subject: trx_if: Clarify {SET;ADJ}POWER TRXC commands .. Patch Set 3: Code-Review+2 -- To view, visit

Change in libosmo-netif[master]: src/stream.c: Don't leak socket during SCTP_EVENTS getsockopt

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18639 ) Change subject: src/stream.c: Don't leak socket during SCTP_EVENTS getsockopt .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. Patch Set 8: This change is ready for review. -- To

Change in osmo-bsc[master]: is_cm_service_for_emerg(): return false, not 0

2020-06-03 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18650 ) Change subject: is_cm_service_for_emerg(): return false, not 0 .. is_cm_service_for_emerg(): return false, not 0 Change-Id:

Change in osmo-hlr[master]: osmo-mslookup-client: fix segfault for respond_error() caller

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/18651 ) Change subject: osmo-mslookup-client: fix segfault for respond_error() caller .. Patch Set 1: (2 comments)

Change in osmo-hlr[master]: osmo-mslookup-client: fix segfault for respond_error() caller

2020-06-03 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/18651 ) Change subject: osmo-mslookup-client: fix segfault for respond_error() caller .. osmo-mslookup-client: fix segfault for respond_error() caller

Change in osmo-mgw[master]: mgcp_trunk: remove audio_name and audio_payloa

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18645 ) Change subject: mgcp_trunk: remove audio_name and audio_payloa .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18644 ) Change subject: osmo-mgw: refactor endpoint and trunk handling .. Patch Set 1: Code-Review+1 like in the previous patch, I'm still

Change in osmo-mgw[master]: mgcp_trunk: remove audio_name and audio_payload

2020-06-03 Thread dexter
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18645 to look at the new patch set (#2). Change subject: mgcp_trunk: remove audio_name and audio_payload

Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling

2020-06-03 Thread dexter
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18644 to look at the new patch set (#2). Change subject: osmo-mgw: refactor endpoint and trunk handling

Change in osmo-hlr[master]: osmo-mslookup-client: fix segfault for respond_error() caller

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/18651 ) Change subject: osmo-mslookup-client: fix segfault for respond_error() caller .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-bsc[master]: gsm0408_test.c: drop test_mi_functionality()

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18648 ) Change subject: gsm0408_test.c: drop test_mi_functionality() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 ) Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds .. Patch Set 5: This change is ready for review. -- To view,

Change in docker-playground[master]: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch

2020-06-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/18655 ) Change subject: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch .. ttcn3-bts: Update cfg for test

Change in docker-playground[master]: ttcn3-bts: jenkins.sh: Log fake_trx stdout to file

2020-06-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/18642 ) Change subject: ttcn3-bts: jenkins.sh: Log fake_trx stdout to file .. ttcn3-bts: jenkins.sh: Log fake_trx stdout to file

Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18644 ) Change subject: osmo-mgw: refactor endpoint and trunk handling .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-mgw[master]: mgcp_vty: fix indentation in VTY config write

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18593 ) Change subject: mgcp_vty: fix indentation in VTY config write .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: osmo-mgw: rename struct mgcp_trunk_config and symbol tcfg

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18643 ) Change subject: osmo-mgw: rename struct mgcp_trunk_config and symbol tcfg .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: is_cm_service_for_emerg(): return false, not 0

2020-06-03 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18650 ) Change subject: is_cm_service_for_emerg(): return false, not 0 .. is_cm_service_for_emerg(): return false, not 0 Change-Id:

Change in osmo-bsc[master]: is_cm_service_for_emerg(): return false, not 0

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18650 ) Change subject: is_cm_service_for_emerg(): return false, not 0 .. Patch Set 1: Code-Review+2 missed a comment, should have been part

Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. Patch Set 8: Code-Review+1 -- To view, visit

Change in osmo-hlr[master]: osmo-mslookup-client: fix segfault for respond_error() caller

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/18651 ) Change subject: osmo-mslookup-client: fix segfault for respond_error() caller .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: bts-trx: Re-apply tx power if nominal power is received after POWERON

2020-06-03 Thread pespin
pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/18652 ) Change subject: bts-trx: Re-apply tx power if nominal power is received after POWERON .. bts-trx: Re-apply tx power if nominal power

Change in osmo-hlr[master]: osmo-mslookup-client: fix segfault for respond_error() caller

2020-06-03 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/18651 ) Change subject: osmo-mslookup-client: fix segfault for respond_error() caller .. osmo-mslookup-client: fix segfault for

Change in osmo-gsm-manuals[master]: trx_if.adoc: Document cmd NOMTXPOWER

2020-06-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18630 ) Change subject: trx_if.adoc: Document cmd NOMTXPOWER .. trx_if.adoc: Document cmd NOMTXPOWER TRXC message is implemented in:

Change in osmo-bts[master]: bts-trx: vty: Add 'nominal-tx-power' cmd

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18579 ) Change subject: bts-trx: vty: Add 'nominal-tx-power' cmd .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-gsm-manuals[master]: trx_if.adoc: Document cmd NOMTXPOWER

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18630 ) Change subject: trx_if.adoc: Document cmd NOMTXPOWER .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from os...

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18589 ) Change subject: bts-trx: Use TRXC cmd NOMTXPOWER to retrieve nominal tx power from osmo-trx .. Patch Set 3: Code-Review+1 -- To

Change in osmo-bts[master]: bts-trx: vty: Add 'nominal-tx-power' cmd

2020-06-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18579 ) Change subject: bts-trx: vty: Add 'nominal-tx-power' cmd .. bts-trx: vty: Add 'nominal-tx-power' cmd This value will be soon acquired

Change in pysim[master]: commands.py: fix read_binary for lengths > 256

2020-06-03 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17848 ) Change subject: commands.py: fix read_binary for lengths > 256 .. Patch Set 8: > Patch Set 8: > > can this be merged please? I

Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds

2020-06-03 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/18641 to look at the new patch set (#6). Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds

Change in osmo-mgw[master]: trunk: get rid of virt_trunk pointer

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18590 ) Change subject: trunk: get rid of virt_trunk pointer .. Patch Set 5: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: bts-trx: Re-apply tx power if nominal power is receives after POWERON

2020-06-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18652 ) Change subject: bts-trx: Re-apply tx power if nominal power is receives after POWERON .. bts-trx: Re-apply tx power if nominal

Change in osmo-ci[master]: remove openbsc from nightly and latest builds

2020-06-03 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/18656 ) Change subject: remove openbsc from nightly and latest builds .. remove openbsc from nightly and latest builds The only part that

Change in docker-playground[master]: ttcn3-bts: jenkins.sh: Log fake_trx stdout to file

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18642 ) Change subject: ttcn3-bts: jenkins.sh: Log fake_trx stdout to file .. Patch Set 1: Verified+1 -- To view, visit

Change in osmo-mgw[master]: mgcp_vty: fix indentation in VTY config write

2020-06-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18593 ) Change subject: mgcp_vty: fix indentation in VTY config write .. mgcp_vty: fix indentation in VTY config write The config under the node mgcp

Change in osmo-mgw[master]: osmo-mgw: rename struct mgcp_trunk_config and symbol tcfg

2020-06-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18643 ) Change subject: osmo-mgw: rename struct mgcp_trunk_config and symbol tcfg .. osmo-mgw: rename struct mgcp_trunk_config and symbol tcfg rename

Change in osmo-bsc[master]: refactor bsc_find_msc()'s round-robin

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18505 ) Change subject: refactor bsc_find_msc()'s round-robin .. Patch Set 4: Code-Review+1 -- To view, visit

Change in osmo-mgw[master]: osmo-mgw: rename struct mgcp_trunk_config and symbol tcfg

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18643 ) Change subject: osmo-mgw: rename struct mgcp_trunk_config and symbol tcfg .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18644 ) Change subject: osmo-mgw: refactor endpoint and trunk handling .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-mgw[master]: mgcp_trunk: remove audio_name and audio_payload

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18645 ) Change subject: mgcp_trunk: remove audio_name and audio_payload .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bts: Introduce test TC_tx_power_start_ramp_up_bcch

2020-06-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654 ) Change subject: bts: Introduce test TC_tx_power_start_ramp_up_bcch .. bts: Introduce test TC_tx_power_start_ramp_up_bcch

Change in osmo-ttcn3-hacks[master]: bts: Fix trailing whitespace

2020-06-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18653 ) Change subject: bts: Fix trailing whitespace .. bts: Fix trailing whitespace Change-Id:

Change in osmo-ci[master]: remove openbsc from nightly and latest builds

2020-06-03 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18656 ) Change subject: remove openbsc from nightly and latest builds .. Patch Set 1: Code-Review+1 -- To view, visit

Change in docker-playground[master]: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18655 ) Change subject: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch .. Patch Set 1: Verified+1 -- To view, visit

Change in osmo-bts[master]: bts-trx: phy_link: Improve logging fmt in phy_link_state_set()

2020-06-03 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18646 ) Change subject: bts-trx: phy_link: Improve logging fmt in phy_link_state_set() .. bts-trx: phy_link: Improve logging fmt in

Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. Patch Set 4: (1 comment)

Change in osmo-msc[master]: contrib/osmo-msc.spec.in: Enable SMPP in RPM builds

2020-06-03 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/18640 ) Change subject: contrib/osmo-msc.spec.in: Enable SMPP in RPM builds .. contrib/osmo-msc.spec.in: Enable SMPP in RPM builds The

Change in osmo-msc[master]: contrib/osmo-msc.spec.in: Enable SMPP in RPM builds

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18640 ) Change subject: contrib/osmo-msc.spec.in: Enable SMPP in RPM builds .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions

2020-06-03 Thread neels
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18506 to look at the new patch set (#5). Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions

Change in osmo-bsc[master]: cosmetic: tweak rc type of is_cm_service_for_emerg()

2020-06-03 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18647 ) Change subject: cosmetic: tweak rc type of is_cm_service_for_emerg() .. cosmetic: tweak rc type of is_cm_service_for_emerg()

Change in osmo-bsc[master]: gsm0408_test.c: drop test_mi_functionality()

2020-06-03 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18648 ) Change subject: gsm0408_test.c: drop test_mi_functionality() .. gsm0408_test.c: drop test_mi_functionality() Testing these functions

Change in osmo-bsc[master]: refactor bsc_find_msc()'s round-robin

2020-06-03 Thread neels
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18505 to look at the new patch set (#4). Change subject: refactor bsc_find_msc()'s round-robin ..

Change in osmo-pcu[master]: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request

2020-06-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18387 ) Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request .. BTS::parse_rach_ind(): properly handle EGPRS Packet

Change in libosmo-netif[master]: src/stream.c: Don't leak socket during SCTP_EVENTS getsockopt

2020-06-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18639 ) Change subject: src/stream.c: Don't leak socket during SCTP_EVENTS getsockopt .. src/stream.c: Don't leak socket during SCTP_EVENTS

Change in osmo-mgw[master]: trunk: get rid of virt_trunk pointer

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18590 ) Change subject: trunk: get rid of virt_trunk pointer .. Patch Set 5: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: CTRL: determine MSC connection status from RESET-ACK, not AS_ACTIVE

2020-06-03 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18501 ) Change subject: CTRL: determine MSC connection status from RESET-ACK, not AS_ACTIVE .. CTRL: determine MSC connection status from RESET-ACK,

Change in osmo-bsc[master]: create only one SCCP user per SCCP instance

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18504 ) Change subject: create only one SCCP user per SCCP instance .. Patch Set 4: Code-Review+2 combining votes -- To view, visit

Change in pysim[master]: Add support for ADF_USIM/EF_EHPLMN

2020-06-03 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/18649 ) Change subject: Add support for ADF_USIM/EF_EHPLMN .. Add support for ADF_USIM/EF_EHPLMN If the EF.EHPLMN exists, it contains the

Change in osmo-bsc[master]: cosmetic: tweak rc type of is_cm_service_for_emerg()

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18647 ) Change subject: cosmetic: tweak rc type of is_cm_service_for_emerg() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: gsm0408_test.c: drop test_mi_functionality()

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18648 ) Change subject: gsm0408_test.c: drop test_mi_functionality() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions

2020-06-03 Thread neels
neels has restored this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. Restored -- To view, visit

Change in libosmocore[master]: gsm23236: add NRI range utility functions

2020-06-03 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18540 ) Change subject: gsm23236: add NRI range utility functions .. Abandoned merged into the other gsm23236 patch (was too much work keeping them

Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. Patch Set 4: copying review from the other patch that

Change in osmo-msc[master]: vlr_subscr_rx_id_resp(): dont assert on received MI type

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18635 ) Change subject: vlr_subscr_rx_id_resp(): dont assert on received MI type .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: refactor bsc_find_msc()'s round-robin

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18505 ) Change subject: refactor bsc_find_msc()'s round-robin .. Patch Set 4: I'm still asking why aren't you making use of linked list by

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18633 ) Change subject: BTS_Tests: fix f_init_rsl(): expect all 4 transceivers to connect .. Patch Set 3: Code-Review-1 I have been

Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions

2020-06-03 Thread neels
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18506 to look at the new patch set (#4). Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions

Change in osmo-msc[master]: vlr_subscr_rx_id_resp(): dont assert on received MI type

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18635 ) Change subject: vlr_subscr_rx_id_resp(): dont assert on received MI type .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: manual: link to new common cs7-config.adoc, remove some dup of that

2020-06-03 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17580 ) Change subject: manual: link to new common cs7-config.adoc, remove some dup of that .. manual: link to new common cs7-config.adoc, remove

Change in osmo-msc[master]: manual: link to new common cs7-config.adoc, remove some dup of that

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17580 ) Change subject: manual: link to new common cs7-config.adoc, remove some dup of that .. Patch Set 2: Code-Review+2 -- To view,

Change in osmo-mgw[master]: osmo-mgw: rename struct mgcp_trunk_config and symbol tcfg

2020-06-03 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18643 ) Change subject: osmo-mgw: rename struct mgcp_trunk_config and symbol tcfg .. osmo-mgw: rename struct mgcp_trunk_config and symbol

Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling

2020-06-03 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18372 ) Change subject: osmo-mgw: refactor endpoint and trunk handling .. Patch Set 7: (21 comments) @neels: Thanks for commenting on this

Change in osmo-mgw[master]: mgcp_vty: fix indentation in VTY config write

2020-06-03 Thread dexter
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18593 to look at the new patch set (#3). Change subject: mgcp_vty: fix indentation in VTY config write

Change in osmo-mgw[master]: mgcp_trunk: remove audio_name and audio_payloa

2020-06-03 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18645 ) Change subject: mgcp_trunk: remove audio_name and audio_payloa .. mgcp_trunk: remove audio_name and audio_payloa get rid of

Change in osmo-mgw[master]: trunk: get rid of virt_trunk pointer

2020-06-03 Thread dexter
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18590 to look at the new patch set (#5). Change subject: trunk: get rid of virt_trunk pointer ..

Change in pysim[master]: commands.py: fix read_binary for lengths > 256

2020-06-03 Thread gui...@gmail.com
gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17848 ) Change subject: commands.py: fix read_binary for lengths > 256 .. Patch Set 8: can this be merged please? I am struggling

Change in osmo-mgw[master]: mgcp_trunk: remove audio_name and audio_payloa

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18645 ) Change subject: mgcp_trunk: remove audio_name and audio_payloa .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: create only one SCCP user per SCCP instance

2020-06-03 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18504 ) Change subject: create only one SCCP user per SCCP instance .. create only one SCCP user per SCCP instance Depends:

Change in osmo-msc[master]: vlr_subscr_rx_id_resp(): dont assert on received MI type

2020-06-03 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18635 ) Change subject: vlr_subscr_rx_id_resp(): dont assert on received MI type .. vlr_subscr_rx_id_resp(): dont assert on received MI type The Mobile

Change in osmo-bsc[master]: cosmetic: tweak rc type of is_cm_service_for_emerg()

2020-06-03 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18647 ) Change subject: cosmetic: tweak rc type of is_cm_service_for_emerg() .. cosmetic: tweak rc type of is_cm_service_for_emerg() Change-Id:

Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions

2020-06-03 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. Abandoned merged with the other gsm23236 patch -- To view,

Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. Patch Set 4: > one *could* (not saying you must if

Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. Patch Set 5: (I changed the order of the functions in

Change in osmo-bsc[master]: create only one SCCP user per SCCP instance

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18504 ) Change subject: create only one SCCP user per SCCP instance .. Patch Set 4: ah, actually didn't check that. Looking now, we don't

Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds

2020-06-03 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 ) Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds .. Patch Set 6: (1 comment)

Change in osmo-msc[master]: contrib/osmo-msc.spec.in: Enable SMPP in RPM builds

2020-06-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18640 ) Change subject: contrib/osmo-msc.spec.in: Enable SMPP in RPM builds .. Patch Set 1: Code-Review+1 -- To view, visit

Change in pysim[master]: commands.py: fix read_binary for lengths > 256

2020-06-03 Thread gui...@gmail.com
gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17848 ) Change subject: commands.py: fix read_binary for lengths > 256 .. Patch Set 8: > Patch Set 8: > > > Patch Set 8: > > > > can

Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds

2020-06-03 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 ) Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds .. Patch Set 6: Code-Review+1 (1 comment)

Change in osmocom-bb[master]: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds

2020-06-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18641 ) Change subject: fake_trx: Support SETPOWER and NOMTXPOWER TRXC cmds .. Patch Set 6: (1 comment)

Change in osmo-bsc[master]: gsm0408_test.c: drop test_mi_functionality()

2020-06-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18648 ) Change subject: gsm0408_test.c: drop test_mi_functionality() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in pysim[master]: commands.py: fix read_binary for lengths > 256

2020-06-03 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17848 ) Change subject: commands.py: fix read_binary for lengths > 256 .. Patch Set 8: > I got a couple of SIMs with the PLMN lists with 300

Change in libosmocore[master]: add osmo_mobile_identity API

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18507 ) Change subject: add osmo_mobile_identity API .. Patch Set 5: This change is ready for review. -- To view, visit

Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64

2020-06-03 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of

Change in pysim[master]: commands.py: fix read_binary for lengths > 256

2020-06-03 Thread herlesupreeth
herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17848 ) Change subject: commands.py: fix read_binary for lengths > 256 .. Patch Set 8: > Patch Set 8: > > > I got a couple of SIMs with

Change in osmo-bsc[master]: refactor bsc_find_msc()'s round-robin

2020-06-03 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18505 ) Change subject: refactor bsc_find_msc()'s round-robin .. Patch Set 4: > Patch Set 4: > > I'm still asking why aren't you making use

Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007

2020-06-03 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 .. Implement Generic SIM Access interface as per 3GPP TS

Change in pysim[master]: ts_31_102.py: add EF_ADF_map

2020-06-03 Thread herlesupreeth
herlesupreeth has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/18564 ) Change subject: ts_31_102.py: add EF_ADF_map .. ts_31_102.py: add EF_ADF_map the EF files in the USIM ADF are different to the ones int

  1   2   >