Re: [Gimp-developer] soc-2006-healing-brush branch merged and closed
Hi Sven, Regarding your questions: Of course optimizing the Laplacion solver is still desirable. Have you done any profiling on this yet? Is there a way to benchmark it? A regression test would also be nice to have for this purpose. At the moment I haven't done any profiling. I haven't thought of any benchmarking except for total time spent. The inner loop runs until convergence so we may have to change that to run for a specific number of times for profiling purposes. Kevin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] healing brush hanging X11
Hi Sven, I haven't had any time to try this. I depart this Saturday and don't anticipate having more time to devote to the healing brush in the near future. Once I get settled I'll set up a work environment and try and work on the code some more. Kevin On 9/13/06, Sven Neumann [EMAIL PROTECTED] wrote: Hi Kevin,a while ago we discussed how to change the heal tool so that it doesn'tdo it's time-expensive calculations while the user is painting but to delay it until after the mouse has been released. Have you tried tochange the code in this direction? Do you need more help with this?Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] soc-2006-healing-brush branch merged and closed
Hi!I'm really glad the the Healing Brush has been merged into HEAD. That marks my first open-source contribution! (1) It would be nice if Jimmac could have a look at redoing the icon. Ivery much like the metaphor but the icon would benefit from some Tangolove applied to it.Yes. Please fix the icon. This was just something I did in a few spare minutes, and I am definitely not an icon expert. (3) I frequently get error messages saying Source and destinationregions are not the same size.. That shouldn't happen. The source and destination region should be the same size, but I don't know how to ensure this for every click. Right now the best I could do is not report the error and just run the loop again. I'll look into it though (4) I don't really understand how to use the tool. I understand that Ineed to Ctrl-Click to select a source as with the Clone tool. But then, when I try to heal an area, I find the behaviour unpredictable andsomehwat erratic. Can someone please explain how this tool is supposedto be used?I created a tutorial about the tool. Is there any GIMP hosted site where I could post it to for everyone to look at. This should answer most of your questions. Kevin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] [Gimp Developer] Healing Brush CVS
Hello everyone,The healing brush is now available on GIMP CVS. Its in the soc-2006-healing-brush branch. Please test it out and report any bugs, faults, compliments, etc.Right now one of the remaining issues is implementing support for Sample merged ( i.e., healing using a projection). If you have any comments on that let me know.Thanks,Kevin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] [PATCH] SoC: Healing brush
Hello everyone,I recently finished an implementation of the healing brush. A patch implementing the brush is given at http://bugzilla.gnome.org/show_bug.cgi?id=109801#c11 but does not contain the icon and cursor that I created for the tool.I have also posted some screen shots of the results of the tool at: http://picasaweb.google.com/kevin.sookocheff/HealingBrushExamplesI just tried the brush on some example images I found on the web.At this point there are a few things I'd like to do, but I'm not sure how to go about doing them. TODO:(1) Allow the source healing point to be taken from a separate image. I tried implementing this by referencing the clone tool implementation, but got stuck on it. At this point I want to get the tool into CVS and get some feedback, so I'll work on this incrementally from here. (2) The brush does not work for indexed images. I'm not sure how to fix this, but I haven't given it too much thought at this point.(3) Further integration as a GIMP tool. There are a lot of points in the code where the new tool should be integrated ( i.e., app/gimpcore.def). I tried to do some of these things myself but quickly got overwhelmed, and was a bit worried that I would inadvertetently break something. If someone could guide me through these steps that would be great. So, I'd like to get this tool checked into CVS, but first I'm asking permission to do that :) I have commit access to CVS so if someone gives the go-ahead, please guide me in how to make a branch and commit the code. I hope that everyone likes the tool and is able to test it out for me.Thanks,Kevin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [PATCH] SoC: Healing brush
Hello, Shouldn't the healing tool be derived from GimpCloneTool? It seems to besimilar enough. Perhaps you need to add a virtual function or two to the clone tool. But then it should be possible to share most of the code byderiving from it. I think there is a possibility to do this and that it should be at least discussed. The idea was presented before but it was decided that just getting a working implementation going is important enough for now. But now that a working implementation is here, we can try and come up with something. Another idea that was floated earlier mentioned that a GimpFromSourceTool (something that acts on data aquired from aCTRL-click source)could act as a super-class to the clone tool and healing brush, and handle any further, similar tools. However, this approach would most likely be more difficult than deriving the healing brush from the clone tool. What are the other points where it would need to be integrated. I'm not sure. I don't know the source code well enough to know this. I just grepped for references to other tools and there are a lot of references to other tools where I don't reference the healing brush. I don't know if this is an issue, or if it affects other places in GIMP. It could be fine how it is, but like I said, I don't know the code well enough. We first need to decide if we still want to accept this new tool for the2.4 release. Otherwise it would have to be committed to a branch and merged into HEAD after the stable release is done. OK. I think that it could be included in the next release with a little fine tuning. One work constraint that I have is that I will be moving to Kenya on Sept. 16th to start an internship. So, starting on Sept. 1st I won't be contributing much to the code until I get settled in the new environment. I will be active on the mailing list though. Cheers! Kevin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] Summer of Code
Hi everyone, I'm a student who is finishing a master's degree in computer science with a thesis on image processing. A little more specifically I do texture analysis and texture synthesis. Anyways, I noticed that GIMP is a mentoring organization for Google's Summer of Code for 2006. I'll be completing my degree by the time the coding portion of the program begins and so I can work full-time on a project for most of the summer. This will give me some more practical working experience over the summer and hopefully be a lot of fun. I've been wanting to gain experience with open source programming and the ability to have a mentor for the work is very appealing to me. I've applied to the program to work on the Save for the Web plug-in and the Healing Brush. The Healing Brush in particular is interesting to me and is quite related to the work that I'm already familiar with when I did my Master's thesis. If anyone has any other suggestions for projects I'm very open to them, or if anyone wanted to know more about me to aid in the sponsorship decision please ask (my resume is at www.cs.usask.ca/grads/kbs464/resume.pdf ) Thanks a bunch for your time, Kevin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
