Re: [Gimp-developer] Code cleanup in unsharp-mask.c and possible speed enhancement

2009-01-17 Thread Sven Neumann
Hi, On Thu, 2009-01-15 at 18:19 -0600, Winston Chang wrote: > OK - I'll submit the patches via bugzilla, then. Yes, please do that. It would be very nice if we could speed up the unsharp-mask plug-in for GIMP 2.8. Its slowness is quite often mentioned in GIMP reviews and it makes GIMP look badly

Re: [Gimp-developer] Code cleanup in unsharp-mask.c and possible speed enhancement

2009-01-15 Thread Winston Chang
> > > Hi! > > > > I want to mention that since we are in the progress of migrating to GEGL > > we generally prefer that people make sure the GEGL counterpart works > > well rather than maintaining the legacy 8 bpc code. A patch for GEGL is > > much more attractive than a patch for an old GIMP plug-

Re: [Gimp-developer] Code cleanup in unsharp-mask.c and possible speed enhancement

2009-01-15 Thread Michael Natterer
On Thu, 2009-01-15 at 08:43 +0100, Martin Nordholts wrote: > Winston Chang wrote: > > I took a look at the svn history of unsharp-mask.c (I'm the original > > author) and saw that the fix for bug #166406 stopped using a lookup > > table called ctable. This was because it slowed things down a lot fo

Re: [Gimp-developer] Code cleanup in unsharp-mask.c and possible speed enhancement

2009-01-15 Thread Martin Nordholts
Winston Chang wrote: > Dang. I wish I knew that before I coded up the box blur... > > Does this mean that I would have to code up a new plugin from scratch, > or is there a GEGL version of it out there already? (Sorry, I'm > totally unfamiliar with this GEGL stuff.) Gegl has a "gegl:unsharp-mask"

Re: [Gimp-developer] Code cleanup in unsharp-mask.c and possible speed enhancement

2009-01-14 Thread Winston Chang
Dang. I wish I knew that before I coded up the box blur... Does this mean that I would have to code up a new plugin from scratch, or is there a GEGL version of it out there already? (Sorry, I'm totally unfamiliar with this GEGL stuff.) -Winston On Thu, Jan 15, 2009 at 1:43 AM, Martin Nordholts

Re: [Gimp-developer] Code cleanup in unsharp-mask.c and possible speed enhancement

2009-01-14 Thread Martin Nordholts
Winston Chang wrote: > I took a look at the svn history of unsharp-mask.c (I'm the original > author) and saw that the fix for bug #166406 stopped using a lookup > table called ctable. This was because it slowed things down a lot for > large values of radius, due to cache overloading. > http://bugz

Re: [Gimp-developer] Code cleanup in unsharp-mask.c and possible speed enhancement

2009-01-14 Thread Winston Chang
> > Also, I've read recently that a three-pass box blur is close to a true > gaussian blur (within 3% when std_dev>2.0) so I'm considering implementing > that for the unsharp mask. It should be much faster while still looking very > good. > > More info on the 3-pass box blur here: > http://www.w3.o