Re: [Gimp-developer] Gimp (current svn) crop tool
Guys, the fixed ratio/width/height/size functionality is optimised for applying that constraint many times over a period of time (all day long). You set it up, then you use it for a while. If you quickly want to set the width/height/size of the bounding rectangle then there are the width and height fields, that is what they are there for. --ps principal user interaction architect man + machine interface works http://mmiworks.net/blog : on interaction architecture ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Gimp (current svn) crop tool
On Tue, 2007-08-21 at 08:34 +0200, Martin Nordholts wrote: > It seems to me as if you describe Fixed: Size simply as a facility to > lock the current size. That was the case before I started to implement > guiguru's rectangle tools spec [1], but it's not the case anymore, so > your argumentation is somewhat "out of date" (or I have misunderstood it). I was trying to explain what I saw as the original poster's comment. Sorry if I didn't make that clear. However, with latest svn it's still frustrating: (1) open a medium-sized image, e.g. 1000x3000 pixels (2) press C to choose crop tool, and drag out a rectangle of (say) several hundred pixels on a side (3) in tool options, check Fixed (4) next to Fixed, choose Size from the pulldown (5) the numbers 100x100 appear, and the Width and Height fields are (extremely annoyingly) greyed out so you can't copy and paste the numbers. (6) if you try and move the rectangle now you've got it to the size you wanted, it will spring to 100x100. Start over. Liam > [1] http://gui.gimp.org/index.php/Selection_%2B_crop_tool_specification -- Liam Quin - XML Activity Lead, W3C, http://www.w3.org/People/Quin/ Pictures from old books: http://fromoldbooks.org/ Ankh: irc.sorcery.net irc.gnome.org www.advogato.org ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Gimp (current svn) crop tool
Liam R E Quin wrote: > On Tue, 2007-08-21 at 08:34 +0200, Martin Nordholts wrote: > However, with latest svn it's still frustrating: > (1) open a medium-sized image, e.g. 1000x3000 pixels > (2) press C to choose crop tool, and drag out a rectangle of > (say) several hundred pixels on a side > (3) in tool options, check Fixed > (4) next to Fixed, choose Size from the pulldown > (5) the numbers 100x100 appear, and the Width and Height > fields are (extremely annoyingly) greyed out so you can't > copy and paste the numbers. > (6) if you try and move the rectangle now you've got it to > the size you wanted, it will spring to 100x100. Start over. > > Liam Well, you could just uncheck Fixed: Size and do the copy-pasting. Moving the rectangle should indeed not change size of the rectangle, so that is a bug. Will be fixed. - Martin Nordholts ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Gimp (current svn) crop tool
Liam R E Quin wrote: >> It would be easy to update Fixed: Size however, since that uses the same >> widget as Fixed: Aspect ratio, so I'm still curious about what you mean >> with "crop zone" > > I think it's fairly clear (although maybe I'm out to breakfast)... > when you clidck on Fixed Size, the size (width + height fields) > could be filled in from the current size of the crop preview > rectangle, if there is one. Sounds to me as if you need to svn up and rebuild :) Fixed size is no longer specified using separate Width and Height entries, instead, a so called GimpNumberPairEntry is used. It seems to me as if you describe Fixed: Size simply as a facility to lock the current size. That was the case before I started to implement guiguru's rectangle tools spec [1], but it's not the case anymore, so your argumentation is somewhat "out of date" (or I have misunderstood it). > There are some UI problems with this though. > If I enter a width and height and then click fixed size, > the crop rectangle preview probably needs to change, not > the numbers I entered. So the dialogue would need to > keep track of whether I had entered values into width > and/or heigher since the state of Fixed Size was last > changed, and retain those if so. I think? For handling Fixed: Width/Height, what the spec says makes most sense imo. Thew new GimpNumberPairEntry widget has what you are asking for, a "user override mode", and a "default values mode", please refer to spec for details. The problem is that the Fixed: Width/Height entry widgets do not have that functionality yet, and there lies the problem. - Martin Nordholts [1] http://gui.gimp.org/index.php/Selection_%2B_crop_tool_specification ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Gimp (current svn) crop tool
> It would be easy to update Fixed: Size however, since that uses the same > widget as Fixed: Aspect ratio, so I'm still curious about what you mean > with "crop zone" I think it's fairly clear (although maybe I'm out to breakfast)... when you clidck on Fixed Size, the size (width + height fields) could be filled in from the current size of the crop preview rectangle, if there is one. There are some UI problems with this though. If I enter a width and height and then click fixed size, the crop rectangle preview probably needs to change, not the numbers I entered. So the dialogue would need to keep track of whether I had entered values into width and/or heigher since the state of Fixed Size was last changed, and retain those if so. I think? Liam -- Liam Quin - XML Activity Lead, W3C, http://www.w3.org/People/Quin/ Pictures from old books: http://fromoldbooks.org/ Ankh: irc.sorcery.net irc.gnome.org www.advogato.org ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Gimp (current svn) crop tool
Martin Nordholts wrote: > Updating the Fixed: Width/Height entries would be nice indeed, and I > plan to fix this before 2.4, I just haven't found the time to do so yet. > Since I have already written the surrounding code, fixing this should go > fairly quick. Crap, just recalled why this isn't still done; the entry widgets used for Fixed: Width/Height is not the same as for Fixed: Aspect ratio/Size, and does not support a user-override mode, so you will unfortunately have to wait for 2.6 for automatically updated Fixed: Width/Height entries. It would be easy to update Fixed: Size however, since that uses the same widget as Fixed: Aspect ratio, so I'm still curious about what you mean with "crop zone" - Martin Nordholts ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Gimp (current svn) crop tool
Laurent MONIN wrote: > Hello, > > the "fixed" option of the crop tool is far better now, aspect ratio is > nicely working, thank you very much for what you did. > > I noted few things (that you may already know): > - in some cases, there are spurious lines drawn when defining the crop zone. > - Fixed Aspect Ratio reports width:height which is great, but when changing > to Fixed Width or Fixed Height, the value is set to 100, it would be more > useful if it stayed on the previous width or height value. > Fixed Size should be the one of the current crop zone, not 100x100 Thanks Laurent Yup, bug 467972 (http://bugzilla.gnome.org/show_bug.cgi?id=467972) is the highlight artifacts bug. Updating the Fixed: Width/Height entries would be nice indeed, and I plan to fix this before 2.4, I just haven't found the time to do so yet. Since I have already written the surrounding code, fixing this should go fairly quick. I'm not sure what to put for Fixed: Size though, and the spec simply states 100x100 "but are open for improvments". "Crop zone" sounds interesting, what do you mean by that? - Martin Nordholts ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
