Re: ValueIndexed OutEdgeMap

2011-09-13 Thread Jake Mannix
On Tue, Sep 13, 2011 at 4:44 PM, Claudio Martella < claudio.marte...@gmail.com> wrote: > Oh, misunderstanding. My code (github's I guess) and the javadoc on > the apache site showed BasicVertex as an interface. Now everything > makes sense. > BasicVertex was an interface until Sunday night, I thi

Re: ValueIndexed OutEdgeMap

2011-09-13 Thread Claudio Martella
Oh, misunderstanding. My code (github's I guess) and the javadoc on the apache site showed BasicVertex as an interface. Now everything makes sense. Thanks for the feedback, made my day! On Wed, Sep 14, 2011 at 1:01 AM, Jake Mannix wrote: > > On Tue, Sep 13, 2011 at 3:34 PM, Claudio Martella > w

Re: ValueIndexed OutEdgeMap

2011-09-13 Thread Jake Mannix
On Tue, Sep 13, 2011 at 3:34 PM, Claudio Martella < claudio.marte...@gmail.com> wrote: > ok, i understand. you suggest i IMPLEMENT BasicVertex and encapsulate > Vertex. This sounds like a possibility. Still I think there should be > an implementation without final addEdge (as the rest isn't final)

Re: ValueIndexed OutEdgeMap

2011-09-13 Thread Claudio Martella
ok, i understand. you suggest i IMPLEMENT BasicVertex and encapsulate Vertex. This sounds like a possibility. Still I think there should be an implementation without final addEdge (as the rest isn't final). On Tue, Sep 13, 2011 at 6:31 PM, Jake Mannix wrote: > Claudio, >   If your vertex class ha

Re: ValueIndexed OutEdgeMap

2011-09-13 Thread Jake Mannix
I actually think the name should be reversed: everything "is a Vertex", so that should be the base abstract class, and BasicVertex (or SimpleVertex) should maybe be the name of "the simplest generic implementation" - ie what is now called Vertex. And yes, then document clearly when you should subc

Re: ValueIndexed OutEdgeMap

2011-09-13 Thread Dmitriy Ryaboy
We should add that to Vertex's javadoc... On Tue, Sep 13, 2011 at 9:31 AM, Jake Mannix wrote: > Claudio, > > If your vertex class has special internal data structures, what you'll > want to do is subclass either BasicVertex, or MutableVertex, not Vertex. > And then yes, add a "getEdgesByValue

Re: ValueIndexed OutEdgeMap

2011-09-13 Thread Jake Mannix
Claudio, If your vertex class has special internal data structures, what you'll want to do is subclass either BasicVertex, or MutableVertex, not Vertex. And then yes, add a "getEdgesByValue()" or whatever to that class. -jake On Tue, Sep 13, 2011 at 8:22 AM, Claudio Martella < claudio.marte

Re: ValueIndexed OutEdgeMap

2011-09-13 Thread Claudio Martella
Hi Jake, thanks for the feedback. I checked out the patch, but it looks like it's changing just the "read" access visibility. How could I provide a "value"-indexed internal datastructure according to the new api? the new addEdge is stil final. I can add my own "getEdgesByValue()" (as I might have

Re: ValueIndexed OutEdgeMap

2011-09-13 Thread Jake Mannix
Hi Claudio, So what you want is to be able to build up your own application-specific data structure for the outbound edges of a vertex (in your case, one that effectively supports fulltext search on the edge values)? Check out: https://issues.apache.org/jira/browse/GIRAPH-31 - this change, if

ValueIndexed OutEdgeMap

2011-09-13 Thread Claudio Martella
Hello list, I'm currently implementing large scale path traversals over an RDF graph. the traversals are defined by the starting vertex and a set of edge labels that have to be traversed, if possible, to obtain all the wanted paths. In my current scenario the vertexID is Text, and the Edge is as