Re: Bizarre problem cloning repo from Codeplex

2012-11-11 Thread Andreas Schwab
Enrico Weigelt writes: >> > Their webserver seems to be configured quite restrictively >> > (eg. cannot access files like 'packed-refs'). >> >> Probably it just doesn't exist. > > Aren' these files requied ? No. If you've never run git pack-refs it's never created. Andreas. -- Andreas Schwa

[PATCH v3 4/5] push: flag updates that require force

2012-11-11 Thread Chris Rorvick
Add a flag for indicating an update to a reference requires force. Currently the nonfastforward flag of a ref is used for this when generating status the status message. A separate flag insulates the status logic from the details of set_ref_status_for_push(). Signed-off-by: Chris Rorvick --- ca

[PATCH v3 5/5] push: update remote tags only with force

2012-11-11 Thread Chris Rorvick
References are allowed to update from one commit-ish to another if the former is a ancestor of the latter. This behavior is oriented to branches which are expected to move with commits. Tag references are expected to be static in a repository, though, thus an update to a tag (lightweight and anno

[PATCH v3 3/5] push: flag updates

2012-11-11 Thread Chris Rorvick
If the reference exists on the remote and the the update is not a delete, then mark as an update. This is in preparation for handling tags and branches differently when pushing. Signed-off-by: Chris Rorvick --- cache.h | 1 + remote.c | 18 +++--- 2 files changed, 12 insertions(+)

[PATCH v3 2/5] push: add advice for rejected tag reference

2012-11-11 Thread Chris Rorvick
Advising the user to fetch and merge only makes sense if the rejected reference is a branch. If none of the rejections were for branches, tell the user they need to force the update(s). Signed-off-by: Chris Rorvick --- builtin/push.c | 16 ++-- cache.h| 1 + remote.c

[PATCH v3 1/5] push: return reject reasons via a mask

2012-11-11 Thread Chris Rorvick
Pass all rejection reasons back from transport_push(). The logic is simpler and more flexible with regard to providing useful feedback. Signed-off-by: Chris Rorvick --- builtin/push.c | 13 - builtin/send-pack.c | 4 ++-- transport.c | 17 - transport.h

[PATCH v3 0/5] push: update remote tags only with force

2012-11-11 Thread Chris Rorvick
Minor changes since from v2 set. Reposting primarily because I mucked up the Cc: list (again) and hoping to route feedback to the appropriate audience. This patch set can be divided into two sets: 1. Provide useful advice for rejected tag references. push: return reject reasons via a mas

Re: Thanking the interim maintainer

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 07:12:26PM -0800, Junio C Hamano wrote: > I am physically back but still am far from catching up with the list > traffic (yet). After skimming my inbox, it appears that you have > done a magnificent job keeping track of topics in flight and merging > low-risk fixes early t

Thanking the interim maintainer

2012-11-11 Thread Junio C Hamano
I am physically back but still am far from catching up with the list traffic (yet). After skimming my inbox, it appears that you have done a magnificent job keeping track of topics in flight and merging low-risk fixes early to the 'master' branch. I am hoping that I can ask you to do another issu

Re: Bizarre problem cloning repo from Codeplex

2012-11-11 Thread Enrico Weigelt
> > Their webserver seems to be configured quite restrictively > > (eg. cannot access files like 'packed-refs'). > > Probably it just doesn't exist. Aren' these files requied ? cu -- Mit freundlichen Grüßen / Kind regards Enrico Weigelt VNC - Virtual Network Consult GmbH Head Of Developmen

Re: Reviews on mailing-list

2012-11-11 Thread David Lang
On Sun, 11 Nov 2012, Deniz Türkoglu wrote: I understand from the feedback that gerrit should get better on making it possible to review code via e-mail, as pointed out in Nguyen's mail, a flow like Shawn mentioned[1] can be a good solution. FWIW, I can fetch the change(s) from gerrit I am inter

Re: Reviews on mailing-list

2012-11-11 Thread Deniz Türkoglu
I understand from the feedback that gerrit should get better on making it possible to review code via e-mail, as pointed out in Nguyen's mail, a flow like Shawn mentioned[1] can be a good solution. FWIW, I can fetch the change(s) from gerrit I am interested in and review it any time I want. I curr

[PATCH] Update cygwin.c for new mingw-64 win32 api headers

2012-11-11 Thread Mark Levedahl
The cygwin project recently switched to a new implementation of the windows api, now using header files from the mingw-64 project. These new header files are incompatible with the way cygwin.c included the old headers: cygwin.c can be compiled using the new or the older (mingw) headers, but differe

Re: [msysGit] Re: [PATCH] git tag --contains : avoid stack overflow

2012-11-11 Thread Johannes Schindelin
Hi, On Sun, 11 Nov 2012, Jeff King wrote: > On Sun, Nov 11, 2012 at 05:46:32PM +0100, René Scharfe wrote: > > > >However, I couldn't reproduce it on Linux : where the windows > > >implementations crashes at a ~32000 depth (*not* exactly 32768, mind > > >you), on linux it happily went through 100

[RFC PATCH 1/1] status: Allow for short-form via config option

2012-11-11 Thread Thomas Adam
It is currently not possible to use the short-form output of git status without declaring an alias to do so. This isn't always desirable therfore, define a git config option which can be set to display the short-form: status.shortwithbranch Signed-off-by: Thomas Adam --- builtin/commit.c | 12

[RFC PATCH 0/1] status: Allow for short-form output by default

2012-11-11 Thread Thomas Adam
Hi, It was asked recently whether git status could output the short-form instead of the long output (via its "-sb" options). To that end, I've created a rough POC on how this might look. It's deliberately lacking documentation; I was curious to know whether: status.shortwithbranch = true Was g

[PATCH] git p4: handle servers without move support

2012-11-11 Thread Pete Wyckoff
Support for the "p4 move" command was added in 8e9497c (git p4: add support for 'p4 move' in P4Submit, 2012-07-12), which checks to make sure the client and server support the command. But older versions of p4d may not handle the "-k" argument, and newer p4d allow disabling "p4 move" with a config

Re: [PATCH v5 00/14] New remote-hg helper

2012-11-11 Thread Chris Webb
Felipe Contreras writes: > Implemented now. I'm not handling the 'tip' revision, but most likely > it's also the '.' revision. In this case a fake 'master' bookmark will > be created to track that revision. Hi Felipe. Sorry for the slow response, I've been snowed under with work and have only ju

Re: [PATCH 0/5] ignore SIGINT while editor runs

2012-11-11 Thread Andreas Schwab
Krzysztof Mazur writes: > That's why I'm proposing in case of SIGQUIT just killing the editor > (SIGTERM is sufficient for ed). > > So git will ignore SIGINT, but die on SIGQUIT (and kill editor > that ignores SIGQUIT). system(3) also ignores SIGQUIT. Andreas. -- Andreas Schwab, sch...@linux-

Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 9:49 PM, Max Horn wrote: > > On 11.11.2012, at 14:59, Felipe Contreras wrote: > >> People seeking for reference would find it useful. > > Hm, I don't understand this commit message. Probably means I am j git > fast-export --use-done-featureust too dumb, but since I am one

Re: Reviews on mailing-list

2012-11-11 Thread David Lang
On Sun, 11 Nov 2012, Krzysztof Mazur wrote: On Sun, Nov 11, 2012 at 11:09:36AM -0200, Thiago Farina wrote: On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras wrote: Requiring everyone to use a web browser would limit the amount of ways people can review patches. I don't see that as a limitat

Re: [PATCH v5 14/15] fast-export: make sure updated refs get updated

2012-11-11 Thread Max Horn
On 11.11.2012, at 14:59, Felipe Contreras wrote: > When an object has already been exported (and thus is in the marks) it's > flagged as SHOWN, so it will not be exported again, even if in a later > time it's exported through a different ref. > > We don't need the object to be exported again, bu

Re: [PATCH v5 02/15] remote-testgit: fix direction of marks

2012-11-11 Thread Max Horn
On 11.11.2012, at 14:59, Felipe Contreras wrote: > Basically this is what we want: > > == pull == > > testgit transport-helper > > * export -> import > > # testgit.marks git.marks > > == push == > > testgit transp

Re: [PATCH v5 05/15] Add new simplified git-remote-testgit

2012-11-11 Thread Max Horn
On 11.11.2012, at 14:59, Felipe Contreras wrote: > It's way simpler. It exerceises the same features of remote helpers. Typo: exerceises => exercises Cheers, Max -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature

2012-11-11 Thread Max Horn
On 11.11.2012, at 14:59, Felipe Contreras wrote: > People seeking for reference would find it useful. Hm, I don't understand this commit message. Probably means I am just too dumb, but since I am one of those people who would likely be seeking for reference, I would really appreciate if it cou

Re: [PATCH 0/5] ignore SIGINT while editor runs

2012-11-11 Thread Krzysztof Mazur
On Sun, Nov 11, 2012 at 03:24:19PM -0500, Paul Fox wrote: > krzysztof wrote: > > Looks ok, but what about SIGQUIT? Some editors like GNU ed (0.4 and 1.6) > > ignore SIGQUIT, and after SIGQUIT git dies, but editor is still running. > > After pressing any key ed receives -EIO and prints "stdin: In

Re: [PATCH 0/5] ignore SIGINT while editor runs

2012-11-11 Thread Paul Fox
krzysztof wrote: > On Sun, Nov 11, 2012 at 11:31:00AM -0500, Jeff King wrote: > > > > Here's a series that I think should resolve the situation for everybody. > > > > [1/5]: launch_editor: refactor to use start/finish_command > > > > The cleanup I sent out a few minutes ago. > > > >

Re: Test failures in contrib/remote-helpers

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 1:48 PM, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: >> On Sun, Nov 11, 2012 at 11:32 AM, Ramkumar Ramachandra >> wrote: >>> I'm experiencing test failures in contrib/remote-helpers. >> >> Which are your versions of hg, and bzr? > > Mercurial Distributed SCM (ver

Re: [PATCH 5/5] launch_editor: propagate SIGINT from editor to git

2012-11-11 Thread Johannes Sixt
Am 11.11.2012 17:57, schrieb Jeff King: > @@ -51,6 +51,8 @@ int launch_editor(const char *path, struct strbuf *buffer, > const char *const *en > sigchain_push(SIGINT, SIG_IGN); > ret = finish_command(&p); > sigchain_pop(SIGINT); > + if (WIFSIGN

Re: [PATCH 0/5] ignore SIGINT while editor runs

2012-11-11 Thread Krzysztof Mazur
On Sun, Nov 11, 2012 at 11:31:00AM -0500, Jeff King wrote: > > Here's a series that I think should resolve the situation for everybody. > > [1/5]: launch_editor: refactor to use start/finish_command > > The cleanup I sent out a few minutes ago. > > [2/5]: launch_editor: ignore SIGINT while

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 7:14 PM, Jeff King wrote: > On Sun, Nov 11, 2012 at 06:45:32PM +0100, Felipe Contreras wrote: > >> > If there is a standard filter, then what is the advantage in doing it as >> > a pipe? Why not just teach fast-import the same trick (and possibly make >> > it optional)? Tha

Re: Failure using webdav basic auth by git client

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 01:09:02PM -0500, Jason Pyeron wrote: > > My google fu has failed me on this issue. I am trying to setup http(s) > > repositories for git. If I require authenticated users then git asks > > for a username and password for the first volley of communications, but > > then doe

Re: [PATCH 0/5] ignore SIGINT while editor runs

2012-11-11 Thread Paul Fox
jeff wrote: > On Sun, Nov 11, 2012 at 10:48:46AM -0500, Jeff King wrote: > > > Silly me. When I thought through the impact of Paul's patch, I knew that > > we would notice signal death of the editor. But I totally forgot to > > consider that the blocked signal is inherited by the child proces

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-11 Thread A Large Angry SCM
On 11/11/2012 12:15 PM, Jeff King wrote: On Sun, Nov 11, 2012 at 12:00:44PM -0500, A Large Angry SCM wrote: a) Leave the name conversion to the export tools, and when they miss some weird corner case, like 'Author [...] b) Do the name conversion in fast-import itself, perhaps optionally, so if

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 06:45:32PM +0100, Felipe Contreras wrote: > > If there is a standard filter, then what is the advantage in doing it as > > a pipe? Why not just teach fast-import the same trick (and possibly make > > it optional)? That would be simpler, more efficient, and it would make > >

Re: [PATCH] Add new git-cc-cmd helper to contrib

2012-11-11 Thread Felipe Contreras
Hi, On Sun, Nov 11, 2012 at 6:18 PM, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: >> The code finds the changes in each commit in the list, runs 'git blame' >> to see which other commits are relevant to those lines, and then adds >> the author and signer to the list. >> >> Finally, it ca

RE: Failure using webdav basic auth by git client

2012-11-11 Thread Jason Pyeron
I had to munge the body so the list would post it. See: http://vger.kernel.org/majordomo-taboos.txt > -Original Message- > From: Pyeron, Jason J CTR (US) > Sent: Thursday, November 08, 2012 2:49 PM > To: git@vger.kernel.org > Subject: Failure using webdav basic auth by git client > > M

Re: [PATCH] send-email: add proper default sender

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 6:12 PM, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: >> I got really tired of 'git send-email' always asking me from which address >> to send mails... that's already configured. > > Use sendemail.from. The email sender doesn't necessarily have to be the > autho

Re: [PATCH v5 01/15] fast-export: avoid importing blob marks

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 5:36 PM, Torsten Bögershausen wrote: > On 11.11.12 14:59, Felipe Contreras wrote: >> test_expect_success 'test biridectionality' ' >> + echo -n > marks-cur && >> + echo -n > marks-new && > Unless I messed up the patch: > > Minor issue: still a typo "biridectionality

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 6:39 PM, A Large Angry SCM wrote: > On 11/11/2012 12:16 PM, Felipe Contreras wrote: >> And how do you propose to find the commit commands without parsing all >> the other commands? If you randomly look for lines that begin with >> 'commit /refs' you might end up in the mid

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 6:15 PM, Jeff King wrote: > On Sun, Nov 11, 2012 at 12:00:44PM -0500, A Large Angry SCM wrote: > If there is a standard filter, then what is the advantage in doing it as > a pipe? Why not just teach fast-import the same trick (and possibly make > it optional)? That would b

Re: What's cooking in git.git (Oct 2012, #09; Mon, 29)

2012-11-11 Thread Jeff King
On Sat, Nov 10, 2012 at 06:33:38PM +, Ramsay Jones wrote: > > We should probably wrap it. I'm planning to queue this on top of Chris's > > patch: > > Unfortunately, I haven't had time yet to test this patch. (Early this week, I > went into hospital for a "minor" surgical procedure - I have no

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-11 Thread A Large Angry SCM
On 11/11/2012 12:16 PM, Felipe Contreras wrote: On Sun, Nov 11, 2012 at 6:00 PM, A Large Angry SCM wrote: On 11/11/2012 07:41 AM, Felipe Contreras wrote: Such a filter would probably be quite complicated, and would decrease performance. Really? The fast import stream protocol is pretty si

Re: [PATCH] Add new git-cc-cmd helper to contrib

2012-11-11 Thread Ramkumar Ramachandra
Hi Felipe, Felipe Contreras wrote: > The code finds the changes in each commit in the list, runs 'git blame' > to see which other commits are relevant to those lines, and then adds > the author and signer to the list. > > Finally, it calculates what percentage of the total relevant commits > each

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 6:00 PM, A Large Angry SCM wrote: > On 11/11/2012 07:41 AM, Felipe Contreras wrote: >> Such a filter would probably be quite complicated, and would decrease >> performance. > > Really? > > The fast import stream protocol is pretty simple. All the filter really > needs to d

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 12:00:44PM -0500, A Large Angry SCM wrote: > >>>a) Leave the name conversion to the export tools, and when they miss > >>>some weird corner case, like 'Author >>>consequences, perhaps after an hour of the process. > [...] > >>>b) Do the name conversion in fast-import itself

Re: Reviews on mailing-list

2012-11-11 Thread Krzysztof Mazur
On Sun, Nov 11, 2012 at 11:09:36AM -0200, Thiago Farina wrote: > On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras > wrote: > > Requiring everyone to use a web browser would limit the amount of ways > > people can review patches. > I don't see that as a limitation as I think everyone has access t

[PATCH] Add new git-cc-cmd helper to contrib

2012-11-11 Thread Felipe Contreras
You can run it like format-patch: % git cc-cmd master..my-branch And you'll get relevant people to Cc. The code finds the changes in each commit in the list, runs 'git blame' to see which other commits are relevant to those lines, and then adds the author and signer to the list. Finally, it ca

[PATCH] send-email: add proper default sender

2012-11-11 Thread Felipe Contreras
There's no point in asking this over and over if the user already properly configured his/her name and email. Signed-off-by: Felipe Contreras --- I got really tired of 'git send-email' always asking me from which address to send mails... that's already configured. git-send-email.perl | 11 +++

[PATCH 2/2] send-email: add series-cc-cmd option

2012-11-11 Thread Felipe Contreras
cc-cmd is only per-file, and many times receipients get lost without seing the full patch series. So, add an option for series-cc-cmd, which receives as an argument rev-list options, just like format-patch. Signed-off-by: Felipe Contreras --- Documentation/git-send-email.txt | 7 +++

[PATCH 1/2] send-email: refactor recipients_cmd()

2012-11-11 Thread Felipe Contreras
If we pass the full command to run, we should be able to use it in more extensible ways--see next patch. Signed-off-by: Felipe Contreras --- git-send-email.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index aea66a0..26d447

[PATCH 0/2] send-email: new series-cc-cmd option

2012-11-11 Thread Felipe Contreras
cc-cmd is probably not that useful, what we really want is to make a list of people to Cc on a per-patch-series basis. This patch series allows just that. Felipe Contreras (2): send-email: refactor recipients_cmd() send-email: add series-cc-cmd option Documentation/git-send-email.txt

[PATCH 2/5] launch_editor: ignore SIGINT while the editor has control

2012-11-11 Thread Paul Fox
The user's editor likely catches SIGINT (ctrl-C). but if the user spawns a command from the editor and uses ctrl-C to kill that command, the SIGINT will likely also kill git itself (depending on the editor, this can leave the terminal in an unusable state). Signed-off-by: Paul Fox Signed-off-by:

Re: RFD: fast-import is picky with author names (and maybe it should - but how much so?)

2012-11-11 Thread A Large Angry SCM
On 11/11/2012 07:41 AM, Felipe Contreras wrote: On Sat, Nov 10, 2012 at 8:25 PM, A Large Angry SCM wrote: On 11/10/2012 01:43 PM, Felipe Contreras wrote: So, the options are: a) Leave the name conversion to the export tools, and when they miss some weird corner case, like 'Author c) Do the

[PATCH 3/3] submodule: display summary header in bold

2012-11-11 Thread Ramkumar Ramachandra
Currently, 'git diff --submodule' displays output with a bold diff header for non-submodules. So this part is in bold: diff --git a/file1 b/file1 index 30b2f6c..2638038 100644 --- a/file1 +++ b/file1 For submodules, the header looks like this: Submodule submodule1 012b072..2

[PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-11 Thread Ramkumar Ramachandra
Introduce a diff.submodule configuration variable corresponding to the '--submodule' command-line option of 'git diff'. Signed-off-by: Ramkumar Ramachandra --- Documentation/diff-config.txt|7 ++ Documentation/diff-options.txt |3 +- cache.h |1 + d

[PATCH v3 0/3] Introduce diff.submodule

2012-11-11 Thread Ramkumar Ramachandra
v1 is here: http://mid.gmane.org/1349196670-2844-1-git-send-email-artag...@gmail.com v2 is here: http://mid.gmane.org/1351766630-4837-1-git-send-email-artag...@gmail.com This version was prepared in response to Peff's review of v2. As suggested, I've created a separate function which both '--su

[PATCH 1/3] Documentation: move diff.wordRegex from config.txt to diff-config.txt

2012-11-11 Thread Ramkumar Ramachandra
19299a8 (Documentation: Move diff..* from config.txt to diff-config.txt, 2011-04-07) moved the diff configuration options to diff-config.txt, but forgot about diff.wordRegex, which was left behind in config.txt. Fix this. Signed-off-by: Ramkumar Ramachandra --- Documentation/config.txt |

[PATCH 2/5] launch_editor: ignore SIGINT while the editor has control

2012-11-11 Thread Jeff King
From: Paul Fox The user's editor likely catches SIGINT (ctrl-C). but if the user spawns a command from the editor and uses ctrl-C to kill that command, the SIGINT will likely also kill git itself (depending on the editor, this can leave the terminal in an unusable state). Signed-off-by: Paul Fo

[PATCH 5/5] launch_editor: propagate SIGINT from editor to git

2012-11-11 Thread Jeff King
We block SIGINT while the editor runs so that git is not killed accidentally by a stray "^C" meant for the editor or its subprocesses. This works because most editors ignore SIGINT. However, some editor wrappers, like emacsclient, expect to die due to ^C. We detect the signal death in the editor a

[PATCH 4/5] run-command: do not warn about child death by SIGINT

2012-11-11 Thread Jeff King
SIGINT is not generally an interesting signal to the user, since it is typically caused by them hitting "^C" or otherwise telling their terminal to send the signal. Signed-off-by: Jeff King --- I thought about making this an optional parameter for run-command, but it seems like everybody would wa

[PATCH 2/2] git-svn, perl/Git.pm: extend and use Git->prompt method for querying users

2012-11-11 Thread Sven Strickroth
git-svn reads usernames and other user queries from an interactive terminal. This cause GUIs (w/o STDIN connected) to hang waiting forever for git-svn to complete (http://code.google.com/p/tortoisegit/issues/detail?id=967). This change extends the Git::prompt helper, so that it can also be used f

[PATCH 3/5] run-command: drop silent_exec_failure arg from wait_or_whine

2012-11-11 Thread Jeff King
We do not actually use this parameter; instead we complain from the child itself (for fork/exec) or from start_command (if we are using spawn on Windows). Signed-off-by: Jeff King --- Just a cleanup I noticed while in the area. run-command.c | 7 +++ 1 file changed, 3 insertions(+), 4 delet

[PATCH 1/5] launch_editor: refactor to use start/finish_command

2012-11-11 Thread Jeff King
The launch_editor function uses the convenient run_command_* interface. Let's use the more flexible start_command and finish_command functions, which will let us manipulate the parent state while we're waiting for the child to finish. Signed-off-by: Jeff King --- editor.c | 10 +- 1 file

Re: [PATCH] git tag --contains : avoid stack overflow

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 05:46:32PM +0100, René Scharfe wrote: > >However, I couldn't reproduce it on Linux : where the windows > >implementations crashes at a ~32000 depth (*not* exactly 32768, mind > >you), on linux it happily went through 10 commits. I didn't take > >time to look much furthe

[PATCH 1/2] git-svn, perl/Git.pm: add central method for prompting passwords honoring GIT_ASKPASS and SSH_ASKPASS

2012-11-11 Thread Sven Strickroth
git-svn reads passwords from an interactive terminal or by using GIT_ASKPASS helper tool. But if GIT_ASKPASS environment variable is not set, git-svn does not try to use SSH_ASKPASS as git-core does. This cause GUIs (w/o STDIN connected) to hang waiting forever for git-svn to complete (http://code.

[PATCH 0/2] second try

2012-11-11 Thread Sven Strickroth
Hi, Am 06.10.2012 20:28 schrieb Junio C Hamano: > It is either that it was simply forgotten, or after I wrote the part > you quoted early in January there were discussions later that showed > the patch was not desirable for some reason. I do not recall which. I noticed no threads about possible p

Re: [PATCH] git tag --contains : avoid stack overflow

2012-11-11 Thread René Scharfe
Am 10.11.2012 22:13, schrieb Jean-Jacques Lafay: Le samedi 10 novembre 2012 21:00:10 UTC+1, Philip Oakley a écrit : From: "Jean-Jacques Lafay" > Sent: Saturday, November 10, 2012 5:36 PM > In large repos, the recursion implementation of contains(commit, > commit_list)

[PATCH] Re:gitweb: add readme to overview page

2012-11-11 Thread Heinrich Schuchardt
In this version of the patch the formatting has been corrected. Warnings for double / in filenames are avoided. Signed-off-by: Heinrich Schuchardt --- gitweb/gitweb.perl | 12 1 file changed, 12 insertions(+) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 10ed9e5..6

Re: [PATCH v5 01/15] fast-export: avoid importing blob marks

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 05:36:53PM +0100, Torsten Bögershausen wrote: > On 11.11.12 14:59, Felipe Contreras wrote: > > test_expect_success 'test biridectionality' ' > > + echo -n > marks-cur && > > + echo -n > marks-new && > Unless I messed up the patch: > > Minor issue: still a typo "biridec

Re: [PATCH v5 01/15] fast-export: avoid importing blob marks

2012-11-11 Thread Torsten Bögershausen
On 11.11.12 14:59, Felipe Contreras wrote: > test_expect_success 'test biridectionality' ' > + echo -n > marks-cur && > + echo -n > marks-new && Unless I messed up the patch: Minor issue: still a typo "biridectionality" Major issue: "echo -n" is still not portable. Could we simply use t

[PATCH 0/5] ignore SIGINT while editor runs

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 10:48:46AM -0500, Jeff King wrote: > Silly me. When I thought through the impact of Paul's patch, I knew that > we would notice signal death of the editor. But I totally forgot to > consider that the blocked signal is inherited by the child process. I > think we just need t

Re: What's cooking in git.git (Nov 2012, #02; Fri, 9)

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 09:02:48AM +0200, Kalle Olavi Niemitalo wrote: > If git did the same thing as cvs here, i.e. ignore the signals in > the parent process only and check the exit status of the editor, > I think that would be OK. Silly me. When I thought through the impact of Paul's patch, I

[PATCH] gitweb: add readme to overview page

2012-11-11 Thread Heinrich Schuchardt
For repositories it is possible to maintain a README.html which will be shown on the summary page. This is not possible for the server root. German law requires to provide contact data on the web server. This data could easily be entered in the overview page using a README.html. Furthermore it is

Re: [PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-11 Thread Jeff King
On Sun, Nov 11, 2012 at 08:20:27PM +0530, Ramkumar Ramachandra wrote: > >> diff --git a/builtin/diff.c b/builtin/diff.c > >> index 9650be2..6d00311 100644 > >> --- a/builtin/diff.c > >> +++ b/builtin/diff.c > >> @@ -297,6 +297,10 @@ int cmd_diff(int argc, const char **argv, const char > >> *prefi

Re: Help requested - trying to build a tool doing whole-tree commits

2012-11-11 Thread Eric S. Raymond
Junio C Hamano : > Perhaps not exactly what you are looking for, but don't we have > import-tar somewhere in contrib/fast-import hierarchy (sorry, not on > a machine yet, and I cannot give more details). If I recall correctly, that can only be used for original import. I think Andreas Schwab's su

Re: [PATCH v3 1/3] git-submodule add: Add -r/--record option

2012-11-11 Thread W. Trevor King
On Sun, Nov 11, 2012 at 02:33:45AM -0800, Junio C Hamano wrote: > The change seems to think "branch" is the _only_ thing the user > might want to record per submodule upon "git submodule add". I felt that earlier floating/tracking submodule patches were biting off more than they could chew, so I w

Re: [PATCH 2/3] diff: introduce diff.submodule configuration variable

2012-11-11 Thread Ramkumar Ramachandra
Jeff King wrote: > On Thu, Nov 01, 2012 at 04:13:49PM +0530, Ramkumar Ramachandra wrote: > >> diff --git a/builtin/diff.c b/builtin/diff.c >> index 9650be2..6d00311 100644 >> --- a/builtin/diff.c >> +++ b/builtin/diff.c >> @@ -297,6 +297,10 @@ int cmd_diff(int argc, const char **argv, const char >

[PATCH v2 6/6] completion: simplify __gitcomp() test helper

2012-11-11 Thread Felipe Contreras
By using print_comp as suggested by SZEDER Gábor. Signed-off-by: Felipe Contreras --- t/t9902-completion.sh | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 66c7af6..9b38b69 100755 --- a/t/t9902-completion.sh

[PATCH v2 5/6] completion: refactor __gitcomp related tests

2012-11-11 Thread Felipe Contreras
Lots of duplicated code! No functional changes. Signed-off-by: Felipe Contreras --- t/t9902-completion.sh | 76 ++- 1 file changed, 27 insertions(+), 49 deletions(-) diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 59cdbfd..66c7af

[PATCH v2 4/6] completion: consolidate test_completion*() tests

2012-11-11 Thread Felipe Contreras
No need to have two versions; if a second argument is specified, use that, otherwise use stdin. Signed-off-by: Felipe Contreras --- t/t9902-completion.sh | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/t/t9902-completion.sh b/t/t9902-completio

[PATCH v2 3/6] completion: simplify tests using test_completion_long()

2012-11-11 Thread Felipe Contreras
No need to duplicate that functionality. Signed-off-by: Felipe Contreras --- t/t9902-completion.sh | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index aff7e44..204c92a 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-co

[PATCH v2 2/6] completion: standardize final space marker in tests

2012-11-11 Thread Felipe Contreras
The rest of the code uses ' Z$'. Lets use that for test_completion_long() as well. Signed-off-by: Felipe Contreras --- t/t9902-completion.sh | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 5c067

[PATCH v2 1/6] completion: add comment for test_completion()

2012-11-11 Thread Felipe Contreras
So that it's easier to understand what it does. Also, make sure we pass only the first argument for completion. Shouldn't cause any functional changes because run_completion only checks $1. Signed-off-by: Felipe Contreras --- t/t9902-completion.sh | 6 +- 1 file changed, 5 insertions(+), 1

[PATCH v2 0/6] completion: test consolidations

2012-11-11 Thread Felipe Contreras
These started from a discussion with SZEDER, but then I realized there were many improvements possible. Changes since v1: * A lot more cleanups Felipe Contreras (6): completion: add comment for test_completion() completion: standardize final space marker in tests completion: simplify test

[PATCH v3 7/7] remote-bzr: add support to push special modes

2012-11-11 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-bzr | 60 +-- 1 file changed, 43 insertions(+), 17 deletions(-) diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr index 2bae5d0..f8919f4 100755 --- a/co

[PATCH v3 6/7] remote-bzr: add support for fecthing special modes

2012-11-11 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-bzr | 38 +-- contrib/remote-helpers/test-bzr.sh| 32 + 2 files changed, 59 insertions(+), 11 deletions(-) diff --git a/contrib/remote-helpers/git-remote-bzr b/c

[PATCH v3 5/7] remote-bzr: add simple tests

2012-11-11 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- contrib/remote-helpers/test-bzr.sh | 111 + 1 file changed, 111 insertions(+) create mode 100755 contrib/remote-helpers/test-bzr.sh diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh new f

[PATCH v3 4/7] remote-bzr: update working tree

2012-11-11 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-bzr | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr index 2c05f35..5b89a05 100755 --- a/contrib/remote-helpers/git-remote-bzr +++ b/contrib/re

[PATCH v3 3/7] remote-bzr: add support for remote repositories

2012-11-11 Thread Felipe Contreras
Strictly speaking bzr doesn't need any changes to interact with remote repositories, but it's dead slow. Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-bzr | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/contrib/remote-helper

[PATCH v3 2/7] remote-bzr: add support for pushing

2012-11-11 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-bzr | 295 ++ 1 file changed, 295 insertions(+) diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr index b6be9d6..8366234 100755 --- a/contrib/remote-hel

[PATCH v3 1/7] Add new remote-bzr transport helper

2012-11-11 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-bzr | 352 ++ 1 file changed, 352 insertions(+) create mode 100755 contrib/remote-helpers/git-remote-bzr diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-

[PATCH v3 0/7] New remote-bzr remote helper

2012-11-11 Thread Felipe Contreras
Hi, This is a re-roll of the previous series to add support to fetch and push special modes, and refactor some related code. Cheers. Changes since v2: * Add support for special modes * Minor refactoring and cleanups Changes since v1: * Rewritten to avoid bzr-fastimport Felipe Contreras (7

[PATCH 2/2] remote-hg: fix for files with spaces

2012-11-11 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-hg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 0edb8ac..1d46838 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/

[PATCH 1/2] remote-hg: trivial cleanups

2012-11-11 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-hg | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 7929eec..0edb8ac 100755 --- a/contrib/remote-helpers/git-remote-hg ++

[PATCH 0/2] remote-hg: small fixes

2012-11-11 Thread Felipe Contreras
Hi, Nothing major. These are meant to be on top of fc/remote-hg that is on peff/pu. Felipe Contreras (2): remote-hg: trivial cleanups remote-hg: fix for files with spaces contrib/remote-helpers/git-remote-hg | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.8.0 -- To unsu

[PATCH v5 15/15] fast-export: don't handle uninteresting refs

2012-11-11 Thread Felipe Contreras
They have been marked as UNINTERESTING for a reason, lets respect that. Currently the first ref is handled properly, but not the rest, so: % git fast-export master ^master Would currently throw a reset for master (2nd ref), which is not what we want. % git fast-export master ^foo ^bar ^roo %

[PATCH v5 14/15] fast-export: make sure updated refs get updated

2012-11-11 Thread Felipe Contreras
When an object has already been exported (and thus is in the marks) it's flagged as SHOWN, so it will not be exported again, even if in a later time it's exported through a different ref. We don't need the object to be exported again, but we want the ref updated, which doesn't happen. Since we ca

[PATCH v5 13/15] fast-export: fix comparison in tests

2012-11-11 Thread Felipe Contreras
First the expected, then the actual, otherwise the diff would be the opposite of what we want. Signed-off-by: Felipe Contreras --- t/t9350-fast-export.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh index 0c8d828..b7d30

[PATCH v5 12/15] fast-export: trivial cleanup

2012-11-11 Thread Felipe Contreras
Setting 'commit' to 'commit' is a no-op. It might have been there to avoid a compiler warning, but if so, it was the compiler to blame, and it's certainly not there any more. Signed-off-by: Felipe Contreras --- builtin/fast-export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

  1   2   >