On Sun, Nov 11, 2012 at 9:49 PM, Max Horn <m...@quendi.de> wrote:
> On 11.11.2012, at 14:59, Felipe Contreras wrote:
>> People seeking for reference would find it useful.
> Hm, I don't understand this commit message. Probably means I am j git 
> fast-export --use-done-featureust too dumb, but since I am one of those 
> people who would likely be seeking for reference, I would really appreciate 
> if it could clarified. Like, for example, I don't see how the patch below 
> makes anything "clear", it just seems to change the "import" command of 
> git-remote-testgit to make use of the 'done' feature?

No, the done feature was there already, but not so visible: git
fast-export --use-done-feature <-there. Which is the problem, it's too
easy to miss, therefore the need to make it clear.

> Perhaps the idea of the patch is to make use of the "done" feature so that 
> remote-testgit acts as "reference implementation"? If that is the intention, 
> then perhaps this could be used as commit message:

It's already there.

>   remote-testgit: make use of the 'done' feature
>   This might be helpful for people who would like to see how to properly
>   implement the "done" feature.

Everybody should implement the 'done' feature. Otherwise random error
messages quite easily appear.

Felipe Contreras
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to