e3fdbcc8e1 (parse_mailboxes: accept extra text after <...> address,
2016-10-13) improved our in-house address parser and made it closer to
Mail::Address. As a consequence, some tests comparing it to
Mail::Address now pass, but e3fdbcc8e1 forgot to update the test.
Signed-off-by: Matthi
Junio C Hamano writes:
> Are you proposing to replace the tests written as shell scripts with
> scripts in another language or framework that run equivalent
> sequences of git commands that is as portable as, if not more,
> Bourne shell?
The language (/bin/sh) is probably not the biggest issue.
tch hunks individually, "git add -p" jumps directly to the
"patch" inner loop of "git add -i".
To add whole individual files, a plain "git add" using zsh's smart
completion (autocompletes only files for which "git add" is not a
no-op), or globs.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
after email
address, 2012-11-22).
IMHO, it's OK to continue doing this: removing comments from To: and Cc:
is not really a problem (and I think we've seen nobody complain about it
since 2012). But after my patch, these two lines can probably safely be
removed, as there can no longer be "garbage" after the email, only
comments.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
ep the possibility to handle comma-separated lists.
Reported-by: Larry Finger
Signed-off-by: Matthieu Moy
---
perl/Git.pm | 13 +++--
t/t9001-send-email.sh | 29 +
2 files changed, 36 insertions(+), 6 deletions(-)
diff --git a/perl/Git.pm b/perl/Git.pm
=> we'd need to handle the ".*" syntax when stripping comments. And
again, that wouldn't be consistent with Mail::Address.
So, I ended up implementing 3., which actually isn't hard, and gives
code IMHO cleaner than it used to be.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
think it is a realistic
> expectation. How would it know "Cc: Stable 4.8, 4.9"
> has garbage " 4.8, 4.9" that needs to be stripped, while "Cc: Stable
> 4.8, torva...@linux-foundation.org" has two valid
> addresses that need to be CC'ed and " 4.8" is the only thing that is
> unwanted?
We clearly can't guess, but we can be consistent with Mail::Address, so
that git's behavior depends less on its availability.
Patch follows doing that.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Larry Finger writes:
> On 10/12/2016 02:36 AM, Matthieu Moy wrote:
>> Larry Finger writes:
>>
>>> On 10/11/2016 11:18 AM, Matthieu Moy wrote:
>>>> Larry Finger writes:
>>>>
>>>>> That added information at the end is intended to
Larry Finger writes:
> On 10/12/2016 02:36 AM, Matthieu Moy wrote:
>> Larry Finger writes:
>>
>>> On 10/11/2016 11:18 AM, Matthieu Moy wrote:
>>>> Larry Finger writes:
>>>>
>>>>> That added information at the end is intended to
Larry Finger writes:
> On 10/11/2016 11:18 AM, Matthieu Moy wrote:
>> Larry Finger writes:
>>
>>> That added information at the end is intended to be passed on to the
>>> stable group. In this case, the patch needs to be applied to kernel
>>> vers
quot; which won't remove it).
Not an objection to patching send-email anyway, but if there's a simple
and RFC-compliant way to do what you're looking for, we can as well use
it (possibly in addition to patching).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
in perl/Git.pm. It should be
rather easy to modify it but I need to understand the spec before I can
try to implement anything.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Johannes Schindelin writes:
> Hi Matthieu,
>
> On Fri, 7 Oct 2016, Matthieu Moy wrote:
>
>> Another possibility: !(nocd), which leaves room
>> for !(keyword1,keyword2,...) if needed later. Also, it is consistent
>> with the :(word) syntax of pathspecs.
>
> But
;> construct. I know that *I* would have been puzzled by it, asking
>> "What the
>> heck does this do?".
>
> Yep. And I wouldn't want to set a tradition for the next alias type
> '!!!'. There's no good choice to represent a new alias type with a
>
ing` is a deprecated synonym for this).
)
I agree that doing the same thing is the best option.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
t; + support for backwards compatibility with existing configuration
> + files.
Nit: I think the doc normally doesn't use "we" this way (we = the Git
developers or the Git tool). Hence my s/which we still support/still
supported/ above.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
on't know who invented the concept, but environment variables have
been there in the windows world since it exists I think (it existed in
MS-DOS).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
hashes.
OTOH, small projects could keep these few columns of screen real-estate.
That said, I can certainly live without these 5 columns, don't take my
message as an objection to setting to 12 right away.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
ase of someone growing his own project without
cloning, and isn't as clever as actually looking for colision, but it
would probably provide a sane default in 99% cases, and wouldn't be
worse than hardcoding 7 in the 1% remaining cases.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
in the wrong direction. You may want to Cc
brian if unsure.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
default is
'auto' to avoid one indirection for the reader.
Signed-off-by: Matthieu Moy
---
Documentation/config.txt | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index 32f065c..66429fb 100
while back already). Patch follows.
> (2) git config color.branch false ; git branch
Unrelated from the question, but you could write
git -c color.branch=false git branch
to set a configuration value just for one command.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
checkout update:\n%s");
Probably a leftover from an old sentence starting with Working? In any
case, obviously correct too, thanks.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
both cases, once you're done, continue with:
I don't remember writing this, but since I'm Cc-ed I guess I did ;-).
Obviously correct, thanks.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Johannes Schindelin writes:
> Hi,
>
> On Fri, 2 Sep 2016, Matthieu Moy wrote:
>
>> Johannes Schindelin writes:
>>
>> > Hi Ævar,
>> >
>> > On Fri, 2 Sep 2016, Ævar Arnfjörð Bjarmason wrote:
>> >
>> >> This might be me mi
ause of the many t9*svn* tests (which, BTW
> take a substantial time to run). So if I run the test suite, I better do
> it with a perl.exe in the PATH that can run the SVN tests. Otherwise I
> might just as well not bother with running the entire test suite...
Maybe something like
\path\to\strawberry-perl\perl.exe \path\to\prove ...
without changing the PATH would work. I wouldn't call that convenient
though.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Duy Nguyen writes:
> On Mon, Aug 22, 2016 at 7:59 PM, Matthieu Moy
> wrote:
>> Duy Nguyen writes:
>>
>>> On Sun, Aug 21, 2016 at 4:08 AM, Jakub Narębski wrote:
>>>> W dniu 19.08.2016 o 15:54, Jeff King pisze:
>>>>> On Sat, Aug 13, 2016 at
e it may later be extended to e.g.
[include-if "not(gitdir-is:...)"]
[include-if "gitdir-matches:regex"]
[include-if "gitdir-is:... and git-version-greater:2.9"]
...
I actually already use "conditional include on version number" because I
use push.default=upstr
wn variant.
I think the way to go is --no-renames until you stop using patch <2.7.
If you don't want to specify it each time, you can revert to the pre-2.9
behavior by setting
[diff]
renames = false
in ~/.gitconfig.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscri
Changes are described in CHANGES.
Contributions-by: Matthieu Moy
Contributions-by: Irfan Adilovic
Signed-off-by: Matthieu Moy
---
contrib/hooks/multimail/CHANGES | 59 ++
contrib/hooks/multimail/CONTRIBUTING.rst| 9 +-
contrib/hooks/multimail/README
We already suggest 'git rebase --abort' during a conflicted rebase.
Similarly, suggest 'git merge --abort' during conflict resolution on
'git merge'.
Signed-off-by: Matthieu Moy
---
t/t7060-wtstatus.sh| 4
t/t7512-status-help.sh | 1 +
wt-status.c
Jeff King writes:
> On Wed, Jul 13, 2016 at 09:21:37AM +0200, Matthieu Moy wrote:
>
>> > +static int prepare_include_condition_pattern(struct strbuf *pat)
>> > +{
>> > + int prefix = 0;
>> > +
>> > + /* TODO: maybe support ~user/ too */
>
' && is_dir_sep(pat->buf[1])) {
> + struct strbuf path = STRBUF_INIT;
> + const char *home = getenv("HOME");
> +
> + if (!home)
> + return error(_("$HOME is not defined"));
expand_user_path in
+preview::
> +Parse and render local file into HTML. Preview a page without actually
> pushing it to the wiki.
Better write the commands completely like
git mw help::
to avoid ambiguity with git-remote-mediawiki (which is a separate
command).
--
Matthieu Moy
http://www-verimag.imag.fr/~
gt; Is there some sort of strange file caching that happening
> when make starts that, although the local db is updated, I don't get
> what I'm after?
Git can keep information either in RAM, hence not shared between git
invocations (so running git within or outside the Makefile wouldn&#x
definition can override an "xfuncname"
def. To preserve this behavior we had to introduce ordering in the
cache, but to me this was a design mistake to rely on order.
In short: we already have one, but I'm not excited either about
introducing new ones.
--
Matthieu Moy
http://www
bort with ":cq", which will make Vim exit
non-zero").
If you mean "likely to trigger nasty bugs", then indeed testing the case
when apply_autostash fails is interesting: for example, calling
die_abort when "stash apply" fails is tempting, but would lead to
infinit
(by switching to a branch which doesn't contain a directory
for example).
> If I do: cd .. && cd -; all is well.
This is a typical symptom of the issue above.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git&q
7;grep.patternType')
removed.
Other fixes are typos and details in commit messages.
Matthieu Moy (7):
Documentation/git-mv.txt: fix whitespace indentation
doc: typeset short command-line options as literal
doc: typeset long command-line options as literal
doc: typeset '--
The current practice is:
git/Documentation$ git grep "'HEAD'" | wc -l
24
git/Documentation$ git grep "\`HEAD\`" | wc -l
66
Let's adopt the majority as a guideline.
Signed-off-by: Matthieu Moy
---
Documentation/CodingGuidelines | 5 +++--
1 file changed, 3
scribe rewritten history).
Signed-off-by: Matthieu Moy
---
Documentation/config.txt | 32
Documentation/diff-format.txt| 2 +-
Documentation/diff-generate-patch.txt| 4 ++--
Documentation/fetch-options.txt | 6 +++---
Docu
x27;(-[a-z])'/\`\$1\`/g" *.txt
Signed-off-by: Matthieu Moy
---
Documentation/config.txt | 8
Documentation/diff-config.txt | 2 +-
Documentation/diff-format.txt | 8
Documentation/diff-generate-patch.txt | 4 ++--
Documentation/git-cat-
This was obtained with:
perl -pi -e "s/'--'/\`--\`/g" *.txt
Signed-off-by: Matthieu Moy
---
Documentation/git-fast-import.txt | 4 ++--
Documentation/git-filter-branch.txt | 2 +-
Documentation/rev-list-options.txt | 2 +-
3 files changed, 4 insertions(+), 4 deleti
We previously reformatted '--option' to `--option`. This patch reformats
'--option ' to `--option `. Obtained with:
perl -pi -e "s/'(--[a-z][a-z=<>-]* <[^>]*>)'/\`\$1\`/g" *.txt
Signed-off-by: Matthieu Moy
---
Documentation/git-
This is an application of the newly added CodingGuidelines to HEAD and
variants like FETCH_HEAD. It was obtained with:
perl -pi -e "s/'([A-Z_]*HEAD)'/\`\$1\`/g" *.txt
Signed-off-by: Matthieu Moy
---
Documentation/git-bisect.txt| 2 +-
Documentation/git-br
Replace spaces with tabs to avoid a warning when further patches change
these lines.
Signed-off-by: Matthieu Moy
---
Documentation/git-mv.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-mv.txt b/Documentation/git-mv.txt
index e453132..6dcb8b2 100644
receive`
> (Similar question for commands like 'git fetch').
Backticks too:
Literal examples (e.g. use of command-line options, command names,
branch names, configuration and environment variables) must be
typeset in monospace (i.e. wrapped with backticks):
`--pretty=oneline`
Jeff King writes:
> On Mon, Jun 27, 2016 at 07:46:18PM +0200, Matthieu Moy wrote:
>
>> diff --git a/Documentation/git-mv.txt b/Documentation/git-mv.txt
>> index e453132..cbae886 100644
>> --- a/Documentation/git-mv.txt
>> +++ b/Documentation/git-mv.tx
Jeff King writes:
> On Mon, Jun 27, 2016 at 07:46:20PM +0200, Matthieu Moy wrote:
>
>> Subject: Re: [PATCH 3/6] doc: typeset -- as litteral
>
> s/litteral/literal/
>
> I can hardly blame you, though. I think English stole the word from
> French and then switche
Jeff King writes:
> On Mon, Jun 27, 2016 at 07:46:19PM +0200, Matthieu Moy wrote:
>
>> grep.extendedRegexp::
>> -If set to true, enable '--extended-regexp' option by default. This
>> -option is ignored when the `grep.patternType` option is set to a va
scribe rewritten history).
Signed-off-by: Matthieu Moy
---
Documentation/config.txt | 34
Documentation/diff-format.txt| 2 +-
Documentation/diff-generate-patch.txt| 4 ++--
Documentation/fetch-options.txt | 6 +++---
Docu
This is an application of the newly added CodingGuidelines to HEAD and
variants like FETCH_HEAD. It was obtained with:
perl -pi -e "s/'([A-Z_]*HEAD)'/\`\$1\`/g" *.txt
Signed-off-by: Matthieu Moy
---
Documentation/git-bisect.txt| 2 +-
Documentation/git-br
We previously reformatted '--option' to `--option`. This patch reformats
'--option ' to `--option `. Obtained with
perl -pi -e "s/'(--[a-z][a-z=<>-]* <[^>]*>)'/\`\$1\`/g" *.txt
Signed-off-by: Matthieu Moy
---
Documentation/git-config.txt
The current practice is:
git/Documentation$ git grep "'HEAD'" | wc -l
24
git/Documentation$ git grep "\`HEAD\`" | wc -l
66
Let's adopt the majority as a guideline.
Signed-off-by: Matthieu Moy
---
Documentation/CodingGuidelines | 5 +++--
1 file changed, 3
This was obtained with
perl -pi -e "s/'--'/\`--\`/g" *.txt
Signed-off-by: Matthieu Moy
---
Documentation/git-fast-import.txt | 4 ++--
Documentation/git-filter-branch.txt | 2 +-
Documentation/rev-list-options.txt | 2 +-
3 files changed, 4 insertions(+), 4 deleti
x27;(-[a-z])'/\`\$1\`/g" *.txt
Signed-off-by: Matthieu Moy
---
Documentation/config.txt | 8
Documentation/diff-config.txt | 2 +-
Documentation/diff-format.txt | 8
Documentation/diff-generate-patch.txt | 4 ++--
Documentation/git-cat-
ve speaker, but I think both versions are correct.
I'm OK with the change, though. Dropping something useless is usually a
good thing :-).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
6 at the bottom)
>
> Nobody. It is too cumbersome to use their upload tool to update many
> files (it is geared towards updating a handful of tarballs at a time).
Then, I guess it would make sense to remove it to avoid pointing users
to outdated docs?
--
Matthieu Moy
http://www-verimag.imag.fr/~
github.com = github.com with any protocol
* /path/to/file or file:///path/to/file = local path
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
printf(_("nothing to commit, working directory
> clean\n"));
> + printf(_("nothing to commit, working tree clean\n"));
Looks good to me, thanks.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> Jeff King writes:
>>
>>> --- a/send-pack.c
>>> +++ b/send-pack.c
>>> @@ -36,18 +36,15 @@ int option_parse_push_signed(const struct option *opt,
>>> die("bad %s argument: %s"
issed the obvious, but doesn't this change the behavior when
"negative && !has_sha1_file(sha1)" happens? I understand that you don't
need write_or_whine anymore, but don't understand how you get rid of the
"return 1" here.
--
Matthieu Moy
http://www-verimag.im
15:53:58 +0200, aut...@example.com wrote:"
> msgtxt3 &&
I would prefer to have the full address including the real name here (A
) in this example. Actually, after a quick look at
the code, I don't understand where the name has gone (what's shown here
is extracted from the From: header).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
e $prefix_re. You can just
my $subject = $mail->{"subject"}[0];
if (...) {
$subject = "Re: " . $subject;
}
(preferably using sensible as '...' as noted by Junio ;-) ).
In previous iterations of this series, you had issues wit
ere, which
did carry some information.
I'd write it as
Adding cc: cc-...@example.com from --cc-cmd: ./cccmd
It might make sense to split this into two patches: one for (mbox) +
headers and one for (cc-cmd) and (to-cmd). Spotting special-cases like
the above inside a long patch is hard for
ther have a bit more explanation about why this info is
"unnecessary".
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ready refactoring, then I think it makes sense
to have two patch series, the first being only "reply to a message in a
file". If the refactoring itself is not ready, you may send a separate
series "tests clean up" and explain on the cover-letter that it's, well,
only a t
C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= "
> + cc_adr=$(awk "/^Cc: /{flag=1}/^Subject: /{flag=0} flag {print}"
> msgtxt1) &&
> + echo "$cc_adr" | grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?=
> "
> '
>
> test_expect_succes
le at 2), "sort" reads nothing and
> writes nothing.
Tom: in case you're not convinced, try this:
$ (echo b; echo a) >f
$ sort f
a
b
$ sort f >f
$ cat f
$
Also, useless ';' and missing double-quotes around "$1" to avoid bad
surprises ifever test_cmp_noorder i
history (because you can "rebase -i" and
force-push as much as you want to your public fork before the code is
merged)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
x27;t think they have to be part of this series. On a side note,
this patch is written by students of mine as part of a school project
which ends this Friday, leaving very little time for them to write more
patches.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list:
this patch.
Did you drop the "configuration variables" patch on purpose? Or will you
resend it separately?
Anyway, this new patch and the new version of the first two are
Reviewed-by: Matthieu Moy
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from th
Junio C Hamano writes:
> Matthieu Moy writes:
>
>>> +test_config_unchanged () {
>>> + git config --list --local >original
>>> + "$@"
>>> + git config --list --local >modified
>>> + test_cmp original modified
>>>
"Philip Oakley" writes:
> From: "Matthieu Moy"
>
>> But then the maintainer is not the one picking changes from it (you're
>> sending them by email), so the "maintainer" label is not really accurate
>> in the diagram:
>>
>&g
nd self promotion.
>
> A clarification/explanation that calling it a 'publish' repo is about
> granting access, and possible open access, would make it more
> acceptable.
I think "publish" is the best we found up to now.
--
Matthieu Moy
http://www-verimag.imag.fr/~
"Philip Oakley" writes:
> From: "Matthieu Moy"
>>
>> I don't think you will find a name that fits all use-cases. IHMO, best
>> is to pick one rather general use-case, make the explanations for it,
>> and maybe explain somewhere that there a
"Annie Wojcik" writes:
> Hello,
> Can you tell me if this product is free for educational use?
Git is free, period ;-). Both free of charge, and "free as in free
speach" (http://www.gnu.org/philosophy/free-sw.en.html).
--
Matthieu Moy
http://www-verimag.imag.fr/~m
Matthieu Moy writes:
>> + *easier and avoid confusion with a distant repo like 'github.com'
Forgotten nit in previous message: s/distant/remote/.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" i
ses' '
> +
> + test-strbuf --preallocated_check_behavior
Useless blank line.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
William Duclot writes:
> The function strbuf_wrap() is not part of the strbuf API, yet prevent to
> extend the API to include wrapping functions. Renaming it to something
> more specific allow to use "strbuf_wrap" for the strbut API.
s/strbut/strbuf/
--
Matthieu Moy
http://
;size is not as expected");
Space before '('. Also, it's nice for the guy debugging that to say
"incorrect size. Expected %d, got %d" or so.
> diff --git a/t/t0082-strbuf.sh b/t/t0082-strbuf.sh
> new file mode 100755
> index 000..6a579a3
> --- /dev/null
pect_success 'pull -u refs/heads/*:refs/remotes/origin/* should not
> work' '
> + git checkout master &&
> + test_config_unchanged git pull -u upstream
> "refs/heads/*:refs/remotes/upstream/*"
> +'
> +
> +test_expect_success 'pull -u master:refs/remotes/origin/master should not
> work' '
> + test_config_unchanged git pull -u upstream
> master:refs/remotes/upstream/master
> +'
> +
> +test_expect_success 'pull -u with a tag should not work' '
> + git checkout master &&
> + test_config_unchanged git pull -u upstream initial_tag
> +'
> +
> +test_expect_success 'pull -u on detached head should not work' '
> + git checkout HEAD^0 &&
> + test_config_unchanged git pull -u upstream master2 &&
> + git checkout -
> +'
For all these "test_config_unchanged", it would be nice to check that
the error message is the right one too.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
test_expect_success 'local path with file://' '
> + git config remote.pushBlacklist file://blacklist &&
> + test_must_fail git push blacklist HEAD 2> result &&
> + test_cmp result forbidden
> +'
> +test_expect_success 'only on
tes one
trivial conflict with pu, and my suggested fix for long options creates
one more. Seems manageable.
For now, I went carefully through the patches. With or without my
suggested changes/additions, the series is now
Reviewed-by: Matthieu Moy
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr
mpt as
We now have a minor inconsistency between GIT_ASKPASS and SSH_ASKPASS.
You can catch this one and a handful others with
git grep "'[A-Z_]*' environment"
(That would be a separate patch)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from thi
Matthieu Moy writes:
> Tom Russello writes:
>
>> --- a/Documentation/CodingGuidelines
>> +++ b/Documentation/CodingGuidelines
>> @@ -526,12 +526,13 @@ Writing Documentation:
>> modifying paragraphs or option/command explanations that contain options
>&
further expanded. The use of `backticks` to achieve the
It might make sense to mention that they will appear bold in manpages
too.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vge
Jordan DE GEA writes:
>> Matthieu Moy a écrit :
>>
>> That is technically correct, but to illustrate the overall flow, I'd
>> rather avoid naming the repositories in terms of git commands. If you do
>> so, you will probably end up with tautological explanat
dback on it. I
think it translates the intent better than PUSH_REMOTE. An alternative
would be PUBLISH (= the repository you use to publish your changes so
that the maintainer can pick them).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "uns
one would be even better. Consider this case (without the
> indentation):
Rejecting colon anywhere in the line would also reject valid patterns
like this:
a:hover {
Rejecting it at end of line is probably a good trade-off.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubs
's codebase, so it's not necessarily a step in the right
direction.
In conclusion, I don't have a conclusion, sorry ;-).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in the last one.
Signed-off-by: Matthieu Moy
---
Junio, you can add this to mm/makefile-developer-can-be-in-config-mak
(or squash it in the commit, but having two separate commit messages
make sense IMO).
Makefile | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff
isn't for
you and you should just set CFLAGS directly.
Not really serious, but we can fix that easily. Patch follows.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
tion policy, so in this case the user should call
strbuf_release(), and let it chose whether to call "free()"
(OWNS_MEMORY) or not. This is OK with your implementation, but the doc
needs to reflect this.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list
=
> +
> +
> +Push to origin by default
> +~
> +
> +===
> +`git config branch.master.pushRemote origin`
> +===
"by default" probably needs to be clarified ("
g the configure script to generate a
config.mak.autogen, the later file contained a "CFLAGS = "
initialization, which overrode the "CFLAGS += -W..." triggered by
DEVELOPER.
This patch fixes both issues.
Signed-off-by: Matthieu Moy
---
I'm surprised that no one noticed the
.
@grenoble-inp.fr => only for staff (i.e. me but not students).
I have a preference for the @grenoble-inp.org in the From and
Signed-off-by as the Git history will remain after the current adress
become invalid.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: sen
ction in the meantime).
I'm all for dropping a feature that no one uses if it turns out to be
the case.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More
t;git show --check".
Not sure if it deserves a reroll. Junio?
Other than that, the patch is now
Reviewed-by: Matthieu Moy
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vg
William Duclot writes:
> Matthieu Moy writes:
>
>> void strbuf_grow(struct strbuf *sb, size_t extra)
>> {
>> int new_buf = !sb->alloc;
>> ...
>> if (sb->flags & STRBUF_OWNS_MEMORY) {
>> if (new_
101 - 200 of 2167 matches
Mail list logo
