Junio C Hamano writes:
> I see a lot of rerolls on the credential helper front, but is there
> anybody working on hooking send-email to the credential framework?
Not answering the question, but git-remote-mediawiki supports the
credential framework. It is written in perl, and the credential supp
On Tue, Feb 05, 2013 at 01:46:09PM -0800, Constantine A. Murenin wrote:
> I've encountered two problems so far:
>
> 0. After initialising the repository, I was unable to `git checkout
> --orphan Debian-6.0.4-nginx-1.0.12` -- presumably it doesn't work when
> the repo is empty? This sounds like a
On Sun, Jan 27, 2013 at 3:12 PM, Hans-Juergen Euler wrote:
> This seems to be a problem of the windows version. At least with its
> complete severity. Installed git on Ubuntu in a virtual machine was
> able to clone the subversion repos past the tag with the white-space
> at the end. I am not sure
On Sun, Jan 27, 2013 at 3:57 PM, Torsten Bögershausen wrote:
> t0070 and t1301 fail when running the test suite under cygwin.
> Skip the failing tests by unsetting POSIXPERM.
>
But is this the real reason? I thought Cygwin implemented POSIX permissions...?
--
To unsubscribe from this list: send t
On 02/05/2013 06:27 PM, Junio C Hamano wrote:
> Michael Haggerty writes:
>> I would again like to express my discomfort about this feature, which is
>> already listed as "will merge to next".
>
> Do not take "will merge to next" too literally. One major purpose
> of marking a topic as such is ex
On Tue, Feb 5, 2013 at 5:29 PM, Michael Haggerty wrote:
> Hiderefs creates a "dark" corner of a remote git repo that can hold
> arbitrary content that is impossible for anybody to discover but
> nevertheless possible for anybody to download (if they know the name of
> a hidden reference). In earl
On 01/31/2013 11:09 PM, Junio C Hamano wrote:
>
> -static int http_request_reauth(const char *url, void *result, int target,
> +static int http_request_reauth(const char *url,
> +struct strbuf *type,
> +void *result, int target,
>
On Wed, Feb 06, 2013 at 11:24:41AM +0100, Michael Schubert wrote:
> On 01/31/2013 11:09 PM, Junio C Hamano wrote:
>
> >
> > -static int http_request_reauth(const char *url, void *result, int target,
> > +static int http_request_reauth(const char *url,
> > + struct strbu
On Wed, Feb 6, 2013 at 11:35 AM, Junio C Hamano wrote:
>> How about this since [PATCH v3]:
>>
>> diff --git a/utf8.c b/utf8.c
>> index 52dbd..b893a 100644
>> --- a/utf8.c
>> +++ b/utf8.c
>> @@ -443,8 +443,11 @@ int utf8_fprintf(FILE *stream, const char *format, ...)
>> strbuf_vaddf(&buf, f
Neil venit, vidit, dixit 06.02.2013 05:45:
> Hi everyone,
>
> A while back I did a svn-to-git migration for my team. Our subversion
> repository had about 30K+ commits, 100+ branches, 2K+ tags, all made
> over a 20+ year period. I was doing the migration using git-svn, and
> my big problem was the
On Tue, Feb 05, 2013 at 07:45:01AM -0800, Junio C Hamano wrote:
> > In the earlier review, I mentioned making this per-service, but I see
> > that is not the case here. Do you have an argument against doing so?
>
> Perhaps then I misunderstood your intention. By reminding me of the
> receive-pac
Hi there,
while trying to understand which parts of the author & committer identity are
mandatory (name, email, or both), I ended up in ident.c, looking at
ident_is_sufficient(), and to my surprise discovered that this seems to differ
between Windows (were both are mandatory) and everyone else:
On Wed, Feb 06 2013, Junio C Hamano wrote:
> I see a lot of rerolls on the credential helper front, but is there
> anybody working on hooking send-email to the credential framework?
I assumed someone had, but if not I can take a stab at it. I'm not sure
however how should I map server, server-po
On Wed, 06 Feb 2013 14:26:46 +0100 Michal Nazarewicz wrote:
MN> On Wed, Feb 06 2013, Junio C Hamano wrote:
>> I see a lot of rerolls on the credential helper front, but is there
>> anybody working on hooking send-email to the credential framework?
MN> I assumed someone had, but if not I can ta
On Wed, 06 Feb 2013 09:11:17 +0100 Matthieu Moy
wrote:
MM> Junio C Hamano writes:
>> I see a lot of rerolls on the credential helper front, but is there
>> anybody working on hooking send-email to the credential framework?
MM> Not answering the question, but git-remote-mediawiki supports the
> From: Matthieu Moy
>
> In any case, I can't reproduce with 1.8.1.2.526.gf51a757: I don't get
> undless output. On the other hand, I get a slightly misformatted output:
>
> * commit a393ed598e9fb11436f85bd58f1a38c82f2cadb7 (from
> 2c1e6a36f4b712e914fac994463da7d0fdb2bc6d)
> |\ Merge: 2c1e6a
This min series aims at completing the textconv support of user facing
commands. It is RFC for lack of documentation and tests, to check
whether we really want to go in that direction (I do).
1/4 covers the missing textconv support in the "blob case" of "git
show", which should be (and then is) an
Currently, "diff" and "cat-file" for blobs obey "--textconv" options
(with the former defaulting to "--textconv" and the latter to
"--no-textconv") whereas "show" does not obey this option, even though
it takes diff options.
Make "show" on blobs behave like "diff", i.e. obey "--textconv" by
defaul
When a command is supposed to use textconv filters (by default or with
"--textconv") and none are configured then the blob is output without
conversion; the only exception to this rule is "cat-file --textconv".
Make it behave like the rest of textconv aware commands.
Signed-off-by: Michael J Grub
From: Jeff King
Recently and not so recently, we made sure that log/grep type operations
use textconv filters when a userfacing diff would do the same:
ef90ab6 (pickaxe: use textconv for -S counting, 2012-10-28)
b1c2f57 (diff_grep: use textconv buffers for add/deleted files, 2012-10-28)
0508fe5
Make "grep" obey the "--textconv" option also for the object case, i.e.
when used with an argument "rev:path".
Signed-off-by: Michael J Gruber
---
builtin/grep.c | 11 ++-
object.c | 26 --
object.h | 2 ++
3 files changed, 28 insertions(+), 11 deleti
On Mon, 04 Feb 2013 15:10:45 -0800 Junio C Hamano wrote:
JCH> Ted Zlatanov writes:
JCH> I thought that we tend to avoid Emacs/Vim formatting cruft left in
JCH> the file. Do we have any in existing file outside contrib/?
>>
>> No, but it's a nice way to express the settings so no one is guessi
Ted Zlatanov writes:
> MM> [...] so the way to go for send-email is probably to libify the
> MM> credential support in git-remote-mediawiki, and to use it in send-email.
>
> I looked and that's indeed very useful. If it's put in a library, I'd
> use credential_read() and credential_write() in my
Michael J Gruber writes:
> Introduce an option "--textconv" which makes git grep use any configured
> textconv filters for grepping and output purposes. It is off by default.
>
> Signed-off-by: Michael J Gruber
> ---
> builtin/grep.c | 2 ++
> grep.c | 100
> +
On Wed, Feb 06, 2013 at 10:03:00AM -0500, Dale R. Worley wrote:
> > From: Matthieu Moy
> >
> > In any case, I can't reproduce with 1.8.1.2.526.gf51a757: I don't get
> > undless output. On the other hand, I get a slightly misformatted output:
> >
> > * commit a393ed598e9fb11436f85bd58f1a38c82f2
Duy Nguyen writes:
> How about utf8_fwprintf? wprintf() deals with wide characters and
> returns the number of wide characters, I think the name fits. And we
> could just drop utf8_ and use the existing name, because we don't use
> wchar_t* anyway.
Please, no. That line of reasoning shows a hor
Jeff King writes:
> Is it worth having a strbuf_set* family of functions to match the
> strbuf_add*? We seem to have these sorts of errors with strbuf from time
> to time, and I wonder if that would make it easier (and more readable)
> to do the right thing.
Possibly.
The callsite below may be
Jeff King writes:
> On Tue, Feb 05, 2013 at 07:45:01AM -0800, Junio C Hamano wrote:
>
>> > In the earlier review, I mentioned making this per-service, but I see
>> > that is not the case here. Do you have an argument against doing so?
>>
>> Perhaps then I misunderstood your intention. By remind
Hi there:
I asked a few days ago whether I could easily diff 2 file revisions with the
mouse in gitk, but I got no reply yet, see here:
How to diff two file revisions with the mouse (with gitk)
https://groups.google.com/forum/#!topic/git-users/9znsQsTB0dE
I am hoping that it was the wron
On Wed, 06 Feb 2013 16:10:12 +0100 Matthieu Moy
wrote:
MM> Ted Zlatanov writes:
MM> [...] so the way to go for send-email is probably to libify the
MM> credential support in git-remote-mediawiki, and to use it in send-email.
>>
>> I looked and that's indeed very useful. If it's put in a libr
Hi,
I'd like to script a git export command that can be given a list of already
exported worktrees and the tree SHA1s these worktrees correspond too. The git
export command should then for every file it wants to export lookup in the
existing worktrees whether an identical file is already presen
Ted Zlatanov writes:
> - As in C (see above), we avoid using braces unnecessarily (but Perl
>forces braces around if/unless/else/foreach blocks, so this is not
>always possible).
Is it ever (as opposed to "not always") possible to omit braces?
It sounds as if we encourage the use of st
Ted Zlatanov writes:
> None of these are a big deal, and Michal said he's working on libifying
> this anyhow:
>
> - making 'fill' a special operation is weird
Well, 'fill' is the only operation that mutates the credential structure
(i.e. the only one for which "git credential" emits an output to
Michael J Gruber writes:
> When a command is supposed to use textconv filters (by default or with
> "--textconv") and none are configured then the blob is output without
> conversion; the only exception to this rule is "cat-file --textconv".
I am of two minds. Because cat-file is mostly a low-l
Michael J Gruber writes:
> Currently, "diff" and "cat-file" for blobs obey "--textconv" options
> (with the former defaulting to "--textconv" and the latter to
> "--no-textconv") whereas "show" does not obey this option, even though
> it takes diff options.
>
> Make "show" on blobs behave like "d
The parts for "grep" in the series makes tons of sense to me. I am
not yet convinced about the other two, though.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordom
On Wed, 06 Feb 2013 17:41:01 +0100 Matthieu Moy
wrote:
MM> Ted Zlatanov writes:
>> - sort the output tokens (after 'url' is extracted) so the output is
>> consistent and testable
MM> Why not, if you want to use the output of credential_write in tests. But
MM> credential_write is essentially
On 6 February 2013 17:29, Junio C Hamano wrote:
> Ted Zlatanov writes:
>
>> - As in C (see above), we avoid using braces unnecessarily (but Perl
>>forces braces around if/unless/else/foreach blocks, so this is not
>>always possible).
>
> Is it ever (as opposed to "not always") possible t
Update the coding guidelines for Perl 5.
Signed-off-by: Ted Zlatanov
---
Documentation/CodingGuidelines | 44
1 files changed, 44 insertions(+), 0 deletions(-)
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 1d7de5f..
On Wed, 06 Feb 2013 08:29:30 -0800 Junio C Hamano wrote:
JCH> Is it ever (as opposed to "not always") possible to omit braces?
Oh yes! Not that I recommend it, and I'm not even going to touch on
Perl Golf :)
JCH> It sounds as if we encourage the use of statement modifiers, which
JCH> certainl
On Wed, 6 Feb 2013 18:45:56 +0100 demerphq wrote:
d> So if you objective is maintainability I would just ban "unless" outright.
Please consider me opposed to such a ban.
Ted
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
Am 06.02.2013 16:57, schrieb R. Diez:
> I would like to start gitk, select with the mouse 2
> revisions of some file and then compare them, hopefully with an external
> diff tool, very much like I am used to with WinCVS.
>
> The closest I
> got is to start gitk with a filename as an argument, i
perl.mak uses relative path, which is OK when called from the toplevel,
but won't be anymore if one includes it from elsewhere. It is now
possible to include the file using:
GIT_ROOT_DIR=
include $(GIT_ROOT_DIR)/perl.mak
Signed-off-by: Matthieu Moy
---
perl.mak | 11 +++
1 file changed,
The final goal is to make it easy to write Git commands in perl in the
contrib/ directory. It is currently possible to do so, but without the
benefits of Git's Makefile: adapt first line with $(PERL_PATH),
hardcode the path to Git.pm, ...
We make the perl-related part of the Makefile available fro
Similarly to the extraction of perl-related code in perl.mak, we extract
general default configuration from the Makefile to make it available from
directories other than the toplevel.
This is required to make perl.mak usable because it requires $(pathsep)
to be set.
Signed-off-by: Matthieu Moy
-
The very final goal is to be able to move painlessly (credential) code
from git-remote-mediawiki to Git.pm, but then it's nice for the user
to be able to say just "cd contrib/mw-to-git && make install" and let
the Makefile set perl's library path just like other Git commands
written in perl.
This
The configuration of the install directory is not reused from the
toplevel Makefile: we assume Git is already built, hence just call
"git --exec-path". This avoids too much surgery in the toplevel Makefile.
git-remote-mediawiki.perl can now "use Git;".
Signed-off-by: Matthieu Moy
---
contrib/mw
demerphq writes:
> As you mention below statement modifiers have their place. For instance
>
> next if $whatever;
>
> Is considered preferable to
>
> if ($whatever) {
> next;
> }
>
> Similarly
>
> open my $fh, ">", $filename
>or die "Failed to open '$filename': $!";
>
> Is considered pref
Ted Zlatanov writes:
> On Wed, 06 Feb 2013 08:29:30 -0800 Junio C Hamano wrote:
>
> JCH> Is it ever (as opposed to "not always") possible to omit braces?
>
> Oh yes! Not that I recommend it, and I'm not even going to touch on
> Perl Golf :)
>
> JCH> It sounds as if we encourage the use of stat
On 6 February 2013 19:14, Junio C Hamano wrote:
> demerphq writes:
>
>> As you mention below statement modifiers have their place. For instance
>>
>> next if $whatever;
>>
>> Is considered preferable to
>>
>> if ($whatever) {
>> next;
>> }
>>
>> Similarly
>>
>> open my $fh, ">", $filename
>>
On 6 February 2013 19:05, Ted Zlatanov wrote:
> On Wed, 06 Feb 2013 08:29:30 -0800 Junio C Hamano wrote:
>
> JCH> Is it ever (as opposed to "not always") possible to omit braces?
>
> Oh yes! Not that I recommend it, and I'm not even going to touch on
> Perl Golf :)
I think you are wrong. Can yo
On Wed, 06 Feb 2013 10:16:21 -0800 Junio C Hamano wrote:
JCH> I'd suggest to just drop that "try to write without braces" entirely.
OK, I'll do it on the reroll, or you can just make the change directly.
I agree it was not going anywhere :)
Ted
diff --git a/Documentation/CodingGuidelines b/D
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.
As usual, this cycle is expected to last for 8 to 10 weeks, with a
preview -rc0 sometime in the middle of this month.
You can find the changes
John Keeping writes:
> I would argue that the line should start with "| | ", since it really is
> just a continuation of the same commit.
>
> | |
> | | commit a393ed598e9fb11436f85bd58f1a38c82f2cadb7 (from
> 33e70e70c0173d634826b998bdc304f93c0966b8)
> | | Merge: 2c1e6a3 33e70e7
> | | Author: Ma
On Wed, 6 Feb 2013 19:25:43 +0100 demerphq wrote:
d> On 6 February 2013 19:05, Ted Zlatanov wrote:
>> On Wed, 06 Feb 2013 08:29:30 -0800 Junio C Hamano wrote:
>>
JCH> Is it ever (as opposed to "not always") possible to omit braces?
>>
>> Oh yes! Not that I recommend it, and I'm not even goi
On 6 February 2013 19:35, Ted Zlatanov wrote:
> On Wed, 6 Feb 2013 19:25:43 +0100 demerphq wrote:
>
> d> On 6 February 2013 19:05, Ted Zlatanov wrote:
>>> On Wed, 06 Feb 2013 08:29:30 -0800 Junio C Hamano wrote:
>>>
> JCH> Is it ever (as opposed to "not always") possible to omit braces?
>>>
>>>
On Wed, 6 Feb 2013 19:44:16 +0100 demerphq wrote:
d> Ah ok. Right, at a low level:
d> if (condition) { do_this() }
d> is identical to
d> condition && do_this();
d> IOW, Perl allows logical operators to act as control flow statements.
d> I hope your document include something that says that
Duy Nguyen writes:
> On Tue, Feb 5, 2013 at 5:29 PM, Michael Haggerty wrote:
>> Hiderefs creates a "dark" corner of a remote git repo that can hold
>> arbitrary content that is impossible for anybody to discover but
>> nevertheless possible for anybody to download (if they know the name of
>> a
Am 06.02.2013 19:29, schrieb Junio C Hamano:
> * jl/submodule-deinit (2013-02-04) 1 commit
> - submodule: add 'deinit' command
>
> There was no Porcelain way to say "I no longer am interested in
> this submodule", once you express your interest in a submodule with
> "submodule init". "submodu
Ted Zlatanov writes:
> "Make your code readable and sensible, and don't try to be clever."
>
> But this is good C and shell advice too,...
Sounds sensible.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
Jens Lehmann writes:
> Am 06.02.2013 19:29, schrieb Junio C Hamano:
>> * jl/submodule-deinit (2013-02-04) 1 commit
>> - submodule: add 'deinit' command
>>
>> There was no Porcelain way to say "I no longer am interested in
>> this submodule", once you express your interest in a submodule with
Junio C Hamano wrote:
> Duy Nguyen writes:
>> On Tue, Feb 5, 2013 at 5:29 PM, Michael Haggerty
>> wrote:
>>> Hiderefs creates a "dark" corner of a remote git repo
[...]
>> Or you can think hiderefs is the first step to addressing the
>> initial ref advertisment problem. The series says hidden
Update the coding guidelines for Perl 5.
Signed-off-by: Ted Zlatanov
---
Changes since PATCHv1:
- removed brace guidelines
- add "don't try to be clever" at beginning
Documentation/CodingGuidelines | 42
1 files changed, 42 insertions(+), 0 deletions(-
Michael Haggerty wrote:
> Scenario 1: Some providers junk up their users' repositories with
> content that is not created by the repository's owner and that the owner
> doesn't want to appear to vouch for (e.g., GitHub pull requests). These
> references might sometimes be useful to fetch, singly
On Wed, Feb 06, 2013 at 07:33:08PM +0100, Matthieu Moy wrote:
> John Keeping writes:
>
> > I would argue that the line should start with "| | ", since it really is
> > just a continuation of the same commit.
> >
> > | |
> > | | commit a393ed598e9fb11436f85bd58f1a38c82f2cadb7 (from
> > 33e70e70c
Am 2013-02-06 10:34, schrieb Erik Faye-Lund:
On Sun, Jan 27, 2013 at 3:57 PM, Torsten Bögershausen wrote:
t0070 and t1301 fail when running the test suite under cygwin.
Skip the failing tests by unsetting POSIXPERM.
But is this the real reason? I thought Cygwin implemented POSIX permissions.
From: Michal Nazarewicz
As discussed on the list, adding git-credential interface to Git.pm
(sort of copied from git-remote-mediawiki) and making git-send-email
use it.
I see git-remote-mediawiki does not have “use Git” so I did not touch
it. On top of that I'd have no way to tests the changes
On Wed, Feb 06 2013, Michal Nazarewicz wrote:
> As discussed on the list, adding git-credential interface to Git.pm
> (sort of copied from git-remote-mediawiki) and making git-send-email
> use it.
>
> I see git-remote-mediawiki does not have “use Git” so I did not touch
> it. On top of that I'd ha
Max Horn writes:
> static int ident_is_sufficient(int user_ident_explicitly_given)
> {
> #ifndef WINDOWS
> return (user_ident_explicitly_given & IDENT_MAIL_GIVEN);
> #else
> return (user_ident_explicitly_given == IDENT_ALL_GIVEN);
> #endif
> }
>
>
> According to git blame, this was in
From: Michal Nazarewicz
As discussed on the list, adding git-credential interface to Git.pm
(sort of copied from git-remote-mediawiki) and making git-send-email
use it.
I see git-remote-mediawiki does not have “use Git” so I did not touch
it. On top of that I'd have no way to tests the changes
From: Michal Nazarewicz
The documentation of command_close_bidi_pipe() claims that it can
be called as a method, but it does not check whether the first
argument is $self or not assuming the latter. Using _maybe_self()
fixes this.
Signed-off-by: Michal Nazarewicz
---
perl/Git.pm | 2 +-
1 fil
From: Michal Nazarewicz
The command_close_bidi_pipe() function will insist on closing both
input and output pipes returned by command_bidi_pipe(). With this
change it is possible to close one of the pipes in advance and
pass undef as an argument.
This allows for something like:
my ($pid, $in
From: Michal Nazarewicz
Add a credential() function which is an interface to the
git credential command.
Signed-off-by: Michal Nazarewicz
---
perl/Git.pm | 112 +++-
1 file changed, 111 insertions(+), 1 deletion(-)
diff --git a/perl/Git.
From: Michal Nazarewicz
If smtp_user is provided but smtp_pass is not, instead of prompting
for password, make git-send-email use git credential command
instead.
Signed-off-by: Michal Nazarewicz
---
Documentation/git-send-email.txt | 4 +--
git-send-email.perl | 59 ++
Junio C Hamano writes:
> I suspect somebody from the Windows camp saw a patch I posted
> without the ifdef, noticed that there is a problem to expect
> IDENT_NAME_GIVEN to be set on Windows for some reason, and resulted
> in a reroll of the function in that shape.
>
> I didn't find anything in th
Junio C Hamano writes:
> Junio C Hamano writes:
>
>> I suspect somebody from the Windows camp saw a patch I posted
>> without the ifdef, noticed that there is a problem to expect
>> IDENT_NAME_GIVEN to be set on Windows for some reason, and resulted
>> in a reroll of the function in that shape.
Michal Nazarewicz writes:
> On second thought, give me a moment, ;) I've just discovered a bug
> preventing git-send-email from mailing a patchset.
I somehow found this highly amusing.
I wish all the bugs are like that: if your series is buggy, some
parts of the system prevents you from sending
With "git submodule init" the user is able to tell git he cares about one
or more submodules and wants to have it populated on the next call to "git
submodule update". But currently there is no easy way he could tell git he
does not care about a submodule anymore and wants to get rid of his local
w
Am 05.02.2013 11:32, schrieb Lingcha X:
> As we all know, git provides `submodule add , init, update, sync, sumary,
> foreach, status`, but where is `submodule remove`?
>
> will
> I not delete one of them sometime in the future? Although most people
> will not use submodule or one who uses it c
On 02/06/2013 08:17 PM, Junio C Hamano wrote:
> Duy Nguyen writes:
>
>> On Tue, Feb 5, 2013 at 5:29 PM, Michael Haggerty
>> wrote:
>>> Hiderefs creates a "dark" corner of a remote git repo that can hold
>>> arbitrary content that is impossible for anybody to discover but
>>> nevertheless possib
On Wed, Feb 06, 2013 at 10:58:13AM -0500, Ted Zlatanov wrote:
> MM> I don't know about the netrc credential helper, but I guess that's
> MM> another layer. The git-remote-mediawiki code is the code to call the
> MM> credential C API, that in turn may (or may not) call a credential
> MM> helper.
>
Default values for *plink can be set using PuTTY. If a user makes
telnet the default in PuTTY this breaks ssh clones in git.
Since git clones of the type user@host:path use ssh, tell *plink
to use ssh and override PuTTY defaults for the protocol to use.
Signed-off-by: Sven Strickroth
---
connec
On Wed, Feb 06, 2013 at 04:08:50PM +0100, Michael J Gruber wrote:
> diff --git a/builtin/log.c b/builtin/log.c
> index 8f0b2e8..f83870d 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -402,10 +402,28 @@ static void show_tagger(char *buf, int len, struct
> rev_info *rev)
> strbuf_rel
On 02/06/2013 08:55 PM, Jonathan Nieder wrote:
> Michael Haggerty wrote:
> [...]
>> But now every time I do a "gitk --all" or "git log --decorate", the
>> output is cluttered with all of his references (most of which are just
>> old versions of references from the upstream repository that we both
>
On Wed, Feb 06, 2013 at 08:53:52AM -0800, Junio C Hamano wrote:
> Michael J Gruber writes:
>
> > Currently, "diff" and "cat-file" for blobs obey "--textconv" options
> > (with the former defaulting to "--textconv" and the latter to
> > "--no-textconv") whereas "show" does not obey this option, e
Michael Haggerty writes:
> On 02/06/2013 08:17 PM, Junio C Hamano wrote:
> ...
>
> Yes, the first three patches sound much more reasonable if this is the
> goal.
> ...
> I think that a more useful interim solution would be to make it easy to
> have two URLs accessing a single git repository, with
On Wed, Feb 06, 2013 at 04:08:51PM +0100, Michael J Gruber wrote:
> When a command is supposed to use textconv filters (by default or with
> "--textconv") and none are configured then the blob is output without
> conversion; the only exception to this rule is "cat-file --textconv".
>
> Make it be
On Wed, Feb 06, 2013 at 04:08:52PM +0100, Michael J Gruber wrote:
> From: Jeff King
>
> Recently and not so recently, we made sure that log/grep type operations
> use textconv filters when a userfacing diff would do the same:
>
> ef90ab6 (pickaxe: use textconv for -S counting, 2012-10-28)
> b1c
Jeff King writes:
> Which made me wonder: what happens with:
>
> git cat-file --textconv HEAD
>
> It looks like we die just before textconv-ing, because we have no
> obj_context.path. But that is also unlike all of the other --textconv
> switches, which mean "turn on textconv if you are showing
On Wed, Feb 6, 2013 at 8:17 PM, Junio C Hamano wrote:
Maybe this should be split up into a different thread, but:
> The upload-pack-2 service sits on a port different from today's
> [...].
I think there's a simpler way to do this, which is that:
* New clients supporting v2 of the protocol sen
On Wed, Feb 06, 2013 at 04:08:53PM +0100, Michael J Gruber wrote:
> - add_object_array(object, arg, &list);
> + add_object_array_with_context(object, arg, &list,
> xmemdupz(&oc, sizeof(struct object_context)));
If we go this route, this new _with_context v
On Wed, Feb 06, 2013 at 02:23:36PM -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> > Which made me wonder: what happens with:
> >
> > git cat-file --textconv HEAD
> >
> > It looks like we die just before textconv-ing, because we have no
> > obj_context.path. But that is also unlike all of
On Wed, Feb 06, 2013 at 07:56:08AM -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> > Is it worth having a strbuf_set* family of functions to match the
> > strbuf_add*? We seem to have these sorts of errors with strbuf from time
> > to time, and I wonder if that would make it easier (and mor
On Wed, Feb 06, 2013 at 11:17:06AM -0800, Junio C Hamano wrote:
> Let me help unconfuse this thread.
>
> I think the series as 8-patch series was poorly presented, and
> separating it into two will help understanding what they are about.
>
> The first three:
>
> upload-pack: share more code
>
On Wed, Feb 06, 2013 at 09:47:04PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz
>
> The command_close_bidi_pipe() function will insist on closing both
> input and output pipes returned by command_bidi_pipe(). With this
> change it is possible to close one of the pipes in advance an
On Wed, 6 Feb 2013 16:57:24 -0500 Jeff King wrote:
JK> On Wed, Feb 06, 2013 at 10:58:13AM -0500, Ted Zlatanov wrote:
MM> I don't know about the netrc credential helper, but I guess that's
MM> another layer. The git-remote-mediawiki code is the code to call the
MM> credential C API, that in turn
On Wed, Feb 06, 2013 at 09:47:05PM +0100, Michal Nazarewicz wrote:
> +sub _credential_read {
> + my %credential;
> + my ($reader, $op) = (@_);
> + while (<$reader>) {
> + chomp;
> + my ($key, $value) = /([^=]*)=(.*)/;
Empty keys are not valid. Can we make this:
On Wed, Feb 06, 2013 at 09:47:06PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz
>
> If smtp_user is provided but smtp_pass is not, instead of prompting
> for password, make git-send-email use git credential command
> instead.
>
> Signed-off-by: Michal Nazarewicz
> ---
> Documenta
On Wed, Feb 06, 2013 at 10:58:49PM +0100, Sven Strickroth wrote:
> Default values for *plink can be set using PuTTY. If a user makes
> telnet the default in PuTTY this breaks ssh clones in git.
>
> Since git clones of the type user@host:path use ssh, tell *plink
> to use ssh and override PuTTY de
Jeff King writes:
> And stating it that way makes it clear that there may be other missing
> steps (3 and up) to apply other gitattributes. For example, should "git
> show $blob" respect crlf attributes? Smudge filters?
Yeah, I think applying these when path is availble may make sense.
Are we g
1 - 100 of 111 matches
Mail list logo