(*) that the
...
* [ew: fixed in Subversion r1553376 as noted by Jonathan Nieder]
Cc: Benjamin Pabst benjamin.pabs...@gmail.com
Cc: Eric Wong normalper...@yhbt.net
Cc: Jonathan Nieder jrnie...@gmail.com
No need for these lines --- the mail header already keeps track of who
is being cc-ed
manjian2...@gmail.com wrote:
From: linzj li...@ucweb.com
I am trying to improve git svn's performance according to some
profiling data.As the data showed,_rev_list subroutine and rebuild
subroutine are consuming a large proportion of time.So I improve
_rev_list's performance by
manjian2...@gmail.com wrote:
* perl/Git/SVN.pm
Modified according to Eric Wong normalper...@yhbt.net
Hi, I'm interested in this. How much did performance improve by
(and how many revisions is the repository)
Our svn server are built in a LAN,15152 revisions.Not optimized
git-svn used
.
Signed-off-by: lin zuojian manjian2...@gmail.com
Thanks!
Signed-off-by: Eric Wong normalper...@yhbt.net
Pushed for Junio.
The following changes since commit d9bb4be53bc5185244b4be9860562a012803bacb:
Merge tag 'gitgui-0.19.0' of http://repo.or.cz/r/git-gui (2014-01-21 13:16:17
-0800
Brilliantov Kirill Vladimirovich brillian...@inbox.ru wrote:
Signed-off-by: Brilliantov Kirill Vladimirovich brillian...@inbox.ru
---
git-send-email.perl | 18 ++
1 file changed, 18 insertions(+)
Some documentation references to .mailrc and its format would be nice.
---
Brilliantov Kirill Vladimirovich brillian...@inbox.ru wrote:
On 2014-01-25 22:37:21, Eric Wong wrote:
Brilliantov Kirill Vladimirovich brillian...@inbox.ru wrote:
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -28,6 +28,7 @@ use File::Temp qw/ tempdir tempfile /;
use File
Elia Pinto gitter.spi...@gmail.com wrote:
The Git CodingGuidelines prefer the $( ... ) construct for command
substitution instead of using the back-quotes, or grave accents (`..`).
I did not check very closely, but for the git-svn tests:
Acked-by: Eric Wong normalper...@yhbt.net
Thanks
Johan Herland jo...@herland.net wrote:
--- a/Documentation/git-svn.txt
+++ b/Documentation/git-svn.txt
@@ -86,14 +86,7 @@ COMMANDS
(refs/remotes/$remote/*). Setting a prefix is also useful
if you wish to track multiple projects that share a common
repository.
-+
-NOTE: In
Johan Herland jo...@herland.net wrote:
Feel free to add/squash this on top.
Thanks! Squashed and pushed.
The following changes since commit cc291953df19aa4a97bee3590e708dc1fc557500:
Git 2.0-rc0 (2014-04-18 11:21:43 -0700)
are available in the git repository at:
Thanks! I still haven't gotten around to looking at svn:mergeinfo
things, but this passes tests so I'm inclined to merge this unless
somebody disagrees.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Jakob Stoklund Olesen stokl...@2pi.dk wrote:
Subversion can put mergeinfo on any sub-directory to track cherry-picks.
Since cherry-picks are not represented explicitly in git, git-svn should
just ignore it.
Hi, was git-svn trying to track cherry-picks as merge before?
This changes behavior a
Piotr Krukowiecki piotr.krukowie...@gmail.com wrote:
On Mon, Apr 28, 2014 at 9:26 PM, Aaron Laws dartm...@gmail.com wrote:
The way I understand it, when `git svn dcommit` is run, new commits
are created (A' is created from A adding SVN information), then the
current branch is moved to point
Users may already store sensitive data such as imap.pass in
.git/config; making the file world-readable when git config
is called to edit means their password would be compromised
on a shared system.
Signed-off-by: Eric Wong normalper...@yhbt.net
---
config.c | 7 +++
t/t1300
Users may already store sensitive data such as imap.pass in
.git/config; making the file world-readable when git config
is called to edit means their password would be compromised
on a shared system.
[v2: updated for section renames, as noted by Junio]
Signed-off-by: Eric Wong normalper
the git repository, the following
document describes it:
http://ssoma.public-inbox.org/ssoma_repository.txt
Thanks for reading this far!
--
Eric Wong
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Felipe Contreras felipe.contre...@gmail.com wrote:
No updates since 2010, and no tests.
Who benefits from this removal? Is this causing a maintenance
burden for Junio?
Plus, foreign SCM tools should live out-of-tree anyway.
Even if so, there ought to be a transitionary period in case there
Felipe Contreras felipe.contre...@gmail.com wrote:
Eric Wong wrote:
Felipe Contreras felipe.contre...@gmail.com wrote:
No updates since 2010, and no tests.
Who benefits from this removal? Is this causing a maintenance
burden for Junio?
It is cruft that nobody uses and we
time to
retrieve them. I've forgotten how to use tla to get a public repo,
even.
Eric Wong wrote:
No, I am not convinced existing foreign SCM tools should move
out-of-tree. Perhaps something like the following would be helpful:
Tell that to Junio.
If tools like git-remote-hg with tests
Thomas Adam tho...@xteddy.org wrote:
I think I speak for everyone when I say: fuck off.
I wouldn't put it so harshly...
Felipe: I suggest you take a long vacation away from development.
Whatever good you may be able to contribute today is drowned out by your
behavior. The projects you are
Patrick Reynolds patrick.reyno...@github.com wrote:
But in the real world, several real potential callers, including
Perl, Apache, and Unicorn, sometimes spawn subprocesses with SIGPIPE
ignored.
s/Unicorn/Ruby/
But unicorn would ignore SIGPIPE it if Ruby did not; relying on SIGPIPE
while
Lawrence Velázquez v...@larryv.me wrote:
Git no longer seems to use these flags or their associated config keys;
when they are present, git-svn outputs a message indicating that they
are being ignored.
Signed-off-by: Lawrence Velázquez v...@larryv.me
Thanks, will queue.
Signed-off-by: Eric
to Andrej Manduch amand...@gmail.com for originally
noticing the issue and fixing my original version of this to handle
more corner cases such as /path/to/top/../top and
/path/to/top/../top/file as shown in the new test cases.
Signed-off-by: Andrej Manduch amand...@gmail.com
Signed-off-by: Eric Wong
Allow -B and -A to act as short aliases for --before and --after
options respectively. This reduces typing and hopefully allows
reuse of muscle memory for grep(1) users.
Signed-off-by: Eric Wong normalper...@yhbt.net
---
Will push to git://bogomips.org/git-svn.git
Documentation/git-svn.txt
= canonicalize_path($cmd_dir_prefix . $path);
--8---
From: Eric Wong normalper...@yhbt.net
Subject: [PATCH v3] git svn: info: correctly handle absolute path args
Calling git svn info $(pwd) would hit:
Reading from filehandle failed at ...
errors due to improper prefixing
On my Debian 7 system, this gives annoying warnings when the output
of git svn commands are redirected:
Unable to get Terminal Size. The TIOCGWINSZ ioctl didn't work.
The COLUMNS and LINES environment variables didn't work. The
resize program didn't work.
Signed-off-by: Eric Wong
Eric Wong normalper...@yhbt.net wrote:
On my Debian 7 system, this gives annoying warnings when the output
s/gives/fixes/
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
://bogomips.org/git-svn.git master
for you to fetch changes up to 30d45f798d1a4b14759cd977b68be4476d66ea17:
git-svn: delay term initialization (2014-09-14 08:08:54 +)
Eric Wong (3):
git svn: info: correctly handle absolute path
Hin-Tak Leung ht...@users.sourceforge.net wrote:
(I am not on the list - please CC)
Done, it is standard practice for git :)
Thanks for git-svn - I use it instead of subversion itself for many years now.
Just thought I'd ask/report a few issues I noticed for some time
now, of tracking
Eric Wong normalper...@yhbt.net wrote:
Jakob sent some patches a few months ago which seem to address the
issue. Unfortunately we forgot about them :x
Hin-Tak: have you tried Jakob's patches? I've taken another look,
signed-off and pushed to my master.
Can you take a look at the following
Fabian Schmied fabian.schm...@gmail.com wrote:
Hi,
I'm currently migrating an SVN repository to Git using git-svn (Git
for Windows 1.8.3-preview20130601), and I'm experiencing severe
performance problems with git svn fetch. Commits to the SVN trunk
are fetched very fast (a few seconds or so
Robert Dailey rcdailey.li...@gmail.com wrote:
Hey guys,
I'm using MSMTP to define 2 accounts: Work email and personal email.
If I send patches via email through Git at work, I want to use my work
SMTP server and account information. Likewise at home for personal
projects, I want to use my
Eric Wong normalper...@yhbt.net wrote:
Hin-Tak (Cc-ed) reported good improvements with them, but also
a large memory increase:
This might reduce the pathname and internal hash overheads:
8---
From: Eric Wong normalper...@yhbt.net
Date: Sun, 19 Oct
Eric Wong normalper...@yhbt.net wrote:
This reduces hash lookups for looking up cache data and will
simplify tying data to disk in the next commit.
I considered the following, but GDBM might not be readily available on
non-POSIX platforms. I think the other problem is the existing caches
smaller, too:
--- 8 -
From: Eric Wong normalper...@yhbt.net
Subject: [PATCH] git-svn: reduce check_cherry_pick cache overhead
We do not need to store entire lists of commits, only the
number of incomplete and the first commit for reference.
This reduces
the below? (on top of your original two patches)
Pushed to my master @ git://bogomips.org/git-svn.git
Eric Wong (2):
git-svn: reduce check_cherry_pick cache overhead
git-svn: cache only mergeinfo revisions
Jakob Stoklund Olesen (2):
git-svn: only look
...@users.sourceforge.net
Thanks, minor grammar+spelling fix to the commit message:
Advertise that the svn-remote.name.pushurl config key allows specifying
the commit URL for the entire SVN repository in the documentation of the
git svn dcommit command.
Signed-off-by: Eric Wong normalper...@yhbt.net
Tommaso Colombo tommaso.colo...@outlook.com wrote:
When populating svn:mergeinfo, git-svn merge checks if the merge parent
of the merged branch is under the same root as the git-svn repository.
This was implemented comparing $gs-repos_root with the return value of
of cmt_metadata for the merge
-8--
Signed-off-by: Eric Wong normalper...@yhbt.net
---
Pushed to master of git://bogomips.org/git-svn
However, memory usage still seems to grow infinitely even in this simple
fetch case, so are other memory leaks.
perl/Git/SVN/Ra.pm | 6 ++
1 file
:
8-
From: Eric Wong normalper...@yhbt.net
Date: Tue, 21 Oct 2014 06:23:22 +
Subject: [PATCH] git-svn: remove mergeinfo rev caching
This should further reduce memory usage from the new mergeinfo
speedups without hurting performance too
Eric Wong normalper...@yhbt.net wrote:
+ SVN::Core-gpool-clear;
Unfortunately, SVN::Core-gpool is not available in older SVN,
but I'm cooking a better patch which saves even more memory.
--
To unsubscribe from this list: send the line unsubscribe git in
the body
nr=1
while test $nr -gt 0
do
echo $nr a
svn commit -q -m A
nr=$((nr - 1))
done
echo repository created in $repo
-8--
Signed-off-by: Eric Wong normalper...@yhbt.net
---
Eric Wong normalper...@yhbt.net wrote
Hin-Tak Leung ht...@users.sourceforge.net wrote:
I keep tabs of a particular svn repository over many years
and run git svn fetch --all every few days. So that's the old clone.
Since this discussion started, I made a new one with git 2.1.0 patched
with the first two patches below, a couple of
Hin-Tak Leung ht...@users.sourceforge.net wrote:
Comparing trunk of old and new, I see one difference - One short
commit message is missing in the *old* (the Add checkPoFiles etc. part)
and so all the sha1 afterwards differed. Is that an old bug that's fixed
and therefore I should throw away
Hin-Tak Leung ht...@users.sourceforge.net wrote:
the old didn't missing a revision - just a revision 'message' - blank
instead of 3 words, above the git svn id. I supppse it is possible
some power problem or etc caused this. I'll check the other branches
as well, and possibly clone again to be
This override was probably never necessary, but most likely a no-op
as it does not appear to do anything in SVN::Ra itself.
Signed-off-by: Eric Wong normalper...@yhbt.net
---
perl/Git/SVN/Ra.pm | 4
1 file changed, 4 deletions(-)
diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
index
There is no reason to keep entries in the %revs hash after we're
done processing a revision, so allow entries become freed as
processing continues.
Signed-off-by: Eric Wong normalper...@yhbt.net
---
perl/Git/SVN/Ra.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/perl/Git
Jakob to improve svn:mergeinfo
performance along with some followup patches to reduce memory
use. However memory bloat is still a problem.
Currently in my master branch of git://bogomips.org/git-svn
Eric Wong (4):
git-svn: reduce check_cherry_pick cache overhead
git-svn: cache only
Hin-Tak Leung ht...@users.sourceforge.net wrote:
On Sat, Oct 25, 2014 00:34 BST Eric Wong wrote:
Hin-Tak Leung ht...@users.sourceforge.net wrote:
0006-git-svn-clear-global-SVN-pool-between-get_log-invoca.patch
0006 is insufficient and incompatible with older SVN.
I pushed git-svn
Hin-Tak Leung ht...@users.sourceforge.net wrote:
btw, git svn seems to disallow single word commit messages (or is it a
svn config?). i found that i could not do git svn dcommit, when i had
merely did git commit -m 'typos', for example, for an svn repo i have
write access to. (I don't have
-project.org/R
[2] file:// repos causes libsvn to use more memory internally
Signed-off-by: Eric Wong normalper...@yhbt.net
Cc: Hin-Tak Leung ht...@users.sourceforge.net
---
This patch is in my less-memo branch of bogomips.org/git-svn.git
Info here:
(not intended as a pull request for Junio, yet
Hin-Tak Leung ht...@users.sourceforge.net wrote:
On Sat, Oct 25, 2014 00:34 BST Eric Wong wrote:
0006 is insufficient and incompatible with older SVN.
I pushed git-svn: reload RA every log-window-size
(commit dfa72fdb96befbd790f623bb2909a347176753c2) instead
which saves much more memory
Eric Wong normalper...@yhbt.net wrote:
Which SVN version are you using? I'm cloning (currently on r373xx)
https://svn.r-project.org/R using --stdlayout and
unable to see memory growth of the git-svn Perl process beyond 40M
(on a 32-bit system).
git-svn hit 45M and took 11:44 to finish. My
Hin-Tak Leung ht...@users.sourceforge.net wrote:
To compare the old clone with the new, I did:
git branch -r | sort | xargs -n 1 git log --decorate=full -n 1
It turned out other than the empty vs 3 word commit messages
about two years ago on trunk (which are inherited in all the newer
Hin-Tak Leung ht...@users.sourceforge.net wrote:
Eric Wong normalper...@yhbt.net wrote:
Which SVN version are you using? I'm cloning (currently on r373xx)
https://svn.r-project.org/R using --stdlayout and
unable to see memory growth of the git-svn Perl process beyond 40M
(on a 32-bit
Hin-Tak Leung ht...@users.sourceforge.net wrote:
Hi, I patched my system git with the recent git-svn improvements, and just use
it for general use; so theses are the patches, against 2.1.0.
0001-git-svn-only-look-at-the-new-parts-of-svn-mergeinfo.patch
This should help me track down errors in git-svn more easily:
write .git/Git_XX: Bad file descriptor
at /usr/lib/perl5/SVN/Ra.pm line 623
Signed-off-by: Eric Wong normalper...@yhbt.net
---
Not sure you want to take this separately or in a git-svn pull.
Still working
Memoizing these initialization functions saves some memory for
long fetches which require scanning many unwanted revisions
before any wanted revisions happen.
Signed-off-by: Eric Wong normalper...@yhbt.net
---
perl/Git/SVN/Ra.pm | 63 +++---
1 file
Hin-Tak Leung ht...@users.sourceforge.net wrote:
On Tue, 28/10/14, Eric Wong normalper...@yhbt.net wrote:
So both merges
are correct, but we lose one, and gain one?
I'll try to check more closely tomorrow.
Can you point out
the exact revisions in the
R repo? Thanks
Hin-Tak Leung ht...@users.sourceforge.net wrote:
Argh, sorry. I thought I included the info but I didn't.
Thanks. I'll try a different version of svn later.
What do you think were missing in my e-mails?
I was skimming and missed the part about Debian packages :)
--
To unsubscribe from this
And minor reformatting while we're in the area.
Signed-off-by: Eric Wong normalper...@yhbt.net
---
perl/Git/SVN.pm | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
index 893b9a8..d9a52a5 100644
--- a/perl/Git/SVN.pm
+++ b/perl/Git/SVN.pm
Neither find_extra_svk_parents or find_extra_svn_parents ever
used the `$ed' parameter.
Signed-off-by: Eric Wong normalper...@yhbt.net
---
perl/Git/SVN.pm | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
index 5f9d469..893b9a8
:
git-svn: add space after W: prefix in warning (2014-10-30 08:31:28 +)
Eric Wong (11):
git-svn: reduce check_cherry_pick cache overhead
git-svn: cache only mergeinfo revisions
git-svn: remove mergeinfo rev caching
without the PerlIO layer knowing about it. This is likely a bug
inside libsvn (1.6.17), as none of the Git.pm or Git::SVN
modules close IOs without the knowledge of the PerlIO layer.
Cc: Kyle J. McKay mack...@gmail.com
Signed-off-by: Eric Wong normalper...@yhbt.net
---
Kyle/Junio: thoughts? I'm
Hin-Tak Leung ht...@users.sourceforge.net wrote:
That's quite straight-forward, I think - except for the recent burst (I am
essentially
adapting the git 2.1.0 release shipped by the upcoming fedora 21 scheduled
for christmas)
I tend to update to the latest fedora release about a week or
Kyle J. McKay mack...@gmail.com wrote:
On Oct 30, 2014, at 15:08, Eric Wong wrote:
For a (currently) unknown reason, Git::SVN::Fetcher::close_file
sometimes triggers Bad file descriptor errors on syswrite when
writing symlink contents on the svn_hash tempfile.
The current IO::Handle::opened
changes up to 9d536cf625cf42b8a8272070e3720325c68f3b48:
git-svn: coerce check_path and get_log args to int (2014-10-30 23:10:57 +)
Eric Wong (12):
git-svn: reduce check_cherry_pick cache overhead
git-svn: cache
...@web172304.mail.ir2.yahoo.com
ref: 1414722617.89476.yahoomailba...@web172305.mail.ir2.yahoo.com
Signed-off-by: Eric Wong normalper...@yhbt.net
Cc: Hin-Tak Leung ht...@users.sourceforge.net
---
This should fix the vbox clone problem. SVN Perl binding
breakage (again :). I shall revert
...@web172304.mail.ir2.yahoo.com
ref: 1414722617.89476.yahoomailba...@web172305.mail.ir2.yahoo.com
Signed-off-by: Eric Wong normalper...@yhbt.net
Cc: Hin-Tak Leung ht...@users.sourceforge.net
---
Sorry, waaay past my bed time. This version doesn't infinite loop
on autoload or older SVN
Eric Wong normalper...@yhbt.net wrote:
Hi Junio, I haven't heard back from Hin-Tak about the last one
(git-svn: coerce check_path and get_log args to int)[1],
but I think it's a harmless defensive patch in case you
want to tag 2.2-rc0 soon.
OK, that coercion patch was pointless and I worked
Eric Wong normalper...@yhbt.net wrote:
This avoids the following failure with normal get_dir on newer
versions of SVN (tested with SVN 1.8.8-1ubuntu3.1):
Incorrect parameters given: Could not convert '%ld' into a number
Filed a bug in Debian since I hit it in sid, too:
http
Hin-Tak Leung ht...@users.sourceforge.net wrote:
On Fri, Oct 31, 2014 19:08 GMT Eric Wong wrote:
Filed a bug in Debian since I hit it in sid, too:
http://bugs.debian.org/767530
Thanks all.
Hmm, but why are you filing at debian? I had the error when i applied
the dev code patches on top
Hin-Tak Leung ht...@users.sourceforge.net wrote:
Tested-by: Hin-Tak Leung ht...@users.sourceforge.net
Okay, this one on top of my git 2.1.0 + 10 recent git svn improvement
patches
allow me to fetch further.
I suspect the problem must be elsewhere though, and this just band-aided
over
Hin-Tak Leung ht...@users.sourceforge.net wrote:
While my 2.10 + 11 patches continue to fetch, where it was stuck, now
it does Couldn't find revmap... - also, the single branch clone is doing
the 'trunk/branches/... thing - are these supposed to happen?
I'm afraid this is a problem with the
Hin-Tak Leung ht...@users.sourceforge.net wrote:
Hmm, I see you are filing the problem against subversion. FWIW,
I am currently using subversion-perl-1.8.10-1.fc20.x86_64 package on fedora
20.
I'll possibly think about filing one under redhat's bugzilla and
let them take it upward too.
This
Jonathan Nieder jrnie...@gmail.com wrote:
(cc-ing Eric Wong, who maintains git-svn and knows both it and
the libsvn perl bindings much better than I do)
I doubt that's the case anymore. I've hardly looked at SVN in many
years, now.
Anyways, if the patches:
1) do not introduce regressions
2
Matthijs Kooijman matth...@stdin.nl wrote:
Hi folks,
any chance this patch can be merged?
It's probably fine. Does anybody else have testing/feedback? I haven't
used git-svn/SVN in years, and I don't use GNOME (nor much GUI).
--
To unsubscribe from this list: send the line unsubscribe git
Edward Rudd ur...@outoforder.cc wrote:
Where is a link to the latest patch? I can give it a quick once-over
with one of my git-svn'ed game ports I'm working on. (due for
launching on the 10th.. WOOHOO!)
http://mid.gmane.org/1371573490-21973-1-git-send-email-matth...@stdin.nl
Thanks!
--
To
happening.
Thanks. Please sign-off your patch.
I am Cc'ing Kyle McKay who apparently had some experience working
with git-svn with newer svn that can only use serf, hoping that we
can get an independent opinion/test just to be sure. Also Cc'ed is
Eric Wong who has been the official git-svn
Peter Baumann waste.mana...@gmx.de wrote:
On Tue, Aug 07, 2012 at 08:45:10PM +, Eric Wong wrote:
Peter Baumann waste.mana...@gmx.de wrote:
+ for my $suffix (qw(yaml db)) {
+ unlink($cache_file.$suffix);
Need to check for unlink() errors
Robert Luberda rob...@debian.org wrote:
Eric Wong wrote:
+ echo PATH=\$PATH\; export PATH $hook
+ echo svnconf=\$svnconf\ $hook
+ cat $hook - 'EOF2'
+ cd work-auto-commits.svn
+ svn up --config-dir $svnconf
Junio C Hamano gits...@pobox.com wrote:
I should have asked this yesterday, but do you mean you want to have
your maint in the upcoming 1.7.12? This does look like a useful
thing to do, but does not seem like a regression fix to me.
Yeah, I wasn't sure what to name it since my master is still
Peter Baumann waste.mana...@gmx.de wrote:
First, let me thank you for your review and your detailed explanation.
I really appreciate it.
You're welcome, Peter. Thanks again for the patch. I've signed-off and
pushed for Junio.
The following changes since commit
Junio C Hamano gits...@pobox.com wrote:
Eric Wong normalper...@yhbt.net writes:
Peter Baumann (1):
git svn: reset invalidates the memoized mergeinfo caches
Robert Luberda (1):
git svn: handle errors and concurrent commits in dcommit
OK, so these two are fit for 1.7.12-rc3
Steven Walter stevenrwal...@gmail.com wrote:
Consider the case where you have trunk, branchA of trunk, and branchB of
branchA. trunk is merged back into branchB, and then branchB is
reintegrated into trunk. The merge of branchB into trunk will have
svn:mergeinfo property references to both
Steven Walter stevenrwal...@gmail.com wrote:
On Sat, Aug 18, 2012 at 3:51 PM, Sam Vilain s...@vilain.net wrote:
On 08/11/2012 10:14 AM, Steven Walter wrote:
---
git-svn.perl |1 -
t/t9164-git-svn-fetch-merge-branch-of-branch2.sh | 53
Junio C Hamano gits...@pobox.com wrote:
Unless you found a reason not to in the meantime, that is. Is what
I have on 'pu' still good, or do you (Eric and/or Michael) have any
updates you'd rather have me pull instead?
No updates, everything is still good.
--
To unsubscribe from this list:
test name,
also eliminate space after to conform to guidelines]
Signed-off-by: Eric Wong normalper...@yhbt.net
---
...n-dcommit-concrrent.sh = t9164-git-svn-dcommit-concurrent.sh} | 8
1 file changed, 4 insertions(+), 4 deletions(-)
rename t/{t9164-git-svn-dcommit-concrrent.sh
Steven Walter stevenrwal...@gmail.com wrote:
Consider the case where you have trunk, branch1 of trunk, and branch2 of
branch1. trunk is merged back into branch2, and then branch2 is
reintegrated into trunk. The merge of branch2 into trunk will have
svn:mergeinfo property references to both
Robert Luberda rob...@debian.org wrote:
Eric Wong wrote:
Oops, I'll push the following out since Junio already merged your
original:
I can see that you haven't pushed the change yet. Maybe it would be a
good idea to fix other style mistakes (extra spaces after redirections,
lack
Robert Luberda rob...@debian.org wrote:
Junio C Hamano wrote:
Eric Wong normalper...@yhbt.net writes:
I think having svn in svn.trimsvnlog twice is redundant and not ideal.
Perhaps just --trim-log and svn.trimlog?
Do we ever want to trim our log when relaying the Git commits back
Ammon Riley ammon.ri...@gmail.com wrote:
Branches passed to 'git-svn init' via the -b/--branches flag
automatically had a /* appended to them. When the branch contained
a fancy glob with a {} pattern, this is incorrect behaviour, and
leads to odd branches being created in the git repository.
Ammon Riley ammon.ri...@gmail.com wrote:
I confess that I'd completely forgot about the {} expansion in bash.
Perhaps a note in the CAVEATS section of the documentation would
be sufficient?
I think so, yes. Can you send a patch for that instead? Thanks.
--
To unsubscribe from this list: send
Jonathan Nieder jrnie...@gmail.com wrote:
Hi,
Michael G Schwern wrote:
On 2012.7.30 12:51 PM, Eric Wong wrote:
Michael G Schwern wrote:
_collapse_dotdot() works better than the existing regex did.
I don't dispute it's better, but it's worth explaining in the commit
message
Jonathan Nieder jrnie...@gmail.com wrote:
Eric Wong wrote:
That said, I'd favor an implementation that split on m{/+} and
collapsed as Michael mentioned.
Sounds sensible. Is canonicalize_path responsible for collapsing
runs of slashes? What should _collapse_dotdot do to
c:/.. or http
Jonathan Nieder jrnie...@gmail.com wrote:
Maybe we can use apr_filepath_merge() to avoid reinventing the wheel?
Ideally, yes. Is there an easy way to access that from Perl? (and
for the older versions of SVN folks people are running).
Perhaps we can expose equivalent functionality in git via
/svnrepo' contains unsupported hostname at \
/home/jrn/src/git-scratch/perl/blib/lib/Git/SVN.pm line 148
With it, the git-svn tests pass again.
Signed-off-by: Jonathan Nieder jrnie...@gmail.com
Thanks for noticing this.
Signed-off-by: Eric Wong normalper...@yhbt.net
and pushed to my master
are sent in a format that modern svn update can handle and
tests t9100.11-13 pass again.
[ew: s,git-svn\.perl,perl/Git/SVN/Editor.pm,g]
Signed-off-by: Jonathan Nieder jrnie...@gmail.com
Signed-off-by: Eric Wong normalper...@yhbt.net
---
perl/Git/SVN/Editor.pm | 25 -
1 file
Jonathan Nieder jrnie...@gmail.com wrote:
Michael J Gruber wrote:
Jonathan Nieder venit, vidit, dixit 09.10.2012 10:41:
Signed-off-by: Jonathan Nieder jrnie...@gmail.com
Tested with Subversion 1.6.18.
Thanks both. Also pushed to master on git://bogomips.org/git-svn.git
(commit
Jonathan Nieder jrnie...@gmail.com wrote:
Eric Wong wrote:
Thanks both. Also pushed to master on git://bogomips.org/git-svn.git
(commit 44bc5ac71fd99f195bf1a3bea63c11139d2d535f)
Jonathan Nieder (2):
git svn: work around SVN 1.7 mishandling of svn:special changes
svn
Jonathan Nieder jrnie...@gmail.com wrote:
Eric Wong wrote:
Jonathan Nieder jrnie...@gmail.com wrote:
-- 8 --
Subject: Git::SVN::Editor::T: pass $deletions to -A and -D
For future reference, it'd be slightly easier for me to apply if you
included the From: (and Date:) headers so I
1 - 100 of 685 matches
Mail list logo
