Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-27 Thread Eric Wong
(*) that the ... * [ew: fixed in Subversion r1553376 as noted by Jonathan Nieder] Cc: Benjamin Pabst benjamin.pabs...@gmail.com Cc: Eric Wong normalper...@yhbt.net Cc: Jonathan Nieder jrnie...@gmail.com No need for these lines --- the mail header already keeps track of who is being cc-ed

Re: [PATCH] improve git svn performance

2014-01-21 Thread Eric Wong
manjian2...@gmail.com wrote: From: linzj li...@ucweb.com I am trying to improve git svn's performance according to some profiling data.As the data showed,_rev_list subroutine and rebuild subroutine are consuming a large proportion of time.So I improve _rev_list's performance by

Re: [PATCH v2] improve git svn performance

2014-01-22 Thread Eric Wong
manjian2...@gmail.com wrote: * perl/Git/SVN.pm Modified according to Eric Wong normalper...@yhbt.net Hi, I'm interested in this. How much did performance improve by (and how many revisions is the repository) Our svn server are built in a LAN,15152 revisions.Not optimized git-svn used

Re: [PATCH v3] git-svn: memoize _rev_list and rebuild

2014-01-22 Thread Eric Wong
. Signed-off-by: lin zuojian manjian2...@gmail.com Thanks! Signed-off-by: Eric Wong normalper...@yhbt.net Pushed for Junio. The following changes since commit d9bb4be53bc5185244b4be9860562a012803bacb: Merge tag 'gitgui-0.19.0' of http://repo.or.cz/r/git-gui (2014-01-21 13:16:17 -0800

Re: [PATCH] Added get sendmail from .mailrc

2014-01-25 Thread Eric Wong
Brilliantov Kirill Vladimirovich brillian...@inbox.ru wrote: Signed-off-by: Brilliantov Kirill Vladimirovich brillian...@inbox.ru --- git-send-email.perl | 18 ++ 1 file changed, 18 insertions(+) Some documentation references to .mailrc and its format would be nice. ---

Re: [PATCH] Added get sendmail from .mailrc

2014-01-26 Thread Eric Wong
Brilliantov Kirill Vladimirovich brillian...@inbox.ru wrote: On 2014-01-25 22:37:21, Eric Wong wrote: Brilliantov Kirill Vladimirovich brillian...@inbox.ru wrote: --- a/git-send-email.perl +++ b/git-send-email.perl @@ -28,6 +28,7 @@ use File::Temp qw/ tempdir tempfile /; use File

Re: [PATCH 099/144] t9101-git-svn-props.sh: use the $( ... ) construct for command substitution

2014-03-29 Thread Eric Wong
Elia Pinto gitter.spi...@gmail.com wrote: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). I did not check very closely, but for the git-svn tests: Acked-by: Eric Wong normalper...@yhbt.net Thanks

Re: [RFC/PATCHv3 3/3] Git 2.0: git svn: Set default --prefix='origin/' if --prefix is not given

2014-04-19 Thread Eric Wong
Johan Herland jo...@herland.net wrote: --- a/Documentation/git-svn.txt +++ b/Documentation/git-svn.txt @@ -86,14 +86,7 @@ COMMANDS (refs/remotes/$remote/*). Setting a prefix is also useful if you wish to track multiple projects that share a common repository. -+ -NOTE: In

Re: [PATCH] git-svn.txt: Retain a description og pre-v2.0 default prefix

2014-04-19 Thread Eric Wong
Johan Herland jo...@herland.net wrote: Feel free to add/squash this on top. Thanks! Squashed and pushed. The following changes since commit cc291953df19aa4a97bee3590e708dc1fc557500: Git 2.0-rc0 (2014-04-18 11:21:43 -0700) are available in the git repository at:

Re: [PATCH 1/2] git-svn: only look at the new parts of svn:mergeinfo

2014-04-22 Thread Eric Wong
Thanks! I still haven't gotten around to looking at svn:mergeinfo things, but this passes tests so I'm inclined to merge this unless somebody disagrees. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/2] git-svn: only look at the root path for svn:mergeinfo

2014-04-22 Thread Eric Wong
Jakob Stoklund Olesen stokl...@2pi.dk wrote: Subversion can put mergeinfo on any sub-directory to track cherry-picks. Since cherry-picks are not represented explicitly in git, git-svn should just ignore it. Hi, was git-svn trying to track cherry-picks as merge before? This changes behavior a

Re: git-svn Rewrites Some Commits, but not All

2014-04-30 Thread Eric Wong
Piotr Krukowiecki piotr.krukowie...@gmail.com wrote: On Mon, Apr 28, 2014 at 9:26 PM, Aaron Laws dartm...@gmail.com wrote: The way I understand it, when `git svn dcommit` is run, new commits are created (A' is created from A adding SVN information), then the current branch is moved to point

[PATCH] config: preserve config file permissions on edits

2014-05-05 Thread Eric Wong
Users may already store sensitive data such as imap.pass in .git/config; making the file world-readable when git config is called to edit means their password would be compromised on a shared system. Signed-off-by: Eric Wong normalper...@yhbt.net --- config.c | 7 +++ t/t1300

[PATCH v2] config: preserve config file permissions on edits

2014-05-05 Thread Eric Wong
Users may already store sensitive data such as imap.pass in .git/config; making the file world-readable when git config is called to edit means their password would be compromised on a shared system. [v2: updated for section renames, as noted by Junio] Signed-off-by: Eric Wong normalper

[ANNOUNCE] ssoma - some sort of mail archiver (using git)

2014-05-07 Thread Eric Wong
the git repository, the following document describes it: http://ssoma.public-inbox.org/ssoma_repository.txt Thanks for reading this far! -- Eric Wong -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v1 1/2] Remove 'git archimport'

2014-05-08 Thread Eric Wong
Felipe Contreras felipe.contre...@gmail.com wrote: No updates since 2010, and no tests. Who benefits from this removal? Is this causing a maintenance burden for Junio? Plus, foreign SCM tools should live out-of-tree anyway. Even if so, there ought to be a transitionary period in case there

Re: [PATCH v1 1/2] Remove 'git archimport'

2014-05-09 Thread Eric Wong
Felipe Contreras felipe.contre...@gmail.com wrote: Eric Wong wrote: Felipe Contreras felipe.contre...@gmail.com wrote: No updates since 2010, and no tests. Who benefits from this removal? Is this causing a maintenance burden for Junio? It is cruft that nobody uses and we

Re: [PATCH v1 1/2] Remove 'git archimport'

2014-05-09 Thread Eric Wong
time to retrieve them. I've forgotten how to use tla to get a public repo, even. Eric Wong wrote: No, I am not convinced existing foreign SCM tools should move out-of-tree. Perhaps something like the following would be helpful: Tell that to Junio. If tools like git-remote-hg with tests

Re: [PATCH v1 1/2] Remove 'git archimport'

2014-05-09 Thread Eric Wong
Thomas Adam tho...@xteddy.org wrote: I think I speak for everyone when I say: fuck off. I wouldn't put it so harshly... Felipe: I suggest you take a long vacation away from development. Whatever good you may be able to contribute today is drowned out by your behavior. The projects you are

Re: [PATCH] unblock and unignore SIGPIPE

2014-08-17 Thread Eric Wong
Patrick Reynolds patrick.reyno...@github.com wrote: But in the real world, several real potential callers, including Perl, Apache, and Unicorn, sometimes spawn subprocesses with SIGPIPE ignored. s/Unicorn/Ruby/ But unicorn would ignore SIGPIPE it if Ruby did not; relying on SIGPIPE while

Re: [PATCH] git-svn.txt: Remove mentions of repack options

2014-09-07 Thread Eric Wong
Lawrence Velázquez v...@larryv.me wrote: Git no longer seems to use these flags or their associated config keys; when they are present, git-svn outputs a message indicating that they are being ignored. Signed-off-by: Lawrence Velázquez v...@larryv.me Thanks, will queue. Signed-off-by: Eric

[PATCH v2] git svn: info: correctly handle absolute path args

2014-09-07 Thread Eric Wong
to Andrej Manduch amand...@gmail.com for originally noticing the issue and fixing my original version of this to handle more corner cases such as /path/to/top/../top and /path/to/top/../top/file as shown in the new test cases. Signed-off-by: Andrej Manduch amand...@gmail.com Signed-off-by: Eric Wong

[PATCH] git svn: find-rev allows short switches for near matches

2014-09-07 Thread Eric Wong
Allow -B and -A to act as short aliases for --before and --after options respectively. This reduces typing and hopefully allows reuse of muscle memory for grep(1) users. Signed-off-by: Eric Wong normalper...@yhbt.net --- Will push to git://bogomips.org/git-svn.git Documentation/git-svn.txt

[PATCH v3] git svn: info: correctly handle absolute path args

2014-09-09 Thread Eric Wong
= canonicalize_path($cmd_dir_prefix . $path); --8--- From: Eric Wong normalper...@yhbt.net Subject: [PATCH v3] git svn: info: correctly handle absolute path args Calling git svn info $(pwd) would hit: Reading from filehandle failed at ... errors due to improper prefixing

[PATCH] git-svn: delay term initialization

2014-09-14 Thread Eric Wong
On my Debian 7 system, this gives annoying warnings when the output of git svn commands are redirected: Unable to get Terminal Size. The TIOCGWINSZ ioctl didn't work. The COLUMNS and LINES environment variables didn't work. The resize program didn't work. Signed-off-by: Eric Wong

Re: [PATCH] git-svn: delay term initialization

2014-09-14 Thread Eric Wong
Eric Wong normalper...@yhbt.net wrote: On my Debian 7 system, this gives annoying warnings when the output s/gives/fixes/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PULL] git svn updates for master

2014-09-14 Thread Eric Wong
://bogomips.org/git-svn.git master for you to fetch changes up to 30d45f798d1a4b14759cd977b68be4476d66ea17: git-svn: delay term initialization (2014-09-14 08:08:54 +) Eric Wong (3): git svn: info: correctly handle absolute path

Re: git svn's performance issue and strange pauses, and other thing

2014-09-19 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: (I am not on the list - please CC) Done, it is standard practice for git :) Thanks for git-svn - I use it instead of subversion itself for many years now. Just thought I'd ask/report a few issues I noticed for some time now, of tracking

Re: git svn's performance issue and strange pauses, and other thing

2014-10-04 Thread Eric Wong
Eric Wong normalper...@yhbt.net wrote: Jakob sent some patches a few months ago which seem to address the issue. Unfortunately we forgot about them :x Hin-Tak: have you tried Jakob's patches? I've taken another look, signed-off and pushed to my master. Can you take a look at the following

Re: git-svn performance

2014-10-18 Thread Eric Wong
Fabian Schmied fabian.schm...@gmail.com wrote: Hi, I'm currently migrating an SVN repository to Git using git-svn (Git for Windows 1.8.3-preview20130601), and I'm experiencing severe performance problems with git svn fetch. Commits to the SVN trunk are fetched very fast (a few seconds or so

Re: Specifying account profile in MSMTP

2014-10-18 Thread Eric Wong
Robert Dailey rcdailey.li...@gmail.com wrote: Hey guys, I'm using MSMTP to define 2 accounts: Work email and personal email. If I send patches via email through Git at work, I want to use my work SMTP server and account information. Likewise at home for personal projects, I want to use my

Re: git-svn performance

2014-10-18 Thread Eric Wong
Eric Wong normalper...@yhbt.net wrote: Hin-Tak (Cc-ed) reported good improvements with them, but also a large memory increase: This might reduce the pathname and internal hash overheads: 8--- From: Eric Wong normalper...@yhbt.net Date: Sun, 19 Oct

Re: git-svn performance

2014-10-18 Thread Eric Wong
Eric Wong normalper...@yhbt.net wrote: This reduces hash lookups for looking up cache data and will simplify tying data to disk in the next commit. I considered the following, but GDBM might not be readily available on non-POSIX platforms. I think the other problem is the existing caches

Re: git svn's performance issue and strange pauses, and other thing

2014-10-18 Thread Eric Wong
smaller, too: --- 8 - From: Eric Wong normalper...@yhbt.net Subject: [PATCH] git-svn: reduce check_cherry_pick cache overhead We do not need to store entire lists of commits, only the number of incomplete and the first commit for reference. This reduces

Re: git-svn performance

2014-10-19 Thread Eric Wong
the below? (on top of your original two patches) Pushed to my master @ git://bogomips.org/git-svn.git Eric Wong (2): git-svn: reduce check_cherry_pick cache overhead git-svn: cache only mergeinfo revisions Jakob Stoklund Olesen (2): git-svn: only look

Re: [PATCH] git-svn.txt: advertise pushurl with dcommit

2014-10-19 Thread Eric Wong
...@users.sourceforge.net Thanks, minor grammar+spelling fix to the commit message: Advertise that the svn-remote.name.pushurl config key allows specifying the commit URL for the entire SVN repository in the documentation of the git svn dcommit command. Signed-off-by: Eric Wong normalper...@yhbt.net

Re: [PATCH] git-svn: merge: fix rooturl/branchurl match check

2014-10-20 Thread Eric Wong
Tommaso Colombo tommaso.colo...@outlook.com wrote: When populating svn:mergeinfo, git-svn merge checks if the merge parent of the merged branch is under the same root as the git-svn repository. This was implemented comparing $gs-repos_root with the return value of of cmt_metadata for the merge

[PATCH] git-svn: clear global SVN pool between get_log invocations

2014-10-20 Thread Eric Wong
-8-- Signed-off-by: Eric Wong normalper...@yhbt.net --- Pushed to master of git://bogomips.org/git-svn However, memory usage still seems to grow infinitely even in this simple fetch case, so are other memory leaks. perl/Git/SVN/Ra.pm | 6 ++ 1 file

Re: git-svn performance

2014-10-21 Thread Eric Wong
: 8- From: Eric Wong normalper...@yhbt.net Date: Tue, 21 Oct 2014 06:23:22 + Subject: [PATCH] git-svn: remove mergeinfo rev caching This should further reduce memory usage from the new mergeinfo speedups without hurting performance too

Re: [PATCH] git-svn: clear global SVN pool between get_log invocations

2014-10-24 Thread Eric Wong
Eric Wong normalper...@yhbt.net wrote: + SVN::Core-gpool-clear; Unfortunately, SVN::Core-gpool is not available in older SVN, but I'm cooking a better patch which saves even more memory. -- To unsubscribe from this list: send the line unsubscribe git in the body

[PATCH] git-svn: reload RA every log-window-size

2014-10-24 Thread Eric Wong
nr=1 while test $nr -gt 0 do echo $nr a svn commit -q -m A nr=$((nr - 1)) done echo repository created in $repo -8-- Signed-off-by: Eric Wong normalper...@yhbt.net --- Eric Wong normalper...@yhbt.net wrote

Re: Anomaly with the new code - Re: git-svn performance

2014-10-24 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: I keep tabs of a particular svn repository over many years and run git svn fetch --all every few days. So that's the old clone. Since this discussion started, I made a new one with git 2.1.0 patched with the first two patches below, a couple of

Re: git-svn performance

2014-10-24 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: Comparing trunk of old and new, I see one difference - One short commit message is missing in the *old* (the Add checkPoFiles etc. part) and so all the sha1 afterwards differed. Is that an old bug that's fixed and therefore I should throw away

Re: git-svn performance

2014-10-25 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: the old didn't missing a revision - just a revision 'message' - blank instead of 3 words, above the git svn id. I supppse it is possible some power problem or etc caused this. I'll check the other branches as well, and possibly clone again to be

[PATCH] git-svn: remove unnecessary DESTROY override

2014-10-25 Thread Eric Wong
This override was probably never necessary, but most likely a no-op as it does not appear to do anything in SVN::Ra itself. Signed-off-by: Eric Wong normalper...@yhbt.net --- perl/Git/SVN/Ra.pm | 4 1 file changed, 4 deletions(-) diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm index

[PATCH] git-svn: save a little memory as fetch progresses

2014-10-25 Thread Eric Wong
There is no reason to keep entries in the %revs hash after we're done processing a revision, so allow entries become freed as processing continues. Signed-off-by: Eric Wong normalper...@yhbt.net --- perl/Git/SVN/Ra.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/perl/Git

Re: [PATCH v3] git-svn: memoize _rev_list and rebuild

2014-10-25 Thread Eric Wong
Jakob to improve svn:mergeinfo performance along with some followup patches to reduce memory use. However memory bloat is still a problem. Currently in my master branch of git://bogomips.org/git-svn Eric Wong (4): git-svn: reduce check_cherry_pick cache overhead git-svn: cache only

Re: Anomaly with the new code - Re: git-svn performance

2014-10-25 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: On Sat, Oct 25, 2014 00:34 BST Eric Wong wrote: Hin-Tak Leung ht...@users.sourceforge.net wrote: 0006-git-svn-clear-global-SVN-pool-between-get_log-invoca.patch 0006 is insufficient and incompatible with older SVN. I pushed git-svn

Re: git-svn performance

2014-10-25 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: btw, git svn seems to disallow single word commit messages (or is it a svn config?). i found that i could not do git svn dcommit, when i had merely did git commit -m 'typos', for example, for an svn repo i have write access to. (I don't have

[PATCH] git-svn: disable _rev_list memoization

2014-10-26 Thread Eric Wong
-project.org/R [2] file:// repos causes libsvn to use more memory internally Signed-off-by: Eric Wong normalper...@yhbt.net Cc: Hin-Tak Leung ht...@users.sourceforge.net --- This patch is in my less-memo branch of bogomips.org/git-svn.git Info here: (not intended as a pull request for Junio, yet

Re: Anomaly with the new code - Re: git-svn performance

2014-10-27 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: On Sat, Oct 25, 2014 00:34 BST Eric Wong wrote: 0006 is insufficient and incompatible with older SVN. I pushed git-svn: reload RA every log-window-size (commit dfa72fdb96befbd790f623bb2909a347176753c2) instead which saves much more memory

Re: Anomaly with the new code - Re: git-svn performance

2014-10-27 Thread Eric Wong
Eric Wong normalper...@yhbt.net wrote: Which SVN version are you using? I'm cloning (currently on r373xx) https://svn.r-project.org/R using --stdlayout and unable to see memory growth of the git-svn Perl process beyond 40M (on a 32-bit system). git-svn hit 45M and took 11:44 to finish. My

Re: differences between old clone and new Re: git-svn performance

2014-10-28 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: To compare the old clone with the new, I did: git branch -r | sort | xargs -n 1 git log --decorate=full -n 1 It turned out other than the empty vs 3 word commit messages about two years ago on trunk (which are inherited in all the newer

Re: Anomaly with the new code - Re: git-svn performance

2014-10-28 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: Eric Wong normalper...@yhbt.net wrote: Which SVN version are you using?  I'm cloning (currently on r373xx) https://svn.r-project.org/R using --stdlayout and unable to see memory growth of the git-svn Perl process beyond 40M (on a 32-bit

Re: Regression and failure to clone/fetch with new code Re: git-svn performance

2014-10-29 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: Hi, I patched my system git with the recent git-svn improvements, and just use it for general use; so theses are the patches, against 2.1.0. 0001-git-svn-only-look-at-the-new-parts-of-svn-mergeinfo.patch

[PATCH] Git.pm: add specified name to tempfile template

2014-10-29 Thread Eric Wong
This should help me track down errors in git-svn more easily: write .git/Git_XX: Bad file descriptor at /usr/lib/perl5/SVN/Ra.pm line 623 Signed-off-by: Eric Wong normalper...@yhbt.net --- Not sure you want to take this separately or in a git-svn pull. Still working

[PATCH] git-svn: prepare SVN::Ra config pieces once

2014-10-29 Thread Eric Wong
Memoizing these initialization functions saves some memory for long fetches which require scanning many unwanted revisions before any wanted revisions happen. Signed-off-by: Eric Wong normalper...@yhbt.net --- perl/Git/SVN/Ra.pm | 63 +++--- 1 file

Re: differences between old clone and new Re: git-svn performance

2014-10-29 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: On Tue, 28/10/14, Eric Wong normalper...@yhbt.net wrote: So both merges are correct, but we lose one, and gain one? I'll try to check more closely tomorrow.  Can you point out the exact revisions in the R repo?  Thanks

Re: Regression and failure to clone/fetch with new code Re: git-svn performance

2014-10-29 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: Argh, sorry. I thought I included the info but I didn't. Thanks. I'll try a different version of svn later. What do you think were missing in my e-mails? I was skimming and missed the part about Debian packages :) -- To unsubscribe from this

[PATCH] git-svn: add space after W: prefix in warning

2014-10-30 Thread Eric Wong
And minor reformatting while we're in the area. Signed-off-by: Eric Wong normalper...@yhbt.net --- perl/Git/SVN.pm | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm index 893b9a8..d9a52a5 100644 --- a/perl/Git/SVN.pm +++ b/perl/Git/SVN.pm

[PATCH] git-svn: (cleanup) remove editor param passing

2014-10-30 Thread Eric Wong
Neither find_extra_svk_parents or find_extra_svn_parents ever used the `$ed' parameter. Signed-off-by: Eric Wong normalper...@yhbt.net --- perl/Git/SVN.pm | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm index 5f9d469..893b9a8

Re: Regression and failure to clone/fetch with new code Re: git-svn performance

2014-10-30 Thread Eric Wong
: git-svn: add space after W: prefix in warning (2014-10-30 08:31:28 +) Eric Wong (11): git-svn: reduce check_cherry_pick cache overhead git-svn: cache only mergeinfo revisions git-svn: remove mergeinfo rev caching

[RFC] Git.pm: stat the FD to ensure the file is really open

2014-10-30 Thread Eric Wong
without the PerlIO layer knowing about it. This is likely a bug inside libsvn (1.6.17), as none of the Git.pm or Git::SVN modules close IOs without the knowledge of the PerlIO layer. Cc: Kyle J. McKay mack...@gmail.com Signed-off-by: Eric Wong normalper...@yhbt.net --- Kyle/Junio: thoughts? I'm

Re: differences between old clone and new Re: git-svn performance

2014-10-30 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: That's quite straight-forward, I think - except for the recent burst (I am essentially adapting the git 2.1.0 release shipped by the upcoming fedora 21 scheduled for christmas) I tend to update to the latest fedora release about a week or

Re: [RFC] Git.pm: stat the FD to ensure the file is really open

2014-10-30 Thread Eric Wong
Kyle J. McKay mack...@gmail.com wrote: On Oct 30, 2014, at 15:08, Eric Wong wrote: For a (currently) unknown reason, Git::SVN::Fetcher::close_file sometimes triggers Bad file descriptor errors on syswrite when writing symlink contents on the svn_hash tempfile. The current IO::Handle::opened

[PULL] git-svn updates for 2.2

2014-10-30 Thread Eric Wong
changes up to 9d536cf625cf42b8a8272070e3720325c68f3b48: git-svn: coerce check_path and get_log args to int (2014-10-30 23:10:57 +) Eric Wong (12): git-svn: reduce check_cherry_pick cache overhead git-svn: cache

[PATCH] git-svn: use SVN::Ra::get_dir2 when possible

2014-10-31 Thread Eric Wong
...@web172304.mail.ir2.yahoo.com ref: 1414722617.89476.yahoomailba...@web172305.mail.ir2.yahoo.com Signed-off-by: Eric Wong normalper...@yhbt.net Cc: Hin-Tak Leung ht...@users.sourceforge.net --- This should fix the vbox clone problem. SVN Perl binding breakage (again :). I shall revert

[PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible

2014-10-31 Thread Eric Wong
...@web172304.mail.ir2.yahoo.com ref: 1414722617.89476.yahoomailba...@web172305.mail.ir2.yahoo.com Signed-off-by: Eric Wong normalper...@yhbt.net Cc: Hin-Tak Leung ht...@users.sourceforge.net --- Sorry, waaay past my bed time. This version doesn't infinite loop on autoload or older SVN

Re: [PULL v2] git-svn updates for 2.2

2014-10-31 Thread Eric Wong
Eric Wong normalper...@yhbt.net wrote: Hi Junio, I haven't heard back from Hin-Tak about the last one (git-svn: coerce check_path and get_log args to int)[1], but I think it's a harmless defensive patch in case you want to tag 2.2-rc0 soon. OK, that coercion patch was pointless and I worked

Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible

2014-10-31 Thread Eric Wong
Eric Wong normalper...@yhbt.net wrote: This avoids the following failure with normal get_dir on newer versions of SVN (tested with SVN 1.8.8-1ubuntu3.1): Incorrect parameters given: Could not convert '%ld' into a number Filed a bug in Debian since I hit it in sid, too: http

Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible

2014-10-31 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: On Fri, Oct 31, 2014 19:08 GMT Eric Wong wrote: Filed a bug in Debian since I hit it in sid, too: http://bugs.debian.org/767530 Thanks all. Hmm, but why are you filing at debian? I had the error when i applied the dev code patches on top

Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible

2014-10-31 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: Tested-by: Hin-Tak Leung ht...@users.sourceforge.net Okay, this one on top of my git 2.1.0 + 10 recent git svn improvement patches allow me to fetch further. I suspect the problem must be elsewhere though, and this just band-aided over

Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible

2014-10-31 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: While my 2.10 + 11 patches continue to fetch, where it was stuck, now it does Couldn't find revmap... - also, the single branch clone is doing the 'trunk/branches/... thing - are these supposed to happen? I'm afraid this is a problem with the

Re: [PATCH] git-svn: use SVN::Ra::get_dir2 when possible

2014-11-02 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: Hmm, I see you are filing the problem against subversion. FWIW, I am currently using subversion-perl-1.8.10-1.fc20.x86_64 package on fedora 20. I'll possibly think about filing one under redhat's bugzilla and let them take it upward too. This

Re: [PATCH v4 2/2] git-svn: allow git-svn fetching to work using serf

2013-07-18 Thread Eric Wong
Jonathan Nieder jrnie...@gmail.com wrote: (cc-ing Eric Wong, who maintains git-svn and knows both it and the libsvn perl bindings much better than I do) I doubt that's the case anymore. I've hardly looked at SVN in many years, now. Anyways, if the patches: 1) do not introduce regressions 2

Re: [PATCH] git-svn: Configure a prompt callback for gnome_keyring.

2013-08-29 Thread Eric Wong
Matthijs Kooijman matth...@stdin.nl wrote: Hi folks, any chance this patch can be merged? It's probably fine. Does anybody else have testing/feedback? I haven't used git-svn/SVN in years, and I don't use GNOME (nor much GUI). -- To unsubscribe from this list: send the line unsubscribe git

Re: [PATCH] git-svn: Configure a prompt callback for gnome_keyring.

2013-08-29 Thread Eric Wong
Edward Rudd ur...@outoforder.cc wrote: Where is a link to the latest patch? I can give it a quick once-over with one of my git-svn'ed game ports I'm working on. (due for launching on the 10th.. WOOHOO!) http://mid.gmane.org/1371573490-21973-1-git-send-email-matth...@stdin.nl Thanks! -- To

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-05 Thread Eric Wong
happening. Thanks. Please sign-off your patch. I am Cc'ing Kyle McKay who apparently had some experience working with git-svn with newer svn that can only use serf, hoping that we can get an independent opinion/test just to be sure. Also Cc'ed is Eric Wong who has been the official git-svn

Re: [PATCH] git svn: reset invalidates the memoized mergeinfo caches

2012-08-08 Thread Eric Wong
Peter Baumann waste.mana...@gmx.de wrote: On Tue, Aug 07, 2012 at 08:45:10PM +, Eric Wong wrote: Peter Baumann waste.mana...@gmx.de wrote: + for my $suffix (qw(yaml db)) { + unlink($cache_file.$suffix); Need to check for unlink() errors

Re: [PATCH/RFC] git svn: handle errors and concurrent commits in dcommit

2012-08-08 Thread Eric Wong
Robert Luberda rob...@debian.org wrote: Eric Wong wrote: + echo PATH=\$PATH\; export PATH $hook + echo svnconf=\$svnconf\ $hook + cat $hook - 'EOF2' + cd work-auto-commits.svn + svn up --config-dir $svnconf

Re: [PATCH/RFC] git svn: handle errors and concurrent commits in dcommit

2012-08-10 Thread Eric Wong
Junio C Hamano gits...@pobox.com wrote: I should have asked this yesterday, but do you mean you want to have your maint in the upcoming 1.7.12? This does look like a useful thing to do, but does not seem like a regression fix to me. Yeah, I wasn't sure what to name it since my master is still

Re: [PATCH v2] git svn: reset invalidates the memoized mergeinfo caches

2012-08-10 Thread Eric Wong
Peter Baumann waste.mana...@gmx.de wrote: First, let me thank you for your review and your detailed explanation. I really appreciate it. You're welcome, Peter. Thanks again for the patch. I've signed-off and pushed for Junio. The following changes since commit

Re: [PATCH v2] git svn: reset invalidates the memoized mergeinfo caches

2012-08-10 Thread Eric Wong
Junio C Hamano gits...@pobox.com wrote: Eric Wong normalper...@yhbt.net writes: Peter Baumann (1): git svn: reset invalidates the memoized mergeinfo caches Robert Luberda (1): git svn: handle errors and concurrent commits in dcommit OK, so these two are fit for 1.7.12-rc3

Re: [PATCH v3 1/2] git-svn.perl: consider all ranges for a given merge, instead of only tip-by-tip

2012-08-13 Thread Eric Wong
Steven Walter stevenrwal...@gmail.com wrote: Consider the case where you have trunk, branchA of trunk, and branchB of branchA. trunk is merged back into branchB, and then branchB is reintegrated into trunk. The merge of branchB into trunk will have svn:mergeinfo property references to both

Re: [PATCH v3 2/2] git-svn.perl: keep processing all commits in parents_exclude

2012-08-19 Thread Eric Wong
Steven Walter stevenrwal...@gmail.com wrote: On Sat, Aug 18, 2012 at 3:51 PM, Sam Vilain s...@vilain.net wrote: On 08/11/2012 10:14 AM, Steven Walter wrote: --- git-svn.perl |1 - t/t9164-git-svn-fetch-merge-branch-of-branch2.sh | 53

Re: Fix git-svn for SVN 1.7

2012-08-21 Thread Eric Wong
Junio C Hamano gits...@pobox.com wrote: Unless you found a reason not to in the meantime, that is. Is what I have on 'pu' still good, or do you (Eric and/or Michael) have any updates you'd rather have me pull instead? No updates, everything is still good. -- To unsubscribe from this list:

Re: [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id

2012-08-21 Thread Eric Wong
Robert Luberda rob...@debian.org wrote: I have been quite a busy recently, so it took me longer that I thought. No worries, thanks for following up. It was quite hard for me to think some sensible option name, and finally have chosen --trim-svn-log (svn.trimsvnlog as config key name). Please

Re: [PATCH/RFC] git svn: handle errors and concurrent commits in dcommit

2012-08-21 Thread Eric Wong
test name, also eliminate space after to conform to guidelines] Signed-off-by: Eric Wong normalper...@yhbt.net --- ...n-dcommit-concrrent.sh = t9164-git-svn-dcommit-concurrent.sh} | 8 1 file changed, 4 insertions(+), 4 deletions(-) rename t/{t9164-git-svn-dcommit-concrrent.sh

Re: [PATCH 1/2] git-svn.perl: consider all ranges for a given merge, instead of only tip-by-tip

2012-08-21 Thread Eric Wong
Steven Walter stevenrwal...@gmail.com wrote: Consider the case where you have trunk, branch1 of trunk, and branch2 of branch1. trunk is merged back into branch2, and then branch2 is reintegrated into trunk. The merge of branch2 into trunk will have svn:mergeinfo property references to both

Re: [PATCH/RFC] git svn: handle errors and concurrent commits in dcommit

2012-08-25 Thread Eric Wong
Robert Luberda rob...@debian.org wrote: Eric Wong wrote: Oops, I'll push the following out since Junio already merged your original: I can see that you haven't pushed the change yet. Maybe it would be a good idea to fix other style mistakes (extra spaces after redirections, lack

Re: [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id

2012-08-25 Thread Eric Wong
Robert Luberda rob...@debian.org wrote: Junio C Hamano wrote: Eric Wong normalper...@yhbt.net writes: I think having svn in svn.trimsvnlog twice is redundant and not ideal. Perhaps just --trim-log and svn.trimlog? Do we ever want to trim our log when relaying the Git commits back

[PATCH/RFC] git-svn: use path accessor for Git::SVN objects

2012-09-17 Thread Eric Wong
The accessors should improve maintainability and enforce consistent access to Git::SVN objects. Signed-off-by: Eric Wong normalper...@yhbt.net --- (RFC since I could've missed something) Eric Wong normalper...@yhbt.net wrote: I'll apply the following (on top of a patch which fixes some

Re: [PATCH] Allow fancy globs in git-svn init branches

2012-09-18 Thread Eric Wong
Ammon Riley ammon.ri...@gmail.com wrote: Branches passed to 'git-svn init' via the -b/--branches flag automatically had a /* appended to them. When the branch contained a fancy glob with a {} pattern, this is incorrect behaviour, and leads to odd branches being created in the git repository.

Re: [PATCH] Allow fancy globs in git-svn init branches

2012-09-18 Thread Eric Wong
Ammon Riley ammon.ri...@gmail.com wrote: I confess that I'd completely forgot about the {} expansion in bash. Perhaps a note in the CAVEATS section of the documentation would be sufficient? I think so, yes. Can you send a patch for that instead? Thanks. -- To unsubscribe from this list: send

Re: [PATCH 3/7] Extract, test and enhance the logic to collapse ../foo paths.

2012-09-26 Thread Eric Wong
Jonathan Nieder jrnie...@gmail.com wrote: Hi, Michael G Schwern wrote: On 2012.7.30 12:51 PM, Eric Wong wrote: Michael G Schwern wrote: _collapse_dotdot() works better than the existing regex did. I don't dispute it's better, but it's worth explaining in the commit message

Re: [PATCH 3/7] Extract, test and enhance the logic to collapse ../foo paths.

2012-09-26 Thread Eric Wong
Jonathan Nieder jrnie...@gmail.com wrote: Eric Wong wrote: That said, I'd favor an implementation that split on m{/+} and collapsed as Michael mentioned. Sounds sensible. Is canonicalize_path responsible for collapsing runs of slashes? What should _collapse_dotdot do to c:/.. or http

Re: [PATCH 3/7] Extract, test and enhance the logic to collapse ../foo paths.

2012-09-26 Thread Eric Wong
Jonathan Nieder jrnie...@gmail.com wrote: Maybe we can use apr_filepath_merge() to avoid reinventing the wheel? Ideally, yes. Is there an easy way to access that from Perl? (and for the older versions of SVN folks people are running). Perhaps we can expose equivalent functionality in git via

Re: [PATCH] git-svn: keep leading slash when canonicalizing paths (fallback case)

2012-10-05 Thread Eric Wong
/svnrepo' contains unsupported hostname at \ /home/jrn/src/git-scratch/perl/blib/lib/Git/SVN.pm line 148 With it, the git-svn tests pass again. Signed-off-by: Jonathan Nieder jrnie...@gmail.com Thanks for noticing this. Signed-off-by: Eric Wong normalper...@yhbt.net and pushed to my master

Re: [PATCH/RFC v2] git svn: work around SVN 1.7 mishandling of svn:special changes

2012-10-10 Thread Eric Wong
are sent in a format that modern svn update can handle and tests t9100.11-13 pass again. [ew: s,git-svn\.perl,perl/Git/SVN/Editor.pm,g] Signed-off-by: Jonathan Nieder jrnie...@gmail.com Signed-off-by: Eric Wong normalper...@yhbt.net --- perl/Git/SVN/Editor.pm | 25 - 1 file

Re: [PATCH/RFC] svn test: escape peg revision separator using empty peg rev

2012-10-10 Thread Eric Wong
Jonathan Nieder jrnie...@gmail.com wrote: Michael J Gruber wrote: Jonathan Nieder venit, vidit, dixit 09.10.2012 10:41: Signed-off-by: Jonathan Nieder jrnie...@gmail.com Tested with Subversion 1.6.18. Thanks both. Also pushed to master on git://bogomips.org/git-svn.git (commit

  1   2   3   4   5   6   7   >