Re: [RFC v2 11/16] Add explanatory comment for transport-helpers refs mapping.

2012-07-30 Thread Florian Achleitner
On Monday 30 July 2012 14:15:53 Jonathan Nieder wrote: > Junio C Hamano wrote: > > Jonathan Nieder writes: > >>> + /* > >>> + * If the remote helper advertised the "refspec" capability, > >>> + * it will have the written result of the import to the refs > > > > perhaps s/will have the written r

Re: [RFC v2 11/16] Add explanatory comment for transport-helpers refs mapping.

2012-07-30 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan Nieder writes: >>> + /* >>> +* If the remote helper advertised the "refspec" capability, >>> +* it will have the written result of the import to the refs > > perhaps s/will have the written result of/would have written result of/? That would sound like

Re: [RFC v2 11/16] Add explanatory comment for transport-helpers refs mapping.

2012-07-30 Thread Junio C Hamano
Jonathan Nieder writes: > I would like to see the patch applied so the remote-svn series without > it gets shorter and easier to review. ;-) Munging the two context > lines ending with argv_array_clear(&importer_argv); to > > free(fastimport.argv); > fastimport.argv = NULL; > > makes

Re: [RFC v2 11/16] Add explanatory comment for transport-helpers refs mapping.

2012-07-30 Thread Junio C Hamano
Jonathan Nieder writes: > Hi Junio, > > Florian Achleitner wrote: > >> transport-helpers can advertise the 'refspec' capability, >> if not a default refspec *:* is assumed. This explains >> the post-processing of refs after fetching with fast-import. >> >> Signed-off-by: Florian Achleitner > > T

Re: [RFC v2 11/16] Add explanatory comment for transport-helpers refs mapping.

2012-07-30 Thread Jonathan Nieder
Hi Junio, Florian Achleitner wrote: > transport-helpers can advertise the 'refspec' capability, > if not a default refspec *:* is assumed. This explains > the post-processing of refs after fetching with fast-import. > > Signed-off-by: Florian Achleitner The patch below adds a comment to fetch_w

[RFC v2 11/16] Add explanatory comment for transport-helpers refs mapping.

2012-07-30 Thread Florian Achleitner
transport-helpers can advertise the 'refspec' capability, if not a default refspec *:* is assumed. This explains the post-processing of refs after fetching with fast-import. Signed-off-by: Florian Achleitner --- transport-helper.c | 15 +++ 1 file changed, 15 insertions(+) diff --