Re: Configuring a third-party git hook

2014-03-21 Thread Junio C Hamano
Jeff King writes: > [1] Is there a word to mean the "pluralness" of a noun or verb (similar > to "tense" for a verb). I've seen "plural vs singular" often mentioned in the context of subject and verb agreement. en.wiktionary.org/wiki/concord talks about agreement "in gender, number, person,

Re: Configuring a third-party git hook

2014-03-21 Thread Junio C Hamano
Jeff King writes: > On Fri, Mar 21, 2014 at 10:31:59AM -0700, Junio C Hamano wrote: > >> -- >8 -- >> From: Chris Angelico >> Date: Fri, 21 Mar 2014 15:07:08 +1100 >> Subject: [PATCH] config.txt: third-party tools may and do use their own >> variables >> [...] >> +Other git-related tools may and

Re: Configuring a third-party git hook

2014-03-21 Thread Jeff King
On Fri, Mar 21, 2014 at 10:31:59AM -0700, Junio C Hamano wrote: > -- >8 -- > From: Chris Angelico > Date: Fri, 21 Mar 2014 15:07:08 +1100 > Subject: [PATCH] config.txt: third-party tools may and do use their own > variables > [...] > +Other git-related tools may and do use their own variables.

Re: Configuring a third-party git hook

2014-03-21 Thread Chris Angelico
On Sat, Mar 22, 2014 at 4:31 AM, Junio C Hamano wrote: > Chris Angelico writes: > >> On Fri, Mar 21, 2014 at 2:43 PM, Jeff King wrote: >>> Thanks, the new text looks good to me. Please follow SubmittingPatches >>> (notably, you need to sign-off your work, and please send patches inline >>> rathe

Re: Configuring a third-party git hook

2014-03-21 Thread Junio C Hamano
Chris Angelico writes: > On Fri, Mar 21, 2014 at 2:43 PM, Jeff King wrote: >> Thanks, the new text looks good to me. Please follow SubmittingPatches >> (notably, you need to sign-off your work, and please send patches inline >> rather than as attachments). > > Ah, didn't see that file. It appea

Re: Configuring a third-party git hook

2014-03-20 Thread Chris Angelico
On Fri, Mar 21, 2014 at 2:43 PM, Jeff King wrote: > Thanks, the new text looks good to me. Please follow SubmittingPatches > (notably, you need to sign-off your work, and please send patches inline > rather than as attachments). Ah, didn't see that file. >From 6e1fc126ece37c6201d0c16b76c6c87781f

Re: Configuring a third-party git hook

2014-03-20 Thread Jeff King
On Fri, Mar 21, 2014 at 10:46:15AM +1100, Chris Angelico wrote: > oohh. Heh. I thought the "porcelain" sections of git were the > lower-level or machine-readable versions of other tools, and didn't > really think of mine as fitting into that. The term sometimes gets used confusingly. The

Re: Configuring a third-party git hook

2014-03-20 Thread Chris Angelico
On Fri, Mar 21, 2014 at 10:38 AM, Jeff King wrote: >> A comment there to the effect that "Third party tools may also define >> their own variables" or something would make it clear that this is the >> intention. > > I think this sentence from the section you linked is meant to express > that: > >

Re: Configuring a third-party git hook

2014-03-20 Thread Jeff King
On Fri, Mar 21, 2014 at 03:51:16AM +1100, Chris Angelico wrote: > > 1. I would say yes. git config is made to be extended and doesn't > > require a config item to be known. > > 2. Namespacing the config items like you did is a good thing to do so > > it won't interfere with other options. > > Exc

Re: Configuring a third-party git hook

2014-03-20 Thread Chris Angelico
On Fri, Mar 21, 2014 at 3:53 AM, Junio C Hamano wrote: > Chris Angelico writes: > >> file. It doesn't really care about the full history, and wants to be >> reasonably fast (as the user is waiting for it). It's just a >> convenience, so correctness isn't a huge issue. The easiest way to >> keep i

Re: Configuring a third-party git hook

2014-03-20 Thread Junio C Hamano
Chris Angelico writes: > file. It doesn't really care about the full history, and wants to be > reasonably fast (as the user is waiting for it). It's just a > convenience, so correctness isn't a huge issue. The easiest way to > keep it moving through quickly is to limit the search: > > $ git log

Re: Configuring a third-party git hook

2014-03-20 Thread Chris Angelico
On Thu, Mar 20, 2014 at 11:53 PM, Kevin wrote: > On Wed, Mar 19, 2014 at 12:16 PM, Chris Angelico wrote: >> Two parts to the question, then. Firstly, is it acceptable to use 'git >> config' for a hook like this? And secondly, either: Is there a naming >> convention to follow? or, what alternative

Re: Configuring a third-party git hook

2014-03-20 Thread Kevin
On Wed, Mar 19, 2014 at 12:16 PM, Chris Angelico wrote: > Two parts to the question, then. Firstly, is it acceptable to use 'git > config' for a hook like this? And secondly, either: Is there a naming > convention to follow? or, what alternative would you recommend? 1. I would say yes. git config

Configuring a third-party git hook

2014-03-19 Thread Chris Angelico
I have a bit of a weird question. Poking around with Google searches hasn't come up with any results, so I'm asking here :) Short version: What's the most appropriate way to configure a git hook? Long version: I have a git hook (handles prepare-commit-msg and commit-msg) and part of what it does