Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature

2012-11-21 Thread Junio C Hamano
Max Horn m...@quendi.de writes: Aha, now I understand what this patch is about. So I would suggest this alternate commit message: remote-testgit: make it explicit clear that we use the 'done' feature Previously we relied on passing '--use-done-feature ' to git fast-export, which is

Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature

2012-11-21 Thread Sverre Rabbelier
On Wed, Nov 21, 2012 at 10:11 AM, Junio C Hamano gits...@pobox.com wrote: I'd state it like this, but I may have guessed what Felipe intended incorrectly. remote-testgit: advertise done feature and write done ourselves Instead of letting fast-export advertise the feature and ending

Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature

2012-11-12 Thread Max Horn
On 11.11.2012, at 22:22, Felipe Contreras wrote: On Sun, Nov 11, 2012 at 9:49 PM, Max Horn m...@quendi.de wrote: On 11.11.2012, at 14:59, Felipe Contreras wrote: People seeking for reference would find it useful. Hm, I don't understand this commit message. Probably means I am j git

Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature

2012-11-12 Thread Jonathan Nieder
Max Horn wrote: Aha, now I understand what this patch is about. So I would suggest this alternate commit message: remote-testgit: make it explicit clear that we use the 'done' feature Previously we relied on passing '--use-done-feature ' to git fast-export, which is easy to miss when

Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature

2012-11-12 Thread Felipe Contreras
On Mon, Nov 12, 2012 at 4:45 PM, Jonathan Nieder jrnie...@gmail.com wrote: Max Horn wrote: Aha, now I understand what this patch is about. So I would suggest this alternate commit message: remote-testgit: make it explicit clear that we use the 'done' feature Previously we relied on

Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature

2012-11-11 Thread Max Horn
On 11.11.2012, at 14:59, Felipe Contreras wrote: People seeking for reference would find it useful. Hm, I don't understand this commit message. Probably means I am just too dumb, but since I am one of those people who would likely be seeking for reference, I would really appreciate if it

Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 9:49 PM, Max Horn m...@quendi.de wrote: On 11.11.2012, at 14:59, Felipe Contreras wrote: People seeking for reference would find it useful. Hm, I don't understand this commit message. Probably means I am j git fast-export --use-done-featureust too dumb, but since I