[GitHub] [activemq-artemis] asfgit merged pull request #2708: ARTEMIS-2386 - use internal session for management queues for QOS2

2019-06-18 Thread GitBox
asfgit merged pull request #2708: ARTEMIS-2386 - use internal session for management queues for QOS2 URL: https://github.com/apache/activemq-artemis/pull/2708 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] franz1981 commented on issue #2708: ARTEMIS-2386 - use internal session for management queues for QOS2

2019-06-18 Thread GitBox
franz1981 commented on issue #2708: ARTEMIS-2386 - use internal session for management queues for QOS2 URL: https://github.com/apache/activemq-artemis/pull/2708#issuecomment-503041632 The failure doesn't seem related to this PR , I'm gonna merge it!

[GitHub] [activemq-artemis] franz1981 opened a new pull request #2704: ARTEMIS-2382 Reclaimer doesn't need to be instantiatable

2019-06-17 Thread GitBox
franz1981 opened a new pull request #2704: ARTEMIS-2382 Reclaimer doesn't need to be instantiatable URL: https://github.com/apache/activemq-artemis/pull/2704 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] twyszomirski commented on issue #2712: Allow setting JMS Properties when sending messages via REST.

2019-06-18 Thread GitBox
twyszomirski commented on issue #2712: Allow setting JMS Properties when sending messages via REST. URL: https://github.com/apache/activemq-artemis/pull/2712#issuecomment-503130025 @michaelandrepearce Ok I get the "agnostic" argument, so assuming I drop or replace the word "jms" (for

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2712: Allow setting JMS Properties when sending messages via REST.

2019-06-18 Thread GitBox
michaelandrepearce commented on issue #2712: Allow setting JMS Properties when sending messages via REST. URL: https://github.com/apache/activemq-artemis/pull/2712#issuecomment-503092427 The broker is agnostic of JMS. We specifically stripping JMS specifics this is so the broker can be

[GitHub] [activemq-artemis] cecilphillip commented on issue #2536: ARTEMIS-2245 Implement Docker images

2019-06-18 Thread GitBox
cecilphillip commented on issue #2536: ARTEMIS-2245 Implement Docker images URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-503068680 @michaelandrepearce looks like there an image available here https://github.com/vromero/activemq-artemis-docker

[GitHub] [activemq-artemis] michalxo commented on issue #2710: ARTEMIS-1825 Live-backup topology not correctly displayed on console

2019-06-18 Thread GitBox
michalxo commented on issue #2710: ARTEMIS-1825 Live-backup topology not correctly displayed on console URL: https://github.com/apache/activemq-artemis/pull/2710#issuecomment-503077012 This looks good to me. I have tested on 3 pairs in HA configuration with failback "on" on slaves (so

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-13 Thread GitBox
franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r283266469 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-13 Thread GitBox
franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r283269072 ## File path:

[GitHub] [activemq-artemis] asfgit closed pull request #2646: ARTEMIS-2317 Reuse file buffer wrapper instances to reduce allocations

2019-05-13 Thread GitBox
asfgit closed pull request #2646: ARTEMIS-2317 Reuse file buffer wrapper instances to reduce allocations URL: https://github.com/apache/activemq-artemis/pull/2646 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-13 Thread GitBox
wy96f commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r283246552 ## File path:

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-13 Thread GitBox
wy96f commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r283246012 ## File path:

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-13 Thread GitBox
wy96f commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r283251599 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on issue #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-05-13 Thread GitBox
franz1981 commented on issue #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#issuecomment-491743074 I've moved 2 commits re scalability of paging cache from here into https://github.com/apache/activemq-artemis/pull/2667

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2667: ARTEMIS-2321 Non-blocking Page::read on page cache

2019-05-13 Thread GitBox
clebertsuconic commented on a change in pull request #2667: ARTEMIS-2321 Non-blocking Page::read on page cache URL: https://github.com/apache/activemq-artemis/pull/2667#discussion_r283346968 ## File path:

[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-13 Thread GitBox
wy96f commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r283248085 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-13 Thread GitBox
franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r283267267 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on issue #2667: ARTEMIS-2321 Non-blocking Page::read on page cache

2019-05-13 Thread GitBox
franz1981 commented on issue #2667: ARTEMIS-2321 Non-blocking Page::read on page cache URL: https://github.com/apache/activemq-artemis/pull/2667#issuecomment-491742232 @clebertsuconic I've separated the scalability fix from the GC improvements re paging in this PR.

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-13 Thread GitBox
clebertsuconic commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r283505141 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2667: ARTEMIS-2321 Non-blocking Page::read on page cache

2019-05-13 Thread GitBox
clebertsuconic commented on a change in pull request #2667: ARTEMIS-2321 Non-blocking Page::read on page cache URL: https://github.com/apache/activemq-artemis/pull/2667#discussion_r283374293 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2667: ARTEMIS-2321 Non-blocking Page::read on page cache

2019-05-13 Thread GitBox
franz1981 commented on a change in pull request #2667: ARTEMIS-2321 Non-blocking Page::read on page cache URL: https://github.com/apache/activemq-artemis/pull/2667#discussion_r283381029 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2667: ARTEMIS-2321 Non-blocking Page::read on page cache

2019-05-13 Thread GitBox
franz1981 commented on a change in pull request #2667: ARTEMIS-2321 Non-blocking Page::read on page cache URL: https://github.com/apache/activemq-artemis/pull/2667#discussion_r283374150 ## File path: pom.xml ## @@ -1624,6 +1624,8 @@

[GitHub] [activemq] mrbald opened a new pull request #358: AMQ-7201 added shebang to generated broker admin script

2019-05-13 Thread GitBox
mrbald opened a new pull request #358: AMQ-7201 added shebang to generated broker admin script URL: https://github.com/apache/activemq/pull/358 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq] jbonofre merged pull request #341: Update copyright year

2019-05-13 Thread GitBox
jbonofre merged pull request #341: Update copyright year URL: https://github.com/apache/activemq/pull/341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [activemq] jbonofre merged pull request #318: AMQ-7107 - Make QueueBrowsingTest and UsageBlockedDispatchTest succee…

2019-05-13 Thread GitBox
jbonofre merged pull request #318: AMQ-7107 - Make QueueBrowsingTest and UsageBlockedDispatchTest succee… URL: https://github.com/apache/activemq/pull/318 This is an automated message from the Apache Git Service. To respond

[GitHub] [activemq] jbonofre merged pull request #355: Updating Spring + Camel versions

2019-05-13 Thread GitBox
jbonofre merged pull request #355: Updating Spring + Camel versions URL: https://github.com/apache/activemq/pull/355 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [activemq] jbonofre merged pull request #339: AMQ-7138 Hardcoded paths to a karaf etc directory in a file features.xml

2019-05-13 Thread GitBox
jbonofre merged pull request #339: AMQ-7138 Hardcoded paths to a karaf etc directory in a file features.xml URL: https://github.com/apache/activemq/pull/339 This is an automated message from the Apache Git Service. To

[GitHub] [activemq] jbonofre commented on issue #356: AMQ-7196 - During startup ActiveMq load all the scheduleDB.data on me…

2019-05-13 Thread GitBox
jbonofre commented on issue #356: AMQ-7196 - During startup ActiveMq load all the scheduleDB.data on me… URL: https://github.com/apache/activemq/pull/356#issuecomment-492084856 @alanprot FYI, I reviewed the PR and it looks to me, thanks ! @cshannon sorry, I was busy on Karaf but I was

[GitHub] [activemq] jbonofre merged pull request #325: Set the secure processing feature on the TransformerFactory

2019-05-13 Thread GitBox
jbonofre merged pull request #325: Set the secure processing feature on the TransformerFactory URL: https://github.com/apache/activemq/pull/325 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq] jbonofre merged pull request #323: Update OWasp dependency check plugin version

2019-05-13 Thread GitBox
jbonofre merged pull request #323: Update OWasp dependency check plugin version URL: https://github.com/apache/activemq/pull/323 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [activemq] gtully merged pull request #360: Switch to using a https URL in the mqtt pom

2019-05-22 Thread GitBox
gtully merged pull request #360: Switch to using a https URL in the mqtt pom URL: https://github.com/apache/activemq/pull/360 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2675: ARTEMIS-2347 JournalStorageManager::stopReplication can deadlock while stopping

2019-05-22 Thread GitBox
franz1981 commented on a change in pull request #2675: ARTEMIS-2347 JournalStorageManager::stopReplication can deadlock while stopping URL: https://github.com/apache/activemq-artemis/pull/2675#discussion_r286328434 ## File path:

[GitHub] [activemq] borgstrom opened a new pull request #359: AMQ-7211 STOMP: Do not clear pending ACKs on COMMIT

2019-05-20 Thread GitBox
borgstrom opened a new pull request #359: AMQ-7211 STOMP: Do not clear pending ACKs on COMMIT URL: https://github.com/apache/activemq/pull/359 This PR first adds a test that proves the behavior is broken: c3729b0 When you run this test against master it will fail: ```

[GitHub] [activemq-artemis] gemmellr opened a new pull request #2678: ARTEMIS-2351: update to proton-j 0.33.0 and qpid-jms 0.42.0

2019-05-22 Thread GitBox
gemmellr opened a new pull request #2678: ARTEMIS-2351: update to proton-j 0.33.0 and qpid-jms 0.42.0 URL: https://github.com/apache/activemq-artemis/pull/2678 This is an automated message from the Apache Git Service. To

[GitHub] [activemq-artemis] wy96f opened a new pull request #2677: ARTEMIS-2350 Fix ClassNotFoundException while invoking listConsumers

2019-05-22 Thread GitBox
wy96f opened a new pull request #2677: ARTEMIS-2350 Fix ClassNotFoundException while invoking listConsumers URL: https://github.com/apache/activemq-artemis/pull/2677 The exception is as follows: 2019-05-22 20:27:25,842 FINE [sun.rmi.server.call] RMI TCP Connection(3)-10.49.7.20:

[GitHub] [activemq-artemis] gaohoward closed pull request #2676: ARTEMIS-2349 CLI FQQN name parsing is incorrect

2019-05-22 Thread GitBox
gaohoward closed pull request #2676: ARTEMIS-2349 CLI FQQN name parsing is incorrect URL: https://github.com/apache/activemq-artemis/pull/2676 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] gaohoward commented on issue #2676: ARTEMIS-2349 CLI FQQN name parsing is incorrect

2019-05-22 Thread GitBox
gaohoward commented on issue #2676: ARTEMIS-2349 CLI FQQN name parsing is incorrect URL: https://github.com/apache/activemq-artemis/pull/2676#issuecomment-494789060 I got the fqqn format wrong. The original is correct. I'll reject the jira and close this PR.

[GitHub] [activemq-artemis] andytaylor opened a new pull request #2680: ARTEMIS-2346 - make timestamp human readable in console

2019-05-23 Thread GitBox
andytaylor opened a new pull request #2680: ARTEMIS-2346 - make timestamp human readable in console URL: https://github.com/apache/activemq-artemis/pull/2680 https://issues.apache.org/jira/browse/ARTEMIS-2346 This is an

[GitHub] [activemq-nms-api] michaelandrepearce commented on issue #4: AMQNET-565 NetStandard 2.0 Build

2019-05-23 Thread GitBox
michaelandrepearce commented on issue #4: AMQNET-565 NetStandard 2.0 Build URL: https://github.com/apache/activemq-nms-api/pull/4#issuecomment-495408086 @killnine and @artnaseef we can do refactors later, this just unblocks and gets ball rolling with getting a netstandard 2.0 build which

[GitHub] [activemq-nms-api] michaelandrepearce opened a new pull request #4: AMQNET-565 NetStandard 2.0 Build

2019-05-23 Thread GitBox
michaelandrepearce opened a new pull request #4: AMQNET-565 NetStandard 2.0 Build URL: https://github.com/apache/activemq-nms-api/pull/4 This is to provide a netstandard2.0 build that will also publish to nuget. This is an

[GitHub] [activemq] coheigea opened a new pull request #361: AMQ-7216 - Update Rome dependency

2019-05-24 Thread GitBox
coheigea opened a new pull request #361: AMQ-7216 - Update Rome dependency URL: https://github.com/apache/activemq/pull/361 Tested Atom + RSS feeds in webconsole work after the change. This is an automated message from the

[GitHub] [activemq-nms-api] killnine commented on issue #4: AMQNET-565 NetStandard 2.0 Build

2019-05-24 Thread GitBox
killnine commented on issue #4: AMQNET-565 NetStandard 2.0 Build URL: https://github.com/apache/activemq-nms-api/pull/4#issuecomment-495609889 Sounds good! This is an automated message from the Apache Git Service. To respond

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2679: ARTEMIS-2352 - Add the ability to reject messages without a validated…

2019-05-24 Thread GitBox
clebertsuconic commented on a change in pull request #2679: ARTEMIS-2352 - Add the ability to reject messages without a validated… URL: https://github.com/apache/activemq-artemis/pull/2679#discussion_r287346181 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2679: ARTEMIS-2352 - Add the ability to reject messages without a validated…

2019-05-24 Thread GitBox
clebertsuconic commented on a change in pull request #2679: ARTEMIS-2352 - Add the ability to reject messages without a validated… URL: https://github.com/apache/activemq-artemis/pull/2679#discussion_r287346306 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2675: ARTEMIS-2347 JournalStorageManager::stopReplication can deadlock while stopping

2019-05-24 Thread GitBox
clebertsuconic commented on issue #2675: ARTEMIS-2347 JournalStorageManager::stopReplication can deadlock while stopping URL: https://github.com/apache/activemq-artemis/pull/2675#issuecomment-495685236 The use of theory here is really odd! If the test failed on NIO, there's no

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2679: ARTEMIS-2352 - Add the ability to reject messages without a validated…

2019-05-24 Thread GitBox
clebertsuconic commented on issue #2679: ARTEMIS-2352 - Add the ability to reject messages without a validated… URL: https://github.com/apache/activemq-artemis/pull/2679#issuecomment-495680537 There is a real failure as part of this. look on the PR check

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2647: ARTEMIS-2323 NettyTransport should also send requests with void promises

2019-05-08 Thread GitBox
clebertsuconic commented on a change in pull request #2647: ARTEMIS-2323 NettyTransport should also send requests with void promises URL: https://github.com/apache/activemq-artemis/pull/2647#discussion_r282215861 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2647: ARTEMIS-2323 NettyTransport should also send requests with void promises

2019-05-08 Thread GitBox
clebertsuconic commented on a change in pull request #2647: ARTEMIS-2323 NettyTransport should also send requests with void promises URL: https://github.com/apache/activemq-artemis/pull/2647#discussion_r282221591 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-05-08 Thread GitBox
franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r282275541 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-05-08 Thread GitBox
franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r282275541 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-05-08 Thread GitBox
clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r282275220 ## File path:

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2664: ARTEMIS-2333 Applying proper fix on Stomp delivery

2019-05-08 Thread GitBox
clebertsuconic opened a new pull request #2664: ARTEMIS-2333 Applying proper fix on Stomp delivery URL: https://github.com/apache/activemq-artemis/pull/2664 When connection is dead, the StompSession may deliver a message and if AUTO-ACK it would ack and lose the message

[GitHub] [activemq-artemis] asfgit merged pull request #2664: ARTEMIS-2333 Applying proper fix on Stomp delivery

2019-05-08 Thread GitBox
asfgit merged pull request #2664: ARTEMIS-2333 Applying proper fix on Stomp delivery URL: https://github.com/apache/activemq-artemis/pull/2664 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] jdanekrh commented on a change in pull request #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

2019-05-10 Thread GitBox
jdanekrh commented on a change in pull request #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#discussion_r279748112 ## File path:

[GitHub] [activemq-artemis] jdanekrh commented on a change in pull request #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

2019-05-10 Thread GitBox
jdanekrh commented on a change in pull request #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#discussion_r279748160 ## File path:

[GitHub] [activemq-artemis] jdanekrh commented on a change in pull request #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

2019-05-10 Thread GitBox
jdanekrh commented on a change in pull request #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#discussion_r279750207 ## File path:

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2665: ARTEMIS-2335 Fixing delivery logic for message group on negative attemps

2019-05-10 Thread GitBox
clebertsuconic opened a new pull request #2665: ARTEMIS-2335 Fixing delivery logic for message group on negative attemps URL: https://github.com/apache/activemq-artemis/pull/2665 OpenWireGroupingTest::testGrouping is fixed after this change as it was intermittently failing

[GitHub] [activemq] coheigea opened a new pull request #360: Switch to using a https URL in the mqtt pom

2019-05-21 Thread GitBox
coheigea opened a new pull request #360: Switch to using a https URL in the mqtt pom URL: https://github.com/apache/activemq/pull/360 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [activemq-artemis] asfgit closed pull request #2674: ARTEMIS-2346 - make timestamp human readable in console

2019-05-21 Thread GitBox
asfgit closed pull request #2674: ARTEMIS-2346 - make timestamp human readable in console URL: https://github.com/apache/activemq-artemis/pull/2674 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2675: ARTEMIS-2347 JournalStorageManager::stopReplication can deadlock while stopping

2019-05-21 Thread GitBox
clebertsuconic commented on a change in pull request #2675: ARTEMIS-2347 JournalStorageManager::stopReplication can deadlock while stopping URL: https://github.com/apache/activemq-artemis/pull/2675#discussion_r286189481 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2675: ARTEMIS-2347 JournalStorageManager::stopReplication can deadlock while stopping

2019-05-21 Thread GitBox
clebertsuconic commented on a change in pull request #2675: ARTEMIS-2347 JournalStorageManager::stopReplication can deadlock while stopping URL: https://github.com/apache/activemq-artemis/pull/2675#discussion_r286189481 ## File path:

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #2673: NO-JIRA fix EmbeddedJMSResourceTopicTest

2019-05-20 Thread GitBox
clebertsuconic opened a new pull request #2673: NO-JIRA fix EmbeddedJMSResourceTopicTest URL: https://github.com/apache/activemq-artemis/pull/2673 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2670: ARTEMIS-2339 Set JMS Name on compatible destinations

2019-05-16 Thread GitBox
clebertsuconic commented on issue #2670: ARTEMIS-2339 Set JMS Name on compatible destinations URL: https://github.com/apache/activemq-artemis/pull/2670#issuecomment-493061933 @ehsavoie can you do some testing on this? I want to make sure your tests are ok before I merge this.

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-16 Thread GitBox
franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r284586047 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-16 Thread GitBox
franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r284581196 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-16 Thread GitBox
franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r284573276 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-16 Thread GitBox
franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r284585343 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file

2019-05-16 Thread GitBox
franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r284583148 ## File path:

[GitHub] [activemq-artemis] tabish121 commented on issue #2671: NO-JIRA return security errors for unauthorized anonymous sasl

2019-05-16 Thread GitBox
tabish121 commented on issue #2671: NO-JIRA return security errors for unauthorized anonymous sasl URL: https://github.com/apache/activemq-artemis/pull/2671#issuecomment-493151175 Certainly seems worthy of a JIRA to me. This

[GitHub] [activemq-artemis] brusdev opened a new pull request #2671: NO-JIRA return security errors for unauthorized anonymous sasl

2019-05-16 Thread GitBox
brusdev opened a new pull request #2671: NO-JIRA return security errors for unauthorized anonymous sasl URL: https://github.com/apache/activemq-artemis/pull/2671 When user attempts unauthorized anonymous sasl the broker can return an error of 'failed' instead of the security error that

[GitHub] [activemq-artemis] asfgit merged pull request #2665: ARTEMIS-2335 Fixing delivery logic for message group on negative attemps

2019-05-10 Thread GitBox
asfgit merged pull request #2665: ARTEMIS-2335 Fixing delivery logic for message group on negative attemps URL: https://github.com/apache/activemq-artemis/pull/2665 This is an automated message from the Apache Git Service.

[GitHub] [activemq] bd2019us opened a new pull request #357: [AMQ-7199] Replace Math.Random with Random.nextDouble

2019-05-10 Thread GitBox
bd2019us opened a new pull request #357: [AMQ-7199] Replace Math.Random with Random.nextDouble URL: https://github.com/apache/activemq/pull/357 [AMQ-7199](https://issues.apache.org/jira/browse/AMQ-7199) For better control over randomness and comparatively less performance overhead,

[GitHub] [activemq-artemis] jbertram opened a new pull request #2668: ARTEMIS-2334 avoid potential NPE

2019-05-14 Thread GitBox
jbertram opened a new pull request #2668: ARTEMIS-2334 avoid potential NPE URL: https://github.com/apache/activemq-artemis/pull/2668 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2670: ARTEMIS-2339 Set JMS Name on compatible destinations

2019-05-20 Thread GitBox
clebertsuconic commented on issue #2670: ARTEMIS-2339 Set JMS Name on compatible destinations URL: https://github.com/apache/activemq-artemis/pull/2670#issuecomment-494125713 this is ok now... @ehsavoie ran tests and this is not breaking anything

[GitHub] [activemq-artemis] asfgit closed pull request #2649: NO-JIRA Fix test

2019-04-30 Thread GitBox
asfgit closed pull request #2649: NO-JIRA Fix test URL: https://github.com/apache/activemq-artemis/pull/2649 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279879127 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279907383 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2649: NO-JIRA Fix test

2019-04-30 Thread GitBox
clebertsuconic commented on issue #2649: NO-JIRA Fix test URL: https://github.com/apache/activemq-artemis/pull/2649#issuecomment-488044769 @franz1981 I changed the test, and pushed using this PR as a reference This is an

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279894438 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279860473 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279864970 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279862029 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279862029 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279877569 ## File path:

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
clebertsuconic commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279895059 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279879127 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279879127 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279896623 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-30 Thread GitBox
franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279896623 ## File path:

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487471785 @qihongxu that's super interesting :O TBH I was expecting the patched version to be on par with

[GitHub] [activemq-artemis] franz1981 commented on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 commented on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487471785 @qihongxu that's super interesting :O TBH I was expecting the patched version to be on par with very

[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read

2019-04-29 Thread GitBox
franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-487471785 @qihongxu that's super interesting :O TBH I was expecting the patched version to be on par with

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-29 Thread GitBox
michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279259143 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-29 Thread GitBox
michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279259143 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-29 Thread GitBox
michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279259143 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

2019-04-29 Thread GitBox
michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476844 Just one example of classes that really really should be their own class is the codec algo

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-29 Thread GitBox
michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279274791 ## File path:

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement

2019-04-29 Thread GitBox
franz1981 commented on a change in pull request #2645: ARTEMIS-2321 Paging scalability and GC improvement URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279275072 ## File path:

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

2019-04-29 Thread GitBox
michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476844 Just one example of classes that should be their own class is the algo implementations.

[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning

2019-04-29 Thread GitBox
michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476844 Just one example of classes that should be their own class is the codec algo implementations.

<    5   6   7   8   9   10   11   12   13   14   >