[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332279613 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ## @@ -4215,17 +4222,27

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332279696 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ## @@ -4215,17 +4222,27

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332273651 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java ## @@ -363,6 +363,10 @@

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332259393 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/IScheduledQueryMaintenanceService.java ## @@ -0,0 +1,19 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331670594 ## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/schq/TestScheduledQueryIntegration.java ## @@ -0,0 +1,183 @@ +/* + *

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332263137 ## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java ## @@ -667,6

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332283837 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestMetastoreScheduledQueries.java

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332154141 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ## @@ -2066,6 +2074,71 @@ dropMaterializedViewStatement : KW_DROP

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332264490 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/ScheduledQueryExecutionContext.java ## @@ -0,0 +1,36 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331673256 ## File path: itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java.orig ## @@ -0,0 +1,1053 @@ +/* Review comment: This

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332262473 ## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java ## @@ -667,6

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332261373 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/ScheduledQueryExecutionService.java ## @@ -0,0 +1,159 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332252082 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ScheduledQueryAnalyzer.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332256744 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java ## @@ -196,7 +196,11 @@ DROP_POOL("DROP POOL",

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332255167 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ScheduledQueryAnalyzer.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332255906 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java ## @@ -2318,4 +2318,10 @@ public void

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331843882 ## File path: itests/util/src/main/java/org/apache/hadoop/hive/ql/qoption/QTestOptionDispatcher.java ## @@ -0,0 +1,81 @@ +/* + * Licensed to

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332280312 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ScheduledQueryExecutionsMaintTask.java ##

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332276521 ## File path: ql/src/test/queries/clientpositive/sysdb_schq.q ## @@ -0,0 +1,38 @@ +--! qt:scheduledqueryservice +--! qt:dataset:src + +source

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332263885 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -1754,6 +1754,57 @@ struct

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332149917 ## File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/ScheduledQueryCreationRegistryHook.java ## @@ -0,0 +1,38 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331850284 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/schq/ScheduledQueryMaintTask.java ## @@ -0,0 +1,46 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332150024 ## File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java ## @@ -310,7 +310,7 @@ private void verifyState(QueryPlan

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332261097 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/ScheduledQueryExecutionContext.java ## @@ -0,0 +1,36 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332280503 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MScheduledExecution.java ## @@ -0,0

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r330129801 ## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ## @@ -4771,6 +4772,19 @@ private static void

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332256997 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/MetastoreBasedScheduledQueryService.java ## @@ -0,0 +1,64 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332256244 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ScheduledQueryAnalyzer.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331850345 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/schq/ScheduledQueryMaintTask.java ## @@ -0,0 +1,46 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332157079 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ## @@ -2066,6 +2074,71 @@ dropMaterializedViewStatement : KW_DROP

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332280126 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ## @@ -12583,4

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332282330 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestMetastoreScheduledQueries.java

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331850110 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/schq/ScheduledQueryMaintTask.java ## @@ -0,0 +1,46 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331846838 ## File path: metastore/scripts/upgrade/hive/hive-schema-4.0.0.hive.sql ## @@ -1552,3 +1611,41 @@ WHERE AND

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332237943 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ScheduledQueryAnalyzer.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332275454 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/ScheduledQueryExecutionService.java ## @@ -0,0 +1,159 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332256449 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java ## @@ -166,6 +166,10 @@ private static

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331670949 ## File path: itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestRestrictedList.java ## @@ -64,7 +64,9 @@ public static void

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332283611 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestMetastoreScheduledQueries.java

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332282027 ## File path: standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql ## @@ -18,6 +18,36 @@ UPDATE

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331849457 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/IScheduledQueryMaintenanceService.java ## @@ -0,0 +1,19 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332278060 ## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java ## @@ -3905,4

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332279975 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ## @@ -12583,4

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332269978 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/ScheduledQueryExecutionService.java ## @@ -0,0 +1,159 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332273015 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/ScheduledQueryMaintWork.java ## @@ -0,0 +1,27 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332270501 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/ScheduledQueryExecutionService.java ## @@ -0,0 +1,159 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332256819 ## File path: ql/src/java/org/apache/hadoop/hive/ql/schq/IScheduledQueryMaintenanceService.java ## @@ -0,0 +1,19 @@ +package

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331849694 ## File path: ql/src/java/org/apache/hadoop/hive/ql/Context.java ## @@ -170,6 +170,7 @@ // Load data rewrite private Table

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r331673021 ## File path: itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java ## @@ -266,6 +285,25 @@ public void

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332244066 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ScheduledQueryAnalyzer.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache

[GitHub] [hive] jcamachor commented on a change in pull request #794: HIVE-21884

2019-10-07 Thread GitBox
jcamachor commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r332274057 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ## @@ -2066,6 +2074,71 @@ dropMaterializedViewStatement : KW_DROP

[GitHub] [hive] jcamachor closed pull request #799: HIVE-22252: Fix caught NullPointerExceptions generated during EXPLAIN

2019-10-07 Thread GitBox
jcamachor closed pull request #799: HIVE-22252: Fix caught NullPointerExceptions generated during EXPLAIN URL: https://github.com/apache/hive/pull/799 This is an automated message from the Apache Git Service. To respond to