[GitHub] [hive] sunchao opened a new pull request #2273: HIVE-18147 : Tests can fail with java.net.BindException: Address already in use

sunchao opened a new pull request #2273: URL: https://github.com/apache/hive/pull/2273 This backports HIVE-18147 to branch-2.3 to fix a few flaky tests. I'll let the PR to run through CI and directly cherry-pick the commits if CI looks good. -- This is an automated message from the

[GitHub] [hive] akatona84 opened a new pull request #2275: HIVE-25116: Exclude slf4j from hive-exec uber Jar included by avatica

akatona84 opened a new pull request #2275: URL: https://github.com/apache/hive/pull/2275 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was

[GitHub] [hive] pvary commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

pvary commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r632407545 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +334,42 @@ private static String

[GitHub] [hive] adrian-wang commented on pull request #2276: HIVE-21200: Vectorization: date column throwing java.lang.Unsupported…

adrian-wang commented on pull request #2276: URL: https://github.com/apache/hive/pull/2276#issuecomment-841123252 @sunchao Could you please help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hive] szehon-ho commented on pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x

szehon-ho commented on pull request #2080: URL: https://github.com/apache/hive/pull/2080#issuecomment-841128826 It looks good to me, don't have write access to the repo though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hive] pvary commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

pvary commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r632407679 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +334,42 @@ private static String

[GitHub] [hive] deniskuzZ commented on a change in pull request #2274: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state

deniskuzZ commented on a change in pull request #2274: URL: https://github.com/apache/hive/pull/2274#discussion_r632397219 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java ## @@ -305,17 +302,21 @@

[GitHub] [hive] pvary commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

pvary commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r632404816 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +334,42 @@ private static String

[GitHub] [hive] pvary commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

pvary commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r632408645 ## File path: iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerTestUtils.java ## @@ -68,6 +68,7 @@ static

[GitHub] [hive] deniskuzZ commented on a change in pull request #2274: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state

deniskuzZ commented on a change in pull request #2274: URL: https://github.com/apache/hive/pull/2274#discussion_r632418906 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java ## @@ -305,17 +302,21 @@

[GitHub] [hive] pvary commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

pvary commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r632409952 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java ## @@ -307,7 +307,7 @@ private void

[GitHub] [hive] kgyrtkirk commented on pull request #2254: HIVE-23756: Add foreign keys to jdo file

kgyrtkirk commented on pull request #2254: URL: https://github.com/apache/hive/pull/2254#issuecomment-841198582 Great idea! Thank you for working on this! I'm not sure if the jira reference is correct; you may even create a new ticket - and reference the other that this will solve

[GitHub] [hive] deniskuzZ commented on a change in pull request #2272: HIVE-25113: Connection starvation in TxnHandler.getValidWriteIds

deniskuzZ commented on a change in pull request #2272: URL: https://github.com/apache/hive/pull/2272#discussion_r632445375 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -466,25 +466,30 @@ public

[GitHub] [hive] deniskuzZ commented on a change in pull request #2272: HIVE-25113: Connection starvation in TxnHandler.getValidWriteIds

deniskuzZ commented on a change in pull request #2272: URL: https://github.com/apache/hive/pull/2272#discussion_r632448235 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -1792,6 +1807,9 @@ private

[GitHub] [hive] deniskuzZ merged pull request #2275: HIVE-25116: Exclude slf4j from hive-exec uber Jar included by avatica

deniskuzZ merged pull request #2275: URL: https://github.com/apache/hive/pull/2275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] kgyrtkirk commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

kgyrtkirk commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r632471606 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -690,7 +692,9 @@ struct ForeignKeysRequest { 2: string

[GitHub] [hive] kgyrtkirk commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

kgyrtkirk commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r632473124 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -701,6 +705,8 @@ struct UniqueConstraintsRequest { 1:

[GitHub] [hive] kgyrtkirk commented on a change in pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

kgyrtkirk commented on a change in pull request #2211: URL: https://github.com/apache/hive/pull/2211#discussion_r632474203 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java ## @@ -2688,13 +2734,21 @@ long

[GitHub] [hive] deniskuzZ opened a new pull request #2277: Avoid piling up compaction_queue entries in 'ready for cleaning' state

deniskuzZ opened a new pull request #2277: URL: https://github.com/apache/hive/pull/2277 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [hive] sunchao commented on a change in pull request #2276: HIVE-21200: Vectorization: date column throwing java.lang.Unsupported…

sunchao commented on a change in pull request #2276: URL: https://github.com/apache/hive/pull/2276#discussion_r632796159 ## File path: ql/src/test/org/apache/hadoop/hive/ql/io/parquet/VectorizedColumnReaderTestBase.java ## @@ -372,6 +374,35 @@ protected void longRead(boolean

[GitHub] [hive] kishendas commented on a change in pull request #2272: HIVE-25113: Connection starvation in TxnHandler.getValidWriteIds

kishendas commented on a change in pull request #2272: URL: https://github.com/apache/hive/pull/2272#discussion_r632810253 ## File path: ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandlerWithOneConnection.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache

[GitHub] [hive] kishendas commented on a change in pull request #2238: HIVE-25085: MetaStore Clients no longer shared across sessions.

kishendas commented on a change in pull request #2238: URL: https://github.com/apache/hive/pull/2238#discussion_r632839815 ## File path: ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ## @@ -2210,6 +2218,18 @@ public void endScope(String queryId) { public

[GitHub] [hive] kishendas commented on pull request #2238: HIVE-25085: MetaStore Clients no longer shared across sessions.

kishendas commented on pull request #2238: URL: https://github.com/apache/hive/pull/2238#issuecomment-841530958 How was this patch tested? We ran 10 beeline clients concurrently over a span of 6 hours to reproduce the original problem. With the fix, we were no longer able to

[GitHub] [hive] hsnusonic commented on a change in pull request #2272: HIVE-25113: Connection starvation in TxnHandler.getValidWriteIds

hsnusonic commented on a change in pull request #2272: URL: https://github.com/apache/hive/pull/2272#discussion_r632845951 ## File path: ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandlerWithOneConnection.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache

[GitHub] [hive] kishendas commented on a change in pull request #2272: HIVE-25113: Connection starvation in TxnHandler.getValidWriteIds

kishendas commented on a change in pull request #2272: URL: https://github.com/apache/hive/pull/2272#discussion_r632847770 ## File path: ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandlerWithOneConnection.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache

[GitHub] [hive] jcamachor merged pull request #2263: HIVE-25105: Support Parquet as MV storage format

jcamachor merged pull request #2263: URL: https://github.com/apache/hive/pull/2263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] klcopp opened a new pull request #2274: HIVE-25115: Compaction queue entries may accumulate in "ready for cleaning" state

klcopp opened a new pull request #2274: URL: https://github.com/apache/hive/pull/2274 See HIVE-25115 ### How was this patch tested? Unit test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] akatona84 commented on pull request #2275: HIVE-25116: Exclude slf4j from hive-exec uber Jar included by avatica

akatona84 commented on pull request #2275: URL: https://github.com/apache/hive/pull/2275#issuecomment-841098597 @deniskuzZ could you review this pls? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] adrian-wang opened a new pull request #2276: HIVE-21200: Vectorization: date column throwing java.lang.Unsupported…

adrian-wang opened a new pull request #2276: URL: https://github.com/apache/hive/pull/2276 …OperationException for parquet ### What changes were proposed in this pull request? The date type should be treated as int instead of long. ### Why are the changes needed?

[GitHub] [hive] pvary commented on a change in pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

pvary commented on a change in pull request #2261: URL: https://github.com/apache/hive/pull/2261#discussion_r632405632 ## File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java ## @@ -284,4 +334,42 @@ private static String

[GitHub] [hive] abstractdog opened a new pull request #2278: HIVE-24945: Support vectorization for lead/lag functions

abstractdog opened a new pull request #2278: URL: https://github.com/apache/hive/pull/2278 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How

[GitHub] [hive] belugabehr closed pull request #2269: HIVE-25111: Metastore Catalog Methods JDO Persistence

belugabehr closed pull request #2269: URL: https://github.com/apache/hive/pull/2269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] belugabehr commented on pull request #2269: HIVE-25111: Metastore Catalog Methods JDO Persistence

belugabehr commented on pull request #2269: URL: https://github.com/apache/hive/pull/2269#issuecomment-841438042 @miklosgergely Nothing about this project can be easy. Oh well. Thanks for the review, but clearly this would be a bigger effort than I had imagined/hoped. -- This is an

[GitHub] [hive] belugabehr edited a comment on pull request #2269: HIVE-25111: Metastore Catalog Methods JDO Persistence

belugabehr edited a comment on pull request #2269: URL: https://github.com/apache/hive/pull/2269#issuecomment-841438042 @miklosgergely Nothing about this project can be easy. Oh well. Thanks for the review, but clearly (based on the unit tests) this would be a bigger effort than I had

[GitHub] [hive] yongzhi merged pull request #2201: HIVE-25039: Disabling discovery.partitions config for external tables

yongzhi merged pull request #2201: URL: https://github.com/apache/hive/pull/2201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] yongzhi merged pull request #2075: HIVE-24816: Jackson version changed to 2.11.0 in the pom files

yongzhi merged pull request #2075: URL: https://github.com/apache/hive/pull/2075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] belugabehr commented on pull request #2269: HIVE-25111: Metastore Catalog Methods JDO Persistence

belugabehr commented on pull request #2269: URL: https://github.com/apache/hive/pull/2269#issuecomment-841454459 @miklosgergely `ObjectStore` cannot decide what it wants to be. Each method has its own transaction handling, but there are times, such as in `HMSHandler::create_catalog`

[GitHub] [hive] belugabehr edited a comment on pull request #2269: HIVE-25111: Metastore Catalog Methods JDO Persistence

belugabehr edited a comment on pull request #2269: URL: https://github.com/apache/hive/pull/2269#issuecomment-841454459 @miklosgergely `ObjectStore` cannot decide what it wants to be. Each method has its own transaction handling, but there are times, such as in

[GitHub] [hive] hsnusonic commented on pull request #2272: HIVE-25113: Connection starvation in TxnHandler.getValidWriteIds

hsnusonic commented on pull request #2272: URL: https://github.com/apache/hive/pull/2272#issuecomment-841459608 @kishendas @deniskuzZ Thanks for the suggestions. Please check if there is any concerns. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hive] mustafaiman commented on pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF

mustafaiman commented on pull request #2242: URL: https://github.com/apache/hive/pull/2242#issuecomment-841363674 @abstractdog @rbalamohan are you ok with the latest patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hive] scarlin-cloudera commented on a change in pull request #2238: HIVE-25085: MetaStore Clients no longer shared across sessions.

scarlin-cloudera commented on a change in pull request #2238: URL: https://github.com/apache/hive/pull/2238#discussion_r632669443 ## File path: ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ## @@ -1869,7 +1874,10 @@ public void close() throws IOException {

[GitHub] [hive] sunchao commented on pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x

sunchao commented on pull request #2080: URL: https://github.com/apache/hive/pull/2080#issuecomment-841376548 Thanks @szehon-ho ! tests failure are unrelated (they are known existing flaky tests). Merging to branch-2.3. -- This is an automated message from the Apache Git Service. To

[GitHub] [hive] sunchao merged pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x

sunchao merged pull request #2080: URL: https://github.com/apache/hive/pull/2080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] scarlin-cloudera commented on a change in pull request #2238: HIVE-25085: MetaStore Clients no longer shared across sessions.

scarlin-cloudera commented on a change in pull request #2238: URL: https://github.com/apache/hive/pull/2238#discussion_r632672635 ## File path: ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java ## @@ -1869,7 +1874,10 @@ public void close() throws IOException {

[GitHub] [hive] scarlin-cloudera commented on a change in pull request #2238: HIVE-25085: MetaStore Clients no longer shared across sessions.

scarlin-cloudera commented on a change in pull request #2238: URL: https://github.com/apache/hive/pull/2238#discussion_r632676371 ## File path: service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ## @@ -408,18 +400,10 @@ private synchronized void

[GitHub] [hive] szehon-ho commented on pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x

szehon-ho commented on pull request #2080: URL: https://github.com/apache/hive/pull/2080#issuecomment-841386933 Sounds good, and I got the write access :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] sunchao merged pull request #2273: HIVE-18147 : Tests can fail with java.net.BindException: Address already in use

sunchao merged pull request #2273: URL: https://github.com/apache/hive/pull/2273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] sunchao commented on pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x

sunchao commented on pull request #2080: URL: https://github.com/apache/hive/pull/2080#issuecomment-841387554 Ah cool! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.