[GitHub] [arrow] jorgecarleitao opened a new pull request #8730: ARROW-10673: [Rust] [DataFusion] Made sort not collect on `execute`.

jorgecarleitao opened a new pull request #8730: URL: https://github.com/apache/arrow/pull/8730 Currently, we `collect` and `sort` the record batches from the incoming part of `Sort` on `execute`. However, there is no need to do so: we can postpone that to the stream, like we do for our

[GitHub] [arrow] github-actions[bot] commented on pull request #8729: ARROW-10672: [Rust] [DataFusion] Made Limit be computed on the stream.

github-actions[bot] commented on pull request #8729: URL: https://github.com/apache/arrow/pull/8729#issuecomment-731515022 https://issues.apache.org/jira/browse/ARROW-10672 This is an automated message from the Apache Git

[GitHub] [arrow] jorgecarleitao opened a new pull request #8729: ARROW-10672: [Rust] [DataFusion] Made Limit be computed on the stream.

jorgecarleitao opened a new pull request #8729: URL: https://github.com/apache/arrow/pull/8729 Currently, the `Limit` operator in DataFusion collects all batches `ExecutionPlan::execute` to memory and returns a `MemoryExec` that mimics a stream. This can cause an expensive execution to

[GitHub] [arrow] velvia commented on a change in pull request #8688: ARROW-10330: [Rust][DataFusion] Implement NULLIF() SQL function

velvia commented on a change in pull request #8688: URL: https://github.com/apache/arrow/pull/8688#discussion_r528052210 ## File path: rust/arrow/src/compute/kernels/boolean.rs ## @@ -457,4 +517,42 @@ mod tests { assert_eq!(true, res.value(2));

[GitHub] [arrow] alamb commented on pull request #8545: ARROW-9674: [Rust] Make the parquet read and writers Send

alamb commented on pull request #8545: URL: https://github.com/apache/arrow/pull/8545#issuecomment-731468020 > Beat me to the merge @alamb by seconds  Sorry @nevi-me ! This is an automated message from the Apache

[GitHub] [arrow] github-actions[bot] commented on pull request #8728: ARROW-10669: [C++][Compute] Support scalar arguments to Boolean compute functions

github-actions[bot] commented on pull request #8728: URL: https://github.com/apache/arrow/pull/8728#issuecomment-731442083 https://issues.apache.org/jira/browse/ARROW-10669 This is an automated message from the Apache Git

[GitHub] [arrow] bkietz commented on a change in pull request #8703: ARROW-10143: [C++] Rewrite Array(Range)Equals

bkietz commented on a change in pull request #8703: URL: https://github.com/apache/arrow/pull/8703#discussion_r526259632 ## File path: cpp/src/arrow/ipc/feather_test.cc ## @@ -286,10 +286,13 @@ TEST_P(TestFeather, PrimitiveNullRoundTrip) { std::vector> expected_fields;

[GitHub] [arrow] bkietz closed pull request #8679: ARROW-10619: [C++] Fix IPC validation regressions

bkietz closed pull request #8679: URL: https://github.com/apache/arrow/pull/8679 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] andygrove commented on pull request #8709: ARROW-9555: [Rust] [DataFusion] Implement physical node for inner join

andygrove commented on pull request #8709: URL: https://github.com/apache/arrow/pull/8709#issuecomment-731435487 I will be reviewing this tomorrow (Saturday). Thanks for all the work on this @jorgecarleitao This is an

[GitHub] [arrow] bkietz closed pull request #8461: ARROW-10197: [python][Gandiva] Execute expression on filtered data

bkietz closed pull request #8461: URL: https://github.com/apache/arrow/pull/8461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] bkietz opened a new pull request #8728: ARROW-10669: [C++][Compute] Support scalar arguments to Boolean compute functions

bkietz opened a new pull request #8728: URL: https://github.com/apache/arrow/pull/8728 - "and", "or", "xor", "and_kleene", and "or_kleene" gain support for scalar arguments. - Added new functions "and_not" and "and_not_kleene" - repaired and simplified some null propagation logic

[GitHub] [arrow] nevi-me commented on pull request #8545: ARROW-9674: [Rust] Make the parquet read and writers Send

nevi-me commented on pull request #8545: URL: https://github.com/apache/arrow/pull/8545#issuecomment-731429329 Beat me to the merge @alamb by seconds This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] alamb closed pull request #8545: ARROW-9674: [Rust] Make the parquet read and writers Send

alamb closed pull request #8545: URL: https://github.com/apache/arrow/pull/8545 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] alamb commented on a change in pull request #8545: ARROW-9674: [Rust] Make the parquet read and writers Send

alamb commented on a change in pull request #8545: URL: https://github.com/apache/arrow/pull/8545#discussion_r527993120 ## File path: rust/parquet/src/util/memory.rs ## @@ -39,37 +41,39 @@ pub type WeakMemTrackerPtr = Weak; pub struct MemTracker { // In the tuple, the

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527990761 ## File path: csharp/src/Apache.Arrow.Flight/StreamWriter.cs ## @@ -0,0 +1,51 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [arrow] lyndonb-bq commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lyndonb-bq commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527985763 ## File path: cpp/src/arrow/flight/client_header_auth_middleware.cc ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] sunchao commented on a change in pull request #8726: ARROW-10667: [Rust] [Parquet] Add a convenience type for writing Parquet to memory

sunchao commented on a change in pull request #8726: URL: https://github.com/apache/arrow/pull/8726#discussion_r527982715 ## File path: rust/parquet/src/util/cursor.rs ## @@ -129,6 +132,56 @@ impl Seek for SliceableCursor { } } +/// Use this type to write Parquet to

[GitHub] [arrow] lyndonb-bq commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lyndonb-bq commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527982262 ## File path: cpp/src/arrow/flight/client.h ## @@ -65,6 +65,9 @@ class ARROW_FLIGHT_EXPORT FlightCallOptions { /// \brief IPC writer options, if

[GitHub] [arrow] lyndonb-bq commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lyndonb-bq commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527981869 ## File path: cpp/src/arrow/flight/client.cc ## @@ -993,6 +998,30 @@ class FlightClient::FlightClientImpl { return Status::OK(); } + Status

[GitHub] [arrow] Dandandan edited a comment on pull request #8723: ARROW-10665: [Rust] like utf8 scalar fast paths

Dandandan edited a comment on pull request #8723: URL: https://github.com/apache/arrow/pull/8723#issuecomment-731417468 I think it can use some additional tests as I think there is a bug in the current implementation. Will probably have some time tomorrow to finalize the PR.

[GitHub] [arrow] Dandandan commented on pull request #8723: ARROW-10665: [Rust] like utf8 scalar fast paths

Dandandan commented on pull request #8723: URL: https://github.com/apache/arrow/pull/8723#issuecomment-731417468 I think it can use some additional tests as I think there is a bug in the current implementation. Will probably have some time tomorrow.

[GitHub] [arrow] alamb commented on a change in pull request #8726: ARROW-10667: [Rust] [Parquet] Add a convenience type for writing Parquet to memory

alamb commented on a change in pull request #8726: URL: https://github.com/apache/arrow/pull/8726#discussion_r527978914 ## File path: rust/parquet/src/util/cursor.rs ## @@ -129,6 +132,56 @@ impl Seek for SliceableCursor { } } +/// Use this type to write Parquet to

[GitHub] [arrow] lyndonb-bq commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lyndonb-bq commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527979053 ## File path: cpp/src/arrow/flight/client.cc ## @@ -963,8 +967,9 @@ class FlightClient::FlightClientImpl { std::vector> interceptors; +

[GitHub] [arrow] lidavidm commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lidavidm commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527973482 ## File path: cpp/src/arrow/flight/client.h ## @@ -191,6 +194,14 @@ class ARROW_FLIGHT_EXPORT FlightClient { Status Authenticate(const

[GitHub] [arrow] lyndonb-bq commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lyndonb-bq commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527978639 ## File path: cpp/src/arrow/flight/client.cc ## @@ -371,7 +375,7 @@ class GrpcClientInterceptorAdapterFactory } private: - std::vector>

[GitHub] [arrow] jorgecarleitao closed pull request #8640: ARROW-4193: [Rust] Add support for decimal data type

jorgecarleitao closed pull request #8640: URL: https://github.com/apache/arrow/pull/8640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527973234 ## File path: csharp/src/Apache.Arrow.Flight/FlightDescriptor.cs ## @@ -0,0 +1,105 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [arrow] lidavidm edited a comment on pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lidavidm edited a comment on pull request #8724: URL: https://github.com/apache/arrow/pull/8724#issuecomment-731407237 Note, for formatting, use clang-format; for naming conventions, please follow Google C++ guidelines. See the [developer

[GitHub] [arrow] lidavidm commented on pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lidavidm commented on pull request #8724: URL: https://github.com/apache/arrow/pull/8724#issuecomment-731407237 Note, for formatting, use clang-format; for naming conventions, please follow Google C++ guidelines. See the [developer

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527969900 ## File path: cpp/src/arrow/flight/client_header_auth_middleware.h ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527969260 ## File path: csharp/src/Apache.Arrow.Flight/FlightInfo.cs ## @@ -0,0 +1,69 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527969332 ## File path: cpp/src/arrow/flight/client_header_auth_middleware.cc ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527969075 ## File path: cpp/src/arrow/flight/client_header_auth_middleware.cc ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527968738 ## File path: cpp/src/arrow/flight/client_header_auth_middleware.cc ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527968568 ## File path: cpp/src/arrow/flight/client_header_auth_middleware.cc ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] lyndonb-bq commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lyndonb-bq commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527968403 ## File path: cpp/src/arrow/flight/client.cc ## @@ -51,6 +51,7 @@ #include "arrow/flight/client_auth.h" #include "arrow/flight/client_middleware.h"

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527968462 ## File path: cpp/src/arrow/flight/client_header_auth_middleware.cc ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527968005 ## File path: cpp/src/arrow/flight/client.cc ## @@ -993,6 +998,30 @@ class FlightClient::FlightClientImpl { return Status::OK(); } + Status

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527967753 ## File path: cpp/src/arrow/flight/client.cc ## @@ -993,6 +998,30 @@ class FlightClient::FlightClientImpl { return Status::OK(); } + Status

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527967517 ## File path: cpp/src/arrow/flight/client.cc ## @@ -963,8 +967,9 @@ class FlightClient::FlightClientImpl { std::vector> interceptors; +

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527967227 ## File path: cpp/src/arrow/flight/client.cc ## @@ -328,7 +332,7 @@ class GrpcClientInterceptorAdapterFactory : public

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527967374 ## File path: cpp/src/arrow/flight/client.cc ## @@ -371,7 +375,7 @@ class GrpcClientInterceptorAdapterFactory } private: - std::vector>

[GitHub] [arrow] kylepbit commented on a change in pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

kylepbit commented on a change in pull request #8724: URL: https://github.com/apache/arrow/pull/8724#discussion_r527966995 ## File path: cpp/src/arrow/flight/client.cc ## @@ -51,6 +51,7 @@ #include "arrow/flight/client_auth.h" #include "arrow/flight/client_middleware.h"

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527966241 ## File path: csharp/src/Apache.Arrow.Flight/FlightInfo.cs ## @@ -0,0 +1,69 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[GitHub] [arrow] jorgecarleitao commented on pull request #8709: ARROW-9555: [Rust] [DataFusion] Implement physical node for inner join

jorgecarleitao commented on pull request #8709: URL: https://github.com/apache/arrow/pull/8709#issuecomment-731394905 I've added a couple of more tests verifying that the parts of the join are correct. I promoted this PR out of a draft, as I am now confident that at least we would not

[GitHub] [arrow] github-actions[bot] commented on pull request #8726: ARROW-10667: [Rust] [Parquet] Add a convenience type for writing Parquet to memory

github-actions[bot] commented on pull request #8726: URL: https://github.com/apache/arrow/pull/8726#issuecomment-731385061 https://issues.apache.org/jira/browse/ARROW-10667 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #8727: ARROW-10666: [Rust][DataFusion] Support nested SELECT statements.

github-actions[bot] commented on pull request #8727: URL: https://github.com/apache/arrow/pull/8727#issuecomment-731385060 https://issues.apache.org/jira/browse/ARROW-10666 This is an automated message from the Apache Git

[GitHub] [arrow] drusso opened a new pull request #8727: ARROW-10666: [Rust][DataFusion] Support nested SELECT statements.

drusso opened a new pull request #8727: URL: https://github.com/apache/arrow/pull/8727 This PR enables nested `SELECT` statements. Note that table aliases remain unsupported, and no optimizations are made during the planning stages.

[GitHub] [arrow] carols10cents opened a new pull request #8726: ARROW-10667: [Rust] [Parquet] Add a convenience type for writing Parquet to memory

carols10cents opened a new pull request #8726: URL: https://github.com/apache/arrow/pull/8726 Similar to the [`SliceableCursor`](https://github.com/apache/arrow/blob/0e841aa666b637e24e2889acab7621aa01fb7bcf/rust/parquet/src/util/cursor.rs#L22-L27) type that provides a convenience for

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527932397 ## File path: csharp/src/Apache.Arrow.Flight/Action.cs ## @@ -0,0 +1,71 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527932397 ## File path: csharp/src/Apache.Arrow.Flight/Action.cs ## @@ -0,0 +1,71 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527931177 ## File path: csharp/src/Apache.Arrow.Flight/Ticket.cs ## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527930299 ## File path: csharp/src/Apache.Arrow.Flight/FlightInfo.cs ## @@ -0,0 +1,69 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527927449 ## File path: csharp/src/Apache.Arrow.Flight/FlightClient.cs ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [arrow] Ulimo commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

Ulimo commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527927422 ## File path: csharp/src/Apache.Arrow.Flight/Ticket.cs ## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527926764 ## File path: csharp/src/Apache.Arrow.Flight/FlightClient.cs ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [arrow] nevi-me commented on a change in pull request #8722: ARROW-10664: [Rust] Implement AVX512 sort

nevi-me commented on a change in pull request #8722: URL: https://github.com/apache/arrow/pull/8722#discussion_r527926242 ## File path: rust/arrow/src/arch/avx512.rs ## @@ -41,6 +41,155 @@ pub(crate) unsafe fn avx512_bin_or(left: &[u8], right: &[u8], res: [u8]) {

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527923215 ## File path: csharp/src/Apache.Arrow.Flight/Ticket.cs ## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[GitHub] [arrow] eerhardt commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on a change in pull request #8694: URL: https://github.com/apache/arrow/pull/8694#discussion_r527921442 ## File path: csharp/src/Apache.Arrow.Flight/Apache.Arrow.Flight.csproj ## @@ -0,0 +1,21 @@ + + + +netstandard2.1 + + + + + + +

[GitHub] [arrow] jhorstmann commented on pull request #8685: ARROW-10216: [Rust] Simd implementation for primitive min/max kernels

jhorstmann commented on pull request #8685: URL: https://github.com/apache/arrow/pull/8685#issuecomment-731343546 Both scalar and simd implementations have issues involving null values, I added `ignore` tests with comments. The handling of NaN is also not consistent with the sort kernel,

[GitHub] [arrow] eerhardt closed pull request #8719: ARROW-10661: [C#] Fix benchmarking project

eerhardt closed pull request #8719: URL: https://github.com/apache/arrow/pull/8719 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #8725: ARROW-10526: [FlightRPC][C++][Python] Client cookie middleware

github-actions[bot] commented on pull request #8725: URL: https://github.com/apache/arrow/pull/8725#issuecomment-731336993 https://issues.apache.org/jira/browse/ARROW-10526 This is an automated message from the Apache Git

[GitHub] [arrow] lyndonb-bq opened a new pull request #8725: ARROW-10526: [FlightRPC][C++][Python] Client cookie middleware

lyndonb-bq opened a new pull request #8725: URL: https://github.com/apache/arrow/pull/8725 - Added client cookie middleware which caches and monitors expiry - Added testing for client cookie middleware This is an

[GitHub] [arrow] lyndonb-bq commented on pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lyndonb-bq commented on pull request #8724: URL: https://github.com/apache/arrow/pull/8724#issuecomment-731331899 @lidavidm Hi David, This is currently a work in progress. I was wondering if you could take a look at how this was integrated into the C++ library and let me know if it

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8709: ARROW-9555: [Rust] [DataFusion] Implement physical node for inner join

jorgecarleitao commented on a change in pull request #8709: URL: https://github.com/apache/arrow/pull/8709#discussion_r527880432 ## File path: rust/datafusion/src/physical_plan/hash_join.rs ## @@ -0,0 +1,507 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8709: ARROW-9555: [Rust] [DataFusion] Implement physical node for inner join

jorgecarleitao commented on a change in pull request #8709: URL: https://github.com/apache/arrow/pull/8709#discussion_r527874498 ## File path: rust/datafusion/src/physical_plan/hash_join.rs ## @@ -0,0 +1,507 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8709: ARROW-9555: [Rust] [DataFusion] Implement physical node for inner join

jorgecarleitao commented on a change in pull request #8709: URL: https://github.com/apache/arrow/pull/8709#discussion_r527873825 ## File path: rust/datafusion/src/physical_plan/hash_join.rs ## @@ -0,0 +1,507 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8709: ARROW-9555: [Rust] [DataFusion] Implement physical node for inner join

jorgecarleitao commented on a change in pull request #8709: URL: https://github.com/apache/arrow/pull/8709#discussion_r527864376 ## File path: rust/datafusion/src/physical_plan/hash_utils.rs ## @@ -0,0 +1,150 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] github-actions[bot] commented on pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

github-actions[bot] commented on pull request #8724: URL: https://github.com/apache/arrow/pull/8724#issuecomment-731302827 https://issues.apache.org/jira/browse/ARROW-10487 This is an automated message from the Apache Git

[GitHub] [arrow] lyndonb-bq opened a new pull request #8724: ARROW-10487 [FlightRPC][C++][Python] Header-based auth in clients

lyndonb-bq opened a new pull request #8724: URL: https://github.com/apache/arrow/pull/8724 Current code is a work in progress - looking to get feedback on design and how it fits into current arrow C++ architecture before finalizing comments and fixing linting issues. - Added

[GitHub] [arrow] Dandandan commented on pull request #8723: ARROW-10665: [Rust] like utf8 scalar fast paths

Dandandan commented on pull request #8723: URL: https://github.com/apache/arrow/pull/8723#issuecomment-731290337 Also looks like there is a bug in the existing implementation (missing anchors), maybe that makes regex faster again. Will follow up later.

[GitHub] [arrow] github-actions[bot] commented on pull request #8723: ARROW-10665: [Rust] like utf8 scalar fast paths

github-actions[bot] commented on pull request #8723: URL: https://github.com/apache/arrow/pull/8723#issuecomment-731289205 https://issues.apache.org/jira/browse/ARROW-10665 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #8723: Like utf8 scalar fast paths

github-actions[bot] commented on pull request #8723: URL: https://github.com/apache/arrow/pull/8723#issuecomment-731282668 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] Dandandan opened a new pull request #8723: Like utf8 fast paths

Dandandan opened a new pull request #8723: URL: https://github.com/apache/arrow/pull/8723 Commonly used patterns '%xxx' 'xxx%' and '%xxx' can use faster methods from Rust standard lib instead. ``` like_utf8 scalar equals time: [828.13 us 830.08 us 832.39 us]

[GitHub] [arrow] ch-sc commented on a change in pull request #8715: ARROW-10656: [Rust] Use DataType comparison without values

ch-sc commented on a change in pull request #8715: URL: https://github.com/apache/arrow/pull/8715#discussion_r527811826 ## File path: rust/arrow/src/datatypes.rs ## @@ -1142,6 +1142,44 @@ impl DataType { | Float64 ) } + +/// Compares this

[GitHub] [arrow] ch-sc commented on a change in pull request #8715: ARROW-10656: [Rust] Use DataType comparison without values

ch-sc commented on a change in pull request #8715: URL: https://github.com/apache/arrow/pull/8715#discussion_r527798357 ## File path: rust/arrow/src/datatypes.rs ## @@ -1142,6 +1142,44 @@ impl DataType { | Float64 ) } + +/// Compares this

[GitHub] [arrow] Ulimo edited a comment on pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

Ulimo edited a comment on pull request #8694: URL: https://github.com/apache/arrow/pull/8694#issuecomment-731254431 @eerhardt I tested it against that solution myself, I will check why its not working. I would love to have a docker container of the java application and use

[GitHub] [arrow] ch-sc commented on a change in pull request #8715: ARROW-10656: [Rust] Use DataType comparison without values

ch-sc commented on a change in pull request #8715: URL: https://github.com/apache/arrow/pull/8715#discussion_r527793254 ## File path: rust/arrow/src/datatypes.rs ## @@ -1142,6 +1142,44 @@ impl DataType { | Float64 ) } + +/// Compares this

[GitHub] [arrow] eerhardt edited a comment on pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt edited a comment on pull request #8694: URL: https://github.com/apache/arrow/pull/8694#issuecomment-731202315 UPDATE: I resolved the below issue with this answer: https://stackoverflow.com/a/58053460/3680432 @Ulimo - how much of this is expected to work

[GitHub] [arrow] eerhardt edited a comment on pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt edited a comment on pull request #8694: URL: https://github.com/apache/arrow/pull/8694#issuecomment-731202315 UPDATE: I resolved the below issue with this answer: https://stackoverflow.com/a/58053460/3680432 @Ulimo - how much of this is expected to work end-to-end? I've

[GitHub] [arrow] ch-sc commented on pull request #8715: ARROW-10656: [Rust] Use DataType comparison without values

ch-sc commented on pull request #8715: URL: https://github.com/apache/arrow/pull/8715#issuecomment-731255930 Thank you all for the quick feedback! > Is the only intended change here to not compare the name of fields? Or do you have other ideas in mind for the future? Well, I

[GitHub] [arrow] Ulimo commented on pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

Ulimo commented on pull request #8694: URL: https://github.com/apache/arrow/pull/8694#issuecomment-731254431 @eerhardt I tested it against that solution myself, I will check why its not working. I would love to have a docker container of the java application and use testcontainers so

[GitHub] [arrow] andygrove commented on a change in pull request #8709: ARROW-9555: [Rust] [DataFusion] Implement physical node for inner join

andygrove commented on a change in pull request #8709: URL: https://github.com/apache/arrow/pull/8709#discussion_r527750363 ## File path: rust/datafusion/src/physical_plan/hash_utils.rs ## @@ -0,0 +1,150 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] alamb commented on pull request #8545: ARROW-9674: [Rust] Make the parquet read and writers Send

alamb commented on pull request #8545: URL: https://github.com/apache/arrow/pull/8545#issuecomment-731214207 I will try and review this either later today or tomorrow morning. On Fri, Nov 20, 2020 at 8:43 AM Wakahisa wrote: > @nevi-me requested

[GitHub] [arrow] andygrove commented on a change in pull request #8709: ARROW-9555: [Rust] [DataFusion] Implement physical node for inner join

andygrove commented on a change in pull request #8709: URL: https://github.com/apache/arrow/pull/8709#discussion_r527740558 ## File path: rust/datafusion/src/physical_plan/hash_utils.rs ## @@ -0,0 +1,150 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] andygrove commented on a change in pull request #8709: ARROW-9555: [Rust] [DataFusion] Implement physical node for inner join

andygrove commented on a change in pull request #8709: URL: https://github.com/apache/arrow/pull/8709#discussion_r527735046 ## File path: rust/datafusion/src/physical_plan/hash_utils.rs ## @@ -0,0 +1,150 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] eerhardt commented on pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core

eerhardt commented on pull request #8694: URL: https://github.com/apache/arrow/pull/8694#issuecomment-731202315 @Ulimo - how much of this is expected to work end-to-end? I've been trying to use it against an example server I found in the repo:

[GitHub] [arrow] nevi-me closed pull request #8718: ARROW-10660: [Rust] Implement AVX-512 bit or operation

nevi-me closed pull request #8718: URL: https://github.com/apache/arrow/pull/8718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #8722: ARROW-10664: [Rust] Implement AVX512 sort

github-actions[bot] commented on pull request #8722: URL: https://github.com/apache/arrow/pull/8722#issuecomment-731171915 https://issues.apache.org/jira/browse/ARROW-10664 This is an automated message from the Apache Git

[GitHub] [arrow] vertexclique opened a new pull request #8722: ARROW-10664: [Rust] Implement AVX512 sort

vertexclique opened a new pull request #8722: URL: https://github.com/apache/arrow/pull/8722 Before: ``` sort 2^10 time: [94.137 us 94.154 us 94.174 us] Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high mild sort 2^12

[GitHub] [arrow] Marwes commented on pull request #8545: ARROW-9674: [Rust] Make the parquet read and writers Send

Marwes commented on pull request #8545: URL: https://github.com/apache/arrow/pull/8545#issuecomment-731113355 The `Cell` needs to be removed to make the buffer types `Send`. Anyway, it is fixed. This is an automated message

[GitHub] [arrow] nevi-me commented on pull request #8545: ARROW-9674: [Rust] Make the parquet read and writers Send

nevi-me commented on pull request #8545: URL: https://github.com/apache/arrow/pull/8545#issuecomment-731108868 The memory tracker changes are failing. Was there a big that you picked up @Marwes? Else we could isolate that, and leave the `Rc` > `Arc` changes, which I'm happy with

[GitHub] [arrow] vertexclique commented on pull request #8717: ARROW-10659: [Ruby] Refactor Table#initialize

vertexclique commented on pull request #8717: URL: https://github.com/apache/arrow/pull/8717#issuecomment-731061718 please ping me when you fix tests, so I can take a look. This is an automated message from the Apache Git

[GitHub] [arrow] KirillLykov commented on pull request #8461: ARROW-10197: [python][Gandiva] Execute expression on filtered data

KirillLykov commented on pull request #8461: URL: https://github.com/apache/arrow/pull/8461#issuecomment-731040216 It looks like I addressed all the comments by @bkietz . The only thing is that the commit history looks a bit too long and I would recommend squashing (don't know project