nevi-me commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r530293315
##
File path: rust/arrow/Cargo.toml
##
@@ -48,11 +49,12 @@ lazy_static = "1.4"
packed_simd = { version = "0.3.4", optional = true, package =
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r530326379
##
File path: rust/arrow/Cargo.toml
##
@@ -48,11 +49,12 @@ lazy_static = "1.4"
packed_simd = { version = "0.3.4", optional = true, package =
nevi-me commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-733668680
> @nevi-me , can I have 12h to review it?
Yup, I more meant that if someone else picks up things they'd like
addressed, we could open JIRAs for them instead of trying to
jorgecarleitao commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r530329221
##
File path: rust/arrow/src/compute/kernels/aggregate.rs
##
@@ -141,32 +146,41 @@ where
match array.data().null_buffer() {
None =>
alamb commented on pull request #8752:
URL: https://github.com/apache/arrow/pull/8752#issuecomment-733678504
Thank you @carols10cents -- this was an epic PR description
This is an automated message from the Apache Git
Dandandan commented on a change in pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#discussion_r530338275
##
File path: rust/benchmarks/Cargo.toml
##
@@ -30,5 +30,5 @@ arrow = { path = "../arrow" }
parquet = { path = "../parquet" }
datafusion = { path =
Dandandan commented on a change in pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#discussion_r530338275
##
File path: rust/benchmarks/Cargo.toml
##
@@ -30,5 +30,5 @@ arrow = { path = "../arrow" }
parquet = { path = "../parquet" }
datafusion = { path =
Dandandan commented on a change in pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#discussion_r530338379
##
File path: rust/datafusion/Cargo.toml
##
@@ -57,7 +57,7 @@ chrono = "0.4"
async-trait = "0.1.41"
futures = "0.3"
pin-project-lite= "^0.2.0"
-tokio
jorgecarleitao commented on a change in pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#discussion_r530348245
##
File path: rust/arrow/src/ffi.rs
##
@@ -0,0 +1,657 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
alamb commented on pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#issuecomment-733686362
FYI @jorgecarleitao
This is an automated message from the Apache Git Service.
To respond to the message, please
bkietz commented on a change in pull request #8735:
URL: https://github.com/apache/arrow/pull/8735#discussion_r530348934
##
File path: cpp/src/arrow/util/logging.h
##
@@ -86,56 +67,40 @@ enum class ArrowLogLevel : int {
#define ARROW_CHECK_GE(val1, val2) ARROW_CHECK((val1) >=
pitrou closed pull request #8474:
URL: https://github.com/apache/arrow/pull/8474
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
maartenbreddels commented on pull request #8621:
URL: https://github.com/apache/arrow/pull/8621#issuecomment-733820473
@pitrou this is ready for review.
This is an automated message from the Apache Git Service.
To respond to
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r530343892
##
File path: rust/arrow/src/compute/kernels/aggregate.rs
##
@@ -141,32 +146,41 @@ where
match array.data().null_buffer() {
None => {
xhochy commented on a change in pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#discussion_r530373157
##
File path: cpp/cmake_modules/DefineOptions.cmake
##
@@ -363,6 +363,8 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
alamb commented on a change in pull request #8751:
URL: https://github.com/apache/arrow/pull/8751#discussion_r530466598
##
File path: rust/datafusion/src/optimizer/projection_push_down.rs
##
@@ -114,6 +114,10 @@ fn optimize_plan(
has_projection: bool,
) -> Result {
jorgecarleitao commented on a change in pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#discussion_r530348245
##
File path: rust/arrow/src/ffi.rs
##
@@ -0,0 +1,657 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
alamb commented on pull request #8745:
URL: https://github.com/apache/arrow/pull/8745#issuecomment-733685460
This time @nevi-me beat me to the merge
This is an automated message from the Apache Git Service.
To respond
jorgecarleitao removed a comment on pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#issuecomment-733687016
:shipit: I also found a regression related to this update in
`datafusion-python` on which the process hangs.
alamb commented on pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#issuecomment-733698117
I am waiting for CI to finish running and then I will merge this in
This is an automated message from the Apache
xhochy commented on a change in pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#discussion_r530417334
##
File path: cpp/cmake_modules/DefineOptions.cmake
##
@@ -363,6 +363,8 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
xhochy closed pull request #8759:
URL: https://github.com/apache/arrow/pull/8759
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
josiahyan commented on pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#issuecomment-733751240
Oh, I know why! The CI queue was full (my test runs were taking hours to go
through). By the time the runner got to my PR (Wed, 25 Nov 2020 02:15:47 GMT),
my final commit had
andygrove commented on a change in pull request #8751:
URL: https://github.com/apache/arrow/pull/8751#discussion_r530496041
##
File path: rust/datafusion/src/logical_plan/plan.rs
##
@@ -114,6 +114,8 @@ pub enum LogicalPlan {
/// The output schema, containing fields
jorgecarleitao commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-733667373
Really impressive improvement, @vertexclique .
@nevi-me , can I have 12h to review it?
alamb opened a new pull request #8769:
URL: https://github.com/apache/arrow/pull/8769
## Changes
This PR backs out the version upgrade to tokio done in
https://github.com/apache/arrow/pull/8697 (see comment
https://github.com/apache/arrow/pull/8697#issuecomment-732936572 by
alamb commented on a change in pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#discussion_r530342400
##
File path: rust/benchmarks/Cargo.toml
##
@@ -30,5 +30,5 @@ arrow = { path = "../arrow" }
parquet = { path = "../parquet" }
datafusion = { path =
jhorstmann commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-733710712
> Introducing thread parallelism at a compute kernel level
Conceptually this is not a small change. Personally I think parallelizing on
the datafusion level and keeping
maartenbreddels commented on pull request #8755:
URL: https://github.com/apache/arrow/pull/8755#issuecomment-733734030
@pitrou this is ready for review
This is an automated message from the Apache Git Service.
To respond to
vertexclique commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-733737357
> Conceptually this is not a small change. Personally I think parallelizing
on the datafusion level and keeping kernels single-threaded is the better model.
I don't
xhochy commented on pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#issuecomment-733745584
Everything failing in https://github.com/apache/arrow/pull/8759 is past the
CMake additions I did here, so this should be good to go.
jorgecarleitao closed pull request #8749:
URL: https://github.com/apache/arrow/pull/8749
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r530327927
##
File path: rust/arrow/src/compute/kernels/aggregate.rs
##
@@ -141,32 +146,41 @@ where
match array.data().null_buffer() {
None => {
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r530328033
##
File path: rust/arrow/src/compute/kernels/aggregate.rs
##
@@ -180,9 +194,12 @@ where
///
/// Returns `None` if the array is empty or only
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r530327927
##
File path: rust/arrow/src/compute/kernels/aggregate.rs
##
@@ -141,32 +146,41 @@ where
match array.data().null_buffer() {
None => {
jorgecarleitao commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r530331929
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,588 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
maartenbreddels commented on pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#issuecomment-733748270
#8459 builds on Travis, looking good
This is an automated message from the Apache Git Service.
To
jorgecarleitao commented on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733815809
Genuinely curious: does the key size has such a large impact? Or is there
any memory constraints that you are looking for?
jorgecarleitao commented on pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#issuecomment-733687016
:shipit: I also found a regression related to this update in
`datafusion-python` on which the process hangs.
alamb closed pull request #8750:
URL: https://github.com/apache/arrow/pull/8750
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vertexclique commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-733773942
> Things to do after this pr:
> * Other kernels can be improved by different prs
I have already mentioned that here I think:
alamb commented on pull request #8751:
URL: https://github.com/apache/arrow/pull/8751#issuecomment-733672017
@andygrove - I will try and look at it later today
This is an automated message from the Apache Git Service.
To
alamb commented on a change in pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#discussion_r530339818
##
File path: rust/benchmarks/Cargo.toml
##
@@ -30,5 +30,5 @@ arrow = { path = "../arrow" }
parquet = { path = "../parquet" }
datafusion = { path =
github-actions[bot] commented on pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#issuecomment-733679895
https://issues.apache.org/jira/browse/ARROW-10710
This is an automated message from the Apache Git
jhorstmann commented on a change in pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#discussion_r530350708
##
File path: rust/arrow/src/bytes.rs
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
bkietz commented on a change in pull request #8735:
URL: https://github.com/apache/arrow/pull/8735#discussion_r530348934
##
File path: cpp/src/arrow/util/logging.h
##
@@ -86,56 +67,40 @@ enum class ArrowLogLevel : int {
#define ARROW_CHECK_GE(val1, val2) ARROW_CHECK((val1) >=
alamb commented on pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#issuecomment-733708535
CI is green -- merging this in!
This is an automated message from the Apache Git Service.
To respond to the
bkietz commented on a change in pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#discussion_r530376061
##
File path: cpp/cmake_modules/DefineOptions.cmake
##
@@ -363,6 +363,8 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r530327927
##
File path: rust/arrow/src/compute/kernels/aggregate.rs
##
@@ -141,32 +146,41 @@ where
match array.data().null_buffer() {
None => {
jhorstmann commented on a change in pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#discussion_r530346547
##
File path: rust/arrow/src/ffi.rs
##
@@ -0,0 +1,657 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
nevi-me closed pull request #8745:
URL: https://github.com/apache/arrow/pull/8745
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bkietz commented on a change in pull request #8735:
URL: https://github.com/apache/arrow/pull/8735#discussion_r530369496
##
File path: cpp/src/arrow/util/logging.h
##
@@ -202,48 +169,81 @@ class ARROW_EXPORT ArrowLog : public ArrowLogBase {
private:
pitrou commented on a change in pull request #8735:
URL: https://github.com/apache/arrow/pull/8735#discussion_r530408123
##
File path: cpp/src/arrow/util/logging.h
##
@@ -202,48 +169,81 @@ class ARROW_EXPORT ArrowLog : public ArrowLogBase {
private:
maartenbreddels commented on pull request #8459:
URL: https://github.com/apache/arrow/pull/8459#issuecomment-733739638
There are two issues with this PR:
## empty slices
In #8728
xhochy commented on pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#issuecomment-733745201
> @xhochy I can't seem to summon the bot. But I read what the action did,
and saw that it required a very specific version of the cmake autoformatter, as
you suggested. It works
Dandandan commented on a change in pull request #8760:
URL: https://github.com/apache/arrow/pull/8760#discussion_r530428982
##
File path: rust/benchmarks/src/bin/tpch.rs
##
@@ -353,3 +353,36 @@ fn get_schema(table: ) -> Schema {
_ => unimplemented!(),
}
}
+
josiahyan edited a comment on pull request #8757:
URL: https://github.com/apache/arrow/pull/8757#issuecomment-733751240
Oh, I know why! The CI queue was full (my test runs were taking hours to go
through). By the time the runner got to my PR (Wed, 25 Nov 2020 02:15:47 GMT),
my final
maartenbreddels commented on pull request #8468:
URL: https://github.com/apache/arrow/pull/8468#issuecomment-733803300
I'd rather keep this 1 PR, looks like #8756 is working
This is an automated message from the Apache Git
nevi-me closed pull request #8752:
URL: https://github.com/apache/arrow/pull/8752
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on a change in pull request #8769:
URL: https://github.com/apache/arrow/pull/8769#discussion_r530353896
##
File path: rust/benchmarks/Cargo.toml
##
@@ -30,5 +30,5 @@ arrow = { path = "../arrow" }
parquet = { path = "../parquet" }
datafusion = { path =
bkietz commented on a change in pull request #8735:
URL: https://github.com/apache/arrow/pull/8735#discussion_r530353939
##
File path: cpp/src/arrow/util/logging.h
##
@@ -22,22 +22,21 @@
// The LLVM IR code doesn't have an NDEBUG mode. And, it shouldn't include
references to
alamb closed pull request #8769:
URL: https://github.com/apache/arrow/pull/8769
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-733811489
> Conceptually this is not a small change. Personally I think parallelizing
on the datafusion level and keeping kernels single-threaded is the better model.
I agree with
Dandandan edited a comment on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733824217
@jorgecarleitao Not really on performance as current benchmarks / queries
show, just looking at ways to improve the aggregate / join performance.
The main thing I
Dandandan edited a comment on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733824217
@jorgecarleitao Not really on performance as current benchmarks / queries
show, just looking at ways to improve the aggregate / join performance.
The main thing I
velvia commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r530546823
##
File path: rust/datafusion/tests/sql.rs
##
@@ -508,6 +508,26 @@ async fn csv_query_avg_multi_batch() -> Result<()> {
Ok(())
}
+#[tokio::test]
andygrove commented on pull request #8751:
URL: https://github.com/apache/arrow/pull/8751#issuecomment-733886717
@alamb I decided to reduce the scope of this and not try and deal with
compound identifiers and table aliases for now. Please see the updated
description of this PR. I will do
pitrou edited a comment on pull request #8770:
URL: https://github.com/apache/arrow/pull/8770#issuecomment-733918851
ArrayRangeEquals benchmarks:
```
benchmarkbaseline
contender change %
Dandandan edited a comment on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733824217
@jorgecarleitao Not really on performance as current benchmarks / queries
show, just looking at ways to improve the aggregate / join performance.
The main thing I
github-actions[bot] commented on pull request #8771:
URL: https://github.com/apache/arrow/pull/8771#issuecomment-733952113
https://issues.apache.org/jira/browse/ARROW-10740
This is an automated message from the Apache Git
Dandandan edited a comment on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733824217
@jorgecarleitao Not really on performance as current benchmarks / queries
show, just looking at ways to improve the aggregate / join performance.
The main thing I
Dandandan commented on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733824217
@jorgecarleitao Not really on performance as current benchmarks / queries
show, just looking at ways to improve the aggregate / join performance.
The main thing I wanted
Dandandan edited a comment on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733824217
@jorgecarleitao Not really on performance as current benchmarks / queries
show, just looking at ways to improve the aggregate / join performance.
The main thing I
Dandandan edited a comment on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733824217
@jorgecarleitao Not really on performance as current benchmarks / queries
show, just looking at ways to improve the aggregate / join performance.
The main thing I
lyndonb-bq commented on a change in pull request #8724:
URL: https://github.com/apache/arrow/pull/8724#discussion_r530544565
##
File path: cpp/src/arrow/flight/flight_test.cc
##
@@ -1010,6 +1140,57 @@ class TestErrorMiddleware : public ::testing::Test {
std::unique_ptr
jorgecarleitao commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r530549403
##
File path: rust/datafusion/tests/sql.rs
##
@@ -508,6 +508,26 @@ async fn csv_query_avg_multi_batch() -> Result<()> {
Ok(())
}
pitrou opened a new pull request #8770:
URL: https://github.com/apache/arrow/pull/8770
A specialized bitmap reader that yields runs of set bits, for use cases
where reset bits (e.g. null bits) don't need any handling.
On some use cases it can be significantly faster than the
lyndonb-bq commented on pull request #8724:
URL: https://github.com/apache/arrow/pull/8724#issuecomment-733923181
@lidavidm Hey David, I have made the requested changes. I got a random
Javascript failure in one of the CI teardowns, not sure if this is accepted or
if you can restart the CI
kou commented on a change in pull request #8756:
URL: https://github.com/apache/arrow/pull/8756#discussion_r530622823
##
File path: cpp/CMakeLists.txt
##
@@ -330,6 +330,10 @@ if(ARROW_BUILD_BENCHMARKS
set(ARROW_TESTING ON)
endif()
+if(ARROW_GANDIVA)
+ set(ARROW_WITH_RE2
andygrove commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-733956565
> Also, some of your comments are giving false information (which I stopped
giving feedback). I prefer instead of having counterproductive comments,
productive comments from
Dandandan edited a comment on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733824217
@jorgecarleitao Not really on performance as current benchmarks / queries
show, just looking at ways to improve the aggregate / join performance.
The main thing I
velvia commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r530590352
##
File path: rust/datafusion/tests/sql.rs
##
@@ -508,6 +508,26 @@ async fn csv_query_avg_multi_batch() -> Result<()> {
Ok(())
}
+#[tokio::test]
Dandandan opened a new pull request #8771:
URL: https://github.com/apache/arrow/pull/8771
I think this clippy warning is useful to have in CI and reduces noise in the
code (and maybe some small performance or compile time wins).
Dandandan edited a comment on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733824217
@jorgecarleitao Not really on performance as current benchmarks / queries
show, just looking at ways to improve the aggregate / join performance.
The main thing I
lidavidm commented on a change in pull request #8725:
URL: https://github.com/apache/arrow/pull/8725#discussion_r530544603
##
File path: cpp/src/arrow/flight/client_cookie_middleware.cc
##
@@ -0,0 +1,353 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
maartenbreddels commented on pull request #8468:
URL: https://github.com/apache/arrow/pull/8468#issuecomment-733870297
@pitrou this is ready for review, failure seems unrelated (minio on windows).
This is an automated
pitrou edited a comment on pull request #8770:
URL: https://github.com/apache/arrow/pull/8770#issuecomment-733918851
ArrayRangeEquals benchmarks:
```
benchmarkbaseline contender change %
pitrou edited a comment on pull request #8770:
URL: https://github.com/apache/arrow/pull/8770#issuecomment-733919445
Parquet benchmarks:
```
benchmarkbaseline contender change %
pitrou commented on pull request #8770:
URL: https://github.com/apache/arrow/pull/8770#issuecomment-733919445
Parquet benchmarks:
```
199
BM_PlainDecodingSpacedFloat/32768/100 5.506 GiB/sec 18.466 GiB/sec
235.349
lidavidm closed pull request #8724:
URL: https://github.com/apache/arrow/pull/8724
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lidavidm commented on pull request #8724:
URL: https://github.com/apache/arrow/pull/8724#issuecomment-733943642
Thanks @lyndonb-bq!
This is an automated message from the Apache Git Service.
To respond to the message, please
github-actions[bot] commented on pull request #8772:
URL: https://github.com/apache/arrow/pull/8772#issuecomment-733960357
https://issues.apache.org/jira/browse/ARROW-10741
This is an automated message from the Apache Git
lyndonb-bq commented on a change in pull request #8725:
URL: https://github.com/apache/arrow/pull/8725#discussion_r530695895
##
File path: cpp/src/arrow/flight/client_cookie_middleware.cc
##
@@ -0,0 +1,353 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+//
lyndonb-bq commented on pull request #8725:
URL: https://github.com/apache/arrow/pull/8725#issuecomment-734107259
There appears to be a failure in the python build, I think it's caused by
something unrelated to this pull request though, I noticed the same here:
Dandandan opened a new pull request #8772:
URL: https://github.com/apache/arrow/pull/8772
Just remove some from the ignore list and apply them.
This is an automated message from the Apache Git Service.
To respond to the
Dandandan edited a comment on pull request #8765:
URL: https://github.com/apache/arrow/pull/8765#issuecomment-733824217
@jorgecarleitao Not really on performance as current benchmarks / queries
show, just looking at ways to improve the aggregate / join performance.
The main thing I
lidavidm commented on a change in pull request #8724:
URL: https://github.com/apache/arrow/pull/8724#discussion_r530540183
##
File path: cpp/src/arrow/flight/client.cc
##
@@ -1198,6 +1227,12 @@ Status FlightClient::Authenticate(const
FlightCallOptions& options,
return
velvia commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r530547648
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -223,6 +224,101 @@ pub fn is_not_null(input: ) -> Result
{
jorgecarleitao commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r530549403
##
File path: rust/datafusion/tests/sql.rs
##
@@ -508,6 +508,26 @@ async fn csv_query_avg_multi_batch() -> Result<()> {
Ok(())
}
Ulimo commented on pull request #8694:
URL: https://github.com/apache/arrow/pull/8694#issuecomment-733891188
@eerhardt I just have one question, getting this out as a preview nuget
package soonish, is that possible?
This is
1 - 100 of 125 matches
Mail list logo
