[GitHub] [arrow] kszucs commented on pull request #7816: ARROW-9528: [Python] Honor tzinfo when converting from datetime

kszucs commented on pull request #7816: URL: https://github.com/apache/arrow/pull/7816#issuecomment-667630089 Thanks Micah! Testing it via the spark integration test SGTM. If we think that ignoring timezones during conversion could be a useful feature we could even expose it

[GitHub] [arrow] jorgecarleitao opened a new pull request #7878: ARROW-9617: [Rust] [DataFusion] Add length of string array

jorgecarleitao opened a new pull request #7878: URL: https://github.com/apache/arrow/pull/7878 This is on top of #7876 and only the last commit is specific of this PR. This is an automated message from the Apache Git

[GitHub] [arrow] lhayhurst commented on issue #7877: Adding local persistence to examples/flight/server.py

lhayhurst commented on issue #7877: URL: https://github.com/apache/arrow/issues/7877#issuecomment-667626890 Hacking around on this, I was able to implement local storage without too much work. Didn't need the writer (which wouldn't have helped here -- going through the c++ code I think

[GitHub] [arrow] emkornfield commented on pull request #7816: ARROW-9528: [Python] Honor tzinfo when converting from datetime

emkornfield commented on pull request #7816: URL: https://github.com/apache/arrow/pull/7816#issuecomment-667624552 @kszucs I pushed a few commits to: 1. Fix typos I found on rereview. 2. Plumb through turning off the use of TZ informaiton in C++ via options. 3. Population in

[GitHub] [arrow] emkornfield commented on pull request #7248: ARROW-8402: [Java] Support ValidateFull methods in Java

emkornfield commented on pull request #7248: URL: https://github.com/apache/arrow/pull/7248#issuecomment-667621329 @liyafan82 looks like CI is failing from this change? This is an automated message from the Apache Git

[GitHub] [arrow] emkornfield commented on pull request #7276: ARROW-8947: [Java] MapWithOrdinal javadoc doesn't describe actual behaviour

emkornfield commented on pull request #7276: URL: https://github.com/apache/arrow/pull/7276#issuecomment-667621221 @rymurr it looks like there is conflict now. @jacques-n do you have historical perspective on @rymurr's question above?

[GitHub] [arrow] emkornfield commented on pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

emkornfield commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-667620948 > Hi, I have a question... probably not related to what this PR focus on. What if the compressor / decompressor for the codec will have JNI call for compression /

[GitHub] [arrow] emkornfield commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

emkornfield commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r464025855 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowBodyCompression.java ## @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] [arrow] emkornfield commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

emkornfield commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r464025727 ## File path: java/flight/flight-core/src/main/java/org/apache/arrow/flight/ArrowMessage.java ## @@ -353,6 +361,23 @@ private InputStream

[GitHub] [arrow] emkornfield commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

emkornfield commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r464025676 ## File path: java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] emkornfield commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

emkornfield commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r464025600 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java ## @@ -403,16 +421,29 @@ public static

[GitHub] [arrow] emkornfield commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

emkornfield commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r464025134 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java ## @@ -266,8 +266,15 @@ public static ArrowBlock

[GitHub] [arrow] emkornfield commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

emkornfield commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r464024951 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.java ## @@ -232,6 +252,12 @@ public long

[GitHub] [arrow] emkornfield commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

emkornfield commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r464024560 ## File path: java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] emkornfield commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

emkornfield commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r464024594 ## File path: java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionUtility.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] emkornfield commented on pull request #7319: ARROW-8289: [Rust] Parquet Arrow writer with nested support

emkornfield commented on pull request #7319: URL: https://github.com/apache/arrow/pull/7319#issuecomment-667618090 > IMO we can solve this in two steps: 1) have a top-level method to compute def/rep levels for all leaf arrays of a given an arrow array, and then 2) use column writer to

[GitHub] [arrow] emkornfield commented on a change in pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

emkornfield commented on a change in pull request #7872: URL: https://github.com/apache/arrow/pull/7872#discussion_r464023290 ## File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc ## @@ -101,4 +101,29 @@ TEST(TestArithmeticOps, TestDiv) { context.Reset(); }

[GitHub] [arrow] kou commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

kou commented on a change in pull request #7842: URL: https://github.com/apache/arrow/pull/7842#discussion_r464009266 ## File path: cpp/cmake_modules/Findzstd.cmake ## @@ -54,10 +54,11 @@ else() if(ZSTD_PC_FOUND) set(ZSTD_INCLUDE_DIR "${ZSTD_PC_INCLUDEDIR}") -

[GitHub] [arrow] lhayhurst opened a new issue #7877: Adding local persistence to examples/flight/server.py

lhayhurst opened a new issue #7877: URL: https://github.com/apache/arrow/issues/7877 Hi, thank you for providing [the sample client and server for pyarrow flight](https://github.com/apache/arrow/tree/apache-arrow-1.0.0/python/examples/flight) code--super useful for getting a bare-bones

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7876: ARROW-9615: [Rust] Added kernel to compute length of a string.

jorgecarleitao commented on a change in pull request #7876: URL: https://github.com/apache/arrow/pull/7876#discussion_r463994068 ## File path: rust/arrow/src/compute/kernels/length.rs ## @@ -0,0 +1,102 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] vertexclique commented on pull request #7874: ARROW-9582: [Rust] Implement memory size methods

vertexclique commented on pull request #7874: URL: https://github.com/apache/arrow/pull/7874#issuecomment-667505889 @sunchao even the latter is physical memory calculation, I addressed your comment. :) This is an automated

[GitHub] [arrow] vertexclique edited a comment on pull request #7874: ARROW-9582: [Rust] Implement memory size methods

vertexclique edited a comment on pull request #7874: URL: https://github.com/apache/arrow/pull/7874#issuecomment-667505889 @sunchao even the latter is physical memory calculation, I addressed your comment (that's also shorter naming). :)

[GitHub] [arrow] vertexclique commented on a change in pull request #7873: ARROW-9608: [Rust] Leaner feature gating for arrow in parquet

vertexclique commented on a change in pull request #7873: URL: https://github.com/apache/arrow/pull/7873#discussion_r463945019 ## File path: rust/parquet/Cargo.toml ## @@ -49,7 +49,6 @@ brotli = "3.3" flate2 = "1.0" lz4 = "1.23" zstd = "0.5" -arrow = { path = "../arrow",

[GitHub] [arrow] yordan-pavlov edited a comment on pull request #7798: ARROW-9523 [Rust] Improve filter kernel performance

yordan-pavlov edited a comment on pull request #7798: URL: https://github.com/apache/arrow/pull/7798#issuecomment-667344474 @paddyhoran yes, you are right, I added a couple more tests for sliced arrays and they didn't pass so seeing that the PR was not yet merged I added a few small

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7876: ARROW-9615: [Rust] Added kernel to compute length of a string.

jorgecarleitao commented on a change in pull request #7876: URL: https://github.com/apache/arrow/pull/7876#discussion_r463941048 ## File path: rust/arrow/src/compute/kernels/length.rs ## @@ -0,0 +1,102 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] nevi-me commented on a change in pull request #7876: ARROW-9615: [Rust] Added kernel to compute length of a string.

nevi-me commented on a change in pull request #7876: URL: https://github.com/apache/arrow/pull/7876#discussion_r463935705 ## File path: rust/arrow/src/compute/kernels/length.rs ## @@ -0,0 +1,102 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] nevi-me commented on a change in pull request #7876: ARROW-9615: [Rust] Added kernel to compute length of a string.

nevi-me commented on a change in pull request #7876: URL: https://github.com/apache/arrow/pull/7876#discussion_r463935705 ## File path: rust/arrow/src/compute/kernels/length.rs ## @@ -0,0 +1,102 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] github-actions[bot] commented on pull request #7876: ARROW-9615: [Rust] Added kernel to compute length of a string.

github-actions[bot] commented on pull request #7876: URL: https://github.com/apache/arrow/pull/7876#issuecomment-667485474 https://issues.apache.org/jira/browse/ARROW-9615 This is an automated message from the Apache Git

[GitHub] [arrow] jorgecarleitao opened a new pull request #7876: ARROW-9615: [Rust] Added kernel to compute length of a string.

jorgecarleitao opened a new pull request #7876: URL: https://github.com/apache/arrow/pull/7876 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL