[GitHub] [beam] lukecwik commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-25 Thread GitBox
lukecwik commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r477022288 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1237,8 +1639,10 @@ public Object restriction() {

[GitHub] [beam] codecov[bot] edited a comment on pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12492: URL: https://github.com/apache/beam/pull/12492#issuecomment-680434016 # [Codecov](https://codecov.io/gh/apache/beam/pull/12492?src=pr=h1) Report > Merging [#12492](https://codecov.io/gh/apache/beam/pull/12492?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12492: URL: https://github.com/apache/beam/pull/12492#issuecomment-680434016 # [Codecov](https://codecov.io/gh/apache/beam/pull/12492?src=pr=h1) Report > Merging [#12492](https://codecov.io/gh/apache/beam/pull/12492?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12492: URL: https://github.com/apache/beam/pull/12492#issuecomment-680434016 # [Codecov](https://codecov.io/gh/apache/beam/pull/12492?src=pr=h1) Report > Merging [#12492](https://codecov.io/gh/apache/beam/pull/12492?src=pr=desc) into

[GitHub] [beam] AldairCoronel commented on a change in pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
AldairCoronel commented on a change in pull request #12492: URL: https://github.com/apache/beam/pull/12492#discussion_r477004099 ## File path: sdks/python/apache_beam/io/azure/blobstorageio.py ## @@ -0,0 +1,664 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [beam] lastomato commented on a change in pull request #12661: Add export FHIR resources to GCS IO Connector

2020-08-25 Thread GitBox
lastomato commented on a change in pull request #12661: URL: https://github.com/apache/beam/pull/12661#discussion_r477002138 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java ## @@ -220,6 +222,19 @@ public static

[GitHub] [beam] AldairCoronel commented on a change in pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
AldairCoronel commented on a change in pull request #12492: URL: https://github.com/apache/beam/pull/12492#discussion_r477000643 ## File path: sdks/python/apache_beam/io/azure/blobstorageio.py ## @@ -0,0 +1,664 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [beam] AldairCoronel removed a comment on pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
AldairCoronel removed a comment on pull request #12492: URL: https://github.com/apache/beam/pull/12492#issuecomment-680433635 @pabloem Let's see: - Authentication. At the moment the only way to authenticate is with a connection string obtained from environment variables. (The code

[GitHub] [beam] AldairCoronel commented on pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
AldairCoronel commented on pull request #12492: URL: https://github.com/apache/beam/pull/12492#issuecomment-680433635 @pabloem Let's see: - Authentication. At the moment the only way to authenticate is with a connection string obtained from environment variables. (The code is here:

[GitHub] [beam] codecov[bot] commented on pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
codecov[bot] commented on pull request #12492: URL: https://github.com/apache/beam/pull/12492#issuecomment-680434016 # [Codecov](https://codecov.io/gh/apache/beam/pull/12492?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request head (`BEAM-6807@4c5ab4c`). [Click here

[GitHub] [beam] AldairCoronel closed pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
AldairCoronel closed pull request #12492: URL: https://github.com/apache/beam/pull/12492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] chamikaramj commented on a change in pull request #12609: [BEAM-10699] Logging BigQuery streaming insert tail latencies

2020-08-25 Thread GitBox
chamikaramj commented on a change in pull request #12609: URL: https://github.com/apache/beam/pull/12609#discussion_r476978750 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/Histogram.java ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] boyuanzz commented on a change in pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-08-25 Thread GitBox
boyuanzz commented on a change in pull request #12678: URL: https://github.com/apache/beam/pull/12678#discussion_r476991127 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java ## @@ -100,8 +99,7 @@ public long getBatchSize() {

[GitHub] [beam] lostluck merged pull request #12646: [BEAM-9680] Add Aggregation Count lesson to Go SDK katas

2020-08-25 Thread GitBox
lostluck merged pull request #12646: URL: https://github.com/apache/beam/pull/12646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] AldairCoronel commented on a change in pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
AldairCoronel commented on a change in pull request #12492: URL: https://github.com/apache/beam/pull/12492#discussion_r476976566 ## File path: sdks/python/apache_beam/io/azure/blobstorageio.py ## @@ -0,0 +1,664 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [beam] trucleduc edited a comment on pull request #12661: Add export FHIR resources to GCS IO Connector

2020-08-25 Thread GitBox
trucleduc edited a comment on pull request #12661: URL: https://github.com/apache/beam/pull/12661#issuecomment-680393763 @pabloem You're right that export FHIR doesn't have many options like import, so I dropped the Options class. Can you look at the latest commit?

[GitHub] [beam] trucleduc commented on pull request #12661: Add export FHIR resources to GCS IO Connector

2020-08-25 Thread GitBox
trucleduc commented on pull request #12661: URL: https://github.com/apache/beam/pull/12661#issuecomment-680393763 You're right that export FHIR doesn't have many options like import, so I dropped the Options class. Can you look at the latest commit?

[GitHub] [beam] pabloem commented on a change in pull request #12661: Add export FHIR resources to GCS IO Connector

2020-08-25 Thread GitBox
pabloem commented on a change in pull request #12661: URL: https://github.com/apache/beam/pull/12661#discussion_r476927000 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java ## @@ -220,6 +230,26 @@ public static

[GitHub] [beam] nehsyc commented on a change in pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-08-25 Thread GitBox
nehsyc commented on a change in pull request #12678: URL: https://github.com/apache/beam/pull/12678#discussion_r476909404 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java ## @@ -100,8 +99,7 @@ public long getBatchSize() {

[GitHub] [beam] codecov[bot] edited a comment on pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12651: URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report > Merging [#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12651: URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report > Merging [#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into

[GitHub] [beam] chamikaramj merged pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API

2020-08-25 Thread GitBox
chamikaramj merged pull request #12494: URL: https://github.com/apache/beam/pull/12494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] boyuanzz commented on a change in pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-08-25 Thread GitBox
boyuanzz commented on a change in pull request #12678: URL: https://github.com/apache/beam/pull/12678#discussion_r476862148 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java ## @@ -100,8 +99,7 @@ public long getBatchSize() {

[GitHub] [beam] codecov[bot] edited a comment on pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12651: URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report > Merging [#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12651: URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report > Merging [#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into

[GitHub] [beam] nehsyc commented on pull request #12677: [BEAM-10703] Dedup computation-and-key definitions

2020-08-25 Thread GitBox
nehsyc commented on pull request #12677: URL: https://github.com/apache/beam/pull/12677#issuecomment-680315088 Run Spotless PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] nehsyc commented on a change in pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-08-25 Thread GitBox
nehsyc commented on a change in pull request #12678: URL: https://github.com/apache/beam/pull/12678#discussion_r476839321 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java ## @@ -1264,6 +1268,10 @@

[GitHub] [beam] codecov[bot] edited a comment on pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12651: URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report > Merging [#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into

[GitHub] [beam] nehsyc commented on a change in pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-08-25 Thread GitBox
nehsyc commented on a change in pull request #12678: URL: https://github.com/apache/beam/pull/12678#discussion_r476835000 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java ## @@ -100,8 +99,7 @@ public long getBatchSize() {

[GitHub] [beam] KevinGG closed pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
KevinGG closed pull request #12651: URL: https://github.com/apache/beam/pull/12651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] udim opened a new pull request #12684: [BEAM-10701] Add codecov config, fix paths hopefully

2020-08-25 Thread GitBox
udim opened a new pull request #12684: URL: https://github.com/apache/beam/pull/12684 Also sets up Python code coverage status. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] codecov[bot] edited a comment on pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12651: URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report > Merging [#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12651: URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report > Merging [#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12651: URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report > Merging [#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into

[GitHub] [beam] KevinGG closed pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
KevinGG closed pull request #12651: URL: https://github.com/apache/beam/pull/12651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #12479: [BEAM-10649] Add BigQuery Avro logical type support on read

2020-08-25 Thread GitBox
pabloem commented on pull request #12479: URL: https://github.com/apache/beam/pull/12479#issuecomment-680301325 @regadas have you tested this in a pipeline? I am wondering if the Avro reader class needs to be aware of this or if it automatically outputs the appropriate types whenever

[GitHub] [beam] epicfaace commented on a change in pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
epicfaace commented on a change in pull request #12492: URL: https://github.com/apache/beam/pull/12492#discussion_r476776994 ## File path: sdks/python/apache_beam/io/azure/blobstorageio.py ## @@ -0,0 +1,664 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] epicfaace commented on a change in pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
epicfaace commented on a change in pull request #12492: URL: https://github.com/apache/beam/pull/12492#discussion_r476774438 ## File path: sdks/python/apache_beam/io/azure/blobstorageio.py ## @@ -0,0 +1,664 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] pabloem commented on a change in pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

2020-08-25 Thread GitBox
pabloem commented on a change in pull request #12492: URL: https://github.com/apache/beam/pull/12492#discussion_r476759950 ## File path: sdks/python/apache_beam/io/azure/blobstorageio.py ## @@ -0,0 +1,664 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] pabloem commented on a change in pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-25 Thread GitBox
pabloem commented on a change in pull request #12674: URL: https://github.com/apache/beam/pull/12674#discussion_r476747902 ## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/monitor.py ## @@ -0,0 +1,59 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [beam] codecov[bot] commented on pull request #12651: [BEAM-10775] Added a typescript precommit job

2020-08-25 Thread GitBox
codecov[bot] commented on pull request #12651: URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083 # [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report > Merging [#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into

[GitHub] [beam] iemejia commented on pull request #12514: [BEAM-9850] Key should be available in @OnTimer methods (Spark Runner)

2020-08-25 Thread GitBox
iemejia commented on pull request #12514: URL: https://github.com/apache/beam/pull/12514#issuecomment-680254673 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] iemejia commented on pull request #12514: [BEAM-9850] Key should be available in @OnTimer methods (Spark Runner)

2020-08-25 Thread GitBox
iemejia commented on pull request #12514: URL: https://github.com/apache/beam/pull/12514#issuecomment-680254605 Run Spark StructuredStreaming ValidatesRunner This is an automated message from the Apache Git Service. To

[GitHub] [beam] iemejia commented on pull request #12514: [BEAM-9850] Key should be available in @OnTimer methods (Spark Runner)

2020-08-25 Thread GitBox
iemejia commented on pull request #12514: URL: https://github.com/apache/beam/pull/12514#issuecomment-680254519 Run Spark ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] iemejia commented on pull request #12514: [BEAM-9850] Key should be available in @OnTimer methods (Spark Runner)

2020-08-25 Thread GitBox
iemejia commented on pull request #12514: URL: https://github.com/apache/beam/pull/12514#issuecomment-680253124 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12605: URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009 # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12682: [BEAM-9547] Add a few more DataFrame operations

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12682: URL: https://github.com/apache/beam/pull/12682#issuecomment-680243372 # [Codecov](https://codecov.io/gh/apache/beam/pull/12682?src=pr=h1) Report > Merging [#12682](https://codecov.io/gh/apache/beam/pull/12682?src=pr=desc) into

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-25 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r476125331 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1035,6 +1046,130 @@ private Progress getProgress()

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12605: URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009 # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12605: URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009 # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click

[GitHub] [beam] ceocoder opened a new pull request #12683: [BEAM-10812] fix(beam/sdks/go): fix buffer limit on textio

2020-08-25 Thread GitBox
ceocoder opened a new pull request #12683: URL: https://github.com/apache/beam/pull/12683 bufio.Scanner is limited to 4kb by default, for arbitary line length it is recommended to use bufio.Reader and split by '\n' Ref:

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12605: URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009 # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click

[GitHub] [beam] codecov[bot] commented on pull request #12682: [BEAM-9547] Add a few more DataFrame operations

2020-08-25 Thread GitBox
codecov[bot] commented on pull request #12682: URL: https://github.com/apache/beam/pull/12682#issuecomment-680243372 # [Codecov](https://codecov.io/gh/apache/beam/pull/12682?src=pr=h1) Report > Merging [#12682](https://codecov.io/gh/apache/beam/pull/12682?src=pr=desc) into

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12682: [BEAM-9547] Add a few more DataFrame operations

2020-08-25 Thread GitBox
TheNeuralBit commented on a change in pull request #12682: URL: https://github.com/apache/beam/pull/12682#discussion_r476707154 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -348,6 +358,8 @@ def aggregate(self, func, axis=0, *args, **kwargs):

[GitHub] [beam] robertwb commented on a change in pull request #12185: [BEAM-10409] Add combiner packing to graph optimizer phases

2020-08-25 Thread GitBox
robertwb commented on a change in pull request #12185: URL: https://github.com/apache/beam/pull/12185#discussion_r476702785 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -690,6 +692,200 @@ def fix_side_input_pcoll_coders(stages,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12676: set_index is not index preserving

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12676: URL: https://github.com/apache/beam/pull/12676#issuecomment-680228848 # [Codecov](https://codecov.io/gh/apache/beam/pull/12676?src=pr=h1) Report > Merging [#12676](https://codecov.io/gh/apache/beam/pull/12676?src=pr=desc) into

[GitHub] [beam] robertwb commented on a change in pull request #12682: [BEAM-9547] Add a few more DataFrame operations

2020-08-25 Thread GitBox
robertwb commented on a change in pull request #12682: URL: https://github.com/apache/beam/pull/12682#discussion_r476699247 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -348,6 +358,8 @@ def aggregate(self, func, axis=0, *args, **kwargs):

[GitHub] [beam] robertwb commented on a change in pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

2020-08-25 Thread GitBox
robertwb commented on a change in pull request #12605: URL: https://github.com/apache/beam/pull/12605#discussion_r476694605 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -540,6 +549,8 @@ def add_parent(child, parent):

[GitHub] [beam] codecov[bot] commented on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

2020-08-25 Thread GitBox
codecov[bot] commented on pull request #12605: URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009 # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12676: set_index is not index preserving

2020-08-25 Thread GitBox
codecov[bot] edited a comment on pull request #12676: URL: https://github.com/apache/beam/pull/12676#issuecomment-680228848 # [Codecov](https://codecov.io/gh/apache/beam/pull/12676?src=pr=h1) Report > Merging [#12676](https://codecov.io/gh/apache/beam/pull/12676?src=pr=desc) into

[GitHub] [beam] TheNeuralBit opened a new pull request #12682: [BEAM-9547] Add a few more DataFrame operations

2020-08-25 Thread GitBox
TheNeuralBit opened a new pull request #12682: URL: https://github.com/apache/beam/pull/12682 - Combining Series with & and | - Projecting multiple columns in __getitem__ - Dataframe.drop R: @robertwb Post-Commit Tests Status (on master branch)

[GitHub] [beam] robertwb commented on pull request #12676: set_index is not index preserving

2020-08-25 Thread GitBox
robertwb commented on pull request #12676: URL: https://github.com/apache/beam/pull/12676#issuecomment-680230846 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] commented on pull request #12676: set_index is not index preserving

2020-08-25 Thread GitBox
codecov[bot] commented on pull request #12676: URL: https://github.com/apache/beam/pull/12676#issuecomment-680228848 # [Codecov](https://codecov.io/gh/apache/beam/pull/12676?src=pr=h1) Report > Merging [#12676](https://codecov.io/gh/apache/beam/pull/12676?src=pr=desc) into

[GitHub] [beam] robinyqiu commented on pull request #12643: [BEAM-10438] Update SupportedZetaSqlBuiltinFunctions and support math functions

2020-08-25 Thread GitBox
robinyqiu commented on pull request #12643: URL: https://github.com/apache/beam/pull/12643#issuecomment-680204320 OK now the tests all pass and the blocking [bug](https://issues.apache.org/jira/browse/BEAM-10783) is fixed.

[GitHub] [beam] nevillelyh opened a new pull request #12681: reduce disk usage in NativeFileSorter

2020-08-25 Thread GitBox
nevillelyh opened a new pull request #12681: URL: https://github.com/apache/beam/pull/12681 `dataFile` is used append only and redundant as soon as `sortInBatch` splits it into batch sorted files **Please** add a meaningful description for your change here

[GitHub] [beam] boyuanzz commented on a change in pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-08-25 Thread GitBox
boyuanzz commented on a change in pull request #12678: URL: https://github.com/apache/beam/pull/12678#discussion_r476618504 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java ## @@ -1264,6 +1268,10

[GitHub] [beam] pulasthi commented on a change in pull request #12594: [BEAM-10670] Make Twister2Runner opt-out for using an SDF powered Read transform.

2020-08-25 Thread GitBox
pulasthi commented on a change in pull request #12594: URL: https://github.com/apache/beam/pull/12594#discussion_r476618479 ## File path: runners/twister2/src/main/java/org/apache/beam/runners/twister2/translators/batch/ImpulseTranslatorBatch.java ## @@ -0,0 +1,62 @@ +/* + *

[GitHub] [beam] rehmanmuradali commented on pull request #12680: [BEAM-10810] Implement VARIANCE, VAR_POP, VAR_SAMP for Beam SQL ZetaSQL dialect as CombineFn

2020-08-25 Thread GitBox
rehmanmuradali commented on pull request #12680: URL: https://github.com/apache/beam/pull/12680#issuecomment-680141868 R: @reuvenlax This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] rehmanmuradali commented on pull request #12679: [BEAM-10809] Implement STDDEV, STDDEV_POP, STDDEV_SAMP for Beam SQL ZetaSQL dialect as CombineFn

2020-08-25 Thread GitBox
rehmanmuradali commented on pull request #12679: URL: https://github.com/apache/beam/pull/12679#issuecomment-680141801 R: @reuvenlax This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] rehmanmuradali opened a new pull request #12680: [BEAM-10810] Implement VARIANCE, VAR_POP, VAR_SAMP for Beam SQL ZetaSQL dialect as CombineFn

2020-08-25 Thread GitBox
rehmanmuradali opened a new pull request #12680: URL: https://github.com/apache/beam/pull/12680 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] kmjung commented on a change in pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API

2020-08-25 Thread GitBox
kmjung commented on a change in pull request #12494: URL: https://github.com/apache/beam/pull/12494#discussion_r476580093 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java ## @@ -348,22 +347,17 @@ static

[GitHub] [beam] rehmanmuradali opened a new pull request #12679: [BEAM-10809] Implement STDDEV, STDDEV_POP, STDDEV_SAMP for Beam SQL ZetaSQL dialect as CombineFn

2020-08-25 Thread GitBox
rehmanmuradali opened a new pull request #12679: URL: https://github.com/apache/beam/pull/12679 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] damondouglas commented on pull request #12646: [BEAM-9680] Add Aggregation Count lesson to Go SDK katas

2020-08-25 Thread GitBox
damondouglas commented on pull request #12646: URL: https://github.com/apache/beam/pull/12646#issuecomment-680075309 @lostluck the [stepik course](https://stepik.org/course/70387) has been updated and the `*-remote.yaml` files committed to this PR. This PR is ready to merge.

[GitHub] [beam] kamilwu commented on a change in pull request #12435: [BEAM-10616] Added Python Pardo load tests for streaming on Dataflow

2020-08-25 Thread GitBox
kamilwu commented on a change in pull request #12435: URL: https://github.com/apache/beam/pull/12435#discussion_r476485871 ## File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py ## @@ -125,7 +125,9 @@ def process(self, element, state=state_param):

[GitHub] [beam] jithin97 commented on pull request #12670: [BEAM-5757] Add ElasticsearchIO: delete document support

2020-08-25 Thread GitBox
jithin97 commented on pull request #12670: URL: https://github.com/apache/beam/pull/12670#issuecomment-680015143 R: @echauchot @jbonofre @timrobertson100 This is an automated message from the Apache Git Service. To respond