lukecwik commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r477022288
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1237,8 +1639,10 @@ public Object restriction() {
codecov[bot] edited a comment on pull request #12492:
URL: https://github.com/apache/beam/pull/12492#issuecomment-680434016
# [Codecov](https://codecov.io/gh/apache/beam/pull/12492?src=pr=h1) Report
> Merging
[#12492](https://codecov.io/gh/apache/beam/pull/12492?src=pr=desc) into
codecov[bot] edited a comment on pull request #12492:
URL: https://github.com/apache/beam/pull/12492#issuecomment-680434016
# [Codecov](https://codecov.io/gh/apache/beam/pull/12492?src=pr=h1) Report
> Merging
[#12492](https://codecov.io/gh/apache/beam/pull/12492?src=pr=desc) into
codecov[bot] edited a comment on pull request #12492:
URL: https://github.com/apache/beam/pull/12492#issuecomment-680434016
# [Codecov](https://codecov.io/gh/apache/beam/pull/12492?src=pr=h1) Report
> Merging
[#12492](https://codecov.io/gh/apache/beam/pull/12492?src=pr=desc) into
AldairCoronel commented on a change in pull request #12492:
URL: https://github.com/apache/beam/pull/12492#discussion_r477004099
##
File path: sdks/python/apache_beam/io/azure/blobstorageio.py
##
@@ -0,0 +1,664 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
lastomato commented on a change in pull request #12661:
URL: https://github.com/apache/beam/pull/12661#discussion_r477002138
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##
@@ -220,6 +222,19 @@ public static
AldairCoronel commented on a change in pull request #12492:
URL: https://github.com/apache/beam/pull/12492#discussion_r477000643
##
File path: sdks/python/apache_beam/io/azure/blobstorageio.py
##
@@ -0,0 +1,664 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
AldairCoronel removed a comment on pull request #12492:
URL: https://github.com/apache/beam/pull/12492#issuecomment-680433635
@pabloem Let's see:
- Authentication. At the moment the only way to authenticate is with a
connection string obtained from environment variables. (The code
AldairCoronel commented on pull request #12492:
URL: https://github.com/apache/beam/pull/12492#issuecomment-680433635
@pabloem Let's see:
- Authentication. At the moment the only way to authenticate is with a
connection string obtained from environment variables. (The code is here:
codecov[bot] commented on pull request #12492:
URL: https://github.com/apache/beam/pull/12492#issuecomment-680434016
# [Codecov](https://codecov.io/gh/apache/beam/pull/12492?src=pr=h1) Report
> :exclamation: No coverage uploaded for pull request head
(`BEAM-6807@4c5ab4c`). [Click here
AldairCoronel closed pull request #12492:
URL: https://github.com/apache/beam/pull/12492
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chamikaramj commented on a change in pull request #12609:
URL: https://github.com/apache/beam/pull/12609#discussion_r476978750
##
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/Histogram.java
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software
boyuanzz commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476991127
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##
@@ -100,8 +99,7 @@ public long getBatchSize() {
lostluck merged pull request #12646:
URL: https://github.com/apache/beam/pull/12646
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
AldairCoronel commented on a change in pull request #12492:
URL: https://github.com/apache/beam/pull/12492#discussion_r476976566
##
File path: sdks/python/apache_beam/io/azure/blobstorageio.py
##
@@ -0,0 +1,664 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
trucleduc edited a comment on pull request #12661:
URL: https://github.com/apache/beam/pull/12661#issuecomment-680393763
@pabloem You're right that export FHIR doesn't have many options like
import, so I dropped the Options class. Can you look at the latest commit?
trucleduc commented on pull request #12661:
URL: https://github.com/apache/beam/pull/12661#issuecomment-680393763
You're right that export FHIR doesn't have many options like import, so I
dropped the Options class. Can you look at the latest commit?
pabloem commented on a change in pull request #12661:
URL: https://github.com/apache/beam/pull/12661#discussion_r476927000
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##
@@ -220,6 +230,26 @@ public static
nehsyc commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476909404
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##
@@ -100,8 +99,7 @@ public long getBatchSize() {
codecov[bot] edited a comment on pull request #12651:
URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083
# [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report
> Merging
[#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into
codecov[bot] edited a comment on pull request #12651:
URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083
# [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report
> Merging
[#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into
chamikaramj merged pull request #12494:
URL: https://github.com/apache/beam/pull/12494
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
boyuanzz commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476862148
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##
@@ -100,8 +99,7 @@ public long getBatchSize() {
codecov[bot] edited a comment on pull request #12651:
URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083
# [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report
> Merging
[#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into
codecov[bot] edited a comment on pull request #12651:
URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083
# [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report
> Merging
[#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into
nehsyc commented on pull request #12677:
URL: https://github.com/apache/beam/pull/12677#issuecomment-680315088
Run Spotless PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
nehsyc commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476839321
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##
@@ -1264,6 +1268,10 @@
codecov[bot] edited a comment on pull request #12651:
URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083
# [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report
> Merging
[#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into
nehsyc commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476835000
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##
@@ -100,8 +99,7 @@ public long getBatchSize() {
KevinGG closed pull request #12651:
URL: https://github.com/apache/beam/pull/12651
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
udim opened a new pull request #12684:
URL: https://github.com/apache/beam/pull/12684
Also sets up Python code coverage status.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
codecov[bot] edited a comment on pull request #12651:
URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083
# [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report
> Merging
[#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into
codecov[bot] edited a comment on pull request #12651:
URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083
# [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report
> Merging
[#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into
codecov[bot] edited a comment on pull request #12651:
URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083
# [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report
> Merging
[#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into
KevinGG closed pull request #12651:
URL: https://github.com/apache/beam/pull/12651
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #12479:
URL: https://github.com/apache/beam/pull/12479#issuecomment-680301325
@regadas have you tested this in a pipeline? I am wondering if the Avro
reader class needs to be aware of this or if it automatically outputs the
appropriate types whenever
epicfaace commented on a change in pull request #12492:
URL: https://github.com/apache/beam/pull/12492#discussion_r476776994
##
File path: sdks/python/apache_beam/io/azure/blobstorageio.py
##
@@ -0,0 +1,664 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
epicfaace commented on a change in pull request #12492:
URL: https://github.com/apache/beam/pull/12492#discussion_r476774438
##
File path: sdks/python/apache_beam/io/azure/blobstorageio.py
##
@@ -0,0 +1,664 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
pabloem commented on a change in pull request #12492:
URL: https://github.com/apache/beam/pull/12492#discussion_r476759950
##
File path: sdks/python/apache_beam/io/azure/blobstorageio.py
##
@@ -0,0 +1,664 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
pabloem commented on a change in pull request #12674:
URL: https://github.com/apache/beam/pull/12674#discussion_r476747902
##
File path: sdks/python/apache_beam/testing/benchmarks/nexmark/monitor.py
##
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
codecov[bot] commented on pull request #12651:
URL: https://github.com/apache/beam/pull/12651#issuecomment-680278083
# [Codecov](https://codecov.io/gh/apache/beam/pull/12651?src=pr=h1) Report
> Merging
[#12651](https://codecov.io/gh/apache/beam/pull/12651?src=pr=desc) into
iemejia commented on pull request #12514:
URL: https://github.com/apache/beam/pull/12514#issuecomment-680254673
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
iemejia commented on pull request #12514:
URL: https://github.com/apache/beam/pull/12514#issuecomment-680254605
Run Spark StructuredStreaming ValidatesRunner
This is an automated message from the Apache Git Service.
To
iemejia commented on pull request #12514:
URL: https://github.com/apache/beam/pull/12514#issuecomment-680254519
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message,
iemejia commented on pull request #12514:
URL: https://github.com/apache/beam/pull/12514#issuecomment-680253124
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009
# [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@12004fd`). [Click
codecov[bot] edited a comment on pull request #12682:
URL: https://github.com/apache/beam/pull/12682#issuecomment-680243372
# [Codecov](https://codecov.io/gh/apache/beam/pull/12682?src=pr=h1) Report
> Merging
[#12682](https://codecov.io/gh/apache/beam/pull/12682?src=pr=desc) into
boyuanzz commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r476125331
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1035,6 +1046,130 @@ private Progress getProgress()
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009
# [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@12004fd`). [Click
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009
# [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@12004fd`). [Click
ceocoder opened a new pull request #12683:
URL: https://github.com/apache/beam/pull/12683
bufio.Scanner is limited to 4kb by default, for arbitary line length it
is recommended to use bufio.Reader and split by '\n'
Ref:
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009
# [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@12004fd`). [Click
codecov[bot] commented on pull request #12682:
URL: https://github.com/apache/beam/pull/12682#issuecomment-680243372
# [Codecov](https://codecov.io/gh/apache/beam/pull/12682?src=pr=h1) Report
> Merging
[#12682](https://codecov.io/gh/apache/beam/pull/12682?src=pr=desc) into
TheNeuralBit commented on a change in pull request #12682:
URL: https://github.com/apache/beam/pull/12682#discussion_r476707154
##
File path: sdks/python/apache_beam/dataframe/frames.py
##
@@ -348,6 +358,8 @@ def aggregate(self, func, axis=0, *args, **kwargs):
robertwb commented on a change in pull request #12185:
URL: https://github.com/apache/beam/pull/12185#discussion_r476702785
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##
@@ -690,6 +692,200 @@ def fix_side_input_pcoll_coders(stages,
codecov[bot] edited a comment on pull request #12676:
URL: https://github.com/apache/beam/pull/12676#issuecomment-680228848
# [Codecov](https://codecov.io/gh/apache/beam/pull/12676?src=pr=h1) Report
> Merging
[#12676](https://codecov.io/gh/apache/beam/pull/12676?src=pr=desc) into
robertwb commented on a change in pull request #12682:
URL: https://github.com/apache/beam/pull/12682#discussion_r476699247
##
File path: sdks/python/apache_beam/dataframe/frames.py
##
@@ -348,6 +358,8 @@ def aggregate(self, func, axis=0, *args, **kwargs):
robertwb commented on a change in pull request #12605:
URL: https://github.com/apache/beam/pull/12605#discussion_r476694605
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##
@@ -540,6 +549,8 @@ def add_parent(child, parent):
codecov[bot] commented on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009
# [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@12004fd`). [Click here to
codecov[bot] edited a comment on pull request #12676:
URL: https://github.com/apache/beam/pull/12676#issuecomment-680228848
# [Codecov](https://codecov.io/gh/apache/beam/pull/12676?src=pr=h1) Report
> Merging
[#12676](https://codecov.io/gh/apache/beam/pull/12676?src=pr=desc) into
TheNeuralBit opened a new pull request #12682:
URL: https://github.com/apache/beam/pull/12682
- Combining Series with & and |
- Projecting multiple columns in __getitem__
- Dataframe.drop
R: @robertwb
Post-Commit Tests Status (on master branch)
robertwb commented on pull request #12676:
URL: https://github.com/apache/beam/pull/12676#issuecomment-680230846
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
codecov[bot] commented on pull request #12676:
URL: https://github.com/apache/beam/pull/12676#issuecomment-680228848
# [Codecov](https://codecov.io/gh/apache/beam/pull/12676?src=pr=h1) Report
> Merging
[#12676](https://codecov.io/gh/apache/beam/pull/12676?src=pr=desc) into
robinyqiu commented on pull request #12643:
URL: https://github.com/apache/beam/pull/12643#issuecomment-680204320
OK now the tests all pass and the blocking
[bug](https://issues.apache.org/jira/browse/BEAM-10783) is fixed.
nevillelyh opened a new pull request #12681:
URL: https://github.com/apache/beam/pull/12681
`dataFile` is used append only and redundant as soon as `sortInBatch`
splits it into batch sorted files
**Please** add a meaningful description for your change here
boyuanzz commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476618504
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##
@@ -1264,6 +1268,10
pulasthi commented on a change in pull request #12594:
URL: https://github.com/apache/beam/pull/12594#discussion_r476618479
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/translators/batch/ImpulseTranslatorBatch.java
##
@@ -0,0 +1,62 @@
+/*
+ *
rehmanmuradali commented on pull request #12680:
URL: https://github.com/apache/beam/pull/12680#issuecomment-680141868
R: @reuvenlax
This is an automated message from the Apache Git Service.
To respond to the message, please
rehmanmuradali commented on pull request #12679:
URL: https://github.com/apache/beam/pull/12679#issuecomment-680141801
R: @reuvenlax
This is an automated message from the Apache Git Service.
To respond to the message,
rehmanmuradali opened a new pull request #12680:
URL: https://github.com/apache/beam/pull/12680
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
kmjung commented on a change in pull request #12494:
URL: https://github.com/apache/beam/pull/12494#discussion_r476580093
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##
@@ -348,22 +347,17 @@ static
rehmanmuradali opened a new pull request #12679:
URL: https://github.com/apache/beam/pull/12679
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
damondouglas commented on pull request #12646:
URL: https://github.com/apache/beam/pull/12646#issuecomment-680075309
@lostluck the [stepik course](https://stepik.org/course/70387) has been
updated and the `*-remote.yaml` files committed to this PR. This PR is ready
to merge.
kamilwu commented on a change in pull request #12435:
URL: https://github.com/apache/beam/pull/12435#discussion_r476485871
##
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##
@@ -125,7 +125,9 @@ def process(self, element, state=state_param):
jithin97 commented on pull request #12670:
URL: https://github.com/apache/beam/pull/12670#issuecomment-680015143
R: @echauchot @jbonofre @timrobertson100
This is an automated message from the Apache Git Service.
To respond
75 matches
Mail list logo