aditya0yadav commented on PR #34700:
URL: https://github.com/apache/beam/pull/34700#issuecomment-2861984423
actually i wanna is there any need of feast io connector
or improvement in enrichmnet handler like inserting feature
@jrmccluskey
--
This is an automated message from the Ap
aditya0yadav commented on code in PR #34700:
URL: https://github.com/apache/beam/pull/34700#discussion_r2079025112
##
sdks/python/apache_beam/ml/transforms/embeddings/open_ai.py:
##
@@ -0,0 +1,204 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contri
aditya0yadav commented on code in PR #34700:
URL: https://github.com/apache/beam/pull/34700#discussion_r2079022948
##
sdks/python/apache_beam/ml/transforms/embeddings/open_ai.py:
##
@@ -0,0 +1,204 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contri
rakeshcusat commented on issue #30911:
URL: https://github.com/apache/beam/issues/30911#issuecomment-2861893805
@aaltay I can take a look, feel free to share other relevant information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
TanuSharma2511 opened a new pull request, #34886:
URL: https://github.com/apache/beam/pull/34886
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate i
github-actions[bot] commented on PR #34885:
URL: https://github.com/apache/beam/pull/34885#issuecomment-2861834302
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated me
dependabot[bot] opened a new pull request, #34885:
URL: https://github.com/apache/beam/pull/34885
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.39.0 to
0.40.0.
Commits
https://github.com/golang/net/commit/7d6e62ace5ed100018bd82d1967d2d98cff6fbae";>7d6e62a
go.m
github-actions[bot] commented on PR #34884:
URL: https://github.com/apache/beam/pull/34884#issuecomment-2861583336
Assigning reviewers:
R: @Abacn added as fallback since no labels match configuration
Note: If you would like to opt out of this review, comment `assign to next
TanuSharma2511 commented on issue #34879:
URL: https://github.com/apache/beam/issues/34879#issuecomment-2861474114
.take-issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
shunping opened a new pull request, #34884:
URL: https://github.com/apache/beam/pull/34884
- Changed how environment variables are set.
- Added links to open notebook in colab and github.
- Restructure the sections and sub-sections.
**Please** add a meaningful description for yo
kennknowles opened a new pull request, #34883:
URL: https://github.com/apache/beam/pull/34883
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution qu
robertwb merged PR #34746:
URL: https://github.com/apache/beam/pull/34746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache
tvalentyn commented on PR #34699:
URL: https://github.com/apache/beam/pull/34699#issuecomment-2860671661
> Should we vendor the cloudpickle tests as well if we are modifying the
implementation this much?
+1.
Given cloudpickle authors are not responsive, we might have to mainta
robertwb commented on PR #34746:
URL: https://github.com/apache/beam/pull/34746#issuecomment-2860669869
> Do we want to capability protect this?
This isn't really a capability--the interaction with the runner remains the
same. I thought about guarding this with an experiment, but ther
robertwb commented on code in PR #34746:
URL: https://github.com/apache/beam/pull/34746#discussion_r2078639724
##
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateFetchingIterators.java:
##
@@ -91,6 +94,82 @@ public static CachingStateIterable
readAllAndDe
tvalentyn commented on code in PR #34870:
URL: https://github.com/apache/beam/pull/34870#discussion_r2078622721
##
sdks/python/apache_beam/typehints/opcodes.py:
##
@@ -582,19 +616,31 @@ def build_slice(state, arg):
state.stack[-arg:] = [slice] # a slice object
+def to_bo
github-actions[bot] commented on PR #34882:
URL: https://github.com/apache/beam/pull/34882#issuecomment-2860651512
Assigning reviewers:
R: @damccorm for label python.
R: @Abacn for label java.
R: @damccorm for label website.
Note: If you would like to opt out of this r
priyansndesai commented on PR #34746:
URL: https://github.com/apache/beam/pull/34746#issuecomment-2860620186
Do we want to capability protect this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
liferoad commented on PR #34801:
URL: https://github.com/apache/beam/pull/34801#issuecomment-2860586439
We should inform developers to update their yapf ASAP. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
liferoad commented on code in PR #34882:
URL: https://github.com/apache/beam/pull/34882#discussion_r2078575682
##
website/www/site/content/en/documentation/io/managed-io.md:
##
@@ -32,6 +32,18 @@ For example, the DataflowRunner can seamlessly upgrade a
Managed transform to
its
liferoad commented on code in PR #34882:
URL: https://github.com/apache/beam/pull/34882#discussion_r2078575352
##
sdks/python/gen_managed_doc.py:
##
@@ -69,6 +69,18 @@
its latest SDK version, automatically applying bug fixes and new features (no
manual updates or user interven
talatuyarer commented on code in PR #34799:
URL: https://github.com/apache/beam/pull/34799#discussion_r2078570598
##
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/iceberg/IcebergReadWriteIT.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to
talatuyarer commented on code in PR #34799:
URL: https://github.com/apache/beam/pull/34799#discussion_r2078569069
##
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/PubsubToIcebergIT.java:
##
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apache Software Fou
ahmedabu98 commented on PR #34882:
URL: https://github.com/apache/beam/pull/34882#issuecomment-2860439844
cc @liferoad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
ahmedabu98 opened a new pull request, #34882:
URL: https://github.com/apache/beam/pull/34882
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
kennknowles commented on PR #34881:
URL: https://github.com/apache/beam/pull/34881#issuecomment-2860398235
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #34881:
URL: https://github.com/apache/beam/pull/34881#issuecomment-2860401600
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control. If you'd like to restart, comment
`assign set of reviewer
kennknowles commented on PR #34881:
URL: https://github.com/apache/beam/pull/34881#issuecomment-2860399092
tiny follow up, where I fix some warnings in the files I touched in the last
PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
damccorm merged PR #34459:
URL: https://github.com/apache/beam/pull/34459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache
codecov[bot] commented on PR #34881:
URL: https://github.com/apache/beam/pull/34881#issuecomment-2860225237
##
[Codecov](https://app.codecov.io/gh/apache/beam/pull/34881?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term
liferoad merged PR #34845:
URL: https://github.com/apache/beam/pull/34845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache
github-actions[bot] commented on PR #34801:
URL: https://github.com/apache/beam/pull/34801#issuecomment-2860005756
Assigning reviewers:
R: @liferoad for label python.
R: @nielm for label spanner.
Note: If you would like to opt out of this review, comment `assign to next
jrmccluskey merged PR #34876:
URL: https://github.com/apache/beam/pull/34876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apa
github-actions[bot] commented on PR #33918:
URL: https://github.com/apache/beam/pull/33918#issuecomment-2859925788
Assigning reviewers:
R: @m-trieu for label java.
Note: If you would like to opt out of this review, comment `assign to next
reviewer`.
Available command
scwhittle commented on PR #34746:
URL: https://github.com/apache/beam/pull/34746#issuecomment-2858245639
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jrmccluskey commented on PR #34880:
URL: https://github.com/apache/beam/pull/34880#issuecomment-2859895637
Opting for other pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
jrmccluskey closed pull request #34880: Bump Vertex AI Embeddings test model to
new version
URL: https://github.com/apache/beam/pull/34880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
jrmccluskey merged PR #34875:
URL: https://github.com/apache/beam/pull/34875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apa
claudevdm commented on PR #34875:
URL: https://github.com/apache/beam/pull/34875#issuecomment-2859892250
Those failures are unrelated to this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
claudevdm commented on PR #34880:
URL: https://github.com/apache/beam/pull/34880#issuecomment-2859889445
Hey @jrmccluskey I already have https://github.com/apache/beam/pull/34875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
ahmedabu98 commented on PR #34856:
URL: https://github.com/apache/beam/pull/34856#issuecomment-2859867696
Ahh forgot to update CHANGES. I'll open another PR to do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
ahmedabu98 commented on PR #34856:
URL: https://github.com/apache/beam/pull/34856#issuecomment-2859862634
Thanks Kenn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
ahmedabu98 merged PR #34856:
URL: https://github.com/apache/beam/pull/34856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apac
github-actions[bot] commented on PR #34880:
URL: https://github.com/apache/beam/pull/34880#issuecomment-2859851162
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated me
github-actions[bot] commented on PR #34245:
URL: https://github.com/apache/beam/pull/34245#issuecomment-2858362364
Assigning new set of reviewers because Pr has gone too long without review.
If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb f
github-actions[bot] commented on PR #34876:
URL: https://github.com/apache/beam/pull/34876#issuecomment-2858351224
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @jrmccluskey for label go.
Available commands:
- `stop r
shunping commented on PR #34459:
URL: https://github.com/apache/beam/pull/34459#issuecomment-2859586990
@damccorm, could you please take another look?
Some changes since your last review:
- Added a new section for running anomaly detection on a batch data set.
- Added the links f
damccorm merged PR #34872:
URL: https://github.com/apache/beam/pull/34872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache
Abacn commented on PR #34875:
URL: https://github.com/apache/beam/pull/34875#issuecomment-2859282402
it appears Python3.9-3.11 fails to resolve setuptools dependencies:
```
Collecting setuptools
Using cached setuptools-80.3.1-py3-none-any.whl.metadata (6.5 kB)
Downloading
github-actions[bot] commented on PR #34874:
URL: https://github.com/apache/beam/pull/34874#issuecomment-2858351582
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @jrmccluskey for label python.
Available commands:
- `st
liferoad commented on PR #34856:
URL: https://github.com/apache/beam/pull/34856#issuecomment-2859158623
Please update CHANGES.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
derrickaw commented on code in PR #34872:
URL: https://github.com/apache/beam/pull/34872#discussion_r2077971007
##
scripts/ci/pr-bot/shared/commentStrings.ts:
##
@@ -39,6 +39,8 @@ export function assignReviewer(labelToReviewerMapping: any):
string {
}
}
+ commentStri
razvanculea commented on PR #34777:
URL: https://github.com/apache/beam/pull/34777#issuecomment-2858280752
Improved support for user windowing.
If an unbounded PCollection with GlobalWindow is written:
* without setting triggering_frequency => throw an exception
* if triggering_frequ
jrmccluskey opened a new pull request, #34880:
URL: https://github.com/apache/beam/pull/34880
The Vertex AI Embeddings test depended on the textembedding-gecko@002 model,
which reached EOL on vertex recently and caused our test suites to go
perma-red. This moves to text-embedding-005, the r
kennknowles opened a new pull request, #34881:
URL: https://github.com/apache/beam/pull/34881
Just fixing some broken windows. Mostly adding explicit error checking to
places where we just let invalid values slip through API boundaries.
Re-enabling nullness checking for files I touched in p
gcarson30 opened a new issue, #34879:
URL: https://github.com/apache/beam/issues/34879
### What happened?
Issue Description:
I am encountering a ValueError when setting the resource_hints parameter in
StandardOptions for an Apache Beam pipeline. Specifically, the min_ram resource
kennknowles closed pull request #34820: [DO NOT MERGE] prototyping ValueKind
URL: https://github.com/apache/beam/pull/34820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
scwhittle commented on code in PR #34746:
URL: https://github.com/apache/beam/pull/34746#discussion_r2077415353
##
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateFetchingIterators.java:
##
@@ -91,6 +94,82 @@ public static CachingStateIterable
readAllAndD
scwhittle commented on PR #34878:
URL: https://github.com/apache/beam/pull/34878#issuecomment-2858555648
error appears to be unrelated flake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
ksobrenat32 commented on code in PR #34141:
URL: https://github.com/apache/beam/pull/34141#discussion_r2077685617
##
.test-infra/tools/stale_cleaner.py:
##
@@ -0,0 +1,258 @@
+#!/usr/bin/env python
+#
+#Licensed to the Apache Software Foundation (ASF) under one or more
+#
github-actions[bot] commented on PR #34878:
URL: https://github.com/apache/beam/pull/34878#issuecomment-2858664139
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @shunping added as fallback since no labels match configuration
github-actions[bot] commented on PR #34870:
URL: https://github.com/apache/beam/pull/34870#issuecomment-2858351934
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @claudevdm for label python.
Available commands:
- `stop
scwhittle commented on PR #34878:
URL: https://github.com/apache/beam/pull/34878#issuecomment-2858555126
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ksobrenat32 commented on code in PR #34141:
URL: https://github.com/apache/beam/pull/34141#discussion_r2077612828
##
.test-infra/tools/stale_cleaner.py:
##
@@ -0,0 +1,258 @@
+#!/usr/bin/env python
+#
+#Licensed to the Apache Software Foundation (ASF) under one or more
+#
github-actions[bot] commented on PR #34873:
URL: https://github.com/apache/beam/pull/34873#issuecomment-2858558590
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated me
damccorm commented on code in PR #34872:
URL: https://github.com/apache/beam/pull/34872#discussion_r2077568591
##
scripts/ci/pr-bot/shared/commentStrings.ts:
##
@@ -39,6 +39,8 @@ export function assignReviewer(labelToReviewerMapping: any):
string {
}
}
+ commentStrin
github-actions[bot] commented on PR #34486:
URL: https://github.com/apache/beam/pull/34486#issuecomment-2858490171
Assigning new set of reviewers because Pr has gone too long without review.
If you would like to opt out of this review, comment `assign to next reviewer`:
R: @chamikaram
github-actions[bot] commented on PR #34063:
URL: https://github.com/apache/beam/pull/34063#issuecomment-2858490436
Assigning new set of reviewers because Pr has gone too long without review.
If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowle
github-actions[bot] commented on PR #34878:
URL: https://github.com/apache/beam/pull/34878#issuecomment-2858461397
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated me
github-actions[bot] commented on issue #30813:
URL: https://github.com/apache/beam/issues/30813#issuecomment-2858459213
Reopening since the workflow is still flaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #34875:
URL: https://github.com/apache/beam/pull/34875#issuecomment-2858351429
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @shunping for label python.
Available commands:
- `stop
github-actions[bot] commented on PR #34799:
URL: https://github.com/apache/beam/pull/34799#issuecomment-2858352473
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated me
github-actions[bot] commented on PR #34872:
URL: https://github.com/apache/beam/pull/34872#issuecomment-2858351758
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @damccorm added as fallback since no labels match configuration
github-actions[bot] commented on PR #34252:
URL: https://github.com/apache/beam/pull/34252#issuecomment-2858362178
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
wollowizard commented on code in PR #34873:
URL: https://github.com/apache/beam/pull/34873#discussion_r2077483390
##
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoder.java:
##
@@ -840,4 +843,38 @@ public boolean equals(@Nullable Object
wollowizard commented on code in PR #34873:
URL: https://github.com/apache/beam/pull/34873#discussion_r2077483390
##
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoder.java:
##
@@ -840,4 +843,38 @@ public boolean equals(@Nullable Object
github-actions[bot] commented on PR #34860:
URL: https://github.com/apache/beam/pull/34860#issuecomment-2858352080
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @ahmedabu98 for label java.
Available commands:
- `stop
wollowizard commented on code in PR #34873:
URL: https://github.com/apache/beam/pull/34873#discussion_r2077484721
##
sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java:
##
@@ -416,6 +417,40 @@ public void testReflectRecordEncodi
liferoad closed issue #34724: The pr-bot-new-prs job is flaky
URL: https://github.com/apache/beam/issues/34724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
liferoad merged PR #34877:
URL: https://github.com/apache/beam/pull/34877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache
liferoad closed issue #34731: The pr-bot-pr-updates job is flaky
URL: https://github.com/apache/beam/issues/34731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
scwhittle commented on code in PR #34653:
URL: https://github.com/apache/beam/pull/34653#discussion_r2077442103
##
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##
@@ -522,11 +517,46 @@ public static
scwhittle commented on PR #34746:
URL: https://github.com/apache/beam/pull/34746#issuecomment-2858247213
BoundedQueueExecutor test is unrelated flake, the spark tests were with side
inputs so not sure if related, rerunning tests.
--
This is an automated message from the Apache Git Service
scwhittle opened a new pull request, #34878:
URL: https://github.com/apache/beam/pull/34878
Fix the following flake, the thread may not have terminated yet. By using
join we enforce that it does terminate but avoid the race.
```
testScheduleWorkWhenExceedMaximumBytesOutstanding[use
Amar3tto opened a new pull request, #34877:
URL: https://github.com/apache/beam/pull/34877
Fixes #34724
Fixes #34731
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Men
scwhittle commented on code in PR #34873:
URL: https://github.com/apache/beam/pull/34873#discussion_r2077109138
##
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoder.java:
##
@@ -840,4 +843,38 @@ public boolean equals(@Nullable Object ot
scwhittle commented on PR #34873:
URL: https://github.com/apache/beam/pull/34873#issuecomment-2857731188
> @scwhittle this is a follow up to our discussion in #34749 and #34750. I
would like to run a test with real data in the dataflow runner, is there a way
to get a snapshot build for this
87 matches
Mail list logo
