andygrove merged PR #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
NoeB commented on PR #1072:
URL:
https://github.com/apache/datafusion-comet/pull/1072#issuecomment-2474685268
It seems that Spark 4.0 rewrites array_append into an array_insert
expression, therefor the test is disabled for spark 4.0+. see
https://github.com/apache/spark/blob/f0d465e09b8d89
NoeB commented on PR #1072:
URL:
https://github.com/apache/datafusion-comet/pull/1072#issuecomment-2471225538
Thank you @andygrove for the review
I have updated the code to match the refactor you did yesterday I guess
that's also the reason for the failing tests.
--
This is an automa
NoeB commented on PR #1072:
URL:
https://github.com/apache/datafusion-comet/pull/1072#issuecomment-2469942871
Because array_append has been added in Spark 3.4 I had to rewrite the match
statement in QueryPlanSerde because it would not compile with spark 3.3 the
same thing applies to the t
NoeB commented on code in PR #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072#discussion_r1837701619
##
native/core/src/execution/datafusion/planner.rs:
##
@@ -691,6 +693,34 @@ impl PhysicalPlanner {
expr.ordinal as usize,
))
andygrove commented on code in PR #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072#discussion_r1837147575
##
native/core/src/execution/datafusion/planner.rs:
##
@@ -691,6 +693,34 @@ impl PhysicalPlanner {
expr.ordinal as usize,
NoeB commented on code in PR #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072#discussion_r1836921855
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2313,4 +2313,22 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpar
andygrove commented on code in PR #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072#discussion_r1835886113
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2313,4 +2313,22 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
NoeB commented on code in PR #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072#discussion_r1835759807
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2313,4 +2313,22 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpar
codecov-commenter commented on PR #1072:
URL:
https://github.com/apache/datafusion-comet/pull/1072#issuecomment-2466808384
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1072?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove commented on code in PR #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072#discussion_r1835729939
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2313,4 +2313,22 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
NoeB commented on PR #1072:
URL:
https://github.com/apache/datafusion-comet/pull/1072#issuecomment-2466260009
I am unsure if I implemented the operation correctly, so I just implemented
the array_append operation as a first step. If the approach is correct, I think
I can extract it to a fu
NoeB opened a new pull request, #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072
## Which issue does this PR close?
Related to #1042: Adds support for array_append operation
## Rationale for this change
## What changes are included in this
13 matches
Mail list logo
