andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1612318862
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -644,14 +644,16 @@ impl Cast {
| DataType::Float32
| Data
andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1612318862
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -644,14 +644,16 @@ impl Cast {
| DataType::Float32
| Data
alamb closed pull request #10636: Add `ParquetExec::builder` API
URL: https://github.com/apache/datafusion/pull/10636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
andygrove merged PR #678:
URL: https://github.com/apache/datafusion-python/pull/678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
andygrove merged PR #714:
URL: https://github.com/apache/datafusion-python/pull/714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
andygrove closed pull request #367: Fix Already Borrowed Panic When
SessionContext Used in Multiple Threads
URL: https://github.com/apache/datafusion-python/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
andygrove commented on PR #367:
URL:
https://github.com/apache/datafusion-python/pull/367#issuecomment-2128107098
I'll go ahead and close this since it has been open for a year and is in
draft.
@kylebrooks-8451 feel free to re-open if you resume work on this
--
This is an automate
alamb opened a new pull request, #10643:
URL: https://github.com/apache/datafusion/pull/10643
## Which issue does this PR close?
Part of #10546
## Rationale for this change
While working on https://github.com/apache/datafusion/pull/10549 it was
cumbersome
to create a
alamb closed pull request #10643: Simplify `ParquetExec::new()`
URL: https://github.com/apache/datafusion/pull/10643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
alamb commented on PR #10643:
URL: https://github.com/apache/datafusion/pull/10643#issuecomment-2128118789
The more I think about this the more I like
https://github.com/apache/datafusion/pull/10636 and deprecate the
ParquetExec::new function...
--
This is an automated message from the A
andygrove merged PR #451:
URL: https://github.com/apache/datafusion-comet/pull/451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
appletreeisyellow commented on issue #10602:
URL: https://github.com/apache/datafusion/issues/10602#issuecomment-2128168367
To make `date_bin` timezone aware, there are some edge cases we need to
consider when design it:
1. **Daylight Saving Time (DST) Transitions:**
- Spring F
appletreeisyellow commented on issue #10602:
URL: https://github.com/apache/datafusion/issues/10602#issuecomment-2128169898
> * Fall Back: When the clocks move backward, there is an "extra" hour. For
example, in US central time zone, when DST ends at 2:00 AM, the clocks are set
back to 1:00
andygrove closed issue #10535: Create a DataFusion blog
URL: https://github.com/apache/datafusion/issues/10535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
andygrove commented on issue #10535:
URL: https://github.com/apache/datafusion/issues/10535#issuecomment-2128187298
This task is complete: https://datafusion.apache.org/blog/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
andygrove opened a new issue, #467:
URL: https://github.com/apache/datafusion-comet/issues/467
### What is the problem the feature request solves?
We currently delegate to DataFusion when casting between timestamps (as
discovered in https://github.com/apache/datafusion-comet/pull/461)
andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1612478631
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -622,14 +590,91 @@ impl Cast {
self.eval_mode,
from_type,
andygrove commented on PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#issuecomment-2128254128
This is ready for review now @viirya @parthchandra @kazuyukitanimura
@huaxingao
--
This is an automated message from the Apache Git Service.
To respond to the message, please
andygrove commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1612492325
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -503,41 +503,37 @@ impl Cast {
fn cast_array(&self, array: ArrayRef) -> DataFusionResult {
andygrove commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1612495192
##
core/src/execution/datafusion/expressions/scalar_funcs/hex.rs:
##
@@ -0,0 +1,371 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
jayzhan211 opened a new pull request, #10644:
URL: https://github.com/apache/datafusion/pull/10644
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested
github-actions[bot] commented on PR #9768:
URL: https://github.com/apache/datafusion/pull/9768#issuecomment-2128338041
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or th
github-actions[bot] commented on PR #9763:
URL: https://github.com/apache/datafusion/pull/9763#issuecomment-2128338094
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or th
advancedxy commented on PR #451:
URL: https://github.com/apache/datafusion-comet/pull/451#issuecomment-2128357191
Thanks everyone for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
vaibhawvipul commented on issue #465:
URL:
https://github.com/apache/datafusion-comet/issues/465#issuecomment-2128357365
I am working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
viirya commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1612605807
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -644,14 +644,16 @@ impl Cast {
| DataType::Float32
| DataTyp
advancedxy commented on code in PR #10607:
URL: https://github.com/apache/datafusion/pull/10607#discussion_r1612607959
##
datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs:
##
@@ -38,42 +38,100 @@ use crate::physical_optimizer::pruning::{PruningPredicate,
Pruni
xinlifoobar opened a new pull request, #10645:
URL: https://github.com/apache/datafusion/pull/10645
## Which issue does this PR close?
Closes #10605
## Rationale for this change
## What changes are included in this PR?
## Are these changes
jayzhan211 closed pull request #9763: Replace logical plan from Arc to Box
URL: https://github.com/apache/datafusion/pull/9763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
viirya merged PR #10641:
URL: https://github.com/apache/datafusion/pull/10641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafus
viirya commented on code in PR #1:
URL:
https://github.com/apache/datafusion-benchmarks/pull/1#discussion_r1612654116
##
runners/datafusion-comet/tpcbench.py:
##
@@ -0,0 +1,108 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
viirya commented on code in PR #1:
URL:
https://github.com/apache/datafusion-benchmarks/pull/1#discussion_r1612654513
##
runners/datafusion-comet/tpcbench.py:
##
@@ -0,0 +1,108 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
vidyasankarv commented on issue #466:
URL:
https://github.com/apache/datafusion-comet/issues/466#issuecomment-2128653555
I will work on this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alamb commented on issue #10155:
URL: https://github.com/apache/datafusion/issues/10155#issuecomment-2128812716
Draft report:
https://docs.google.com/document/d/1h4yjvomQO0XdzxKuE4aBSWGNliFFmn8GADd8DlPuXBw/edit
--
This is an automated message from the Apache Git Service.
To respond to the
alamb commented on PR #10641:
URL: https://github.com/apache/datafusion/pull/10641#issuecomment-2128826061
Thanks @viirya and @advancedxy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
alamb commented on code in PR #10638:
URL: https://github.com/apache/datafusion/pull/10638#discussion_r1613016952
##
datafusion-cli/Dockerfile:
##
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-FROM rust:1.73-bullseye as bui
alamb merged PR #10638:
URL: https://github.com/apache/datafusion/pull/10638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #10472: Docker CLI build fails in WSL2 - "Ubuntu 22.04.4 LTS"
URL: https://github.com/apache/datafusion/issues/10472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
waynexia opened a new pull request, #10646:
URL: https://github.com/apache/datafusion/pull/10646
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
Support convert to/from three
jonahgao commented on code in PR #10640:
URL: https://github.com/apache/datafusion/pull/10640#discussion_r1613068493
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -1686,7 +1691,7 @@ fn to_substrait_bounds(window_frame: &WindowFrame) ->
Result<(Bound, Bound)> {
jonahgao commented on code in PR #10640:
URL: https://github.com/apache/datafusion/pull/10640#discussion_r1613097509
##
datafusion/substrait/src/logical_plan/consumer.rs:
##
@@ -1175,6 +1180,47 @@ pub(crate) fn from_substrait_type(dt:
&substrait::proto::Type) -> Result Result {
alamb opened a new pull request, #10647:
URL: https://github.com/apache/datafusion/pull/10647
## Which issue does this PR close?
Part of #10549
## Rationale for this change
While trying to make an example that uses ParquetExec, I found it's
documentation could be improved
metegenez commented on PR #10590:
URL: https://github.com/apache/datafusion/pull/10590#issuecomment-2129065420
There is a robust method to define column-specific options in Datafusion
table options. I believe there should be a single way to do this in Datafusion,
but BigQuery is widely used
alamb commented on PR #10647:
URL: https://github.com/apache/datafusion/pull/10647#issuecomment-2129087302
@thinkharderdev , @tustvold, @Ted-Jiang and @crepererum: if you have time,
could you double check that this correctly describes `ParquetExec` to your
understanding?
--
This is an
ozankabak commented on PR #10590:
URL: https://github.com/apache/datafusion/pull/10590#issuecomment-2129132050
@davisp what I meant was looking at how other dialects (and systems using
those dialects, such as BigQuery) handle column-specific metadata and analyze
pros and cons of various app
alamb commented on issue #10628:
URL: https://github.com/apache/datafusion/issues/10628#issuecomment-2129137066
Moving out of slack into Github so it might be more easily found
If your usecase is to to get the list of filters and tables that appear in a
query, one way to do this is:
Blizzara commented on code in PR #10640:
URL: https://github.com/apache/datafusion/pull/10640#discussion_r1613246909
##
datafusion/substrait/src/logical_plan/producer.rs:
##
@@ -1686,7 +1691,7 @@ fn to_substrait_bounds(window_frame: &WindowFrame) ->
Result<(Bound, Bound)> {
crepererum commented on issue #10631:
URL: https://github.com/apache/datafusion/issues/10631#issuecomment-2129296188
I would suggest a rather larger refactoring? We have:
- `SessionState`
- `SessionConfig`
- `SessionContext`
- `TaskContext`
- `RuntimeConfig`
- `RuntimeEn
mustafasrepo opened a new pull request, #10648:
URL: https://github.com/apache/datafusion/pull/10648
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes test
crepererum commented on code in PR #10647:
URL: https://github.com/apache/datafusion/pull/10647#discussion_r1613322378
##
datafusion/core/src/datasource/physical_plan/parquet/mod.rs:
##
@@ -75,7 +75,79 @@ pub use metrics::ParquetFileMetrics;
pub use schema_adapter::{SchemaAdapt
mustafasrepo opened a new pull request, #10649:
URL: https://github.com/apache/datafusion/pull/10649
## Which issue does this PR close?
Closes #10477.
## Rationale for this change
See [issue
body](https://github.com/apache/datafusion/issues/10477#issue-22
berkaysynnada opened a new pull request, #10650:
URL: https://github.com/apache/datafusion/pull/10650
## Which issue does this PR close?
Closes #.
## Rationale for this change
When CSV header option is not specified from the options clause, it is set
from
jayzhan211 commented on code in PR #10648:
URL: https://github.com/apache/datafusion/pull/10648#discussion_r1613370248
##
datafusion/functions-aggregate/src/first_last.rs:
##
@@ -161,6 +144,23 @@ impl AggregateUDFImpl for FirstValue {
fn aliases(&self) -> &[String] {
andygrove commented on issue #328:
URL:
https://github.com/apache/datafusion-comet/issues/328#issuecomment-2129430050
There is a follow on issue to complete this work:
https://github.com/apache/datafusion-comet/issues/376
--
This is an automated message from the Apache Git Service.
To re
mbwhite commented on issue #646:
URL:
https://github.com/apache/datafusion-python/issues/646#issuecomment-2129449063
FYI _ tried the v38.0.0. from pypi-test and problem remains.
Rebuilding the code locally and using the wheel created then works fine
`maturin build --features substrait`
matthewmturner commented on PR #10600:
URL: https://github.com/apache/datafusion/pull/10600#issuecomment-2129456972
@alamb i have a working example now. i have idea to update it to show more
of the streaming nature (i.e. write to the fifo and get batches multiple times)
but wont have time f
jayzhan211 opened a new pull request, #10651:
URL: https://github.com/apache/datafusion/pull/10651
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested
jonahgao merged PR #10640:
URL: https://github.com/apache/datafusion/pull/10640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
jonahgao commented on PR #10640:
URL: https://github.com/apache/datafusion/pull/10640#issuecomment-2129492219
I plan to merge this PR now as it might conflict with #10646.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
westonpace commented on code in PR #10634:
URL: https://github.com/apache/datafusion/pull/10634#discussion_r1613461895
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -4374,6 +4374,42 @@ GROUP BY dummy
text1, text1, text1
+# Tests for aggregating with NaN val
westonpace commented on PR #10627:
URL: https://github.com/apache/datafusion/pull/10627#issuecomment-2129505697
> So that suggests to me it treats NaN as the largest floating point value
If this is the case then there is divergence between postgres and arrow-rs.
Which takes priority?
westonpace commented on PR #10627:
URL: https://github.com/apache/datafusion/pull/10627#issuecomment-2129511762
> So that suggests to me it treats NaN as the largest floating point value
This is confirmed in the latest version of the [postgres
docs](https://www.postgresql.org/docs/cur
faucct commented on issue #2703:
URL: https://github.com/apache/datafusion/issues/2703#issuecomment-2129536338
Though the paper that you have mentioned admits that JIT-compilation is
beneficial for OLTP workloads:
> Besides OLAP performance, other factors also play an important role.
Omega359 commented on PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#issuecomment-2129537623
This shouldn't have passed checks.
```
+ cargo fmt --all -- --check
`cargo metadata` exited with an error: error: failed to load manifest for
workspace member `/opt/dev/
jayzhan211 commented on code in PR #10644:
URL: https://github.com/apache/datafusion/pull/10644#discussion_r1613540288
##
datafusion/functions-aggregate/src/median.rs:
##
@@ -15,71 +15,105 @@
// specific language governing permissions and limitations
// under the License.
-/
jayzhan211 commented on code in PR #10644:
URL: https://github.com/apache/datafusion/pull/10644#discussion_r1613550658
##
datafusion/functions-aggregate/Cargo.toml:
##
@@ -39,6 +39,7 @@ path = "src/lib.rs"
[dependencies]
arrow = { workspace = true }
+arrow-schema = { workspa
andygrove opened a new issue, #468:
URL: https://github.com/apache/datafusion-comet/issues/468
### Describe the bug
In `CometExpressionSuite` we have two tests that are ignored for Spark 3.2
and 3.3.
```scala
test("cast timestamp and timestamp_ntz to string") {
// T
andygrove closed issue #227: Bad CPU type in executable protoc-jar
URL: https://github.com/apache/datafusion-comet/issues/227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
andygrove commented on issue #227:
URL:
https://github.com/apache/datafusion-comet/issues/227#issuecomment-2129653865
This is no longer an issue for me and we have not had other reports of this
happening, so will close this
--
This is an automated message from the Apache Git Service.
To
cisaacson commented on issue #10628:
URL: https://github.com/apache/datafusion/issues/10628#issuecomment-2129731243
This looks very good, pretty much what I implemented. The only question I
have remaining is:
If `TableScan` has `filters` why would that not catch all filters? What does
alamb commented on issue #10628:
URL: https://github.com/apache/datafusion/issues/10628#issuecomment-2129736024
> If TableScan has filters why would that not catch all filters?
Depending on the value of
https://docs.rs/datafusion/latest/datafusion/logical_expr/enum.TableProviderFilte
Blizzara commented on PR #10531:
URL: https://github.com/apache/datafusion/pull/10531#issuecomment-2129741689
@jonahgao @alamb this last one is ready now too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
goldmedal opened a new issue, #10652:
URL: https://github.com/apache/datafusion/issues/10652
### Is your feature request related to a problem or challenge?
We only support to convert JOIN with `ON` constraint to SQL String now. The
SQL as below can't be converted now.
```
SELECT
goldmedal commented on issue #10652:
URL: https://github.com/apache/datafusion/issues/10652#issuecomment-2129764802
By the way, I saw there're other unimplemented plans in `plan.rs`:
- Distinct
- Union
- Window
- Extension (I guess we need to provide some method for
`UserDefinedL
cisaacson commented on issue #10628:
URL: https://github.com/apache/datafusion/issues/10628#issuecomment-2129782772
Got it, that makes total sense. I will only care about the accepted pushdown
filters, so the `TableScan` will work for what we need.
--
This is an automated message from th
andygrove merged PR #433:
URL: https://github.com/apache/datafusion-comet/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
andygrove closed issue #427: bug: hash expression is not consistent with Spark
URL: https://github.com/apache/datafusion-comet/issues/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
comphead commented on code in PR #10649:
URL: https://github.com/apache/datafusion/pull/10649#discussion_r1613680726
##
datafusion/proto-common/Cargo.toml:
##
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements
comphead commented on code in PR #10649:
URL: https://github.com/apache/datafusion/pull/10649#discussion_r1613684688
##
datafusion/proto-common/gen/src/main.rs:
##
@@ -0,0 +1,57 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
comphead commented on code in PR #10649:
URL: https://github.com/apache/datafusion/pull/10649#discussion_r1613687288
##
datafusion/proto-common/src/lib.rs:
##
@@ -0,0 +1,62 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreemen
comphead commented on code in PR #10649:
URL: https://github.com/apache/datafusion/pull/10649#discussion_r1613685757
##
datafusion/proto-common/src/common.rs:
##
@@ -0,0 +1,22 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agree
comphead commented on code in PR #10642:
URL: https://github.com/apache/datafusion/pull/10642#discussion_r1613714632
##
datafusion/core/tests/parquet/arrow_statistics.rs:
##
@@ -212,13 +218,13 @@ impl Test {
let expected_null_counts = Arc::new(expected_null_counts) as A
comphead commented on code in PR #10642:
URL: https://github.com/apache/datafusion/pull/10642#discussion_r1613715175
##
datafusion/core/tests/parquet/arrow_statistics.rs:
##
@@ -212,13 +218,13 @@ impl Test {
let expected_null_counts = Arc::new(expected_null_counts) as A
andygrove opened a new pull request, #469:
URL: https://github.com/apache/datafusion-comet/pull/469
## Which issue does this PR close?
N/A
## Rationale for this change
Regular expression support is usually important in ETL jobs, so we should
start adding
faucct commented on issue #2703:
URL: https://github.com/apache/datafusion/issues/2703#issuecomment-2129907158
I think that compiling SQL-expressions to UDFs by hand would kinda kill the
whole point of the framework, but it seems like most of the framework would be
irrelevant for the in-mem
Blizzara opened a new pull request, #10653:
URL: https://github.com/apache/datafusion/pull/10653
Substrait 0.32.0+ requires functions to be specified using compound names,
which include the function name as well as the arguments it takes. We don't
necessarily need that information while con
Blizzara commented on PR #10653:
URL: https://github.com/apache/datafusion/pull/10653#issuecomment-2129941680
@alamb curious what you think of fixing just the consumer side first,
without touching the producer - if that'd be okay, then I can add some unit
tests to this PR?
--
This is an
viirya commented on code in PR #469:
URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1613739740
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -1094,24 +1094,46 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde wit
andygrove commented on code in PR #469:
URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1613743037
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -1094,24 +1094,46 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde
metegenez commented on code in PR #10650:
URL: https://github.com/apache/datafusion/pull/10650#discussion_r1613754503
##
datafusion/core/src/datasource/file_format/csv.rs:
##
@@ -301,13 +296,7 @@ impl CsvFormat {
while let Some(chunk) = stream.next().await.transpose()
tshauck commented on PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#issuecomment-2130054380
I think I made the updates requested in the latest round. I left the
dictionary handling the same, but I can look into flattening the dictionary
specific to hex if you guys think i
planga82 commented on issue #464:
URL:
https://github.com/apache/datafusion-comet/issues/464#issuecomment-2130081236
I want to try this!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
jeffreyssmith2nd commented on issue #7925:
URL: https://github.com/apache/datafusion/issues/7925#issuecomment-2130106971
The case we're running into in InfluxDB when enabling timezones is slightly
different. It is a parquet file with Timestamp without a timezone and then
querying with eithe
alamb opened a new issue, #10654:
URL: https://github.com/apache/datafusion/issues/10654
### Describe the bug
Expr::field is broken for ScalarValue::Null
After https://github.com/apache/datafusion/pull/10375 merged `Expr::field`
is broken when we try and do it on `ScalarValue::
kazuyukitanimura commented on code in PR #461:
URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1613863992
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -622,14 +590,89 @@ impl Cast {
self.eval_mode,
fro
kazuyukitanimura commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1613906351
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1038,6 +1038,20 @@ class CometExpressionSuite extends CometTestBase with
Ad
timsaucer opened a new issue, #715:
URL: https://github.com/apache/datafusion-python/issues/715
**Describe the bug**
When you have a column that is a struct of struct and you attempt to index
into the lowest level, if there is a null at the first level of the struct you
get an unexpected
alamb commented on issue #2703:
URL: https://github.com/apache/datafusion/issues/2703#issuecomment-2130243583
FIW there is a lot more to SQL evaluation than just the expression
evaluation, so that might be a reason to use DataFusion even if you had to
implement your own expressions 🤔
--
duongcongtoai opened a new issue, #10656:
URL: https://github.com/apache/datafusion/issues/10656
### Describe the bug
Given this slt
```
statement ok
CREATE TABLE temp
AS VALUES
([struct(1,2)])
;
query ?
select unnest(column1) as struct_elem from temp;
duongcongtoai commented on issue #10656:
URL: https://github.com/apache/datafusion/issues/10656#issuecomment-2130247278
I'm open a PR to fix soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
701 - 800 of 75795 matches
Mail list logo
