bneradt commented on PR #10720:
URL: https://github.com/apache/trafficserver/pull/10720#issuecomment-1792789763
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dragon512 commented on PR #10720:
URL: https://github.com/apache/trafficserver/pull/10720#issuecomment-1792799413
> We need to set up something similar to the clang-format hook for
cmake-format. To document a workflow here:
>
> ```
> python3 -m pip install cmake-format
> cmake-f
bneradt commented on PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#issuecomment-1792802061
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
SolidWallOfCode commented on code in PR #10724:
URL: https://github.com/apache/trafficserver/pull/10724#discussion_r1381986394
##
cmake/AutoOptionHelpers.cmake:
##
@@ -21,17 +21,20 @@ set(GLOBAL_AUTO_OPTION_VARS "")
function(_REGISTER_AUTO_OPTION _NAME _FEATURE_VAR _DESCRIPTI
SolidWallOfCode commented on PR #10724:
URL: https://github.com/apache/trafficserver/pull/10724#issuecomment-1792817131
Most of this PR is formatting changes - could you undo those to make the
actual change clearer?
--
This is an automated message from the Apache Git Service.
To respond t
traeak commented on PR #10723:
URL: https://github.com/apache/trafficserver/pull/10723#issuecomment-1792840491
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
JosiahWI commented on PR #10724:
URL: https://github.com/apache/trafficserver/pull/10724#issuecomment-1792858816
The formatting changes are done by the formatter we agreed to use for
consistency. Maybe it can be split into 2 separate commits?
--
This is an automated message from the Apach
dragon512 commented on PR #10720:
URL: https://github.com/apache/trafficserver/pull/10720#issuecomment-1792900087
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cmcfarlen commented on code in PR #10724:
URL: https://github.com/apache/trafficserver/pull/10724#discussion_r1382065246
##
cmake/AutoOptionHelpers.cmake:
##
@@ -21,17 +21,20 @@ set(GLOBAL_AUTO_OPTION_VARS "")
function(_REGISTER_AUTO_OPTION _NAME _FEATURE_VAR _DESCRIPTION _DE
ywkaras commented on PR #10722:
URL: https://github.com/apache/trafficserver/pull/10722#issuecomment-1792942058
Shouldn't test_Regex.cc also move, to src/tscpp/util/unit_tests ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lzx404243 opened a new pull request, #10726:
URL: https://github.com/apache/trafficserver/pull/10726
The `tunnel_transform` test failed internally in certain environment as the
actual TLS traffic byte counts fell out of the hard-coded range of expected
value.
The TLS byte count can
lzx404243 commented on PR #10726:
URL: https://github.com/apache/trafficserver/pull/10726#issuecomment-1793007074
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cmcfarlen commented on PR #10725:
URL: https://github.com/apache/trafficserver/pull/10725#issuecomment-1793011718
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
JosiahWI commented on code in PR #10724:
URL: https://github.com/apache/trafficserver/pull/10724#discussion_r1382168471
##
cmake/AutoOptionHelpers.cmake:
##
@@ -21,17 +21,20 @@ set(GLOBAL_AUTO_OPTION_VARS "")
function(_REGISTER_AUTO_OPTION _NAME _FEATURE_VAR _DESCRIPTION _DEF
JosiahWI commented on code in PR #10724:
URL: https://github.com/apache/trafficserver/pull/10724#discussion_r1382169359
##
cmake/AutoOptionHelpers.cmake:
##
@@ -21,17 +21,20 @@ set(GLOBAL_AUTO_OPTION_VARS "")
function(_REGISTER_AUTO_OPTION _NAME _FEATURE_VAR _DESCRIPTION _DEF
cmcfarlen commented on PR #10725:
URL: https://github.com/apache/trafficserver/pull/10725#issuecomment-1793074895
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
bryancall opened a new pull request, #281:
URL: https://github.com/apache/trafficserver-ci/pull/281
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
zwoop commented on PR #10716:
URL: https://github.com/apache/trafficserver/pull/10716#issuecomment-1793194274
Yeh, I gave up on the matchers for now at least :/.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
maskit opened a new pull request, #10727:
URL: https://github.com/apache/trafficserver/pull/10727
This moves function definitions into the .cc file so the header file doesn't
bring unrelated dependencies.
- Functions are just moved and not modified
- private header file P_SNIAction
zwoop opened a new pull request, #10728:
URL: https://github.com/apache/trafficserver/pull/10728
Note that this doesn't quite fix the simulator, we have to figure out how to
feed it a YAML initialization.
--
This is an automated message from the Apache Git Service.
To respond to the messa
zwoop opened a new pull request, #10729:
URL: https://github.com/apache/trafficserver/pull/10729
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
zwoop merged PR #10728:
URL: https://github.com/apache/trafficserver/pull/10728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traff
github-actions[bot] commented on PR #10156:
URL: https://github.com/apache/trafficserver/pull/10156#issuecomment-1793955742
This pull request has been automatically marked as stale because it has not
had recent activity. Marking it stale to flag it for further consideration by
the community
JosiahWI opened a new pull request, #10732:
URL: https://github.com/apache/trafficserver/pull/10732
This contains just the file loading and root validation part of a YAML
loader for SplitDNS. I foresee that the complete feature will be a large
change, and I would like feedback now while the
traeak opened a new pull request, #10733:
URL: https://github.com/apache/trafficserver/pull/10733
This should fix the failing branch builds on various linux distributions
(ie: debian11/gcc/release)
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
traeak merged PR #10733:
URL: https://github.com/apache/trafficserver/pull/10733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traf
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383765691
##
doc/admin-guide/files/records.yaml.en.rst:
##
@@ -507,6 +507,23 @@ Network
between `proxy.config.net.max_connections_in` and
`proxy.config.net.m
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383766461
##
doc/admin-guide/files/records.yaml.en.rst:
##
@@ -507,6 +507,23 @@ Network
between `proxy.config.net.max_connections_in` and
`proxy.config.net.m
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383770475
##
include/iocore/net/ConnectionTracker.h:
##
@@ -43,10 +44,11 @@
#include "iocore/net/SessionSharingAPIEnums.h"
/**
- * Singleton class to keep tra
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383773953
##
include/iocore/net/ConnectionTracker.h:
##
@@ -107,49 +111,54 @@ class ConnectionTracker
MatchType const &_match_type; ///< Type of matching.
bneradt commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383776021
##
doc/admin-guide/files/records.yaml.en.rst:
##
@@ -507,6 +507,23 @@ Network
between `proxy.config.net.max_connections_in` and
`proxy.config.net.max_reque
bneradt commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383777028
##
include/iocore/net/ConnectionTracker.h:
##
@@ -43,10 +44,11 @@
#include "iocore/net/SessionSharingAPIEnums.h"
/**
- * Singleton class to keep track of th
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383817545
##
include/iocore/net/ConnectionTracker.h:
##
@@ -166,9 +175,9 @@ class ConnectionTracker
void blocked();
/// Clear all reservations.
voi
dragon512 opened a new pull request, #10734:
URL: https://github.com/apache/trafficserver/pull/10734
Use standard pattern to find libraries and naming for constancy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383829121
##
src/iocore/net/ConnectionTracker.cc:
##
@@ -148,10 +163,31 @@ ConnectionTracker::config_init(GlobalConfig *global,
TxnConfig *txn)
_global_config
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383829626
##
src/iocore/net/ConnectionTracker.cc:
##
@@ -161,17 +197,46 @@ ConnectionTracker::obtain_outbound(TxnConfig const
&txn_cnf, std::string_view fq
Cr
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383834333
##
src/iocore/net/ConnectionTracker.cc:
##
@@ -222,25 +287,46 @@ ConnectionTracker::Group::should_alert(std::time_t *lat)
return zret;
}
+void
+Co
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383836725
##
src/iocore/net/ConnectionTracker.cc:
##
@@ -222,25 +287,46 @@ ConnectionTracker::Group::should_alert(std::time_t *lat)
return zret;
}
+void
+Co
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383839164
##
src/iocore/net/ConnectionTracker.cc:
##
@@ -222,25 +287,46 @@ ConnectionTracker::Group::should_alert(std::time_t *lat)
return zret;
}
+void
+Co
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383847399
##
src/iocore/net/UnixNetAccept.cc:
##
@@ -82,10 +83,29 @@ net_accept(NetAccept *na, void *ep, bool blockable)
}
Metrics::increment(net_rsb.tc
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383847399
##
src/iocore/net/UnixNetAccept.cc:
##
@@ -82,10 +83,29 @@ net_accept(NetAccept *na, void *ep, bool blockable)
}
Metrics::increment(net_rsb.tc
dragon512 closed pull request #10720: Update CMakeLists.txt
URL: https://github.com/apache/trafficserver/pull/10720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
dragon512 commented on PR #10720:
URL: https://github.com/apache/trafficserver/pull/10720#issuecomment-1796066147
Closing PR.. will remake a new one with other tweaks as the better pattern
is now known for us to use
--
This is an automated message from the Apache Git Service.
To respond t
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383848717
##
src/iocore/net/UnixNetAccept.cc:
##
@@ -341,6 +361,23 @@ NetAccept::do_blocking_accept(EThread *t)
Metrics::increment(net_rsb.connections_thro
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383849071
##
src/iocore/net/UnixNetAccept.cc:
##
@@ -461,6 +500,22 @@ NetAccept::acceptFastEvent(int event, void *ep)
Metrics::increment(net_rsb.connecti
JosiahWI commented on PR #10734:
URL: https://github.com/apache/trafficserver/pull/10734#issuecomment-1796147271
This will break the ability to find `NuRaftConfig.cmake` on case sensitive
systems. I can submit a PR to NuRaft to change the name to
`nuraft-config.cmake`.
We could just
bneradt commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383863839
##
include/iocore/net/ConnectionTracker.h:
##
@@ -166,9 +175,9 @@ class ConnectionTracker
void blocked();
/// Clear all reservations.
void clear(
bneradt commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383864458
##
src/iocore/net/ConnectionTracker.cc:
##
@@ -148,10 +163,31 @@ ConnectionTracker::config_init(GlobalConfig *global,
TxnConfig *txn)
_global_config = globa
bneradt commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383865552
##
src/iocore/net/ConnectionTracker.cc:
##
@@ -161,17 +197,46 @@ ConnectionTracker::obtain_outbound(TxnConfig const
&txn_cnf, std::string_view fq
CryptoHash
bneradt commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383866568
##
src/iocore/net/ConnectionTracker.cc:
##
@@ -222,25 +287,46 @@ ConnectionTracker::Group::should_alert(std::time_t *lat)
return zret;
}
+void
+Connection
SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383836725
##
src/iocore/net/ConnectionTracker.cc:
##
@@ -222,25 +287,46 @@ ConnectionTracker::Group::should_alert(std::time_t *lat)
return zret;
}
+void
+Co
dragon512 commented on PR #10734:
URL: https://github.com/apache/trafficserver/pull/10734#issuecomment-1796187703
> This will break the ability to find `NuRaftConfig.cmake` on case sensitive
systems. I can submit a PR to NuRaft to change the name to
`nuraft-config.cmake`.
>
> We coul
dragon512 opened a new pull request, #10735:
URL: https://github.com/apache/trafficserver/pull/10735
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
JosiahWI commented on PR #10735:
URL: https://github.com/apache/trafficserver/pull/10735#issuecomment-1796300772
#10723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
JosiahWI commented on PR #10734:
URL: https://github.com/apache/trafficserver/pull/10734#issuecomment-1796348862
We will have to submit a PR to NuRaft before we can use
`find_package(nuraft)` with their config; however, if we intend to maintain our
own Find module, then submitting that PR m
JosiahWI commented on PR #10735:
URL: https://github.com/apache/trafficserver/pull/10735#issuecomment-1796380932
[approve ci centos]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
JosiahWI commented on PR #10735:
URL: https://github.com/apache/trafficserver/pull/10735#issuecomment-1796380742
CacheDir test timed out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
bryancall merged PR #10590:
URL: https://github.com/apache/trafficserver/pull/10590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
traeak opened a new pull request, #282:
URL: https://github.com/apache/trafficserver-ci/pull/282
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
traeak merged PR #282:
URL: https://github.com/apache/trafficserver-ci/pull/282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traff
bryancall commented on code in PR #10627:
URL: https://github.com/apache/trafficserver/pull/10627#discussion_r1384001096
##
include/proxy/http2/Http2CommonSession.h:
##
@@ -169,6 +174,21 @@ class Http2CommonSession
int64_t read_from_early_data = 0;
bool cur_frame_from_ea
dragon512 commented on PR #10734:
URL: https://github.com/apache/trafficserver/pull/10734#issuecomment-1796507400
That is fine with me. We need this now. we can change it later if we want to
after a new nuraft is made. Till then I believe it better to follow convention
we have in CMake to n
maskit commented on code in PR #10627:
URL: https://github.com/apache/trafficserver/pull/10627#discussion_r1384024926
##
include/proxy/http2/Http2CommonSession.h:
##
@@ -169,6 +174,21 @@ class Http2CommonSession
int64_t read_from_early_data = 0;
bool cur_frame_from_early
dragon512 opened a new pull request, #10736:
URL: https://github.com/apache/trafficserver/pull/10736
Allow plugin to build if required library exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
bneradt commented on code in PR #10729:
URL: https://github.com/apache/trafficserver/pull/10729#discussion_r1384147738
##
example/cripts/example1.cc:
##
@@ -27,7 +27,7 @@ static Matcher::Range::IP CRIPT_ALLOW({"192.168.201.0/24",
"10.0.0.0/8"});
// This is called only when the
bneradt commented on code in PR #10729:
URL: https://github.com/apache/trafficserver/pull/10729#discussion_r1384159323
##
example/cripts/example1.cc:
##
@@ -27,7 +27,7 @@ static Matcher::Range::IP CRIPT_ALLOW({"192.168.201.0/24",
"10.0.0.0/8"});
// This is called only when the
maskit merged PR #10727:
URL: https://github.com/apache/trafficserver/pull/10727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traf
cmcfarlen merged PR #10714:
URL: https://github.com/apache/trafficserver/pull/10714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
bryancall commented on PR #10703:
URL: https://github.com/apache/trafficserver/pull/10703#issuecomment-1797042422
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384181248
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage _
bryancall commented on PR #10692:
URL: https://github.com/apache/trafficserver/pull/10692#issuecomment-1797046286
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384181248
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage _
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384182142
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage _
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384182301
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage _
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384183162
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage _
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384183701
##
include/api/Metrics.h:
##
@@ -103,16 +125,9 @@ class Metrics
return std::nullopt;
}
Review Comment:
It's used in the tests :). But it could be used
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384184194
##
include/proxy/http2/Http2ServerSession.h:
##
@@ -72,13 +72,13 @@ class Http2ServerSession : public PoolableSession, public
Http2CommonSession
void
incre
bneradt commented on code in PR #10725:
URL: https://github.com/apache/trafficserver/pull/10725#discussion_r1384190854
##
src/api/CMakeLists.txt:
##
@@ -32,23 +37,32 @@ set(TSAPI_PUBLIC_HEADERS
target_link_libraries(tsapi PRIVATE libswoc yaml-cpp::yaml-cpp PCRE::PCRE
OpenSSL::
maskit merged PR #10719:
URL: https://github.com/apache/trafficserver/pull/10719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traf
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384224789
##
include/proxy/http2/Http2ServerSession.h:
##
@@ -72,13 +72,13 @@ class Http2ServerSession : public PoolableSession, public
Http2CommonSession
void
inc
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384226458
##
include/api/Metrics.h:
##
@@ -45,23 +45,47 @@ class Metrics
private:
using self_type = Metrics;
+ class AtomicType
+ {
+friend class Metrics;
+
+
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384228993
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384229476
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384229941
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384232603
##
src/iocore/aio/test_AIO.cc:
##
@@ -223,11 +223,11 @@ dump_summary()
auto &m = Metrics::getInstance();
- Metrics::IntType *completed =
m.lookup(m.loo
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384237521
##
src/iocore/aio/test_AIO.cc:
##
@@ -223,11 +223,11 @@ dump_summary()
auto &m = Metrics::getInstance();
- Metrics::IntType *completed =
m.lookup(m.loo
masaori335 opened a new pull request, #10737:
URL: https://github.com/apache/trafficserver/pull/10737
Part of #10628.
Main changes are renaming members of CacheVC.
```
Stripe *vol;
int scanVol(int event, Event *e);
char *scan_vol_map;
```
to
```
Str
masaori335 commented on PR #10737:
URL: https://github.com/apache/trafficserver/pull/10737#issuecomment-1797388067
Draft until https://github.com/apache/trafficserver/pull/10710 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384224789
##
include/proxy/http2/Http2ServerSession.h:
##
@@ -72,13 +72,13 @@ class Http2ServerSession : public PoolableSession, public
Http2CommonSession
void
inc
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384340255
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384340967
##
src/iocore/hostdb/P_RefCountCache.h:
##
@@ -428,21 +428,19 @@ RefCountCache::RefCountCache(unsigned int
num_partitions, int size, int items
bneradt opened a new pull request, #10738:
URL: https://github.com/apache/trafficserver/pull/10738
This makes the naming of the Group members consistent by giving prefacing
min_keep_alive_conns with an underscore.
--
This is an automated message from the Apache Git Service.
To respond to
bneradt commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1384347144
##
src/iocore/net/ConnectionTracker.cc:
##
@@ -161,17 +197,46 @@ ConnectionTracker::obtain_outbound(TxnConfig const
&txn_cnf, std::string_view fq
CryptoHash
ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384224789
##
include/proxy/http2/Http2ServerSession.h:
##
@@ -72,13 +72,13 @@ class Http2ServerSession : public PoolableSession, public
Http2CommonSession
void
inc
ywkaras commented on code in PR #10712:
URL: https://github.com/apache/trafficserver/pull/10712#discussion_r1384375973
##
src/records/P_RecCore.cc:
##
@@ -35,6 +35,7 @@
#include "swoc/bwf_std.h"
#include
+#include
Review Comment:
Why do you need this?
--
This is an
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384381429
##
src/iocore/hostdb/P_RefCountCache.h:
##
@@ -428,21 +428,19 @@ RefCountCache::RefCountCache(unsigned int
num_partitions, int size, int items
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384381660
##
src/iocore/aio/test_AIO.cc:
##
@@ -223,11 +223,11 @@ dump_summary()
auto &m = Metrics::getInstance();
- Metrics::IntType *completed =
m.lookup(m.looku
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384382038
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage _
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384382238
##
include/api/Metrics.h:
##
@@ -289,10 +280,126 @@ class Metrics
mutable std::mutex _mutex;
LookupTable _lookups;
- MetricBlobs _blobs;
+ BlobStorage _
zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384381660
##
src/iocore/aio/test_AIO.cc:
##
@@ -223,11 +223,11 @@ dump_summary()
auto &m = Metrics::getInstance();
- Metrics::IntType *completed =
m.lookup(m.looku
1 - 100 of 12647 matches
Mail list logo
