[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: Reducing the font size might be the reason for icons to look too big in comparison, whereas the display was just entirely scaled up somehow… I have no idea (my Bookworm looks as above, but it's not 100% stock),

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-11 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > - if [ -z "${PATCH}" ] || [ "${PATCH}" = "0" ]; then - MINOR="$((MINOR-1))" - PATCH="90" + if [[ "${MINOR}" = "0" && (-z "${PATCH}" || "${PATCH}" = "0") ]]; then +

[Github-comments] [geany/geany] Fix blooper leading to incorrect variable formatting (PR #3604)

2023-10-16 Thread Colomban Wendling via Github-comments
188038a06a1050308fd7621f11147883d7e5b8fc extended the formatting options, but a blooper made it effectively ignore the language-specific rules, always using the default one. This affects formatting for Go, Pascal and Python, as well as introducing memory leaks for those. You can view, comment

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-16 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. Apart the small doc changes, LGTM. Limited testing shows it works nicely, including mixed languages in a tags file. Older tags files I had laying around using either Pipe or Tagmanager format still seemed to work as usual. I didn't have any older ctags tags

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-16 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > { - if ((NULL == fgets(buf, BUFSIZ, fp)) || ('\0' == *buf)) - return FALSE; - } - while (strncmp(buf, "!_TAG_", 6) == 0); /* skip !_TAG_ lines */ + TMTagType type; + TMTag

[Github-comments] [geany/geany] Prefs: move "virtual spaces" to the "Features" tab (Issue #3605)

2023-10-16 Thread Colomban Wendling via Github-comments
As @techee (IIRC) mentioned somewhere, the *Editor→Display* tab is getting crowded to the point it makes the prefs window grow. I suggest moving the *Virtual spaces* section to the *Editor→Features* tab that not only has room, but also seems more fitting to me – it's not a display thing, it's

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-16 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3049#pullrequestreview-1681065041 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-16 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. Looks fairly useful and simple enough :+1: Apart from my inline comments, LGTM and WFM. > + gtk_container_add(GTK_CONTAINER(menu), item); + gtk_menu_reorder_child(GTK_MENU(menu), item, 0); ```suggestion

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. Thanks a lot for debugging this up to that point! I somehow didn't notice this until fairly recently, and was puzzled (and frightened) at what it could be, yet didn't have time to dig in. And now I see you did, yay! I don't see a problem re-asking for the

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -878,6 +878,10 @@ get_widget_for_buf_range (GeanyDocument *doc, MIN (width + 2, alloc.width), MIN (height + 1, alloc.height)); + /* Size request seems to scroll Scintilla view so we

[Github-comments] Re: [geany/geany-plugins] Spellecheck: Update style mappings (PR #1277)

2023-10-13 Thread Colomban Wendling via Github-comments
> Implicitly require Geany 2.0 for G-P as the SpellCheck plugin makes uses of > new Scintilla API. > > Is this OK? It is, especially as I just merged #1281 which also uses newer API :smile: -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Change popup not working in git-changebar after updating to Scintilla to 5.3.7 (Issue #1279)

2023-10-13 Thread Colomban Wendling via Github-comments
Closed #1279 as completed via #1280. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1279#event-10648933493 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Colomban Wendling via Github-comments
Merged #1280 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1280#event-10648933358 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] GitChangebar: disable Scintilla's Change History in diff tooltip (PR #1281)

2023-10-13 Thread Colomban Wendling via Github-comments
Merged #1281 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1281#event-10648370202 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM. I don't understand what's actually going on, especially as from my tests it seems to work alright without this for lines <= 182 for me (yes, that feels random). Changes on later lines are stuck starting at line 182… Anyway, this works and shouldn't cause

[Github-comments] Re: [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-13 Thread Colomban Wendling via Github-comments
> It's actually kind of surprising that it works now because > `SCI_POINTXFROMPOSITION` didn't work when I removed `SCI_SETFIRSTVISIBLELINE` > in front of the size request and moved it behind - so > `SCI_POINTXFROMPOSITION` works only for the displayed editor area but in this > case it isn't

[Github-comments] Re: [geany/geany-plugins] GitChangebar: disable Scintilla's Change History in diff tooltip (PR #1281)

2023-10-13 Thread Colomban Wendling via Github-comments
Thanks! I didn't see it behave so badly as your screenshot, but it also looks weird if the inline option is enabled, so disabling it altogether in the popup seems the way to go -- and no, we don't need it anyway :) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
> Yeah, will happily add it once it is merged 爛 It just got in :wink: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1765856443 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Clang warnings: sizeof ((((void *)0)))' will return the size of the pointer (#2906)

2023-10-17 Thread Colomban Wendling via Github-comments
See #2398 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2906#issuecomment-1765889149 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-17 Thread Colomban Wendling via Github-comments
Merged #3049 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3049#event-10674470211 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: I'll try and grab my girlfriend's Bullseye (yeah, not updated yet…) which has whatever version of GNOME shell that came with it, and see if it looks more "normal". If it does, I'll take the screenshots later

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-15 Thread Colomban Wendling via Github-comments
What about simply adding a `q` command after the first replacement so only that one is handled? Le 15 octobre 2023 10:05:04 GMT+02:00, "Enrico Tröger" ***@***.***> a écrit : >@eht16 commented on this pull request. > > > >> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: FWIW I just tried in Bookworm VM as well, and was shocked that @eht16 is not crazy and it *does* look like this, be it on Wayland or X11… playing a tad with it, it's due to the Adwaita icons, if I use that on

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: @eht16 if you move those out of the way: * */usr/share/icons/Adwaita/48x48/legacy/edit-clear-all.png* * */usr/share/icons/Adwaita/48x48/legacy/edit-clear.png* *

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. WFM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3599#pullrequestreview-1682534844 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Fix logic comparing version numbers (PR #1284)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM (not tested) Indeed the check is wrong in many aspects -- event 0.0.2 would be < then 1.38.1 Also, it uses `GEANY_VERSION`, which is a compile-time thing, so better update your update checker! It could benefit from Geany exposing

[Github-comments] Re: [geany/geany-plugins] [WIP] commander: fixed deprecated gtk3 calls (#865)

2023-10-17 Thread Colomban Wendling via Github-comments
Closed #865 via 38a138f8c0df31787a3f579c5a606c6a71bb1fd9. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/865#event-10680086514 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] commander: Silence expected deprecation warnings (#952)

2023-10-17 Thread Colomban Wendling via Github-comments
Merged #952 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/952#event-10680086535 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/ ' -i geany_private.rc sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac +sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build

[Github-comments] Re: [geany/geany-plugins] commander: Silence expected deprecation warnings (#952)

2023-10-17 Thread Colomban Wendling via Github-comments
Yeah let's get it in not to have other people waste time trying to "fix" it. This won't remove all deprecation warnings (the plugin still uses `gtk_vbox_new()`) though. I can very easily fix that now we depend on GTK3 anyway though, but that can be for later. -- Reply to this email directly

[Github-comments] Re: [geany/geany] indentation: curly braces difference js x php (review all languages that use them?) (Issue #3655)

2023-10-25 Thread Colomban Wendling via Github-comments
Works for me, be it with *current characters* or *matching brace* indentation methods. Note however that auto-indentation here will not happen if you have something on the right of the cursor when typing the closing brace. What is you version of Geany? Does disabling plugins help? (`geany

[Github-comments] Re: [geany/geany] indentation: curly braces difference js x php (review all languages that use them?) (Issue #3655)

2023-10-25 Thread Colomban Wendling via Github-comments
Closed #3655 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3655#event-10768517618 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Replace never released version 1.39 by 2.0 (13bc05d)

2023-10-19 Thread Colomban Wendling via Github-comments
@kloczek Sorry I don't get it, they both use the same scheme: `major.minor.micro` as the tag, and `major.minor[.micro if micro > 0]` or however I can describe that for the asset names. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Replace never released version 1.39 by 2.0 (13bc05d)

2023-10-19 Thread Colomban Wendling via Github-comments
@kloczek not sure I get it, it's always been like that -- check e.g. the previous release https://github.com/geany/geany/releases/tag/1.38.0: tag is 1.38.0 but tarballs use 1.38. I guess if there's a compelling reason to do otherwise we could, but up until now we used the full version in tags,

[Github-comments] Re: [geany/geany] Rewrite HL_N_ENTRIES macro to avoid a GCC8 false positive warning (#2398)

2023-10-25 Thread Colomban Wendling via Github-comments
Merged #2398 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2398#event-10771516299 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Clang warnings: sizeof ((((void *)0)))' will return the size of the pointer (#2906)

2023-10-25 Thread Colomban Wendling via Github-comments
Closed #2906 as completed via #2398. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2906#event-10771516561 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Replace utils_make_human_readable_str() with g_format_size() (PR #3657)

2023-10-25 Thread Colomban Wendling via Github-comments
This allows removing a needlessly complex and tricky function (I dare you understanding what it actually does the first time around) in which we even introduced subtle (but luckily invisible for now) bugs over time as it was probably not understood properly, and more sensitive to breakage than

[Github-comments] Re: [geany/geany] wrong functions showed in symbols (Issue #3661)

2023-10-30 Thread Colomban Wendling via Github-comments
Current universal-ctags still suffers from the issue. > Detecting command start might not be simple since they can be embedded. It is not trivial indeed. And the other solution of being stricter parsing `function …` is tricky as well because the syntax is actually fairly complex (e.g.

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-03 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > SSM(sci, SCI_SETILEXER, 0, (uintptr_t) lexer); - if (old != (gint)lexer_id) + if (old != sci_get_lexer(sci)) I'm not sure what is the recommendation on this: the [documentation](https://scintilla.org/ScintillaDoc.html#SCI_SETILEXER)

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 1009e021c39bb116e77f007ec4e59d7fb64fc8a6 Use Scintilla lexer names rather than deprecated IDs -- View it on GitHub: https://github.com/geany/geany/pull/3668/files/28fb2d044defbfe62bb29464f3e96700d2f7b663..1009e021c39bb116e77f007ec4e59d7fb64fc8a6 You are receiving this

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 974fb802a897333b003ebea568bdfb8a7194d2a2 fixup! Fix fairly nasty implicit integer conversion -- View it on GitHub: https://github.com/geany/geany/pull/3665/files/12b30c5950eeccad2fed885745ff6cd0888d1d3a..974fb802a897333b003ebea568bdfb8a7194d2a2 You are receiving this

[Github-comments] Re: [geany/geany] Installed 2.0, but 1.38 still loads (Discussion #3671)

2023-11-02 Thread Colomban Wendling via Github-comments
You install in `/usr/local`, while having an installation in `/usr` as well (I guess). I think it's a Ubuntu-specific problem, but anyway the issue is (very likely) that your `/usr/local/bin/geany` uses the library from `/usr/lib/libgeany.so` rather than `/usr/local/lib/geany`. You can verify

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > { - g_warning("Failed to find lexer for ID %u", lexer_id); + g_warning("Failed to find lexer for name %s", lexer_name); I don't know how expansive it'd be indeed, so whether or not it's reasonable to do it, but we could

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -696,23 +696,24 @@ gint sci_get_lexer(ScintillaObject *sci) } -void sci_set_lexer(ScintillaObject *sci, guint lexer_id) +void sci_set_lexer_name(ScintillaObject *sci, const gchar *lexer_name) Fair enough, as indeed I ended up removing the old one.

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -906,7 +906,12 @@ static gint sort_found_tags(gconstpointer a, > gconstpointer b, gpointer user_data * followed by workspace tags, * followed by global tags */ if (t1->type & tm_tag_local_var_t && t2->type &

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-02 Thread Colomban Wendling via Github-comments
…and you could check this patch using this: ```bash #!/bin/bash diff -u \ <( git show | grep -P '#define highlighting_lexer_' | awk '{print $3}' | \ while read -r lexer_id; do read -r lexer_name test "${lexer_name%_*}" = highlighting_lexer && continue echo "$lexer_id $lexer_name" done |

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-02 Thread Colomban Wendling via Github-comments
> Looks good _but_ I didn't check if the actual lexer names are correct - but > see the related comment in the review. Yeah that's the tricky/boring part. What I did was based on the results from `git grep -h 'LexerModule.*SCLEX_' | sed -r 's/^.*(SCLEX_\w*)\W[^"]*("[^"]*").*$/\1: \2/' | sort

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-11-02 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > - * { 0, 19, "geany-3.0.css" }, -*/ - }; - - guint gtk_version = gtk_get_minor_version(); - for (guint i = 0; i < G_N_ELEMENTS(css_files); i++) - { - if (gtk_version >=

[Github-comments] Re: [geany/geany] 2.0.0: meson fails on Linux with ` Dependency "gtk-mac-integration" not found` (Issue #3649)

2023-11-02 Thread Colomban Wendling via Github-comments
Closed #3649 as completed via fb202dc583a9deefa3c17046fd7d5ad23c21e180. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3649#event-10849911654 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Move "Virtual Spaces" preference to "Editor -> Features" (PR #3643)

2023-11-02 Thread Colomban Wendling via Github-comments
Merged #3643 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3643#event-10849945064 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Prefs: move "virtual spaces" to the "Features" tab (Issue #3605)

2023-11-02 Thread Colomban Wendling via Github-comments
Closed #3605 as completed via 4b54306424918c2e4a3f3d3a553463065420cf7c. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3605#event-10849945054 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] 2.0.0: meson fails on Linux with ` Dependency "gtk-mac-integration" not found` (Issue #3649)

2023-11-02 Thread Colomban Wendling via Github-comments
@techee thanks for the test! Committed, as well as 2 additional small improvements, that nobody else tested, so I have a chance to have introduced a big stupid error :smile: -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] meson error: meson.build:446:32: ERROR: The `==` operator of bool does not accept objects of type int (1) (Issue #3618)

2023-11-02 Thread Colomban Wendling via Github-comments
Closed #3618 as completed via 215271b02dbfa13e54bee77b6d3a8a76ec1fad68. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3618#event-10849888462 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-11-02 Thread Colomban Wendling via Github-comments
Merged #3642 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3642#event-10849888473 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-11-03 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > SSM(sci, SCI_SETILEXER, 0, (uintptr_t) lexer); - if (old != (gint)lexer_id) + if (old != sci_get_lexer(sci)) OK. I can easily use this here (seems to work), but porting every use in Geany is gonna be more tricky, especially for cases

[Github-comments] Re: [geany/geany] Cannot open uncompressed PDF file (Issue #3677)

2023-11-07 Thread Colomban Wendling via Github-comments
> Still the image data may not be convertible to UTF-8, its just a sequence of > bytes, not any encoding. UTF-8 no, but many encodings are actually "a sequence of bytes", which is the reason why choosing the right one when opening is so hard (basically, it's a guessing game if you don't know

[Github-comments] Re: [geany/geany] Cannot open uncompressed PDF file (Issue #3677)

2023-11-07 Thread Colomban Wendling via Github-comments
Sure, it won't be a convenient experience, and if the non-binary data is not single-byte encoded it's unlikely to be really usable as even stripping/replacing the NULs will not allow to convert to that multi-byte encoding if it has stricter rules than "any byte goes anywhere" (like UTF-8).

[Github-comments] Re: [geany/geany] Cannot open uncompressed PDF file (Issue #3677)

2023-11-07 Thread Colomban Wendling via Github-comments
Yes, any ISO-8859-* stream with no NULs is convertible to UTF-8 with no NULs. Or am I missing something? I don't think any of ISO-8859-* has things Unicode cannot represent :) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-10-31 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > if (main_status.main_window_realized) - dialogs_show_msgbox(GTK_MESSAGE_WARNING, warn_msg, display_filename); + dialogs_show_msgbox(GTK_MESSAGE_WARNING, "%s", warn_msg); + +

[Github-comments] Re: [geany/geany] Most recent directory is not remembered (Discussion #3664)

2023-10-31 Thread Colomban Wendling via Github-comments
> Although the OP has "no reasons for me to start Geany from the command line" > clearly others do, or the locking problem would not have been noticed and the > SF bug would not have been raised. I don't know how Windows does it, but the same problem would happen if the default working

[Github-comments] [geany/geany] Less warnings (PR #3665)

2023-10-29 Thread Colomban Wendling via Github-comments
With this, you should be able to build *src/* and *plugins/* warning-free with `CFLAGS=-Wall -Wextra -g -Og -Wno-unused-parameter -Wunreachable-code -Wformat=2 -Wundef -Wshadow -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2023-10-29 Thread Colomban Wendling via Github-comments
> An alternative would be to replace all checks for WIN32 in the code with > _WIN32, but there are lots of places.. And they are in ctags code, so this would have to be fixed upstream. Not tested, but looks OK. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Replace utils_make_human_readable_str() with g_format_size() (PR #3657)

2023-10-29 Thread Colomban Wendling via Github-comments
Merged #3657 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3657#event-10800492414 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] 2.0.0: meson fails on Linux with ` Dependency "gtk-mac-integration" not found` (Issue #3649)

2023-10-30 Thread Colomban Wendling via Github-comments
> Even with `--auto-features=enabled` MAC related things should be only checked > on MAC. Sounds reasonable to me; and `--auto-features=enabled` seems useful to make sure a (potentially new) dependency is not missed. Would something like this work? ```diff diff --git a/meson.build

[Github-comments] Re: [geany/geany] Less warnings (PR #3665)

2023-10-30 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > if (main_status.main_window_realized) - dialogs_show_msgbox(GTK_MESSAGE_WARNING, warn_msg, display_filename); + dialogs_show_msgbox(GTK_MESSAGE_WARNING, "%s", warn_msg); + +

[Github-comments] [geany/geany] Use Scintilla lexer names rather than deprecated IDs (PR #3668)

2023-10-31 Thread Colomban Wendling via Github-comments
Title says it all: instead of fetching the name from the deprecated ID, directly use the lexer name. This removes a deprecation warning, and probably aligns us for the future. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3668 -- Commit

[Github-comments] Re: [geany/geany] Question: When is the next release coming? (Discussion #3404)

2023-10-24 Thread Colomban Wendling via Github-comments
So, definite answer is "last Thursday" :wink: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3404#discussioncomment-7374811 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Question: When is the next release coming? (Discussion #3404)

2023-10-24 Thread Colomban Wendling via Github-comments
Closed #3404 as resolved. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3404 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-24 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. Just squash when ready -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3637#pullrequestreview-1695676632 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Is it possible to increase the menu font size in the Windows version of Geany 2.0 WITHOUT recompiling the program? (Issue #3652)

2023-10-24 Thread Colomban Wendling via Github-comments
@b4n converted this issue into discussion #3653. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3652#event-10759585164 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Is it possible to increase the menu font size in the Windows version of Geany 2.0 WITHOUT recompiling the program? (Issue #3652)

2023-10-24 Thread Colomban Wendling via Github-comments
Yes, you can adjust this with custom [GTK CSS](https://docs.gtk.org/gtk3/css-overview.html). Go to [*Tools → Configuration Files → geany.css*](https://geany.org/manual/#customizing-geany-s-appearance-using-gtk-css), and insert something like `menu { font-size: 15pt; }` or `* { -gtk-dpi: 120;

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-24 Thread Colomban Wendling via Github-comments
BTW, if setting this to `-1`, it'll use the minimum size so things fit, which is a bit wider than current master with the entry (I think I was right earlier). It'll however happily hide tabs as we allow this. Anyway, 220 or 230 look indeed better to me, and work as well if I use Adwaita on my

[Github-comments] Re: [geany/geany] New feature requests? (Issue #3659)

2023-10-26 Thread Colomban Wendling via Github-comments
> select and write out a particular chunk of code outside to be used elsewhere. You could use the [context action](https://geany.org/manual/#context-actions) with a custom script, but note that this can be set per-filetype as well, in which case it's less convenient for this. You could use a

[Github-comments] Re: [geany/geany] Pasting via middle-click clears X selection (Issue #3658)

2023-10-26 Thread Colomban Wendling via Github-comments
I don't see the same behavior, although kinda similar: I cannot paste multiple times from the editor to itself. On the first paste it clears the initial selection, and that clears the PRIMARY X selection. I believe that used to work, which was a lot more convenient I think. However, with

[Github-comments] Re: [geany/geany] Replace utils_make_human_readable_str() with g_format_size() (PR #3657)

2023-10-26 Thread Colomban Wendling via Github-comments
> Edit: are you _sure_ you want to use a functions that was only introduced in > Glib 2.30 12 years ago, 2011, thats the same year as C11, surely thats way > too new ;-P Hehe :) Hold tight though, I'm kind of planning to see what our minimal GTK dependency brings as of minimal GLib dependency

[Github-comments] Re: [geany/geany] Cannot open uncompressed PDF file (Issue #3677)

2023-11-06 Thread Colomban Wendling via Github-comments
> Any viable workaround ? Viable I don't know, but I heard some people working around NUL bytes by replacing those with a placeholder and back after edition. Something like `sed -i 's/\0/%%NUL%%/g' file && geany file && sed -i 's/%%NUL%%/\x00/g/'` or along the idea. Something like that should

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 37647e32ca6861f7d06000d8acf8f8f8e079a405 Distribute new documentation image -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/d2186cccddf8a885eae0ccb7c894564f1ac669a0..37647e32ca6861f7d06000d8acf8f8f8e079a405 You are receiving this because you are

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/edit_change_history.png: @eht16 I took the liberty to push to this PR with the fix above. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1364648967 You are receiving this because

[Github-comments] [geany/geany-plugins] lineoperations: Fix translation of some strings (PR #1286)

2023-10-18 Thread Colomban Wendling via Github-comments
@smostertdev @frlan This makes translations actually work in several places (prefs dialog, keybindings list, Nth line dialog) You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1286 -- Commit Summary -- * lineoperations: Fix

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-18 Thread Colomban Wendling via Github-comments
Agreed, it grew way too out of hand to be merged less than 24 hours before the deadline. And I agree with @elextr that it likely requires more testing than just hoping every other distro is shipping a well-behaving theme (better behaving than Debian's Adwaita 43) by default, although @techee

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
I'm gonna postpone that as discussed in #3614, although it might come back to bite us. Or we mention it somewhere in the announcement email? @eht16 :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3613#issuecomment-1769501953 You are

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-18 Thread Colomban Wendling via Github-comments
Postponing as it's a bit late now. Should probably be merged soon after release though. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3396#issuecomment-1769503371 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. New image is missing from the build system. Otherwise I didn't check all PR and issue references, but looks good! :+1: On doc/images/edit_change_history.png: This is not installed! ```diff diff --git a/doc/Makefile.am b/doc/Makefile.am index

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#pullrequestreview-1686329485 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] Small update of the French translation (PR #1287)

2023-10-18 Thread Colomban Wendling via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1287 -- Commit Summary -- * Small update of the French translation -- File Changes -- M po/fr.po (232) -- Patch Links --

[Github-comments] Re: [geany/geany-plugins] lineoperations: Fix translation of some strings (PR #1286)

2023-10-18 Thread Colomban Wendling via Github-comments
@frlan Ideally this could make it to 2.0 as it would extend translation and is fairly trivial, but if it doesn't because it's way too late for this nothing new breaks. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1286#issuecomment-1769587343

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: @eht16 do you want me to take care of the screenshots, or can you do it with what I mentioned? -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > +* Improved support of ctags file format, this is also the + recommended format for generating tags files (PR#3049). ```suggestion * Improved support for the ctags file format, which is now the recommended format for tags files

[Github-comments] Re: [geany/geany] macOS: use ".so" extension for plugins instead of ".dylib" (PR #3608)

2023-10-17 Thread Colomban Wendling via Github-comments
Same as @eht16, it looks good if I believe the docs that a value of `[]` make it use the default behavior. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3608#issuecomment-1767017197 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/pref_dialog_templ.png: Haha I didn't remember I was there :D -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#pullrequestreview-1683202948 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/replace_dialog.png: That one still needs updating, sorry -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#pullrequestreview-1683207407 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-17 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: > The Gnome default screenshot tool adds a think transparent border around the > images. I could remove it but actually I think it's nice because it gives the > images some margin when embedded in the HTML

[Github-comments] Re: [geany/geany] Restoring the session does not restore the current file or files order (Issue #3609)

2023-10-17 Thread Colomban Wendling via Github-comments
Yeah, it happens if `next to current` is checked. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3609#issuecomment-1766878125 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Fix logic comparing version numbers (PR #1284)

2023-10-17 Thread Colomban Wendling via Github-comments
> Here you'll be saved by the copy-paste error of the current code where the > last digit is ignored ;-). Ah indeed, missed that typo :) > The current code won't behave as bad as I thought originally because for > releases the value on the server is the highest number. It would be just in >

[Github-comments] [geany/geany] Restoring the session does not restore the current file or files order (Issue #3609)

2023-10-17 Thread Colomban Wendling via Github-comments
Restoring the session (from my upgraded ~/.config, which has seen all versions since the dawn of time^W^W^W^W I started using Geany) restores the files, but not: * the order * the current file It kinda looks like the first element is right, but the reset is sort of loaded in reverse… Might

[Github-comments] Re: [geany/geany-plugins] updatechecker: Fix logic comparing version numbers (PR #1284)

2023-10-17 Thread Colomban Wendling via Github-comments
Ah right, it was notifying when *either* `major` or `minor` was higher. So yeah, only false positives if the local version is newer than the release. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1284#issuecomment-1766870584 You are receiving

[Github-comments] [geany/geany] Do not enable Scintilla's Change History by default (PR #3591)

2023-10-10 Thread Colomban Wendling via Github-comments
* It looks either a bit confusing or to have some bugs (without having investigated deeply, it did things I didnt understand); * It marks all lines when reloading a file (instead of resetting to a blank slate); * If marker margin is not visible, it can render the editor unreadable with the

[Github-comments] Re: [geany/geany] Improve tag-goto popup (PR #3547)

2023-10-10 Thread Colomban Wendling via Github-comments
@techee I don't think it matters much here (but maybe the "all all"? :grin:), but it could also be one single commit (basically your first one already combines various things together) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Improve Go to Tag menu (PR #3542)

2023-10-10 Thread Colomban Wendling via Github-comments
Closed #3542. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3542#event-10603526637 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Improve Go to Tag menu (PR #3542)

2023-10-10 Thread Colomban Wendling via Github-comments
Closing now #3547 has been merged. Feel free to open further adjustments again :wink: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3542#issuecomment-1755254335 You are receiving this because you are subscribed to this thread. Message ID:

  1   2   3   4   5   6   7   >