github-actions[bot] commented on pull request #7415:
URL: https://github.com/apache/arrow/pull/7415#issuecomment-643169120
https://issues.apache.org/jira/browse/ARROW-7028
This is an automated message from the Apache Git
ursabot commented on pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#issuecomment-643115702
[AMD64 Ubuntu 18.04 C++ Benchmark
(#111432)](https://ci.ursalabs.org/#builders/73/builds/73) builder has been
succeeded.
Revision: 23aee3e5f6fc4c3fac7a859df7c52f79033c1c3c
svenwb commented on pull request #7379:
URL: https://github.com/apache/arrow/pull/7379#issuecomment-643149155
Hey @nevi-me as @vertexclique approved as well, can you merge this? Or how
shall we proceed? Thanks, Sven
This is
jeroen commented on pull request #7412:
URL: https://github.com/apache/arrow/pull/7412#issuecomment-643113980
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sonthonaxrk commented on pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#issuecomment-643178439
@wjones1 could I have write access to your branch so I can finish the
changes without this going stale again?
liyafan82 commented on a change in pull request #7290:
URL: https://github.com/apache/arrow/pull/7290#discussion_r439336805
##
File path: java/vector/src/main/codegen/templates/UnionVector.java
##
@@ -493,6 +576,19 @@ public void splitAndTransfer(int startIndex, int length) {
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r439266993
##
File path: java/dataset/src/main/java/org/apache/arrow/memory/Ownerships.java
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r439266993
##
File path: java/dataset/src/main/java/org/apache/arrow/memory/Ownerships.java
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software
liyafan82 commented on a change in pull request #7290:
URL: https://github.com/apache/arrow/pull/7290#discussion_r439325184
##
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##
@@ -104,6 +105,7 @@
* The index is the type id, and the value is the
liyafan82 commented on a change in pull request #7290:
URL: https://github.com/apache/arrow/pull/7290#discussion_r439334686
##
File path: java/vector/src/main/codegen/templates/UnionVector.java
##
@@ -325,12 +361,45 @@ private void allocateTypeBuffer() {
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r439266993
##
File path: java/dataset/src/main/java/org/apache/arrow/memory/Ownerships.java
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software
liyafan82 commented on a change in pull request #7290:
URL: https://github.com/apache/arrow/pull/7290#discussion_r439338218
##
File path: java/vector/src/main/codegen/templates/UnionVector.java
##
@@ -586,7 +686,9 @@ public ValueVector getVectorByType(int typeId) {
}
liyafan82 commented on a change in pull request #7290:
URL: https://github.com/apache/arrow/pull/7290#discussion_r439336805
##
File path: java/vector/src/main/codegen/templates/UnionVector.java
##
@@ -493,6 +576,19 @@ public void splitAndTransfer(int startIndex, int length) {
jianxind commented on pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#issuecomment-643106609
@ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark
This is an automated message from the Apache
romainfrancois opened a new pull request #7415:
URL: https://github.com/apache/arrow/pull/7415
Although it's to some extent tolerated that Date vectors are backed by
`integer` vectors, it's much more common that they are backed by numeric:
``` r
.Internal(inspect(Sys.Date()))
cool-RR opened a new pull request #7416:
URL: https://github.com/apache/arrow/pull/7416
I recently went over
[Matplotlib](https://github.com/matplotlib/matplotlib/pull/16706),
[Pandas](https://github.com/pandas-dev/pandas/pull/32322) and
github-actions[bot] commented on pull request #7416:
URL: https://github.com/apache/arrow/pull/7416#issuecomment-643200828
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
rok commented on a change in pull request #7044:
URL: https://github.com/apache/arrow/pull/7044#discussion_r439226180
##
File path: cpp/src/arrow/ipc/metadata_internal.cc
##
@@ -882,7 +882,7 @@ Status MakeSparseTensorIndexCOO(FBB& fbb, const
SparseCOOIndex& sparse_index,
eyalleshem commented on a change in pull request #7384:
URL: https://github.com/apache/arrow/pull/7384#discussion_r439304801
##
File path: rust/arrow/src/ipc/reader.rs
##
@@ -793,7 +793,21 @@ impl StreamReader {
}
// determine metadata length
let mut
liyafan82 commented on a change in pull request #7290:
URL: https://github.com/apache/arrow/pull/7290#discussion_r439335068
##
File path: java/vector/src/main/codegen/templates/UnionVector.java
##
@@ -325,12 +361,45 @@ private void allocateTypeBuffer() {
liyafan82 commented on a change in pull request #7275:
URL: https://github.com/apache/arrow/pull/7275#discussion_r439373604
##
File path: java/vector/src/main/codegen/templates/UnionLargeListWriter.java
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation
liyafan82 commented on a change in pull request #7275:
URL: https://github.com/apache/arrow/pull/7275#discussion_r439373751
##
File path: java/vector/src/main/codegen/templates/UnionLargeListWriter.java
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation
pitrou commented on a change in pull request #7418:
URL: https://github.com/apache/arrow/pull/7418#discussion_r439415981
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -37,26 +37,108 @@ struct AsciiLength {
}
};
-struct AsciiUpper {
- // XXX: the
pitrou commented on pull request #7418:
URL: https://github.com/apache/arrow/pull/7418#issuecomment-643268699
I get similar numbers here. It seems to be a 15x speedup over git master.
This is an automated message from the
wesm commented on pull request #7417:
URL: https://github.com/apache/arrow/pull/7417#issuecomment-643281405
There don't seem to be issues on MSVC
https://gist.github.com/wesm/45be57393b2d9186f87faae228f12380/revisions
wesm commented on pull request #7416:
URL: https://github.com/apache/arrow/pull/7416#issuecomment-643236620
To be honest I wasn't even aware of this feature, since for the longest time
I've been developing 2.7/3.x hybrid codebases where syntactic features like
this are off limits. In
nevi-me closed pull request #7379:
URL: https://github.com/apache/arrow/pull/7379
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wesm closed pull request #7357:
URL: https://github.com/apache/arrow/pull/7357
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on pull request #7418:
URL: https://github.com/apache/arrow/pull/7418#issuecomment-643265306
https://issues.apache.org/jira/browse/ARROW-9115
This is an automated message from the Apache Git
bkietz commented on a change in pull request #7410:
URL: https://github.com/apache/arrow/pull/7410#discussion_r439445910
##
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##
@@ -181,8 +180,7 @@ struct GetOutputType> {
};
template
-struct GetOutputType<
-
fsaintjacques commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r439413765
##
File path: cpp/src/arrow/dataset/discovery.h
##
@@ -216,6 +216,16 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public
DatasetFactory {
nealrichardson closed pull request #7412:
URL: https://github.com/apache/arrow/pull/7412
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kszucs opened a new pull request #7417:
URL: https://github.com/apache/arrow/pull/7417
Quickly wanted to add a benchmark for the `Add` function to verify that no
significant regressions were introduced by
https://github.com/apache/arrow/pull/7341
Before:
```
wesm commented on pull request #7417:
URL: https://github.com/apache/arrow/pull/7417#issuecomment-643266987
Thanks for working on this. I'll check the benchmarks on MSVC also
This is an automated message from the Apache Git
wesm commented on a change in pull request #7417:
URL: https://github.com/apache/arrow/pull/7417#discussion_r439431785
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
bkietz commented on a change in pull request #7410:
URL: https://github.com/apache/arrow/pull/7410#discussion_r439442386
##
File path: cpp/src/arrow/compute/kernels/test_util.h
##
@@ -33,7 +33,9 @@
#include "arrow/testing/random.h"
#include "arrow/testing/util.h"
#include
bkietz commented on a change in pull request #7410:
URL: https://github.com/apache/arrow/pull/7410#discussion_r439442116
##
File path: cpp/src/arrow/util/iterator_test.cc
##
@@ -27,6 +27,9 @@
#include
#include
+#include
+#include
+
Review comment:
```suggestion
github-actions[bot] commented on pull request #7420:
URL: https://github.com/apache/arrow/pull/7420#issuecomment-643329115
https://issues.apache.org/jira/browse/ARROW-9022
This is an automated message from the Apache Git
wesm opened a new pull request #7418:
URL: https://github.com/apache/arrow/pull/7418
Following on discussion in #7357. I added a simple benchmark also.
```
--
Benchmark Time CPU Iterations
wesm closed pull request #7418:
URL: https://github.com/apache/arrow/pull/7418
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on pull request #7419:
URL: https://github.com/apache/arrow/pull/7419#issuecomment-643311125
https://issues.apache.org/jira/browse/ARROW-8510
This is an automated message from the Apache Git
fsaintjacques commented on pull request #7419:
URL: https://github.com/apache/arrow/pull/7419#issuecomment-643311800
I also agree with the sentiment on variant, I noted this
[here](https://github.com/apache/arrow/pull/7156#discussion_r435921179) (which
touches the same code path).
pitrou commented on a change in pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#discussion_r439478696
##
File path: cpp/src/arrow/type_fwd.h
##
@@ -351,39 +358,21 @@ std::shared_ptr ARROW_EXPORT
time64(TimeUnit::type unit);
std::shared_ptr ARROW_EXPORT
wesm commented on pull request #7418:
URL: https://github.com/apache/arrow/pull/7418#issuecomment-643263350
cc @maartenbreddels @pitrou
This is an automated message from the Apache Git Service.
To respond to the message,
nevi-me closed pull request #7384:
URL: https://github.com/apache/arrow/pull/7384
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on a change in pull request #7418:
URL: https://github.com/apache/arrow/pull/7418#discussion_r439416979
##
File path: cpp/src/arrow/compute/kernels/scalar_string_benchmark.cc
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
kszucs commented on pull request #6512:
URL: https://github.com/apache/arrow/pull/6512#issuecomment-643280068
@kou I'm afraid that CMAKE_BUILD_PARALLEL_LEVEL doesn't propagate well with
ninja, so it causes OOM during compilation in the arm64v8 build.
bkietz commented on a change in pull request #7410:
URL: https://github.com/apache/arrow/pull/7410#discussion_r439440106
##
File path: cpp/src/arrow/compute/exec.cc
##
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
Review comment:
```suggestion
```
wesm commented on a change in pull request #7418:
URL: https://github.com/apache/arrow/pull/7418#discussion_r439451091
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -37,26 +39,108 @@ struct AsciiLength {
}
};
-struct AsciiUpper {
- // XXX: the
kszucs commented on a change in pull request #6512:
URL: https://github.com/apache/arrow/pull/6512#discussion_r43940
##
File path: .github/workflows/cpp_cron.yml
##
@@ -95,12 +95,13 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v1
with:
wesm commented on a change in pull request #7418:
URL: https://github.com/apache/arrow/pull/7418#discussion_r439418114
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -37,26 +37,108 @@ struct AsciiLength {
}
};
-struct AsciiUpper {
- // XXX: the
cyb70289 commented on a change in pull request #7418:
URL: https://github.com/apache/arrow/pull/7418#discussion_r439448175
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -37,26 +39,108 @@ struct AsciiLength {
}
};
-struct AsciiUpper {
- // XXX: the
emkornfield commented on pull request #7290:
URL: https://github.com/apache/arrow/pull/7290#issuecomment-643320990
@jacques-n I think you had some concerns the last time sparse unions were
made. Do these changes raise the same issues?
pitrou commented on a change in pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#discussion_r439480534
##
File path: cpp/src/arrow/array/array_primitive.h
##
@@ -108,11 +108,11 @@ class ARROW_EXPORT DayTimeIntervalArray : public
PrimitiveArray {
// For
pitrou commented on a change in pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#discussion_r439480534
##
File path: cpp/src/arrow/array/array_primitive.h
##
@@ -108,11 +108,11 @@ class ARROW_EXPORT DayTimeIntervalArray : public
PrimitiveArray {
// For
liyafan82 commented on a change in pull request #7275:
URL: https://github.com/apache/arrow/pull/7275#discussion_r439375810
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/BitVectorHelper.java
##
@@ -73,6 +87,28 @@ public static void setBit(ArrowBuf
bkietz commented on a change in pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#discussion_r439478099
##
File path: cpp/src/arrow/type_fwd.h
##
@@ -351,39 +358,21 @@ std::shared_ptr ARROW_EXPORT
time64(TimeUnit::type unit);
std::shared_ptr ARROW_EXPORT
bkietz commented on a change in pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#discussion_r439477647
##
File path: cpp/src/arrow/type.h
##
@@ -1015,25 +1018,12 @@ class ARROW_EXPORT Decimal128Type : public DecimalType {
/// \brief Concrete type class for
kszucs commented on a change in pull request #7417:
URL: https://github.com/apache/arrow/pull/7417#discussion_r439478018
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under
github-actions[bot] commented on pull request #7416:
URL: https://github.com/apache/arrow/pull/7416#issuecomment-643206492
https://issues.apache.org/jira/browse/ARROW-9113
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7417:
URL: https://github.com/apache/arrow/pull/7417#issuecomment-643228149
https://issues.apache.org/jira/browse/ARROW-9079
This is an automated message from the Apache Git
kszucs commented on a change in pull request #7417:
URL: https://github.com/apache/arrow/pull/7417#discussion_r439371127
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under
kszucs commented on a change in pull request #7417:
URL: https://github.com/apache/arrow/pull/7417#discussion_r439371127
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under
liyafan82 commented on a change in pull request #7275:
URL: https://github.com/apache/arrow/pull/7275#discussion_r439376364
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compare/RangeEqualsVisitor.java
##
@@ -494,4 +505,46 @@ protected boolean
liyafan82 commented on a change in pull request #7275:
URL: https://github.com/apache/arrow/pull/7275#discussion_r439398445
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/complex/LargeListVector.java
##
@@ -0,0 +1,991 @@
+/*
+ * Licensed to the Apache
pitrou commented on pull request #7418:
URL: https://github.com/apache/arrow/pull/7418#issuecomment-643273901
Before:
```
AsciiLower 76218768 ns 76206752 ns 28
bytes_per_second=207.921M/s items_per_second=13.7596M/s
AsciiUpper 83254436 ns 83232143 ns
romainfrancois commented on pull request #7415:
URL: https://github.com/apache/arrow/pull/7415#issuecomment-643274152
Thanks, I had not checked `funs::if_else()`.
Yeah, a Date32 arrow gets converted to a `Date` no matter what, that
means data copy as arrow backs it with a int vector
kszucs commented on a change in pull request #7417:
URL: https://github.com/apache/arrow/pull/7417#discussion_r439371127
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under
wesm opened a new pull request #7419:
URL: https://github.com/apache/arrow/pull/7419
Even without the compiler error on VS 2017 I am not a fan of using variant
to solve problems like these (so to me this new code is strictly preferable to
the old code), nor exposing a variant in public
kszucs opened a new pull request #7420:
URL: https://github.com/apache/arrow/pull/7420
Quick draft for checked arithmetics.
TODOs:
- more portable overflow checks
- consolidate the tests
- add arithmetics options to let the user choose which variant to run (so
remove the
wesm closed pull request #7419:
URL: https://github.com/apache/arrow/pull/7419
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm closed pull request #7407:
URL: https://github.com/apache/arrow/pull/7407
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bkietz commented on pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#issuecomment-643386870
@wesm thanks, I've been trying to get those to pass locally.
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7421:
URL: https://github.com/apache/arrow/pull/7421#issuecomment-643424778
https://issues.apache.org/jira/browse/ARROW-9030
This is an automated message from the Apache Git
nealrichardson commented on pull request #7415:
URL: https://github.com/apache/arrow/pull/7415#issuecomment-643332789
Thanks y'all for looking into this. Given where we are right now, this PR is
probably an improvement on the status quo. If we had benchmarks that the
conversion to Date
wesm commented on pull request #7414:
URL: https://github.com/apache/arrow/pull/7414#issuecomment-643370021
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wesm closed pull request #7414:
URL: https://github.com/apache/arrow/pull/7414
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#issuecomment-643413102
thanks @bkietz!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wesm closed pull request #7378:
URL: https://github.com/apache/arrow/pull/7378
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on pull request #6806:
URL: https://github.com/apache/arrow/pull/6806#issuecomment-643416750
Cool. @zhouyuan could you rebase? Thank you
This is an automated message from the Apache Git Service.
To respond to
wesm closed pull request #7337:
URL: https://github.com/apache/arrow/pull/7337
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on pull request #7337:
URL: https://github.com/apache/arrow/pull/7337#issuecomment-643417028
I'll open a new PR for these changes
This is an automated message from the Apache Git Service.
To respond to the
bkietz commented on a change in pull request #7417:
URL: https://github.com/apache/arrow/pull/7417#discussion_r439583288
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under
cool-RR commented on pull request #7416:
URL: https://github.com/apache/arrow/pull/7416#issuecomment-643355049
I understand.
I personally hate `from None`, and I think that when people are debugging
they have a very different mindset than when they are writing code. When you're
cool-RR closed pull request #7416:
URL: https://github.com/apache/arrow/pull/7416
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wesm commented on a change in pull request #7420:
URL: https://github.com/apache/arrow/pull/7420#discussion_r439523904
##
File path: cpp/src/arrow/compute/api_scalar.h
##
@@ -45,6 +45,12 @@ namespace compute {
ARROW_EXPORT
Result Add(const Datum& left, const Datum& right,
wesm closed pull request #7408:
URL: https://github.com/apache/arrow/pull/7408
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on a change in pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#discussion_r439539160
##
File path: cpp/src/arrow/array/array_primitive.h
##
@@ -108,11 +108,11 @@ class ARROW_EXPORT DayTimeIntervalArray : public
PrimitiveArray {
// For
wesm commented on a change in pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#discussion_r439539505
##
File path: cpp/src/arrow/type_fwd.h
##
@@ -351,39 +358,21 @@ std::shared_ptr ARROW_EXPORT
time64(TimeUnit::type unit);
std::shared_ptr ARROW_EXPORT
wesm closed pull request #7394:
URL: https://github.com/apache/arrow/pull/7394
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on pull request #7394:
URL: https://github.com/apache/arrow/pull/7394#issuecomment-643376415
superseded by #7402
This is an automated message from the Apache Git Service.
To respond to the message, please log
wesm commented on pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#issuecomment-643390508
Sorry about the noise I think I've got it now. We might need to create an
"arrow-deprecated-test" at some point where we verify that deprecated APIs
still work as advertised
houqp commented on a change in pull request #7324:
URL: https://github.com/apache/arrow/pull/7324#discussion_r439567609
##
File path: rust/datafusion/src/execution/physical_plan/sort.rs
##
@@ -0,0 +1,211 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
wesm commented on pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#issuecomment-643412670
Appveyor was passing two commits ago:
https://ci.appveyor.com/project/BenjaminKietzman/arrow/builds/33489614. The
Ursabot CI failure looks transient. I'll go ahead and merge this so
bkietz commented on a change in pull request #7417:
URL: https://github.com/apache/arrow/pull/7417#discussion_r439577349
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc
##
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under
nealrichardson closed pull request #7411:
URL: https://github.com/apache/arrow/pull/7411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
bkietz commented on a change in pull request #7156:
URL: https://github.com/apache/arrow/pull/7156#discussion_r439514082
##
File path: cpp/src/arrow/util/checked_cast.h
##
@@ -39,11 +40,11 @@ inline OutputType checked_cast(InputType&& value) {
}
template
-std::shared_ptr
wesm closed pull request #7409:
URL: https://github.com/apache/arrow/pull/7409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou commented on pull request #7416:
URL: https://github.com/apache/arrow/pull/7416#issuecomment-643378995
To be honest, I think those are all fine. There isn't much to be gained by
forcing ourselves to spell out `raise from ...` explicitly, and we'll
inevitably overlook some possible
wesm opened a new pull request #7421:
URL: https://github.com/apache/arrow/pull/7421
This is some routine scrubbing that deals with some remnants of the prior
dual py2/3 codebase.
This is an automated message from the
1 - 100 of 139 matches
Mail list logo
