Re: [go-nuts] Go beginner asks for code review

2016-09-23 Thread Leandro Motta Barros
Just leaving my final tank you for everyone! You all really helped! Cheers, LMB On Thu, Sep 22, 2016 at 10:58 PM, Diego Medina wrote: > Hi, > > First, awesome that you started using Go! some thoughts inline: > > > >> 1. The sbxs_ prefix is there just because I expect this

Re: [go-nuts] Go beginner asks for code review

2016-09-22 Thread Diego Medina
Hi, First, awesome that you started using Go! some thoughts inline: > 1. The sbxs_ prefix is there just because I expect this package to be part > of a set of related repositories and I wanted to give them some "unity" > through naming. Arguably a bad idea, I am not sure about it. > I have

Re: [go-nuts] Go beginner asks for code review

2016-09-22 Thread 'Chris Manghane' via golang-nuts
On Thu, Sep 22, 2016 at 3:31 PM, Leandro Motta Barros wrote: > Hi Sam, > > Looks like your response got truncated. :-/ > > Anyway, there is a good deal of nice tips, there. I am updating my code to > take your feedback into account. Thanks a lot! > > There is one point I

Re: [go-nuts] Go beginner asks for code review

2016-09-22 Thread Leandro Motta Barros
Hi Sam, Looks like your response got truncated. :-/ Anyway, there is a good deal of nice tips, there. I am updating my code to take your feedback into account. Thanks a lot! There is one point I still wondering about, however: On Thu, Sep 22, 2016 at 1:57 PM, Sam Whited

Re: [go-nuts] Go beginner asks for code review

2016-09-22 Thread Sam Whited
On Thu, Sep 22, 2016 at 10:48 AM, Leandro Motta Barros wrote: > I wonder if anyone would be willing to take a look at it, and give some > advice on how to be more idiomatic or improve it somehow. Not sure how to do this on GitHub if it's not a PR, I don't appear to be able

Re: [go-nuts] Go beginner asks for code review

2016-09-22 Thread Sam Whited
On Thu, Sep 22, 2016 at 10:48 AM, Leandro Motta Barros wrote: > I hope this is not considered off-topic: I have started learning Go a few > weeks ago, and have recently finished writing my first sizable piece of Go > code. Not at all; welcome to the Go community, and

[go-nuts] Go beginner asks for code review

2016-09-22 Thread Leandro Motta Barros
Hello, I hope this is not considered off-topic: I have started learning Go a few weeks ago, and have recently finished writing my first sizable piece of Go code. I wonder if anyone would be willing to take a look at it, and give some advice on how to be more idiomatic or improve it somehow. Any