://groups.google.com/group/google-web-toolkit?hl=en.
--
Rodrigo Chandia | Software Engineer | rchan...@google.com | 678 7431725
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit
I think this patch (under review) fixes this issue:
http://gwt-code-reviews.appspot.com/1794803
On Tuesday, July 24, 2012 3:27:29 PM UTC-4, Rodrigo Chandia wrote:
Hmm, this seems like a bug to me. Hopefully I'll have a fix ready for rc2.
On Mon, Jul 23, 2012 at 11:11 PM, Vasu wrote:
Yea
from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
--
Rodrigo Chandia | Software Engineer | rchan...@google.com | 678 7431725
--
You received this message because you
...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
--
Rodrigo Chandia | Software Engineer | rchan...@google.com | 678 7431725
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post
this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
--
Rodrigo Chandia | Software Engineer | rchan...@google.com | 678 7431725
--
You received this message because you
We have a few POMs through GWT which need its versions updated for the
release. The question is what to use for version string. We have no process
or infrastructure in place for snapshots so I'd like to keep that out of
this picture.
I propose to use 2.5.0.RCx while we publish release
Review at http://gwt-code-reviews.appspot.com/1734804
On Wednesday, June 13, 2012 2:32:28 PM UTC-4, Thomas Broyer wrote:
On Wednesday, June 13, 2012 8:19:52 PM UTC+2, Rodrigo Chandia wrote:
We have a few POMs through GWT which need its versions updated for the
release. The question is what
UiBinder does not handle Cell widget events. You probably want to use the
upcoming Uibinder for Cells functionality (a.k.a. UiRenderer). It will be
part of 2.5, but it is available in trunk, for the time being.
No documentation yet, but there is a design document here:
template.
--
Rodrigo Chandia | Software Engineer | rchan...@google.com | 678 7431725
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
and ant
clean dist-dev for me. I'm using a JDK 1.6 compiler.
I will still change it, but should I make any changes to my local
environment to catch stuff like this going forward?
http://gwt-code-reviews.**appspot.com/1565806/http://gwt-code-reviews.appspot.com/1565806/
--
Rodrigo Chandia
.**appspot.com/1565806/http://gwt-code-reviews.appspot.com/1565806/
--
Rodrigo Chandia | Software Engineer | rchan...@google.com | 678 7431725
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
.
http://gwt-code-reviews.**appspot.com/1537805/http://gwt-code-reviews.appspot.com/1537805/
--
Rodrigo Chandia | Software Engineer | rchan...@google.com | 678 7431725
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ah, I am wrong. It is a dependency of gwt-user.
El 9 de septiembre de 2011 15:31, Rodrigo Chandia rchan...@google.comescribió:
You need to specify it explicitly.
El 9 de septiembre de 2011 15:26, Ray Ryan rj...@google.com escribió:
Thanks.
Do I need the validation-api dependency (in any
Thx!
On Sep 9, 2011 5:08 PM, drfibona...@google.com wrote:
LGTM!
Nice refactoring error handling.
http://gwt-code-reviews.appspot.com/1520810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
/1525806/
--
Rodrigo Chandia | Software Engineer | rchan...@google.com | 678 7431725
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
--
Rodrigo Chandia | Software Engineer | rchan...@google.com | 678
Ready!
On Jun 14, 2011 8:07 PM, Ray Ryan rj...@google.com wrote:
Ready for review?
On Mon, Jun 13, 2011 at 8:17 AM, rchan...@google.com{subItem.from.uri}
wrote:
http://gwt-code-reviews.appspot.com/1453812/
http://www.google.com/url?sa=Dq=http://gwt-code-reviews.appspot.com/1453812/
--
Fixes ant build breakage.
The source target used for samples/mobilewebapp and samples/expenses looks
for content in war/. For Expenses, expenses/war/.place-holder fulfills that
requirement. I added the same thing to mobilewebapp to fix the ant build.
A better fix is to test for the existence of
On Fri, May 6, 2011 at 12:09 PM, Ray Ryan rj...@google.com wrote:
But the distributed app does get the necessary jars in war/WEB-INF/lib
and produce a proper war.
Cool. How?
'samples/build.xml' calls 'samples/mobilewebapp/ant.xml' with target
'source+libs'. That target copies all necessary
Thanks!
On Mon, May 2, 2011 at 6:19 PM, rj...@google.com wrote:
Hey there Rodrigo. Unnur is on point for this review, but you might find
it interesting.
http://gwt-code-reviews.appspot.com/1421811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Yes, I thought it was less confusing to start from what was present in
http://gwt-code-reviews.appspot.com/1426803 and then make changes. Makes it
easier to see differences and such.
On Mon, May 2, 2011 at 7:03 PM, Ray Ryan rj...@google.com wrote:
This still appears to have all the problems of
Thanks for reporting the issue! Filed at:
http://code.google.com/p/google-web-toolkit/issues/detail?id=6300
On Fri, Apr 29, 2011 at 3:15 PM, misra.a...@gmail.com wrote:
There is a small issue with cancel button, when you add task. It doesn't
work.
On 2011/04/27 17:38:57, jlabanca wrote:
'lib/junit-4.8.2' is a relative path and it is missing the .jar file
extension. Whether webAppCreator can find it depends on your current
directory when you run it. If you prefer, you can specify the full path to
ensure it will find the file, or make sure that 'dir lib' shows
junit-4.8.2.jar.
No problem.
On Fri, Apr 22, 2011 at 8:20 AM, jlaba...@google.com wrote:
Or CloudTasks.
@rchandia - please hold off on any big refactor until I get my changes
in. I'll try to send them for review today.
http://gwt-code-reviews.appspot.com/1427803/
--
?
On Fri, Apr 22, 2011 at 5:27 AM, Rodrigo Chandia rchan...@google.comwrote:
No problem.
On Fri, Apr 22, 2011 at 8:20 AM, jlaba...@google.com wrote:
Or CloudTasks.
@rchandia - please hold off on any big refactor until I get my changes
in. I'll try to send them for review today.
http
Yes, I'll make a patch with those files. I held on that until I could test
GPE with the fix for the validation jars
On Thu, Apr 21, 2011 at 1:42 PM, jlaba...@google.com wrote:
I forgot to check during the review, but we usually put the .project,
.classpath, .checkstyle, .settings, and war
On Tue, Apr 19, 2011 at 11:19 AM, Eric Ayers zun...@google.com wrote:
good question. I know that the -sources.jar file is needed to just
make the errors go away for legacy projects that don't reference any
classes that use javax.validation, but I haven't seen the messages for
a sample that
On Mon, Apr 18, 2011 at 4:19 AM, Jeff Schnitzer j...@infohazard.org wrote:
I'm trying to recompile my app with GWT 2.3.0-M1 but I get a deluge of
errors in the logs. I seem to be able to make some of them go away by
adding validation-api-1.0.0.GA.jar to my project, but not all. I've
also
LGTM
On Fri, Apr 15, 2011 at 9:11 AM, jlaba...@google.com wrote:
Reviewers: rchandia,
Description:
Fixing a bug in CellTree where the Show More button doesn't work for the
root node.
Issue: 5547
Please review this at http://gwt-code-reviews.appspot.com/1420801/
Affected files:
M
Oh, sorry. I guess I pasted confusingly similar links. So far there are two
approaches to fix Issue 5950:
http://gwt-code-reviews.appspot.com/1323803/show (This one)
http://gwt-code-reviews.appspot.com/1342803/show (The other one)
El 11 de febrero de 2011 12:48, Ray Ryan rj...@google.com
El 11 de febrero de 2011 13:19, Nick Chalko ncha...@google.com escribió:
On Fri, Feb 11, 2011 at 10:11 AM, Rodrigo Chandia rchan...@google.comwrote:
Oh, sorry. I guess I pasted confusingly similar links. So far there are
two approaches to fix Issue 5950:
http://gwt-code
El 11 de febrero de 2011 14:48, Ray Ryan rj...@google.com escribió:
If Dave has already LGTM'd one of the approaches as maven friendly, is
there any reason not to go with that? What are the trade offs?
No LGTM from David Chandler yet.
But aside from that, from what David and I have
El 8 de febrero de 2011 14:01, Ray Ryan rj...@google.com escribió:
Don't you need to make the same changes to samples/expenses/pom.xml?
Yes. The pom.xml currently generated by webAppCreator is rather broken.
therefore I will try removing the spam from samples/expenses first and then
try to fix
Only partially. The compiler needs the validation classes for every app, not
just the samples.
El 28 de enero de 2011 18:18, ncha...@google.com escribió:
Does just adding these to the serverlibs in the samples build.xml work?
That is what I did for expenses. see
onSuccess will be called as an async operation. That means the actual call
back will happen after getListData returns.
Rodrigo Chandia
El 19 de enero de 2011 05:20, Praveen Kumar praveen.bit...@gmail.comescribió:
Hi,
I have a Presenter which is injected via gin to the view since my view
has
It seems you are hitting this issue:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5708
http://code.google.com/p/google-web-toolkit/issues/detail?id=5708Unfortunately
one of the jarjar'd Jar GWT uses causes Javac 1.5 to die in flames when
compiling GWT from source. The easiest
Gah! I meant:
http://gwt-code-reviews.appspot.com/1170801
El 2 de diciembre de 2010 17:40, Chris Conroy con...@google.com escribió:
that's a link to this review :P
On Thu, Dec 2, 2010 at 5:39 PM, rchan...@google.com wrote:
This is actually a repost of tboryer's patch originally submitted
Let me know how that works as I am doing the same for ROO-1430
El 21 de septiembre de 2010 01:05, Amit Manjhi amitman...@google.comescribió:
LGTM, with a TODO (amitmanjhi) to change SimpleFoo id to String and
checking if everything works.
On Mon, Sep 20, 2010 at 9:15 PM, Amit Manjhi
Ping.
El 22 de junio de 2010 14:21, rchan...@google.com escribió:
http://gwt-code-reviews.appspot.com/636801/diff/1/4
File /bikeshed/src/com/google/gwt/collections/MutableSet.java (right):
http://gwt-code-reviews.appspot.com/636801/diff/1/4#newcode23
cross-casts allow this.
On Thursday, March 25, 2010, John Tamplin j...@google.com wrote:
On Thu, Mar 25, 2010 at 6:07 PM, Rodrigo Chandia rchan...@google.com
wrote:
(Sorry for the spam, Bruce. I forgot to press reply to all.)
I seem to be missing some piece from the puzzle: in which
Thx!
2010/3/25 fabb...@google.com
LGTM
http://gwt-code-reviews.appspot.com/232801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this
email with
(Sorry for the spam, Bruce. I forgot to press reply to all.)
I seem to be missing some piece from the puzzle: in which way does freezing
a MutableArray prevent the allocation of an ImmutableArray object?
// This creates a new MutableArray instance
MutableArray ma = CollectionsFactory.
isFrozen allows assertions on the status of a mutable collection. During
normal use (assertions disabled), there should be no need to call isFrozen.
Moreover, using isFrozen outside of an assertion, or while assertions are
disabled, is not guaranteed to work at all. The intention is to avoid
I like the *concept* of immutability being introduced early in the
development. The initial implementation may be limiting for some use cases,
but I believe it is a useful concept to expand on. If specific needs require
simultaneous mutable and immutable access we can provide implementations to
collection classes, it seems to me we could do the same: e.g.
LiteImmutableList and List extends LiteImmutableList.
rjrjr
On Mon, Mar 22, 2010 at 2:12 PM, Rodrigo Chandia rchan...@google.comwrote:
I like the *concept* of immutability being introduced early in the
development. The initial
on doing.
All I'm suggesting is that the code not land in trunk/user/... until is
ready. A real branch or bikeshed would be a better place.
On Thu, Mar 18, 2010 at 4:44 PM, Rodrigo Chandia rchan...@google.comwrote:
Sure, discussion and comments are welcome.
I am developing all
.
On Fri, Mar 19, 2010 at 9:57 AM, Rodrigo Chandia rchan...@google.comwrote:
Yes. I like your idea. I'll move the development to bikeshed so nobody
thinks this is ready for general consumption. Once the classes are in a
good enough state we will migrate (move) things into GWT proper.
Afterwards
Sure!
2010/3/19 Ray Ryan rj...@google.com
I think bikeshed/{src,test}/com/google/gwt/collections/client/ is just
right.
Be warned, btw, that we have no ant test target in the build.xml there yet.
Patches welcome ;-)
On Fri, Mar 19, 2010 at 12:15 PM, Rodrigo Chandia rchan
I guess we could use a supersource trick to swap in the JS-optimized ones
2010/3/19 John Tamplin j...@google.com
On Fri, Mar 19, 2010 at 4:05 PM, Bruce Johnson br...@google.com wrote:
re: package...consider skipping the client convention because it's
meant to be used on the server too. that
Sure, discussion and comments are welcome.
I am developing all this in a branch. The idea is to keep reviewing the
changes until we are all satisfied with it. I just thought it made more
sense to publish small changes rather than posting a huge patch for review
at the end. I can do either or
50 matches
Mail list logo
