On 2011/08/18 00:21:22, rjrjr wrote:
LGTM
http://gwt-code-reviews.appspot.com/1522803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
:
+hermes
Good point, this is really tricky. The problem here is that we don't
actually have the DOM element until the widget is attached. I see 2 options:
1-) We force the UiField to be a LazyDomElement, so this is explicit.
2-) We use PotentialElement with a resolver that throws an Exception (i.e
Overall looks pretty good. Still trying to digest this first round. I'll
take another pass tomorrow. For now, just silly style suggestions.
http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
File
Reviewers: rjrjr,
Description:
Adding a missing addAndReplaceElement(IsWidget, Element) to HTMLPanel.
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1514805/
Affected files:
M user/src/com/google/gwt/user/client/ui/HTMLPanel.java
Index:
http://gwt-code-reviews.appspot.com/1514805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Making lazy widgets generation the default option.
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1499809/
Affected files:
M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
M
Reviewers: rjrjr, rdcastro,
Description:
Changing lazy widgets strategy to die in case a given @UiField attribute
has no counterpart in the template.
Please review this at http://gwt-code-reviews.appspot.com/1453806/
Affected files:
M
http://gwt-code-reviews.appspot.com/1427809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java
File user/src/com/google/gwt/uibinder/client/LazyDomElement.java
(right):
http://gwt-code-reviews.appspot.com/1428807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
Reviewers: rjrjr, rdcastro,
Description:
Promoting LazyDomElement to be used externally. LazyDomElement can be
used to boost rendering time. Today, html elements marked with
ui:field need to call getElementById() by the time the template is
created even if is not used. LazyDomElement delays
Reviewers: rjrjr,
Description:
Killing @deprecated urn:with from uibinder tests.
Please review this at http://gwt-code-reviews.appspot.com/1425814/
Affected files:
M user/test/com/google/gwt/uibinder/test/client/DomBasedUi.ui.xml
M
Reviewers: rdcastro, rjrjr,
Description:
Introducing FieldTypeWriter, an enum that identifies field writers and
defines precedences useful for disambiguation when sorting builders
in the Widgets ctor.
Please review this at http://gwt-code-reviews.appspot.com/1428807/
Affected files:
M
Reviewers: rjrjr, rdcastro,
Description:
Moving back missing clauses from previous changes.
Please review this at http://gwt-code-reviews.appspot.com/1425812/
Affected files:
M user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
M
Reviewers: rjrjr, rdcastro,
Description:
Making ui:style builders always called in the Widgets ctor. Also add a
final clause in field builders.
Please review this at http://gwt-code-reviews.appspot.com/1422814/
Affected files:
M
Reviewers: rdcastro, rjrjr,
Description:
This fix a bug in WidgetPlaceholderInterpreter (missing convertField)
and create a new FieldWriterType to substitute the ugly
setBuildPrecedence().
It also make LazyDomElement used in more places. This saved a few bytes.
Please review this at
http://gwt-code-reviews.appspot.com/1420810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/04/26 22:11:30, hermes wrote:
Yes, Rafa won the race! The bug is already fixed and FieldWriterType
doesn't
bring any big gain. So I reverted the most of the files.
The only change here is the use of LazyDomElement to make all places
using the
same pattern.
http://gwt-code
Reviewers: rdcastro, rjrjr,
Description:
Fixing setInnerHTML calls on attach/detach sections.
Please review this at http://gwt-code-reviews.appspot.com/1422811/
Affected files:
M
user/src/com/google/gwt/uibinder/elementparsers/WidgetPlaceholderInterpreter.java
M
Reviewers: bobv,
Description:
Introducing ServiceHelper, a inner class of RemoteServiceProxy that
makes ProxyCreator generates less code.
Please review this at http://gwt-code-reviews.appspot.com/1423808/
Affected files:
M user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java
)
@@ -1144,7 +1144,9 @@
addWidgetParser(HasAlignment);
addWidgetParser(DateLabel);
addWidgetParser(NumberLabel);
-addWidgetParser(LazyPanel);
+if (useLazyWidgetBuilders) {
+ addWidgetParser(LazyPanel);
+}
}
/**
--
--Hermes Freitas
--
http
Reviewers: rjrjr, jat,
Description:
LazyPanel parser should be enabled only if useLazyWidgetBuilders is
enabled.
Please review this at http://gwt-code-reviews.appspot.com/1423806/
Affected files:
M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Index:
http://gwt-code-reviews.appspot.com/1420804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):
Reviewers: rjrjr,
Description:
Structural changes to UiBinder to make fields accessible via getters
and creation lazy loaded. LazyPanel support is also added.
Please review this at http://gwt-code-reviews.appspot.com/1420804/
Affected files:
M
http://gwt-code-reviews.appspot.com/1420804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
/UiBinderGenerator.java#newcode166
user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java:166: //
TODO(hermes): poor naming
On 2011/04/19 21:07:20, rjrjr wrote:
How about useLazyWidgetBuilders
Done.
http://gwt-code-reviews.appspot.com/1420804/diff/1/user/src/com/google/gwt/uibinder
Both comments are somewhat related and reflect my phobia of big CLs.
I'll address them still today. Thanks.
http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):
http://gwt-code-reviews.appspot.com/1420804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Once again SQ passed with success and orkut seems ok. I'll take a deeper
look at your doc today morning, looks promising...
On Wed, Apr 20, 2011 at 8:14 PM, her...@google.com wrote:
http://gwt-code-reviews.appspot.com/1420804/
--
--Hermes Freitas
--
http://groups.google.com/group/Google
32 matches
Mail list logo
