On Sep 15, 2:38 am, Scott Blum sco...@google.com wrote:
What Bob said. You can write much, much faster unit tests using just
CompStateBuilder, since it's easy to build a very small world that only
contains just what you need. If you don't care about speed, it's probably
less work to go
The patch is missing a test that we discussed -- the test posts a
sequence of edits and verifies that sane results are returned.
http://gwt-code-reviews.appspot.com/880801/diff/3001/4001
File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java
(left):
Hi,
on my way to implement my html5 widgets I started to implement a new
propery-provider.
Strange: When defining it in my module.xml and inherit this module
from another module, I get some strange error like JavaScript method
not found
When copying the property-provider dev to the module.xml it
Strange stuff, now it is working - without changing anything. No idea
who's the culprit.
Sorry for the noise.
On Sep 15, 2:37 pm, dflorey daniel.flo...@gmail.com wrote:
Hi,
on my way to implement my html5 widgets I started to implement a new
propery-provider.
Strange: When defining it in my
Revision: 8782
Author: b...@google.com
Date: Wed Sep 15 02:57:26 2010
Log: Workaround for a generics bug in javac 1.6.0_20 on the mac.
Patch by: bobv
Review by: rjrjr (TBR)
http://code.google.com/p/google-web-toolkit/source/detail?r=8782
Modified:
MockJavaResource so tests can be self-contained (I'm mainly thinking
about error-checking scenarios here).
CompilationStateBuilder is exactly the thing to use in these cases.
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Moved Property and EnumProperty from the
com.google.gwt.requestfactory.client.impl package to
com.google.gwt.requestfactory.shared.impl package.
Please review this at http://gwt-code-reviews.appspot.com/881801/show
Affected files:
M
Reviewers: conroy, fabbott,
Description:
Fixes speedTracerLogger.markTimline call, updates statistics to
capture the time used by JavaScript optimizers.
Please review this at http://gwt-code-reviews.appspot.com/882801/show
Affected files:
M
Revision: 8783
Author: robertvaw...@google.com
Date: Wed Sep 15 03:48:29 2010
Log: Submitting on behalf of Amit after finding a fix for a generics bug in
jdk6-google-v3.
Patch (by amitman...@google.com):
Initial implementation of a general purpose Find service based on an
EntityProxyId.
Yes, all UiBinder error checking uses it.
On Sep 15, 2010 6:53 AM, BobV b...@google.com wrote:
MockJavaResource so tests can be self-contained (I'm mainly thinking
about error-checking scenarios here).
CompilationStateBuilder is exactly the thing to use in these cases.
--
Bob Vawter
Comment by dean.hiller:
what about tabbing through fields in a popup panel?(it seems to tab all the
way to fields on the page behind even though my popup is modal :( Is that
being addressed as well for accessibility?
For more information:
LGTM + a couple of simple questions
http://gwt-code-reviews.appspot.com/882801/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):
http://gwt-code-reviews.appspot.com/882801/diff/1/4#newcode733
Daniel,
Which HTML5 features are you thinking of emulating on older browsers? It
seems to me that the only ones realistically emulatable are a few of the
input types -- most of the stuff like canvas, audio/video, et al would be
impossible without direct browser support. It might be kind of
http://gwt-code-reviews.appspot.com/882801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8784
Author: sp...@google.com
Date: Wed Sep 15 05:54:44 2010
Log: Adds a -strict option to the GWT compiler. If this option is specified,
then the compile will fail if any of the input files are bad.
Review at http://gwt-code-reviews.appspot.com/853801
Review by: sco...@google.com
Mind taking another peek?
http://gwt-code-reviews.appspot.com/882801/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):
http://gwt-code-reviews.appspot.com/882801/diff/1/4#newcode733
dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:733:
LGTM
Thanks.
http://gwt-code-reviews.appspot.com/881801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
IIUC, ExceptionWrapper can be removed now after removing the last
references in JUnitResult.
http://gwt-code-reviews.appspot.com/870802/diff/1/3
File user/src/com/google/gwt/junit/client/impl/ExceptionWrapper.java
(right):
http://gwt-code-reviews.appspot.com/870802/diff/1/3#newcode26
[+unnurg] who has graciously offered to review this change.
On Wed, Sep 15, 2010 at 10:15 AM, k...@google.com wrote:
IIUC, ExceptionWrapper can be removed now after removing the last
references in JUnitResult.
http://gwt-code-reviews.appspot.com/870802/diff/1/3
File
ExceptionWrapper still needs to exist to force 'cause' and 'stackTrace'
to be transmitted. By default, those fields are transient in our JRE.
http://gwt-code-reviews.appspot.com/870802/diff/1/3
File user/src/com/google/gwt/junit/client/impl/ExceptionWrapper.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/870802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Fair enough re: the test.
http://gwt-code-reviews.appspot.com/880801/diff/3001/4001
File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java
(left):
http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode149
Reviewers: rjrjr,
Description:
Removes @Override annotations on methods implementing interfaces.
They don't compile with a Java 1.5 compiler.
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/884801/show
Affected files:
M
Thanks for flagging this problem, Ray. Can you review this tiny patch to
fix it?
http://gwt-code-reviews.appspot.com/884801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On Wed, Sep 15, 2010 at 10:45 AM, sp...@google.com wrote:
Thanks for flagging this problem, Ray. Can you review this tiny patch to
fix it?
http://gwt-code-reviews.appspot.com/884801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8786
Author: sp...@google.com
Date: Wed Sep 15 07:44:00 2010
Log: The cross-site iframe linker now loads deferred JS code via script
tags holding
the code directly. It no longer has the code in a string literal that gets
passed
around through several layers of code before being
Reviewers: amitmanjhi,
Description:
Fix warnings and checkstyle errors
Please review this at http://gwt-code-reviews.appspot.com/882802/show
Affected files:
M
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java
M
Reviewers: rjrjr,
Description:
Make key provider a constructor argument to Cell widgets and selection
models
Attempt to fix an IndexOutOfBounds and ClassCast exception in
ExpenseDetails.java
Please review this at http://gwt-code-reviews.appspot.com/885801/show
Affected files:
M
LGTM
On Wed, Sep 15, 2010 at 11:17 AM, r...@google.com wrote:
Reviewers: amitmanjhi,
Description:
Fix warnings and checkstyle errors
Please review this at http://gwt-code-reviews.appspot.com/882802/show
Affected files:
M
On 2010/09/15 18:44:44, zhuyi wrote:
I have tried to separated these two cases and give different error
messages
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Be sure your eclipse format settings are corrent as per
trunk/eclipse/README.txt.
http://gwt-code-reviews.appspot.com/876801/diff/4001/5001
File dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (right):
http://gwt-code-reviews.appspot.com/876801/diff/4001/5001#newcode478
Possible to throw a screenshot comparison up on http://imgur.com/?
On 2010/09/15 19:16:00, jat wrote:
On Wed, Sep 15, 2010 at 3:10 PM, mailto:con...@google.com wrote:
fred, i'd love to see this go in. LGTM.
My objection to it as written revolves around wasting vertical space
when the URL
High level, this seems like a good direction. My only concern is that
this feels a little... haphazard. I think as a future direction, we
need to figure out some kind of overall strategy for what gets interned,
and where. Kind of like deciding on callee-save vs. caller-save
registers, or the
Reviewers: amitmanjhi,
Description:
Issue ROO-954: Support for transmitting stack traces for sever
exceptions.
Please review this at http://gwt-code-reviews.appspot.com/886801/show
Affected files:
M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java
M
http://gwt-code-reviews.appspot.com/870801/diff/1/3
File dev/core/src/com/google/gwt/core/ext/typeinfo/JAbstractMethod.java
(right):
http://gwt-code-reviews.appspot.com/870801/diff/1/3#newcode245
dev/core/src/com/google/gwt/core/ext/typeinfo/JAbstractMethod.java:245:
return
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Changed the code according to Scott's comments
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb, Keith,
Description:
Optimize ResourceOracle refresh by doing multiple oracles at the same
time
Please review this at http://gwt-code-reviews.appspot.com/887801/show
Affected files:
M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
M
Reviewers: fredsa,
Description:
Add server side deobfuscation of stack traces to RF Remote log handler
Please review this at http://gwt-code-reviews.appspot.com/867802/show
Affected files:
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml
M
http://gwt-code-reviews.appspot.com/870801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LG with nit.
http://gwt-code-reviews.appspot.com/876801/diff/11001/12001
File dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java (right):
http://gwt-code-reviews.appspot.com/876801/diff/11001/12001#newcode481
dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java:481: if
(resolvedClass !=
On Wed, Sep 15, 2010 at 4:45 PM, Patrick Julien pjul...@gmail.com wrote:
Oh, and forgot to mention, that the root problem is of course this:
public String getValue(R object) {
ProxyImpl proxyImpl = (ProxyImpl) object;
return renderer.render(proxyImpl.Tget(property, String.class));
}
Revision: 8787
Author: zun...@google.com
Date: Wed Sep 15 10:32:35 2010
Log: Fixes speedTracerLogger.markTimline call, updates statistics to
capture the time used by JavaScript optimizers.
Review at http://gwt-code-reviews.appspot.com/882801
Revision: 8788
Author: j...@google.com
Date: Wed Sep 15 13:49:47 2010
Log: Add Guava and streamhtmlparser, as needed by SafeHtmlTemplate.
Patch by: xtof
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=8788
Added:
/tools/lib/guava
/tools/lib/guava/guava-r06
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/870801/diff/1/3
File dev/core/src/com/google/gwt/core/ext/typeinfo/JAbstractMethod.java
(right):
http://gwt-code-reviews.appspot.com/870801/diff/1/3#newcode245
dev/core/src/com/google/gwt/core/ext/typeinfo/JAbstractMethod.java:245:
return
On Wednesday, September 15, 2010 16:16:06 Patrick Julien wrote:
public String getValue(R object) {
-return renderer.render(object.get(property));
+ProxyImpl proxyImpl = (ProxyImpl) object;
+return renderer.render(proxyImpl.Tget(property, String.class));
}
This blows up on
LGTM
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Message:
Review requested.
Description:
Make DynaTableRf use a ListEditor for the favorites.
Fix potential NPE's in AED.Chain.
Widen RequestFactoryEditorDriver's type bound to allow it to drive more
than just EntityProxy types.
Missed Label when adding IsEditor to existing
http://gwt-code-reviews.appspot.com/867802/diff/1/5
File user/src/com/google/gwt/logging/client/SimpleRemoteLogHandler.java
(right):
http://gwt-code-reviews.appspot.com/867802/diff/1/5#newcode78
user/src/com/google/gwt/logging/client/SimpleRemoteLogHandler.java:78:
record,
http://gwt-code-reviews.appspot.com/886801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8789
Author: con...@google.com
Date: Wed Sep 15 11:45:41 2010
Log: Optimize ResourceOracle refresh by doing multiple oracles at the same
time
Review at http://gwt-code-reviews.appspot.com/887801
http://code.google.com/p/google-web-toolkit/source/detail?r=8789
Modified:
using this as tmp work around for now:
package com...workarounds;
import com.google.gwt.app.place.PropertyColumn;
import com.google.gwt.requestfactory.client.impl.ProxyImpl;
import com.google.gwt.requestfactory.shared.EntityProxy;
import com.google.gwt.text.shared.Renderer;
public final class
Reviewers: rjrjr,
Description:
Remove SyncResults. Use EntityProxyId and
RequestFactory.find(EntityProxyId)
instead of the id field in EntityProxy.
Please review this at http://gwt-code-reviews.appspot.com/887802/show
Affected files:
M
On 16 sep, 00:28, codesite-nore...@google.com wrote:
Revision: 8790
Author: j...@google.com
Date: Wed Sep 15 15:19:48 2010
Log: Update javadoc for 2.1M3
Thanks! ;-)
/me time to add links to the new classes in my blog posts ;-)
--
Revision: 8791
Author: mmen...@google.com
Date: Wed Sep 15 12:32:43 2010
Log: Moved Property and EnumProperty from the
com.google.gwt.requestfactory.client.impl package to
com.google.gwt.requestfactory.shared.impl package.
Review at http://gwt-code-reviews.appspot.com/881801
Review by:
On 16 sep, 00:34, Thomas Broyer t.bro...@gmail.com wrote:
On 16 sep, 00:28, codesite-nore...@google.com wrote:
Revision: 8790
Author: j...@google.com
Date: Wed Sep 15 15:19:48 2010
Log: Update javadoc for 2.1M3
Thanks! ;-)
/me time to add links to the new classes in my blog posts
Revision: 8792
Author: sp...@google.com
Date: Wed Sep 15 13:17:02 2010
Log: Removes @Override annotations on methods implementing interfaces.
They don't compile with a Java 1.5 compiler.
Review at http://gwt-code-reviews.appspot.com/884801
Review by: rj...@google.com
Thanks for spotting that Patrick. I'll get the code updated.
On Wed, Sep 15, 2010 at 5:54 PM, Patrick Julien pjul...@gmail.com wrote:
using this as tmp work around for now:
package com...workarounds;
import com.google.gwt.app.place.PropertyColumn;
import
Revision: 8793
Author: b...@google.com
Date: Wed Sep 15 15:23:04 2010
Log: Ugly hack to address the RequestFactory tests being constructed around
a static singleton instance not playing nicely when testing with multiple
browsers.
Patch by: bobv
Review by: rjrjr
http://gwt-code-reviews.appspot.com/886801/diff/3001/4005
File user/src/com/google/gwt/requestfactory/shared/Receiver.java
(right):
http://gwt-code-reviews.appspot.com/886801/diff/3001/4005#newcode57
user/src/com/google/gwt/requestfactory/shared/Receiver.java:57: }
The formatting in this class
http://gwt-code-reviews.appspot.com/01/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
It's a shame that we can't use cells here instead of generating a
widget per
editor. Given our paucity of cells and abundance of widgets, I don't
that
relying only on a cell based approach would fly this week. But do you
think we
will be able to retrofit a CellEditorSource, something that
Whoa, what's going on here? We don't want stack traces going from the server
to the client, just the other direction. Amit's design explicitly does not
call for sending stack traces back.
Did he show you the design wave?
On Wed, Sep 15, 2010 at 6:42 PM, b...@google.com wrote:
Reviewers: rjrjr,
Description:
Fixed a bug in PropertyColumn introduced by r8780. PropertyColumn needs
access to the underlying class literals in order to get the value to
render.
Please review this at http://gwt-code-reviews.appspot.com/889801/show
Affected files:
M
Here's the spec:
https://wave.google.com/wave/waveref/googlewave.com/w+UnRfCRd2C
On Wed, Sep 15, 2010 at 7:27 PM, Ray Ryan rj...@google.com wrote:
Whoa, what's going on here? We don't want stack traces going from the
server to the client, just the other direction. Amit's design explicitly
LGTM
Not least because soon enough we'll code gen that kind of thing.
http://gwt-code-reviews.appspot.com/889801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Amit, https://jira.springsource.org/browse/ROO-1238 includes and fix
under-reporting in its title, and my understanding is that this is
addressed by your design at
https://wave.google.com/wave/waveref/googlewave.com/w+ywx8dL_XC , in
particular the portion where you talk about using version
Revision: 8794
Author: mmen...@google.com
Date: Wed Sep 15 17:06:43 2010
Log: Fixed a bug in PropertyColumn introduced by r8780. PropertyColumn
needs access to the underlying class literals in order to get the value to
render.
Review at http://gwt-code-reviews.appspot.com/889801
Review
That portion has not been fixed. I was planning to get to it after this
patch. I prioritized this patch because this patch makes an api change,
where as the under-reporting is an implementation bug.
Since it is unlikely that I will get to the under-reporting bug today, I
will create another bug
Revision: 8795
Author: unn...@google.com
Date: Wed Sep 15 17:53:58 2010
Log: Add server side deobfuscation of stack traces to RF Remote log handler
Review at http://gwt-code-reviews.appspot.com/867802
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8795
http://gwt-code-reviews.appspot.com/887802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/850801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On Wed, Sep 15, 2010 at 11:23 AM, r...@google.com wrote:
Reviewers: rjrjr,
Description:
Make key provider a constructor argument to Cell widgets and selection
models
Attempt to fix an IndexOutOfBounds and ClassCast exception in
ExpenseDetails.java
Please review this at
75 matches
Mail list logo
