Hi,
I'm fairly new in the GWT development but I'm not sure that the selected
development answers the initial need. Let me explain you why (sorry it is
rather long). It is also very possible that I'm completely wrong.
The main goal is allowing the developers to easily theme their application.
As
With the appearance pattern your proposed Theme class would be the same as a
GWT module containing all the deferred bindings for changing all the
appearance classes of all widgets. So you would inherit this theme module
and you are done. I think you could also overwrite a specific deferred
I am wondering if you are considering to use html5 widgets if available and
provide a fallback gwt implementation for browsers that do not (yet) support
widgets like
http://slides.html5rocks.com/#semantic-tags-2
I think in general GWT has the right tools for using native browser stuff
LGTM
http://gwt-code-reviews.appspot.com/1389801/diff/1/user/test/com/google/gwt/dom/client/SelectTests.java
File user/test/com/google/gwt/dom/client/SelectTests.java (right):
http://gwt-code-reviews.appspot.com/1389801/diff/1/user/test/com/google/gwt/dom/client/SelectTests.java#newcode158
Reviewers: jlabanca,
Description:
Update partial support elements for ie9.
Please review this at http://gwt-code-reviews.appspot.com/1389802/
Affected files:
M user/src/com/google/gwt/canvas/Canvas.gwt.xml
M user/src/com/google/gwt/media/Media.gwt.xml
Index:
LGTM
http://gwt-code-reviews.appspot.com/1389802/diff/1/user/src/com/google/gwt/media/Media.gwt.xml
File user/src/com/google/gwt/media/Media.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1389802/diff/1/user/src/com/google/gwt/media/Media.gwt.xml#newcode54
http://gwt-code-reviews.appspot.com/1383806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java
File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right):
Revision: 9877
Author: fabio...@google.com
Date: Wed Mar 23 05:27:01 2011
Log: cherry picking r9861 into release/2.3m1
http://code.google.com/p/google-web-toolkit/source/detail?r=9877
Modified:
/releases/2.3/user/src/com/google/gwt/core/client/impl/Impl.java
http://gwt-code-reviews.appspot.com/1386803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks, updated as suggested.
http://gwt-code-reviews.appspot.com/1386803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):
committed as r9852
http://gwt-code-reviews.appspot.com/1369809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Mar 23, 2011 at 9:57 AM, zun...@google.com wrote:
If we only write the cache to the same war dir subdirectory, then I
think my concerns with purging the cache are solved (the cache will be
in a well known place). I'm still going to make an exception so that
setting a system property
Antoine, I think the Appearance plan is closer to what you want than
you realize.
In particular, you should know that we're working on a change to
UiBinder to allow it to generate SafeHtmlRenderer instances, and then
to allow those instances to manage cell event handling. We'll share a
design
Christoph, can you take this review?
On Sat, Mar 19, 2011 at 10:04 AM, t.bro...@gmail.com wrote:
I tried to limit the changes to non-formatting ones. I also didn't go as
far as http://gwt-code-reviews.appspot.com/1384801 wrt error handling to
limit the amount of changes and avoid merge
On Wed, Mar 23, 2011 at 12:23 PM, Scott Blum sco...@google.com wrote:
On Wed, Mar 23, 2011 at 9:57 AM, zun...@google.com wrote:
If we only write the cache to the same war dir subdirectory, then I
think my concerns with purging the cache are solved (the cache will be
in a well known place).
On Fri, Mar 18, 2011 at 6:44 PM, Antoine DESSAIGNE
antoine.dessai...@gmail.com wrote:
Also I created new string messages that needs to be translated, but I
didn't do anything to allow GWT contributors to translate it. I can do the
French translation, but should I simply create the
Moving the Default/Negative/Primary Decorations into DefaultAppearance
makes the API much cleaner.
First, I removed all of the static factory methods (but left some
JavaDoc explaining how to use the different constructors). Users can
just use the default constructor, then call setDecoration() to
Nice. And will you have the shorter:
progress value=250 max=1000 /
For permutations that are guaranteed to support it?
On Wed, Mar 23, 2011 at 11:11 AM, John LaBanca jlaba...@google.com wrote:
@dflorey -
We do plan to include some HTML5 widgets using the Appearance pattern.
HTML5 widgets
I'm really looking forward to the new widgets. Sounds extremely promising!
2011/3/23 John LaBanca jlaba...@google.com
@dflorey -
We do plan to include some HTML5 widgets using the Appearance pattern.
HTML5 widgets follow a cool pattern where you can inline the fallback into
the HTML5
On Wed, Mar 23, 2011 at 2:18 PM, Philippe Beaudoin
philippe.beaud...@gmail.com wrote:
Nice. And will you have the shorter:
progress value=250 max=1000 /
For permutations that are guaranteed to support it?
Eventually... maybe. When we drop support for older versions of webkit and
FF, we
On Wed, Mar 23, 2011 at 09:54, Ray Ryan rj...@google.com wrote:
Christoph, can you take this review?
Sure, I'll take it.
On Sat, Mar 19, 2011 at 10:04 AM, t.bro...@gmail.com wrote:
I tried to limit the changes to non-formatting ones. I also didn't go as
far as
LGTM2
On 2011/03/23 18:07:02, rjrjr wrote:
LGTM
This is pretty exciting.
On Wed, Mar 23, 2011 at 11:05 AM, mailto:jlaba...@google.com wrote:
Moving the Default/Negative/Primary Decorations into
DefaultAppearance
makes the API much cleaner.
First, I removed all of the static factory
There's already the show more of CellBrowser / CellTree and text in the
SimplePager.
We shipped our first milestone Monday and our customer already asked us to
translate that show more, so it's going to be an issue soon (we have the
whole dataset ready though, so it's rather a bug in our code
Revision: 9880
Author: drfibona...@google.com
Date: Wed Mar 23 09:23:21 2011
Log: Fixing issue 5807 on server side, new issue due to rietveld
problems
Formerly at 1384802
Review at http://gwt-code-reviews.appspot.com/1384806
Reviewers: robertvawter,
Description:
Move com.google.gwt.requestfactory to com.google.requestfactory
Keep a deprecated version in the old location
Add targets for requestfactory client, server, and JRE test jars
Please review this at http://gwt-code-reviews.appspot.com/1383808/
Affected
On 2011/03/23 19:28:33, jlabanca wrote:
LGTM if you add a test of the sizing changes for CellWidget
http://gwt-code-reviews.appspot.com/1383807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Mar 23, 2011 at 1:02 PM, Eric Ayers zun...@google.com wrote:
FYI: I am adding a call to return the resource location to the
CompilationUnit to handle changing the key.
That's what CompilationUnitBuilder.getLocation() was used for and in
practice, CompilationUnit.getDisplayLocation()
http://gwt-code-reviews.appspot.com/1388803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1380806/diff/1/user/src/com/google/gwt/cell/client/ImageCell.java
File user/src/com/google/gwt/cell/client/ImageCell.java (right):
http://gwt-code-reviews.appspot.com/1380806/diff/1/user/src/com/google/gwt/cell/client/ImageCell.java#newcode58
LGTM
http://gwt-code-reviews.appspot.com/1388803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9881
Author: rj...@google.com
Date: Wed Mar 23 11:08:21 2011
Log: Snip stray package-info from a dead package.
http://code.google.com/p/google-web-toolkit/source/detail?r=9881
Deleted:
/trunk/user/src/com/google/gwt/app
--
LGTM
http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java
File
dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java
(right):
http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java
File
dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java
(right):
Revision: 9882
Author: j...@google.com
Date: Wed Mar 23 11:44:28 2011
Log: Fix JDK 1.6 dependency.
Patch by: jat
Review by: drfibonacci
http://code.google.com/p/google-web-toolkit/source/detail?r=9882
Modified:
http://gwt-code-reviews.appspot.com/1383807/diff/1/user/src/com/google/gwt/user/cellview/client/CellWidget.java
File user/src/com/google/gwt/user/cellview/client/CellWidget.java
(right):
Revision: 9883
Author: skybr...@google.com
Date: Wed Mar 23 11:52:31 2011
Log: make -standardsMode the default for GwtTestCase.
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9883
Modified:
/trunk/user/src/com/google/gwt/junit/JUnitShell.java
Reviewers: zundel, jbrosenberg,
Description:
When we persist CompilationUnits, persist the GWT AST too.
Please review this at http://gwt-code-reviews.appspot.com/1384807/
Affected files:
M dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
M
Revision: 9885
Author: scheg...@google.com
Date: Wed Mar 23 12:56:08 2011
Log: Using cached ZipFileClassPathEntry objects.
While this does not give benefits for DevMode, which parses jar files only
once, GWT Designer does this many times.
This gives about 15% speed up in GWT
Revision: 9886
Author: mrruss...@google.com
Date: Wed Mar 23 16:19:00 2011
Log: tag the 2.3.0m1 release
http://code.google.com/p/google-web-toolkit/source/detail?r=9886
Added:
/tags/2.3.0-m1
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9887
Author: fre...@google.com
Date: Wed Mar 23 13:32:42 2011
Log: Start at adding media events for audio/video elements. Note, the
underlying implementation for HTML5 media
event handling is expected to change in the near future.
Review at
41 matches
Mail list logo
