I'm trying to fix a bug (
https://code.google.com/p/google-web-toolkit/issues/detail?id=8100
), and I could use some expert advice. I'm a long time GWT user (7
years), but only recently started hacking the internals, and I need
help on this one.
Background:
Thomas Broyer has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
IIRC, this new behavior is also consistent with @Inject in
google-gin which again makes
Daniel Kurka has posted comments on this change.
Change subject: add StringBuffer/Builder.reverse
..
Patch Set 1:
(1 comment)
File
Daniel Kurka has uploaded a new patch set (#2).
Change subject: add StringBuffer/Builder.reverse
..
add StringBuffer/Builder.reverse
fixes ISSUE 449
Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5
Review-Link:
Daniel Kurka has uploaded a new patch set (#3).
Change subject: add StringBuffer/Builder.reverse
..
add StringBuffer/Builder.reverse
fixes ISSUE 449
Change-Id: I342e7ed86c0e4efa90d09bdfe0d72c79db2654c5
Review-Link:
John Ahlroos has uploaded a new patch set (#3).
Change subject: Prevent dev mode breakage when lots of jso classes are used.
..
Prevent dev mode breakage when lots of jso classes are used.
Elemental introduces a lot of native
John Ahlroos has posted comments on this change.
Change subject: Prevent dev mode breakage when lots of jso classes are used.
..
Patch Set 3: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2210
To
Daniel Kurka has uploaded a new patch set (#4).
Change subject: Widget Iterator now throws NoSuchElementExceptions
correctly.
..
Widget Iterator now throws NoSuchElementExceptions correctly.
Change-Id:
Daniel Kurka has uploaded a new patch set (#5).
Change subject: Widget Iterator now throws NoSuchElementExceptions
correctly.
..
Widget Iterator now throws NoSuchElementExceptions correctly.
Change-Id:
John Ahlroos has uploaded a new patch set (#3).
Change subject: Workaround for resolving mouse button on mouse move in
Firefox
..
Workaround for resolving mouse button on mouse move in Firefox
Change-Id:
Daniel Kurka has posted comments on this change.
Change subject: Fixes ISSUE 7079 - Add support for the newer bindery
HandlerRegistration
..
Patch Set 1:
Hi Julien,
I can't find you on the CLA-SIGNERS list:
Daniel Kurka has posted comments on this change.
Change subject: Upon selection in a SuggestBox's pop up, focus the text
field
..
Patch Set 2:
Hello Christian,
I could not find you on the CLA signers list:
Julien Dramaix has posted comments on this change.
Change subject: Fixes ISSUE 7079 - Add support for the newer bindery
HandlerRegistration
..
Patch Set 1:
I signed the following one :
Daniel Kurka has abandoned this change.
Change subject: set target and source level to 1.6 for JSP compilation
..
Abandoned
Submitted
--
To view, visit https://gwt-review.googlesource.com/2201
To unsubscribe, visit
Daniel Kurka has abandoned this change.
Change subject: fixing possible NPE in on CellWidget.onBrowserEvent if cell
does not consume any events fixes issue 7649
..
Abandoned
Submitted
--
To view, visit
Goktug Gokdogan has posted comments on this change.
Change subject: add StringBuffer/Builder.reverse
..
Patch Set 3:
(1 comment)
File
Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
I think there are optimization steps in JS which can reduce the code bloat.
Roberto, can
Goktug Gokdogan has posted comments on this change.
Change subject: Widget Iterator now throws NoSuchElementExceptions
correctly.
..
Patch Set 5: Code-Review+1
(1 comment)
Roberto Lublinerman has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
The JsInliner should take care of this case. Methods that are called in
only one
Thomas Broyer has posted comments on this change.
Change subject: Upon selection in a SuggestBox's pop up, focus the text
field
..
Patch Set 2:
Daniel, isn't the CLA process handled by Gerrit now?
(BTW, CLA-SIGNERS is
Thomas Broyer has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
A simple fix is to only use the JSNI method if the method is private.
And in that case, also
Thomas Broyer has posted comments on this change.
Change subject: set target and source level to 1.6 for JSP compilation
..
Patch Set 2:
So Daniel, how does it feel to be on the other side now? ;-)
--
To view, visit
Roberto Lublinerman has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
The existing code is already fixed.
The question remains whether we want to allow
Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
Actually we discussed this internally and we have an agreement on our side
to add the
Okay, I found a pretty good solution. Solved the problem by adding a
method isSourceMapsEnabled to CompilationResult, which gets passed all
the way from Link to SelectionScriptLinker. The value is set in Link
via the permutation's property oracles. I tested this and it works
well!
Now, how can
On Wed, Apr 10, 2013 at 12:22 PM, Alex Epshteyn
alexander.epsht...@gmail.com wrote:
Thanks Thomas! Is it possible to still use SVN by any chance?
We'll continue accepting patches from Rietveld, just it's a bit more work
for us to merge them.
--
--
Brian Slesinsky has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
I agree that we should indirect through JSNI only if the method is actually
private. This
Gotcha. I will certainly have more than one patch to contribute now that
I've really dived into the GWT compiler internals, so I might as well start
working with the new git-based system to make things easier for everyone.
I've already made quite a few other enhancements and bug fixes to the
On Wednesday, April 10, 2013 9:22:18 PM UTC+2, Alex Epshteyn wrote:
Thanks Thomas! Is it possible to still use SVN by any chance? I haven't
made the leap over to git yet as I'm still using an older version of
IntelliJ without git support. If not, could you help me out with some
Goktug Gokdogan has abandoned this change.
Change subject: Avoid implicit inter-dependencies between DOM, History,
Window and Widgets through BaseListenerWrapper by moving things to where
they're used.
..
Abandoned
Thanks Thomas! I appreciate it. I'll give it a try!
On Wed, Apr 10, 2013 at 5:01 PM, Thomas Broyer t.bro...@gmail.com wrote:
On Wednesday, April 10, 2013 9:22:18 PM UTC+2, Alex Epshteyn wrote:
Thanks Thomas! Is it possible to still use SVN by any chance? I haven't
made the leap over
Brian Slesinsky has posted comments on this change.
Change subject: Prevent dev mode breakage when lots of jso classes are used.
..
Patch Set 3:
(3 comments)
File
If you are on Windows or Mac OS I would
recommend http://www.sourcetreeapp.com/ as git frontend (its free).
-- J.
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
Google Web Toolkit
James Nelson has posted comments on this change.
Change subject: Prevent dev mode breakage when lots of jso classes are used.
..
Patch Set 3: Code-Review-1
(3 comments)
This patch doesn't actually fix the underlying issue;
34 matches
Mail list logo
