Re: [gwt-contrib] Re: Latest update to GWT plugin for Eclipse crashes Indigo

2013-12-26 Thread Rajeev Dayal
Looking into this now. Updates will be posted on the other thread that Michael mentions. On Mon, Dec 23, 2013 at 4:38 PM, Michael Prentice splak...@gmail.comwrote: This was also posted in the GPE Google Group here: https://groups.google.com/forum/#!topic/google-plugin-eclipse/V4MaZEXY24Q

Re: [gwt-contrib] Re: GPE does not like GWT trunk SDK?

2013-12-08 Thread Rajeev Dayal
Hey guys, The source is on SVN, as Thomas says, but it's not up-to-date nor is it buildable right now. We have a hidden project on GitHub with the updated GPE source, but I don't want to open it up until external people can actually build it. I'm working on this as we speak. I'd expect to have

Re: [gwt-contrib] Re: GPE does not like GWT trunk SDK?

2013-11-18 Thread Rajeev Dayal
Hi Brandon, The sources are on GitHub right now, but they are not public. I'm working on externalizing the build system. I don't want to make the sources public till then, as it's not much use to outside contributors if they can't build the plugin themselves (which has been evidenced by the GPE

Re: [gwt-contrib] Re: GPE does not like GWT trunk SDK?

2013-10-31 Thread Rajeev Dayal
Hey Stephen, We're in the process of moving the GPE source to github (and converting the build system to Maven/Tycho so that external developers can build it) , which is why that repo hasn't been updated in a long time. I'll update the homepage to reflect that. As for the problem you've noted,

Re: [gwt-contrib] “GWT no longer supports ChromeFrame. The implementation caused more bugs than it solved.”

2012-10-29 Thread Rajeev Dayal
Ugh, thanks Unnur. Sorry about that, Thomas. On Mon, Oct 29, 2012 at 1:02 PM, Unnur Gretarsdottir unn...@google.comwrote: OK - I'm just removing the bullet point entirely now - should be live soon On Fri, Oct 26, 2012 at 5:53 PM, Thomas Broyer t.bro...@gmail.com wrote: On Thursday,

[gwt-contrib] Re: Update Maven sample pom.xml files to use maven-compiler-plugin's annotation processing functiona... (issue1828803)

2012-09-17 Thread Rajeev Dayal
Thanks David - when I tested on the mac, I didn't have to refresh the project after first import provided that I actually did an Update Project after enabling Maven Annotation Processing on the project. I noted this in bold on the Wiki page. On Mon, Sep 17, 2012 at 9:15 AM,

Re: [gwt-contrib] submit chrome dev mode plugin to chrome web store?

2012-09-17 Thread Rajeev Dayal
right now. -Daniel Am 13.09.2012 um 01:09 schrieb Rajeev Dayal rda...@google.com: Sorry, this totally fell off the plate. Daniel, would you be able to submit it to the Chrome Webstore? On Wed, Sep 12, 2012 at 7:07 PM, Daniel Kurka kurka.dan...@gmail.comwrote: Hi Rajeev, what

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1829803)

2012-09-14 Thread Rajeev Dayal
Hey Thomas, Thanks for looking this over. I'll reply to the code-specific comments in Rietveld itself, but I thought I'd respond to your more pressing concerns first. On Fri, Sep 14, 2012 at 10:57 AM, t.bro...@gmail.com wrote: I'm sorry I've only started to review the files (over the last few

Re: [gwt-contrib] submit chrome dev mode plugin to chrome web store?

2012-09-12 Thread Rajeev Dayal
in there. Thanks. Rob On Tue, Aug 7, 2012 at 11:39 AM, Rajeev Dayal rda...@google.com wrote: Hey Daniel, We do need to post the chrome devmode plugin to the webstore. I'll take care of that this week. I also need to rebuild the devmode plugin, as there were some fixes that went

[gwt-contrib] Re: fixes ISSUE 7479 (typo in javadoc) (issue1770803)

2012-07-31 Thread Rajeev Dayal
Patch posted here (had already submitted the original before that): http://gwt-code-reviews.appspot.com/1801803 On Tue, Jul 31, 2012 at 8:24 AM, tucker...@gmail.com wrote: On 2012/07/30 19:10:14, rdayal wrote: Since this is just a doc fix can you also fix 4575?

Re: [gwt-contrib] GWT 2.5 RC1 increases mgwt showcase by 22%

2012-07-23 Thread Rajeev Dayal
Daniel mentioned that somehow the CSS for the blackberry permutation is ending up in the iPhone permutation. That can't just be a Cell Widget issue. On Mon, Jul 23, 2012 at 12:24 AM, Ray Cromwell cromwell...@google.comwrote: Are you using any Cell widgets by any chance? I've seen that the

Re: [gwt-contrib] “GWT no longer supports ChromeFrame. The implementation caused more bugs than it solved.”

2012-07-18 Thread Rajeev Dayal
Hey guys, This is my fault. I mis-interpreted the code change. As the change to fix this issue was basically a revert of the original commit that was supposed to add ChromeFrame support, I incorrectly assumed that reverting the code would prevent special behavior for ChromeFrame (which I figured

[gwt-contrib] Re: Move test Messages files from client to shared; was missed in r10061. This was causing I18NSuite... (issue1752803)

2012-06-20 Thread Rajeev Dayal
No prob, thx for your help in doing so :). On Wed, Jun 20, 2012 at 7:38 PM, j...@google.com wrote: LGTM Thanks for tracking this down and fixing it. http://gwt-code-reviews.**appspot.com/1752803/http://gwt-code-reviews.appspot.com/1752803/ --

Re: [gwt-contrib] tests

2012-06-19 Thread Rajeev Dayal
Hey, I'm running into the same thing on a Linux workstation. It's a virtual instance, so I'm not sure if that might have something to do with it, but it's definitely strange. Here's one exception that I see: [junit] Exception in thread pool-1-thread-1 java.lang.RuntimeException: Unable to

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread Rajeev Dayal
On Wed, Jun 13, 2012 at 5:04 PM, Brian Slesinsky skybr...@google.comwrote: I don't think we support Java 1.5 anymore? http://code.google.com/p/google-web-toolkit/issues/detail?id=6790 https://groups.google.com/forum/#!msg/google-web-toolkit/fATw0rL8lSE/xbxX5Hf8ozUJ I'm totally fine with

Re: [gwt-contrib] Packaging issue: org.json and RequestFactory

2012-06-11 Thread Rajeev Dayal
On Thu, May 31, 2012 at 12:07 PM, Thomas Broyer t.bro...@gmail.com wrote: On Thu, May 31, 2012 at 5:00 PM, Rajeev Dayal wrote: Hey Thomas, Thanks for pointing this out. This is pretty whacked, and is probably a symptom of a problem that we've had for a long time - how do we handle

Re: [gwt-contrib] Packaging issue: org.json and RequestFactory

2012-06-11 Thread Rajeev Dayal
On Wed, Jun 6, 2012 at 2:38 AM, James Nelson ja...@wetheinter.net wrote: I wouldn't be opposed to having differing rules for the GWT SDK package downloadable at code.google.com and the Maven artifacts. AFAIK, the original idea of bundling them into gwt-user.jar (and gwt-dev.jar) was to make

[gwt-contrib] Re: Re: Add Map support to RequestFactory (issue 6132056)

2012-06-08 Thread Rajeev Dayal
need with it. On 7 June 2012 16:18, Rajeev Dayal rda...@google.com wrote: Thomas, thanks for jumping in. James, as Thomas said, we'll defer this to 2.5.1, but we'd definitely like to get it in there, as it's an important patch. We just didn't want to force this patch in 2.5.0, which

[gwt-contrib] Re: Re: Add Map support to RequestFactory (issue 6132056)

2012-06-07 Thread Rajeev Dayal
Thomas, thanks for jumping in. James, as Thomas said, we'll defer this to 2.5.1, but we'd definitely like to get it in there, as it's an important patch. We just didn't want to force this patch in 2.5.0, which is what we would have to do with the current workload. Thanks so much for working on

[gwt-contrib] Re: Use shared.GWT to avoid ClassNotFoundExceptions (issue1722803)

2012-06-07 Thread Rajeev Dayal
Committed as r11024. On Thu May 31 14:13:23 GMT-400 2012, Rajeev Dayal rda...@google.com wrote: Hey all, I don't think I'll have a chance to look at this by the afternoon. John, if you could check into this, that would be great. I believe I was up-to-date; did a sync right before I ran

Re: [gwt-contrib] Packaging issue: org.json and RequestFactory

2012-05-31 Thread Rajeev Dayal
Hey Thomas, Thanks for pointing this out. This is pretty whacked, and is probably a symptom of a problem that we've had for a long time - how do we handle dependencies on GWT? Should we bundle them, re-package them, or require the user to add them to the classpath? Other replies inline: On Tue,

[gwt-contrib] Re: Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

2012-05-31 Thread Rajeev Dayal
Ran the latest patch set through google's battery of tests; everything passed. On Thu May 31 09:22:21 GMT-400 2012, t.bro...@gmail.com wrote: On 2012/05/31 01:56:32, skybrian wrote: LGTM (assuming tests still pass) Because I must confess I didn't run them on the last few patch-sets, I just

[gwt-contrib] Re: Re: Ignore qualified refs with generics (issue1578808)

2012-05-31 Thread Rajeev Dayal
Sounds good. On Thu May 31 11:51:45 GMT-400 2012, stephen.haber...@gmail.com wrote: Double-ping. If we can't land this one soon, we'll defer it to 2.5.1. Yeah, let's just defer. I haven't had time to get back in to it and answer Scott's question. This is just an optimization anyway, and I

[gwt-contrib] Re: Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

2012-05-31 Thread Rajeev Dayal
Committed as r11004. On Thu May 31 11:34:33 GMT-400 2012, Rajeev Dayal rda...@google.com wrote: Ran the latest patch set through google's battery of tests; everything passed. On Thu May 31 09:22:21 GMT-400 2012, t.bro...@gmail.com wrote: On 2012/05/31 01:56:32, skybrian wrote: LGTM

[gwt-contrib] Re: Use shared.GWT to avoid ClassNotFoundExceptions (issue1722803)

2012-05-31 Thread Rajeev Dayal
Hey all, I don't think I'll have a chance to look at this by the afternoon. John, if you could check into this, that would be great. I believe I was up-to-date; did a sync right before I ran the tests. I didn't check to see if some other change had landed that would have caused this problem.

Re: [gwt-contrib] Contributor License Agreements question

2012-05-29 Thread Rajeev Dayal
Just verified that you're added to the corporate CLA list. I think I was looking at an outdated spreadsheet. You're all good! On Fri May 25 10:15:54 GMT-400 2012, Alexandre Ardhuin alexandre.ardh...@gmail.com wrote: Confirmation email forwarded. Thanks, Alexandre 2012/5/25 Rajeev Dayal

Re: [gwt-contrib] Contributor License Agreements question

2012-05-25 Thread Rajeev Dayal
Hey Alexandre, You're not able to verify that you signed the CLA in the corporate case. I looked at our corporate CLA list, and I don't see your name (or that of your company) listed there. I'll do some more digging to see what happened. Did you receive any sort of confirmation e-mail? If so,

Re: [gwt-contrib] Add Map support to RequestFactory (issue 6132056)

2012-05-14 Thread Rajeev Dayal
Hey James, Sorry, I have not had a chance to look this one over, but I am planning to. The turnaround on patches has been pretty bad for the past while, and we're actively going to make some changes soon that will result in big improvements (I hope). In the meantime, we're trying to review and

[gwt-contrib] Re: Re: Fix this-window confusion in DevMode (issue1620805)

2012-05-14 Thread Rajeev Dayal
Hey Stephen, Thanks for the feedback. Replies inline: On Tue May 08 23:22:49 GMT-400 2012, Stephen Haberman stephen.haber...@gmail.com wrote: I agree, but asking anyone to have to make changes in working code Two things, one is that I don't think any code that relies on this behavior

[gwt-contrib] Re: Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

2012-05-07 Thread Rajeev Dayal
Hey Thomas, Good find! I thought there was something funny with finishTestAndReset, but I wouldn't have spotted that :). Replies inline: On Fri May 04 22:08:03 GMT-400 2012, t.bro...@gmail.com wrote: OK, found it: the issue in EditorTest is that the SimpleBar that the setUserName is applied

[gwt-contrib] Re: Re: Serialization of Final Fields in RPC (issue1380807)

2012-05-04 Thread Rajeev Dayal
HA! If it's important enough, we should land it, but my impression is that it isn't - so maybe it should die a quiet death. On Fri May 04 14:13:42 GMT-400 2012, John Tamplin j...@google.com wrote: On Fri, May 4, 2012 at 12:15 PM, rda...@google.com wrote: Was debating whether this one

[gwt-contrib] Re: Re: Serialization of Final Fields in RPC (issue1380807)

2012-05-04 Thread Rajeev Dayal
Hey Stephen, Thanks for the info. So we should probably try and land it. From my quick summary of the comment thread, it looks like there's disagreement on the implementation. Can you or John save me some time and fill me in on the history? Rajeev On Fri May 04 14:24:11 GMT-400 2012,

[gwt-contrib] Re: Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

2012-04-30 Thread Rajeev Dayal
Thanks, Thomas. I'll take a look and see what's going on in our environment. I wonder if it's an order-of-execution failure (implying that there's statefulness between test runs that's not getting cleared). On Sun Apr 29 07:17:38 GMT-400 2012, t.bro...@gmail.com wrote: On 2012/04/29 10:42:26,

[gwt-contrib] Re: Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

2012-04-30 Thread Rajeev Dayal
are failing, we also run with FF3, which Thomas most likely doesn't On Mon Apr 30 11:10:32 GMT-400 2012, Rajeev Dayal rda...@google.com wrote: Thanks, Thomas. I'll take a look and see what's going on in our environment. I wonder if it's an order-of-execution failure (implying that there's

[gwt-contrib] Re: Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

2012-04-06 Thread Rajeev Dayal
No worries, we're leaving it in :). On Thu Apr 05 19:37:49 GMT-400 2012, John Porter Simons porte...@google.com wrote: It's handy, and we depend on it now. Definitely let me know if you remove it so we can subclass Column. On Thu, Apr 5, 2012 at 5:19 PM, jlaba...@google.com wrote: Leave it

[gwt-contrib] Re: Fix PopupPanel.center when content has changed (issue1573803)

2012-04-06 Thread Rajeev Dayal
Thanks! On Fri Apr 06 10:52:30 GMT-400 2012, jlaba...@google.com wrote: LGTM http://gwt-code-reviews.appspot.com/1573803/https://www.google.com/url?sa=Dq=http://gwt-code-reviews.appspot.com/1573803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re: scheglov pointed out a leak in compilation units in dev mode after a refresh (issue1490801)

2012-04-05 Thread Rajeev Dayal
We're gearing up for a GWT 2.5, so I'd either like to get this in, or close the issue if it will never make it into a GWT release. On Thu Apr 05 15:42:05 GMT-400 2012, scheg...@google.com wrote: On 2012/04/05 19:39:54, rdayal wrote: Ping. Is this patch dead, or do we still want to get this

[gwt-contrib] Re: Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

2012-04-05 Thread Rajeev Dayal
Wow, you're right. Good catch. I'll follow up and see what's going on here.. On Thu Apr 05 17:02:10 GMT-400 2012, stephen.haber...@gmail.com wrote: Looks like this one is not going to be accepted. It was actually already committed...if the decision was to not add it, it needs to be

Re: [gwt-contrib] Permutation Specific SymbolMap (issue1652803)

2012-03-02 Thread Rajeev Dayal
On Fri Mar 02 13:09:00 GMT-500 2012, cromwell...@google.com wrote: On 2012/03/02 10:39:39, acleung wrote: Are you missing the module files (.gwt.xml) that define this new property?

Re: [gwt-contrib] Re: Add README step to use the Google Web Toolkit SDK in the gwt-user project so that users can run ... (issue966802)

2010-11-28 Thread Rajeev Dayal
Okay, thanks for checking this out. I'll run some more tests and report back my results. On Sat, Nov 27, 2010 at 7:43 AM, Miguel Méndez mmen...@google.com wrote: Actually, I'm not sure that this is accurate. I just tried it out against gwt-user and gwt-dev with natures and builders on in a

[gwt-contrib] Re: Add README step to use the Google Web Toolkit SDK in the gwt-user project so that users can run ... (issue966802)

2010-11-17 Thread Rajeev Dayal
No, I don't think it will. I think the nature will be ignored. But let me verify that before putting my foot in my mouth. On Wed, Nov 17, 2010 at 1:59 PM, Ray Ryan rj...@google.com wrote: And all the examples as well. I thought one of you GPE guys told me that eclipse would barf if it saw

Re: [gwt-contrib] [google-web-toolkit] r8838 committed - Placeholder for RC1 Maven and GPE artifacts.

2010-09-22 Thread Rajeev Dayal
Sorry, I'm not sure what you're referring to here. On Wed, Sep 22, 2010 at 1:58 PM, Patrick Julien pjul...@gmail.com wrote: Hmm, does that mean we would still be stuck using only static methods? I mean, it's not that far out to introduce a helper class to find types. On Wed, Sep 22, 2010

Re: [gwt-contrib] Re: Eclipse: GDT - Scala plugin cooperation problem

2010-09-06 Thread Rajeev Dayal
! Martin On Wed, Aug 25, 2010 at 18:30, Rajeev Dayal rda...@google.com wrote: If you uninstall GPE and leave the Scala plugin, does everything work? What type of launch configuration are you using? Is it a Web Application launch configuration? On Wed, Aug 25, 2010 at 3:06 AM, Martin Mauch

Re: [gwt-contrib] Re: Eclipse: GDT - Scala plugin cooperation problem

2010-08-25 Thread Rajeev Dayal
If you uninstall GPE and leave the Scala plugin, does everything work? What type of launch configuration are you using? Is it a Web Application launch configuration? On Wed, Aug 25, 2010 at 3:06 AM, Martin Mauch martin.ma...@gmail.comwrote: I'm running into the same problem here. Is there any

Re: [gwt-contrib] STS RPC failures

2010-05-24 Thread Rajeev Dayal
I missing? FWIW, when launching from STS (Run as-Web Application), it launches a Finder window and prompts me to select a WAR directory, which defaults to target/extrack-0.1.0-SNAPSHOT. On Fri, May 21, 2010 at 11:24 AM, Rajeev Dayal rda...@google.com wrote: The roo directory should

Re: [gwt-contrib] STS RPC failures

2010-05-21 Thread Rajeev Dayal
I wonder about the version of Roo that you're using. If you navigate down into your STS folder, do you see a roo-related directory there? What is the name of that directory? I think you need to be using the milestone version of roo, which is located at sts dir/roo dir/bin/roo.{sh, bat}. On Fri,

Re: [gwt-contrib] STS RPC failures

2010-05-21 Thread Rajeev Dayal
The roo directory should be roo-1.1.0.M1; so you should be using Roo 1.1.0.M1 to generate the app, as opposed to Roo 1.0.2. On Fri, May 21, 2010 at 2:22 PM, Rajeev Dayal rda...@google.com wrote: I wonder about the version of Roo that you're using. If you navigate down into your STS folder, do

Re: [gwt-contrib] STS RPC failures

2010-05-21 Thread Rajeev Dayal
window and prompts me to select a WAR directory, which defaults to target/extrack-0.1.0-SNAPSHOT. On Fri, May 21, 2010 at 11:24 AM, Rajeev Dayal rda...@google.com wrote: The roo directory should be roo-1.1.0.M1; so you should be using Roo 1.1.0.M1 to generate the app, as opposed to Roo 1.0.2

Re: [gwt-contrib] STS RPC failures

2010-05-21 Thread Rajeev Dayal
Oh, also, did you enable AspectJ weaving (when STS asked you about this)? On Fri, May 21, 2010 at 3:50 PM, Rajeev Dayal rda...@google.com wrote: [by the way, the second link you posted is broken] Hm, this is odd. What actions are you taking (in the UI) when the RPC exceptions happen

[gwt-contrib] Re: ServletValidate disable external DTDs (issue371801)

2010-04-27 Thread Rajeev Dayal
If that's the main use case, then I agree. The reason I brought it up was because App Engine also does its own validation of the web.xml file, so it seemed like we were doing double-work here. On Mon, Apr 26, 2010 at 3:33 PM, Scott Blum sco...@google.com wrote: I think that would just make

[gwt-contrib] Re: Code Review Request: Fix flaxy MessageTransport test

2010-03-16 Thread Rajeev Dayal
I'm testing that if you try to use MessageTransport.executeRequestAsync(..) and the server side of the network has closed its input stream, then an exception will be thrown (an ExecutionException with an underlying cause of IllegalStateException). I don't think shutdownInput(..) would work,

Re: [gwt-contrib] Google Web Toolkit 2.0 RC2 Now Available

2009-11-30 Thread Rajeev Dayal
Hi Jeff, The method you've outlined below will work. Alternatively, you can blow away everything google related in eclipse/dropins, and then unzip the RC2 archive into the dropins directory. There is no dependency between the RC1 and RC2 plugins. That is, one does not have to be installed on top

Re: [gwt-contrib] Google Web Toolkit 2.0 RC2 Now Available

2009-11-30 Thread Rajeev Dayal
Glad its working for you. I'll keep my eyes out for any other reports of this. On Mon, Nov 30, 2009 at 12:11 PM, Jeff Chimene jchim...@gmail.com wrote: Hi Rajeev, On Mon, Nov 30, 2009 at 9:32 AM, Rajeev Dayal rda...@google.com wrote: Hi Jeff, The method you've outlined below will work

[gwt-contrib] Re: Code Review Request: Send startup URLs over the wire to GPE

2009-11-23 Thread Rajeev Dayal
Ok, I did confirm it - check out the documentation on DevModeUI.setStartupURLs - that defines the values in the map. 2009/11/24 Miguel Méndez mmen...@google.com On Tue, Nov 24, 2009 at 12:17 AM, rda...@google.com wrote: Thanks for the review!

[gwt-contrib] Re: Fixes checkstyle issues introduced by r7001.

2009-11-19 Thread Rajeev Dayal
The Rietveld link does not seem to be working, but LGTM. On Wed, Nov 18, 2009 at 5:18 PM, mmen...@google.com wrote: Reviewers: rdayal, jat, Please review this at http://gwt-code-reviews.appspot.com/103813 Affected files: M dev/core/src/com/google/gwt/dev/DevModeBase.java Index:

[gwt-contrib] Re: Code Review Request: Drop Request/Response Logging Levels down to TRACE

2009-11-18 Thread Rajeev Dayal
Based on some recent discussions, we're going to make a change where we modify the log levels depending on what UI the user is using. I'll send out a CL for this shortly. On Wed, Nov 18, 2009 at 6:07 PM, j...@google.com wrote: http://gwt-code-reviews.appspot.com/103812/diff/1/2 File

[gwt-contrib] Re: Google Plugin for Eclipse Source

2009-10-12 Thread Rajeev Dayal
Happy to hear you're interested in hacking away on the plugin ;) On Mon, Oct 12, 2009 at 2:32 PM, Sam Gross colesb...@gmail.com wrote: I opened issue 4124 ( http://code.google.com/p/google-web-toolkit/issues/detail?id=4124). -Sam On Mon, Oct 12, 2009 at 2:08 PM, Jason Parekh

[gwt-contrib] Re: Invalid version number 2.0 passed to external.gwtOnLoad()

2009-09-21 Thread Rajeev Dayal
Could we modify the hosted mode servlet so that it set the appropriate no-cache headers on hosted.html? I've also run into this issue due to browser caching. Also, is this file re-generated every time hosted mode is started up? If not, it definitely should be. On Mon, Sep 21, 2009 at 1:26 PM,

[gwt-contrib] Re: On Mac, emit a -d32 arg for hosted mode when running on a 64-bit vm

2009-09-18 Thread Rajeev Dayal
Do you also need to apply the same fix for the launch configurations that are generated by WebAppCreator? On Thu, Sep 17, 2009 at 3:10 PM, sco...@google.com wrote: http://gwt-code-reviews.appspot.com/68803/diff/1/3 File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):

[gwt-contrib] Re: Snow Leopard 32-bit checking fix (1.7 based)

2009-09-03 Thread Rajeev Dayal
@Ray: To clarify, you need to add -d32 to the launch config though, right? On Thu, Sep 3, 2009 at 3:22 PM, cromwell...@gmail.com wrote: On 2009/09/03 19:07:53, knorton wrote: Ray, Can you confirm that this patch fixes the Snow Leopard issue. It's the same patch as before with the typo

[gwt-contrib] Issue With Debugging with JDK 1.6.0_14 Has Been Resolved in JDK 1.6.0_16

2009-08-14 Thread Rajeev Dayal
Hi, As some of you may recall, there as an issue with debugging if you're using JDK 1.6.0_14. You'll find that your breakpoints are not hit. More details on the issue can be found here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 This issue has been recently fixed in JDK 1.6.0_16.

[gwt-contrib] Re: ant improvements, round 1

2009-06-11 Thread Rajeev Dayal
Nice job Freeland! You're an ant-master! On Thu, Jun 11, 2009 at 10:40 AM, Freeland Abbott fabb...@google.comwrote: Well, if I've saved serious time by 10:30am, I'm happy indeed. I've got another depends-on-your-hardware-but-I-saw-4min-saving (for work-to-do rebuild of samples, so no gain if

[gwt-contrib] Re: possible ant changes

2009-06-01 Thread Rajeev Dayal
Hey Freeland, All of this sounds great. The build scripts have been in severe need of tweaking for a while, and I'm glad that you've decided to tackle this tricky issue. I've got a couple of comments about the ant test behavior. If it is the case that a subsequent ant build after running ant

[gwt-contrib] Re: locale names

2009-02-24 Thread Rajeev Dayal
You probably have already considered this, but there are made-up locales in the I18N tests (PigLatin, for example). On Mon, Feb 23, 2009 at 1:56 PM, John Tamplin j...@google.com wrote: Does anyone use any made-up locales with GWT? I am getting ready to commit some changes which, among other

[gwt-contrib] Re: Could we create begin/end css attributes rather then switching left and right?

2009-02-18 Thread Rajeev Dayal
FWIW, similar sorts of things were done in HorizontalSplitPanel and DockPanel for the RTL work that was done as part of 1.5. Both of these panels had a concept of LEFT or EAST in GWT 1.4, but the bidi-friendly LINE_START and LINE_END contants were added in GWT 1.5. On Wed, Feb 18, 2009 at 9:43

[gwt-contrib] Code Review Request: Add createApplication method to WebAppCreator that accepts an Eclipse Project Name as an Argument

2009-01-14 Thread Rajeev Dayal
Hi Scott, I'd like to you do a code review. To apply this patch, navigate to the the root of the GWT 1.6 releases branch, and perform the following steps: svn update -r4449 patch -p0 updatedWebAppCreatorWithProjectNameParam-r4449.patch Description: In the migration from ApplicationCreator to

[gwt-contrib] Re: Code Review Request: Add createApplication method to WebAppCreator that accepts an Eclipse Project Name as an Argument

2009-01-14 Thread Rajeev Dayal
WebAppCreator do its thing. Sorry about the unnecessary traffic, and thanks for your input. Rajeev On Wed, Jan 14, 2009 at 4:35 PM, Rajeev Dayal rda...@google.com wrote: Hi Scott, I'd like to you do a code review. To apply this patch, navigate to the the root of the GWT 1.6 releases branch

[gwt-contrib] Re: Updated WAR design for GWT 1.6

2008-11-03 Thread Rajeev Dayal
Hey all, Sorry to derail from the security question that is being debated, but I wanted to mention some of my observations as I've been playing around with the DynaTable2 sample. If the -out directory is unspecified, the application fails to launch. I think this is probably because it is looking

[gwt-contrib] Re: RR : Change Safari XML parse error detection

2008-10-15 Thread Rajeev Dayal
LGTM. If your document legitimately has a parsererror tag contained by a body tag, you're really having a bad day. On Wed, Oct 15, 2008 at 6:49 PM, Bob Vawter [EMAIL PROTECTED] wrote: Here's a version that should allow a tag named parseerror, as long as it's not contained by a body tag. --

[gwt-contrib] Re: [gwt-team] Release Notes for review

2008-10-14 Thread Rajeev Dayal
HTTPRequests no long POST instead of GET in some IE installs because of incorrect XHR selection should be HTTPRequests no longer POST instead of GET in some IE installs because of incorrect XHR selection On Tue, Oct 14, 2008 at 4:20 PM, John LaBanca [EMAIL PROTECTED] wrote: Alright, please

[gwt-contrib] Re: RR: make PopupPanels stay on the screen, even in RTL situations

2008-10-07 Thread Rajeev Dayal
, Alex Rudnick [EMAIL PROTECTED] wrote: Hey Rajeev :) Thanks for the quick review! Responses inline. On Mon, Oct 6, 2008 at 7:08 PM, Rajeev Dayal [EMAIL PROTECTED] wrote: DialogBox.java 199: Spelling: sceen -- screen OK 243: @Overrides on an a method that implements

[gwt-contrib] Re: RR: make PopupPanels stay on the screen, even in RTL situations

2008-10-06 Thread Rajeev Dayal
Hey Alex, Thanks for putting this fix together. Comments below: DialogBox.java 199: Spelling: sceen -- screen 243: @Overrides on an a method that implements an interface only works in Java 1.6. While GWT on the the trunk currently support JDK 1.6, the code base still compiles under GWT 1.5. If

[gwt-contrib] Re: RR: timezone support and updates to DateTimeFormat

2008-09-16 Thread Rajeev Dayal
Hey Alex, Good job with this. Generally, looks good, with a bunch of nits (many related to doc). I've mentioned them on a per-file basis below. If you could take care of these nits (provided that you agree with them), go ahead and commit; there's no need to iterate again on this patch unless you

[gwt-contrib] Re: [google-web-toolkit commit] r3547 - in trunk: . dev/core dev/core/src/com/google/gwt/dev distro-source distro-source/core/src

2008-09-02 Thread Rajeev Dayal
I noticed the following issue (I did not review the entire patch): About.java, line 35: Need the static keyword here; this should be a static initializer, not an instance initializer. Rajeev On Wed, Aug 20, 2008 at 5:40 PM, Scott Blum [EMAIL PROTECTED] wrote: On Wed, Aug 20, 2008 at 5:03